[RFC 0/2] integrity: asynchronous hash support

2014-02-28 Thread Dmitry Kasatkin
simulteneously with hash calculation. - Dmitry Dmitry Kasatkin (2): ima: use ahash API for file hash calculation ima: provide double buffering for hash calculation security/integrity/ima/ima_crypto.c | 269 +++- 1 file changed, 266 insertions(+), 3 deletions

[PATCH 4/8] evm: EVM does not use MD5

2014-02-28 Thread Dmitry Kasatkin
Signed-off-by: Dmitry Kasatkin --- security/integrity/evm/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/security/integrity/evm/Kconfig b/security/integrity/evm/Kconfig index fea9749..5aa9103 100644 --- a/security/integrity/evm/Kconfig +++ b/security/integrity/evm/Kconfig @@ -2,7

[PATCH 1/8] ima: fix erronous removal of security.ima xattr

2014-02-28 Thread Dmitry Kasatkin
. 'security.ima' might be erronously removed. This patch treats POST_SETATTR as special wildcard function and will cause ima_must_appraise() to be true if any of the hooks rules matches. security.ima will not be removed if any of the hooks would require appraisal. Signed-off-by: Dmitry Kasatkin

[PATCH 2/8] integrity: fix checkpatch errors

2014-02-28 Thread Dmitry Kasatkin
Unfixed checkpatch errors make it difficult to see new errors.. This patch fix them. Some lines with over 80 chars remained unchanged to improve code readability. Signed-off-by: Dmitry Kasatkin --- security/integrity/evm/evm.h | 28 +++--- security/integrity/evm/evm_crypto.c

[PATCH 8/8] evm: introduce EVM hmac xattr list

2014-02-28 Thread Dmitry Kasatkin
list which is initialized from CONFIG_EVM_HMAC_XATTRS variable. It allows to build kernel with with support of older and newer EVM HMAC formats. Possible future extension will be to read xattr list from the kernel command line or from securityfs entry. Signed-off-by: Dmitry Kasatkin --- security

[PATCH 0/8] integrity: fixes and new features

2014-02-28 Thread Dmitry Kasatkin
Hi, This patchset contains bug fixes, cleanups and new features for integrity subsytem. - Dmitry Dmitry Kasatkin (8): ima: fix erronous removal of security.ima xattr integrity: fix checkpatch errors ima: return d_name.name if d_path fails evm: EVM does not use MD5 ima: skip memory

[PATCH 7/8] evm: introduce EVM hmac attribute list

2014-02-28 Thread Dmitry Kasatkin
This patch replaces using of hmac version configuration parameter with attribute list. It allows to build kernels which works with previously labeled filesystems. Currently supported attribute is 'fsuuid' which is equivalent of former version 2. Signed-off-by: Dmitry Kasatkin --- security

[PATCH 5/8] ima: skip memory allocation for empty files

2014-02-28 Thread Dmitry Kasatkin
Memory allocation is unnecessary for empty files. This patch finalize the hash without memory allocation. Signed-off-by: Dmitry Kasatkin --- security/integrity/ima/ima_crypto.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/security/integrity/ima

[PATCH 3/8] ima: return d_name.name if d_path fails

2014-02-28 Thread Dmitry Kasatkin
Signed-off-by: Dmitry Kasatkin --- security/integrity/ima/ima_api.c | 2 +- security/integrity/ima/ima_main.c | 7 +-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/security/integrity/ima/ima_api.c b/security/integrity/ima/ima_api.c index c6b4a73..ba9e4d7 100644

[PATCH 6/8] evm: enable key retention service automatically

2014-02-28 Thread Dmitry Kasatkin
If keys are not enabled, EVM is not visible in the configuration menu. It may be difficult to figure out what to do unless you really know. Other subsystems as NFS, CIFS select keys automatically. This patch does the same. Signed-off-by: Dmitry Kasatkin --- security/integrity/evm/Kconfig | 5

[PATCH 6/8] evm: enable key retention service automatically

2014-02-28 Thread Dmitry Kasatkin
If keys are not enabled, EVM is not visible in the configuration menu. It may be difficult to figure out what to do unless you really know. Other subsystems as NFS, CIFS select keys automatically. This patch does the same. Signed-off-by: Dmitry Kasatkin d.kasat...@samsung.com --- security

[PATCH 3/8] ima: return d_name.name if d_path fails

2014-02-28 Thread Dmitry Kasatkin
Signed-off-by: Dmitry Kasatkin d.kasat...@samsung.com --- security/integrity/ima/ima_api.c | 2 +- security/integrity/ima/ima_main.c | 7 +-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/security/integrity/ima/ima_api.c b/security/integrity/ima/ima_api.c index c6b4a73

[PATCH 5/8] ima: skip memory allocation for empty files

2014-02-28 Thread Dmitry Kasatkin
Memory allocation is unnecessary for empty files. This patch finalize the hash without memory allocation. Signed-off-by: Dmitry Kasatkin d.kasat...@samsung.com --- security/integrity/ima/ima_crypto.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git

[PATCH 8/8] evm: introduce EVM hmac xattr list

2014-02-28 Thread Dmitry Kasatkin
list which is initialized from CONFIG_EVM_HMAC_XATTRS variable. It allows to build kernel with with support of older and newer EVM HMAC formats. Possible future extension will be to read xattr list from the kernel command line or from securityfs entry. Signed-off-by: Dmitry Kasatkin d.kasat

[PATCH 0/8] integrity: fixes and new features

2014-02-28 Thread Dmitry Kasatkin
Hi, This patchset contains bug fixes, cleanups and new features for integrity subsytem. - Dmitry Dmitry Kasatkin (8): ima: fix erronous removal of security.ima xattr integrity: fix checkpatch errors ima: return d_name.name if d_path fails evm: EVM does not use MD5 ima: skip memory

[PATCH 7/8] evm: introduce EVM hmac attribute list

2014-02-28 Thread Dmitry Kasatkin
This patch replaces using of hmac version configuration parameter with attribute list. It allows to build kernels which works with previously labeled filesystems. Currently supported attribute is 'fsuuid' which is equivalent of former version 2. Signed-off-by: Dmitry Kasatkin d.kasat

[PATCH 4/8] evm: EVM does not use MD5

2014-02-28 Thread Dmitry Kasatkin
Signed-off-by: Dmitry Kasatkin d.kasat...@samsung.com --- security/integrity/evm/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/security/integrity/evm/Kconfig b/security/integrity/evm/Kconfig index fea9749..5aa9103 100644 --- a/security/integrity/evm/Kconfig +++ b/security/integrity

[PATCH 1/8] ima: fix erronous removal of security.ima xattr

2014-02-28 Thread Dmitry Kasatkin
. 'security.ima' might be erronously removed. This patch treats POST_SETATTR as special wildcard function and will cause ima_must_appraise() to be true if any of the hooks rules matches. security.ima will not be removed if any of the hooks would require appraisal. Signed-off-by: Dmitry Kasatkin d.kasat

[PATCH 2/8] integrity: fix checkpatch errors

2014-02-28 Thread Dmitry Kasatkin
Unfixed checkpatch errors make it difficult to see new errors.. This patch fix them. Some lines with over 80 chars remained unchanged to improve code readability. Signed-off-by: Dmitry Kasatkin d.kasat...@samsung.com --- security/integrity/evm/evm.h | 28 +++--- security

[RFC 2/2] ima: provide double buffering for hash calculation

2014-02-28 Thread Dmitry Kasatkin
Asynchronous hash API allows initiate hash calculation and perform other tasks while hash is calculated. This patch introduces using of double buffering for simultenous hashing and reading of the next chunk of data from storage. Signed-off-by: Dmitry Kasatkin d.kasat...@samsung.com --- security

[RFC 0/2] integrity: asynchronous hash support

2014-02-28 Thread Dmitry Kasatkin
simulteneously with hash calculation. - Dmitry Dmitry Kasatkin (2): ima: use ahash API for file hash calculation ima: provide double buffering for hash calculation security/integrity/ima/ima_crypto.c | 269 +++- 1 file changed, 266 insertions(+), 3 deletions

[RFC 1/2] ima: use ahash API for file hash calculation

2014-02-28 Thread Dmitry Kasatkin
line. Signed-off-by: Dmitry Kasatkin d.kasat...@samsung.com --- security/integrity/ima/ima_crypto.c | 180 +++- 1 file changed, 176 insertions(+), 4 deletions(-) diff --git a/security/integrity/ima/ima_crypto.c b/security/integrity/ima/ima_crypto.c index 1bde8e6

Re: [PATCH 2/8] integrity: fix checkpatch errors

2014-02-28 Thread Dmitry Kasatkin
This patch is on the top of Joe Perches patch. - Dmitry On 28/02/14 16:59, Dmitry Kasatkin wrote: Unfixed checkpatch errors make it difficult to see new errors.. This patch fix them. Some lines with over 80 chars remained unchanged to improve code readability. Signed-off-by: Dmitry

Re: [PATCH 1/2] ima: hooks for directory integrity protection

2013-12-23 Thread Dmitry Kasatkin
Hi, On 12/12/13 15:39, Mimi Zohar wrote: > On Mon, 2013-11-18 at 22:24 +0200, Dmitry Kasatkin wrote: >> Both IMA-appraisal and EVM protect the integrity of regular files. >> IMA protects file data integrity, while EVM protects the file meta-data >> integrity, such as file at

Re: [PATCH 1/2] ima: hooks for directory integrity protection

2013-12-23 Thread Dmitry Kasatkin
Hi, On 12/12/13 15:39, Mimi Zohar wrote: On Mon, 2013-11-18 at 22:24 +0200, Dmitry Kasatkin wrote: Both IMA-appraisal and EVM protect the integrity of regular files. IMA protects file data integrity, while EVM protects the file meta-data integrity, such as file attributes and extended

Re: [PATCH 1/2] ima: hooks for directory integrity protection

2013-12-11 Thread Dmitry Kasatkin
On 18/11/13 20:24, Dmitry Kasatkin wrote: > Both IMA-appraisal and EVM protect the integrity of regular files. > IMA protects file data integrity, while EVM protects the file meta-data > integrity, such as file attributes and extended attributes. This patch > set adds hooks for offli

Re: [PATCH 1/2] ima: hooks for directory integrity protection

2013-12-11 Thread Dmitry Kasatkin
On 18/11/13 20:24, Dmitry Kasatkin wrote: Both IMA-appraisal and EVM protect the integrity of regular files. IMA protects file data integrity, while EVM protects the file meta-data integrity, such as file attributes and extended attributes. This patch set adds hooks for offline directory

[PATCH 1/2] ima: hooks for directory integrity protection

2013-11-18 Thread Dmitry Kasatkin
is changing, for updating the directory hash. Signed-off-by: Dmitry Kasatkin --- fs/namei.c| 42 --- fs/open.c | 6 ++ include/linux/ima.h | 23 + net/unix/af_unix.c

[PATCH 0/2] ima: directory integrity appraisal

2013-11-18 Thread Dmitry Kasatkin
with the cached verification status. So ima_dir_check() does not interrupt RCU path walk. ima_dir_update(), which is called from several places in namei.c when the directory content is changing, for updating the directory hash. - Dmitry Dmitry Kasatkin (2): ima: hooks for directory integrity protection

[PATCH 2/2] ima: directory integrity protection implementation

2013-11-18 Thread Dmitry Kasatkin
the directory hash. Signed-off-by: Dmitry Kasatkin --- security/integrity/ima/Kconfig | 10 + security/integrity/ima/Makefile | 1 + security/integrity/ima/ima.h| 3 +- security/integrity/ima/ima_dir.c| 358 security/integrity/ima

Re: [PATCH 5/6] ima: do not include field length in template digest calc for ima template

2013-11-18 Thread Dmitry Kasatkin
On Fri, Nov 15, 2013 at 3:45 PM, Roberto Sassu wrote: > To maintain compatibility with userspace tools, the field length must not > be included in the template digest calculation for the 'ima' template. > > Signed-off-by: Roberto Sassu > Signed-off-by: Mimi Zohar > --- >

Re: [PATCH 5/6] ima: do not include field length in template digest calc for ima template

2013-11-18 Thread Dmitry Kasatkin
On Fri, Nov 15, 2013 at 3:45 PM, Roberto Sassu roberto.sa...@polito.it wrote: To maintain compatibility with userspace tools, the field length must not be included in the template digest calculation for the 'ima' template. Signed-off-by: Roberto Sassu roberto.sa...@polito.it Signed-off-by:

[PATCH 0/2] ima: directory integrity appraisal

2013-11-18 Thread Dmitry Kasatkin
with the cached verification status. So ima_dir_check() does not interrupt RCU path walk. ima_dir_update(), which is called from several places in namei.c when the directory content is changing, for updating the directory hash. - Dmitry Dmitry Kasatkin (2): ima: hooks for directory integrity protection

[PATCH 2/2] ima: directory integrity protection implementation

2013-11-18 Thread Dmitry Kasatkin
the directory hash. Signed-off-by: Dmitry Kasatkin d.kasat...@samsung.com --- security/integrity/ima/Kconfig | 10 + security/integrity/ima/Makefile | 1 + security/integrity/ima/ima.h| 3 +- security/integrity/ima/ima_dir.c| 358 security

[PATCH 1/2] ima: hooks for directory integrity protection

2013-11-18 Thread Dmitry Kasatkin
is changing, for updating the directory hash. Signed-off-by: Dmitry Kasatkin d.kasat...@samsung.com --- fs/namei.c| 42 --- fs/open.c | 6 ++ include/linux/ima.h | 23 + net/unix

Re: [PATCH linux-next] security/integrity: Fix build error and warnings when CONFIG_INTEGRITY_ASYMMETRIC_KEYS is disabled

2013-11-10 Thread Dmitry Kasatkin
Hello Shuah, Thanks for the patch. If I am correct, Mimi has fixed already this error just recently. But it did not get into James' tree yet... http://git.kernel.org/cgit/linux/kernel/git/zohar/linux-integrity.git/commit/?h=next-fixes=f60bfa151cbe2e2eb6d5eaf84a3421405e7f282a - Dmitry On Fri,

Re: [PATCH linux-next] security/integrity: Fix build error and warnings when CONFIG_INTEGRITY_ASYMMETRIC_KEYS is disabled

2013-11-10 Thread Dmitry Kasatkin
Hello Shuah, Thanks for the patch. If I am correct, Mimi has fixed already this error just recently. But it did not get into James' tree yet... http://git.kernel.org/cgit/linux/kernel/git/zohar/linux-integrity.git/commit/?h=next-fixesid=f60bfa151cbe2e2eb6d5eaf84a3421405e7f282a - Dmitry On

Re: [RFC][PATCH 0/9] encrypted keys & key control op

2013-11-06 Thread Dmitry Kasatkin
Hello David, I will be looking to patches today... - Dmitry On 04/11/13 18:22, David Howells wrote: > Hi Mimi, Dmitry, > > Here's a series of patches, the last three of which attempt to fix up a > problem with encrypted keys update method. The preceding patches are fixes or > are preparatory

Re: [RFC][PATCH 0/9] encrypted keys key control op

2013-11-06 Thread Dmitry Kasatkin
Hello David, I will be looking to patches today... - Dmitry On 04/11/13 18:22, David Howells wrote: Hi Mimi, Dmitry, Here's a series of patches, the last three of which attempt to fix up a problem with encrypted keys update method. The preceding patches are fixes or are preparatory for

[PATCH 1/1] KEYS: store keys in the dedicated directory

2013-10-31 Thread Dmitry Kasatkin
Recent patch "KEYS: Load *.x509 files into kernel keyring" allows to bultin multiple X509 certificates. It is easier to manage keys and certificates when they are stored in the dedicated directory. This patch proposes to store keys in the 'keys' directory. Signed-off-by: Dmitr

Re: [PATCH] ima: define '_ima' as a builtin 'trusted' keyring

2013-10-31 Thread Dmitry Kasatkin
On 31/10/13 14:43, Mimi Zohar wrote: > On Thu, 2013-10-31 at 14:23 +0200, Dmitry Kasatkin wrote: >> On 31/10/13 14:03, Mimi Zohar wrote: >>> On Thu, 2013-10-31 at 10:30 +0200, Dmitry Kasatkin wrote: >>>> On 30/10/13 20:54, Mimi Zohar wrote: >>>>> Requir

Re: [PATCH] ima: define '_ima' as a builtin 'trusted' keyring

2013-10-31 Thread Dmitry Kasatkin
On 31/10/13 14:03, Mimi Zohar wrote: > On Thu, 2013-10-31 at 10:30 +0200, Dmitry Kasatkin wrote: >> On 30/10/13 20:54, Mimi Zohar wrote: >>> Require all keys added to the IMA keyring be signed by an >>> existing trusted key on the system trusted keyring. >>&

Re: [PATCH] ima: define '_ima' as a builtin 'trusted' keyring

2013-10-31 Thread Dmitry Kasatkin
On 30/10/13 20:54, Mimi Zohar wrote: > Require all keys added to the IMA keyring be signed by an > existing trusted key on the system trusted keyring. > > Changelog: > - define stub integrity_init_keyring() function (reported-by Fengguang Wu) > - differentiate between regular and trusted keyring

Re: [PATCH] ima: define '_ima' as a builtin 'trusted' keyring

2013-10-31 Thread Dmitry Kasatkin
On 30/10/13 20:54, Mimi Zohar wrote: Require all keys added to the IMA keyring be signed by an existing trusted key on the system trusted keyring. Changelog: - define stub integrity_init_keyring() function (reported-by Fengguang Wu) - differentiate between regular and trusted keyring names.

Re: [PATCH] ima: define '_ima' as a builtin 'trusted' keyring

2013-10-31 Thread Dmitry Kasatkin
On 31/10/13 14:03, Mimi Zohar wrote: On Thu, 2013-10-31 at 10:30 +0200, Dmitry Kasatkin wrote: On 30/10/13 20:54, Mimi Zohar wrote: Require all keys added to the IMA keyring be signed by an existing trusted key on the system trusted keyring. Changelog: - define stub integrity_init_keyring

Re: [PATCH] ima: define '_ima' as a builtin 'trusted' keyring

2013-10-31 Thread Dmitry Kasatkin
On 31/10/13 14:43, Mimi Zohar wrote: On Thu, 2013-10-31 at 14:23 +0200, Dmitry Kasatkin wrote: On 31/10/13 14:03, Mimi Zohar wrote: On Thu, 2013-10-31 at 10:30 +0200, Dmitry Kasatkin wrote: On 30/10/13 20:54, Mimi Zohar wrote: Require all keys added to the IMA keyring be signed

[PATCH 1/1] KEYS: store keys in the dedicated directory

2013-10-31 Thread Dmitry Kasatkin
Recent patch KEYS: Load *.x509 files into kernel keyring allows to bultin multiple X509 certificates. It is easier to manage keys and certificates when they are stored in the dedicated directory. This patch proposes to store keys in the 'keys' directory. Signed-off-by: Dmitry Kasatkin d.kasat

Re: linux-next: manual merge of the security tree with the tree

2013-10-29 Thread Dmitry Kasatkin
On 28/10/13 09:47, Stephen Rothwell wrote: > Hi James, > > Today's linux-next merge of the security tree got a conflict in > crypto/Makefile between commit a62b01cd6cc1 ("crypto: create generic > version of ablk_helper") from the crypto tree and commit ee08997fee16 > ("crypto: provide single place

Re: linux-next: manual merge of the security tree with the tree

2013-10-29 Thread Dmitry Kasatkin
On 28/10/13 09:47, Stephen Rothwell wrote: Hi James, Today's linux-next merge of the security tree got a conflict in crypto/Makefile between commit a62b01cd6cc1 (crypto: create generic version of ablk_helper) from the crypto tree and commit ee08997fee16 (crypto: provide single place for hash

Re: [PATCH v2 01/23] crypto: provide single place for hash algo information

2013-10-22 Thread Dmitry Kasatkin
On Tue, Oct 22, 2013 at 12:32 PM, Herbert Xu wrote: > On Tue, Oct 22, 2013 at 12:29:56PM +0100, Dmitry Kasatkin wrote: >> >> We are not adding user-space interface. >> We just need to algo definitions which are in sync between user space, >> IMA/EVM and kernel module

Re: [PATCH v2 01/23] crypto: provide single place for hash algo information

2013-10-22 Thread Dmitry Kasatkin
On Tue, Oct 22, 2013 at 6:24 AM, Herbert Xu wrote: > On Mon, Oct 21, 2013 at 06:42:46PM -0400, Mimi Zohar wrote: >> From: Dmitry Kasatkin >> >> This patch provides a single place for information about hash algorithms, >> such as hash sizes and kernel driver names

Re: [PATCH v2 01/23] crypto: provide single place for hash algo information

2013-10-22 Thread Dmitry Kasatkin
On Tue, Oct 22, 2013 at 6:24 AM, Herbert Xu herb...@gondor.apana.org.au wrote: On Mon, Oct 21, 2013 at 06:42:46PM -0400, Mimi Zohar wrote: From: Dmitry Kasatkin d.kasat...@samsung.com This patch provides a single place for information about hash algorithms, such as hash sizes and kernel

Re: [PATCH v2 01/23] crypto: provide single place for hash algo information

2013-10-22 Thread Dmitry Kasatkin
On Tue, Oct 22, 2013 at 12:32 PM, Herbert Xu herb...@gondor.apana.org.au wrote: On Tue, Oct 22, 2013 at 12:29:56PM +0100, Dmitry Kasatkin wrote: We are not adding user-space interface. We just need to algo definitions which are in sync between user space, IMA/EVM and kernel module signing

Re: [PATCH V4 02/15] asymmetric keys: implement EMSA_PKCS1-v1_5-ENCODE in rsa

2013-09-17 Thread Dmitry Kasatkin
On Sat, Sep 14, 2013 at 7:56 PM, Lee, Chun-Yi wrote: > Implement EMSA_PKCS1-v1_5-ENCODE [RFC3447 sec 9.2] in rsa.c. It's the > first step of signature generation operation (RSASSA-PKCS1-v1_5-SIGN). > > This patch is temporary set emLen to pks->k, and temporary set EM to > pks->S for debugging. We

Re: [PATCH V4 02/15] asymmetric keys: implement EMSA_PKCS1-v1_5-ENCODE in rsa

2013-09-17 Thread Dmitry Kasatkin
Hello, On Sat, Sep 14, 2013 at 7:56 PM, Lee, Chun-Yi wrote: > Implement EMSA_PKCS1-v1_5-ENCODE [RFC3447 sec 9.2] in rsa.c. It's the > first step of signature generation operation (RSASSA-PKCS1-v1_5-SIGN). > > This patch is temporary set emLen to pks->k, and temporary set EM to > pks->S for

Re: [PATCH V4 02/15] asymmetric keys: implement EMSA_PKCS1-v1_5-ENCODE in rsa

2013-09-17 Thread Dmitry Kasatkin
Hello, On Sat, Sep 14, 2013 at 7:56 PM, Lee, Chun-Yi joeyli.ker...@gmail.com wrote: Implement EMSA_PKCS1-v1_5-ENCODE [RFC3447 sec 9.2] in rsa.c. It's the first step of signature generation operation (RSASSA-PKCS1-v1_5-SIGN). This patch is temporary set emLen to pks-k, and temporary set EM to

Re: [PATCH V4 02/15] asymmetric keys: implement EMSA_PKCS1-v1_5-ENCODE in rsa

2013-09-17 Thread Dmitry Kasatkin
On Sat, Sep 14, 2013 at 7:56 PM, Lee, Chun-Yi joeyli.ker...@gmail.com wrote: Implement EMSA_PKCS1-v1_5-ENCODE [RFC3447 sec 9.2] in rsa.c. It's the first step of signature generation operation (RSASSA-PKCS1-v1_5-SIGN). This patch is temporary set emLen to pks-k, and temporary set EM to pks-S

Re: [PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-28 Thread Dmitry Kasatkin
ot remove comment, because it is for explaining the macro line... Second warning is natural in this case because macro itself defines dev_dbg() functionality. Internally it must use something else than itself... - Dmitry > Sarah Sharp > > On Tue, Aug 27, 2013 at 05:47:34PM +0300, Dmitry Kasatkin

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Dmitry Kasatkin
On 28/08/13 19:59, Sarah Sharp wrote: > Please trim your replies. > > On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote: >>>>> That change seems to cause the problems: >>>>> >>>>> commit 0730d52a86919300a39a2be37f6c140997dfb82f

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Dmitry Kasatkin
On 28/08/13 13:46, Sedat Dilek wrote: > On Wed, Aug 28, 2013 at 12:43 PM, Dmitry Kasatkin > wrote: >> On 28/08/13 13:38, Sedat Dilek wrote: >>> On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek wrote: >>>> On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek >>>

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Dmitry Kasatkin
On 28/08/13 13:38, Sedat Dilek wrote: > On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek wrote: >> On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek wrote: >>> On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek wrote: Hi all, Changes since 20130827: The f2fs tree lost its build

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Dmitry Kasatkin
On 28/08/13 13:38, Sedat Dilek wrote: On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek sedat.di...@gmail.com wrote: On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek sedat.di...@gmail.com wrote: On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek sedat.di...@gmail.com wrote: Hi all, Changes since

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Dmitry Kasatkin
On 28/08/13 13:46, Sedat Dilek wrote: On Wed, Aug 28, 2013 at 12:43 PM, Dmitry Kasatkin d.kasat...@samsung.com wrote: On 28/08/13 13:38, Sedat Dilek wrote: On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek sedat.di...@gmail.com wrote: On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek sedat.di

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Dmitry Kasatkin
On 28/08/13 19:59, Sarah Sharp wrote: Please trim your replies. On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote: That change seems to cause the problems: commit 0730d52a86919300a39a2be37f6c140997dfb82f xhci:prevent callbacks suppressed when debug is not enabled - Sedat

Re: [PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-28 Thread Dmitry Kasatkin
is natural in this case because macro itself defines dev_dbg() functionality. Internally it must use something else than itself... - Dmitry Sarah Sharp On Tue, Aug 27, 2013 at 05:47:34PM +0300, Dmitry Kasatkin wrote: When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data structures even

Re: [PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-27 Thread Dmitry Kasatkin
On Tue, Aug 27, 2013 at 9:16 PM, Joe Perches wrote: > On Tue, 2013-08-27 at 13:32 -0400, Jason Baron wrote: >> On 08/27/2013 12:20 PM, Joe Perches wrote: >> > On Tue, 2013-08-27 at 17:47 +0300, Dmitry Kasatkin wrote: >> >> When DEBUG is defined, dev_dbg_ratel

Re: [PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled

2013-08-27 Thread Dmitry Kasatkin
On Tue, Aug 27, 2013 at 8:39 PM, Greg KH wrote: > On Tue, Aug 27, 2013 at 05:16:37PM +0300, Dmitry Kasatkin wrote: >> On 16/08/13 20:45, Greg KH wrote: >> > On Fri, Aug 16, 2013 at 08:38:12PM +0300, Dmitry Kasatkin wrote: >> >> On Fri, Aug 16, 2013 at 8:30

Re: [PATCHv2 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled

2013-08-27 Thread Dmitry Kasatkin
Used vim "=" as Sarah suggested. - Dmitry On Tue, Aug 27, 2013 at 5:47 PM, Dmitry Kasatkin wrote: > When debug is not enabled and dev_dbg() will expand to nothing, > log might be flooded with "callbacks suppressed". If it was not > done on purpose, better to use

[PATCHv2 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled

2013-08-27 Thread Dmitry Kasatkin
When debug is not enabled and dev_dbg() will expand to nothing, log might be flooded with "callbacks suppressed". If it was not done on purpose, better to use dev_dbg_ratelimited() instead. Signed-off-by: Dmitry Kasatkin --- drivers/usb/host/xhci-ring.c | 24 --

[PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-27 Thread Dmitry Kasatkin
]: *** [drivers/usb/host] Error 2 make: *** [drivers/usb/] Error 2 This patch separates definition for CONFIG_DYNAMIC_DEBUG and DEBUG cases. Signed-off-by: Dmitry Kasatkin --- include/linux/device.h | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/include/linux

Re: [PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled

2013-08-27 Thread Dmitry Kasatkin
On 16/08/13 20:45, Greg KH wrote: > On Fri, Aug 16, 2013 at 08:38:12PM +0300, Dmitry Kasatkin wrote: >> On Fri, Aug 16, 2013 at 8:30 PM, Sarah Sharp wrote: >>> On Fri, Aug 16, 2013 at 10:26:35AM -0700, Sarah Sharp wrote: >>>> On Thu, Aug 15, 2013 at 05:17:16PM -070

Re: [PATCH 2/2] xhci:prevent callbacks suppressed when debug is not enabled

2013-08-27 Thread Dmitry Kasatkin
On 16/08/13 20:45, Greg KH wrote: On Fri, Aug 16, 2013 at 08:38:12PM +0300, Dmitry Kasatkin wrote: On Fri, Aug 16, 2013 at 8:30 PM, Sarah Sharp sarah.a.sh...@intel.com wrote: On Fri, Aug 16, 2013 at 10:26:35AM -0700, Sarah Sharp wrote: On Thu, Aug 15, 2013 at 05:17:16PM -0700, Greg KH wrote

[PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-27 Thread Dmitry Kasatkin
]: *** [drivers/usb/host] Error 2 make: *** [drivers/usb/] Error 2 This patch separates definition for CONFIG_DYNAMIC_DEBUG and DEBUG cases. Signed-off-by: Dmitry Kasatkin d.kasat...@samsung.com --- include/linux/device.h | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff

[PATCHv2 2/2] xhci:prevent callbacks suppressed when debug is not enabled

2013-08-27 Thread Dmitry Kasatkin
When debug is not enabled and dev_dbg() will expand to nothing, log might be flooded with callbacks suppressed. If it was not done on purpose, better to use dev_dbg_ratelimited() instead. Signed-off-by: Dmitry Kasatkin d.kasat...@samsung.com --- drivers/usb/host/xhci-ring.c | 24

Re: [PATCHv2 2/2] xhci:prevent callbacks suppressed when debug is not enabled

2013-08-27 Thread Dmitry Kasatkin
Used vim = as Sarah suggested. - Dmitry On Tue, Aug 27, 2013 at 5:47 PM, Dmitry Kasatkin d.kasat...@samsung.com wrote: When debug is not enabled and dev_dbg() will expand to nothing, log might be flooded with callbacks suppressed. If it was not done on purpose, better to use

Re: [PATCH 2/2] xhci:prevent callbacks suppressed when debug is not enabled

2013-08-27 Thread Dmitry Kasatkin
On Tue, Aug 27, 2013 at 8:39 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Aug 27, 2013 at 05:16:37PM +0300, Dmitry Kasatkin wrote: On 16/08/13 20:45, Greg KH wrote: On Fri, Aug 16, 2013 at 08:38:12PM +0300, Dmitry Kasatkin wrote: On Fri, Aug 16, 2013 at 8:30 PM, Sarah Sharp

Re: [PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-27 Thread Dmitry Kasatkin
On Tue, Aug 27, 2013 at 9:16 PM, Joe Perches j...@perches.com wrote: On Tue, 2013-08-27 at 13:32 -0400, Jason Baron wrote: On 08/27/2013 12:20 PM, Joe Perches wrote: On Tue, 2013-08-27 at 17:47 +0300, Dmitry Kasatkin wrote: When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data

Re: [PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled

2013-08-16 Thread Dmitry Kasatkin
13 at 07:04:55PM +0300, Dmitry Kasatkin wrote: >> > > > When debug is not enabled and dev_dbg() will expand to nothing, >> > > > log might be flooded with "callbacks suppressed". If it was not >> > > > done on purpose, better t

Re: [PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled

2013-08-16 Thread Dmitry Kasatkin
On Fri, Aug 16, 2013 at 8:30 PM, Sarah Sharp wrote: > On Fri, Aug 16, 2013 at 10:26:35AM -0700, Sarah Sharp wrote: >> On Thu, Aug 15, 2013 at 05:17:16PM -0700, Greg KH wrote: >> > On Thu, Aug 15, 2013 at 07:04:55PM +0300, Dmitry Kasatkin wrote: >> > > When de

Re: [PATCH 2/2] xhci:prevent callbacks suppressed when debug is not enabled

2013-08-16 Thread Dmitry Kasatkin
On Fri, Aug 16, 2013 at 8:30 PM, Sarah Sharp sarah.a.sh...@intel.com wrote: On Fri, Aug 16, 2013 at 10:26:35AM -0700, Sarah Sharp wrote: On Thu, Aug 15, 2013 at 05:17:16PM -0700, Greg KH wrote: On Thu, Aug 15, 2013 at 07:04:55PM +0300, Dmitry Kasatkin wrote: When debug is not enabled

Re: [PATCH 2/2] xhci:prevent callbacks suppressed when debug is not enabled

2013-08-16 Thread Dmitry Kasatkin
+0300, Dmitry Kasatkin wrote: When debug is not enabled and dev_dbg() will expand to nothing, log might be flooded with callbacks suppressed. If it was not done on purpose, better to use dev_dbg_ratelimited() instead. Signed-off-by: Dmitry Kasatkin d.kasat...@samsung.com

Re: [PATCH 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-15 Thread Dmitry Kasatkin
On 15/08/13 19:37, Greg KH wrote: > On Thu, Aug 15, 2013 at 07:04:54PM +0300, Dmitry Kasatkin wrote: >> When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data >> structures even when CONFIG_DYNAMIC_DEBUG is not defined. >> It leads to build break. >> For

[PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled

2013-08-15 Thread Dmitry Kasatkin
When debug is not enabled and dev_dbg() will expand to nothing, log might be flooded with "callbacks suppressed". If it was not done on purpose, better to use dev_dbg_ratelimited() instead. Signed-off-by: Dmitry Kasatkin --- drivers/usb/host/xhci-ring.c | 6 ++ 1 file changed, 2

[PATCH 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-15 Thread Dmitry Kasatkin
]: *** [drivers/usb/host] Error 2 make: *** [drivers/usb/] Error 2 This patch separates definition for CONFIG_DYNAMIC_DEBUG and DEBUG cases. Signed-off-by: Dmitry Kasatkin Cc: sta...@vger.kernel.org --- include/linux/device.h | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions

Re: [PATCH 02/10] crypto: omap-aes: Add useful debug macros

2013-08-15 Thread Dmitry Kasatkin
On 15/08/13 06:12, Joel Fernandes wrote: > On 08/14/2013 07:47 PM, Joe Perches wrote: >> On Wed, 2013-08-14 at 18:40 -0500, Joel Fernandes wrote: >>> On 08/14/2013 06:29 PM, Joe Perches wrote: On Wed, 2013-08-14 at 18:12 -0500, Joel Fernandes wrote: > When DEBUG is enabled, these macros

Re: [PATCH 02/10] crypto: omap-aes: Add useful debug macros

2013-08-15 Thread Dmitry Kasatkin
On 15/08/13 06:12, Joel Fernandes wrote: On 08/14/2013 07:47 PM, Joe Perches wrote: On Wed, 2013-08-14 at 18:40 -0500, Joel Fernandes wrote: On 08/14/2013 06:29 PM, Joe Perches wrote: On Wed, 2013-08-14 at 18:12 -0500, Joel Fernandes wrote: When DEBUG is enabled, these macros can be used to

[PATCH 2/2] xhci:prevent callbacks suppressed when debug is not enabled

2013-08-15 Thread Dmitry Kasatkin
When debug is not enabled and dev_dbg() will expand to nothing, log might be flooded with callbacks suppressed. If it was not done on purpose, better to use dev_dbg_ratelimited() instead. Signed-off-by: Dmitry Kasatkin d.kasat...@samsung.com --- drivers/usb/host/xhci-ring.c | 6 ++ 1 file

[PATCH 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-15 Thread Dmitry Kasatkin
]: *** [drivers/usb/host] Error 2 make: *** [drivers/usb/] Error 2 This patch separates definition for CONFIG_DYNAMIC_DEBUG and DEBUG cases. Signed-off-by: Dmitry Kasatkin d.kasat...@samsung.com Cc: sta...@vger.kernel.org --- include/linux/device.h | 17 ++--- 1 file changed, 14

Re: [PATCH 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-15 Thread Dmitry Kasatkin
On 15/08/13 19:37, Greg KH wrote: On Thu, Aug 15, 2013 at 07:04:54PM +0300, Dmitry Kasatkin wrote: When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data structures even when CONFIG_DYNAMIC_DEBUG is not defined. It leads to build break. For example, when I try to use

Re: [PATCH 00/10] crypto: omap-aes: DMA and PIO mode improvements

2013-08-14 Thread Dmitry Kasatkin
On 15/08/13 02:30, Joel Fernandes wrote: > On 08/14/2013 06:12 PM, Joel Fernandes wrote: >> This patch series is a rewrite of the DMA portion of omap-aes driver >> and also adds support for PIO mode. Both these modes, give better >> performance than before. >> >> Earlier, only a single SG was used

Re: [PATCH 00/10] crypto: omap-aes: DMA and PIO mode improvements

2013-08-14 Thread Dmitry Kasatkin
On 15/08/13 02:30, Joel Fernandes wrote: On 08/14/2013 06:12 PM, Joel Fernandes wrote: This patch series is a rewrite of the DMA portion of omap-aes driver and also adds support for PIO mode. Both these modes, give better performance than before. Earlier, only a single SG was used for DMA

Re: [PATCH] MPILIB: disable usage of floating point registers on parisc

2013-05-31 Thread Dmitry Kasatkin
Sorry. I am not at @intel.com any more. Did not see it. Will handle. - Dmitry On Mon, May 6, 2013 at 1:08 AM, Helge Deller wrote: > The umul_ppmm() macro for parisc uses the xmpyu assembler statement > which does calculation via a floating point register. > > But usage of floating point

Re: [PATCH] lib: digsig: Use ERR_CAST function

2013-05-31 Thread Dmitry Kasatkin
Sorry. I am not at @intel.com any more. Did not see it. I will use my private email for now.. Yes. This was bothering my eye for quite a while... - Dmitry On Fri, Apr 12, 2013 at 4:12 AM, Alexandru Gheorghiu wrote: > > Use ERR_CAST function instead of ERR_PTR and PTR_ERR. > Patch found using

Re: [PATCH] lib: digsig: Use ERR_CAST function

2013-05-31 Thread Dmitry Kasatkin
Sorry. I am not at @intel.com any more. Did not see it. I will use my private email for now.. Yes. This was bothering my eye for quite a while... - Dmitry On Fri, Apr 12, 2013 at 4:12 AM, Alexandru Gheorghiu gheorghiuan...@gmail.com wrote: Use ERR_CAST function instead of ERR_PTR and PTR_ERR.

Re: [PATCH] MPILIB: disable usage of floating point registers on parisc

2013-05-31 Thread Dmitry Kasatkin
Sorry. I am not at @intel.com any more. Did not see it. Will handle. - Dmitry On Mon, May 6, 2013 at 1:08 AM, Helge Deller del...@gmx.de wrote: The umul_ppmm() macro for parisc uses the xmpyu assembler statement which does calculation via a floating point register. But usage of floating

Re: [RFC 2/2] initramfs with digital signature protection

2013-04-11 Thread Dmitry Kasatkin
On Thu, Apr 11, 2013 at 5:55 PM, Vivek Goyal wrote: > On Thu, Apr 11, 2013 at 11:06:55AM +0300, Dmitry Kasatkin wrote: >> Hello, >> >> I respond to the original question of this thread. >> signed initramfs allows not only to add keys to the keyrings but perform >&g

Re: [RFC 2/2] initramfs with digital signature protection

2013-04-11 Thread Dmitry Kasatkin
Hello, (in plain text) I respond to the original question of this thread. signed initramfs allows not only to add keys to the keyrings but perform other initialization, which requires user-space. Keys can be embedded into the kernel. This is fine. Regards - Dmitry On Thu, Apr 11, 2013 at

Re: [RFC 2/2] initramfs with digital signature protection

2013-04-11 Thread Dmitry Kasatkin
Hello, (in plain text) I respond to the original question of this thread. signed initramfs allows not only to add keys to the keyrings but perform other initialization, which requires user-space. Keys can be embedded into the kernel. This is fine. Regards - Dmitry On Thu, Apr 11, 2013 at

Re: [RFC 2/2] initramfs with digital signature protection

2013-04-11 Thread Dmitry Kasatkin
On Thu, Apr 11, 2013 at 5:55 PM, Vivek Goyal vgo...@redhat.com wrote: On Thu, Apr 11, 2013 at 11:06:55AM +0300, Dmitry Kasatkin wrote: Hello, I respond to the original question of this thread. signed initramfs allows not only to add keys to the keyrings but perform other initialization

[RFC 1/1] xattr: provide integrity. namespace to read real values

2013-02-13 Thread Dmitry Kasatkin
ing LSM and read real extended attribute values. getfattr -e text -n integrity.SMACK64 foo # file: foo integrity.SMACK64="hello world" Suggested-by: Casey Schaufler Signed-off-by: Dmitry Kasatkin --- fs/xattr.c | 22 +++--- include/uapi/linux/x

<    2   3   4   5   6   7   8   >