Re: [PATCH v2 18/29] scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'tinfo'

2020-07-14 Thread Doug Ledford
t; drivers/scsi/aic7xxx/aic7xxx_osm.c:567:30: warning: variable ‘tinfo’ > set but not used [-Wunused-but-set-variable] > 567 | struct ahc_initiator_tinfo *tinfo; > | ^ > > Cc: Hannes Reinecke > Cc: "Daniel M. Eischen" > Cc: Doug Ledford FWIW, I can't seem

Re: [PATCH] RDMA/hns: Fix build error again

2019-10-22 Thread Doug Ledford
On Mon, 2019-10-21 at 23:51 +0200, Arnd Bergmann wrote: > On Mon, Oct 21, 2019 at 11:09 PM Doug Ledford > wrote: > > This fix looks reasonable, but since I can't test this at all, and > > I'm > > personally tired of trying and failing to fix this issue, I need to > &g

Re: [PATCH] RDMA/hns: Fix build error again

2019-10-21 Thread Doug Ledford
quot;RDMA/hns: Split hw v1 driver from hns roce > driver") > Signed-off-by: Arnd Bergmann This fix looks reasonable, but since I can't test this at all, and I'm personally tired of trying and failing to fix this issue, I need to ask if you've tried all the permutations for this just

Re: linux-next: Fixes tag needs some work in the rdma-fixes tree

2019-10-21 Thread Doug Ledford
otnuri to fix his stuff. As for the rdma tree, the 10 digit hash is still unique as of today, so I won't rebase the official branch to fix this. However, I'll see about adding a check for this in my workflow. Thanks. -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint

Re: [GIT PULL] Thermal management updates for v5.4-rc1

2019-09-27 Thread Doug Ledford
On Fri, 2019-09-27 at 21:52 +0200, Richard Weinberger wrote: > On Fri, Sep 27, 2019 at 9:30 PM Doug Ledford > wrote: > > Because there are literally thousands of developers working on > > kernel > > bits here and there, and you're swatting this particular fly one > &g

Re: [GIT PULL] Thermal management updates for v5.4-rc1

2019-09-27 Thread Doug Ledford
On Fri, 2019-09-27 at 12:41 -0700, Linus Torvalds wrote: > On Fri, Sep 27, 2019 at 12:29 PM Doug Ledford > wrote: > > Because there are literally thousands of developers working on > > kernel > > bits here and there, and you're swatting this particular fly one > >

Re: [GIT PULL] Thermal management updates for v5.4-rc1

2019-09-27 Thread Doug Ledford
llionth time, and that takes longer and is more aggravating than the > conflict would have taken to just sort out. > >Linus -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

[PULL REQUEST] Please pull rdma.git

2019-08-30 Thread Doug Ledford
to 531a64e4c35bb9844b0cf813a6c9a87e00be05ff: RDMA/siw: Fix IPv6 addr_list locking (2019-08-28 10:29:19 -0400) Pull request for 5.3-rc6 - Fix locking on list traversal (siw) Signed-off-by: Doug Ledford

Re: [PULL REQUEST] Please pull rdma.git

2019-08-23 Thread Doug Ledford
Hi Linus, I didn't notice I was on my personal email identity when I sent the pull request. Sorry about that. It's really me ;-) On Fri, 2019-08-23 at 14:48 -0400, Doug Ledford wrote: > Hi Linus, > > No beating around the bush: this is a monster pull request for an -rc5 > kernel

Re: [PATCH] infiniband: hfi1: fix memory leaks

2019-08-20 Thread Doug Ledford
> to free 'data' before returning the error. > > Signed-off-by: Wenwen Wang Applied to for-rc, thanks. -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH] infiniband: hfi1: fix a memory leak bug

2019-08-20 Thread Doug Ledford
d-off-by: Wenwen Wang Applied to for-rc, thanks. -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH] IB/mlx4: Fix memory leaks

2019-08-20 Thread Doug Ledford
; 'tun_qp->tx_ring' whenever an error occurs. > > Signed-off-by: Wenwen Wang > --- Thanks, applied to for-rc. -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH] RDMA/hns: Fix some white space check_mtu_validate()

2019-08-20 Thread Doug Ledford
On Fri, 2019-08-16 at 14:39 +0300, Dan Carpenter wrote: > This line was indented a bit too far. > > Signed-off-by: Dan Carpenter Thanks, applied to for-next. -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD sign

[PULL REQUEST] Please pull rdma.git

2019-08-14 Thread Doug Ledford
ror code on error (core) - Allow siw to be built on 32bit arches (siw, ABI change, but OK since siw was just merged this merge window and there is no prior released kernel to maintain compatibility with and we also updated the rdma-core user space package to match) Signed-off-by: Doug Ledf

Re: [PATCH] RDMA/hns: remove obsolete Kconfig comment

2019-08-07 Thread Doug Ledford
On Wed, 2019-08-07 at 11:22 +0800, YueHaibing wrote: > Since commit a07fc0bb483e ("RDMA/hns: Fix build error") > these kconfig comment is obsolete, so just remove it. > > Signed-off-by: YueHaibing Thanks, applied to for-next. -- Doug Ledford GPG KeyID: B826A3330E

Re: [PATCH V2] mlx5: Fix formats with line continuation whitespace

2019-08-02 Thread Doug Ledford
On Fri, 2019-08-02 at 18:32 +, Saeed Mahameed wrote: > On Fri, 2019-08-02 at 11:09 -0700, Joe Perches wrote: > > On Tue, 2018-11-06 at 16:34 -0500, Doug Ledford wrote: > > > On Thu, 2018-11-01 at 09:34 +0200, Leon Romanovsky wrote: > > > > On Thu, Nov 01, 2018 at

[PULL REQUEST] Please pull rdma.git

2019-08-02 Thread Doug Ledford
+- drivers/infiniband/hw/mlx5/mr.c| 27 +++- drivers/infiniband/hw/qedr/main.c | 10 ++- drivers/infiniband/sw/siw/siw_qp.c | 6 +- include/rdma/ib_verbs.h| 4 +- 13 files changed, 124 insertions(+), 83 deletions(-) -- Doug Ledford GPG KeyID

Re: [PATCH] IB/hfi1: Fix Spectre v1 vulnerability

2019-08-01 Thread Doug Ledford
l.org > Signed-off-by: Gustavo A. R. Silva > --- Thanks, applied to for-rc. -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH -next] RDMA/hns: remove set but not used variable 'irq_num'

2019-08-01 Thread Doug Ledford
gt; > Reported-by: Hulk Robot > > Signed-off-by: YueHaibing > > --- > > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > I'm hitting this error too. > > Thanks, > Reviewed-by: Leon Romanovsky Applied to fo

Re: [PATCH V2] IB/core: Add mitigation for Spectre V1

2019-07-31 Thread Doug Ledford
On Wed, 2019-07-31 at 14:52 -0400, Doug Ledford wrote: > On Wed, 2019-07-31 at 12:52 -0500, Gustavo A. R. Silva wrote: > > This is insufficient. The speculation windows are large: > > > > "Speculative execution on modern CPUs can run several > > h

Re: [PATCH V2] IB/core: Add mitigation for Spectre V1

2019-07-31 Thread Doug Ledford
df Thanks, I'll take a look at that. That issue aside, returning without wasting time on two mutexes is still better IMO, so I like my patch more than the proposed one. Tony, would you like to resubmit? -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 26

Re: [PATCH][next] RDMA/core: fix spelling mistake "Nelink" -> "Netlink"

2019-07-31 Thread Doug Ledford
; > --- > > drivers/infiniband/core/netlink.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Thanks, > Reviewed-by: Leon Romanovsky Thanks, applied to for-next. -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 12

Re: [PATCH v6 20/57] infiniband: Remove dev_err() usage after platform_get_irq()

2019-07-31 Thread Doug Ledford
... } > ... > -dev_err(...); > ) > ... > } > // > > While we're here, remove braces on if statements that only have one > statement (manually). > > Cc: Doug Ledford > Cc: Jason Gunthorpe > Cc: linux-r...@vger.kernel.org > Cc: Greg Kroah-Hartman >

Re: [PATCH V2] IB/core: Add mitigation for Spectre V1

2019-07-31 Thread Doug Ledford
return -EINVAL; mutex_lock(>port->file_mutex); mutex_lock(>mutex); - if (id >= IB_UMAD_MAX_AGENTS || !__get_agent(file, id)) { + /* +* Is our check of id far enough away, code wise, to prevent +* speculative prefetch? +*/ + id = arra

Re: [PATCH] rdma: siw: remove unused variable

2019-07-29 Thread Doug Ledford
On Mon, 2019-07-29 at 16:03 -0300, Jason Gunthorpe wrote: > On Mon, Jul 29, 2019 at 02:19:35PM -0400, Doug Ledford wrote: > > On Fri, 2019-07-26 at 11:25 +0200, Anders Roxell wrote: > > > The variable 'p' si no longer used and the compiler rightly > > > complains >

Re: [PATCH] rdma: siw: remove unused variable

2019-07-29 Thread Doug Ledford
it subject does not exist in Linus' tree as of today. What tree is this being merged through, and is it slated to merge soon or is this a for-next item? -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH] infiniband: hw: cxgb3: Fix a possible null-pointer dereference in connect_reply_upcall()

2019-07-29 Thread Doug Ledford
ep->com.cm_id->rem_ref(ep->com.cm_id); > + if (ep->com.cm_id) > + ep->com.cm_id->rem_ref(ep->com.cm_id); > ep->com.cm_id = NULL; > ep->com.qp = NULL; > } -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH] RDMA/hns: Fix build error

2019-07-29 Thread Doug Ledford
lize the PCI device for hip08 > > RoCE") > > Fixes: 08805fdbeb2d ("RDMA/hns: Split hw v1 driver from hns roce > > driver") > > Signed-off-by: YueHaibing > > drivers/infiniband/hw/hns/Kconfig | 6 +++--- > > drivers/infiniband/hw/hns/Makefile | 8 ++

[PULL REQUEST] Please pull rdma.git

2019-06-21 Thread Doug Ledford
+ drivers/infiniband/hw/hfi1/verbs.h | 1 + drivers/infiniband/hw/hfi1/verbs_txreq.c | 2 +- drivers/infiniband/hw/hfi1/verbs_txreq.h | 3 +- 17 files changed, 174 insertions(+), 62 deletions(-) -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B

Re: linux-next: manual merge of the rdma tree with Linus' tree

2019-06-19 Thread Doug Ledford
On Thu, 2019-06-20 at 12:10 +1000, Stephen Rothwell wrote: > 2d3c72ed5041 ("rdma: Remove nes") Yeah, not much you can do about tree wide patchsets conflicting with a removal ;-) -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B

Re: linux-next: manual merge of the rdma tree with Linus' tree

2019-06-19 Thread Doug Ledford
fixed as far as linux-next is concerned, but any non trivial > conflicts should be mentioned to your upstream maintainer when your > tree > is submitted for merging. You may also want to consider cooperating > with the maintainer of the conflicting tree to minimise any > particularly

Re: [PATCH trivial] IB/hfi1: Spelling s/statisfied/satisfied/

2019-06-17 Thread Doug Ledford
PACE bit is set in qp->s_flags. Thanks, applied to for-next. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: RDMA: Clean destroy CQ in drivers do not return errors

2019-06-14 Thread Doug Ledford
model: Passing null pointer cq->umem to ib_umem_release, > which dereferences it" > > Is the logic inverted on that null check? > > Colin -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: linux-next: manual merge of the rdma tree with Linus' tree

2019-06-14 Thread Doug Ledford
minimise any > particularly > complex conflicts. > Thanks Stephen. There will be at least one more coming too. We've had a number of -rc patches and -next patches that touch the same area of code this cycle. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B

Re: [PATCH v2] RDMA/cma: Make CM response timeout and # CM retries configurable

2019-06-13 Thread Doug Ledford
On Thu, 2019-06-13 at 18:58 +0200, Håkon Bugge wrote: > > On 13 Jun 2019, at 16:25, Doug Ledford wrote: > > > > On Tue, 2019-02-26 at 08:57 +0100, Håkon Bugge wrote: > > > During certain workloads, the default CM response timeout is too > > > short, leadi

Re: [PATCH v2] RDMA/cma: Make CM response timeout and # CM retries configurable

2019-06-13 Thread Doug Ledford
On Thu, 2019-06-13 at 08:28 -0700, Bart Van Assche wrote: > On 6/13/19 7:25 AM, Doug Ledford wrote: > > So, to revive this patch, what I'd like to see is some attempt to > > actually quantify a reasonable timeout for the default backlog > > depth, > > then the p

Re: [PATCH v2] RDMA/cma: Make CM response timeout and # CM retries configurable

2019-06-13 Thread Doug Ledford
e timeout, and then put in the ability to adjust the timeout with some sort of doc guidance on how to calculate a reasonable timeout based on configured backlog depth. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signa

Re: linux-next: manual merge of the rdma-fixes tree with Linus' tree

2019-04-29 Thread Doug Ledford
icting tree to > minimise any particularly complex conflicts. > Sorry, I forgot to back that head commit out. Once Linus committed his fix the one in the rdma tree was superfluous (and wrong anyway). -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4

Re: [GIT PULL] Please pull rdma.git

2019-04-29 Thread Doug Ledford
On Mon, 2019-04-29 at 21:00 +0300, Leon Romanovsky wrote: > On Mon, Apr 29, 2019 at 01:13:01PM -0400, Doug Ledford wrote: > > On Mon, 2019-04-29 at 09:48 -0700, Linus Torvalds wrote: > > > On Mon, Apr 29, 2019 at 9:29 AM Doug Ledford wrote: > > > > drivers/inf

Re: [GIT PULL] Please pull rdma.git

2019-04-29 Thread Doug Ledford
On Mon, 2019-04-29 at 09:48 -0700, Linus Torvalds wrote: > On Mon, Apr 29, 2019 at 9:29 AM Doug Ledford wrote: > > > > drivers/infiniband/core/uverbs_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > This trivial one-liner is actually incorre

Re: [GIT PULL] Please pull RDMA subsystem changes

2019-04-29 Thread Doug Ledford
On Mon, 2019-04-29 at 11:42 -0400, Doug Ledford wrote: > On Mon, 2019-04-29 at 08:40 +, Jason Gunthorpe wrote: > > On Mon, Apr 29, 2019 at 08:09:47AM +0200, Heiko Carstens wrote: > > > On Sun, Apr 28, 2019 at 11:52:12AM +, Jason Gunthorpe wrote: > > > > Hi Li

[GIT PULL] Please pull rdma.git

2019-04-29 Thread Doug Ledford
insertion(+), 1 deletion(-) -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [GIT PULL] Please pull RDMA subsystem changes

2019-04-29 Thread Doug Ledford
get_page(vmf->page); > > return 0; > > } > > > > Thanks Heiko, this looks right to me. > > I'm surprised to be seeing this at this point, these patches should > have been seen by 0 day for several days now, and they were in > linux-next already too.. > > Doug, can you send this to Linus today? Yep. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH] cxgb4: fix undefined behavior in mem.c

2019-03-01 Thread Doug Ledford
to space > > deallocated by a call to the free or realloc function is used (7.22.3). > > > > Since the C standard explicitly refers to free() and realloc(), does that > > mean that that statement about undefined behavior does not apply to munmap() > > (for user space code) nor to kfree() (for kernel code)? > > > > Bart. > > -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: linux-next: manual merge of the net-next tree with the rdma tree

2019-02-27 Thread Doug Ledford
nflicts. > Thanks Stephen, we'll add it to the (largish this release) list of conflicts to bring to Linus' attention. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH] RDMA/cma: Make CM response timeout and # CM retries configurable

2019-02-22 Thread Doug Ledford
cm.max_backlog and > net.iw_cm.default_backlog. The core network stack seems to use sysctl > and not ip tool to set basically globals. > > To use rdma tool, we'd have to have some concept of a "module" object, I > guess. IE there's dev, link, and resource rdma tool objects currently. > But these cma timeout settings are really not per dev, link, nor a > resource. Maybe we have just a "core" object: rdma core set > cma_max_cm_retries min 8 max 30. I don’t know, I think you make a fairly good argument for leaving it as a sysctl. We have infrastructure in place for admins to set persistent sysctl settings. The per device/link settings need something different because link names and such can change. Since these are globals, I’d leave them where they are. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: Message signed with OpenPGP

Re: linux-next: build warning after merge of the rdma tree

2019-02-13 Thread Doug Ledford
ugh > happens (assuming that the fall through is intentional). > Thanks Stephen, we'll sort it and make an appropriate fixup patch. Kaike? -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-07 Thread Doug Ledford
oug Ledford wrote: > > On Wed, 2019-02-06 at 15:08 -0700, Jason Gunthorpe wrote: > > > On Thu, Feb 07, 2019 at 08:03:56AM +1100, Dave Chinner wrote: > > > > On Wed, Feb 06, 2019 at 07:16:21PM +, Christopher Lameter wrote: > > > > > On Wed, 6 Feb 2019, Doug

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-07 Thread Doug Ledford
On Thu, 2019-02-07 at 10:41 -0500, Tom Talpey wrote: > On 2/7/2019 10:37 AM, Doug Ledford wrote: > > On Thu, 2019-02-07 at 10:28 -0500, Tom Talpey wrote: > > > On 2/7/2019 10:04 AM, Chuck Lever wrote: > > > > > On Feb 7, 2019, at 12:23 AM, Jason Gunthorpe wrote:

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-07 Thread Doug Ledford
oesn't tell the communication agent about a broken lease, it want's to be able to do things 100% transparently without any work on the communication agent's part. That works for ODP, but not for anything else. If the filesystem notified the communication agent of the need to drop the MMU region and rebuild

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-06 Thread Doug Ledford
On Wed, 2019-02-06 at 14:44 -0800, Dan Williams wrote: > On Wed, Feb 6, 2019 at 2:25 PM Doug Ledford wrote: > > Can someone give me a real world scenario that someone is *actually* > > asking for with this? > > I'll point to this example. At the 6:35 mark Kodi talks about

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-06 Thread Doug Ledford
On Wed, 2019-02-06 at 14:44 -0800, Dan Williams wrote: > On Wed, Feb 6, 2019 at 2:25 PM Doug Ledford wrote: > > On Wed, 2019-02-06 at 15:08 -0700, Jason Gunthorpe wrote: > > > On Thu, Feb 07, 2019 at 08:03:56AM +1100, Dave Chinner wrote: > > > > On Wed, Fe

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-06 Thread Doug Ledford
On Wed, 2019-02-06 at 15:08 -0700, Jason Gunthorpe wrote: > On Thu, Feb 07, 2019 at 08:03:56AM +1100, Dave Chinner wrote: > > On Wed, Feb 06, 2019 at 07:16:21PM +, Christopher Lameter wrote: > > > On Wed, 6 Feb 2019, Doug Ledford wrote: > > > > > >

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-06 Thread Doug Ledford
On Wed, 2019-02-06 at 13:04 -0800, Dan Williams wrote: > On Wed, Feb 6, 2019 at 12:14 PM Doug Ledford wrote: > > On Wed, 2019-02-06 at 11:45 -0800, Dan Williams wrote: > > > On Wed, Feb 6, 2019 at 10:52 AM Jason Gunthorpe wrote: > > > > On Wed, Feb 06, 2019 at 10

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-06 Thread Doug Ledford
On Wed, 2019-02-06 at 12:20 -0800, Matthew Wilcox wrote: > On Wed, Feb 06, 2019 at 03:16:02PM -0500, Doug Ledford wrote: > > On Wed, 2019-02-06 at 11:40 -0800, Matthew Wilcox wrote: > > > On Wed, Feb 06, 2019 at 07:16:21PM +, Christopher Lameter wrote: > > > > tho

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-06 Thread Doug Ledford
On Wed, 2019-02-06 at 12:49 -0800, Matthew Wilcox wrote: > On Wed, Feb 06, 2019 at 03:47:53PM -0500, Doug Ledford wrote: > > On Wed, 2019-02-06 at 12:41 -0800, Matthew Wilcox wrote: > > > On Wed, Feb 06, 2019 at 03:28:35PM -0500, Doug Ledford wrote: > > > > On

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-06 Thread Doug Ledford
On Wed, 2019-02-06 at 12:41 -0800, Matthew Wilcox wrote: > On Wed, Feb 06, 2019 at 03:28:35PM -0500, Doug Ledford wrote: > > On Wed, 2019-02-06 at 12:20 -0800, Matthew Wilcox wrote: > > > On Wed, Feb 06, 2019 at 03:16:02PM -0500, Doug Ledford wrote: > > > > On

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-06 Thread Doug Ledford
On Wed, 2019-02-06 at 12:20 -0800, Matthew Wilcox wrote: > On Wed, Feb 06, 2019 at 03:16:02PM -0500, Doug Ledford wrote: > > On Wed, 2019-02-06 at 11:40 -0800, Matthew Wilcox wrote: > > > On Wed, Feb 06, 2019 at 07:16:21PM +, Christopher Lameter wrote: > > > > tho

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-06 Thread Doug Ledford
he device (something that would have returned ETXTBSY)? -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-06 Thread Doug Ledford
is a major case of dissonant cognitive behavior here if the syscall supports ETXTBSY, even though the ability to kill apps using the text pages is trivial, but thinks supporting EBUSY is out of the question. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-06 Thread Doug Ledford
On Wed, 2019-02-06 at 10:35 -0800, Matthew Wilcox wrote: > On Wed, Feb 06, 2019 at 01:32:04PM -0500, Doug Ledford wrote: > > On Wed, 2019-02-06 at 09:52 -0800, Matthew Wilcox wrote: > > > On Wed, Feb 06, 2019 at 10:31:14AM -0700, Jason Gunthorpe wrote: > > > > On W

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-06 Thread Doug Ledford
ot;this file has pinned pages that can not be freed" is not (or should not be) totally out of the question. Admittedly, I'm coming in late to this conversation, but did I miss the portion where that alternative was ruled out? -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

[PULL REQUEST] Please pull rdma.git

2018-12-13 Thread Doug Ledford
- 7 files changed, 22 insertions(+), 8 deletions(-) -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: linux-next: manual merge of the mlx5-next tree with the rdma tree

2018-12-04 Thread Doug Ledford
en your tree > is submitted for merging. You may also want to consider cooperating > with the maintainer of the conflicting tree to minimise any particularly > complex conflicts. > -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: linux-next: manual merge of the mlx5-next tree with the rdma tree

2018-12-04 Thread Doug Ledford
en your tree > is submitted for merging. You may also want to consider cooperating > with the maintainer of the conflicting tree to minimise any particularly > complex conflicts. > -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings

2018-12-03 Thread Doug Ledford
ild test robot > > --- > > applied to for-next, thanks > > Jason This caused a conflict with your make write() handlers use a consistent flow series, which I fixed up during git am run. Just FYI in case you want to check out the conflict spot as a double check (but it was a sim

Re: [PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings

2018-12-03 Thread Doug Ledford
ild test robot > > --- > > applied to for-next, thanks > > Jason This caused a conflict with your make write() handlers use a consistent flow series, which I fixed up during git am run. Just FYI in case you want to check out the conflict spot as a double check (but it was a sim

Re: [PATCH] RDMA/hns: Use 64-bit arithmetic instead of 32-bit

2018-10-18 Thread Doug Ledford
/infiniband/hw/hns/hns_roce_mr.c > > @@ -1219,7 +1219,7 @@ struct ib_mr *hns_roce_alloc_mr(struct ib_pd *pd, > > enum ib_mr_type mr_type, > > int ret; > > > > page_size = 1 << (hr_dev->caps.pbl_buf_pg_sz + PAGE_SHIFT); > > - length = max_num_sg * p

Re: [PATCH] RDMA/hns: Use 64-bit arithmetic instead of 32-bit

2018-10-18 Thread Doug Ledford
/infiniband/hw/hns/hns_roce_mr.c > > @@ -1219,7 +1219,7 @@ struct ib_mr *hns_roce_alloc_mr(struct ib_pd *pd, > > enum ib_mr_type mr_type, > > int ret; > > > > page_size = 1 << (hr_dev->caps.pbl_buf_pg_sz + PAGE_SHIFT); > > - length = max_num_sg * p

Re: [PATCH v3 0/2] IB/mlx4: Enable debug print of SMPs and enhance output for MADs

2018-10-16 Thread Doug Ledford
es, my v2 > was partly original submission plus a v2. That probably fooled > both the kbuild bot and patchwork > > 2.14.3 Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH v3 0/2] IB/mlx4: Enable debug print of SMPs and enhance output for MADs

2018-10-16 Thread Doug Ledford
es, my v2 > was partly original submission plus a v2. That probably fooled > both the kbuild bot and patchwork > > 2.14.3 Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH] RDMA/ucma: Fix Spectre v1 vulnerability

2018-10-16 Thread Doug Ledford
the first load and not worry if it can be > completed with a dependent load/store [1]. > > [1] https://marc.info/?l=linux-kernel=152449131114778=2 > > Cc: sta...@vger.kernel.org > Signed-off-by: Gustavo A. R. Silva Thanks, applied to for-rc. -- Doug Ledford GPG KeyID: B826A3

Re: [PATCH] RDMA/ucma: Fix Spectre v1 vulnerability

2018-10-16 Thread Doug Ledford
the first load and not worry if it can be > completed with a dependent load/store [1]. > > [1] https://marc.info/?l=linux-kernel=152449131114778=2 > > Cc: sta...@vger.kernel.org > Signed-off-by: Gustavo A. R. Silva Thanks, applied to for-rc. -- Doug Ledford GPG KeyID: B826A3

Re: [PATCH] IB/ucm: Fix Spectre v1 vulnerability

2018-10-16 Thread Doug Ledford
the first load and not worry if it can be > completed with a dependent load/store [1]. > > [1] https://marc.info/?l=linux-kernel=152449131114778=2 > > Cc: sta...@vger.kernel.org > Signed-off-by: Gustavo A. R. Silva Thanks, applied to for-rc. -- Doug Ledford GPG KeyID: B826A3

Re: [PATCH] IB/ucm: Fix Spectre v1 vulnerability

2018-10-16 Thread Doug Ledford
the first load and not worry if it can be > completed with a dependent load/store [1]. > > [1] https://marc.info/?l=linux-kernel=152449131114778=2 > > Cc: sta...@vger.kernel.org > Signed-off-by: Gustavo A. R. Silva Thanks, applied to for-rc. -- Doug Ledford GPG KeyID: B826A3

Re: [PATCH rdma-next 00/18] RDMA: Add support for ib_device_ops

2018-10-09 Thread Doug Ledford
On Tue, 2018-10-09 at 14:46 -0400, Jason Gunthorpe wrote: > > > On Tue., Oct. 9, 2018, 2:44 p.m. Kamal Heib, wrote: > > On Tue, Oct 09, 2018 at 02:31:27PM -0400, Doug Ledford wrote: > > > On Tue, 2018-10-09 at 19:27 +0300, Kamal Heib wrote: > > > > Thi

Re: [PATCH rdma-next 00/18] RDMA: Add support for ib_device_ops

2018-10-09 Thread Doug Ledford
On Tue, 2018-10-09 at 14:46 -0400, Jason Gunthorpe wrote: > > > On Tue., Oct. 9, 2018, 2:44 p.m. Kamal Heib, wrote: > > On Tue, Oct 09, 2018 at 02:31:27PM -0400, Doug Ledford wrote: > > > On Tue, 2018-10-09 at 19:27 +0300, Kamal Heib wrote: > > > > Thi

Re: [PATCH rdma-next 00/18] RDMA: Add support for ib_device_ops

2018-10-09 Thread Doug Ledford
ired changes in the core and ulps to start using it. > > Thanks, > Kamal Hi Kamal, Please repost this to linux-r...@vger.kernel.org as that's how this gets into patchworks. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57

Re: [PATCH rdma-next 00/18] RDMA: Add support for ib_device_ops

2018-10-09 Thread Doug Ledford
ired changes in the core and ulps to start using it. > > Thanks, > Kamal Hi Kamal, Please repost this to linux-r...@vger.kernel.org as that's how this gets into patchworks. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57

Re: [PATCH] IB/nes: Remove unnecessary parentheses

2018-09-21 Thread Doug Ledford
; = > > Remove the unnecessary parentheses to silence this warning. > > Reported-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor Applied to for-next, thanks. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B

Re: [PATCH] IB/nes: Remove unnecessary parentheses

2018-09-21 Thread Doug Ledford
; = > > Remove the unnecessary parentheses to silence this warning. > > Reported-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor Applied to for-next, thanks. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B

Re: [PATCH] RDMA/cxgb4: remove redundant null pointer check before kfree_skb

2018-09-21 Thread Doug Ledford
On Thu, 2018-09-20 at 17:52 +0800, zhong jiang wrote: > kfree_skb has taken the null pointer into account. hence it is safe > to remove the redundant null pointer check before kfree_skb. > > Signed-off-by: zhong jiang Applied to for-next, thanks. -- Doug Ledford

Re: [PATCH] IB/mlx4: Remove unnecessary parentheses

2018-09-21 Thread Doug Ledford
if ((method == IB_MGMT_METHOD_GET_RESP)) { > ^~ > = > > Remove the unnecessary parentheses to silence this warning. > > Reported-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor Applied to for-next, thanks. -- Doug Ledford G

Re: [PATCH] RDMA/cxgb4: remove redundant null pointer check before kfree_skb

2018-09-21 Thread Doug Ledford
On Thu, 2018-09-20 at 17:52 +0800, zhong jiang wrote: > kfree_skb has taken the null pointer into account. hence it is safe > to remove the redundant null pointer check before kfree_skb. > > Signed-off-by: zhong jiang Applied to for-next, thanks. -- Doug Ledford

Re: [PATCH] IB/mlx4: Remove unnecessary parentheses

2018-09-21 Thread Doug Ledford
if ((method == IB_MGMT_METHOD_GET_RESP)) { > ^~ > = > > Remove the unnecessary parentheses to silence this warning. > > Reported-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor Applied to for-next, thanks. -- Doug Ledford G

Re: [PATCH] ucma: fix a use-after-free in ucma_resolve_ip()

2018-09-13 Thread Doug Ledford
t; pattern is already used by ucma_destroy_id(). > > Reported-and-tested-by: syzbot+da2591e115d57a9cb...@syzkaller.appspotmail.com > Reported-by: syzbot+cfe3c1e8ef634ba89...@syzkaller.appspotmail.com > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Leon Romanovsky > Signed-off-by: Cong Wang T

Re: [PATCH] ucma: fix a use-after-free in ucma_resolve_ip()

2018-09-13 Thread Doug Ledford
t; pattern is already used by ucma_destroy_id(). > > Reported-and-tested-by: syzbot+da2591e115d57a9cb...@syzkaller.appspotmail.com > Reported-by: syzbot+cfe3c1e8ef634ba89...@syzkaller.appspotmail.com > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Leon Romanovsky > Signed-off-by: Cong Wang T

Re: [PATCH -next] RDMA: Remove duplicated include from ib_addr.h

2018-09-13 Thread Doug Ledford
eletion(-) > > > > Thanks, > Reviewed-by: Leon Romanovsky Thanks, applied to for-next. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH -next] RDMA: Remove duplicated include from ib_addr.h

2018-09-13 Thread Doug Ledford
eletion(-) > > > > Thanks, > Reviewed-by: Leon Romanovsky Thanks, applied to for-next. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH] infiniband: nes: add unlikely() to assert()

2018-09-07 Thread Doug Ledford
On Wed, 2018-09-05 at 09:01 +0300, Leon Romanovsky wrote: > On Fri, Aug 31, 2018 at 10:24:18PM +0300, Igor Stoppa wrote: > > Typically the assert is expected to not fail. > > This whole assert can be removed. > > > > > Signed-off-by: Igor Stoppa > > Acked-

Re: [PATCH] infiniband: nes: add unlikely() to assert()

2018-09-07 Thread Doug Ledford
On Wed, 2018-09-05 at 09:01 +0300, Leon Romanovsky wrote: > On Fri, Aug 31, 2018 at 10:24:18PM +0300, Igor Stoppa wrote: > > Typically the assert is expected to not fail. > > This whole assert can be removed. > > > > > Signed-off-by: Igor Stoppa > > Acked-

Re: [PATCH 01/23] infiniband: nes: add unlikely() to assert()

2018-08-31 Thread Doug Ledford
On Fri, 2018-08-31 at 01:34 +0300, Igor Stoppa wrote: > Typically the assert is expected to not fail. > > Signed-off-by: Igor Stoppa > Cc: Chien Tung > Cc: Roland Dreier > Cc: Faisal Latif > Cc: Doug Ledford > Cc: Jason Gunthorpe Acked-by: Doug Ledford > --- &

Re: [PATCH 01/23] infiniband: nes: add unlikely() to assert()

2018-08-31 Thread Doug Ledford
On Fri, 2018-08-31 at 01:34 +0300, Igor Stoppa wrote: > Typically the assert is expected to not fail. > > Signed-off-by: Igor Stoppa > Cc: Chien Tung > Cc: Roland Dreier > Cc: Faisal Latif > Cc: Doug Ledford > Cc: Jason Gunthorpe Acked-by: Doug Ledford > --- &

Re: [RDMA bug] KASAN: use-after-free Read in __list_del_entry_valid (4)

2018-08-23 Thread Doug Ledford
On Thu, 2018-08-23 at 16:39 +, Parav Pandit wrote: > > -Original Message- > > From: Jason Gunthorpe > > Sent: Thursday, August 23, 2018 9:55 AM > > To: Eric Biggers > > Cc: Doug Ledford ; linux-r...@vger.kernel.org; > > dasaratharaman.cha

Re: [RDMA bug] KASAN: use-after-free Read in __list_del_entry_valid (4)

2018-08-23 Thread Doug Ledford
On Thu, 2018-08-23 at 16:39 +, Parav Pandit wrote: > > -Original Message- > > From: Jason Gunthorpe > > Sent: Thursday, August 23, 2018 9:55 AM > > To: Eric Biggers > > Cc: Doug Ledford ; linux-r...@vger.kernel.org; > > dasaratharaman.cha

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-31 Thread Doug Ledford
able rdma-cm, including all > > support for rx'ing remote packets? Greg? > > Yes. That's my goal when INFINIBAND_ADDR_TRANS is unset. > > > If this is required for iwarp then Arnd's patch is probably the right > > way to go.. > > Jason > > Agreed. > Acked-by: Greg Thelen If that's the case, then there should be a NOTE: in the Kconfig that disabling the connection manager completely disables iWARP hardware. I don't really think I like this approach though. At a minimum if you are going to make iWARP totally dependent on rdmacm, then there is zero reason that iw_cm.o should be part of the obj-$(CONFIG_INFINIBAND) Makefile recipe when ADDR_TRANS is disabled. We can take this patch as a band-aid, but IMO it's either incomplete or simply not the right solution. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-31 Thread Doug Ledford
able rdma-cm, including all > > support for rx'ing remote packets? Greg? > > Yes. That's my goal when INFINIBAND_ADDR_TRANS is unset. > > > If this is required for iwarp then Arnd's patch is probably the right > > way to go.. > > Jason > > Agreed. > Acked-by: Greg Thelen If that's the case, then there should be a NOTE: in the Kconfig that disabling the connection manager completely disables iWARP hardware. I don't really think I like this approach though. At a minimum if you are going to make iWARP totally dependent on rdmacm, then there is zero reason that iw_cm.o should be part of the obj-$(CONFIG_INFINIBAND) Makefile recipe when ADDR_TRANS is disabled. We can take this patch as a band-aid, but IMO it's either incomplete or simply not the right solution. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH] RDMA/qedr: fix spelling mistake: "adrresses" -> "addresses"

2018-05-31 Thread Doug Ledford
On Wed, 2018-05-30 at 10:40 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in DP_ERR error message > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B

Re: [PATCH] RDMA/qedr: fix spelling mistake: "adrresses" -> "addresses"

2018-05-31 Thread Doug Ledford
On Wed, 2018-05-30 at 10:40 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in DP_ERR error message > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B

Re: [PATCH 6/6] infiniband: qplib_fp: Use dev_fmt

2018-05-15 Thread Doug Ledford
t; > Signed-off-by: Joe Perches <j...@perches.com> I don't see any problem with this patch. For the IB part: Acked-by: Doug Ledford <dledf...@redhat.com> -- Doug Ledford <dledf...@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B

  1   2   3   4   5   6   7   8   9   10   >