Owner is automatically set by mtdcore. Make use of that.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/denali.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
index f44c606..16e61de 100644
--- a/drivers/mtd/nand
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/fsl_elbc_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand
Fix a bug where mtd devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/maps/ixp4xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/maps/ixp4xx.c b
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner and name set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/plat_nand.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mtd/nand
Fix a bug where devices aren't shown in sysfs.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/mpc5121_nfc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/mpc5121_nfc.c b/drivers/mtd/nand/mpc5121_nfc.c
index 1f12e5b..b97c371 100644
--- a/drivers/mtd
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/ndfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/ndfc.c b/drivers/mtd/nand
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/pxa3xx_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/pxa3xx_nand.c
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/pasemi_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/pasemi_nand.c
Fix a bug where mtd devices aren't shown in sysfs.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/devices/spear_smi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/devices/spear_smi.c b/drivers/mtd/devices/spear_smi.c
index 508bab3..015a1cf 100644
Owner is automatically set by mtdcore. Make use of that.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/maps/physmap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
index 4305fd6..cc2adbb 100644
--- a/drivers/mtd
Owner is automatically set by mtdcore. Make use of that.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/maps/physmap_of.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c
index ff26e97..10954f7 100644
If a parent device is set, add_mtd_device() has enough knowledge to fill
in some sane default values for the module name and owner. Do so if they
aren't already set.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/mtdcore.c | 9 +
1 file changed, 9 insertions(+)
diff
Owner is automatically set by mtdcore. Make use of that.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/devices/mtd_dataflash.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/devices/mtd_dataflash.c
b/drivers/mtd/devices/mtd_dataflash.c
index 0099aba..ca5ae8e
Owner is automatically set by mtdcore. Make use of that.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/cafe_nand.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/cafe_nand.c b/drivers/mtd/nand/cafe_nand.c
index 9a0f45f..aa1dc55 100644
--- a/drivers
Fix a bug where mtd devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/maps/intel_vr_nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/maps
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/docg4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/docg4.c b/drivers
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/bcm47xxnflash/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/bf5xx_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/bf5xx_nand.c b
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/au1550nd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/au1550nd.c b
Fix a bug where mtd devices aren't shown in sysfs.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/maps/gpio-addr-flash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/maps/gpio-addr-flash.c
b/drivers/mtd/maps/gpio-addr-flash.c
index 2fb3460
Fix a bug where mtd devices aren't shown in sysfs.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/lpddr/lpddr2_nvm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/lpddr/lpddr2_nvm.c b/drivers/mtd/lpddr/lpddr2_nvm.c
index 063cec4..2342277 100644
--- a/drivers
Fix a bug where devices aren't shown in sysfs.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/tmio_nand.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/tmio_nand.c b/drivers/mtd/nand/tmio_nand.c
index fb8fd35..befddf0 100644
--- a/drivers/mtd/nand
Owner and name are automatically set by mtdcore. Make use of that.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/onenand/omap2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
index 646ddd6..3e02856 100644
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/jz4740_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/jz4740_nand.c
Owner and name are automatically set by mtdcore. Make use of that.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/davinci_nand.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
index feb6d18..78e0c4d
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/fsl_upm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/fsl_upm.c b/drivers/mtd
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/fsmc_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/fsmc_nand.c b
Owner is automatically set by mtdcore. Make use of that.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/lpc32xx_mlc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/lpc32xx_mlc.c b/drivers/mtd/nand/lpc32xx_mlc.c
index 79c3b78..65b7e03 100644
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/gpio.c b/drivers/mtd
Owner is automatically set by mtdcore. Make use of that.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/mxc_nand.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index a8f550f..a62284c 100644
--- a/drivers/mtd
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/atmel_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b
Fix a bug where mtd devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Incidentally, it seems the owner field in the concatenated mtds is not
actually used, so this shouldn't make much of a difference anyway.
Signed-off-by: Frans Klaver franskla
Fix a bug where mtd devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/maps/rbtx4939-flash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/maps
Fix a bug where mtd devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/devices/docg3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/docg3.c b
/generic
The rest is untested. If you have suggestions for me to compile-test most of
them for a next run, I'd be much obliged.
Thanks for having a go at your favorite MTD,
Frans
[1] https://lkml.org/lkml/2014/5/26/586
Frans Klaver (60):
mtd: core: tone down suggestion that dev.parent should
Fix a bug where mtd devices aren't shown in sysfs.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c
b/drivers/mtd/spi-nor/fsl-quadspi.c
index 1c7308c..91b9d3f 100644
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/txx9ndfmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/txx9ndfmc.c b
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/sharpsl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/sharpsl.c b
Fix a bug where mtd devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/devices/sst25l.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mtd/devices
Fix a bug where mtd devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/maps/lantiq-flash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/maps/lantiq
Fix a bug where devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/nand/orion_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/orion_nand.c b
Fix a bug where mtd devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/maps/latch-addr-flash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/maps
Fix a bug where mtd devices aren't shown in sysfs.
While at it, make use of the default owner value set by mtdcore.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/devices/bcm47xxsflash.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd
Fix a bug where mtd devices aren't shown in sysfs.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/devices/m25p80.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 85e35467..48eee8f 100644
--- a/drivers/mtd
actually provide a parent device to link to. That means we
cannot WARN_ON() here, as it would trigger false positives.
Make the comment a bit less firm in its assertion that dev.parent should
be set.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/mtd/mtdcore.c | 2 +-
1 file changed, 1
Fix incorrect spelling of situation.
Signed-off-by: Frans Klaver
---
init/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/init/main.c b/init/main.c
index 6f0f1c5f..9d353ce 100644
--- a/init/main.c
+++ b/init/main.c
@@ -143,7 +143,7 @@ EXPORT_SYMBOL_GPL
Fix incorrect spelling of situation.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
init/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/init/main.c b/init/main.c
index 6f0f1c5f..9d353ce 100644
--- a/init/main.c
+++ b/init/main.c
@@ -143,7 +143,7
On Wed, Feb 4, 2015 at 12:18 PM, Rasmus Villemoes
wrote:
> Hi,
>
> The kernel's ctype is almost, but not quite, equivalent to latin1. Apart
> from whether one wants to include the C1 control chars (0x80-0x9f),
> there are a few other differences. For example, 0xb5 (MICRO SIGN) is, at
> least
On Wed, Feb 4, 2015 at 12:18 PM, Rasmus Villemoes
li...@rasmusvillemoes.dk wrote:
Hi,
The kernel's ctype is almost, but not quite, equivalent to latin1. Apart
from whether one wants to include the C1 control chars (0x80-0x9f),
there are a few other differences. For example, 0xb5 (MICRO SIGN)
On Thu, Feb 5, 2015 at 9:39 AM, Frans Klaver wrote:
> On Thu, Feb 5, 2015 at 5:08 AM, william wrote:
>> so it seems that i m hitting this bug :
>> https://lkml.org/lkml/2014/4/29/497
>>
>> + if (!divisor)
>> + divisor = 1;
>>
>> that have been fixe
[+cc andrew, rik, michal]
On Thu, Feb 5, 2015 at 5:08 AM, william wrote:
> so it seems that i m hitting this bug :
> https://lkml.org/lkml/2014/4/29/497
>
> + if (!divisor)
> + divisor = 1;
>
> that have been fixed ( well it looks more like a workaround than a fix
> seen from here ) in the 64
[+cc andrew, rik, michal]
On Thu, Feb 5, 2015 at 5:08 AM, william will...@waisse.org wrote:
so it seems that i m hitting this bug :
https://lkml.org/lkml/2014/4/29/497
+ if (!divisor)
+ divisor = 1;
that have been fixed ( well it looks more like a workaround than a fix
seen from here ) in
On Thu, Feb 5, 2015 at 9:39 AM, Frans Klaver franskla...@gmail.com wrote:
On Thu, Feb 5, 2015 at 5:08 AM, william will...@waisse.org wrote:
so it seems that i m hitting this bug :
https://lkml.org/lkml/2014/4/29/497
+ if (!divisor)
+ divisor = 1;
that have been fixed ( well it looks more
Hi,
On Thu, Jan 22, 2015 at 6:56 AM, Dick Hollenbeck wrote:
> This was generated from 3.14 kernel, but since its so small it will likely
> apply to newer
> kernels without issue.
Thanks for contributing.
It is the custom that you send your patches in the body of the e-mail
instead of as an
Hi,
On Thu, Jan 22, 2015 at 6:56 AM, Dick Hollenbeck d...@softplc.com wrote:
This was generated from 3.14 kernel, but since its so small it will likely
apply to newer
kernels without issue.
Thanks for contributing.
It is the custom that you send your patches in the body of the e-mail
On Thu, Jan 15, 2015 at 01:52:49AM +0100, Sebastian Reichel wrote:
> Thanks for the cleanup, applied:
>
> http://git.infradead.org/battery-2.6.git/commit/d84ba07c27fafca3cc77b25a1e204383a4b5af91
Thanks for the heads up.
Cheers,
Frans
--
To unsubscribe from this list: send the line "unsubscribe
On Thu, Jan 15, 2015 at 01:52:49AM +0100, Sebastian Reichel wrote:
Thanks for the cleanup, applied:
http://git.infradead.org/battery-2.6.git/commit/d84ba07c27fafca3cc77b25a1e204383a4b5af91
Thanks for the heads up.
Cheers,
Frans
--
To unsubscribe from this list: send the line unsubscribe
may
power down the platform if the power button is pressed for about 5
seconds, we still need to make sure to start the watchdog toggle to
prolong the system power for as long as we need it.
This will still allow the system to control power using the kill signal.
Signed-off-by: Frans Klaver
The three gpio's used by this driver are stored in an array of pointers.
This doesn't add much besides cleanups in a loop. In fact, it makes most
of the usage sites harder to read. Unroll the loop, and live with the
fact that cleanups become slightly larger.
Signed-off-by: Frans Klaver
Make use of the fact that we allocated resources can be automatically
deallocated. This reduces cleanup code and chance of errors. It also
removes the need for the virq member of the ltc2952_poweroff_data
struct.
Signed-off-by: Frans Klaver
---
drivers/power/reset/ltc2952-poweroff.c | 19
to the module_platform_driver() macro.
Signed-off-by: Frans Klaver
---
drivers/power/reset/ltc2952-poweroff.c | 57 +-
1 file changed, 22 insertions(+), 35 deletions(-)
diff --git a/drivers/power/reset/ltc2952-poweroff.c
b/drivers/power/reset/ltc2952-poweroff.c
index 9d493b5..bc8d228
The function pointers for the timers and pm_power_off are assigned with
C++ style
foo =
Let's change it instead to the more C style
foo = func;
Signed-off-by: Frans Klaver
---
drivers/power/reset/ltc2952-poweroff.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
of boiler plate, while achieving nothing. Drop the
functions instead.
Signed-off-by: Frans Klaver
---
drivers/power/reset/ltc2952-poweroff.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/power/reset/ltc2952-poweroff.c
b/drivers/power/reset/ltc2952-poweroff.c
index bc8d228
Disable the timers when ltc2952_poweroff is removed. We don't want to
risk calling functions on data that no longer exist.
Signed-off-by: Frans Klaver
---
drivers/power/reset/ltc2952-poweroff.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/power/reset/ltc2952-poweroff.c
b
the timer. If the button is active, we should start the timer,
else we should stop it.
The situation described can now still occur if the polarity of the input
pin is set incorrectly, but that at least is predictable behavior and
can be detected during the first tests.
Signed-off-by: Frans Klaver
ltc2952_poweroff_handler uses gotos to return from the function. Since
we don't do cleanups exiting this function, just return IRQ_HANDLED on
the spot and be done with it.
While at it, remove the variable 'ret'. It was never used very much.
Signed-off-by: Frans Klaver
---
drivers/power/reset
Document the fact that the trigger signal is now optional, and describe
the behavior when this is used.
While at it, fix a typo, and paraphrase a sentence to be less platform
specific.
Signed-off-by: Frans Klaver
---
.../devicetree/bindings/power/reset/ltc2952-poweroff.txt| 13
This reduces cleanup code and chance of errors.
Signed-off-by: Frans Klaver
---
drivers/power/reset/ltc2952-poweroff.c | 44 --
1 file changed, 10 insertions(+), 34 deletions(-)
diff --git a/drivers/power/reset/ltc2952-poweroff.c
b/drivers/power/reset/ltc2952
ill to
poweroff. The name poweroff is already used a lot. Besides that, the control
is referred to as kill in the ltc2952 datasheet.
Thanks,
Frans
Frans Klaver (13):
power: reset: ltc2952: prefer devm_kzalloc over kzalloc
power: reset: ltc2952: prefer devm_request_irq over request_irq
power: re
that little bit of typing.
Signed-off-by: Frans Klaver
---
drivers/power/reset/ltc2952-poweroff.c | 75 +++---
1 file changed, 41 insertions(+), 34 deletions(-)
diff --git a/drivers/power/reset/ltc2952-poweroff.c
b/drivers/power/reset/ltc2952-poweroff.c
index 1e96b5b
Make use of the fact that the allocated resources can be automatically
deallocated. This reduces cleanup code and chance of leaks.
Signed-off-by: Frans Klaver
---
drivers/power/reset/ltc2952-poweroff.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/power
that little bit of typing.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/power/reset/ltc2952-poweroff.c | 75 +++---
1 file changed, 41 insertions(+), 34 deletions(-)
diff --git a/drivers/power/reset/ltc2952-poweroff.c
b/drivers/power/reset/ltc2952
Make use of the fact that the allocated resources can be automatically
deallocated. This reduces cleanup code and chance of leaks.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/power/reset/ltc2952-poweroff.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff
Document the fact that the trigger signal is now optional, and describe
the behavior when this is used.
While at it, fix a typo, and paraphrase a sentence to be less platform
specific.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
.../devicetree/bindings/power/reset/ltc2952
This reduces cleanup code and chance of errors.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/power/reset/ltc2952-poweroff.c | 44 --
1 file changed, 10 insertions(+), 34 deletions(-)
diff --git a/drivers/power/reset/ltc2952-poweroff.c
b/drivers
ltc2952_poweroff_handler uses gotos to return from the function. Since
we don't do cleanups exiting this function, just return IRQ_HANDLED on
the spot and be done with it.
While at it, remove the variable 'ret'. It was never used very much.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
to
poweroff. The name poweroff is already used a lot. Besides that, the control
is referred to as kill in the ltc2952 datasheet.
Thanks,
Frans
Frans Klaver (13):
power: reset: ltc2952: prefer devm_kzalloc over kzalloc
power: reset: ltc2952: prefer devm_request_irq over request_irq
power: reset
The function pointers for the timers and pm_power_off are assigned with
C++ style
foo = func;
Let's change it instead to the more C style
foo = func;
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/power/reset/ltc2952-poweroff.c | 6 +++---
1 file changed, 3
of boiler plate, while achieving nothing. Drop the
functions instead.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/power/reset/ltc2952-poweroff.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/power/reset/ltc2952-poweroff.c
b/drivers/power/reset/ltc2952
to the module_platform_driver() macro.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/power/reset/ltc2952-poweroff.c | 57 +-
1 file changed, 22 insertions(+), 35 deletions(-)
diff --git a/drivers/power/reset/ltc2952-poweroff.c
b/drivers/power/reset/ltc2952-poweroff.c
Disable the timers when ltc2952_poweroff is removed. We don't want to
risk calling functions on data that no longer exist.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/power/reset/ltc2952-poweroff.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/power/reset
the timer. If the button is active, we should start the timer,
else we should stop it.
The situation described can now still occur if the polarity of the input
pin is set incorrectly, but that at least is predictable behavior and
can be detected during the first tests.
Signed-off-by: Frans Klaver
The three gpio's used by this driver are stored in an array of pointers.
This doesn't add much besides cleanups in a loop. In fact, it makes most
of the usage sites harder to read. Unroll the loop, and live with the
fact that cleanups become slightly larger.
Signed-off-by: Frans Klaver frans.kla
Make use of the fact that we allocated resources can be automatically
deallocated. This reduces cleanup code and chance of errors. It also
removes the need for the virq member of the ltc2952_poweroff_data
struct.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/power/reset/ltc2952
may
power down the platform if the power button is pressed for about 5
seconds, we still need to make sure to start the watchdog toggle to
prolong the system power for as long as we need it.
This will still allow the system to control power using the kill signal.
Signed-off-by: Frans Klaver
Hi there,
On Wed, Oct 22, 2014 at 04:30:57PM +0200, Frans Klaver wrote:
>
> This series implements devm_* usage, reduction of globals, some cleanup and
> finally makes the input trigger optional.
Has this fallen through the cracks?
Thanks,
Frans
--
To unsubscribe from this list: send
Hi there,
On Wed, Oct 22, 2014 at 04:30:57PM +0200, Frans Klaver wrote:
This series implements devm_* usage, reduction of globals, some cleanup and
finally makes the input trigger optional.
Has this fallen through the cracks?
Thanks,
Frans
--
To unsubscribe from this list: send the line
s,produciton,production
Signed-off-by: Frans Klaver
---
kernel/trace/trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 8a52839..f3ef80c 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2028,7 +2028,7
s,produciton,production
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
kernel/trace/trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 8a52839..f3ef80c 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
In serial8250_rx_chars(), max_count is set to 256. Due to the
post-decrement operator used in the while() condition, the maximum
number of iterations actually 257. This is not a problem, but it is
mildly surprising if you're debugging. Use pre-decrement instead.
Signed-off-by: Frans Klaver
On Thu, Nov 6, 2014 at 1:53 PM, Peter Rosin wrote:
>
> Sorry for not sending this from my axentia.se account, but I tend to
> get high spam-scores from there when I use git send-email.
I don't know if you already tried it, but I had the same issue until I
switched from sendmail to actually using
In serial8250_rx_chars(), max_count is set to 256. Due to the
post-decrement operator used in the while() condition, the maximum
number of iterations actually 257. This is not a problem, but it is
mildly surprising if you're debugging. Use pre-decrement instead.
Signed-off-by: Frans Klaver
On Thu, Nov 6, 2014 at 1:53 PM, Peter Rosin p...@lysator.liu.se wrote:
Sorry for not sending this from my axentia.se account, but I tend to
get high spam-scores from there when I use git send-email.
I don't know if you already tried it, but I had the same issue until I
switched from sendmail
On Wed, Nov 5, 2014 at 10:34 AM, Brian Norris
wrote:
> On Sun, Nov 02, 2014 at 10:03:53PM +0100, Frans Klaver wrote:
>> On Wed, May 28, 2014 at 01:43:44AM -0700, Brian Norris wrote:
>> > And in fact, if any drivers are missing mtd->name, perhaps it's best to
>> > ju
On Wed, Nov 5, 2014 at 10:34 AM, Brian Norris
computersforpe...@gmail.com wrote:
On Sun, Nov 02, 2014 at 10:03:53PM +0100, Frans Klaver wrote:
On Wed, May 28, 2014 at 01:43:44AM -0700, Brian Norris wrote:
And in fact, if any drivers are missing mtd-name, perhaps it's best to
just modify
eeepc_acpi_notify increases the indentation level to a whopping four. If
we revise the conditions a bit, we can reduce that to a more soothing
two and satisfy the indentation guidelines in Documentation/CodingStyle.
Remove an unwanted space while we're in the neighbourhood.
Signed-off-by: Frans
On Wed, May 28, 2014 at 01:43:44AM -0700, Brian Norris wrote:
> And in fact, if any drivers are missing mtd->name, perhaps it's best to
> just modify the MTD registration to give them a default:
>
> if (!mtd->name)
> mtd->name = dev_name(>dev);
>
...
> How about we rethink
On Wed, May 28, 2014 at 01:43:44AM -0700, Brian Norris wrote:
And in fact, if any drivers are missing mtd-name, perhaps it's best to
just modify the MTD registration to give them a default:
if (!mtd-name)
mtd-name = dev_name(pdev-dev);
...
How about we rethink the
eeepc_acpi_notify increases the indentation level to a whopping four. If
we revise the conditions a bit, we can reduce that to a more soothing
two and satisfy the indentation guidelines in Documentation/CodingStyle.
Remove an unwanted space while we're in the neighbourhood.
Signed-off-by: Frans
On Fri, Oct 31, 2014 at 11:34:45AM +0100, Roy Spliet wrote:
>
> It does ring a tiny bell: please check out
> https://bugs.freedesktop.org/show_bug.cgi?id=85160 and try the fix proposed
> in comment #7.
Yup, that seems to fix things. As far as I'm concerned, that patch is
Test
501 - 600 of 999 matches
Mail list logo
