field). Therefore, let's use same approach here.
Thanks for the change, it look cleaner than my re-work;
Acked-by: Ganapathi Bhat
Regards,
Ganapathi
hank you for this change.
Acked-by: Ganapathi Bhat
Regards,
Ganapathi
Hi Pali,
> > > > Hello Ganapathi! Seems that on both locations is older version of
> > > > sdsd8997_combo_v4.bin firmware, not the latest one. On both
> > > > location is available just version 16.68.1.p179. But we have newer
> version 16.68.1.p197.
Where did you find p197, kindly let me know so
Acked-by: Ganapathi Bhat
Acked-by: Ganapathi Bhat
Acked-by: Ganapathi Bhat
Acked-by: Ganapathi Bhat
Hi Pali,
> This patch series fixes mwifiex and btmrvl drivers to load firmware for
> sd8977 and sd8997 chipsets from correct filename.
Thanks you for the changes, I will ack each patch;
Regards,
Ganapathi
Hi Pali,
> Hello Ganapathi! Seems that on both locations is older version of
> sdsd8997_combo_v4.bin firmware, not the latest one. On both location is
> available just version 16.68.1.p179. But we have newer version 16.68.1.p197.
> Could you please recheck it?
p179 do have the fix but we will
Hi Pali,
> Hello Ganapathi! Thank you for information. Can you point me to git tree or
> location where are firmware files already updated?
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git
or
https://github.com/NXP/mwifiex-firmware
Regards,
Ganapathi
Hi Pali,
> According to publicly available information, firmware for these W8xxx
> Marvell wifi chips is vulnerable to security issue CVE-2019-6496 [1].
>
> Are you able to update firmwares to the last versions and give us some
> information which (old) firmware versions are affected by that
Hi Pali,
> Hello! Could you please look at this trivial patch?
The change look good.
Acked-by: Ganapathi Bhat
HI Pali,
> Kernel quirks for SDIO devices are
> matched against device ID from SDIO Common CIS. Therefore device ID used
> in quirk is correct, just has misleading name.
OK, understood. Thanks for the change.
Acked-by: Ganapathi Bhat
Hi Pali,
> Add underscore as separator in Marvell 8688 macro names for better
> readability and consistency.
>
Thanks for the change;
Acked-by: Ganapathi Bhat
Hi Pali,
> Add _WLAN suffix to macro names for consistency with other Marvell macros.
> These IDs represents wlan function of combo bt/wlan cards. Other functions
> of these cards have different IDs.
>
OK, thanks for the cleanup change;
Acked-by: Ganapathi Bhat
Hi Pali,
> Define appropriate macro names for consistency with other Marvell macros.
>
Thanks for the change;
Acked-by: Ganapathi Bhat
Hi Pali,
Thanks for this notice. We will try to push the new firmware and also, fix the
naming problem.
Regards,
Ganapathi
n can be triggered by registering multiple SSIDs and calling, in
> parallel for multiple interfaces
> iw dev station dump
Thanks for this change.
Acked-by: Ganapathi Bhat
Regards,
Ganapathi
Hi Navid,
> Fixes: fc3314609047 ("mwifiex: use pci_alloc/free_consistent APIs for PCIe")
Thanks for the change;
Acked-by: Ganapathi Bhat
Regards,
Ganapathi
Hi Navid,
> Fixes: 0732484b47b5 ("mwifiex: separate ring initialization and ring creation
> routines")
Thanks for the this change as well;
Acked-by: Ganapathi Bhat
Regards,
Ganapathi
Hi Andy,
> I was wondering if you've posted the updated version of the fix?
Sorry for the delay; I have started addressing the comment from community; It
should be done in couple of days;
Regards,
Ganapathi
Hi Dmitry,
We have a patch to fix this: https://patchwork.kernel.org/patch/10990275/
Regards,
Ganapathi
a
> quick spin as well.
>
Thanks a lot for this; We will also run the tests locally; But, I find the
change is good;
Acked-by: Ganapathi Bhat
Regards,
Ganapathi
Hi Brian,
> >netif_rx_ni+0xe8/0x120
> >mwifiex_recv_packet+0xfc/0x10c [mwifiex]
> >mwifiex_process_rx_packet+0x1d4/0x238 [mwifiex]
> >mwifiex_11n_dispatch_pkt+0x190/0x1ac [mwifiex]
> >mwifiex_11n_rx_reorder_pkt+0x28c/0x354 [mwifiex]
>
> TL;DR: the problem was right here ^^^
>
Hi Dmitry,
> The "fixed" status relates to the similar past bug that was reported and fixed
> more than a year ago:
Oh OK; We understood the issue, working on a change to fix this;
Thanks,
Ganapathi
Hi Dan,
> > > > if (is_multicast_ether_addr(ra)) {
> > > > skb_uap = skb_copy(skb, GFP_ATOMIC);
> > > > + if (!skb_uap)
> > > > + return -ENOMEM;
> > >
> > > I think we would want to free dev_kfree_skb_any(skb) before returning.
> > I
Hi syzbot,
>
> syzbot found the following crash on:
>
As per the link(https://syzkaller.appspot.com/bug?extid=dc4127f950da51639216),
the issue is fixed; Is it OK? Let us know if we need to do something?
Regards,
Ganapathi
Hi Dan,
> > if (is_multicast_ether_addr(ra)) {
> > skb_uap = skb_copy(skb, GFP_ATOMIC);
> > + if (!skb_uap)
> > + return -ENOMEM;
>
> I think we would want to free dev_kfree_skb_any(skb) before returning.
I think if the pointer is NULL, no need to free
Hi Kalle/Brian,
>> RFC: I'd appreciate it if someone from Marvell could double check my work
>> here.
>BTW, if we don't hear anything from Marvell I'm going to apply these
>anyway.
This patch series looks good to us.
Thanks,
Ganapathi
ger.kernel.org>
> > Cc: Avinash Patil <pat...@marvell.com>
> > Cc: Xinming Hu <h...@marvell.com>
> > Signed-off-by: Brian Norris <briannor...@chromium.org>
> > ---
> > I've got a ton of other patches still queued up locally, and I hope
> to
&g
ash Patil
> > Cc: Xinming Hu
> > Signed-off-by: Brian Norris
> > ---
> > I've got a ton of other patches still queued up locally, and I hope
> to
> > send them soon. But I realized this one is a nasty bug (with a
> trivial
> > fix), so it's probabl
Hi Kalle/Brian,
> Brian Norris <briannor...@chromium.org> writes:
>
> > His email is bouncing, and I expect he's not doing this work any
> more.
> >
> > Cc: Amitkumar Karwar <amitkar...@gmail.com>
> > Cc: Nishant Sarmukadam <nisha...@marvell.com>
Hi Kalle/Brian,
> Brian Norris writes:
>
> > His email is bouncing, and I expect he's not doing this work any
> more.
> >
> > Cc: Amitkumar Karwar
> > Cc: Nishant Sarmukadam
> > Cc: Ganapathi Bhat
> > Cc: Xinming Hu
> > Signed-off-by:
33 matches
Mail list logo
