ction parameter 'ids'
description in 'fc_rport_create'
drivers/scsi/libfc/fc_rport.c:1452: warning: Function parameter or member
'rdata_arg' not described in 'fc_rport_logo_resp'
drivers/scsi/libfc/fc_rport.c:1452: warning: Excess function parameter
'lp
rameter or member
'state' not described in 'fc_lport_enter_ms'
drivers/scsi/libfc/fc_lport.c:1939: warning: Function parameter or member
'tov' not described in 'fc_lport_els_request'
Cc: Hannes Reinecke
Signed-off-by: Lee Jones
---
drivers/scsi/
/fcoe_transport.c:682: warning: Function parameter or member
'netdev' not described in 'fcoe_netdev_map_lookup'
Cc: Hannes Reinecke
Signed-off-by: Lee Jones
---
drivers/scsi/fcoe/fcoe_transport.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
drivers/scsi/fcoe/fcoe_ctlr.c:2977: warning: Excess function parameter
'lport' description in 'fcoe_ctlr_vlan_recv'
drivers/scsi/fcoe/fcoe_ctlr.c:2977: warning: Excess function parameter 'fp'
description in 'fcoe_ctlr_vlan_recv'
drivers/scsi/fcoe
resp'
not described in 'fcoe_elsct_send'
drivers/scsi/fcoe/fcoe.c:2627: warning: Function parameter or member 'arg'
not described in 'fcoe_elsct_send'
drivers/scsi/fcoe/fcoe.c:2627: warning: Function parameter or member
'timeout' not described in
On 7/13/20 9:46 AM, Lee Jones wrote:
This is my fault (can't even blame copy/paste).
Cc: Hannes Reinecke
Reported-by: Johannes Thumshirn
Signed-off-by: Lee Jones
---
drivers/scsi/libfc/fc_disc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/
R_MANUFACTURER_LEN 80
+#define FC_FDMI_HBA_ATTR_SERIALNUMBER_LEN 80
#define FC_FDMI_HBA_ATTR_MODEL_LEN256
#define FC_FDMI_HBA_ATTR_MODELDESCR_LEN 256
#define FC_FDMI_HBA_ATTR_HARDWAREVERSION_LEN 256
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes R
'fc_invoke_resp'
drivers/scsi/libfc/fc_exch.c:727: warning: Function parameter or member 'sp'
not described in 'fc_invoke_resp'
drivers/scsi/libfc/fc_exch.c:727: warning: Function parameter or member 'fp'
not described in 'fc_invoke_resp'
Cc:
scription in 'fc_disc_gpn_ft_parse'
drivers/scsi/libfc/fc_disc.c:498: warning: Function parameter or member
'disc_arg' not described in 'fc_disc_gpn_ft_resp'
drivers/scsi/libfc/fc_disc.c:498: warning: Excess function parameter 'lp_arg'
description i
fd->transferred_length = 0;
+ fd->status = NVME_SC_INTERNAL;
}
- fd->status = 0;
spin_unlock_irqrestore(&priv->cmd_lock, flags);
fd->done(fd);
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke
;0' in word 0 byte 0 means 'Name not present' :-)
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
urn ret;
}
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
gt;remoteport.port_state == FC_OBJSTATE_ONLINE &&
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
reg_dev->nr_zones =
DIV_ROUND_UP(reg_dev->capacity,
str r1, [r6, #64] @ tmp306, reg_dev_166->nr_zones
git blame points at this commit:
commit 70978208ec91d798066f4c291bc98ff914bea222
Author: Hannes Reinecke
Date: Mon May 11 10:24:30 2020 +0200
dm zoned: metadata
e(fc_trc_flag);
+ kfree(fc_trc_flag);
}
/*
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 3
g_use_adisc && (vport->fc_flag & FC_RSCN_MODE)) ||
> + if (vport->cfg_use_adisc && ((vport->fc_flag & FC_RSCN_MODE) ||
> ((ndlp->nlp_fcp_info & NLP_FCP_2_DEVICE) &&
> - (ndlp->nlp_type & NLP_FCP_TARGET))
s_cont_entry_t *pkt)
> if (sense_len == 0) {
> rsp->status_srb = NULL;
> sp->done(sp, cp->result);
> - } else {
> - WARN_ON_ONCE(true);
> }
> }
>
>
Not that I can speak for firmware documentation, but:
_Host
> *shost)
> {
> @@ -1996,6 +2003,7 @@ static struct fc_function_template qedf_fc_transport_fn
> = {
> .show_host_active_fc4s = 1,
> .show_host_maxframe_size = 1,
>
> + .get_host_port_id = qedf_get_host_port_id,
> .show_host_port_id = 1,
> .show_
device we're using if the transport
options are identical. Although I'm not sure for RDMA; here we don't
necessarily have a host transport address, so we _might_ send the
discovery via the wrong controller in a CMIC enviroment.
- Match the options in nvme-cli, and just discard the event if it
doesn't match. Which is some additional coding in nvme-cli and might ran
afoul if we ever miss events.
I'd go for the second option; after considering the first introduces far
too many conditions rendering debugging impractical.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 247165 (AG München), GF: Felix Imendörffer
drivers/nvme/host/core.c | 21 ++---
> 1 file changed, 10 insertions(+), 11 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
h...@suse.de +49 911 74053 688
end;
> struct scatterlist *sgde = scsi_prot_sglist(cmnd);
>
> if (!_dump_buf_dif) {
> @@ -138,7 +143,12 @@ struct scsi_dif_tuple {
> }
>
> dst = _dump_buf_dif;
> + end = ((char *) dst) + ((1 << PAGE_SHIFT) <&
isk(struct gendisk
> *disk, struct nvme_id_ns *id)
> if (ns->head->disk) {
> nvme_update_disk_info(ns->head->disk, ns, id);
> blk_queue_stack_limits(ns->head->disk->queue, ns->queue);
> + revalidate_disk(ns->head->disk);
>
itation interval (mS) */
> #define FCOE_CTLR_FCF_LIMIT 20 /* max. number of FCF entries */
> #define FCOE_CTLR_VN2VN_LOGIN_LIMIT 3 /* max. VN2VN rport login
> retries */
>
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTe
y\n");
> + FC_LIBFC_DBG("Receiving frames for an lport that "
> + "has not been initialized correctly\n");
> fc_frame_free(fp);
> return;
> }
>
Reviewed-by: Hannes Reinecke
Cheers
On 7/5/19 7:53 PM, Douglas Gilbert wrote:
> On 2019-07-05 3:22 a.m., Hannes Reinecke wrote:
[ .. ]
>> As mentioned, rescan-scsi-bus.sh is keeping references to /proc/scsi as
>> a fall back only, as it's meant to work kernel independent. Per default
>> it'll be us
n before the last request is reached.
>
> Suggested-by: Stefan Hajnoczi
> Signed-off-by: Paolo Bonzini
> ---
> drivers/scsi/virtio_scsi.c | 55 +++---
> 1 file changed, 40 insertions(+), 15 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers
On 7/5/19 9:44 AM, Stefan Hajnoczi wrote:
> On Fri, Jul 05, 2019 at 09:12:37AM +0200, Hannes Reinecke wrote:
>> On 7/4/19 3:19 PM, Paolo Bonzini wrote:
>>> On 19/06/19 12:31, Paolo Bonzini wrote:
>>>>> I'm a bit unsure if 'bd->last' is always set
IO is selected and
> /proc/scsi/sg/allow_dio
> ./doc/sgp_dd.8:mapping to SCSI block devices should be checked with 'cat
> /proc/scsi/scsi'
> ./doc/sg_dd.8:notes this at completion. If direct IO is selected and
> /proc/scsi/sg/allow_dio
> ./doc/sg_dd.8:this at completion. I
q_dd.c
>>
>> That is 6 (not 38) by my count.
>
> Hi Doug,
>
> This is the command I ran:
>
> $ git grep /proc/scsi | wc -l
> 38
>
> I think your query excludes scripts/rescan-scsi-bus.sh.
>
You can ignore rescan-scsi-bus.sh.
It's keeping /proc
?
> Where is the ->commit_rqs() callback invoked?
I don't seem to be able to find it...
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Fe
have been queued with
* queuecommand, when an error is encountered before sending
* the request with SCMD_LAST set.
So it should be somewhere in the error path, probably scsi_error or
something. But I don't seem to be able to find it ...
Cheers,
Hannes
--
Dr. Hannes Reinecke
t; @@ -659,5 +666,6 @@ void nvme_mpath_uninit(struct nvme_ctrl *ctrl)
> {
> kfree(ctrl->ana_log_buf);
> ctrl->ana_log_buf = NULL;
> + ctrl->ana_enabled = false;
> }
>
> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
> inde
On 6/19/19 11:52 AM, Marcos Paulo de Souza wrote:
> On Wed, Jun 19, 2019 at 08:34:56AM +0200, Hannes Reinecke wrote:
>> On 6/19/19 5:35 AM, Martin K. Petersen wrote:
>>>
>>> Marcos,
>>>
>>>> WWID composed from VPD data from device, specifically pag
is part of the same batch?
Aside from it: I think it's a good idea to match the '->last' setting
onto the SCMD_LAST flag; I would even go so far and make this an
independent patch.
Once to above points are cleared, that is.
But if that one is in, why do we need to have the separate 'commit_rqs'
callback?
Can't we let the driver decide to issue a doorbell kick (or whatever the
driver decides to do there)?
If we ensure that the SCMD_LAST flag is always set for the end of a
batch (even if this batch consists only of one request), the driver
simply can evaluate the flag and do its actions.
Why do we need a new callback here?
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
possibilities why a
specific attribute is not present.
So making 'wwid' conditional would actually defeat its very purpose, and
we should leave it blank if not supported.
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.com
ater chips, this
>* area can be read and written by both the host and the sequencer.
>
Indeed trivial.
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.com +49 911 74053 688
rted-by: Thomas Renninger
Signed-off-by: Rafael J. Wysocki
---
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Fel
/sysfs-devices-system-cpu | 18
Documentation/admin-guide/pm/intel_epb.rst | 27 ++
arch/x86/kernel/cpu/intel_epb.c| 93
-
3 files changed, 134 insertions(+), 4 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes
ck(&lport->disc.disc_mutex);
+ return;
+ }
kref_get(&lport->ptp_rdata->kref);
lport->ptp_rdata->ids.port_name = remote_wwpn;
lport->ptp_rdata->ids.node_name = remote_wwnn;
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
On 2/27/19 7:09 AM, YueHaibing wrote:
Friendly ping:
Who can review or take this, please?
Thanks
On 2019/1/30 18:11, YueHaibing wrote:
There is a potential NULL pointer dereference in case
fc_rport_create() fails and returns NULL.
Fixes: 2580064b5ec6 ("scsi: libfc: Replace ->rport_create ca
Lukas Bulwahn
CC: Nick Desaulniers
CC: Nathan Chancellor
CC: Hannes Reinecke
Suggested-by: Johannes Thumshirn
---
[ v2:
- Based on the original patch by Lukas Bulwahn
- Suggestion by Johannes T. [1] required some changes:
+ s/case FIP_ST_VMMP_START/case FIP_ST_V*N*MP_START
+ s
On 2/5/19 4:09 PM, John Garry wrote:
On 05/02/2019 14:52, Keith Busch wrote:
On Tue, Feb 05, 2019 at 05:24:11AM -0800, John Garry wrote:
On 04/02/2019 07:12, Hannes Reinecke wrote:
Hi Hannes,
So, as the user then has to wait for the system to declars 'ready for
CPU remove', wh
On 2/5/19 3:52 PM, Keith Busch wrote:
On Tue, Feb 05, 2019 at 05:24:11AM -0800, John Garry wrote:
On 04/02/2019 07:12, Hannes Reinecke wrote:
Hi Hannes,
So, as the user then has to wait for the system to declars 'ready for
CPU remove', why can't we just disable the SQ and w
On 2/1/19 10:57 PM, Thomas Gleixner wrote:
On Fri, 1 Feb 2019, Hannes Reinecke wrote:
Thing is, if we have _managed_ CPU hotplug (ie if the hardware provides some
means of quiescing the CPU before hotplug) then the whole thing is trivial;
disable SQ and wait for all outstanding commands to
en with todays infrastructure.
And I'm not sure if we can handle surprise CPU hotplug at all, given all
the possible race conditions.
But then I might be wrong.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
s here; maybe I'm totally wrong and
it's already been taken care of.
But if there is no generic mechanism this really is a fit topic for
LSF/MM, as most other drivers would be affected, too.
Cheers,
Hannes
--
Dr. Hannes Reinecke
On 1/28/19 12:06 PM, Johannes Thumshirn wrote:
I'll be moving on to different things in the storage stack and Hannes
agreed to take over FCoE.
Cc: Hannes Reinecke
Signed-off-by: Johannes Thumshirn
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
On 1/26/19 11:39 AM, Greg Kroah-Hartman wrote:
On Sat, Jan 26, 2019 at 11:26:47AM +0100, Hannes Reinecke wrote:
On 1/22/19 3:27 PM, Greg Kroah-Hartman wrote:
We are trying to get rid of BUS_ATTR() and the usage of that in the fcoe
driver can be trivially converted to use BUS_ATTR_WO(), so use
On 1/22/19 3:27 PM, Greg Kroah-Hartman wrote:
We are trying to get rid of BUS_ATTR() and the usage of that in the fcoe
driver can be trivially converted to use BUS_ATTR_WO(), so use that
instead.
Cc: Johannes Thumshirn
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Signed-off-by: Greg Kr
-855,7 +855,6 @@ ssize_t fcoe_ctlr_destroy_store(struct bus_type *bus,
mutex_unlock(&ft_mutex);
return rc;
}
-EXPORT_SYMBOL(fcoe_ctlr_destroy_store);
/**
* fcoe_transport_create() - Create a fcoe interface
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke
u want ...
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
t;Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/aic7xxx/aic79xx_core.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
Sorry, I thought I'd done so already.
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Re
On 12/21/18 4:29 PM, James Bottomley wrote:
[scsi list cc added]
On Fri, 2018-12-21 at 08:54 +0100, Greg Kroah-Hartman wrote:
We are trying to get rid of BUS_ATTR() and the usage of that in the
fcoe driver can be trivially converted to use BUS_ATTR_WO(), so use
that instead.
At the same time re
.
Addresses-Coverity-ID: 1465234 ("Missing break in switch")
Addresses-Coverity-ID: 1465238 ("Missing break in switch")
Addresses-Coverity-ID: 1465242 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/myrb.c | 3 +++
1 file changed, 3 inser
ctls with sysfs interface
Cc: Sergey Senozhatsky
Cc: Hannes Reinecke
Tested-by: Howard Chen
Signed-off-by: Minchan Kim
---
drivers/block/zram/zram_drv.c | 26 ++
1 file changed, 6 insertions(+), 20 deletions(-)
Actually, I have a similar patch for NVMe in older revi
On 10/7/18 11:04 AM, Daniel Vetter wrote:
> On Sat, Oct 6, 2018 at 11:36 PM James Bottomley
> wrote:
>>
>> From 4a614e9440148894207bef5bf69e74071baceb3b Mon Sep 17 00:00:00 2001
>> From: James Bottomley
>> Date: Sat, 6 Oct 2018 14:21:56 -0700
>> Subject: [PATCH 1/2] code-of-conduct: Fix the ambig
rport_recv_plogi_req()
>> (presumably it is being inlined) and this looks like an actual bug :-(
>
> This warning now appears after the merge of the scsi tree.
>
I have send a new round of patches to the scsi mailing list (cf
'libfc/fcoe: disc_mutex fixes') which address
On Mon, 28 May 2018 23:02:36 -0400
Mike Snitzer wrote:
> On Mon, May 28 2018 at 9:19pm -0400,
> Martin K. Petersen wrote:
>
> >
> > Mike,
> >
> > I understand and appreciate your position but I still don't think
> > the arguments for enabling DM multipath are sufficiently
> > compelling. The
b ("scsi: scsi: Export blacklist flags to sysfs")
>
> Cc: Hannes Reinecke
> Signed-off-by: Randy Dunlap
> ---
> drivers/scsi/Makefile |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-4.17-rc4.orig/drivers/scsi/Makefile
> +++ linux-4.1
f_ctrl_options *opts)
> }
> spin_unlock_irqrestore(&nvme_fc_lock, flags);
>
> + pr_warn("%s: %s - %s combination not found\n",
> + __func__, opts->traddr, opts->host_traddr);
> return ERR_PTR(-ENOENT);
> }
>
>
Revie
cmd->result |= SAM_STAT_CHECK_CONDITION << 1;
> + cmd->result |= SAM_STAT_CHECK_CONDITION;
> return 1;
> }
>
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networki
f (!name || strlen(name) == 0)
> + return NULL;
> +
> dh = __scsi_dh_lookup(name);
> if (!dh) {
> request_module("scsi_dh_%s", name);
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
On 03/15/2018 10:42 AM, David Howells wrote:
> Do we have anything left that still implements NOMMU?
>
RISC-V ?
(evil grin :-)
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE
ers/scsi/device_handler/scsi_dh_alua.c | 8
> drivers/scsi/device_handler/scsi_dh_emc.c | 2 +-
> drivers/scsi/device_handler/scsi_dh_rdac.c | 2 +-
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke
static int phy_down_v3_hw(int phy_no, struct hisi_hba
> *hisi_hba)
> hisi_sas_phy_write32(hisi_hba, phy_no, CHL_INT0, CHL_INT0_NOT_RDY_MSK);
> hisi_sas_phy_write32(hisi_hba, phy_no, PHYCTRL_NOT_RDY_MSK, 0);
>
> - return 0;
> + return I
abort task will
> be executed only when the retry process finished.
>
Hmm. That sounds weird.
I would have expected that a link retrain will force a device reset,
after which no tasks should be active on the target.
Consequently the succeeding abort task will be a no-op.
Care to clarify?
Che
[ 70.440907] R10: ffdf R11: 0293 R12:
> 55867dd47410
> [ 70.441199] R13: R14: 0001 R15:
> 7f6d4c03be00
> [ 70.441486] Code: fe ff ff 44 0f b6 bd 7f ff ff ff 80 7d ab 00 79
> 05 45 84 ff 74 7b 48 83 c4 78 5b 41 5c 41 5d 4
_id=%u, result=%llu, retries=%u, flags=0x%x,
> status=%u",
> + __entry->cid,
> + (unsigned long long)le64_to_cpu(__entry->result),
> + __entry->retries, __entry->flags, __entry->status)
> +
mnd));
> + ),
> +
> + TP_printk("nsid=%u, command_id=%u, flags=0x%x, metadata=0x%llx,
> cmd=(%s %s)",
> + le32_to_cpu(__entry->nsid), __entry->cid, __entry->flags,
> + (unsigned long long) le64_to_cpu(__entry->meta
uest);
>
>
Hmm. Why do we need to call blk_mq_map_queue() here?
Is there a chance that we end up with a _different_ hctx on completion
than that one used for submission?
If not, why can't we just keep a pointer to the hctx in struct request?
Cheers,
Hannes
--
Dr. Hannes Reinecke
On 12/15/2017 01:18 PM, Hannes Reinecke wrote:
> On 12/08/2017 10:42 AM, Jason Yan wrote:
>> If the PHY burst too many events, we will alloc a lot of events for the
>> worker. This may leads to memory exhaustion.
>>
>> Dan Williams suggested to shut down the PH
sas_phy = container_of(port->phy_list.next, struct asd_sas_phy,
> + port_phy_el);
> + ha->notify_port_event(sas_phy, PORTE_BROADCAST_RCVD);
> }
> mutex_unlock(&ha->disco_mutex);
> }
>
Reviewed-by: Hannes Reinec
sas/sas_internal.h | 1 +
> drivers/scsi/libsas/sas_port.c | 3 +++
> include/scsi/libsas.h | 3 +--
> include/scsi/scsi_transport_sas.h | 1 +
> 7 files changed, 27 insertions(+), 22 deletions(-)
>
Signed-off-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hann
sas_porte_broadcast_rcvd(struct work_struct *work)
>
> SAS_DPRINTK("broadcast received: %d\n", prim);
> sas_discover_event(phy->port, DISCE_REVALIDATE_DOMAIN);
> +
> + if (phy->port)
> + flush_workqueue(phy->port->ha->d
gt; CC: Dan Williams
> Signed-off-by: Jason Yan
> ---
> drivers/scsi/libsas/sas_discover.c | 2 +-
> drivers/scsi/libsas/sas_event.c| 6 +++---
> drivers/scsi/libsas/sas_init.c | 18 ++
> include/scsi/libsas.h | 3 +++
> 4 files changed, 25 inse
On 12/08/2017 10:42 AM, Jason Yan wrote:
> Add a sysfs attr that LLDD can configure it for every host. We made
> a example in hisi_sas. Other LLDDs using libsas can implement it if
> they want.
>
> Suggested-by: Hannes Reinecke
> Signed-off-by: Jason Yan
> CC: John
024 events is a bit arbitrary; one might want to
adjust that).
Couldn't you allocate two static events always (for shutdown and signal
loss), and then use a fixed pool?
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
++-
> drivers/scsi/libsas/sas_init.c | 27 --
> drivers/scsi/libsas/sas_internal.h | 6
> drivers/scsi/libsas/sas_phy.c | 44 +--
> drivers/scsi/libsas/sas_port.c | 18 +-
> include/scsi/libsas.h
90] [c03a03c4] sysfs_kf_write+0x64/0xa0
> [c07792d47cb0] [c039f1b0] kernfs_fop_write+0x170/0x250
> [c07792d47d00] [c02fd370] __vfs_write+0x40/0x200
> [c07792d47d90] [c02fd748] vfs_write+0xc8/0x240
> [c07792d47de0] [c02fda80] SyS_w
ve been rather invasive and required reworking the
> entire initialization sequence.
>
> Fixes: 45349821ab3a ("scsi: bfa: fix access to bfad_im_port_s")
> Signed-off-by: Arnd Bergmann
> ---
> drivers/scsi/bfa/bfad_bsg.c | 4 ++--
> drivers/scsi/bfa/bfad_im.c | 6 --
> drivers/scsi/bfa/bfad_im.h | 10 ++
> 3 files changed, 16 insertions(+), 4 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
continue;
>
> list_for_each_entry(rport, &lport->endp_list, endp_list) {
We need both, 'laddr.nn' and 'laddr.pn'. So this statement is wrong.
You probably need something like
if (!laddr.nn || !laddr.pn || )
Cheers,
Hannes
--
Dr. Hannes
st(job));
> + struct Scsi_Host *shost = fc_bsg_to_shost(job);
> + struct bfad_im_port_s *im_port = shost->hostdata[0];
> struct bfad_s *bfad = im_port->bfad;
> bfa_bsg_fcpt_t *bsg_fcpt;
> struct bfad_fcxp*drv_fcxp;
>
Reviewed-by: Hannes Reinecke
lt; nvecs; curvec++)
> cpumask_copy(masks + curvec, irq_default_affinity);
> - free_node_to_present_cpumask(node_to_present_cpumask);
> + free_node_to_possible_cpumask(node_to_possible_cpumask);
> out:
> free_cpumask_var(nmsk);
> return masks;
> @@ -214,7
submit a revert request?
>
I'll be checking what's going on there.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
As per recommendation from Linus we should be using a distinct
type for blacklist flags.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_devinfo.c | 18 -
drivers/scsi/scsi_priv.h| 15 +++---
drivers/scsi/scsi_scan.c| 2 +-
include/scsi/scsi_device.h | 4
SI merge this merge window, and it
> seems to still revert cleanly.
>
> So I do suspect that by now we should just revert that commit. It's
> not clear why that state attribute should be pollable, and the new
> code is clearly very much buggy.
>
> Hannes, Martin?
>
Seeing
On 11/03/2017 04:38 AM, Gavin Guo wrote:
> On Sat, Oct 28, 2017 at 11:35 AM, Gavin Guo wrote:
>> On Fri, Oct 27, 2017 at 10:53 PM, Hannes Reinecke wrote:
>>> On 10/27/2017 04:02 PM, Gavin Guo wrote:
>>>> Hi Hannes,
>>>>
>>>> Thank you for l
queue ID to '0' if an invalid CPU was found.
With that the driver should be able to ensure that no new I/O will be
submitted which will hit the dead CPU, so with a bit of luck this might
already solve the problem.
Alternatively I could resurrect my patchset converting the driver to
p device hotplug for VMWare ESXi', which I guess is
already scheduled for inclusion in 4.14.
Anything else I could help you with?
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LIN
ignore
> index c89ae9a04399..e2956741fbd1 100644
> --- a/drivers/scsi/.gitignore
> +++ b/drivers/scsi/.gitignore
> @@ -1 +1,2 @@
> 53c700_d.h
> +scsi_devinfo_tbl.c
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networkin
On 10/17/2017 03:29 AM, Ming Lei wrote:
> On Mon, Oct 16, 2017 at 01:30:09PM +0200, Hannes Reinecke wrote:
>> On 10/13/2017 07:29 PM, Ming Lei wrote:
>>> On Fri, Oct 13, 2017 at 05:08:52PM +, Bart Van Assche wrote:
>>>> On Sat, 2017-10-14 at 00:45 +0800, Ming L
st->can_queue value?
>
> ->can_queue is size of the whole tag space shared by all LUNs, looks it isn't
> reasonable to increase cmd_per_lun to .can_queue.
>
'3' is just a starting point; later on it'll be adjusted via
scsi_change_depth().
Looks like it's not
bnx2i: make bound ep check common")
> Cc: Lee Duncan
> Cc: Hannes Reinecke
> Cc: Bart Van Assche
> Cc: Chris Leech
> ---
> drivers/scsi/libiscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/
nel threads, which probably should be stopped, too, when
going into suspend. After all, MD might be doing on of it's internal
operations (eg resync) at that time, which will generate quite some I/O.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...
issue with the mptsas driver, who originally assumed that no
system will have direct-attached SAS devices.
VMWare chose to implement exactly that, so the hotplug detection logic
is flawed here.
I'll be sending a patch.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage
port_fc.c
> @@ -3328,6 +3328,9 @@ int fc_block_scsi_eh(struct scsi_cmnd *cmnd)
> {
> struct fc_rport *rport = starget_to_rport(scsi_target(cmnd->device));
>
> + if (WARN_ON_ONCE(!rport))
> + return 0;
> +
> return fc_block_rport(rport);
> }
&g
On 09/25/2017 09:09 AM, Sagi Grimberg wrote:
>
>
> On 25/09/17 08:59, Hannes Reinecke wrote:
>> On 09/25/2017 07:37 AM, Sagi Grimberg wrote:
>>>
>>>> So why exposing it then in the first time? I know you don't want
>>>> dm-mpath in
>>
alues (eg path up, path down, path blocked), and have
NVMf translating the internal state into that.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
On 09/21/2017 01:27 AM, Kees Cook wrote:
> stat_timer only ever assigns the same function and data, so consolidate to
> a setup_timer() call and drop everything else used to pass things around.
>
> reset_timer is unused; remove it.
>
> Cc: Hannes Reinecke
> Cc: "J
; [...] R13: 7f0bd751f9c0 R14: 7f0bd751f700 R15:
>> ---
>>
>> Thanks,
>> Yasuaki Ishimatsu
>>
This indeed looks like a problem.
We're going to great lengths to submit and complete I/O on the same CPU,
so if the CPU is offlined while I/O is in
101 - 200 of 1007 matches
Mail list logo
