request defines so as
to not break the kernel ABI in case someone has been using the old
request defines.
Fixes: f6ddd094f579 ("virt: Add vboxguest driver for Virtual Box Guest
integration UAPI")
Cc: sta...@vger.kernel.org
Reviewed-by: Arnd Bergmann
Signed-off-by: Hans de Goede
---
dr
://bugzilla.redhat.com/show_bug.cgi?id=1789545
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 2 ++
include/uapi/linux/vbox_vmmdev_types.h | 3 +++
2 files changed, 5 insertions(+)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers/virt/vboxguest
The session lock is a mutex, not a spinlock, fix the comments to match.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers/virt/vboxguest
Rename guest_caps[_tracker] struct members to set_guest_caps[_tracker]
this is a preparation patch for adding support for the
VBGL_IOCTL_GUEST_CAPS_ACQUIRE ioctl.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 20 ++--
drivers/virt/vboxguest
Add vbg_set_host_capabilities() helper function, this is a preparation
patch for adding support for the VBGL_IOCTL_GUEST_CAPS_ACQUIRE ioctl.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 79 ++---
1 file changed, 46 insertions(+), 33 deletions
=1789545
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 163 +++-
drivers/virt/vboxguest/vboxguest_core.h | 14 ++
include/uapi/linux/vboxguest.h | 24
3 files changed, 200 insertions(+), 1 deletion(-)
diff --git a/drivers/virt
request defines so as
to not break the kernel ABI in case someone has been using the old
request defines.
Fixes: f6ddd094f579 ("virt: Add vboxguest driver for Virtual Box Guest
integration UAPI")
Cc: sta...@vger.kernel.org
Reviewed-by: Arnd Bergmann
Signed-off-by: Hans de Goede
---
dr
Every now and then upstream adds new ioctls without notifying us,
log unknown ioctl requests as an error to catch these.
Signed-off-by: Hans de Goede
---
Changes in v2:
- Rate-limit the error logging to avoid userspace potentially DOS-ing the log
---
drivers/virt/vboxguest/vboxguest_core.c | 2
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 2 +-
drivers/virt/vboxguest/vmmdev.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers/virt/vboxguest/vboxguest_core.c
index 8fab04e76c14..18
Hi All,
Here is v2 of my vboxguest driver patch-set adding support for the
new VBG_IOCTL_ACQUIRE_GUEST_CAPABILITIES ioctl which is necessary to
make guest resizing work with the new(ish) VMSVGA emulation in vbox +
some other small fixes.
The only change since v2 is rate-limiting the
Hi,
Thank you for the review and sorry for being slow with
responding.
On 5/20/20 11:47 PM, Arnd Bergmann wrote:
On Wed, May 20, 2020 at 9:55 PM Hans de Goede wrote:
Add support for the new VBG_IOCTL_ACQUIRE_GUEST_CAPABILITIES ioctl, this
is necessary for automatic resizing of the guest
.
Which GPIO is attached to the LED is usually not described in the ACPI
tables, so this driver contains per-system info about the GPIO inside the
driver. This means that this driver only works on systems the driver knows
about.
Signed-off-by: Hans de Goede
---
Changes in v2:
- Rebase on top
Hi Bastien,
On 6/19/20 12:50 PM, Bastien Nocera wrote:
On Thu, 2020-06-18 at 11:42 +0200, Greg Kroah-Hartman wrote:
The USB core has a quirk flag to ignore specific endpoints, so rename
it
to be more obvious what this quirk does.
Cc: Johan Hovold
Cc: Alan Stern
Cc: Richard Dodd
Cc: Hans de
Hi,
On 6/19/20 6:16 AM, Kai-Heng Feng wrote:
Hi,
On Jun 18, 2020, at 23:28, Hans de Goede wrote:
Hi,
On 6/18/20 4:55 PM, Kai-Heng Feng wrote:
Many laptops can be woken up from Suspend-to-Idle by touchpad. This is
also the default behavior on other OSes.
So let's enable the wakeup support
Hi,
On 6/18/20 4:55 PM, Kai-Heng Feng wrote:
Many laptops can be woken up from Suspend-to-Idle by touchpad. This is
also the default behavior on other OSes.
So let's enable the wakeup support if the system defaults to
Suspend-to-Idle.
I have been debugging a spurious wakeup issue on an Asus
:
Reviewed-by: Hans de Goede
Regards,
Hans
Documentation/input/input-programming.rst | 40 +++
1 file changed, 40 insertions(+)
diff --git a/Documentation/input/input-programming.rst
b/Documentation/input/input-programming.rst
index 45a4c6e05e39..7432315cc829 100644
Hi,
On 6/16/20 7:29 PM, Andrzej Pietrasiewicz wrote:
Document inhibiting input devices and its relation to being
a wakeup source.
Signed-off-by: Andrzej Pietrasiewicz
---
@Hans, @Dmitry,
My fist attempt at documenting inhibiting. Kindly look at it to see if I
haven't got anything
wrong.
Hi,
On 6/15/20 10:49 PM, Federico Ricchiuto wrote:
The Mediacom FlexBook edge13 uses the SIPODEV SP1064 touchpad, which does
not supply descriptors, so it has to be added to the override list.
Signed-off-by: Federico Ricchiuto
It looks like you copied and pasted part of the commit message
Hi,
On 6/10/20 3:41 PM, Andrzej Pietrasiewicz wrote:
Hi Hans,
W dniu 10.06.2020 o 15:21, Hans de Goede pisze:
Hi,
On 6/10/20 3:12 PM, Andrzej Pietrasiewicz wrote:
Hi All,
W dniu 10.06.2020 o 12:38, Rafael J. Wysocki pisze:
On Wed, Jun 10, 2020 at 11:50 AM Hans de Goede wrote:
Hi All
appropriate mutex
ACPI: button: Use input_device_enabled() helper
iio: adc: exynos: Use input_device_enabled()
platform/x86: thinkpad_acpi: Use input_device_enabled()
Patrik Fimml (1):
Input: Add "inhibited" property
The entire series looks good to me:
Acked-by: Hans de Goede
Hi,
On 6/10/20 8:28 PM, Dmitry Torokhov wrote:
On Wed, Jun 10, 2020 at 12:38:30PM +0200, Rafael J. Wysocki wrote:
On Wed, Jun 10, 2020 at 11:50 AM Hans de Goede wrote:
Hi All,
On 6/8/20 1:22 PM, Andrzej Pietrasiewicz wrote:
This is a quick respin of v3, with just two small changes, please
Hi,
On 6/10/20 12:38 PM, Rafael J. Wysocki wrote:
On Wed, Jun 10, 2020 at 11:50 AM Hans de Goede wrote:
A different, but related issue is how to make devices actually use the
new inhibit support on the builtin keyboard + touchpad when say the lid
is closed. Arguably this is an userspace
Hi,
On 6/10/20 3:12 PM, Andrzej Pietrasiewicz wrote:
Hi All,
W dniu 10.06.2020 o 12:38, Rafael J. Wysocki pisze:
On Wed, Jun 10, 2020 at 11:50 AM Hans de Goede wrote:
Hi All,
On 6/8/20 1:22 PM, Andrzej Pietrasiewicz wrote:
This is a quick respin of v3, with just two small changes, please
Hi All,
On 6/8/20 1:22 PM, Andrzej Pietrasiewicz wrote:
This is a quick respin of v3, with just two small changes, please see
the changelog below.
Userspace might want to implement a policy to temporarily disregard input
from certain devices.
An example use case is a convertible laptop, whose
Hi Sebastian,
On 6/9/20 6:45 PM, Sebastian Reichel wrote:
Hi,
On Tue, Jun 09, 2020 at 05:49:38PM +0200, Pali Rohár wrote:
On Monday 08 June 2020 20:36:58 mario.limoncie...@dell.com wrote:
Can you please comment here how you would like to see events like this should
come
through to
Hi,
On 6/9/20 5:36 PM, mario.limoncie...@dell.com wrote:
Loop linux-input mailing list and trim to the relevant conversation.
Can you please comment here how you would like to see events like this
should come
through to userspace?
* Wrong power adapter (you have X and should have Y)
* You
Hi,
On 6/8/20 10:36 PM, mario.limoncie...@dell.com wrote:
-Original Message-
From: Y Paritcher
Sent: Monday, June 8, 2020 3:13 PM
To: Limonciello, Mario
Cc: linux-kernel@vger.kernel.org; platform-driver-...@vger.kernel.org;
mj...@srcf.ucam.org; p...@kernel.org
Subject: Re: [PATCH 2/3]
ction of power resources
lists")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=205057
Link:
https://lore.kernel.org/linux-acpi/20200603194659.185757-1-hdego...@redhat.com/
Reported-by: Hans de Goede
Cc: 3.10+ # 3.10+
Signed-off-by: Rafael J. Wysocki
Thank you.
I've tested this and I can co
Hi,
On 6/5/20 7:33 PM, Andrzej Pietrasiewicz wrote:
From: Patrik Fimml
Userspace might want to implement a policy to temporarily disregard input
from certain devices, including not treating them as wakeup sources.
An example use case is a laptop, whose keyboard can be folded under the
screen
Add minimum values for the x and y axis, correct the max value for the
x-axis and add support for the capacitive home-button these tablets have.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/touchscreen_dmi.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
Hi,
On 5/30/20 4:56 PM, Andy Shevchenko wrote:
On Sat, May 9, 2020 at 4:07 PM Hans de Goede wrote:
Many Bay Trail and Cherry Trail devices come with a camera attached to
Intel's Image Signal Processor. Linux currently does not have a driver for
these, so they do not work as a camera.
Some
WMI calls,
the size needs to be expanded to fix the problem.
Signed-off-by: Chris Chiu
Thank you, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/platform/x86/asus-wmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/platform/x86/asus-wmi
Hi,
On 5/21/20 12:33 PM, Chris Chiu wrote:
Hi,
I have the ASUS new laptop UX325JA and most of the media keys are
not working even with the latest kernel (5.7.0-rc5+). Looking into the
dmesg log, the ASUS WMI driver fails to load because of
[7.827241] asus-nb-wmi: probe of asus-nb-wmi
The session lock is a mutex, not a spinlock, fix the comments to match.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers/virt/vboxguest
://bugzilla.redhat.com/show_bug.cgi?id=1789545
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 2 ++
include/uapi/linux/vbox_vmmdev_types.h | 3 +++
2 files changed, 5 insertions(+)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers/virt/vboxguest
Every now and then upstream adds new ioctls without notifying us,
log unknown ioctl requests as an error to catch these.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virt/vboxguest
=1789545
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 163 +++-
drivers/virt/vboxguest/vboxguest_core.h | 14 ++
include/uapi/linux/vboxguest.h | 24
3 files changed, 200 insertions(+), 1 deletion(-)
diff --git a/drivers/virt
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 2 +-
drivers/virt/vboxguest/vmmdev.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers/virt/vboxguest/vboxguest_core.c
index 8fab04e76c14..18
Add vbg_set_host_capabilities() helper function, this is a preparation
patch for adding support for the VBGL_IOCTL_GUEST_CAPS_ACQUIRE ioctl.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 79 ++---
1 file changed, 46 insertions(+), 33 deletions
request defines so as
to not break the kernel ABI in case someone has been using the old
request defines.
Fixes: f6ddd094f579 ("virt: Add vboxguest driver for Virtual Box Guest
integration UAPI")
Cc: sta...@vger.kernel.org
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_co
Rename guest_caps[_tracker] struct members to set_guest_caps[_tracker]
this is a preparation patch for adding support for the
VBGL_IOCTL_GUEST_CAPS_ACQUIRE ioctl.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 20 ++--
drivers/virt/vboxguest
of the model for which
the chassis-type check was added.
Note this also fixes the current version of the code no longer checking
if dmi_get_system_info(DMI_CHASSIS_TYPE) returns NULL.
Fixes: 1fac39fd0316 ("platform/x86: intel-vbtn: Also handle tablet-mode switch
on "Detachable" an
key with type 0x0011 and code 0xfff3 pressed
Note SW_TABLET_MODE is already reported through the intel_vbtn driver on
this and other Dell devices, so dell_wmi should not report this too,
to avoid duplicate events.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/dell-wmi.c | 10
you, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/platform/x86/touchscreen_dmi.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/platform/x86/touchscreen_dmi.c
b/drivers/platform/x86/touchscreen_dmi.c
index 6ec8923dec1a..d87315892458
Hi,
On 5/11/20 9:20 PM, Jonathan Cameron wrote:
On Mon, 4 May 2020 14:55:50 +0200
Hans de Goede wrote:
On ACPI based systems the CPLM3218 ACPI device node describing the
CM3218[1] sensor typically will have some extra tables with register
init values for initializing the sensor
is completely unchanged.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/asus-wmi.c | 78 -
1 file changed, 39 insertions(+), 39 deletions(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index e705ae66c083..25ec821dae21
and T200TA.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/asus-wmi.c| 24 --
include/linux/platform_data/x86/asus-wmi.h | 3 +++
2 files changed, 25 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index
message every time the charger is plugged-in:
[ 79.639548] asus_wmi: Unknown key 79 pressed
Signed-off-by: Hans de Goede
---
drivers/platform/x86/asus-nb-wmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b/drivers/platform/x86/asus-nb-wmi.c
index
-off-by: Hans de Goede
---
drivers/platform/x86/intel-vbtn.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/intel-vbtn.c
b/drivers/platform/x86/intel-vbtn.c
index 29984154f8e4..ef92c1c3adbd 100644
--- a/drivers/platform/x86/intel-vbtn.c
+++ b/drivers
This is a preparation patch for calling detect_tablet_mode() from
intel_vbtn_input_setup() without needing a forward declaration.
Note this commit makes no functional changes, the moved block of code
is completely unchanged.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/intel-vbtn.c
Hi,
On 5/10/20 11:48 AM, Jonathan Cameron wrote:
On Mon, 4 May 2020 14:55:41 +0200
Hans de Goede wrote:
Switch to the new style i2c-driver probe_new probe function and drop the
unnecessary i2c_device_id table (we do not have any old style board files
using this).
This is a preparation
.
Which GPIO is attached to the LED is usually not described in the ACPI
tables, so this driver contains per-system info about the GPIO inside the
driver. This means that this driver only works on systems the driver knows
about.
Signed-off-by: Hans de Goede
---
MAINTAINERS
cklist, so that the Asus WMI driver can be used on these
models to report their tablet-mode.
Note, not calling INIT is also not an option, because then we will not
receive events when the tablet-mode changes. So the LED issue will need
to be fixed somewhere else entirely.
Signed-off-by: Han
Hi,
On 5/9/20 2:23 PM, Andy Shevchenko wrote:
On Fri, May 8, 2020 at 11:56 PM Andy Shevchenko
wrote:
On Fri, May 8, 2020 at 10:54 PM Hans de Goede wrote:
On 4/23/20 12:05 AM, Hans de Goede wrote:
Andy, Darren, I see that you have already added this to the for-next
branch of linux
Hi,
On 4/23/20 12:05 AM, Hans de Goede wrote:
asus-nb-wmi does not add any extra functionality on these Asus
Transformer books. They have detachable keyboards, so the hotkeys are
send through a HID device (and handled by the hid-asus driver) and also
the rfkill functionality is not used
Hi,
On 5/5/20 4:27 PM, Andy Shevchenko wrote:
On Tue, May 5, 2020 at 5:22 PM wrote:
-Original Message-
From: platform-driver-x86-ow...@vger.kernel.org On Behalf Of Hans de Goede
Sent: Tuesday, May 5, 2020 4:06 AM
To: Limonciello, Mario; dvh...@infradead.org; a...@infradead.org
Cc
Hi,
On 5/4/20 5:37 PM, mario.limoncie...@dell.com wrote:
-Original Message-
From: Hans de Goede
Sent: Saturday, May 2, 2020 1:30 PM
To: Darren Hart; Andy Shevchenko; Limonciello, Mario
Cc: Hans de Goede; linux-a...@vger.kernel.org; platform-driver-
x...@vger.kernel.org; linux-kernel
Hi,
On 5/4/20 8:20 PM, Randy Dunlap wrote:
Hi,
Usually you need to send patches to a maintainer who could then
merge/apply them.
From a code point-of-view this looks good to me.
Andrew, if you can resend this to the proper folks (including me)
with a proper Signed-off-by (*), then this
with the CM3218 variant of the light sensor.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
Changes in v4:
- Add a cm32181_chip_info structure and use that to store the various
sensor-model specific values
---
drivers/iio/light/cm32181.c | 67 ++---
1
Make lux_per_bit and lux_per_bit_base_it settings stored in struct
cm32181_chip instead of a hardcoded (defined) values.
This is a preparation patch for reading some ACPI tables which specify
a device specific lux_per_bit value.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
Fix integartion time typo and while at it improve the comment with
the typo a bit in general.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
drivers/iio/light/cm32181.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/light/cm32181.c b/drivers/iio
, but the changes
from this newer version never made it upstream.
This was tested on the following models: Acer Switch 10 SW5-012 (CM32181)
Asus T100TA (CM3218), Asus T100CHI (CM3218) and HP X2 10-n000nd (CM32181).
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
Changes in v2:
- Factor out
i2c_get_clientdata()
or dev_get_drvdata() anywhere.
3. Add a dev helper variable and use it in various places instead of
>dev.
Signed-off-by: Hans de Goede
---
Changes in v3:
- This is a new patch in v3 of this patch-set
---
drivers/iio/light/cm32181.c | 20 +++-
1 file changed, 7 inserti
This is a preparation patch for reading some ACPI tables which give
init values for multiple registers.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
Changes in v2:
- Use unsigned long for init_regs_bitmap
- Use for_each_set_bit()
---
drivers/iio/light/cm32181.c | 14
of the light sensor.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
drivers/iio/light/cm32181.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
index 91f83f9b9ea3..e7dc3276d800 100644
ent for the actual I2C address and
use that client to communicate with the sensor.
Signed-off-by: Hans de Goede
---
Changes in v3:
- Create and use a dummy client instead of relying on i2c-multi-instantiate
to create 2 separate clients for the 2 I2C resources
Changes in v2
- s/i2c_client-s
, as the values in the ACPI tables also use
1/10th units.
This units change means that our intermediate values in cm32181_get_lux()
may get quite big, change the type of the lux variable to a u64 to
deal with this.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
drivers/iio/light/cm32181
Add support for ACPI enumeration, this has been tested on a HP
HP Pavilion x2 Detachable 10 (Bay Trail model).
Signed-off-by: Hans de Goede
---
Changes in v3:
- This is a new patch in v3 of this patch-set
---
drivers/iio/light/cm32181.c | 9 +
1 file changed, 9 insertions(+)
diff --git
Switch to the new style i2c-driver probe_new probe function and drop the
unnecessary i2c_device_id table (we do not have any old style board files
using this).
This is a preparation patch for adding ACPI binding support.
Signed-off-by: Hans de Goede
---
Changes in v4:
- Set indio_dev->n
good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/i2c/busses/i2c-cht-wc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
index 35e55feda763..343ae5754e6e 100644
--- a/drivers/i2c/busses
Hi,
On 5/3/20 1:22 PM, Jonathan Cameron wrote:
On Tue, 28 Apr 2020 19:29:22 +0200
Hans de Goede wrote:
On ACPI based systems the CPLM3218 ACPI device node describing the
CM3218[1] sensor typically will have some extra tables with register
init values for initializing the sensor
Hi,
On 5/3/20 1:04 PM, Jonathan Cameron wrote:
On Tue, 28 Apr 2020 19:29:18 +0200
Hans de Goede wrote:
Some ACPI systems list 2 I2C resources for the CM3218 sensor. On these
systems the first I2cSerialBus ACPI-resource points to the SMBus Alert
Response Address (ARA, 0x0c) and the second
Hi,
On 5/3/20 12:59 PM, Jonathan Cameron wrote:
On Tue, 28 Apr 2020 19:29:16 +0200
Hans de Goede wrote:
Add support for the CM3218 which is an older version of the
CM32181.
This is based on a newer version of cm32181.c, with a copyright of:
* Copyright (C) 2014 Capella Microsystems Inc
Hi,
On 5/3/20 12:54 PM, Jonathan Cameron wrote:
On Tue, 28 Apr 2020 19:29:13 +0200
Hans de Goede wrote:
Switch to the new style i2c-driver probe_new probe function and drop the
unnecessary i2c_device_id table (we do not have any old style board files
using this).
This is a preparation patch
Hi All,
Here is a series of fixes, mostly aimed at fixing commit: de9647efeaa9
("platform/x86: intel-vbtn: Only activate tablet mode switch on 2-in-1's")
causing the driver to not bind on some devices where it could and
should report SW_TABLET_MODE.
The last commit makes the driver also work on
Use acpi_evaluate_integer() instead of open-coding it.
This is a preparation patch for adding a intel_vbtn_has_switches()
helper function.
Fixes: de9647efeaa9 ("platform/x86: intel-vbtn: Only activate tablet mode
switch on 2-in-1's")
Signed-off-by: Hans de Goede
---
drivers/platform
).
Fixes: de9647efeaa9 ("platform/x86: intel-vbtn: Only activate tablet mode
switch on 2-in-1's")
Signed-off-by: Hans de Goede
---
drivers/platform/x86/intel-vbtn.c | 28 +---
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/intel
there are both no buttons and
no switches. Also only report the buttons being present to userspace if
the has_buttons check has succeeded.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/intel-vbtn.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git
de report on the Dell XPS 9360 laptop. To the best of my knowledge
that laptop is using a chassis-type of 9 / "Laptop", so after this commit
we still ignore the tablet-switch for that chassis-type.
Fixes: de9647efeaa9 ("platform/x86: intel-vbtn: Only activate tablet mode
swit
e presence of this switch for certain heuristics.
Fixes: de9647efeaa9 ("platform/x86: intel-vbtn: Only activate tablet mode
switch on 2-in-1's")
Signed-off-by: Hans de Goede
---
drivers/platform/x86/intel-vbtn.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
of the light sensor.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
drivers/iio/light/cm32181.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
index 5ca8bbf6667c..6fc0a753c499 100644
Make lux_per_bit and lux_per_bit_base_it settings stored in struct
cm32181_chip instead of a hardcoded (defined) values.
This is a preparation patch for reading some ACPI tables which specify
a device specific lux_per_bit value.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
Fix integartion time typo and while at it improve the comment with
the typo a bit in general.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
drivers/iio/light/cm32181.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/light/cm32181.c b/drivers/iio
i2c_get_clientdata()
or dev_get_drvdata() anywhere.
3. Add a dev helper variable and use it in various places instead of
>dev.
Signed-off-by: Hans de Goede
---
Changes in v3:
- This is a new patch in v3 of this patch-set
---
drivers/iio/light/cm32181.c | 22 --
1 file changed
with the CM3218 variant of the light sensor.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
drivers/iio/light/cm32181.c | 48 +++--
1 file changed, 36 insertions(+), 12 deletions(-)
diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
This is a preparation patch for reading some ACPI tables which give
init values for multiple registers.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
Changes in v2:
- Use unsigned long for init_regs_bitmap
- Use for_each_set_bit()
---
drivers/iio/light/cm32181.c | 14
, as the values in the ACPI tables also use
1/10th units.
This units change means that our intermediate values in cm32181_get_lux()
may get quite big, change the type of the lux variable to a u64 to
deal with this.
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
drivers/iio/light/cm32181
Switch to the new style i2c-driver probe_new probe function and drop the
unnecessary i2c_device_id table (we do not have any old style board files
using this).
This is a preparation patch for adding ACPI binding support.
Signed-off-by: Hans de Goede
---
Changes in v3:
- This is a new patch
ent for the actual I2C address and
use that client to communicate with the sensor.
Signed-off-by: Hans de Goede
---
Changes in v3:
- Create and use a dummy client instead of relying on i2c-multi-instantiate
to create 2 separate clients for the 2 I2C resources
Changes in v2
- s/i2c_client-s
, but the changes
from this newer version never made it upstream.
This was tested on the following models: Acer Switch 10 SW5-012 (CM32181)
Asus T100TA (CM3218), Asus T100CHI (CM3218) and HP X2 10-n000nd (CM32181).
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
Changes in v2:
- Factor out
Add support for ACPI enumeration, this has been tested on a HP
HP Pavilion x2 Detachable 10 (Bay Trail model).
Signed-off-by: Hans de Goede
---
Changes in v3:
- This is a new patch in v3 of this patch-set
---
drivers/iio/light/cm32181.c | 9 +
1 file changed, 9 insertions(+)
diff --git
From: Daniel Gorbea Ainz
Add touchscreen platform data for the Schneider SCT101CTM tablet
Signed-off-by: Daniel Gorbea
Reviewed-by: Hans de Goede
Signed-off-by: Hans de Goede
---
hdegoede: Resend from my email address as vger.kernel.org does not like
Daniel's emails
---
drivers/platform/x86
Hi,
On 23-10-2019 18:15, Andy Shevchenko wrote:
On Wed, Oct 23, 2019 at 7:08 PM Hans de Goede wrote:
On 23-10-2019 17:23, Daniel Gorbea Ainz wrote:
Add touchscreen platform data for the Schneider SCT101CTM tablet
Signed-off-by: Daniel Gorbea
Patch looks good to me:
Reviewed-by: Hans de
Hi,
On 23-10-2019 17:23, Daniel Gorbea Ainz wrote:
Add touchscreen platform data for the Schneider SCT101CTM tablet
Signed-off-by: Daniel Gorbea
Patch looks good to me:
Reviewed-by: Hans de Goede
Daniel, I received your patch just fine, shall I resend
it to the list for you ?
Regards
Hi,
On 10/22/19 6:29 PM, Philipp Zabel wrote:
Add missing parentheses to correctly hyperlink the reference to
reset_control_get_shared().
Fixes: 0b52297f2288 ("reset: Add support for shared reset controls")
Signed-off-by: Philipp Zabel
Thanks, looks good to me:
Reviewed-by: Han
Hi,
On 16-10-2019 17:12, Kai-Heng Feng wrote:
Runtime power management in i2c-hid brings lots of issues, such as:
- When transitioning from display manager to desktop session, i2c-hid
was closed and opened, so the device was set to SLEEP and ON in a short
period. Vendors confirmed that their
Hi,
On 18-10-2019 22:37, John Stultz wrote:
On Fri, Oct 18, 2019 at 1:21 PM Hans de Goede wrote:
On 18-10-2019 22:12, John Stultz wrote:
On Fri, Oct 18, 2019 at 12:59 PM Hans de Goede wrote:
On 18-10-2019 21:53, John Stultz wrote:
On Fri, Oct 18, 2019 at 12:30 PM Hans de Goede wrote
Hi,
On 18-10-2019 22:12, John Stultz wrote:
On Fri, Oct 18, 2019 at 12:59 PM Hans de Goede wrote:
On 18-10-2019 21:53, John Stultz wrote:
On Fri, Oct 18, 2019 at 12:30 PM Hans de Goede wrote:
Looking at drivers/usb/typec/tcpm/tcpci.c: tcpci_set_vconn I see that
there is a data struct
Hi,
On 18-10-2019 21:53, John Stultz wrote:
On Fri, Oct 18, 2019 at 12:30 PM Hans de Goede wrote:
Looking at drivers/usb/typec/tcpm/tcpci.c: tcpci_set_vconn I see that
there is a data struct with vendor specific callbacks and that the
drivers/usb/typec/tcpm/tcpci_rt1711h.c implements
Hi,
On 18-10-2019 20:39, John Stultz wrote:
On Fri, Oct 18, 2019 at 1:06 AM Hans de Goede wrote:
On 18-10-2019 07:55, John Stultz wrote:
On Wed, Oct 16, 2019 at 12:27 AM Hans de Goede wrote:
Look at the tcpm_set_vbus implementation in drivers/usb/typec/tcpm/fusb302.c
you need to do
701 - 800 of 4303 matches
Mail list logo
