The divisors needed to generate the SPI clock are calculated per
transfer based on the t-speed_hz. There is no reason to calculate
them in ep93xx_spi_setup().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Acked-by: Mika Westerberg mika.westerb...@iki.fi
Cc: Ryan Mallon rmal
into ep93xx_spi_chip_setup()
and return the dividers thru pointers. Remove the divider values from
the per chip data structure.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Acked-by: Mika Westerberg mika.westerb...@iki.fi
Cc: Ryan Mallon rmal...@gmail.com
Cc: Mark Brown broo...@kernel.org
The kzalloc() failure will have already output a message.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ryan Mallon rmal...@gmail.com
Cc: Mika Westerberg mika.westerb...@iki.fi
Cc: Mark Brown broo...@kernel.org
Cc: Grant Likely grant.lik...@linaro.org
---
drivers/spi/spi
Use devm_clk_get() to make the code a bit cleaner and simpler.
This also fixes a bug where a clk_put() is not done if usb_add_hcd()
fails.
Signed-off-by: H Hartley Sweeten
Acked-by: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 4 +---
1 file
and simply call clk_enable() and clk_disable()
directly. The extra level of redirection does not add any clarity.
Signed-off-by: H Hartley Sweeten
Cc: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 128 +
1
Use platform_get_irq() instead of accessing the platform_device
resources directly.
Signed-off-by: H Hartley Sweeten
Acked-by: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff
Tidy up this driver a bit.
v2: redo patch 4 based on suggestions from Alan Stern
H Hartley Sweeten (4):
usb: ohci-ep93xx: use devm_ioremap_resource()
usb: ohci-ep93xx: use platform_get_irq()
usb: ohci-ep93xx: use devm_clk_get()
usb: ohci-ep93xx: tidy up driver (*probe) and (*remove
Use devm_ioremap_resource() to make the code a bit cleaner and
simpler.
Signed-off-by: H Hartley Sweeten
Acked-by: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 35 ++-
1 file changed, 14 insertions(+), 21
On Monday, July 01, 2013 11:23 AM, H Hartley Sweeten wrote:
> On Sunday, June 30, 2013 9:14 AM, Mika Westerberg wrote:
>> Please use SPI_BPW_RANGE_MASK(4, 16) here.
>
> I thought there was a macro for this, just couldn't find it. I'll fix this.
Doh... This patch is already in li
On Sunday, June 30, 2013 9:14 AM, Mika Westerberg wrote:
> On Fri, Jun 28, 2013 at 11:43:07AM -0700, H Hartley Sweeten wrote:
>> This driver supports 16 to 4 bits per work. Set the bits_per_word_mask
>> to allows the spi core to handle validation.
>>
>> Signed-off-b
On Monday, July 01, 2013 3:58 AM, Mark Brown wrote:
> On Sat, Jun 29, 2013 at 09:15:09AM +1000, Ryan Mallon wrote:
>> On 29/06/13 04:42, H Hartley Sweeten wrote:
>
>>> -static inline u8
>>> -ep93xx_spi_read_u8(const struct ep93xx_spi *spi, u16 reg)
>>> -{
&g
On Monday, July 01, 2013 3:28 AM, Mark Brown wrote:
> On Fri, Jun 28, 2013 at 11:43:34AM -0700, H Hartley Sweeten wrote:
>> __spi_async(), which starts every SPI message transfer, initializes
>> the bits_per_word and max speed for every transfer in the message.
>> Since
On Monday, July 01, 2013 3:28 AM, Mark Brown wrote:
On Fri, Jun 28, 2013 at 11:43:34AM -0700, H Hartley Sweeten wrote:
__spi_async(), which starts every SPI message transfer, initializes
the bits_per_word and max speed for every transfer in the message.
Since the conditional test
On Monday, July 01, 2013 3:58 AM, Mark Brown wrote:
On Sat, Jun 29, 2013 at 09:15:09AM +1000, Ryan Mallon wrote:
On 29/06/13 04:42, H Hartley Sweeten wrote:
-static inline u8
-ep93xx_spi_read_u8(const struct ep93xx_spi *spi, u16 reg)
-{
- return __raw_readb(spi-regs_base + reg
On Sunday, June 30, 2013 9:14 AM, Mika Westerberg wrote:
On Fri, Jun 28, 2013 at 11:43:07AM -0700, H Hartley Sweeten wrote:
This driver supports 16 to 4 bits per work. Set the bits_per_word_mask
to allows the spi core to handle validation.
Signed-off-by: H Hartley Sweeten hswee
On Monday, July 01, 2013 11:23 AM, H Hartley Sweeten wrote:
On Sunday, June 30, 2013 9:14 AM, Mika Westerberg wrote:
Please use SPI_BPW_RANGE_MASK(4, 16) here.
I thought there was a macro for this, just couldn't find it. I'll fix this.
Doh... This patch is already in linux-next.
I'll need
Tidy up this driver a bit.
v2: redo patch 4 based on suggestions from Alan Stern
H Hartley Sweeten (4):
usb: ohci-ep93xx: use devm_ioremap_resource()
usb: ohci-ep93xx: use platform_get_irq()
usb: ohci-ep93xx: use devm_clk_get()
usb: ohci-ep93xx: tidy up driver (*probe) and (*remove
Use devm_ioremap_resource() to make the code a bit cleaner and
simpler.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Acked-by: Alan Stern st...@rowland.harvard.edu
Cc: Lennert Buytenhek ker...@wantstofly.org
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/usb/host
and simply call clk_enable() and clk_disable()
directly. The extra level of redirection does not add any clarity.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Alan Stern st...@rowland.harvard.edu
Cc: Lennert Buytenhek ker...@wantstofly.org
Cc: Greg Kroah-Hartman gre
Use platform_get_irq() instead of accessing the platform_device
resources directly.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Acked-by: Alan Stern st...@rowland.harvard.edu
Cc: Lennert Buytenhek ker...@wantstofly.org
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Use devm_clk_get() to make the code a bit cleaner and simpler.
This also fixes a bug where a clk_put() is not done if usb_add_hcd()
fails.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Acked-by: Alan Stern st...@rowland.harvard.edu
Cc: Lennert Buytenhek ker...@wantstofly.org
Cc
Refactor the function a bit to remove the need for the local variable.
The extern prototype of usb_disabled() is not needed.
Signed-off-by: H Hartley Sweeten
Cc: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 11 +++
1 file changed, 3
Use devm_clk_get() to make the code a bit cleaner and simpler.
This also fixes a bug where a clk_put() is not done if usb_add_hcd()
fails.
Signed-off-by: H Hartley Sweeten
Cc: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 4 +---
1 file changed
Use platform_get_irq() instead of accessing the platform_device
resources directly.
Signed-off-by: H Hartley Sweeten
Cc: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
Use devm_ioremap_resource() to make the code a bit cleaner and
simpler.
Signed-off-by: H Hartley Sweeten
Cc: Alan Stern
Cc: Lennert Buytenhek
Cc: Greg Kroah-Hartman
---
drivers/usb/host/ohci-ep93xx.c | 35 ++-
1 file changed, 14 insertions(+), 21 deletions
Tidy up this driver a bit.
H Hartley Sweeten (4):
usb: ohci-ep93xx: use devm_ioremap_resource()
usb: ohci-ep93xx: use platform_get_irq()
usb: ohci-ep93xx: use devm_clk_get()
usb: ohci-ep93xx: tidy up ohci_hcd_ep93xx_drv_probe()
drivers/usb/host/ohci-ep93xx.c | 60
Hello all,
I have a question concerning the "au" size of a SD Card.
I have an old Kingston 64MB SD-Card and lately I have noticed this
kernel message when I use the card:
mmc0: SD Status: Invalid Allocation Unit size.
This is due to the following commit:
commit
On Friday, June 28, 2013 4:18 PM, Ryan Mallon wrote:
> On 29/06/13 04:43, H Hartley Sweeten wrote:
>> __spi_async(), which starts every SPI message transfer, initializes
>> the bits_per_word and max speed for every transfer in the message.
>> Since
Hello Chris,
I have a question concerning the "au" size of a SD Card.
I have an old Kingston 64MB SD-Card and lately I have noticed this
kernel message when I use the card:
mmc0: SD Status: Invalid Allocation Unit size.
This is due to the following commit:
commit
The SPI core provides infrastructure for standard message queueing. Use
that instead of handling it in the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c | 164
all into ep93xx_spi_chip_setup()
and return the dividers thru pointers. Remove the divider values from
the per chip data structure.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c |
The divisors needed to generate the SPI clock are calculated per
transfer based on the t->speed_hz. There is no reason to calculate
them in ep93xx_spi_setup().
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93x
tup() in
ep93xx_spi_process_transfer() and remove 'dss' from the per chip private
data.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/driv
This inline helper function is only used to determine the bus width
of the current transfer (8 or 16 bit). Add a bool flag to the private
structure and set it appropriately for each transfer.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
for each transfer in the message.
Remove the redundant ep93xx_spi_chp_setup() in ep93xx_spi_process_transfer()
which just initializes the hardware to the "default" based on the SPI
device.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Gr
This driver supports 16 to 4 bits per work. Set the bits_per_word_mask
to allows the spi core to handle validation.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc: Mark Brown
Cc: Grant Likely
---
drivers/spi/spi-ep93xx.c | 11 +--
1 file changed, 1 insertion
The memory resource used by this driver is ioremap()'d and the normal
read,write calls can be used instead of the __raw_* variants.
Remove the inline read,write helpers and just do the read,write
directly in the callers.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Mika Westerberg
Cc
Do a bit of housecleaning in this driver and convert it to use the
SPI queued driver infrastructure.
H Hartley Sweeten (8):
spi: spi-ep93xx: use read,write instead of __raw_* variants
spi: spi-ep93xx: use bits_per_word_mask
spi: spi-ep93xx: always handle transfer specific settings
spi
Do a bit of housecleaning in this driver and convert it to use the
SPI queued driver infrastructure.
H Hartley Sweeten (8):
spi: spi-ep93xx: use read,write instead of __raw_* variants
spi: spi-ep93xx: use bits_per_word_mask
spi: spi-ep93xx: always handle transfer specific settings
spi
The memory resource used by this driver is ioremap()'d and the normal
read,write calls can be used instead of the __raw_* variants.
Remove the inline read,write helpers and just do the read,write
directly in the callers.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ryan
This driver supports 16 to 4 bits per work. Set the bits_per_word_mask
to allows the spi core to handle validation.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ryan Mallon rmal...@gmail.com
Cc: Mika Westerberg mika.westerb...@iki.fi
Cc: Mark Brown broo...@kernel.org
Cc
for each transfer in the message.
Remove the redundant ep93xx_spi_chp_setup() in ep93xx_spi_process_transfer()
which just initializes the hardware to the default based on the SPI
device.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ryan Mallon rmal...@gmail.com
Cc: Mika
This inline helper function is only used to determine the bus width
of the current transfer (8 or 16 bit). Add a bool flag to the private
structure and set it appropriately for each transfer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ryan Mallon rmal...@gmail.com
Cc: Mika
() in
ep93xx_spi_process_transfer() and remove 'dss' from the per chip private
data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ryan Mallon rmal...@gmail.com
Cc: Mika Westerberg mika.westerb...@iki.fi
Cc: Mark Brown broo...@kernel.org
Cc: Grant Likely grant.lik...@linaro.org
---
drivers/spi/spi
The divisors needed to generate the SPI clock are calculated per
transfer based on the t-speed_hz. There is no reason to calculate
them in ep93xx_spi_setup().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ryan Mallon rmal...@gmail.com
Cc: Mika Westerberg mika.westerb...@iki.fi
into ep93xx_spi_chip_setup()
and return the dividers thru pointers. Remove the divider values from
the per chip data structure.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ryan Mallon rmal...@gmail.com
Cc: Mika Westerberg mika.westerb...@iki.fi
Cc: Mark Brown broo...@kernel.org
Cc
The SPI core provides infrastructure for standard message queueing. Use
that instead of handling it in the driver.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ryan Mallon rmal...@gmail.com
Cc: Mika Westerberg mika.westerb...@iki.fi
Cc: Mark Brown broo...@kernel.org
Cc: Grant
Hello Chris,
I have a question concerning the au size of a SD Card.
I have an old Kingston 64MB SD-Card and lately I have noticed this
kernel message when I use the card:
mmc0: SD Status: Invalid Allocation Unit size.
This is due to the following commit:
commit
On Friday, June 28, 2013 4:18 PM, Ryan Mallon wrote:
On 29/06/13 04:43, H Hartley Sweeten wrote:
__spi_async(), which starts every SPI message transfer, initializes
the bits_per_word and max speed for every transfer in the message.
Since the conditional test in ep93xx_spi_process_transfer
Hello all,
I have a question concerning the au size of a SD Card.
I have an old Kingston 64MB SD-Card and lately I have noticed this
kernel message when I use the card:
mmc0: SD Status: Invalid Allocation Unit size.
This is due to the following commit:
commit
Tidy up this driver a bit.
H Hartley Sweeten (4):
usb: ohci-ep93xx: use devm_ioremap_resource()
usb: ohci-ep93xx: use platform_get_irq()
usb: ohci-ep93xx: use devm_clk_get()
usb: ohci-ep93xx: tidy up ohci_hcd_ep93xx_drv_probe()
drivers/usb/host/ohci-ep93xx.c | 60
Use devm_ioremap_resource() to make the code a bit cleaner and
simpler.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Alan Stern st...@rowland.harvard.edu
Cc: Lennert Buytenhek ker...@wantstofly.org
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/usb/host/ohci
Use platform_get_irq() instead of accessing the platform_device
resources directly.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Alan Stern st...@rowland.harvard.edu
Cc: Lennert Buytenhek ker...@wantstofly.org
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/usb
Use devm_clk_get() to make the code a bit cleaner and simpler.
This also fixes a bug where a clk_put() is not done if usb_add_hcd()
fails.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Alan Stern st...@rowland.harvard.edu
Cc: Lennert Buytenhek ker...@wantstofly.org
Cc: Greg
Refactor the function a bit to remove the need for the local variable.
The extern prototype of usb_disabled() is not needed.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Alan Stern st...@rowland.harvard.edu
Cc: Lennert Buytenhek ker...@wantstofly.org
Cc: Greg Kroah-Hartman
On Tuesday, June 11, 2013 12:48 PM, Thierry Reding wrote:
>
> I'm tempted to take your v5 patch and make a note to clean that up
> separately at some point (along with similar changes for the DEBUG_FS
> support).
Thierry,
So you want a v6 of this patch or are you ok with v5?
Thanks,
Hartley
--
On Tuesday, June 11, 2013 12:48 PM, Thierry Reding wrote:
I'm tempted to take your v5 patch and make a note to clean that up
separately at some point (along with similar changes for the DEBUG_FS
support).
Thierry,
So you want a v6 of this patch or are you ok with v5?
Thanks,
Hartley
--
To
On Tuesday, June 11, 2013 11:35 AM, Thierry Reding wrote:
> On Tue, Jun 11, 2013 at 11:47:23AM -0500, H Hartley Sweeten wrote:
>> On Tuesday, June 11, 2013 9:09 AM, H Hartley Sweeten wrote:
>>> On Tuesday, June 11, 2013 4:29 AM, Ryan Mallon wrote:
>>>> On 11/06/
channel to the kernel
Signed-off-by: H Hartley Sweeten
Cc: Thierry Reding
Cc: Lars Poeschel
Cc: Ryan Mallon
Cc: Rob Landley
---
v5: * rename the 'duty' attribute to 'duty_cycle'
* make the Kconfig option hidden and enabled when CONFIG_SYSFS
is enabled
* use sysfs_streq
On Tuesday, June 11, 2013 9:09 AM, H Hartley Sweeten wrote:
> On Tuesday, June 11, 2013 4:29 AM, Ryan Mallon wrote:
>> On 11/06/13 20:14, Thierry Reding wrote:
>>> On Mon, Jun 10, 2013 at 04:12:07PM -0700, H Hartley Sweeten wrote:
>>>> +config PWM_SYSFS
>>&
On Tuesday, June 11, 2013 4:29 AM, Ryan Mallon wrote:
> On 11/06/13 20:14, Thierry Reding wrote:
>> On Mon, Jun 10, 2013 at 04:12:07PM -0700, H Hartley Sweeten wrote:
>> [...]
>>> +What: /sys/class/pwm/pwmchipN/pwmX/duty
>>> +Date: May
On Tuesday, June 11, 2013 4:29 AM, Ryan Mallon wrote:
On 11/06/13 20:14, Thierry Reding wrote:
On Mon, Jun 10, 2013 at 04:12:07PM -0700, H Hartley Sweeten wrote:
[...]
+What: /sys/class/pwm/pwmchipN/pwmX/duty
+Date: May 2013
+KernelVersion: 3.11
+Contact: H
On Tuesday, June 11, 2013 9:09 AM, H Hartley Sweeten wrote:
On Tuesday, June 11, 2013 4:29 AM, Ryan Mallon wrote:
On 11/06/13 20:14, Thierry Reding wrote:
On Mon, Jun 10, 2013 at 04:12:07PM -0700, H Hartley Sweeten wrote:
+config PWM_SYSFS
+ bool /sys/class/pwm/... (sysfs interface
channel to the kernel
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Thierry Reding thierry.red...@gmail.com
Cc: Lars Poeschel poesc...@lemonage.de
Cc: Ryan Mallon rmal...@gmail.com
Cc: Rob Landley r...@landley.net
---
v5: * rename the 'duty' attribute to 'duty_cycle'
* make
On Tuesday, June 11, 2013 11:35 AM, Thierry Reding wrote:
On Tue, Jun 11, 2013 at 11:47:23AM -0500, H Hartley Sweeten wrote:
On Tuesday, June 11, 2013 9:09 AM, H Hartley Sweeten wrote:
On Tuesday, June 11, 2013 4:29 AM, Ryan Mallon wrote:
On 11/06/13 20:14, Thierry Reding wrote:
On Mon, Jun
to the kernel
Signed-off-by: H Hartley Sweeten
Cc: Thierry Reding
Cc: Lars Poeschel
Cc: Ryan Mallon
Cc: Rob Landley
---
v4: * address a number of issues pointed out by Thierry Reding
- fix some typos and wording issues in the Documentation
- rename the new source file to sysfs.c
On Monday, June 10, 2013 12:00 PM, Thierry Reding wrote:
> On Thu, May 30, 2013 at 02:30:39PM -0700, H Hartley Sweeten wrote:
>> Add a simple sysfs interface to the generic PWM framework.
>
> Sorry for taking so long to review this.
Not a problem. Thanks for the review.
>
Ping?
-Original Message-
From: H Hartley Sweeten
Sent: Thursday, May 30, 2013 2:31 PM
To: Linux Kernel
Cc: linux-...@vger.kernel.org; linux-...@vger.kernel.org;
thierry.red...@gmail.com; poesc...@lemonage.de; Ryan Mallon; r...@landley.net;
H Hartley Sweeten
Subject: [PATCH v3] pwm: add
Ping?
-Original Message-
From: H Hartley Sweeten
Sent: Thursday, May 30, 2013 2:31 PM
To: Linux Kernel
Cc: linux-...@vger.kernel.org; linux-...@vger.kernel.org;
thierry.red...@gmail.com; poesc...@lemonage.de; Ryan Mallon; r...@landley.net;
H Hartley Sweeten
Subject: [PATCH v3] pwm: add
On Monday, June 10, 2013 12:00 PM, Thierry Reding wrote:
On Thu, May 30, 2013 at 02:30:39PM -0700, H Hartley Sweeten wrote:
Add a simple sysfs interface to the generic PWM framework.
Sorry for taking so long to review this.
Not a problem. Thanks for the review.
/sys/class/pwm
to the kernel
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Thierry Reding thierry.red...@gmail.com
Cc: Lars Poeschel poesc...@lemonage.de
Cc: Ryan Mallon rmal...@gmail.com
Cc: Rob Landley r...@landley.net
---
v4: * address a number of issues pointed out by Thierry Reding
Signed-off-by: H Hartley Sweeten
Cc: Thierry Reding
Cc: Lars Poeschel
Cc: Ryan Mallon
Cc: Rob Landley
---
v3: * fix an issue with the export/unexport of the PWM chip
v2: * add API documentation and update Documentation/pwm.txt
* fix some issues pointed out by Ryan Mallon
* add the pwm
On Thursday, May 30, 2013 12:30 PM, H Hartley Sweeten wrote:
> Add a simple sysfs interface to the generic PWM framework.
>
> /sys/class/pwm/
> `-- pwmchipN/ for each PWM chip
> |-- export (w/o) ask the kernel to export a PWM channel
> |-- n
to the kernel
Signed-off-by: H Hartley Sweeten
Cc: Thierry Reding
Cc: Lars Poeschel
Cc: Ryan Mallon
Cc: Rob Landley
---
v2: * add API documentation and update Documentation/pwm.txt
* fix some issues pointed out by Ryan Mallon
* add the pwm attributes to dev.groups so they are created
On Wednesday, May 29, 2013 7:02 PM, Ryan Mallon wrote:
> On 30/05/13 07:08, H Hartley Sweeten wrote:
>> Add a simple sysfs interface to the PWM framework.
>>
>> /sys/class/pwm/
>> `-- pwmchipN/ for each PWM chip
>> |-- export (w/
On Wednesday, May 29, 2013 7:02 PM, Ryan Mallon wrote:
On 30/05/13 07:08, H Hartley Sweeten wrote:
Add a simple sysfs interface to the PWM framework.
/sys/class/pwm/
`-- pwmchipN/ for each PWM chip
|-- export (w/o) ask the kernel to export a PWM to userspace
to the kernel
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Thierry Reding thierry.red...@gmail.com
Cc: Lars Poeschel poesc...@lemonage.de
Cc: Ryan Mallon rmal...@gmai.com
Cc: Rob Landley r...@landley.net
---
v2: * add API documentation and update Documentation/pwm.txt
* fix
On Thursday, May 30, 2013 12:30 PM, H Hartley Sweeten wrote:
Add a simple sysfs interface to the generic PWM framework.
/sys/class/pwm/
`-- pwmchipN/ for each PWM chip
|-- export (w/o) ask the kernel to export a PWM channel
|-- npwn (r/o) number
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Thierry Reding thierry.red...@gmail.com
Cc: Lars Poeschel poesc...@lemonage.de
Cc: Ryan Mallon rmal...@gmail.com
Cc: Rob Landley r...@landley.net
---
v3: * fix an issue with the export/unexport of the PWM chip
v2: * add API documentation
On Tuesday, May 28, 2013 4:42 AM, Lars Poeschel wrote:
> On Tuesday 28 May 2013 at 13:00:12, Thierry Reding wrote:
>> I've added Lars Poeschel on Cc, who's done some work on a sysfs
>> interface for the PWM subsystem already. It's undergone some review
>> already[0] and I think he's working on a
| |-- duty_ns(r/w) duty cycle (in nanoseconds)
| |-- enable (r/w) enable/disable PWM
| |-- period_ns (r/w) period (in nanoseconds)
| `-- polarity (r/w) polarity of PWM
`-- unexport (w/o) return a PWM to the kernel
Signed-off-by: H Hartley Sweeten
Cc
| |-- duty_ns(r/w) duty cycle (in nanoseconds)
| |-- enable (r/w) enable/disable PWM
| |-- period_ns (r/w) period (in nanoseconds)
| `-- polarity (r/w) polarity of PWM
`-- unexport (w/o) return a PWM to the kernel
Signed-off-by: H Hartley Sweeten
On Tuesday, May 28, 2013 4:42 AM, Lars Poeschel wrote:
On Tuesday 28 May 2013 at 13:00:12, Thierry Reding wrote:
I've added Lars Poeschel on Cc, who's done some work on a sysfs
interface for the PWM subsystem already. It's undergone some review
already[0] and I think he's working on a v2 now.
On Monday, May 27, 2013 8:20 AM, Arnd Bergmann wrote:
> On Saturday 25 May 2013, H Hartley Sweeten wrote:
>> This driver needs to be converted to the new PWM framework.
>>
>> Before converting it clean up all the cruft,
>>
>> H Hartley Sweeten (14):
>>
On Monday, May 27, 2013 8:18 AM, Arnd Bergmann wrote:
> On Saturday 25 May 2013, H Hartley Sweeten wrote:
>> @@ -42,13 +42,13 @@ struct ep93xx_pwm {
>> static inline void ep93xx_pwm_writel(struct ep93xx_pwm *pwm,
>> unsigned int val, unsigned int off)
>>
On Monday, May 27, 2013 8:18 AM, Arnd Bergmann wrote:
On Saturday 25 May 2013, H Hartley Sweeten wrote:
@@ -42,13 +42,13 @@ struct ep93xx_pwm {
static inline void ep93xx_pwm_writel(struct ep93xx_pwm *pwm,
unsigned int val, unsigned int off)
{
- __raw_writel(val, pwm
On Monday, May 27, 2013 8:20 AM, Arnd Bergmann wrote:
On Saturday 25 May 2013, H Hartley Sweeten wrote:
This driver needs to be converted to the new PWM framework.
Before converting it clean up all the cruft,
H Hartley Sweeten (14):
misc/ep93xx_pwm: use managed device resources
misc
Add the (*probe) function to the platform_driver and use the
module_platform_driver() macro to initialize the module.
Remove the unnecessary __init and __exit tags.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers
This is a simple wrapper around writel(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/misc
strict_strtol is deprecated in favor of kstrtol.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/ep93xx_pwm.c b
This is a simple wrapper around readl(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/misc
This is a simple wrapper around readl(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/misc
This is a simple wrapper around readl(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/misc
This is a simple wrapper around writel(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/misc
This is a simple wrapper around writel(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/misc
This is a simple wrapper around writel(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/misc
This is a simple wrapper around writel(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/misc
This is a simple wrapper around writel(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/misc
These are simple wrappers around writel() and readl(). Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 30 +-
1 file changed, 9 insertions(+), 21 deletions
The mmio_base is an ioremap'ed memory resource. The normal memory
io functions should be used not the __raw_* versions.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 4 ++--
1 file changed, 2
501 - 600 of 1421 matches
Mail list logo
