On Thu, 2008-01-17 at 20:14 -0500, H. Peter Anvin wrote:
> Harvey Harrison wrote:
> >
> >>> /* still need a define here, as one is long and one is unsigned long.
> >>> * but this is another target for unification I guess. */
> >>> #define reg
Roland actually put on CC this time.
On Thu, 2008-01-17 at 19:59 -0500, H. Peter Anvin wrote:
> Harvey Harrison wrote:
> >
> > Sorry, missed that detail in ptrace.h, I notice now.
> >
> > Is there some better way this could be organized, would the following
> &
On Thu, 2008-01-17 at 19:59 -0500, H. Peter Anvin wrote:
> Harvey Harrison wrote:
> >
> > Sorry, missed that detail in ptrace.h, I notice now.
> >
> > Is there some better way this could be organized, would the following
> > be an improvement, as o
Use v8086_mode inline in fault_32.c, no functional change
also ifdef the section for 32-bit only and add to fault_64.c
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
HPA noted that v8086_mode is always zero on X86_64, no ifdef
needed.
arch/x86/mm/fault_32.c |3 ++-
arch/
On Thu, 2008-01-17 at 18:02 -0500, H. Peter Anvin wrote:
> Harvey Harrison wrote:
> > Use v8086_mode inline in fault_32.c, no functional change
> > also ifdef the section for 32-bit only and add to fault_64.c
>
> The #ifdef is unnecessary, since v8086_mode() is now a const
Use v8086_mode inline in fault_32.c, no functional change
also ifdef the section for 32-bit only and add to fault_64.c
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/mm/fault_32.c |4 +++-
arch/x86/mm/fault_64.c | 11 +++
2 files changed, 14 insertions
Further towards unifying these files, add another helper
in same spirit as is_errata93.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/mm/fault_32.c | 19 +++
arch/x86/mm/fault_64.c | 25 +
2 files changed, 36 insertions
Further towards unifying these files, add another helper
in same spirit as is_errata93.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Incorporated HPA's suggestion of unconditional prototype for
do_invalid_op.
arch/x86/mm/fault_32.c | 39 ++-
Use v8086_mode inline in fault_32.c, no functional change
also ifdef the section for 32-bit only and add to fault_64.c
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/mm/fault_32.c |4 +++-
arch/x86/mm/fault_64.c | 11 +++
2 files changed, 14 insertions(+), 1
Further towards unifying these files, add another helper
in same spirit as is_errata93.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/mm/fault_32.c | 19 +++
arch/x86/mm/fault_64.c | 25 +
2 files changed, 36 insertions(+), 8 deletions
Further towards unifying these files, add another helper
in same spirit as is_errata93.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Incorporated HPA's suggestion of unconditional prototype for
do_invalid_op.
arch/x86/mm/fault_32.c | 39 ++-
arch
Use v8086_mode inline in fault_32.c, no functional change
also ifdef the section for 32-bit only and add to fault_64.c
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
HPA noted that v8086_mode is always zero on X86_64, no ifdef
needed.
arch/x86/mm/fault_32.c |3 ++-
arch/x86/mm
On Thu, 2008-01-17 at 18:02 -0500, H. Peter Anvin wrote:
Harvey Harrison wrote:
Use v8086_mode inline in fault_32.c, no functional change
also ifdef the section for 32-bit only and add to fault_64.c
The #ifdef is unnecessary, since v8086_mode() is now a constant zero on
x86-64. gcc
On Thu, 2008-01-17 at 19:59 -0500, H. Peter Anvin wrote:
Harvey Harrison wrote:
Sorry, missed that detail in ptrace.h, I notice now.
Is there some better way this could be organized, would the following
be an improvement, as opposed to two long ifdef sections?
Patch will follow
Roland actually put on CC this time.
On Thu, 2008-01-17 at 19:59 -0500, H. Peter Anvin wrote:
Harvey Harrison wrote:
Sorry, missed that detail in ptrace.h, I notice now.
Is there some better way this could be organized, would the following
be an improvement, as opposed to two long
On Thu, 2008-01-17 at 20:14 -0500, H. Peter Anvin wrote:
Harvey Harrison wrote:
/* still need a define here, as one is long and one is unsigned long.
* but this is another target for unification I guess. */
#define regs_return_value(regs) ((regs)-ax)
Indeed...
I think this comes
Leave definition of pt_regs in its own section, move all kernel
code to section afterwards, unify prototype definitions, has some
conditional prototypes to make it clear what was only defined in
32 and 64 bit.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
include/asm-x86/ptrace.h | 43
Unify the definiton of:
v8086_mode
user_mode
user_mode_vm
stack_pointer
instruction_pointer
frame_pointer
in ptrace.h to make it clear where the differences are between
32 and 64 bit. Changes macros to static inlines as well.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
include/asm-x86
On Thu, 2008-01-17 at 20:36 -0500, H. Peter Anvin wrote:
Roland McGrath wrote:
It's indeed true that pt_regs is truly the esp value for x86-32
kernel-mode trap frames. Because this nonobvious calculation is
only right for a kernel mode pt_regs and not for a user-mode one,
I think it
On Thu, 2008-01-17 at 20:56 -0500, H. Peter Anvin wrote:
Harvey Harrison wrote:
Unify the definiton of:
v8086_mode
user_mode
user_mode_vm
stack_pointer
instruction_pointer
frame_pointer
in ptrace.h to make it clear where the differences are between
32 and 64 bit. Changes
On Thu, 2008-01-17 at 20:36 -0500, H. Peter Anvin wrote:
Roland McGrath wrote:
It's indeed true that pt_regs is truly the esp value for x86-32
kernel-mode trap frames. Because this nonobvious calculation is
only right for a kernel mode pt_regs and not for a user-mode one,
I think it
On Thu, 2008-01-17 at 21:03 -0500, H. Peter Anvin wrote:
Kyle McMartin wrote:
i915_flush_ttm was unconditionally executing a clflush instruction
to (obviously) flush the cache. Instead, check if the cpu supports
clflush, and if not, fall back to calling wbinvd to flush the entire
cache.
Choose a less generic name for such a special case. Add
a comment explaining the odd use in X86_32.
Change the one user of stack_pointer.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/oprofile/backtrace.c |2 +-
include/asm-x86/ptrace.h |8 +++-
2 files changed
On Wed, 2008-01-16 at 22:11 -0500, H. Peter Anvin wrote:
> Harvey Harrison wrote:
> > On Wed, 2008-01-16 at 23:27 +0100, Andi Kleen wrote:
> >> Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
> >>
> >> ---
> >> arch/x86/mm/fault_32.c |2 +
On Wed, 2008-01-16 at 23:27 +0100, Andi Kleen wrote:
> Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
>
> ---
> arch/x86/mm/fault_32.c |2 +-
Could use exactly the same in fault_64.c
> #ifdef CONFIG_X86_32
> - "%s%s[%d]: segfault at %08lx ip %08lx sp %08lx error
>
On Wed, 2008-01-16 at 23:27 +0100, Andi Kleen wrote:
Signed-off-by: Andi Kleen [EMAIL PROTECTED]
---
arch/x86/mm/fault_32.c |2 +-
Could use exactly the same in fault_64.c
#ifdef CONFIG_X86_32
- %s%s[%d]: segfault at %08lx ip %08lx sp %08lx error
%lx\n,
+
On Wed, 2008-01-16 at 22:11 -0500, H. Peter Anvin wrote:
Harvey Harrison wrote:
On Wed, 2008-01-16 at 23:27 +0100, Andi Kleen wrote:
Signed-off-by: Andi Kleen [EMAIL PROTECTED]
---
arch/x86/mm/fault_32.c |2 +-
Could use exactly the same in fault_64.c
#ifdef CONFIG_X86_32
On Wed, 2008-01-16 at 10:22 +0530, Ananth N Mavinakayanahalli wrote:
> On Mon, Jan 14, 2008 at 07:21:55PM -0800, Stephen Hemminger wrote:
> > Fix warning from missing cast, maybe a result of the x86 merge?
> >
> > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
>
> Acked-by: Ananth N
On Tue, 2008-01-15 at 22:22 -0500, H. Peter Anvin wrote:
> Kyle McMartin wrote:
> > On Tue, Jan 15, 2008 at 06:48:35PM -0800, Harvey Harrison wrote:
> >> +#ifdef CONFIG_X86_F00F_BUG
> >> +void do_invalid_op(struct pt_regs *, unsigned long);
> >> +#endif
> &
Further towards unifying these files, add another helper
in same spirit as is_errata93. Add an #ifdef around the
forward declaration of do_invalid_op to make it clear it
is only needed in the one place.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/mm/fault_32.c
- Rename it to pte_exec() from pte_exec_kernel(). There is nothing
kernel specific in there.
- Move it into the common file because _PAGE_NX is 0 on !PAE and then
pte_exec() will be always evaluate to true.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Taken from Patch 31/31 in
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Taken from Andi's CPA 16/31, against x86.git, not sure what
the etiquette is with adding his S-O-B
arch/x86/mm/pageattr_64.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/pageattr_64.c b/ar
Similar to X86_64.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, pulled this out of some unification work, Andi Kleen
sent a pretty much identical patch in his CPA queue (7/31), this
is against current x86.git
arch/x86/mm/fault_32.c
On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote:
> Since change_page_attr() is tricky code it is good to have some regression
> test code. This patch maps and unmaps some random pages in the direct mapping
> at boot and then dumps the state and does some simple sanity checks.
>
> Add it with
On Tue, 2008-01-15 at 11:06 +0100, Andi Kleen wrote:
> On Tuesday 15 January 2008 10:29:51 Harvey Harrison wrote:
> > On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote:
> > > Instead of open coding the bit accesses uses standard style
> > > *PageDeferred* macros.
On Tue, 2008-01-15 at 10:59 +0100, Andi Kleen wrote:
> > global_flush_tlb outside CONFIG_CPA_DEBUG here. Intentional?
>
> Yes that's all intentional. Without CPA_DEBUG there is only a single flush,
> with CPA_DEBUG we flush more often simply to catch bugs.
>
OK, it just looked a bit fishy with
On Tue, 2008-01-15 at 11:00 +0100, Andi Kleen wrote:
> > > +void dump_pagetable(unsigned long address)
> >
> > static?
>
> This is used by other files too with future patches. Also
> in general it's useful for debugging stuff - i often put calls
> to it into debugging patches.
>
> > > +{
> > >
On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote:
> Instead of open coding the bit accesses uses standard style
> *PageDeferred* macros.
>
Any reason these couldn't be static inlines in a shared header?
asm/page.h perhaps?
Cheers,
Harvey
--
To unsubscribe from this list: send the line
On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote:
> Similar to x86-64. This is useful in other situations where we want
> the page table dumped too.
>
> Besides anything that makes i386 do_page_fault shorter is good.
>
> Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
>
> ---
>
On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote:
> When CONFIG_DEBUG_RODATA is enabled undo the ro mapping and redo it again.
> This gives some simple testing for change_page_attr()
>
> Optional patch, but I find it useful.
>
> Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
>
> ---
>
On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote:
Similar to x86-64. This is useful in other situations where we want
the page table dumped too.
Besides anything that makes i386 do_page_fault shorter is good.
Signed-off-by: Andi Kleen [EMAIL PROTECTED]
---
arch/x86/mm/fault_32.c |
On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote:
When CONFIG_DEBUG_RODATA is enabled undo the ro mapping and redo it again.
This gives some simple testing for change_page_attr()
Optional patch, but I find it useful.
Signed-off-by: Andi Kleen [EMAIL PROTECTED]
---
On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote:
Instead of open coding the bit accesses uses standard style
*PageDeferred* macros.
Any reason these couldn't be static inlines in a shared header?
asm/page.h perhaps?
Cheers,
Harvey
--
To unsubscribe from this list: send the line
On Tue, 2008-01-15 at 11:00 +0100, Andi Kleen wrote:
+void dump_pagetable(unsigned long address)
static?
This is used by other files too with future patches. Also
in general it's useful for debugging stuff - i often put calls
to it into debugging patches.
+{
+
On Tue, 2008-01-15 at 11:06 +0100, Andi Kleen wrote:
On Tuesday 15 January 2008 10:29:51 Harvey Harrison wrote:
On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote:
Instead of open coding the bit accesses uses standard style
*PageDeferred* macros.
Any reason these couldn't
On Tue, 2008-01-15 at 10:59 +0100, Andi Kleen wrote:
global_flush_tlb outside CONFIG_CPA_DEBUG here. Intentional?
Yes that's all intentional. Without CPA_DEBUG there is only a single flush,
with CPA_DEBUG we flush more often simply to catch bugs.
OK, it just looked a bit fishy with the
On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote:
Since change_page_attr() is tricky code it is good to have some regression
test code. This patch maps and unmaps some random pages in the direct mapping
at boot and then dumps the state and does some simple sanity checks.
Add it with a
Similar to X86_64.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Ingo, pulled this out of some unification work, Andi Kleen
sent a pretty much identical patch in his CPA queue (7/31), this
is against current x86.git
arch/x86/mm/fault_32.c | 72
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Taken from Andi's CPA 16/31, against x86.git, not sure what
the etiquette is with adding his S-O-B
arch/x86/mm/pageattr_64.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/pageattr_64.c b/arch/x86/mm
- Rename it to pte_exec() from pte_exec_kernel(). There is nothing
kernel specific in there.
- Move it into the common file because _PAGE_NX is 0 on !PAE and then
pte_exec() will be always evaluate to true.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Taken from Patch 31/31 in Andi's CPA
Further towards unifying these files, add another helper
in same spirit as is_errata93. Add an #ifdef around the
forward declaration of do_invalid_op to make it clear it
is only needed in the one place.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/mm/fault_32.c | 41
On Tue, 2008-01-15 at 22:22 -0500, H. Peter Anvin wrote:
Kyle McMartin wrote:
On Tue, Jan 15, 2008 at 06:48:35PM -0800, Harvey Harrison wrote:
+#ifdef CONFIG_X86_F00F_BUG
+void do_invalid_op(struct pt_regs *, unsigned long);
+#endif
+
+static int is_f00f_bug(struct pt_regs *regs
On Wed, 2008-01-16 at 10:22 +0530, Ananth N Mavinakayanahalli wrote:
On Mon, Jan 14, 2008 at 07:21:55PM -0800, Stephen Hemminger wrote:
Fix warning from missing cast, maybe a result of the x86 merge?
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Acked-by: Ananth N Mavinakayanahalli
On Sat, 2008-01-12 at 22:05 +0100, Rafael J. Wysocki wrote:
> [RFC: Would that be useful if I sent regression-fixing patches, CCed to the
> appropriate maintainers/lists, along with the reports?]
Perhaps keep the regression report as-is, but for each regression with
a patch follow up with an
Add caller of is_errata93() to X86_32, ifdef'd to do
nothing.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/mm/fault_32.c | 59 +--
arch/x86/mm/fault_64.c | 30 ++--
2 files changed, 83 insertions
Comments, indentation, printk format.
Uses task_pid_nr() on X86_64 now, but this is always defined
to task->pid.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/mm/fault_32.c | 20
arch/x86/mm/fault_64.c | 29 +++--
Comments, indentation, printk format.
Uses task_pid_nr() on X86_64 now, but this is always defined
to task-pid.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/mm/fault_32.c | 20
arch/x86/mm/fault_64.c | 29 +++--
2 files changed
Add caller of is_errata93() to X86_32, ifdef'd to do
nothing.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/mm/fault_32.c | 59 +--
arch/x86/mm/fault_64.c | 30 ++--
2 files changed, 83 insertions(+), 6 deletions
On Sat, 2008-01-12 at 22:05 +0100, Rafael J. Wysocki wrote:
[RFC: Would that be useful if I sent regression-fixing patches, CCed to the
appropriate maintainers/lists, along with the reports?]
Perhaps keep the regression report as-is, but for each regression with
a patch follow up with an
Copy the prefetch of map_sem from X86_64 and move the check
notify_page_fault (soon to be kprobe_handle_fault) out of
the unlikely if() statement.
This makes the X86_32|64 pagefault handlers closer to each
other.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, I'll g
the segment limit was being checked
on X86_32.
Remove get_segment_eip as well.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/step.c | 84 --
arch/x86/mm/fault_32.c | 15 +---
arch/x86/mm/fault_64.c
Rename convert_rip_to_linear to convert_ip_to_linear for shared
X86_32|64 use.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/step.c |4 ++--
arch/x86/mm/fault_32.c |2 +-
arch/x86/mm/fault_64.c |2 +-
include/asm-x86/ptrace.h |2 +-
4 files c
the segment limit was being checked
on X86_32.
Remove get_segment_eip as well.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/kernel/step.c | 84 --
arch/x86/mm/fault_32.c | 15 +---
arch/x86/mm/fault_64.c | 15
Rename convert_rip_to_linear to convert_ip_to_linear for shared
X86_32|64 use.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/kernel/step.c |4 ++--
arch/x86/mm/fault_32.c |2 +-
arch/x86/mm/fault_64.c |2 +-
include/asm-x86/ptrace.h |2 +-
4 files changed, 5
Copy the prefetch of map_sem from X86_64 and move the check
notify_page_fault (soon to be kprobe_handle_fault) out of
the unlikely if() statement.
This makes the X86_32|64 pagefault handlers closer to each
other.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Ingo, I'll go back to the zero
these to wrmsrl.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Incorporating HPA's comment removing 0L.
arch/x86/kernel/kprobes.c |4 ++--
arch/x86/kernel/step.c|4
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kpr
these to wrmsrl.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/kprobes.c |4 ++--
arch/x86/kernel/step.c|4
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c
index 53ba6a5..34becd1 100644
---
On Thu, 2008-01-10 at 13:40 +0100, Ingo Molnar wrote:
> * Harvey Harrison <[EMAIL PROTECTED]> wrote:
>
> > @@ -148,11 +148,7 @@ static void write_debugctlmsr(struct task_struct
> > *child, unsigned long val)
> > if (child != current)
> > ret
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, you could/should probably fold this into Masami's kprobe
unification patch.
commit 17735e04f7f18bea4dcbe4daa31c34acac55b332
Author: Masami Hiramatsu <[EMAIL PROTECTED]>
Date: Wed Jan 9 13:30:50 2008 +0100
kprobes
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Ingo, you could/should probably fold this into Masami's kprobe
unification patch.
commit 17735e04f7f18bea4dcbe4daa31c34acac55b332
Author: Masami Hiramatsu [EMAIL PROTECTED]
Date: Wed Jan 9 13:30:50 2008 +0100
kprobes code for x86
On Thu, 2008-01-10 at 13:40 +0100, Ingo Molnar wrote:
* Harvey Harrison [EMAIL PROTECTED] wrote:
@@ -148,11 +148,7 @@ static void write_debugctlmsr(struct task_struct
*child, unsigned long val)
if (child != current)
return;
-#ifdef CONFIG_X86_64
- wrmsrl
these to wrmsrl.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Incorporating HPA's comment removing 0L.
arch/x86/kernel/kprobes.c |4 ++--
arch/x86/kernel/step.c|4
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c
get_segment_eip has similarities to convert_rip_to_linear(),
and is used in a similar context. Move get_segment_eip to
step.c to allow easier consolidation.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, you may want to fold this into my previous patch:
x86: begin fault_{32
Similar cleanup was done when unifying kprobes_32|64.c and
wrmsr() was chosen there over wrmsrl().
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, only chose this direction based on the kprobes.c unification.
arch/x86/kernel/step.c |4
1 files changed, 0 insertions
On Wed, 2008-01-09 at 22:05 -0800, Arjan van de Ven wrote:
> Subject: Make the 32 bit Frame Pointer backtracer fall back to traditional
> From: Arjan van de Ven <[EMAIL PROTECTED]>
>
> The 32 bit Frame Pointer backtracer code checks if the EBP is valid
> to do a backtrace; however currently on a
out before hitting kprobe_running().
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
include/linux/kprobes.h | 19 ---
1 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h
index c01e320..e61607a
.
This uncovered a possible bug in the s390 version as that purely
copied the x86 version unconditionally passing 14 as the trapnr
rather than the error_code parameter. s390 is changed to pass
error_code in this patch.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/avr32/mm/fault.c
On Thu, 2008-01-10 at 00:16 +0100, Heiko Carstens wrote:
> > arch/avr32/mm/fault.c | 21 +
> > arch/ia64/mm/fault.c| 24 +---
> > arch/powerpc/mm/fault.c | 25 +
> > arch/s390/mm/fault.c| 25
On Wed, 2008-01-09 at 23:28 +0100, Andi Kleen wrote:
> Do you have a simple recipe to just update from the the remote branch,
> assuming there are no local changes or local branches?
>
> -Andi
For staying up to date I use the following:
# Add Linus's tree as a remote
git remote --add linus
.
avr32 was the only arch without the preempt_disable/enable pair
in its notify_page_fault implementation.
This uncovered a possible bug in the s390 version as that purely
copied the x86 version unconditionally passing 14 as the trapnr
rather than the error_code parameter.
Signed-off-by: Harvey
.
avr32 was the only arch without the preempt_disable/enable pair
in its notify_page_fault implementation.
This uncovered a possible bug in the s390 version as that purely
copied the x86 version unconditionally passing 14 as the trapnr
rather than the error_code parameter.
Signed-off-by: Harvey
On Wed, 2008-01-09 at 23:28 +0100, Andi Kleen wrote:
Do you have a simple recipe to just update from the the remote branch,
assuming there are no local changes or local branches?
-Andi
For staying up to date I use the following:
# Add Linus's tree as a remote
git remote --add linus
On Thu, 2008-01-10 at 00:16 +0100, Heiko Carstens wrote:
arch/avr32/mm/fault.c | 21 +
arch/ia64/mm/fault.c| 24 +---
arch/powerpc/mm/fault.c | 25 +
arch/s390/mm/fault.c| 25 +
.
This uncovered a possible bug in the s390 version as that purely
copied the x86 version unconditionally passing 14 as the trapnr
rather than the error_code parameter. s390 is changed to pass
error_code in this patch.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/avr32/mm/fault.c | 21
out before hitting kprobe_running().
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
include/linux/kprobes.h | 19 ---
1 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h
index c01e320..e61607a 100644
--- a/include
On Wed, 2008-01-09 at 22:05 -0800, Arjan van de Ven wrote:
Subject: Make the 32 bit Frame Pointer backtracer fall back to traditional
From: Arjan van de Ven [EMAIL PROTECTED]
The 32 bit Frame Pointer backtracer code checks if the EBP is valid
to do a backtrace; however currently on a failure
Similar cleanup was done when unifying kprobes_32|64.c and
wrmsr() was chosen there over wrmsrl().
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Ingo, only chose this direction based on the kprobes.c unification.
arch/x86/kernel/step.c |4
1 files changed, 0 insertions(+), 4
get_segment_eip has similarities to convert_rip_to_linear(),
and is used in a similar context. Move get_segment_eip to
step.c to allow easier consolidation.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Ingo, you may want to fold this into my previous patch:
x86: begin fault_{32|64}.c
On Wed, 2008-01-09 at 07:14 +0100, Heiko Carstens wrote:
> > +/*
> > + * If it is a kprobe pagefault we can not be premptible so return before
>
> Missing 'e' in preemptible.
OK.
> However, the old code you removed had a lot of preempt_disable/enable calls
> that you removed. Hope you checked
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/avr32/mm/fault.c | 21 +
arch/ia64/mm/fault.c| 24 +---
arch/powerpc/mm/fault.c | 25 +
arch/s390/mm/fault.c| 25 +
arch/sparc64
()/oops_end(). Small whitespace change in
traps_64.c for easier comparison between the two.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/traps_32.c | 137 +++-
arch/x86/kernel/traps_64.c | 11 +--
2 files changed, 76 inse
Use the fixup_exception() helper instead of the open-coded
search_extable() users.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, this depends on my patch in x86.git unifying extable.c that
introduces fixup_exception() to X86_64.
arch/x86/kernel/traps_64.c
Small step towards unifying traps_32|64.c. No functional
changes. Pull out a small helper from an if() statement
in die().
Marked as __kprobes as eventually we will want to call this
from do_page_fault similar to how X86_64 does it.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
On Tue, 2008-01-08 at 16:48 -0800, Harvey Harrison wrote:
> Small step towards unifying traps_32|64.c. No functional
> changes. Pull out a small helper from an if() statement
> in die().
>
> Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
> ---
> Ingo, I kno
Should be the last of the error_code tests that could use
the PF_ defines. Makes X86_32|64 a little closer.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/mm/fault_32.c |7 ---
arch/x86/mm/fault_64.c |2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
Small step towards unifying traps_32|64.c. No functional
changes. Pull out a small helper from an if() statement
in die().
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, I know this will have checkpatch problems, doing code
movement first, will do the cleanup as a final ste
On Wed, 2008-01-09 at 09:45 +1100, Paul Mackerras wrote:
> Harvey Harrison writes:
>
> > Use a central is_kprobe_fault() inline in kprobes.h to remove all
> > of the arch-dependant, practically identical implementations in
> > avr32, ia64, powerpc, s390, sparc64, an
On Wed, 2008-01-09 at 09:45 +1100, Paul Mackerras wrote:
Harvey Harrison writes:
Use a central is_kprobe_fault() inline in kprobes.h to remove all
of the arch-dependant, practically identical implementations in
avr32, ia64, powerpc, s390, sparc64, and x86.
I don't like the name
Small step towards unifying traps_32|64.c. No functional
changes. Pull out a small helper from an if() statement
in die().
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Ingo, I know this will have checkpatch problems, doing code
movement first, will do the cleanup as a final step once
we
Should be the last of the error_code tests that could use
the PF_ defines. Makes X86_32|64 a little closer.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/mm/fault_32.c |7 ---
arch/x86/mm/fault_64.c |2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git
501 - 600 of 799 matches
Mail list logo
