; SDP and PPS types. The mirroring is intentional so as to not impact
> existing usage of the 'type' property.
>
> Signed-off-by: Adam Thomson
Reviewed-by: Heikki Krogerus
> ---
> Documentation/ABI/testing/sysfs-class-power | 12
> drivers/power/supply/power_s
_thermal() will try to dereference the pointer
> thus causing a kernel dump.
>
> This commit updates the registration code to add some basic
> checks on the desc pointer validity, name, and presence of
> properties.
>
> Signed-off-by: Adam Thomson
Reviewed-by: Heik
USB related properties have been listed.
>
> Signed-off-by: Adam Thomson
Thank you a lot for doing this Adam! FWIW:
Reviewed-by: Heikki Krogerus
> ---
> Documentation/ABI/testing/sysfs-class-power | 443
>
> MAINTAINERS
. Change this to depend on CONFIG_TRACING like
> other users of tracepoints do.
>
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Signed-off-by: Tobias Regnery
Acked-by: Heikki Krogerus
Thanks,
--
heikki
Hi Tobias,
On Mon, Apr 09, 2018 at 01:40:53PM +0200, Tobias Regnery wrote:
> You are right, building a defconfig, enable the UCSI driver and disable
> CONFIG_FTRACE indeed builds without problems. So it must be some other
> combination of config options. Attached is the randconfig which triggers
>
On Mon, Apr 09, 2018 at 09:55:17AM +0200, Tobias Regnery wrote:
> The ucsi driver defines several tracepoints, but the header file with the
> tracepoint definition trace.h is only conditionally built depending on
> CONFIG_FTRACE.
You mean trace.c, right? The definitions are indeed in the header,
t
Using reStructuredText literal-block element with ascii-art.
That prevents the ascii art from being processed as
reStructuredText.
Reported-by: Masanari Iida
Fixes: bdecb33af34f ("usb: typec: API for controlling USB Type-C Multiplexers")
Signed-off-by: Heikki Krogerus
---
Change
Hi Markus,
On Fri, Apr 06, 2018 at 12:03:55PM +0200, Markus Heiser wrote:
> >> There are ways to do this, look at how the v4l2 and I think the drm
> >> subsystems handle ascii art such that "real" drawings end up being
> >> produced.
> >
> > Thanks. I did not actually find anything else except us
On Fri, Apr 06, 2018 at 11:22:29AM +0300, Heikki Krogerus wrote:
> To prevent processing of ascii art as reStructuredText
> elements, marking it as a comment.
I will change this, and use literal-block instead.
> Reported-by: Masanari Iida
> Fixes: bdecb33af34f ("usb: typec: AP
On Fri, Apr 06, 2018 at 10:30:10AM +0200, Greg KH wrote:
> On Fri, Apr 06, 2018 at 11:15:55AM +0300, Heikki Krogerus wrote:
> > On Fri, Apr 06, 2018 at 09:57:34AM +0200, Greg KH wrote:
> > > On Fri, Apr 06, 2018 at 10:51:09AM +0300, Heikki Krogerus wrote:
> > > > On F
To prevent processing of ascii art as reStructuredText
elements, marking it as a comment.
Reported-by: Masanari Iida
Fixes: bdecb33af34f ("usb: typec: API for controlling USB Type-C Multiplexers")
Signed-off-by: Heikki Krogerus
---
Documentation/driver-api/usb/typec.rst | 2 +-
1 fi
On Fri, Apr 06, 2018 at 09:57:34AM +0200, Greg KH wrote:
> On Fri, Apr 06, 2018 at 10:51:09AM +0300, Heikki Krogerus wrote:
> > On Fri, Apr 06, 2018 at 12:38:42PM +0900, Masanari Iida wrote:
> > > After merge following patch during 4.17 merger period,
> > > make xmldo
On Fri, Apr 06, 2018 at 12:38:42PM +0900, Masanari Iida wrote:
> After merge following patch during 4.17 merger period,
> make xmldocs start to fail with error.
>
> [bdecb33af34f79cbfbb656661210f77c8b8b5b5f]
> usb: typec: API for controlling USB Type-C Multiplexers
>
> Error messages.
> reST mar
Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v3:
-Add #include-s for a few missing headers to drivers/usb/typec/mux.c
-Various spelling and gramar fixes in the docs pointed out by Randy Dunlap
---
Documentation/driver-api/usb/typec.rst
-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v3:
-Add Guenter's Reviewed-by
Changes in v2:
-Added Heikki's Reviewed-by
---
drivers/usb/typec/Kconfig | 1 +
drivers/usb/typec/fusb302/fusb302.c | 1 -
drivers/usb/typec/tcpm.c
clearly according to the
newest specifications, introducing separate definitions for
the data roles.
Reviewed-by: Guenter Roeck
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 56 ++---
drivers/usb/typec/fusb302/fusb302.c | 1 +
driv
on devices with an INT3496 ACPI device
-Charger-type misdetection (always SDP) on devices with an INT3496 when the
USB role (always) gets initialized as host
Signed-off-by: Hans de Goede
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Review
-by: Mathias Nyman
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v2:
-Use SPDX license header
-Various small style cleanups / changes
-Add Heikki's Reviewed-by
Changes from some time ago when this patch was part of ano
From: Hans de Goede
Add a driver for the Pericom PI3USB30532 Type-C cross switch /
mux chip found on some devices with a Type-C port.
Signed-off-by: Hans de Goede
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v7:
- Remove unneeded semicolon
Changes in v4:
-Add
that our read/write/modify of cfg0 may race with the AML code
doing the same to avoid this we take the global ACPI lock while doing
the read/write/modify.
Signed-off-by: Hans de Goede
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v7:
- Declare intel_xhci_usb_remove
goal is to ultimately extract the
connection descriptions also from firmware by using the
fwnode_graph_* functions and other mechanisms that are
available.
Reviewed-by: Hans de Goede
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v9
- Now really stop using rcu
_not_ stay in their last mode after a detach.
Signed-off-by: Hans de Goede
Reviewed-by: Guenter Roeck
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v3:
-Add Guenter's Reviewed-by
Changes in v2:
-Added Heikki
o tie together these muxes
and the Type-C Port Manager (tcpm) code, using the then new drivers/mux
framework. But the way I used the mux framework went against what it was
designed for, so in the end that series got nowhere.
Heikki Krogerus from Intel, who maintains the USB TYPEC subsystem, has
recently
Type-C drivers for the control.
For other types of USB connectors (mainly microAB) the class
provides user space control via sysfs attribute file that
can be used to request role swapping from the switch.
Reviewed-by: Hans de Goede
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
when we want to loop through all capabilities.
Signed-off-by: Mathias Nyman
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v2:
-Added Heikki's Reviewed-by
---
drivers/usb/host/xhci-ext-caps.h | 5 +++--
1 file
From: Hans de Goede
We need to add device-connections for the Type-C mux/switch and usb-role
code to be able to find the PI3USB30532 Type-C cross-switch and the
device/host role-switch integrated in the CHT SoC.
Signed-off-by: Hans de Goede
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki
On Tue, Mar 20, 2018 at 01:21:57PM +0100, Hans de Goede wrote:
> On 20-03-18 11:32, Heikki Krogerus wrote:
> > On Tue, Mar 20, 2018 at 12:04:12PM +0200, Heikki Krogerus wrote:
> > > > > +void device_connection_remove(struct device_connection *con)
> > >
On Tue, Mar 20, 2018 at 12:04:12PM +0200, Heikki Krogerus wrote:
> > > +void device_connection_remove(struct device_connection *con)
> > > +{
> > > + mutex_lock(&devcon_lock);
> > > + list_del_rcu(&con->list);
> >
> > See, rcu?
>
&g
On Tue, Mar 20, 2018 at 10:20:04AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Mar 14, 2018 at 04:12:04PM +0300, Heikki Krogerus wrote:
> > Several frameworks - clk, gpio, phy, pmw, etc. - maintain
> > lookup tables for describing connections and provide custom
> > API fo
Hi Guenter,
On Fri, Mar 16, 2018 at 02:32:06PM -0700, Guenter Roeck wrote:
> On Fri, Mar 09, 2018 at 06:19:18PM +0300, Heikki Krogerus wrote:
> > This adds more complete handling of VDMs and registration of
> > partner alternate modes, and introduces callbacks for
> > alte
Hi Guenter,
On Fri, Mar 16, 2018 at 02:33:36PM -0700, Guenter Roeck wrote:
> On Fri, Mar 09, 2018 at 06:19:17PM +0300, Heikki Krogerus wrote:
> > diff --git a/drivers/usb/typec/bus.c b/drivers/usb/typec/bus.c
> > new file mode 100644
> > index ..92944aaf3
igned-off-by: ShuFan Lee
Looks OK to me. I'll put a few nitpics below in case you make one more
version for some other reason. In any case:
Reviewed-by: Heikki Krogerus
> ---
> drivers/staging/typec/Kconfig | 8 +
> drivers/staging/typec/Makefile| 1 +
> dr
Hi ShuFan,
On Fri, Mar 16, 2018 at 05:12:49PM +0800, ShuFan Lee wrote:
> +static int rt1711h_init_gpio(struct rt1711h_chip *chip)
> +{
> + int ret;
> + struct device_node *np = chip->dev->of_node;
> +
> + ret = of_get_named_gpio(np, "rt,intr_gpio", 0);
> + if (ret < 0) {
> +
Hi,
On Wed, Mar 14, 2018 at 10:50:12AM +0200, Felipe Balbi wrote:
> >>> - Support to replace pip3 clock going to DWC3 with utmi clock
> >>>for hardware configuration where SSPHY is not used with DWC3.
> >> Is that SW configurable? Really? In any case seems like this and SESSVLD
> >> valid sho
goal is to ultimately extract the
connection descriptions also from firmware by using the
fwnode_graph_* functions and other mechanisms that are
available.
Reviewed-by: Hans de Goede
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v8:
- No longer using rcu.
Changes in v7
Type-C drivers for the control.
For other types of USB connectors (mainly microAB) the class
provides user space control via sysfs attribute file that
can be used to request role swapping from the switch.
Reviewed-by: Hans de Goede
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
clearly according to the
newest specifications, introducing separate definitions for
the data roles.
Reviewed-by: Guenter Roeck
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 56 ++---
drivers/usb/typec/fusb302/fusb302.c | 1 +
driv
-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v3:
-Add Guenter's Reviewed-by
Changes in v2:
-Added Heikki's Reviewed-by
---
drivers/usb/typec/Kconfig | 1 +
drivers/usb/typec/fusb302/fusb302.c | 1 -
drivers/usb/typec/tcpm.c
_not_ stay in their last mode after a detach.
Signed-off-by: Hans de Goede
Reviewed-by: Guenter Roeck
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v3:
-Add Guenter's Reviewed-by
Changes in v2:
-Added Heikki
that our read/write/modify of cfg0 may race with the AML code
doing the same to avoid this we take the global ACPI lock while doing
the read/write/modify.
Signed-off-by: Hans de Goede
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v7:
- Declare intel_xhci_usb_remove
when we want to loop through all capabilities.
Signed-off-by: Mathias Nyman
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v2:
-Added Heikki's Reviewed-by
---
drivers/usb/host/xhci-ext-caps.h | 5 +++--
1 file
-by: Mathias Nyman
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v2:
-Use SPDX license header
-Various small style cleanups / changes
-Add Heikki's Reviewed-by
Changes from some time ago when this patch was part of ano
From: Hans de Goede
Add a driver for the Pericom PI3USB30532 Type-C cross switch /
mux chip found on some devices with a Type-C port.
Signed-off-by: Hans de Goede
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v7:
- Remove unneeded semicolon
Changes in v4:
-Add
on devices with an INT3496 ACPI device
-Charger-type misdetection (always SDP) on devices with an INT3496 when the
USB role (always) gets initialized as host
Signed-off-by: Hans de Goede
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Review
From: Hans de Goede
We need to add device-connections for the Type-C mux/switch and usb-role
code to be able to find the PI3USB30532 Type-C cross-switch and the
device/host role-switch integrated in the CHT SoC.
Signed-off-by: Hans de Goede
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki
Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v3:
-Add #include-s for a few missing headers to drivers/usb/typec/mux.c
-Various spelling and gramar fixes in the docs pointed out by Randy Dunlap
---
Documentation/driver-api/usb/typec.rst
I submitted a patch-series to tie together these muxes
and the Type-C Port Manager (tcpm) code, using the then new drivers/mux
framework. But the way I used the mux framework went against what it was
designed for, so in the end that series got nowhere.
Heikki Krogerus from Intel, who maintains the USB
On Wed, Mar 14, 2018 at 12:16:05PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Mar 12, 2018 at 05:34:20PM +0300, Heikki Krogerus wrote:
> > Several frameworks - clk, gpio, phy, pmw, etc. - maintain
> > lookup tables for describing connections and provide custom
> > API fo
Type-C drivers for the control.
For other types of USB connectors (mainly microAB) the class
provides user space control via sysfs attribute file that
can be used to request role swapping from the switch.
Reviewed-by: Hans de Goede
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v3:
-Add #include-s for a few missing headers to drivers/usb/typec/mux.c
-Various spelling and gramar fixes in the docs pointed out by Randy Dunlap
---
Documentation/driver-api/usb/typec.rst
clearly according to the
newest specifications, introducing separate definitions for
the data roles.
Reviewed-by: Guenter Roeck
Signed-off-by: Heikki Krogerus
---
Changes in v7:
- This patch was added to the series
---
drivers/usb/typec/class.c | 56 ++--
_not_ stay in their last mode after a detach.
Signed-off-by: Hans de Goede
Revieved-by: Heikki Krogerus
Reviewed-by: Guenter Roeck
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v3:
-Add Guenter's Reviewed-by
Cha
that our read/write/modify of cfg0 may race with the AML code
doing the same to avoid this we take the global ACPI lock while doing
the read/write/modify.
Signed-off-by: Hans de Goede
Reviewed-by: Heikki Krogerus
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v7
when we want to loop through all capabilities.
Signed-off-by: Mathias Nyman
Revieved-by: Heikki Krogerus
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v2:
-Added Heikki's Reviewed-by
---
drivers/usb/host/xhci-ext-
-by: Mathias Nyman
Revieved-by: Heikki Krogerus
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v2:
-Use SPDX license header
-Various small style cleanups / changes
-Add Heikki's Reviewed-by
Changes from some time ago
From: Hans de Goede
Add a driver for the Pericom PI3USB30532 Type-C cross switch /
mux chip found on some devices with a Type-C port.
Signed-off-by: Hans de Goede
Reviewed-by: Heikki Krogerus
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v7:
- Remove unneeded
on devices with an INT3496 ACPI device
-Charger-type misdetection (always SDP) on devices with an INT3496 when the
USB role (always) gets initialized as host
Signed-off-by: Hans de Goede
Reviewed-by: Heikki Krogerus
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v4
From: Hans de Goede
We need to add device-connections for the Type-C mux/switch and usb-role
code to be able to find the PI3USB30532 Type-C cross-switch and the
device/host role-switch integrated in the CHT SoC.
Signed-off-by: Hans de Goede
Reviewed-by: Heikki Krogerus
Reviewed-by: Andy
From: Hans de Goede
Remove the unused (not implemented anywhere) tcpc_mux_dev abstraction
and replace it with calling the new typec_set_orientation,
usb_role_switch_set and typec_set_mode functions.
Signed-off-by: Hans de Goede
Revieved-by: Heikki Krogerus
Reviewed-by: Guenter Roeck
Reviewed
goal is to ultimately extract the
connection descriptions also from firmware by using the
fwnode_graph_* functions and other mechanisms that are
available.
Reviewed-by: Hans de Goede
Reviewed-by: Andy Shevchenko
Signed-off-by: Heikki Krogerus
---
Changes in v7:
- API naming improvements suggested
muxes
and the Type-C Port Manager (tcpm) code, using the then new drivers/mux
framework. But the way I used the mux framework went against what it was
designed for, so in the end that series got nowhere.
Heikki Krogerus from Intel, who maintains the USB TYPEC subsystem, has
recently been working
On Mon, Mar 12, 2018 at 10:19:34AM +0100, Hans de Goede wrote:
> > > I currently have significantly less bandwidth for this due to
> > > personal circumstances, so if a new version of this patch-set
> > > is necessary it would be great if you (Heikki) can do a v7.
> >
> > Sure thing. I'll prepare
On Sun, Mar 11, 2018 at 07:24:18PM +0100, Hans de Goede wrote:
> Hi all,
>
> On 09-03-18 18:53, Greg Kroah-Hartman wrote:
> > On Fri, Mar 02, 2018 at 11:20:46AM +0100, Hans de Goede wrote:
> > > From: Heikki Krogerus
> > >
> > > Several framewo
Before a device was created for every discovered SVID, but
this will create a device for every discovered mode of every
SVID. The idea is to make it easier to create mode specific
drivers once a bus for the alternate mode is added.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c
Introducing a simple bus for the alternate modes. Bus allows
binding drivers to the discovered alternate modes the
partners support.
Signed-off-by: Heikki Krogerus
---
Documentation/ABI/obsolete/sysfs-class-typec | 48 +++
Documentation/ABI/testing/sysfs-bus-typec| 51
Documentation
This adds more complete handling of VDMs and registration of
partner alternate modes, and introduces callbacks for
alternate mode operations.
Only DFP role is supported for now.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/tcpm.c | 133 +++
1
no solution for the "platform data" case
where we have neither DT nor ACPI to describe the connections for us.
[1] Documentation/devicetree/bindings/graph.txt
[2] Documentation/acpi/dsd/graph.txt
Heikki Krogerus (3):
usb: typec: Register a device for every mode
usb: typec: Bus
On Mon, Mar 05, 2018 at 09:18:10AM +0100, Andrzej Hajda wrote:
> On 02.03.2018 14:13, Heikki Krogerus wrote:
> > Hi,
> >
> > On Tue, Feb 27, 2018 at 08:11:29AM +0100, Andrzej Hajda wrote:
> >> +2. USB-C connector attached to CC controller (s2mm005), HS lines
Hi,
On Tue, Feb 27, 2018 at 08:11:29AM +0100, Andrzej Hajda wrote:
> +2. USB-C connector attached to CC controller (s2mm005), HS lines routed
> +to companion PMIC (max77865), SS lines to USB3 PHY and SBU to DisplayPort.
> +DisplayPort video lines are routed to the connector via SS mux in USB3 PHY.
Hi,
On Thu, Mar 01, 2018 at 12:56:57AM +, Jun Li wrote:
> > +struct device *device_find_connection(struct device *dev, const char
> > +*con_id) {
> > + return __device_find_connection(dev, con_id, generic_match, NULL); }
>
> - return __device_find_connection(dev, con_id, generic_match
On Wed, Feb 28, 2018 at 04:42:32PM +0100, Hans de Goede wrote:
> Hi,
>
> On 28-02-18 16:15, Heikki Krogerus wrote:
> > On Wed, Feb 28, 2018 at 04:07:45PM +0100, Hans de Goede wrote:
> > > diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> > > index
On Wed, Feb 28, 2018 at 04:07:45PM +0100, Hans de Goede wrote:
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index 96099a245c69..5917e3095e2a 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -1825,6 +1825,7 @@ struct xhci_hcd {
> /* Reserved. It was
ndows.
>
> The presence of AML code which modifies the cfg0 reg (on some systems)
> means that our read/write/modify of cfg0 may race with the AML code
> doing the same to avoid this we take the global ACPI lock while doing
> the read/write/modify.
>
> Signed-off-by: Hans de Go
On Fri, Feb 16, 2018 at 04:07:59PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 16, 2018 at 12:47 PM, Hans de Goede wrote:
>
> > USB role switch is a device that can be used to choose the
> > data role for USB connector. With dual-role capable USB
> > controllers, the controller itself will be the
le (always) gets initialized as host
>
> Signed-off-by: Hans de Goede
After addressing Andy's comments:
Reviewed-by: Heikki Krogerus
Thanks,
--
heikki
: Hans de Goede
Reviewed-by: Heikki Krogerus
Thanks,
--
heikki
On Fri, Feb 16, 2018 at 11:47:49AM +0100, Hans de Goede wrote:
> Add a driver for the Pericom PI3USB30532 Type-C cross switch /
> mux chip found on some devices with a Type-C port.
>
> Signed-off-by: Hans de Goede
Reviewed-by: Heikki Krogerus
Thanks,
--
heikki
On Fri, Feb 16, 2018 at 11:47:48AM +0100, Hans de Goede wrote:
> diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile
> index 060643a1b5c8..7d1b8c82b208 100644
> --- a/drivers/usb/Makefile
> +++ b/drivers/usb/Makefile
> @@ -65,3 +65,5 @@ obj-$(CONFIG_USB_COMMON)+= common/
> obj-$(CONFIG_US
ci_ext_cap_init() a call to it should also
> be added to other bus probe paths.
>
> Signed-off-by: Hans de Goede
> Acked-by: Mathias Nyman
Reviewed-by: Heikki Krogerus
Thanks,
--
heikki
capability with matching id
>
> capability id 0 is not used by xhci (reserved)
>
> This is useful when we want to loop through all capabilities.
>
> Signed-off-by: Mathias Nyman
> Signed-off-by: Hans de Goede
FWIW:
Reviewed-by: Heikki Krogerus
Br,
--
heikki
e
Reviewed-by: Heikki Krogerus
Thanks,
--
heikki
This commit also makes tcpm_reset_port() call tcpm_mux_set(port,
> TYPEC_MUX_NONE, USB_ROLE_NONE) so that the mux and switch
> do _not_ stay in their last mode after a detach.
>
> Signed-off-by: Hans de Goede
I'm happy with this, but Guenter should also check tcpm changes.
Reviewe
On Fri, Feb 16, 2018 at 12:21:15PM +0100, Hans de Goede wrote:
> Hi,
>
> On 16-02-18 12:00, Andy Shevchenko wrote:
> > On Fri, Feb 16, 2018 at 12:47 PM, Hans de Goede wrote:
> > > From: Heikki Krogerus
> > >
> > > Several frameworks - clk, gpio, phy
On Wed, Feb 14, 2018 at 05:24:04PM +0800, ShuFanLee wrote:
> From: ShuFanLee
>
> Handle vendor defined behavior in tcpci_init and tcpci_irq.
> More operations can be extended in tcpci_vendor_data if needed.
> According to TCPCI specification, 4.4.5.2 ROLE_CONTROL,
> TCPC shall not start DRP toggl
Hi Adam,
On Tue, Feb 06, 2018 at 03:51:26PM +, Adam Thomson wrote:
> Right now there is no documentation for the generic psy class. The stuff in
> sysfs-class-power is device specific property information, and the same goes
> for
> sysfs-class-power-twl4030. The property usage can vary depend
On Tue, Feb 06, 2018 at 02:33:08PM +, Adam Thomson wrote:
> On 30 January 2018 12:47, Heikki Krogerus wrote:
>
> > > +static int tcpm_pps_set_op_curr(struct tcpm_port *port, u16 op_curr)
> > > +{
> > > + unsigned int target_mw;
> > > + int ret = 0;
&
On Tue, Jan 02, 2018 at 03:50:48PM +, Adam Thomson wrote:
> This patch set adds sink side support for the PPS feature introduced in the
> USB PD 3.0 specification.
>
> The source PPS supply is represented using the Power Supply framework to
> provide
> access and control APIs for dealing with
added. Sending of
> Not_Supported is added is added to handle messages
> received but not yet handled.
>
> Signed-off-by: Adam Thomson
FWIW:
Acked-by: Heikki Krogerus
--
heikki
Hi Adam,
On Tue, Jan 02, 2018 at 03:50:54PM +, Adam Thomson wrote:
> This commit adds a power_supply class instance to represent a
> PD source's voltage and current properties. This provides an
> interface for reading these properties from user-space or other
> drivers.
>
> For PPS enabled So
and in addition has
> the PPS type. In the future this can be extended further for other
> types which have multiple connected types supported. The mirroring
> is intentional so as to not impact existing usage of the 'type'
> property.
>
> Signed-off-by: Adam Thomson
On Tue, Jan 02, 2018 at 03:50:52PM +, Adam Thomson wrote:
> This commit adds code to handle requesting of PPS APDOs. Switching
> between standard PDOs and APDOs, and re-requesting an APDO to
> modify operating voltage/current will be triggered by an
> external call into TCPM.
>
> Signed-off-by
On Tue, Jan 02, 2018 at 03:50:51PM +, Adam Thomson wrote:
> This commit adds a header providing definitions for handling
> Status messages. Currently the header only focuses on handling
> incoming Status messages.
>
> Signed-off-by: Adam Thomson
Acked-by: Heikki Kro
On Tue, Jan 02, 2018 at 03:50:50PM +, Adam Thomson wrote:
> This commit adds a header providing definitions for handling Alert
> messages. Currently the header only focuses on handling incoming
> alerts.
>
> Signed-off-by: Adam Thomson
Acked-by: Heikki Krogerus
Thanks,
--
heikki
per line in several places in this series, and I many cases it
does not look like splitting the line would make the code any less
readable.
But I don't think that is critical, so if there are no other comments:
Acked-by: Heikki Krogerus
> ---
> inclu
Hi,
On Fri, Jan 19, 2018 at 09:01:24AM +, shufan_lee(?|) wrote:
> Hi Heikki,
>
> For example, the flow of tcpci_init is a little bit different.
> In tcpci_init, there are more parameters need to be set for RT1711H.
Different init parameters is really not a reason for a fork of the
dr
Hi Shu-Fan,
On Fri, Jan 19, 2018 at 05:48:02AM +, shufan_lee(?) wrote:
> Hi Jun,
>
> For now, RT1711H is not fully compatible with TCPCI. So the existing tcpci.c
> may not work for it.
The datasheet for RT1711H does talk about TCPCi and TCPM+TCPC [1].
What are the differences tha
Hi Greg,
On Wed, Jan 17, 2018 at 12:14:02PM +0100, Greg KH wrote:
> On Wed, Jan 17, 2018 at 01:08:58PM +0200, Heikki Krogerus wrote:
> > Hi,
> >
> > On Wed, Jan 17, 2018 at 09:30:45AM +, shufan_lee(?) wrote:
> > > Dear Heikki,
> > >
> >
Hi,
On Wed, Jan 17, 2018 at 09:30:45AM +, shufan_lee(?) wrote:
> Dear Heikki,
>
> Sorry for bothering.
>
> Just want to check is there anything we need to modify?
I'll check the patch this week, but please note that we are -rc8, so
nothing is going to happen before -rc1 is out.
On Tue, Dec 05, 2017 at 07:34:55AM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
>
> Signed-off-by: Pravin Shedge
Acked-by: Heikki Krogerus
> ---
On Mon, Nov 27, 2017 at 04:54:08PM +, Adam Thomson wrote:
> On 27 November 2017 14:12, Heikki Krogerus wrote:
>
> > Hi Adam,
> >
> > On Fri, Nov 24, 2017 at 02:05:27PM +, Adam Thomson wrote:
> > > On 24 November 2017 12:19, Heikki Krogerus wrote:
>
801 - 900 of 1619 matches
Mail list logo
