Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

On Wed, 2016-11-23 at 19:32 +0100, Matthias Brugger wrote: > Hi Hongzhou, > > On 12/05/16 04:55, Hongzhou Yang wrote: > > On Wed, 2016-05-11 at 19:09 -0700, Hongzhou Yang wrote: > >> On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote: > >>> Hi, > >

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

On Wed, 2016-11-23 at 19:32 +0100, Matthias Brugger wrote: > Hi Hongzhou, > > On 12/05/16 04:55, Hongzhou Yang wrote: > > On Wed, 2016-05-11 at 19:09 -0700, Hongzhou Yang wrote: > >> On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote: > >>> Hi, > >

Re: [RESEND PATCH] pinctrl: mt8173: set GPIO16 to usb iddig mode

, > + MTK_EINT_FUNCTION(1, 16), > MTK_FUNCTION(0, "GPIO16"), > MTK_FUNCTION(1, "IDDIG"), > MTK_FUNCTION(2, "CMFLASH"), Acked-by: Hongzhou Yang <hongzhou.y...@mediatek.com> Thanks, Hongzhou

Re: [RESEND PATCH] pinctrl: mt8173: set GPIO16 to usb iddig mode

, 16), > MTK_FUNCTION(0, "GPIO16"), > MTK_FUNCTION(1, "IDDIG"), > MTK_FUNCTION(2, "CMFLASH"), Acked-by: Hongzhou Yang Thanks, Hongzhou

Re: [PATCH] pinctrl: mediatek: use builtin_platform_driver

tic struct platform_driver mtk_pinctrl_driver = { > }, > }; > > -static int __init mtk_pinctrl_init(void) > -{ > - return platform_driver_register(_pinctrl_driver); > -} > -device_initcall(mtk_pinctrl_init); > +builtin_platform_driver(mtk_pinctrl_driver); Acked-by: Hongzhou Yang <hongzhou.y...@mediatek.com> Thanks, Hongzhou

Re: [PATCH] pinctrl: mediatek: use builtin_platform_driver

ruct platform_driver mtk_pinctrl_driver = { > }, > }; > > -static int __init mtk_pinctrl_init(void) > -{ > - return platform_driver_register(_pinctrl_driver); > -} > -device_initcall(mtk_pinctrl_init); > +builtin_platform_driver(mtk_pinctrl_driver); Acked-by: Hongzhou Yang Thanks, Hongzhou

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

On Wed, 2016-05-11 at 19:09 -0700, Hongzhou Yang wrote: > On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote: > > Hi, > > > > On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote: > > > On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote: > > > >

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

On Wed, 2016-05-11 at 19:09 -0700, Hongzhou Yang wrote: > On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote: > > Hi, > > > > On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote: > > > On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote: > > > >

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote: > Hi, > > On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote: > > On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote: > > > On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun > > >

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote: > Hi, > > On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote: > > On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote: > > > On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun > > > wrote: > > &g

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote: > On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun > wrote: > > > the default mode of GPIO16 pin is gpio, when set EINT16 to > > IRQ_TYPE_LEVEL_HIGH, no interrupt is triggered, it can be > > fixed when set its

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote: > On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun > wrote: > > > the default mode of GPIO16 pin is gpio, when set EINT16 to > > IRQ_TYPE_LEVEL_HIGH, no interrupt is triggered, it can be > > fixed when set its default mode as usb iddig. > > >

Re: [PATCH v2] pinctrl: mediatek: correct debounce time unit in mtk_gpio_set_debounce

unce setting is 500us, > correct this as well. > > While I'm at it, also change the debounce time array name to > "debounce_time" for readability. > > Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> Acked-by: Hongzhou Yang <hongzhou.y...@mediatek.com>

Re: [PATCH v2] pinctrl: mediatek: correct debounce time unit in mtk_gpio_set_debounce

unce setting is 500us, > correct this as well. > > While I'm at it, also change the debounce time array name to > "debounce_time" for readability. > > Signed-off-by: Yingjoe Chen Acked-by: Hongzhou Yang > --- > This was based on v4.6-rc1 > Change since v1: >

Re: [PATCH 2/8] drivers/pinctrl: make mediatek/pinctrl-mt6397 driver explicitly non-modular

mit. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > Cc: Linus Walleij <linus.wall...@linaro.org> &

Re: [PATCH 2/8] drivers/pinctrl: make mediatek/pinctrl-mt6397 driver explicitly non-modular

mit. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > Cc: Linus Walleij > Cc: Matthias Brugg

Re: [PATCH 13/50] pinctrl: mtk-common: Use devm_pinctrl_register() for pinctrl registration

On Wed, 2016-02-24 at 18:45 +0530, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and clean > the error path. > > Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> > Cc: Matthias Brugger <matthias@gmail.com> >

Re: [PATCH 13/50] pinctrl: mtk-common: Use devm_pinctrl_register() for pinctrl registration

On Wed, 2016-02-24 at 18:45 +0530, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and clean > the error path. > > Signed-off-by: Laxman Dewangan > Cc: Matthias Brugger > Cc: Hongzhou Yang > Cc: Yingjoe Chen > --- Acked-by: Hongzhou

Re: [PATCH 1/2] pinctrl: mediatek: fix direction control issue

On Fri, 2016-02-05 at 14:52 +0100, Linus Walleij wrote: > On Thu, Feb 4, 2016 at 4:03 AM, Hongzhou Yang > wrote: > > On Wed, 2016-02-03 at 09:24 +0800, Biao Huang wrote: > >> Since input-enable/disable and input-schmitt-enable/disable are > >> workable when g

Re: [PATCH 1/2] pinctrl: mediatek: fix direction control issue

On Fri, 2016-02-05 at 14:52 +0100, Linus Walleij wrote: > On Thu, Feb 4, 2016 at 4:03 AM, Hongzhou Yang > <hongzhou.y...@mediatek.com> wrote: > > On Wed, 2016-02-03 at 09:24 +0800, Biao Huang wrote: > >> Since input-enable/disable and input-schmitt-enable/disable

Re: [PATCH 1/2] pinctrl: mediatek: fix direction control issue

On Wed, 2016-02-03 at 09:24 +0800, Biao Huang wrote: > Since input-enable/disable and input-schmitt-enable/disable are > workable when gpio direction is input, so add direction setting > when do input-enable/disable and input-schmitt-enable/disable > properties. > > Signed-off-by: Biao Huang >

Re: [PATCH 1/2] pinctrl: mediatek: fix direction control issue

On Wed, 2016-02-03 at 09:24 +0800, Biao Huang wrote: > Since input-enable/disable and input-schmitt-enable/disable are > workable when gpio direction is input, so add direction setting > when do input-enable/disable and input-schmitt-enable/disable > properties. > > Signed-off-by: Biao Huang

[PATCH] pinctrl: mediatek: fix a memleak when do dt maps.

configs will kmemdup to dup_configs in pictrl util function. So configs need to be freed. Signed-off-by: Hongzhou Yang Reviewed-by: Daniel Kurtz Reviewed-by: Matthias Brugger --- Fix a memleak issue. According to Yingjoe's comment, add return checek for pinconf_generic_parse_dt_config

[PATCH] pinctrl: mediatek: Add get_direction support.

Since Linux gpio framework return 0 for output, 1 for input. But HW use 0 stands for input, and 1 stands for output. So use negative to correct it. And gpio_chip.get is used to get input value, no need to get output value, so removing it. Signed-off-by: Hongzhou Yang --- Base on v4.4-rc1

[PATCH] pinctrl: mediatek: fix a memleak when do dt maps.

configs will kmemdup to dup_configs in pictrl util function. So configs need to be freed. Signed-off-by: Hongzhou Yang <hongzhou.y...@mediatek.com> Reviewed-by: Daniel Kurtz <djku...@chromium.org> Reviewed-by: Matthias Brugger <matthias@gmail.com> --- Fix a memleak

[PATCH] pinctrl: mediatek: Add get_direction support.

Since Linux gpio framework return 0 for output, 1 for input. But HW use 0 stands for input, and 1 stands for output. So use negative to correct it. And gpio_chip.get is used to get input value, no need to get output value, so removing it. Signed-off-by: Hongzhou Yang <hongzhou.y...@mediatek.

[PATCH] pinctrl: mediatek: fix a memleak when do dt maps.

configs will kmemdup to dup_configs in pictrl util function. So configs need to be freed. Signed-off-by: Hongzhou Yang --- Fix a memleak issue. drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git

[PATCH] pinctrl: mediatek: fix a memleak when do dt maps.

configs will kmemdup to dup_configs in pictrl util function. So configs need to be freed. Signed-off-by: Hongzhou Yang --- Fix a memleak issue. drivers/pinctrl/mediatek/pinctrl-mtk-common.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mediatek

[PATCH] pinctrl: mediatek: fix a memleak when do dt maps.

configs will kmemdup to dup_configs in pictrl util function. So configs need to be freed. Signed-off-by: Hongzhou Yang <hongzhou.y...@mediatek.com> --- Fix a memleak issue. drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 24 ++-- 1 file changed, 14 insertions(

[PATCH] pinctrl: mediatek: fix a memleak when do dt maps.

configs will kmemdup to dup_configs in pictrl util function. So configs need to be freed. Signed-off-by: Hongzhou Yang <hongzhou.y...@mediatek.com> --- Fix a memleak issue. drivers/pinctrl/mediatek/pinctrl-mtk-common.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH] pinctrl: mediatek: Add get_direction support.

Since Linux gpio framework return 0 for output, 1 for input. But HW use 0 stands for input, and 1 stands for output. So use negative to correct it. And gpio_chip.get is used to get input value, no need to get output value, so removing it. Signed-off-by: Hongzhou Yang --- Add get direction

[PATCH] pinctrl: mediatek: Add get_direction support.

Since Linux gpio framework return 0 for output, 1 for input. But HW use 0 stands for input, and 1 stands for output. So use negative to correct it. And gpio_chip.get is used to get input value, no need to get output value, so removing it. Signed-off-by: Hongzhou Yang <hongzhou.y...@mediatek.

Re: [PATCH 5/6] pinctrl: mediatek: Remove unneded semicolon

rq_set_chained_handler_and_data(irq, mtk_eint_irq_handler, pctl); > return 0; Acked-by: Hongzhou Yang Thanks Hongzhou -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 5/6] pinctrl: mediatek: Remove unneded semicolon

; > + } > > irq_set_chained_handler_and_data(irq, mtk_eint_irq_handler, pctl); > return 0; Acked-by: Hongzhou Yang <hongzhou.y...@mediatek.com> Thanks Hongzhou -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

[PATCH v4] pinctrl: mediatek: Fix multiple registration issue.

, all members in pinctrl_desc will set to the new one's, such as name, pins and pins numbers, etc. This is a bug. Move pinctrl_desc into mtk_pinctrl, assign new value for each pinctrl device to fix it. Cc: sta...@vger.kernel.org # v4.1+ Signed-off-by: Hongzhou Yang Reviewed-by: Axel Lin

Re: [PATCH v4] pinctrl: mediatek: Fix multiple registration issue.

On Tue, 2015-08-25 at 17:16 -0700, Hongzhou Yang wrote: > Since our common driver need support main chip and PMU > at the same time, that means it will register two > pinctrl device, and the pinctrl_desc structure should > be used two times. > > But pinctrl_desc use global

[PATCH v4] pinctrl: mediatek: Fix multiple registration issue.

, all members in pinctrl_desc will set to the new one's, such as name, pins and pins numbers, etc. This is a bug. Changing to use devm_kzalloc to fix it. Cc: sta...@vger.kernel.org # v4.1+ Signed-off-by: Hongzhou Yang Reviewed-by: Axel Lin --- Adding pinctrl_desc into mtk_pinctrl, assign new value

[PATCH v4] pinctrl: mediatek: Fix multiple registration issue.

, all members in pinctrl_desc will set to the new one's, such as name, pins and pins numbers, etc. This is a bug. Changing to use devm_kzalloc to fix it. Cc: sta...@vger.kernel.org # v4.1+ Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com Reviewed-by: Axel Lin axel@ingics.com --- Adding

Re: [PATCH v4] pinctrl: mediatek: Fix multiple registration issue.

On Tue, 2015-08-25 at 17:16 -0700, Hongzhou Yang wrote: Since our common driver need support main chip and PMU at the same time, that means it will register two pinctrl device, and the pinctrl_desc structure should be used two times. But pinctrl_desc use global static definition

[PATCH v4] pinctrl: mediatek: Fix multiple registration issue.

, all members in pinctrl_desc will set to the new one's, such as name, pins and pins numbers, etc. This is a bug. Move pinctrl_desc into mtk_pinctrl, assign new value for each pinctrl device to fix it. Cc: sta...@vger.kernel.org # v4.1+ Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com

[PATCH v3] pinctrl: mediatek: Fix multiple registration issue.

, all members in pinctrl_desc will set to the new one's, such as name, pins and pins numbers, etc. This is a bug. Changing to use devm_kzalloc to fix it. Cc: sta...@vger.kernel.org # v4.1+ Signed-off-by: Hongzhou Yang --- Use dynamic allocation to fix multiple registration issue. drivers/pinctrl

[PATCH v3] pinctrl: mediatek: Fix multiple registration issue.

, all members in pinctrl_desc will set to the new one's, such as name, pins and pins numbers, etc. This is a bug. Changing to use devm_kzalloc to fix it. Cc: sta...@vger.kernel.org # v4.1+ Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- Use dynamic allocation to fix multiple registration

[PATCH v2] pinctrl: mediatek: Fix multiple registration issue.

, all members in pinctrl_desc will set to the new one's, such as name, pins and pins numbers, etc. This is a bug. Changing to use devm_kzalloc to fix it. Cc: sta...@vger.kernel.org # v4.1+ Signed-off-by: Hongzhou Yang --- Use dynamic allocation to fix multiple registration issue. drivers/pinctrl

[PATCH v2] pinctrl: mediatek: Fix multiple registration issue.

, all members in pinctrl_desc will set to the new one's, such as name, pins and pins numbers, etc. This is a bug. Changing to use devm_kzalloc to fix it. Cc: sta...@vger.kernel.org # v4.1+ Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- Use dynamic allocation to fix multiple registration

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

>> +} > > > > > > Hi Maoguang, > > > > > > You changed from set_bit/clear_bit to this, but didn't add any locking. > > > Since this is basic read/modify/write, is it OK to do it without > > > locking? > > > > I believe calling .irq

Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

provide irq_bus_lock callback. So this should be OK. Sorry for the noise. For this patch: Acked-by: Yingjoe Chen yingjoe.c...@mediatek.com Joe.C Acked-by: Hongzhou Yang hongzhou.y...@mediatek.com Thanks. Hongzhou -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] pinctrl: mediatek: Fix multiple registeration issue.

On Tue, 2015-08-11 at 15:45 +0800, Daniel Kurtz wrote: > On Tue, Aug 11, 2015 at 12:49 PM, Hongzhou Yang > wrote: > > Use dynamic allocation to fix multiple registeration issue. > > s/registeration/registration - here and in the patch subject. > &g

Re: [PATCH] pinctrl: mediatek: Fix multiple registeration issue.

On Tue, 2015-08-11 at 15:45 +0800, Daniel Kurtz wrote: On Tue, Aug 11, 2015 at 12:49 PM, Hongzhou Yang hongzhou.y...@mediatek.com wrote: Use dynamic allocation to fix multiple registeration issue. s/registeration/registration - here and in the patch subject. --8

[PATCH] pinctrl: mediatek: Fix multiple registeration issue.

off-by: Hongzhou Yang --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 27 +++-- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index ad1ea16..2bba504 100

Re: [PATCH] pinctrl: mediatek: Implement pictrl irq wake handler

re you OK with this patch? Can I have your ACKs? > > Yours, > Linus Walleij Hi Linus, Yes, you can. Thank you. Acked-by: Hongzhou Yang Hongzhou -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel

[PATCH] pinctrl: mediatek: Fix multiple registeration issue.

-by: Hongzhou Yang hongzhou.y...@mediatek.com --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 27 +++-- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index ad1ea16

Re: [PATCH] pinctrl: mediatek: Implement pictrl irq wake handler

Hongzhou/Yingjoe: are you OK with this patch? Can I have your ACKs? Yours, Linus Walleij Hi Linus, Yes, you can. Thank you. Acked-by: Hongzhou Yang hongzhou.y...@mediatek.com Hongzhou -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] pinctrl/mediatek: fix spelling mistake in dev_err error message

", > + dev_err(pctl->dev, "invalid function %d on group %d .\n", > function, group); > return -EINVAL; > } Hi Colin, Thank you very much. Acked-by: Hongzhou Yang Hongzhou -- To unsubscribe from this list: send the l

Re: [PATCH] pinctrl/mediatek: fix spelling mistake in dev_err error message

.\n, function, group); return -EINVAL; } Hi Colin, Thank you very much. Acked-by: Hongzhou Yang hongzhou.y...@mediatek.com Hongzhou -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATH] Fix ies/smt and register irq fail bug.

On Wed, 2015-05-27 at 02:43 -0700, Hongzhou Yang wrote: > Hi Linus, > After integration test, we found some bugs in the code you just merged. > The first is that I missed ies/smt configuration for MSDC3. > The seconed is the if judgement for "interrupt-controller" I ad

Re: [PATH] Fix ies/smt and register irq fail bug.

On Wed, 2015-05-27 at 02:43 -0700, Hongzhou Yang wrote: Hi Linus, After integration test, we found some bugs in the code you just merged. The first is that I missed ies/smt configuration for MSDC3. The seconed is the if judgement for interrupt-controller I added last time should

Re: [PATCH] mfd: mediatek: Add GPIO sub module support into mfd.

On Wed, 2015-05-27 at 11:32 +0100, Lee Jones wrote: > On Wed, 27 May 2015, Hongzhou Yang wrote: > > > Base on Lee Jones' comment, change pinctrl subnode name. > > > > --- > > Register pinctrl subnode into 6397 mfd cell. > > Sascha already mentioned w

[PATCH 1/2] pinctrl: mediatek: Fix bug of ies/smt setting for mt8173.

Add ies/smt support for MSDC3. Also fix ies bug for pin 106 and 107. Signed-off-by: Hongzhou Yang --- drivers/pinctrl/mediatek/pinctrl-mt8173.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8173.c b/drivers/pinctrl/mediatek

[PATH] Fix ies/smt and register irq fail bug.

ould on the contrary, this is a bug. so adding this patch to fix it. Hongzhou Yang (2): pinctrl: mediatek: Fix bug of ies/smt setting for mt8173. pinctrl: mediatek: Fix pinctrl register irq fail bug. drivers/pinctrl/mediatek/pinctrl-mt8173.c | 10 +- drivers/pinctrl/mediatek/pinctrl

[PATCH 2/2] pinctrl: mediatek: Fix pinctrl register irq fail bug.

d_property. Also fix bug of misuse pointer. Signed-off-by: Hongzhou Yang --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c ind

[PATCH] mfd: mediatek: Add GPIO sub module support into mfd.

Base on Lee Jones' comment, change pinctrl subnode name. --- Register pinctrl subnode into 6397 mfd cell. Signed-off-by: Hongzhou Yang Acked-by: Linus Walleij --- drivers/mfd/mt6397-core.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397

[PATCH 1/2] pinctrl: mediatek: Fix bug of ies/smt setting for mt8173.

Add ies/smt support for MSDC3. Also fix ies bug for pin 106 and 107. Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- drivers/pinctrl/mediatek/pinctrl-mt8173.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8173.c b

[PATCH] mfd: mediatek: Add GPIO sub module support into mfd.

Base on Lee Jones' comment, change pinctrl subnode name. --- Register pinctrl subnode into 6397 mfd cell. Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com Acked-by: Linus Walleij linus.wall...@linaro.org --- drivers/mfd/mt6397-core.c |3 +++ 1 file changed, 3 insertions(+) diff

[PATH] Fix ies/smt and register irq fail bug.

, this is a bug. so adding this patch to fix it. Hongzhou Yang (2): pinctrl: mediatek: Fix bug of ies/smt setting for mt8173. pinctrl: mediatek: Fix pinctrl register irq fail bug. drivers/pinctrl/mediatek/pinctrl-mt8173.c | 10 +- drivers/pinctrl/mediatek/pinctrl-mtk-common.c |4

[PATCH 2/2] pinctrl: mediatek: Fix pinctrl register irq fail bug.

. Also fix bug of misuse pointer. Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk

Re: [PATCH] mfd: mediatek: Add GPIO sub module support into mfd.

On Wed, 2015-05-27 at 11:32 +0100, Lee Jones wrote: On Wed, 27 May 2015, Hongzhou Yang wrote: Base on Lee Jones' comment, change pinctrl subnode name. --- Register pinctrl subnode into 6397 mfd cell. Sascha already mentioned what's wrong here, so I'll not labour the point. I'm

Re: [PATCH v2 08/11] mfd: mediatek: Add GPIO sub module support into mfd.

On Tue, 2015-05-19 at 10:34 +0100, Lee Jones wrote: > On Mon, 18 May 2015, Hongzhou Yang wrote: > > > Register pinctrl subnode into 6397 mfd cell. > > > > Signed-off-by: Hongzhou Yang > > --- > > drivers/mfd/mt6397-core.c |3 +++ > > 1 file ch

Re: [PATCH v2 08/11] mfd: mediatek: Add GPIO sub module support into mfd.

On Tue, 2015-05-19 at 10:34 +0100, Lee Jones wrote: On Mon, 18 May 2015, Hongzhou Yang wrote: Register pinctrl subnode into 6397 mfd cell. Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- drivers/mfd/mt6397-core.c |3 +++ 1 file changed, 3 insertions(+) diff

[PATCH v2 10/11] arm64: dts: mt8173-evb: Add pinctrl/GPIO node for mt6397.

Add pinctrl and GPIO node to mt8173-evb.dts. Signed-off-by: Hongzhou Yang --- arch/arm64/boot/dts/mediatek/mt8173-evb.dts |8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts index c9bc71b

[PATCH v2 11/11] ARM: dts: mt8135-evbp1: Add pinctrl/GPIO node for mt6397.

Add pinctrl and GPIO node to mt8135-evbp1.dts. Signed-off-by: Hongzhou Yang --- arch/arm/boot/dts/mt8135-evbp1.dts |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/mt8135-evbp1.dts b/arch/arm/boot/dts/mt8135-evbp1.dts index 357a91f..332233b 100644 --- a/arch/arm

[PATCH v2 09/11] ARM: dts: mt8127: add pinctrl/GPIO/EINT node for mt8127

From: Yingjoe Chen Add pinctrl,GPIO and EINT node to mt8127.dtsi. Signed-off-by: Yingjoe Chen Signed-off-by: Hongzhou Yang --- arch/arm/boot/dts/mt8127-pinfunc.h | 742 arch/arm/boot/dts/mt8127.dtsi | 22 ++ 2 files changed, 764 insertions

[PATCH v2 08/11] mfd: mediatek: Add GPIO sub module support into mfd.

Register pinctrl subnode into 6397 mfd cell. Signed-off-by: Hongzhou Yang --- drivers/mfd/mt6397-core.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c index 09bc780..012c620 100644 --- a/drivers/mfd/mt6397-core.c +++ b/drivers/mfd

[PATCH v2 07/11] pinctrl: mediatek: add pinctrl/GPIO/EINT driver for mt8127

From: Yingjoe Chen MT8127 pinctrl/eint are similar to mt8135 and mt8173, add support for mt8127 using mediatek common pinctrl driver. Signed-off-by: Yingjoe Chen Signed-off-by: Hongzhou Yang --- drivers/pinctrl/mediatek/Kconfig |6 + drivers/pinctrl/mediatek/Makefile

[PATCH v2 06/11] pinctrl: mediatek: Add Pinctrl/GPIO driver for mt6397.

it. Signed-off-by: Hongzhou Yang --- drivers/pinctrl/mediatek/Kconfig |6 + drivers/pinctrl/mediatek/Makefile |1 + drivers/pinctrl/mediatek/pinctrl-mt6397.c | 78 + drivers/pinctrl/mediatek/pinctrl-mt8135.c |2 +- drivers/pinctrl/mediatek/pinctrl

[PATCH v2 05/11] pinctrl: mediatek: add ies/smt control to common code.

future soc driver can use it. Signed-off-by: Hongzhou Yang --- drivers/pinctrl/mediatek/pinctrl-mt8173.c | 201 + drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 82 +++--- drivers/pinctrl/mediatek/pinctrl-mtk-common.h | 31 +++- 3 files changed, 198 insertions

[PATCH v2 04/11] pinctrl: mediatek: add mtk_pctrl_spec_pull_set_samereg common code

-by: Yingjoe Chen Signed-off-by: Hongzhou Yang --- drivers/pinctrl/mediatek/pinctrl-mt8173.c | 166 +++-- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 60 + drivers/pinctrl/mediatek/pinctrl-mtk-common.h | 31 + 3 files changed, 136 insertions(+), 121

[PATCH v2 03/11] pinctrl: mediatek: data struct optimize and remove unused member

Signed-off-by: Hongzhou Yang --- drivers/pinctrl/mediatek/pinctrl-mt8135.c | 10 -- drivers/pinctrl/mediatek/pinctrl-mtk-common.h | 10 ++ 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8135.c b/drivers/pinctrl/mediatek

[PATCH v2 02/11] pinctrl: dt bindings: mt6397: Add pinfunc header file for mt6397.

Add pinfunc header file, mt8135/mt8173 relate dts will include it. Signed-off-by: Hongzhou Yang --- include/dt-bindings/pinctrl/mt6397-pinfunc.h | 256 ++ 1 file changed, 256 insertions(+) create mode 100644 include/dt-bindings/pinctrl/mt6397-pinfunc.h diff --git

[PATCH v2 01/11] dt-bindings: mediatek: Modify pinctrl bindings for mt6397.

Since 6397 is no need to support interrupt controller, moving interrupt controller relate property to optional list. Also adding mt8173 and mt8127 to bindings. Signed-off-by: Hongzhou Yang --- .../devicetree/bindings/pinctrl/pinctrl-mt65xx.txt |9 +++-- 1 file changed, 7 insertions

[PATCH v2 0/11] Mediatek pinctrl driver optimize and add Mediatek SoC Pinctrl/GPIO/EINT driver for mt6397/mt8127.

Due to these patches haven't sent to ML, just resend them. Changes in v2: - Break mfd relate change out into a sparate patch. - Rearrange order of patches. Hongzhou Yang (7): dt-bindings: mediatek: Modify pinctrl bindings for mt6397. pinctrl: dt bindings: mt6397: Add pinfunc header file

[PATCH v2 08/11] mfd: mediatek: Add GPIO sub module support into mfd.

Register pinctrl subnode into 6397 mfd cell. Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- drivers/mfd/mt6397-core.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c index 09bc780..012c620 100644 --- a/drivers/mfd

[PATCH v2 07/11] pinctrl: mediatek: add pinctrl/GPIO/EINT driver for mt8127

From: Yingjoe Chen yingjoe.c...@mediatek.com MT8127 pinctrl/eint are similar to mt8135 and mt8173, add support for mt8127 using mediatek common pinctrl driver. Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- drivers/pinctrl

[PATCH v2 09/11] ARM: dts: mt8127: add pinctrl/GPIO/EINT node for mt8127

From: Yingjoe Chen yingjoe.c...@mediatek.com Add pinctrl,GPIO and EINT node to mt8127.dtsi. Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- arch/arm/boot/dts/mt8127-pinfunc.h | 742 arch/arm

[PATCH v2 06/11] pinctrl: mediatek: Add Pinctrl/GPIO driver for mt6397.

it. Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- drivers/pinctrl/mediatek/Kconfig |6 + drivers/pinctrl/mediatek/Makefile |1 + drivers/pinctrl/mediatek/pinctrl-mt6397.c | 78 + drivers/pinctrl/mediatek/pinctrl-mt8135.c |2 +- drivers

[PATCH v2 03/11] pinctrl: mediatek: data struct optimize and remove unused member

. Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- drivers/pinctrl/mediatek/pinctrl-mt8135.c | 10 -- drivers/pinctrl/mediatek/pinctrl-mtk-common.h | 10 ++ 2 files changed, 6 insertions(+), 14 deletions(-) diff

[PATCH v2 05/11] pinctrl: mediatek: add ies/smt control to common code.

future soc driver can use it. Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- drivers/pinctrl/mediatek/pinctrl-mt8173.c | 201 + drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 82 +++--- drivers/pinctrl/mediatek/pinctrl-mtk-common.h | 31 +++- 3 files

[PATCH v2 04/11] pinctrl: mediatek: add mtk_pctrl_spec_pull_set_samereg common code

can use it. Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- drivers/pinctrl/mediatek/pinctrl-mt8173.c | 166 +++-- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 60 + drivers/pinctrl/mediatek

[PATCH v2 02/11] pinctrl: dt bindings: mt6397: Add pinfunc header file for mt6397.

Add pinfunc header file, mt8135/mt8173 relate dts will include it. Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- include/dt-bindings/pinctrl/mt6397-pinfunc.h | 256 ++ 1 file changed, 256 insertions(+) create mode 100644 include/dt-bindings/pinctrl/mt6397

[PATCH v2 0/11] Mediatek pinctrl driver optimize and add Mediatek SoC Pinctrl/GPIO/EINT driver for mt6397/mt8127.

Due to these patches haven't sent to ML, just resend them. Changes in v2: - Break mfd relate change out into a sparate patch. - Rearrange order of patches. Hongzhou Yang (7): dt-bindings: mediatek: Modify pinctrl bindings for mt6397. pinctrl: dt bindings: mt6397: Add pinfunc header file

[PATCH v2 01/11] dt-bindings: mediatek: Modify pinctrl bindings for mt6397.

Since 6397 is no need to support interrupt controller, moving interrupt controller relate property to optional list. Also adding mt8173 and mt8127 to bindings. Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- .../devicetree/bindings/pinctrl/pinctrl-mt65xx.txt |9 +++-- 1 file

[PATCH v2 11/11] ARM: dts: mt8135-evbp1: Add pinctrl/GPIO node for mt6397.

Add pinctrl and GPIO node to mt8135-evbp1.dts. Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- arch/arm/boot/dts/mt8135-evbp1.dts |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/mt8135-evbp1.dts b/arch/arm/boot/dts/mt8135-evbp1.dts index 357a91f

[PATCH v2 10/11] arm64: dts: mt8173-evb: Add pinctrl/GPIO node for mt6397.

Add pinctrl and GPIO node to mt8173-evb.dts. Signed-off-by: Hongzhou Yang hongzhou.y...@mediatek.com --- arch/arm64/boot/dts/mediatek/mt8173-evb.dts |8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173

Re: [PATCH 35/35 linux-next] pinctrl: constify of_device_id array

On Thu, 2015-03-19 at 19:41 +0100, Fabian Frederick wrote: > > > On 19 March 2015 at 02:58 Hongzhou Yang wrote: > > > > > > On Mon, 2015-03-16 at 20:59 +0100, Fabian Frederick wrote: > > > of_device_id is always used as const. > > > (See driv

Re: [PATCH 35/35 linux-next] pinctrl: constify of_device_id array

On Thu, 2015-03-19 at 19:41 +0100, Fabian Frederick wrote: On 19 March 2015 at 02:58 Hongzhou Yang hongzhou.y...@mediatek.com wrote: On Mon, 2015-03-16 at 20:59 +0100, Fabian Frederick wrote: of_device_id is always used as const. (See driver.of_match_table and open firmware

Re: [PATCH 35/35 linux-next] pinctrl: constify of_device_id array

diatek/pinctrl-mt8135.c | 2 +- > drivers/pinctrl/mediatek/pinctrl-mt8173.c | 2 +- > For the pinctrl-mt81xx driver, Acked-by: Hongzhou Yang By the way, Axel has sent same patch to linux-gpio. http://article.gmane.org/gmane.linux.kernel.gpio/6815 Thanks. Hongzhou -- To unsubscribe fr

Re: [PATCH 35/35 linux-next] pinctrl: constify of_device_id array

-mt8135.c | 2 +- drivers/pinctrl/mediatek/pinctrl-mt8173.c | 2 +- For the pinctrl-mt81xx driver, Acked-by: Hongzhou Yang hongzhou.y...@mediatek.com By the way, Axel has sent same patch to linux-gpio. http://article.gmane.org/gmane.linux.kernel.gpio/6815 Thanks. Hongzhou -- To unsubscribe