for this purpose, the property allows to
declare that the camera power is controlled by the MAX9286 directly.
The property accepts a gpio-index (0 or 1) and one line polarity
flag as defined by dt-bindings/gpio/gpio.h.
Reviewed-by: Rob Herring
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
From: Kieran Bingham
Describe the FAKRA connector available on Eagle board that allows
connecting GMSL camera modules such as IMI RDACM20 and RDACM21.
Signed-off-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/eagle-gmsl.dtsi | 178
1 file
From: Kieran Bingham
Include the eagle-gmsl.dtsi to enable GMSL camera support on the
Eagle-V3M platform.
Signed-off-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot
From: Kieran Bingham
Enable the MAX9286 GMSL deserializer on the Eagle-V3M board.
Connected cameras should be defined in a device-tree overlay or included
after these definitions.
Reviewed-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
.../arm64/boot/dts
Declare port@0 in the csi40 device node and leave it un-connected.
Each board .dts file will connect the port as it requires.
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 4
1 file changed, 4 insertions(+)
diff --git a/arch
time.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 125 +++-
1 file changed, 94 insertions(+), 31 deletions(-)
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index 6fd4d59fcc72..99160aa68a5f 100644
--- a/drivers/media/i2c
The dt-bindings examples are usually indented with 4 spaces.
The maxim,max9286 schema has the example indented with only
2 spaces, re-indent it.
Cosmetic change only.
Reviewed-by: Laurent Pinchart
Acked-by: Rob Herring
Signed-off-by: Jacopo Mondi
---
.../bindings/media/i2c/maxim,max9286
'properties' in the if: clause :)
but this already looks better than the preceding version
- driver:
- Backtrack on the set_gpio() function and share implementation with
the gpiochip function
Tested on Eagle-V3M
Thanks
j
Jacopo Mondi (4):
dt-bindings: media: max9286: Re-indent
Hi Laurent,
On Thu, Apr 15, 2021 at 10:19:30PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Thu, Apr 15, 2021 at 02:25:58PM +0200, Jacopo Mondi wrote:
> > The 'maxim,gpio-poc' property is used when the remote camera
> > power-ove
Hi Laurent,
On Thu, Apr 15, 2021 at 10:14:05PM +0300, Laurent Pinchart wrote:
> > > > + /* GPIO values default to high */
> > > > + priv->gpio_state = BIT(0) | BIT(1);
> > >
> > > Why is that ?
> > >
> > As the set/get functions of gpiochip use the gpio_state and I
Hi,
with feedback from media maintainers I can resend the series which is
now fully reviewed.
Thanks
j
On Mon, Apr 12, 2021 at 11:34:50AM +0200, Jacopo Mondi wrote:
> The init() subdev core operation is deemed to be deprecated for new
> subdevice drivers. However it could prove
From: Kieran Bingham
Include the eagle-gmsl.dtsi to enable GMSL camera support on the
Eagle-V3M platform.
Signed-off-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot
From: Kieran Bingham
Describe the FAKRA connector available on Eagle board that allows
connecting GMSL camera modules such as IMI RDACM20 and RDACM21.
Signed-off-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/eagle-gmsl.dtsi | 178
1 file
Declare port@0 in the csi40 device node and leave it un-connected.
Each board .dts file will connect the port as it requires.
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77970
From: Kieran Bingham
Enable the MAX9286 GMSL deserializer on the Eagle-V3M board.
Connected cameras should be defined in a device-tree overlay or included
after these definitions.
Reviewed-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
.../arm64/boot/dts
for this purpose, the property allows to
declare that the camera power is controlled by the MAX9286 directly.
The property accepts a gpio-index (0 or 1) and one line polarity
flag as defined by dt-bindings/gpio/gpio.h.
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
.../bindings/media/i2c
time.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 119
1 file changed, 93 insertions(+), 26 deletions(-)
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index 6fd4d59fcc72..a8b37783d2ef 100644
--- a/drivers/media/i2c
The dt-bindings examples are usually indented with 4 spaces.
The maxim,max9286 schema has the example indented with only
2 spaces, re-indent it.
Cosmetic change only.
Signed-off-by: Jacopo Mondi
---
.../bindings/media/i2c/maxim,max9286.yaml | 214 +-
1 file changed, 107
Following the recent v3, this new version:
- Two new patches (minor fixes)
- Address Laurent's comments on gpio-poc bindings and implementation.
Naming might still be discussed
- Address Laurent's comments on DTS patches
- Last patch not for inclusion
Thanks
j
Jacopo Mondi (4):
dt
Hi Laurent,
On Thu, Apr 15, 2021 at 02:53:17AM +0300, Laurent Pinchart wrote:
> Hi Jacopo and Kieran,
>
> Thank you for the patch.
>
> On Wed, Apr 14, 2021 at 03:51:27PM +0200, Jacopo Mondi wrote:
> > From: Kieran Bingham
> >
> > Describe the FAKRA connector ava
Hi Laurent,
On Thu, Apr 15, 2021 at 03:00:56AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Wed, Apr 14, 2021 at 03:51:25PM +0200, Jacopo Mondi wrote:
> > The 'maxim,gpio-poc' property is used when the remote camera
> > power-ove
Hi Laurent,
On Thu, Apr 15, 2021 at 02:47:12AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Wed, Apr 14, 2021 at 03:51:24PM +0200, Jacopo Mondi wrote:
> > Define a new vendor property in the maxim,max9286 binding schema.
> >
From: Kieran Bingham
Enable the MAX9286 GMSL deserializer on the Eagle-V3M board.
Connected cameras should be defined in a device-tree overlay or included
after these definitions.
Signed-off-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
.../arm64/boot/dts/renesas/r8a77970-eagle.dts
From: Kieran Bingham
Include the eagle-gmsl.dtsi to enable GMSL camera support on the
Eagle-V3M platform.
Signed-off-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts
From: Kieran Bingham
Describe the FAKRA connector available on Eagle board that allows
connecting GMSL camera modules such as IMI RDACM20 and RDACM21.
Signed-off-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/eagle-gmsl.dtsi | 186
1 file
time.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 125 +++-
1 file changed, 96 insertions(+), 29 deletions(-)
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index 6fd4d59fcc72..0c125f7b3d9b 100644
--- a/drivers/media/i2c
for this purpose, the property allows to
declare that the camera power is controlled by the MAX9286 directly.
The property accepts a gpio-index (0 or 1) and one line polarity
flag as defined by dt-bindings/gpio/gpio.h.
Signed-off-by: Jacopo Mondi
---
.../bindings/media/i2c/maxim,max9286.yaml | 53
controller registered
by the driver.
The series introduces the new property and add support for parsing it in the
driver.
The DTS changes that follow are identical to v2, and comments there have not
been addressed waiting for a validation of patches 1 and 2.
Thanks
j
Jacopo Mondi (2):
dt-bindings
Hi Eugene
On Mon, Apr 12, 2021 at 02:15:32PM +, eugen.hris...@microchip.com wrote:
> On 4/12/21 4:41 PM, Jacopo Mondi wrote:
> > Hi Eugene,
> >
> > On Mon, Apr 12, 2021 at 12:37:41PM +, eugen.hris...@microchip.com wrote:
> >>> +static int xisc_pa
Hi Eugene,
On Mon, Apr 12, 2021 at 12:37:41PM +, eugen.hris...@microchip.com wrote:
> > +static int xisc_parse_dt(struct device *dev, struct isc_device *isc)
> > +{
> > + struct device_node *np = dev->of_node;
> > + struct device_node *epn = NULL;
> > + struct isc_subdev_entity
Hi Eugene,
On Mon, Apr 12, 2021 at 10:12:22AM +, eugen.hris...@microchip.com wrote:
> On 4/12/21 12:57 PM, Jacopo Mondi wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> > content is safe
> >
> > Hi Eugene,
> >
>
Hi Eugene,
On Mon, Apr 05, 2021 at 06:51:03PM +0300, Eugen Hristev wrote:
> Add bindings for the microchip xisc, a driver based on atmel-isc.
> It shares common code with atmel-isc, but the xisc is the next generation
> ISC which is present on sama7g5 product.
> It has an enhanced pipeline,
Ups,
On Mon, Apr 12, 2021 at 11:43:12AM +0200, Jacopo Mondi wrote:
> Hi Eugene,
>
> On Mon, Apr 05, 2021 at 06:50:39PM +0300, Eugen Hristev wrote:
> > Move the max width and max height constants to the product specific driver
> > and have them in the device struct.
> &g
Hi Eugene
On Mon, Apr 05, 2021 at 06:50:40PM +0300, Eugen Hristev wrote:
> The dma configuration (DCFG) is specific to the product.
> Move this configuration in the product specific driver, and add the
> field inside the driver struct.
Do you plan to match on different compatible values ?
As in
Hi Eugene,
On Mon, Apr 05, 2021 at 06:50:39PM +0300, Eugen Hristev wrote:
> Move the max width and max height constants to the product specific driver
> and have them in the device struct.
>
> Signed-off-by: Eugen Hristev
> ---
> drivers/media/platform/atmel/atmel-isc-base.c | 28
The camera module initialization routine does not check the return
value of a few functions. Fix that.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm20.c | 13 +
1 file changed, 9 insertions(+), 4 deletions
the long sleep delays and
only wait after the chip exits from reset for 350-500 microseconds
interval, which is larger than the minimum (2048 * (1 / XVCLK)) timeout
characterized in the chip manual.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 19 +---
drivers/media/i2c/rdacm20.c | 59 ++---
drivers/media/i2c/rdacm21.c | 59 ++---
3 files changed, 87 insertions(+), 50 deletions(-)
diff --git a/drivers/media/i2c
nce) are run in the subdevice init() operation implementation.
Signed-off-by: Jacopo Mondi
---
include/media/v4l2-subdev.h | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index d0e9a5bdb08b..3068d9940669 100644
--- a/i
rdacm21 8-0054: Timeout waiting for firmware boot
Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm21.c | 46 ++---
1 file changed, 32 insertions(+), 14 deletions(-)
diff --git
and the image sensor and their addresses gets changed
by the rdacm20 driver it is required to manually enable the noise
immunity threshold to make the communication on the control channel
more reliable.
Reviewed-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm20.c | 14
When the device is identified the driver currently reports the
names of the chips embedded in the camera module.
Report the name of the camera module itself instead.
Cosmetic change only.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media
There's no reason to allocate dynamically the 'serializer' field in
the driver structure.
Embed the field and adjust all its users in the driver.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm20.c | 36
Rephrase a comment in .bound() callback to make it clear we register
a subdev notifier and remove a redundant comment about disabling i2c
auto-ack.
No functional changes intended.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c
Check the return value of the max9271_write() function in the
max9271 library driver.
While at it, modify an existing condition to be made identical
to other checks.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9271.c | 30
.
Use the newly introduced function in the rdacm20 and rdacm21 camera
drivers. The former was not respecting the required delay while the
latter was waiting for a too-short timeout.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c
Add a delay after the OV490 chip is put in reset state. The reset
signal shall be held for at least 250 useconds.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm21.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c
40 chip ID:
rdacm21 8-0054: OV10640 ID mismatch: (0x01)
Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm21.c | 10 --
1 file changed
Provide a macro to define the reverse channel amplitude to
be used to compensate the remote serializer noise immunity.
While at it, update a comment.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 5 +++--
1 file
Cache the current channel amplitude in a driver variable
to skip updating it if the newly requested value is the same
as the currently configured one.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 13 ++---
1
Rename the reverse_channel_mv variable to init_rev_chan_mv as
the next patch will cache the reverse channel amplitude in
a new driver variable.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 11 ++-
1 file
The parameters to max9286_i2c_mux_configure() fits on the previous
line. Adjust it.
Cosmetic change only.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff
me did not work, and this version is the only one I've found that
gurantees a reliable initialization sequence. I've cc-ed Hans and Sakari to
continue the discussion.
Run quite some tests with Eagle and RDACM21: 1378 boot cycles with 100% boot
success (thanks Kieran for the board access).
Thanks
j
J
its.
> So, instead of using a typecast, use a bit and logic.
>
> Signed-off-by: Mauro Carvalho Chehab
Please see
https://patchwork.linuxtv.org/project/linux-media/patch/20210319164148.199192-11-jacopo+rene...@jmondi.org/
Whatever gets in first it's fine, so you can add my
Acked-by: Ja
nce accordingly.
>
> Fixes: 34009bffc1c6 ("media: i2c: Add RDACM20 driver")
> Fixes: e9f817689789 ("media: dt-bindings: media: i2c: Add bindings for IMI
> RDACM2x")
> Signed-off-by: Mauro Carvalho Chehab
Thanks
Acked-by: Jacopo Mondi
> ---
> MAINTAIN
Hi Sakari,
On Mon, Mar 22, 2021 at 01:51:44PM +0100, Jacopo Mondi wrote:
> Hi Sakari,
>
> On Sun, Mar 21, 2021 at 10:52:56PM +0200, Sakari Ailus wrote:
> > Hi Laurent and Jacopo,
> >
> > Thanks for cc'ing me.
> >
> > On Sat, Mar 20, 2021 at 05:42:12PM
Hi Laurent, Kieran,
On Sat, Mar 20, 2021 at 05:52:18PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Fri, Mar 19, 2021 at 04:49:44PM +, Kieran Bingham wrote:
> > Hi Jacopo,
> >
> > s/dealy/delay/ in $SUBJECT
> >
>
Hi Laurent,
On Sat, Mar 20, 2021 at 06:24:09PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Fri, Mar 19, 2021 at 05:41:48PM +0100, Jacopo Mondi wrote:
> > The OV10635 image sensor embedded in the camera module is currently
> &
Hi Laurent,
On Sat, Mar 20, 2021 at 06:14:43PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Fri, Mar 19, 2021 at 05:41:42PM +0100, Jacopo Mondi wrote:
> > The current RDACM21 initialization routine powers up the
> > OV10640 image
> > CC'ing Sakari on v3 to get feedback.
> >
> > On Fri, Mar 19, 2021 at 05:41:34PM +0100, Jacopo Mondi wrote:
> > > The init() subdev core operation is deemed to be deprecated for new
> > > subdevice drivers. However it could prove useful for complex
> > > archite
When the device is identified the driver currently reports the
names of the chips embedded in the camera module.
Report the name of the camera module itself instead.
Cosmetic change only.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media
the long sleep delays and
only wait after the chip exits from reset for 350-500 microseconds
interval, which is larger than the minimum (2048 * (1 / XVCLK)) timeout
characterized in the chip manual.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers
The camera module initialization routine does not check the return
value of a few functions. Fix that.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm20.c | 13 +
1 file changed, 9 insertions(+), 4 deletions
-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm20.c | 29 +
1 file changed, 13 insertions(+), 16 deletions(-)
diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c
index 7bdcfafa6c10
There's no reason to allocate dynamically the 'serializer' field in
the driver structure.
Embed the field and adjust all its users in the driver.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm20.c | 40
and the image sensor and their addresses gets changed
by the rdacm20 driver it is required to manually enable the noise
immunity threshold to make the communication on the control channel
more reliable.
Reviewed-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm20.c | 14
completion:
rdacm21 8-0054: Timeout waiting for firmware boot
Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm21.c | 46 ++---
1 file changed, 32 insertions(+), 14 deletions(-)
Check the return value of the max9271_write() function in the
max9271 library driver.
While at it, modify an existing condition to be made identical
to other checks.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9271.c | 30
3b4b ("media: i2c: Add driver for RDACM21 camera module")
Reported-by: Hans Verkuil
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm21.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i
Add a delay after the OV490 chip is put in reset state. The reset
signal shall be held for at least 250 useconds.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm21.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c
40 chip ID:
rdacm21 8-0054: OV10640 ID mismatch: (0x01)
Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm21.c | 10 --
1 file changed
control address
reprogramming.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9271.c | 7 +++
drivers/media/i2c/max9271.h | 9 +
drivers/media/i2c/rdacm20.c | 2 +-
drivers/media/i2c/rdacm21.c | 3 +--
4 files changed, 18
Rephrase a comment in .bound() callback to make it clear we register
a subdev notifier and remove a redundant comment about disabling i2c
auto-ack.
No functional changes intended.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 19 +++---
drivers/media/i2c/rdacm20.c | 69 +++--
drivers/media/i2c/rdacm21.c | 65 --
3 files changed, 98 insertions(+), 55 deletions(-)
diff --git a/drivers/media/i2c
nce) are run in the subdevice init() operation implementation.
Signed-off-by: Jacopo Mondi
---
include/media/v4l2-subdev.h | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index d0e9a5bdb08b..3068d9940669 100644
--- a/i
Provide a macro to define the reverse channel amplitude to
be used to compensate the remote serializer noise immunity.
While at it, update a comment.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 5 +++--
1 file
The parameters to max9286_i2c_mux_configure() fits on the previous
line. Adjust it.
Cosmetic change only.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff
Rename the reverse_channel_mv variable to init_rev_chan_mv as
the next patch will cache the reverse channel amplitude in
a new driver variable.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 11 ++-
1 file
Cache the current channel amplitude in a driver variable
to skip updating it if the newly requested value is the same
as the currently configured one.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 13 ++---
1
is almost identical a few grammar fixes apart.
Thanks
j
Jacopo Mondi (19):
media: i2c: max9286: Adjust parameters indent
media: i2c: max9286: Rename reverse_channel_mv
media: i2c: max9286: Cache channel amplitude
media: i2c: max9286: Define high channel amplitude
media: v4l2-subde
Hi Laurent,
On Fri, Mar 19, 2021 at 02:29:30AM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Wed, Mar 17, 2021 at 11:04:45AM +0100, Jacopo Mondi wrote:
> > On Mon, Mar 15, 2021 at 05:22:37PM +, Kieran Bingham wrote:
> > > On 15/03/2021 13:15, Jacopo Mondi wr
Hi Laurent,
On Tue, Mar 16, 2021 at 12:15:16AM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Mon, Mar 15, 2021 at 05:30:25PM +0100, Jacopo Mondi wrote:
> > The MAX9286 GMSL deserializer features gpio controller capabilities,
> >
Hi Kieran, Laurent,
On Mon, Mar 15, 2021 at 05:22:37PM +, Kieran Bingham wrote:
> On 15/03/2021 13:15, Jacopo Mondi wrote:
> > It has been observed through repeated testing (250 boots) that in the
> > 10% of the cases the RDACM21 initialization sequence errors out due a
>
Hi Laurent,
On Mon, Mar 15, 2021 at 11:37:26PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Mon, Mar 15, 2021 at 02:14:56PM +0100, Jacopo Mondi wrote:
> > Enable the noise immunity threshold at the end of the rdacm20
>
From: Kieran Bingham
Include the eagle-gmsl.dtsi to enable GMSL camera support on the
Eagle-V3M platform.
Signed-off-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts
From: Kieran Bingham
Describe the FAKRA connector available on Eagle board that allows
connecting GMSL camera modules such as IMI RDACM20 and RDACM21.
Signed-off-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/eagle-gmsl.dtsi | 186
1 file
From: Kieran Bingham
Enable the MAX9286 GMSL deserializer on the Eagle-V3M board.
Connected cameras should be defined in a device-tree overlay or included
after these definitions.
Signed-off-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
.../arm64/boot/dts/renesas/r8a77970-eagle.dts
, allow
the usage of a gpio-hog for that purpose.
The usage of the gpio-hog is required in designs where the MAX9286
GPIO lines control the remote cameras power.
Signed-off-by: Jacopo Mondi
---
.../bindings/media/i2c/maxim,max9286.yaml| 16
1 file changed, 16 insertions
ern property to describe the gpio-hog
Thanks
j
Jacopo Mondi (1):
dt-bindings: media: max9286: Describe gpio-hog
Kieran Bingham (3):
arm64: dts: renesas: eagle: Enable MAX9286
arm64: dts: renesas: eagle: Add GMSL .dtsi
arm64: dts: renesas: eagle: Include eagle-gmsl
.../bindings/media/
nce) are run in the subdevice init() operation implementation.
Signed-off-by: Jacopo Mondi
---
include/media/v4l2-subdev.h | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index d0e9a5bdb08b..3068d9940669 100644
--- a/i
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 19 ---
drivers/media/i2c/rdacm20.c | 63 ++---
drivers/media/i2c/rdacm21.c | 63 ++---
3 files changed, 91 insertions(+), 54 deletions(-)
diff --git a/drivers/media/i2c
Re-phrase a comment in .bound() callback to make it clear we register
a subdev notifier and remove a redundant comment about disabling i2c
auto-ack.
No functional changes intended.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 16 ++--
1 file changed, 6 insertions
it reduces the sporadic error rate down to 1 over an 80 boot
sequences test run.
The firmware boot delay is unfortunately not characterized in the camera
module manual.
Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c
Cache the current channel amplitude in a driver variable
to skip updating it if the newly requested value is the same
as the currently configured one.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 13 ++---
1
Provide a macro to define the reverse channel amplitude to
be used to compensate the remote serializer noise immunity.
While at it, update a comment.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 5 +++--
1 file
Rename the reverse_channel_mv variable to init_rev_chan_mv as
the next patch will cache the reverse channel amplitude in
a new driver variable.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 11 ++-
1 file
The parameters to max9286_i2c_mux_configure() fits on the previous
line. Adjust it.
Cosmetic change only.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9286.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff
control address
reprogramming.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/max9271.c | 7 +++
drivers/media/i2c/max9271.h | 9 +
drivers/media/i2c/rdacm20.c | 2 +-
drivers/media/i2c/rdacm21.c | 3 +--
4 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/drivers/media
the long sleep delays and
only wait after the chip exits from reset for 350-500 microseconds
interval, which is larger than the minimum (2048 * (1 / XVCLK)) timeout
characterized in the chip manual.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers
a failure to
read the OV10640 chip ID:
rdacm21 8-0054: OV10640 ID mismatch: (0x01)
Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/rdacm21.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
1 - 100 of 1512 matches
Mail list logo
