Re: [tpmdd-devel] [PATCH RFC v2 5/5] tpm2: expose resource manager via a device link /dev/tpms

2017-01-13 Thread James Bottomley
On Fri, 2017-01-13 at 14:23 -0700, Jason Gunthorpe wrote: > On Fri, Jan 13, 2017 at 12:02:36PM -0800, James Bottomley wrote: > > > > Actually, no, the devrm is a completely lifetime managed device > > > > as part of the chip structure. once you've done a devi

Re: [tpmdd-devel] [PATCH RFC v2 5/5] tpm2: expose resource manager via a device link /dev/tpms

2017-01-13 Thread James Bottomley
On Fri, 2017-01-13 at 12:47 -0700, Jason Gunthorpe wrote: > On Fri, Jan 13, 2017 at 11:20:47AM -0800, James Bottomley wrote: > > On Thu, 2017-01-12 at 11:39 -0700, Jason Gunthorpe wrote: > > > On Thu, Jan 12, 2017 at 07:46:08PM +0200, Jarkko Sakkinen wrote: > > >

[PATCH] tpm: add session handles to the save and restore of the tpm2 space manager

2017-01-13 Thread James Bottomley
ned-off-by: James Bottomley diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c index f5c9355..d8e896e 100644 --- a/drivers/char/tpm/tpm-interface.c +++ b/drivers/char/tpm/tpm-interface.c @@ -400,6 +400,10 @@ ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_sp

Re: [tpmdd-devel] [PATCH RFC v2 5/5] tpm2: expose resource manager via a device link /dev/tpms

2017-01-13 Thread James Bottomley
e kfreed because it's no longer visible to anything else. The fix is simply not to do the put. With that and the other errors, here's a v3 James --- >From 572cbf2ac64df040be084182d750f55df836a759 Mon Sep 17 00:00:00 2001 From: James Bottomley Date: Tue, 3 Jan 2017 09:07:32 -0800 Subj

Re: [tpmdd-devel] [PATCH RFC v2 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

2017-01-13 Thread James Bottomley
This version has a bug in that it doesn't do a clear_bit(0, &chip ->is_open) on release. so fixed that James --- >From c006f181988dd2fd54e5a84f3e4a6dc0157c96f5 Mon Sep 17 00:00:00 2001 From: James Bottomley Date: Tue, 10 Jan 2017 19:08:53 -0800 Subject: [PATCH 4/5] tpm: spli

Re: [tpmdd-devel] [PATCH RFC v2 5/5] tpm2: expose resource manager via a device link /dev/tpms

2017-01-13 Thread James Bottomley
On Fri, 2017-01-13 at 11:01 -0700, Jason Gunthorpe wrote: > On Fri, Jan 13, 2017 at 09:40:08AM -0800, James Bottomley wrote: > > On Fri, 2017-01-13 at 10:25 -0700, Jason Gunthorpe wrote: > > > On Thu, Jan 12, 2017 at 10:56:28PM +0200, Jarkko Sakkinen wrote: > > >

Re: [tpmdd-devel] [PATCH RFC v2 5/5] tpm2: expose resource manager via a device link /dev/tpms

2017-01-13 Thread James Bottomley
On Fri, 2017-01-13 at 10:25 -0700, Jason Gunthorpe wrote: > On Thu, Jan 12, 2017 at 10:56:28PM +0200, Jarkko Sakkinen wrote: > > > > dev_t tpm_devt; > > > > But they should have different major device numbers. > > major/minors don't really matter these days since they are dynamic Right, althou

[GIT PULL] SCSI fixes for 4.10-rc3

2017-01-13 Thread James Bottomley
The major fix is the bfa firmware, since the latest 10Gb cards fail probing with the current firmware. The rest is a set of minor fixes: one missed Kconfig dependency causing randconfig failures, a missed error return on an error leg, a change for how multiqueue waits on a blocked device and a don

Re: [tpmdd-devel] [PATCH RFC v2 3/5] tpm: infrastructure for TPM spaces

2017-01-12 Thread James Bottomley
On Thu, 2017-01-12 at 19:46 +0200, Jarkko Sakkinen wrote: > @@ -189,6 +190,12 @@ struct tpm_chip *tpm_chip_alloc(struct device > *pdev, > chip->cdev.owner = THIS_MODULE; > chip->cdev.kobj.parent = &chip->dev.kobj; > > + chip->work_space.context_buf = kzalloc(PAGE_SIZE, > GFP_KERNEL

Re: [tpmdd-devel] [PATCH RFC v2 3/5] tpm: infrastructure for TPM spaces

2017-01-12 Thread James Bottomley
om something that's on byte 6 (so misaligned): some architectures will trigger an unaligned trap for this (it's not a problem: they trap handle it, it just slows down processing a lot). James --- commit d17ad905ff7b114f7efd23f930e9a541ccdf7621 Author: James Bottomley Date: Wed Jan 11

Re: [tpmdd-devel] [PATCH RFC v2 5/5] tpm2: expose resource manager via a device link /dev/tpms

2017-01-12 Thread James Bottomley
On Thu, 2017-01-12 at 19:46 +0200, Jarkko Sakkinen wrote: > From: James Bottomley > > Currently the Resource Manager (RM) is not exposed to userspace. > Make > this exposure via a separate device, which can now be opened multiple > times because each read/write transaction g

Re: [tpmdd-devel] [PATCH RFC v2 3/5] tpm: infrastructure for TPM spaces

2017-01-12 Thread James Bottomley
On Thu, 2017-01-12 at 19:46 +0200, Jarkko Sakkinen wrote: > @@ -435,17 +440,23 @@ ssize_t tpm_transmit(struct tpm_chip *chip, > const u8 *buf, size_t bufsiz, > goto out; > > out_recv: > - rc = chip->ops->recv(chip, (u8 *) buf, bufsiz); > - if (rc < 0) > + len = chip->ops

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-11 Thread James Bottomley
On Wed, 2017-01-11 at 10:56 -0700, Jason Gunthorpe wrote: > On Wed, Jan 11, 2017 at 07:39:53AM -0800, James Bottomley wrote: > > > RAW access means the ability to DoS the TPM simply by exhausting > > handles. Therefore, I think most applications only get RM access. > >

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-11 Thread James Bottomley
On Wed, 2017-01-11 at 13:34 +0200, Jarkko Sakkinen wrote: > On Tue, Jan 10, 2017 at 01:05:58PM -0700, Jason Gunthorpe wrote: > > On Tue, Jan 10, 2017 at 01:16:35AM +0200, Jarkko Sakkinen wrote: > > > On Wed, Jan 04, 2017 at 10:12:41AM -0600, Dr. Greg Wettstein > > > wrote: > > > > The kernel needs

Re: xfs: commit 6552321831dc "xfs: remove i_iolock and use i_rwsem in the VFS inode instead" change causes hang

2017-01-08 Thread James Bottomley
On Sun, 2017-01-08 at 19:18 +0100, Christoph Hellwig wrote: > On Sun, Jan 08, 2017 at 09:59:25AM -0800, James Bottomley wrote: > > Hey, that's not really true: the inode lock (i_rwsem) is used in > > all sorts of generic places, including generic_file_write_iter(). > >

Re: xfs: commit 6552321831dc "xfs: remove i_iolock and use i_rwsem in the VFS inode instead" change causes hang

2017-01-08 Thread James Bottomley
On Sun, 2017-01-08 at 15:52 +0100, Christoph Hellwig wrote: > On Sun, Jan 08, 2017 at 09:48:44AM -0500, Mimi Zohar wrote: > > IMA takes the i_rwsem (fomerly i_mutex) before reading the file to > > synchronize calculating the file hash and validating the file's > > hash/signature stored as security.

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-05 Thread James Bottomley
On Thu, 2017-01-05 at 15:21 -0700, Jason Gunthorpe wrote: > On Thu, Jan 05, 2017 at 11:55:49AM -0800, James Bottomley wrote: > > > We don't really have that choice: Keys require authorization, so > > you have to have an auth session. > > I know, this is why I sugge

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-05 Thread James Bottomley
On Thu, 2017-01-05 at 16:50 -0700, Jason Gunthorpe wrote: > On Thu, Jan 05, 2017 at 02:58:46PM -0800, James Bottomley wrote: > > On Thu, 2017-01-05 at 15:21 -0700, Jason Gunthorpe wrote: > > > On Thu, Jan 05, 2017 at 11:55:49AM -0800, James Bottomley wrote: > > > > &

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-05 Thread James Bottomley
On Thu, 2017-01-05 at 12:20 -0700, Jason Gunthorpe wrote: > On Thu, Jan 05, 2017 at 10:33:43AM -0800, James Bottomley wrote: > > > > A combo ioctl that could setup the session, issue an operation in > > > it > > > and then delete the session, for instance. > &

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-05 Thread James Bottomley
On Thu, 2017-01-05 at 10:27 -0700, Jason Gunthorpe wrote: > On Thu, Jan 05, 2017 at 03:52:02PM +, Fuchs, Andreas wrote: [...] > > - Session Limits (here it gets ugly): > > > Even thought the TPM supports the same swapping-scheme for sessions > > as it does for transient objects, it only allows

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-05 Thread James Bottomley
On Thu, 2017-01-05 at 10:27 -0700, Jason Gunthorpe wrote: > On Thu, Jan 05, 2017 at 03:52:02PM +, Fuchs, Andreas wrote: > > Great to see this coming along so well. Thanks a lot to Jarkko ! > > > The TPM allows an application to get the list of currently loaded > > handles TPM2_GetCapabilities(

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-04 Thread James Bottomley
On Wed, 2017-01-04 at 11:31 -0700, Jason Gunthorpe wrote: > On Wed, Jan 04, 2017 at 06:53:03AM -0800, James Bottomley wrote: > > > > > But this is not trousers, this is an in-kernel 0666 char dev > > > > that will be active on basically every Linux system with a T

Re: [tpmdd-devel] [PATCH RFC 2/4] tpm: validate TPM 2.0 commands

2017-01-04 Thread James Bottomley
On Wed, 2017-01-04 at 13:04 -0500, Stefan Berger wrote: > Jarkko Sakkinen wrote on 01/02/2017 > 08:22:08 AM: > > > --- a/drivers/char/tpm/tpm2-cmd.c > > +++ b/drivers/char/tpm/tpm2-cmd.c > > @@ -943,7 +943,9 @@ EXPORT_SYMBOL_GPL(tpm2_probe); > > */ > > int tpm2_auto_startup(struct tpm_chip *ch

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-04 Thread James Bottomley
On Wed, 2017-01-04 at 14:50 +0200, Jarkko Sakkinen wrote: > On Tue, Jan 03, 2017 at 05:17:32PM -0700, Jason Gunthorpe wrote: > > On Tue, Jan 03, 2017 at 02:39:58PM -0800, James Bottomley wrote: [...] > > > > Even if TPM 2 has a stronger password based model, I still > >

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-03 Thread James Bottomley
On Tue, 2017-01-03 at 21:14 +0200, Jarkko Sakkinen wrote: > On Tue, Jan 03, 2017 at 08:36:02PM +0200, Jarkko Sakkinen wrote: > > On Tue, Jan 03, 2017 at 08:14:55AM -0800, James Bottomley wrote: > > > On Tue, 2017-01-03 at 15:41 +0200, Jarkko Sakkinen wrote: [...] > > > &

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-03 Thread James Bottomley
On Tue, 2017-01-03 at 17:17 -0700, Jason Gunthorpe wrote: > On Tue, Jan 03, 2017 at 02:39:58PM -0800, James Bottomley wrote: > > > > I think we should also consider TPM 1.2 support in all of this, > > > it is still a very popular peice of hardware and it is equally &g

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-03 Thread James Bottomley
On Tue, 2017-01-03 at 14:47 -0700, Jason Gunthorpe wrote: > On Tue, Jan 03, 2017 at 08:36:10AM -0800, James Bottomley wrote: > > > > I'm not sure about this. Why you couldn't have a very thin daemon > > > that prepares the file descriptor and sends it thr

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-03 Thread James Bottomley
On Tue, 2017-01-03 at 14:32 -0700, Jason Gunthorpe wrote: > On Mon, Jan 02, 2017 at 08:36:20AM -0800, James Bottomley wrote: > > On Mon, 2017-01-02 at 15:22 +0200, Jarkko Sakkinen wrote: > > > This patch set adds support for TPM spaces that provide a context > > >

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-03 Thread James Bottomley
On Tue, 2017-01-03 at 15:51 +0200, Jarkko Sakkinen wrote: > On Mon, Jan 02, 2017 at 01:40:48PM -0800, James Bottomley wrote: > > On Mon, 2017-01-02 at 21:33 +0200, Jarkko Sakkinen wrote: > > > On Mon, Jan 02, 2017 at 08:36:20AM -0800, James Bottomley wrote: > > > &g

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-03 Thread James Bottomley
On Tue, 2017-01-03 at 15:41 +0200, Jarkko Sakkinen wrote: > On Mon, Jan 02, 2017 at 09:26:58PM -0800, James Bottomley wrote: > > On Mon, 2017-01-02 at 13:40 -0800, James Bottomley wrote: > > > On Mon, 2017-01-02 at 21:33 +0200, Jarkko Sakkinen wrote: > > > > On M

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-02 Thread James Bottomley
On Mon, 2017-01-02 at 13:40 -0800, James Bottomley wrote: > On Mon, 2017-01-02 at 21:33 +0200, Jarkko Sakkinen wrote: > > On Mon, Jan 02, 2017 at 08:36:20AM -0800, James Bottomley wrote: > > > On Mon, 2017-01-02 at 15:22 +0200, Jarkko Sakkinen wrote: > > > > This

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-02 Thread James Bottomley
On Mon, 2017-01-02 at 21:33 +0200, Jarkko Sakkinen wrote: > On Mon, Jan 02, 2017 at 08:36:20AM -0800, James Bottomley wrote: > > On Mon, 2017-01-02 at 15:22 +0200, Jarkko Sakkinen wrote: > > > This patch set adds support for TPM spaces that provide a context > > >

Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager

2017-01-02 Thread James Bottomley
On Mon, 2017-01-02 at 15:22 +0200, Jarkko Sakkinen wrote: > This patch set adds support for TPM spaces that provide a context > for isolating and swapping transient objects. This patch set does > not yet include support for isolating policy and HMAC sessions but > it is trivial to add once the basi

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

2017-01-01 Thread James Bottomley
On Sun, 2017-01-01 at 11:33 -0500, David Miller wrote: > From: Bart Van Assche > Date: Sun, 1 Jan 2017 14:22:11 + > > > My recommendation is to revert commit 18f6084a989b ("scsi: mpt3sas: Fix > > secure erase premature termination"). Since the mpt3sas driver uses the > > single-queue approach

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

2016-12-31 Thread James Bottomley
On Thu, 2016-12-29 at 00:02 -0800, Christoph Hellwig wrote: > On Wed, Dec 28, 2016 at 11:30:24PM -0500, Jason Baron wrote: > > Add a new parameter to scsi_internal_device_block() to decide > > whether or not to invoke scsi_wait_for_queuecommand(). > > We'll also need to deal with the blk-mq wait

Re: linux-next: build failure after merge of the scsi tree

2016-12-24 Thread James Bottomley
On Sat, 2016-12-24 at 12:46 +0100, Thomas Gleixner wrote: > On Sat, 24 Dec 2016, Stephen Rothwell wrote: > > On Thu, 22 Dec 2016 16:56:34 -0800 James Bottomley < > > james.bottom...@hansenpartnership.com> wrote: > > > > > > On Fri, 2016-12-23 at 11:45 +1

Re: linux-next: build failure after merge of the scsi tree

2016-12-22 Thread James Bottomley
On Fri, 2016-12-23 at 11:45 +1100, Stephen Rothwell wrote: > Hi James, > > After merging the scsi tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/scsi/qedi/qedi_main.c: In function 'qedi_init': > drivers/scsi/qedi/qedi_main.c:2073:2: error: implicit declaratio

[GIT PULL] final round of SCSI updates for the 4.9+ merge window

2016-12-22 Thread James Bottomley
This is mostly stuff which missed the initial pull. There's a new driver: qedi, some ufs, ibmvscsis and ncr5380 updates plus some assorted driver fixes and also a fix for the bug where if a device goes into a blocked state between configuration and sysfs device add (which can be a long time under

[GIT PULL] first round of SCSI updates for the 4.9+ merge window

2016-12-13 Thread James Bottomley
This update includes the usual round of major driver updates (ncr5380, lpfc, hisi_sas, megaraid_sas, ufs, ibmvscsis, mpt3sas). There's also an assortment of minor fixes, mostly in error legs or other not very user visible stuff. The major change is the pci_alloc_irq_vectors replacement for the ol

Re: version 3.18.44 to 3.18.45 introduced a bug in "drivers/scsi/megaraid/megaraid_sas_base.c"

2016-12-13 Thread James Bottomley
On Tue, 2016-12-13 at 08:33 -0800, Randy Dunlap wrote: > On 12/13/16 08:30, Greg Kroah-Hartman wrote: > > I don't maintain 3.18-stable :) > > > > thanks, > > > > greg k-h > > > > Thanks. My bad. > > adding Sasha. This was all covered here: https://www.spinics.net/lists/stable/msg150608.html

[GIT PULL] SCSI fixes for 4.9-rc8

2016-12-08 Thread James Bottomley
One small fix for a regression in a prior fix (again). This time the condition in the prior fix BUG_ON proved to be wrong under certain circumstances causing a BUG to trigger where it shouldn't in the lpfc driver. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/sc

Re: LSF/MM 2017: Call for Proposals

2016-12-08 Thread James Bottomley
On Thu, 2016-12-08 at 13:26 +0100, Michal Hocko wrote: > On Wed 07-12-16 06:57:06, James Bottomley wrote: > [...] > > Just on this point, since there seems to be a lot of confusion: lsf > > -pc > > is the list for contacting the programme committee, so you ca

Re: LSF/MM 2017: Call for Proposals

2016-12-07 Thread James Bottomley
On Thu, 2016-12-01 at 09:11 -0500, Jeff Layton wrote: > 1) Proposals for agenda topics should be sent before January 15th, > 2016 to: > > lsf...@lists.linux-foundation.org > > and cc the Linux list or lists that are relevant for the topic in > question: > > ATA: linux-...@vger.kernel.

Re: [PATCH 8/9] MODSIGN: Import certificates from UEFI Secure Boot

2016-12-02 Thread James Bottomley
On Thu, 2016-11-24 at 11:17 -0800, James Bottomley wrote: > On Mon, 2016-11-21 at 16:16 +, Ard Biesheuvel wrote: > > On 16 November 2016 at 18:11, David Howells > > wrote: > > > From: Josh Boyer > > > > > > Secure Boot stores a list of allowed cert

[GIT PULL] SCSI fixes for 4.9-rc7

2016-11-29 Thread James Bottomley
Four small fixes. The be2iscsi is a potential device overrun in consistent memory, which could have nasty consequences if the consistent allocations are packed. The hpsa one fixes a regression where older controllers can now get a numbering clash between the first internal disk and the controller

Re: [PATCH 5/7] efi: Get the secure boot status [ver #3]

2016-11-24 Thread James Bottomley
On Wed, 2016-11-23 at 12:54 +, David Howells wrote: > Get the firmware's secure-boot status in the kernel boot wrapper and > stash it somewhere that the main kernel image can find. > > The efi_get_secureboot() function is extracted from the arm stub and > (a) generalised so that it can be ca

Re: [PATCH 8/9] MODSIGN: Import certificates from UEFI Secure Boot

2016-11-24 Thread James Bottomley
On Mon, 2016-11-21 at 11:25 -0500, Josh Boyer wrote: > On Mon, Nov 21, 2016 at 11:16 AM, Ard Biesheuvel > wrote: > > On 16 November 2016 at 18:11, David Howells > > wrote: > > > From: Josh Boyer > > > > > > Secure Boot stores a list of allowed certificates in the 'db' > > > variable. This impo

Re: [PATCH 8/9] MODSIGN: Import certificates from UEFI Secure Boot

2016-11-24 Thread James Bottomley
On Mon, 2016-11-21 at 16:16 +, Ard Biesheuvel wrote: > On 16 November 2016 at 18:11, David Howells > wrote: > > From: Josh Boyer > > > > Secure Boot stores a list of allowed certificates in the 'db' > > variable. This imports those certificates into the system trusted > > keyring. This a

[GIT PULL] SCSI fixes for 4.9-rc6

2016-11-21 Thread James Bottomley
Two small fixes. One prevents timeouts on mpt3sas when trying to use the secure erase protocol which causes the erase protocol to be aborted. The second is a regression in a prior fix which causes all commands to abort during PCI extended error recovery, which is incorrect because PCI EEH is inde

Re: [PATCH v2] Add a "nosymlinks" mount option.

2016-11-21 Thread James Bottomley
On Wed, 2016-11-16 at 13:18 -0800, Mattias Nissler wrote: > I understand that silence suggests there's little interest, but > here's some new information I discovered today that may justify to > reconsider the patch: > > The BSDs already have exactly what I propose, the mount option is > called "

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-21 Thread James Bottomley
On Mon, 2016-11-21 at 12:06 -0200, Mauro Carvalho Chehab wrote: > Em Mon, 21 Nov 2016 11:39:41 +0100 > Johannes Berg escreveu: > > On Sat, 2016-11-19 at 10:15 -0700, Jonathan Corbet wrote: > > > > > Rather than beating our heads against the wall trying to convert > > > between various image forma

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-17 Thread James Bottomley
On Thu, 2016-11-17 at 13:16 -0200, Mauro Carvalho Chehab wrote: > Hi Ted, > > Em Thu, 17 Nov 2016 09:52:44 -0500 > Theodore Ts'o escreveu: > > > On Thu, Nov 17, 2016 at 12:07:15PM +0100, Arnd Bergmann wrote: > > > [adding Linus for clarification] > > > > > > I understood the concern as being ab

[GIT PULL] SCSI fixes for 4.9-rc4

2016-11-11 Thread James Bottomley
The megaraid_sas patch in here fixes a major regression in the last fix set that made all megaraid_sas cards unusable. It turns out no-one had actually tested such an "obvious" fix, sigh. The fix for the fix has been tested ... The next most serious is the vmw_pvscsi abort problem which basical

Re: linux-next: manual merge of the scsi tree with the block tree

2016-11-08 Thread James Bottomley
On Tue, 2016-11-08 at 16:48 +1100, Stephen Rothwell wrote: > Hi James, > > Today's linux-next merge of the scsi tree got a conflict in: > > drivers/scsi/ufs/ufshcd.c > > between commit: > > e806402130c9 ("block: split out request-only flags into a new > namespace") > > from the block tree

[GIT PULL] SCSI fixes for 4.9-rc3

2016-11-05 Thread James Bottomley
Two more important data integrity fixes related to RAID device drivers which wrongly throw away the SYNCHRONIZE CACHE command in the non-RAID path and a memory leak fix in the scsi_debug driver. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes T

[GIT PULL] SCSI fixes for 4.9-rc2

2016-10-27 Thread James Bottomley
Two small fixes: one is a fatal section mismatch (reference to init after it's discarded) and the other two are iscsi locking fixes. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Arnd Bergmann (1): scsi: NCR5380

[GIT PULL] SCSI fixes for 4.9-rc1

2016-10-21 Thread James Bottomley
Five small fixes. Some of these, like the nested spinlock overwriting saved flags and the Kasan use after free look serious, but they seem not to have been picked up in testing or seen in the field. The biggest user visible issue is probably the wrong device handler for Clariion, which means that

Re: [PATCH] sd: assign appropriate log level

2016-10-17 Thread James Bottomley
On Mon, 2016-10-17 at 09:51 -0700, David Singleton wrote: > From: Shikhar Dogra > > Reduce chatter on console for usb hotplug. > KERN_ERR is too high severity for these messages, moving them > to KERN_WARNING It's an error because we have several USB to IDE bridges that have write back cache dri

[GIT PULL] final round of SCSI updates for the 4.8+ merge window

2016-10-13 Thread James Bottomley
This is just a set of minor updates and fixes which weren't quite ready in time for the first pull request. The only real thing of note is Mike Christie is stepping down as Maintainer of iscsi to be replaced by Lee Duncan and Chris Leech. The patch is available here: git://git.kernel.org/pub/scm

Re: [PATCH 4.7 122/141] scsi: ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-10-06 Thread James Bottomley
On Thu, 2016-10-06 at 10:29 +0200, Greg Kroah-Hartman wrote: > 4.7-stable review patch. If anyone has any objections, please let me > know. This doesn't build if SCSI_SAS_ATTRS isn't set without this patch: commit c1a23f6d64552b4480208aa584ec7e9c13d6d9c3 Author: Johannes Thumshirn Date: Wed

[GIT PULL] first round of SCSI updates for the 4.8+ merge window

2016-10-06 Thread James Bottomley
This update includes the usual round of major driver updates (hpsa, be2iscsi, hisi_sas, zfcp, cxlflash). There's a new incarnation of hpsa called smartpqi for which a driver is added, there's some cleanup work of the ibm vscsi target and updates to libfc, plus a whole host of minor fixes and updat

[GIT PULL] SCSI fixes for 4.8-rc8

2016-10-01 Thread James Bottomley
One final fix before 4.8: there's a memory leak triggered by turning scsi mq off due to the fact that we assume on host release that the already running hosts weren't mq based because that's the state of the global flag (even though they were), so fix it by tracking this on a per host host basis.

Re: [Intel-gfx] Skylake graphics regression: projector failure with 4.8-rc3

2016-09-19 Thread James Bottomley
On Mon, 2016-09-19 at 08:09 -0700, James Bottomley wrote: > On Sun, 2016-09-18 at 13:35 +0200, Thorsten Leemhuis wrote: > > Hi! James & Paulo: What's the current status of this? > > No, the only interaction has been the suggestion below for a revert, > which didn

Re: [Intel-gfx] Skylake graphics regression: projector failure with 4.8-rc3

2016-09-19 Thread James Bottomley
ween? Just > asking, because this issue is on the list of regressions for 4.8. I'm just about to try out -rc7, but it's not fixed so far. James > Ciao, Thorsten > > On 01.09.2016 00:25, James Bottomley wrote: > > On Wed, 2016-08-31 at 21:51 +, Zanoni, Paulo

Re: TRIM/UNMAP/DISCARD via ATA Passthrough

2016-09-16 Thread James Bottomley
On Fri, 2016-09-16 at 13:06 -0400, Austin S. Hemmelgarn wrote: > On 2016-09-16 12:21, James Bottomley wrote: > > On Fri, 2016-09-16 at 11:53 -0400, Austin S. Hemmelgarn wrote: > > > On 2016-09-16 07:16, Hannes Reinecke wrote: > > > > On 09/15/2016 10:52 PM, Jason A.

Re: TRIM/UNMAP/DISCARD via ATA Passthrough

2016-09-16 Thread James Bottomley
On Fri, 2016-09-16 at 11:53 -0400, Austin S. Hemmelgarn wrote: > On 2016-09-16 07:16, Hannes Reinecke wrote: > > On 09/15/2016 10:52 PM, Jason A. Donenfeld wrote: > > > Hi Martin, > > > > > > On Thu, Sep 15, 2016 at 6:07 PM, Martin K. Petersen > > > > But how do they signal that ATA passthrough is

[GIT PULL] SCSI fixes for 4.8-rc5

2016-09-06 Thread James Bottomley
This is really three fixes, but the SES one comes in a bundle of three (making the replacement API available properly, using it and removing the non-working one). The SES problem causes an oops on hpsa devices because they attach virtual disks to the host which aren't SAS attached (the replacement

Re: [Intel-gfx] Skylake graphics regression: projector failure with 4.8-rc3

2016-08-31 Thread James Bottomley
On Wed, 2016-08-31 at 21:51 +, Zanoni, Paulo R wrote: > Hi > > Em Qua, 2016-08-31 às 14:43 -0700, James Bottomley escreveu: > > On Wed, 2016-08-31 at 11:23 -0700, James Bottomley wrote: > > > > > > On Fri, 2016-08-26 at 09:10 -0400, James Bottomley wrote: &g

Re: Skylake graphics regression: projector failure with 4.8-rc3

2016-08-31 Thread James Bottomley
On Wed, 2016-08-31 at 11:23 -0700, James Bottomley wrote: > On Fri, 2016-08-26 at 09:10 -0400, James Bottomley wrote: > > We seem to have an xrandr regression with skylake now. What's > > happening is that I can get output on to a projector, but the > > system is losi

Re: Skylake graphics regression: projector failure with 4.8-rc3

2016-08-31 Thread James Bottomley
On Fri, 2016-08-26 at 09:10 -0400, James Bottomley wrote: > We seem to have an xrandr regression with skylake now. What's > happening is that I can get output on to a projector, but the system > is losing video when I change the xrandr sessions (like going from a > --above b

Re: [PATCH] binfmt_misc: allow selecting the interpreter based on xattr keywords

2016-08-26 Thread James Bottomley
On Fri, 2016-08-26 at 13:59 -0400, Carlos O'Donell wrote: > On 08/26/2016 10:55 AM, Florian Weimer wrote: > > On 08/25/2016 06:15 PM, James Bottomley wrote: > > > On Sun, 2016-08-21 at 21:01 -0700, Josh Max wrote: > > > > This patch allows binfmt_misc to select t

Re: [PATCH] binfmt_misc: allow selecting the interpreter based on xattr keywords

2016-08-26 Thread James Bottomley
On Fri, 2016-08-26 at 22:12 +0100, One Thousand Gnomes wrote: > > A non-security use case would be to run the binary (without > > modification) with a different ELF interpreter (assuming this > > allows to override binfmt_elf, but self-sandboxing would need that > > as well). This would make it

Skylake graphics regression: projector failure with 4.8-rc3

2016-08-26 Thread James Bottomley
We seem to have an xrandr regression with skylake now. What's happening is that I can get output on to a projector, but the system is losing video when I change the xrandr sessions (like going from a - -above b to a --same-as b). The main screen goes blank, which is basically a reboot situation.

Re: Skylake graphics regression: projector failure with 4.8-rc3

2016-08-26 Thread James Bottomley
On Fri, 2016-08-26 at 09:10 -0400, James Bottomley wrote: > We seem to have an xrandr regression with skylake now. What's > happening is that I can get output on to a projector, but the system > is losing video when I change the xrandr sessions (like going from a > --above b

Re: [PATCH] binfmt_misc: allow selecting the interpreter based on xattr keywords

2016-08-25 Thread James Bottomley
On Sun, 2016-08-21 at 21:01 -0700, Josh Max wrote: > This patch allows binfmt_misc to select the interpeter for arbitrary > binaries by comparing a specified registered keyword with the value > of a specified binary's extended attribute (user.binfmt.interp), > and then launching the program with th

Re: [Documentation] State of CPU controller in cgroup v2

2016-08-20 Thread James Bottomley
On Wed, 2016-08-17 at 13:18 -0700, Andy Lutomirski wrote: > On Aug 5, 2016 7:07 PM, "Tejun Heo" wrote: [...] > > 2. Disagreements and Arguments > > > > There have been several lengthy discussion threads [3][4] on LKML > > around the structural constraints of cgroup v2. The two that > > affect t

[GIT PULL] SCSI fixes for 4.8-rc2

2016-08-19 Thread James Bottomley
Six fairly small fixes. The ipr, mpt3sas and ses ones all trigger oopses. The megaraid one fixes an attach failure on io mapped only cards, the fcoe one is an obvious problem in the error path and the aacraid one is a theoretical security issue (ability to trick the kernel into a buffer overrun).

Re: [PATCH v4 2/3] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-18 Thread James Bottomley
On Wed, 2016-08-17 at 11:46 +0200, Johannes Thumshirn wrote: > Use scsi_is_sas_rphy() instead of is_sas_attached() to decide whether > we should obtain the SAS address from a scsi device or not. This will > prevent us from tripping on the BUG_ON() in sas_sdev_to_rdev() if the > rphy isn't attached

Re: [PATCH v4 2/3] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-18 Thread James Bottomley
And please fix your scripts or just use the standard ones: Cc: sta...@vger.kernel.org, #@suse.de, v4...@suse.de, I'm tired of getting two bounces every time I reply to this thread. James

Re: [PATCH v2 1/3] sas: provide stub implementations for scsi_is_sas_phy and sas_get_address

2016-08-15 Thread James Bottomley
On Mon, 2016-08-15 at 17:12 +0200, Johannes Thumshirn wrote: > +static inline u64 sas_get_address(struct scsi_device *sdev) > +{ > + return 0; > +} To be honest, we don't want this. We do want the code to fail to compile if you ever use sas_get_address where you shouldn't because the code wil

Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-15 Thread James Bottomley
On Mon, 2016-08-15 at 16:40 +0200, Johannes Thumshirn wrote: > On Mon, Aug 15, 2016 at 07:25:53AM -0700, James Bottomley wrote: > > On Mon, 2016-08-15 at 22:11 +0800, kbuild test robot wrote: > > > Hi Johannes, > > > > > > [auto build test ERROR on scsi/for-n

Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-15 Thread James Bottomley
On Mon, 2016-08-15 at 22:11 +0800, kbuild test robot wrote: > Hi Johannes, > > [auto build test ERROR on scsi/for-next] > [also build test ERROR on v4.8-rc2 next-20160815] > [if your patch is applied to the wrong git tree, please drop us a > note to help improve the system] This is happening bec

Re: [PATCH] ses: Fix racy cleanup of /sys in remove_dev()

2016-08-12 Thread James Bottomley
sys files, with this patch I haven't seen a single one.) > > Calvin> Ping? Thoughts, comments? > > James: This is your puppy... I thought it would be bigger by now going by the early paw size indicator ... Anyway Reviewed-by: James Bottomley James

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

2016-08-12 Thread James Bottomley
On Fri, 2016-08-12 at 16:39 +0200, Hannes Reinecke wrote: > On 08/12/2016 04:34 PM, James Bottomley wrote: > > On Fri, 2016-08-12 at 15:11 +0200, Johannes Thumshirn wrote: > > > On Fri, Aug 12, 2016 at 12:08:54PM +0200, Johannes Thumshirn > > > wrote: > > > &g

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

2016-08-12 Thread James Bottomley
On Fri, 2016-08-12 at 15:11 +0200, Johannes Thumshirn wrote: > On Fri, Aug 12, 2016 at 12:08:54PM +0200, Johannes Thumshirn wrote: > > Ok, we can't use the rphy because of wide-ports. We can't fix it to > > an end device either, as this makes some peoples systems > > unbootable. Now let's find a

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

2016-08-11 Thread James Bottomley
On Thu, 2016-08-11 at 18:43 +0200, Johannes Thumshirn wrote: > On Thu, Aug 11, 2016 at 08:09:35AM -0700, James Bottomley wrote: > > On Thu, 2016-08-11 at 09:59 +0200, Johannes Thumshirn wrote: > > > Since commit 3f8d6f2a0 ('ses: fix discovery of SATA devices in >

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

2016-08-11 Thread James Bottomley
On Thu, 2016-08-11 at 09:59 +0200, Johannes Thumshirn wrote: > Since commit 3f8d6f2a0 ('ses: fix discovery of SATA devices in SAS > enclosures') ses_match_to_enclosure() is calling sas_get_address(), > which is coming from commit bcf508c13385 ('scsi_transport_sas: add > function to get SAS endpoint

[GIT PULL] first round of SCSI updates for the 4.7+ merge window

2016-08-06 Thread James Bottomley
This is seven basic fixes (plus one MAINTAINERS update) which came in close to the merge window. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-misc The short changelog is: Brian King (1): ipr: Wait to do async scan until scsi host is initial

Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread James Bottomley
On Tue, 2016-08-02 at 18:39 +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access > permission. As we know, these numeric value for access permission > have had the corresponding macro, and th

Re: [GIT PULL] configfs updates for 4.8

2016-07-28 Thread James Bottomley
On Thu, 2016-07-28 at 13:24 -0700, Linus Torvalds wrote: > On Thu, Jul 28, 2016 at 1:18 PM, Al Viro > wrote: > > > > FWIW, git request-pull is very likely to make complete mess of > > diffstat - all it takes is branch started at -rc1, then a merge > > from > > anything started at later point (e.g

Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window

2016-07-28 Thread James Bottomley
On Wed, 2016-07-27 at 20:30 -0700, Joe Perches wrote: > On Wed, 2016-07-27 at 20:26 -0700, Linus Torvalds wrote: > > On Wed, Jul 27, 2016 at 8:21 PM, Joe Perches > > wrote: > > > > > > On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote: > > > > > > > > Did you actually try it. > > > yes. >

[GIT PULL] binfmt_misc updates for 4.7+ merge window

2016-07-27 Thread James Bottomley
ing tools, like systemd-binfmt work with this without modification. It's also all been incubated in linux-next for over a month. The update is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/binfmt_misc.git binfmt-for-linus The short changelog is: James Bottomley (3):

[GIT PULL] first round of SCSI updates for the 4.7+ merge window

2016-07-27 Thread James Bottomley
This update includes the usual round of driver updates (fcoe, lpfc, ufs, qla2xxx, hisi_sas). The most important other change is removing the flag to allow non-blk_mq on a per host basis (it's unused); there is still a global module parameter for all of SCSI just in case. The rest are an assortmen

Re: [PATCH 0/5 RFC] Add an interface to discover relationships between namespaces

2016-07-23 Thread James Bottomley
On Sat, 2016-07-23 at 14:14 -0700, W. Trevor King wrote: > On Thu, Jul 14, 2016 at 11:20:14AM -0700, Andrey Vagin wrote: > > Pid and user namepaces are hierarchical. There is no way to > > discover parent-child relationships too. > > It bothers me that network namespaces are not hierarchical too

Re: [PATCH v1 3/3] cgroup: relax common ancestor restriction for direct descendants

2016-07-21 Thread James Bottomley
On Thu, 2016-07-21 at 11:50 -0400, Tejun Heo wrote: > Hello, James. > > On Thu, Jul 21, 2016 at 08:34:36AM -0700, James Bottomley wrote: > > So if I as the cgroup ns owner am moving a task from A to A_subdir, > > the admin scanning tasks in all of A may miss this task in m

Re: [PATCH v1 3/3] cgroup: relax common ancestor restriction for direct descendants

2016-07-21 Thread James Bottomley
On Thu, 2016-07-21 at 11:26 -0400, Tejun Heo wrote: > Hello, James. > > On Thu, Jul 21, 2016 at 08:16:34AM -0700, James Bottomley wrote: > > > That'd be one side. The other side is the one moving. Let's say > > > the system admin thing wants to move all pro

Re: [PATCH v1 3/3] cgroup: relax common ancestor restriction for direct descendants

2016-07-21 Thread James Bottomley
On Thu, 2016-07-21 at 11:07 -0400, Tejun Heo wrote: > Hello, James. > > On Thu, Jul 21, 2016 at 08:04:16AM -0700, James Bottomley wrote: > > > I understand what you're trying to achieve but don't think > > > cgroup's filesystem interface can accomod

Re: [PATCH v1 3/3] cgroup: relax common ancestor restriction for direct descendants

2016-07-21 Thread James Bottomley
On Thu, 2016-07-21 at 10:52 -0400, Tejun Heo wrote: > Hello, Aleksa. > > On Thu, Jul 21, 2016 at 05:49:36PM +1000, Aleksa Sarai wrote: > > > > The reason I'm doing this is so that we might be able to > > > > _practically_ use cgroups as an unprivileged user (something > > > > that will almost ce

Re: [PATCH v1 3/3] cgroup: relax common ancestor restriction for direct descendants

2016-07-21 Thread James Bottomley
On Thu, 2016-07-21 at 09:33 -0500, Serge E. Hallyn wrote: > Quoting Aleksa Sarai (asa...@suse.de): > > > > The reason I'm doing this is so that we might be able to > > > > _practically_ use cgroups as an unprivileged user (something > > > > that will almost certainly be useful to not just the cont

Re: [CRIU] Introspecting userns relationships to other namespaces?

2016-07-10 Thread James Bottomley
On Sun, 2016-07-10 at 15:29 -0500, Eric W. Biederman wrote: > Andrew Vagin writes: > > > On Fri, Jul 08, 2016 at 10:13:08PM -0500, Eric W. Biederman wrote: > > > "W. Trevor King" writes: > > > > > > > On Thu, Jul 07, 2016 at 08:01:52AM -0700

<    4   5   6   7   8   9   10   11   12   13   >