[PATCH] mfd: intel-lpss: Fix Intel Cannon Lake LPSS I2C input clock

: b418bbff36dd ("mfd: intel-lpss: Add Intel Cannonlake PCI IDs") Reported-by: Jian-Hong Pan <jian-h...@endlessm.com> Reported-by: Chris Chiu <c...@endlessm.com> Reported-by: Daniel Drake <dr...@endlessm.com> Signed-off-by: Jarkko Nikula <jarkko.nik...@linux.int

[PATCH] mfd: intel-lpss: Fix Intel Cannon Lake LPSS I2C input clock

: b418bbff36dd ("mfd: intel-lpss: Add Intel Cannonlake PCI IDs") Reported-by: Jian-Hong Pan Reported-by: Chris Chiu Reported-by: Daniel Drake Signed-off-by: Jarkko Nikula --- Hi Jian-Hong, Chris and Daniel. Could you test does this fix your touchpad issue? --- drivers/mfd/intel-lpss-

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

Hi On 05/15/2018 01:20 PM, Jarkko Nikula wrote: On 05/15/2018 06:22 AM, Chris Chiu wrote: What if I change the 120MHz to 180MHz and then make sure that the I2C operates in target FS mode frequency 400kHz via scope? Would there be any side effect? Maybe some other busses frequency could

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

Hi On 05/15/2018 01:20 PM, Jarkko Nikula wrote: On 05/15/2018 06:22 AM, Chris Chiu wrote: What if I change the 120MHz to 180MHz and then make sure that the I2C operates in target FS mode frequency 400kHz via scope? Would there be any side effect? Maybe some other busses frequency could

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

On 05/15/2018 06:22 AM, Chris Chiu wrote: What if I change the 120MHz to 180MHz and then make sure that the I2C operates in target FS mode frequency 400kHz via scope? Would there be any side effect? Maybe some other busses frequency could be also affected and causing some other component

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

On 05/15/2018 06:22 AM, Chris Chiu wrote: What if I change the 120MHz to 180MHz and then make sure that the I2C operates in target FS mode frequency 400kHz via scope? Would there be any side effect? Maybe some other busses frequency could be also affected and causing some other component

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

On 05/10/2018 03:03 PM, Chris Chiu wrote: Report from guys who can access scope. If i2c-sda-falling-time-ns=400ns , HCNT increase to 117, the SCL high duration is 576ns as follows https://pasteboard.co/HkwERvP.png The original SCL high duration (HCNT = 105, 120MHz) is as follows

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

On 05/10/2018 03:03 PM, Chris Chiu wrote: Report from guys who can access scope. If i2c-sda-falling-time-ns=400ns , HCNT increase to 117, the SCL high duration is 576ns as follows https://pasteboard.co/HkwERvP.png The original SCL high duration (HCNT = 105, 120MHz) is as follows

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

Hi On 05/07/2018 11:07 AM, Chris Chiu wrote: Besides, according to ASUS's input, they observed that after entering the OS, the frequency of SCL is too fast (about 600kHz) and the SCL High time is around 450ns, not following I2C spec which is 0.6us. https://pasteboard.co/HjzSWXd.png Some

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

Hi On 05/07/2018 11:07 AM, Chris Chiu wrote: Besides, according to ASUS's input, they observed that after entering the OS, the frequency of SCL is too fast (about 600kHz) and the SCL High time is around 450ns, not following I2C spec which is 0.6us. https://pasteboard.co/HjzSWXd.png Some

Re: [RFC PATCH spi] spi: pxa2xx: pxa2xx_spi_transfer_one() can be static

struct spi_transfer *transfer) Thanks Fengguang. I don't understand how I managed to drop "static" while doing manual s/pump_transfers/pxa2xx_spi_transfer_one/ :-) Reviewed-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [RFC PATCH spi] spi: pxa2xx: pxa2xx_spi_transfer_one() can be static

_transfer *transfer) Thanks Fengguang. I don't understand how I managed to drop "static" while doing manual s/pump_transfers/pxa2xx_spi_transfer_one/ :-) Reviewed-by: Jarkko Nikula

Build failure due commit 9217e566bdee

Hi Today's head and linux-next doesn't compile due commit 9217e566bdee ("of_net: Implement of_get_nvmem_mac_address helper"): drivers/of/of_net.o: In function `of_get_nvmem_mac_address': .../drivers/of/of_net.c:100: undefined reference to `of_nvmem_cell_get' .../drivers/of/of_net.c:104:

Build failure due commit 9217e566bdee

Hi Today's head and linux-next doesn't compile due commit 9217e566bdee ("of_net: Implement of_get_nvmem_mac_address helper"): drivers/of/of_net.o: In function `of_get_nvmem_mac_address': .../drivers/of/of_net.c:100: undefined reference to `of_nvmem_cell_get' .../drivers/of/of_net.c:104:

Re: Applied "spi: Fix unregistration of controller with fixed SPI bus number" to the regulator tree

Hi On 03/07/2018 04:15 PM, Mark Brown wrote: The patch spi: Fix unregistration of controller with fixed SPI bus number has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git Was this lost in the regulator tree? I noticed my

Re: Applied "spi: Fix unregistration of controller with fixed SPI bus number" to the regulator tree

Hi On 03/07/2018 04:15 PM, Mark Brown wrote: The patch spi: Fix unregistration of controller with fixed SPI bus number has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git Was this lost in the regulator tree? I noticed my

Re: [PATCH 5/7] PM: i2c-designware-platdrv: Use DPM_FLAG_SMART_PREPARE

(+), 1 deletion(-) Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH 5/7] PM: i2c-designware-platdrv: Use DPM_FLAG_SMART_PREPARE

ary any more, because the core does it when setting power.direct_complete for the device, so drop it. Signed-off-by: Rafael J. Wysocki --- drivers/i2c/busses/i2c-designware-platdrv.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) Acked-by: Jarkko Nikula

Re: [PATCH 6/7] PM: i2c-designware-platdrv: Optimize power management

designware-core.h|2 - drivers/i2c/busses/i2c-designware-platdrv.c | 31 ++-- 2 files changed, 12 insertions(+), 21 deletions(-) This doesn't apply to linux-next due 0326f9f801b2 ("i2c: designware: rename i2c_dw_plat_prepare_clk to i2c_dw_prepare_clk"

Re: [PATCH 6/7] PM: i2c-designware-platdrv: Optimize power management

rv.c | 31 ++-- 2 files changed, 12 insertions(+), 21 deletions(-) This doesn't apply to linux-next due 0326f9f801b2 ("i2c: designware: rename i2c_dw_plat_prepare_clk to i2c_dw_prepare_clk"). It was trivial to fix which I did locally for testing. Acked-by: Jarkko Nikula

Re: [PATCH 0/7] PM / core: Direct handling of DPM_FLAG_SMART_SUSPEND and DPM_FLAG_LEAVE_SUSPENDED

and touchpad devices were working fine. I used linux-next next-20180108 and patches 4-7/7. Tested-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH 0/7] PM / core: Direct handling of DPM_FLAG_SMART_SUSPEND and DPM_FLAG_LEAVE_SUSPENDED

and touchpad devices were working fine. I used linux-next next-20180108 and patches 4-7/7. Tested-by: Jarkko Nikula

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

On Wed, Dec 20, 2017 at 10:32:11AM +0100, Greg Kroah-Hartman wrote: > On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote: > > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote: > > > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote: > > >

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

On Wed, Dec 20, 2017 at 10:32:11AM +0100, Greg Kroah-Hartman wrote: > On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote: > > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote: > > > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote: > > >

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

ude/linux/sysfs.h S_IWUSR: include/uapi/linux/stat.h S_IRUGO: include/linux/stat.h Jarkko Nikula <jarkko.nik...@bitmer.com>

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

ude/linux/sysfs.h S_IWUSR: include/uapi/linux/stat.h S_IRUGO: include/linux/stat.h Jarkko Nikula

Re: [PATCH urgent 0/3] __restore_processor_state() fixes

On 12/15/2017 03:28 AM, Rafael J. Wysocki wrote: On Thursday, December 14, 2017 10:19:04 PM CET Andy Lutomirski wrote: __restore_processor_state() was spaghetti code, made no sense, and had bugs. And I broke resume on 32-bit systems. This series cleans it up and fixes it (hopefully!). Andy

Re: [PATCH urgent 0/3] __restore_processor_state() fixes

On 12/15/2017 03:28 AM, Rafael J. Wysocki wrote: On Thursday, December 14, 2017 10:19:04 PM CET Andy Lutomirski wrote: __restore_processor_state() was spaghetti code, made no sense, and had bugs. And I broke resume on 32-bit systems. This series cleans it up and fixes it (hopefully!). Andy

Re: Linux 4.15-rc2: Regression in resume from ACPI S3

it/commit/?h=x86/fixes=cb855aa9679a15adbe43732f5854270de2b35856 I've barely tested it. It suspended and resumed once in a 64-bit VM. It compiles on 32-bit. I tested with "rtcwake -s 5 -m mem" 2-3 times on a real machine. Both 64-bit and 32-bit work. Tested-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: Linux 4.15-rc2: Regression in resume from ACPI S3

=cb855aa9679a15adbe43732f5854270de2b35856 I've barely tested it. It suspended and resumed once in a 64-bit VM. It compiles on 32-bit. I tested with "rtcwake -s 5 -m mem" 2-3 times on a real machine. Both 64-bit and 32-bit work. Tested-by: Jarkko Nikula

Re: [PATCH] Fix resume on x86-32 machines

Anyway, that should be easy enough to verify. Pavel, can you please check if the below change works too? --- arch/x86/power/cpu.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Works here on my test machine. Tested-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH] Fix resume on x86-32 machines

be easy enough to verify. Pavel, can you please check if the below change works too? --- arch/x86/power/cpu.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Works here on my test machine. Tested-by: Jarkko Nikula

Re: [PATCH] Fix resume on x86-32 machines

On 12/11/2017 12:20 AM, Pavel Machek wrote: On Sun 2017-12-10 13:58:23, Andy Lutomirski wrote: On Dec 10, 2017, at 1:38 PM, Pavel Machek wrote: After 4.15-rc2, suspend stopped working on Thinkpad X60. 5b06bbc (unintentionally?) reordered stuff with respect to

Re: [PATCH] Fix resume on x86-32 machines

On 12/11/2017 12:20 AM, Pavel Machek wrote: On Sun 2017-12-10 13:58:23, Andy Lutomirski wrote: On Dec 10, 2017, at 1:38 PM, Pavel Machek wrote: After 4.15-rc2, suspend stopped working on Thinkpad X60. 5b06bbc (unintentionally?) reordered stuff with respect to fix_processor_context() on

Re: [PATCH] x86/power: Fix some ordering bugs in __restore_processor_context()

write(1, buf, len); return 0; } and running ldt_echo >/sys/power/mem Without the fix, the latter causes a triple fault on resume. Reported-by: Jarkko Nikula <jarkko.nik...@linux.intel.com> Fixes: ca37e57bbe0c ("x86/entry/64: Add missing irqflags tracing to native_loa

Re: [PATCH] x86/power: Fix some ordering bugs in __restore_processor_context()

write(1, buf, len); return 0; } and running ldt_echo >/sys/power/mem Without the fix, the latter causes a triple fault on resume. Reported-by: Jarkko Nikula Fixes: ca37e57bbe0c ("x86/entry/64: Add missing irqflags tracing to native_load_gs_index()") Signed-off-by: A

Re: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled

On 11/29/2017 08:12 PM, Andy Lutomirski wrote: On Wed, Nov 29, 2017 at 9:57 AM, Andy Lutomirski <l...@kernel.org> wrote: On Tue, Nov 28, 2017 at 11:09 PM, Ingo Molnar <mi...@kernel.org> wrote: * Jarkko Nikula <jarkko.nik...@linux.intel.com> wrote: Hi Suspend-to-ram

Re: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled

On 11/29/2017 08:12 PM, Andy Lutomirski wrote: On Wed, Nov 29, 2017 at 9:57 AM, Andy Lutomirski wrote: On Tue, Nov 28, 2017 at 11:09 PM, Ingo Molnar wrote: * Jarkko Nikula wrote: Hi Suspend-to-ram and resume stopped working on v4.15-rc1 and I bisected it to commit ca37e57bbe0c (&quo

Re: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled

On 11/29/2017 11:28 AM, Thomas Gleixner wrote: On Wed, 29 Nov 2017, Jarkko Nikula wrote: On 11/29/2017 09:09 AM, Ingo Molnar wrote: Hm, that commit looks broken with irq-tracing enabled. Does the patch below fix it? No, it makes the machine not to boot at all :-( Log below when I used my

Re: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled

On 11/29/2017 11:28 AM, Thomas Gleixner wrote: On Wed, 29 Nov 2017, Jarkko Nikula wrote: On 11/29/2017 09:09 AM, Ingo Molnar wrote: Hm, that commit looks broken with irq-tracing enabled. Does the patch below fix it? No, it makes the machine not to boot at all :-( Log below when I used my

Re: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled

On 11/29/2017 09:09 AM, Ingo Molnar wrote: * Jarkko Nikula <jarkko.nik...@linux.intel.com> wrote: Hi Suspend-to-ram and resume stopped working on v4.15-rc1 and I bisected it to commit ca37e57bbe0c ("x86/entry/64: Add missing irqflags tracing to native_load_gs_index()&quo

Re: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled

On 11/29/2017 09:09 AM, Ingo Molnar wrote: * Jarkko Nikula wrote: Hi Suspend-to-ram and resume stopped working on v4.15-rc1 and I bisected it to commit ca37e57bbe0c ("x86/entry/64: Add missing irqflags tracing to native_load_gs_index()"). I noticed it on Intel Kaby

Suspend-to-ram/resume regression with commit ca37e57bbe0c

Hi Suspend-to-ram and resume stopped working on v4.15-rc1 and I bisected it to commit ca37e57bbe0c ("x86/entry/64: Add missing irqflags tracing to native_load_gs_index()"). I noticed it on Intel Kabylake (core) and Apollolake (atom) based prototype machines. Symptoms are that machine

Suspend-to-ram/resume regression with commit ca37e57bbe0c

Hi Suspend-to-ram and resume stopped working on v4.15-rc1 and I bisected it to commit ca37e57bbe0c ("x86/entry/64: Add missing irqflags tracing to native_load_gs_index()"). I noticed it on Intel Kabylake (core) and Apollolake (atom) based prototype machines. Symptoms are that machine

Re: [PATCH] i2c: designware: make *CNT values configurable

Hi On 10/25/2017 09:50 PM, Shikhar Dogra wrote: The values are already configurable from ACPI. This patch makes the high count (HCNT) and low count (LCNT) register values configurable through device tree. Cc: xe-linux-exter...@cisco.com Signed-off-by: Shikhar Dogra ---

Re: [PATCH] i2c: designware: make *CNT values configurable

Hi On 10/25/2017 09:50 PM, Shikhar Dogra wrote: The values are already configurable from ACPI. This patch makes the high count (HCNT) and low count (LCNT) register values configurable through device tree. Cc: xe-linux-exter...@cisco.com Signed-off-by: Shikhar Dogra ---

Re: [PATCH] device property: Track owner device of device property

On 10/20/2017 05:34 PM, Greg Kroah-Hartman wrote: @@ -938,6 +940,7 @@ int device_add_properties(struct device *dev, p->fwnode.ops = _fwnode_ops; set_secondary_fwnode(dev, >fwnode); + p->dev = dev; Don't you also need to increment the reference counter here? Or how is it

Re: [PATCH] device property: Track owner device of device property

On 10/20/2017 05:34 PM, Greg Kroah-Hartman wrote: @@ -938,6 +940,7 @@ int device_add_properties(struct device *dev, p->fwnode.ops = _fwnode_ops; set_secondary_fwnode(dev, >fwnode); + p->dev = dev; Don't you also need to increment the reference counter here? Or how is it

[PATCH] device property: Track owner device of device property

leted. Fixes: 478573c93abd ("driver core: Don't leak secondary fwnode on device removal") Cc: <sta...@vger.kernel.org> # v4.9+ Signed-off-by: Jarkko Nikula <jarkko.nik...@linux.intel.com> --- drivers/base/property.c | 15 +-- 1 file changed, 9 insertions(+), 6

[PATCH] device property: Track owner device of device property

leted. Fixes: 478573c93abd ("driver core: Don't leak secondary fwnode on device removal") Cc: # v4.9+ Signed-off-by: Jarkko Nikula --- drivers/base/property.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/base/property.c b/driver

Re: [PATCH] i2c: designware: make const array supported_speeds static to shink object code size

static const int supported_speeds[] = { + 0, 10, 40, 100, 340 + }; Oh, this is so easy to forget. Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH] i2c: designware: make const array supported_speeds static to shink object code size

, 10, 40, 100, 340 + }; Oh, this is so easy to forget. Acked-by: Jarkko Nikula

Re: [PATCH] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices

On 08/31/2017 07:04 PM, Andy Shevchenko wrote: On Mon, Aug 14, 2017 at 11:52 PM, Hans de Goede wrote: On 14-08-17 22:45, Andy Shevchenko wrote: On Mon, Aug 14, 2017 at 11:14 PM, Hans de Goede wrote: +int cht_int33fe_check_for_max17047(struct

Re: [PATCH] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices

On 08/31/2017 07:04 PM, Andy Shevchenko wrote: On Mon, Aug 14, 2017 at 11:52 PM, Hans de Goede wrote: On 14-08-17 22:45, Andy Shevchenko wrote: On Mon, Aug 14, 2017 at 11:14 PM, Hans de Goede wrote: +int cht_int33fe_check_for_max17047(struct device *dev, void *data) +{ + const char

Re: [PATCH 05/11] ASoC: omap: make snd_soc_platform_driver const

t; > --- > sound/soc/omap/omap-pcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Jarkko Nikula <jarkko.nik...@bitmer.com>

Re: [PATCH 05/11] ASoC: omap: make snd_soc_platform_driver const

c/omap/omap-pcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Jarkko Nikula

Re: [PATCH][i2c-next] i2c: designware: fix spelling mistakes

t;colin.k...@canonical.com> --- drivers/i2c/busses/i2c-designware-slave.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH][i2c-next] i2c: designware: fix spelling mistakes

re-slave.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Jarkko Nikula

Re: [PATCH v12 2/2] i2c: designware: enable SLAVE in platform module

c-designware-core.h| 2 ++ drivers/i2c/busses/i2c-designware-platdrv.c | 41 + 2 files changed, 38 insertions(+), 5 deletions(-) Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH v12 2/2] i2c: designware: enable SLAVE in platform module

-designware-platdrv.c | 41 + 2 files changed, 38 insertions(+), 5 deletions(-) Acked-by: Jarkko Nikula

Re: [PATCH v12 1/2] i2c: designware: add SLAVE mode functions

t all of those variables are not necessary in this debug print (e.g. are we interested other than bit 0 in DW_IC_ENABLE and line above already returns if it reads zero). - Typos "STAUTS SLAVE_ACTTVITY". You may add my acked by if you want to send another version or I'm fine w

Re: [PATCH v12 1/2] i2c: designware: add SLAVE mode functions

re not necessary in this debug print (e.g. are we interested other than bit 0 in DW_IC_ENABLE and line above already returns if it reads zero). - Typos "STAUTS SLAVE_ACTTVITY". You may add my acked by if you want to send another version or I'm fine with incremental patch also. Acked-by: Jarkko Nikula

Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

On 06/19/2017 07:22 PM, Wolfram Sang wrote: I wonder if we haven't reached a state where Luis just could fix the buildbot error (missing 'select I2C_SLAVE') and the thing pointed out by Andy and we handle further small fixes incrementally during the v4.13 cycle? AFAICS there is no major

Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

On 06/19/2017 07:22 PM, Wolfram Sang wrote: I wonder if we haven't reached a state where Luis just could fix the buildbot error (missing 'select I2C_SLAVE') and the thing pointed out by Andy and we handle further small fixes incrementally during the v4.13 cycle? AFAICS there is no major

Re: [PATCH 1/8] i2c: rename core source file to allow refactorization

the transaction here. FWIW, Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH 1/8] i2c: rename core source file to allow refactorization

the transaction here. FWIW, Acked-by: Jarkko Nikula

Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660

On 05/24/2017 05:34 AM, zhangfei wrote: Rob suggest add something like "hisilicon,hi3660-dw-i2c" as well. "The problem is dw-i2c does not give any clue as to what the configuration or version of the IP is. Is that fully discoverable with version/capability registers? If not then you need a

Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660

On 05/24/2017 05:34 AM, zhangfei wrote: Rob suggest add something like "hisilicon,hi3660-dw-i2c" as well. "The problem is dw-i2c does not give any clue as to what the configuration or version of the IP is. Is that fully discoverable with version/capability registers? If not then you need a

Re: [PATCH] i2c: designware: Fix bogus sda_hold_time due to uninitialized vars

mings described by ACPI from clock rate") Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- Affects 4.12-rc2. Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH] i2c: designware: Fix bogus sda_hold_time due to uninitialized vars

mings described by ACPI from clock rate") Signed-off-by: Jan Kiszka --- Affects 4.12-rc2. Acked-by: Jarkko Nikula

Re: [PATCH v9 5/6] i2c: designware: add SLAVE mode functions

On 05/08/2017 07:53 PM, Andy Shevchenko wrote: + } else if (reg == (DW_IC_COMP_TYPE_VALUE & 0x)) { GENMASK(15, 0) I don't think this increase readability compared to 0x here. -- Jarkko

Re: [PATCH v9 5/6] i2c: designware: add SLAVE mode functions

On 05/08/2017 07:53 PM, Andy Shevchenko wrote: + } else if (reg == (DW_IC_COMP_TYPE_VALUE & 0x)) { GENMASK(15, 0) I don't think this increase readability compared to 0x here. -- Jarkko

Re: [PATCH v8 5/6] i2c: designware: add SLAVE mode functions

On 04/12/2017 07:47 PM, Luis Oliveira wrote: - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support - Slave functions added to core library file - Slave abort sources added to common source file - New driver: i2c-designware-slave added - Changes in the Makefile to compile the

Re: [PATCH v8 5/6] i2c: designware: add SLAVE mode functions

On 04/12/2017 07:47 PM, Luis Oliveira wrote: - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support - Slave functions added to core library file - Slave abort sources added to common source file - New driver: i2c-designware-slave added - Changes in the Makefile to compile the

Re: [PATCH v8 4/6] i2c: designware: introducing I2C_SLAVE definitions

<loli...@synopsys.com> Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Acked-by: Rob Herring <r...@kernel.org> Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com> --- v7-v8 - no changes ... +#define DW_IC_RX_ABRT_SLAVE_RD_INTX(1UL <<

Re: [PATCH v8 3/6] i2c: designware: MASTER mode as separated driver

are-common.c rename drivers/i2c/busses/{i2c-designware-core.c => i2c-designware-master.c} (65%) Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH v8 4/6] i2c: designware: introducing I2C_SLAVE definitions

Reviewed-by: Andy Shevchenko Acked-by: Rob Herring Acked-by: Jarkko Nikula --- v7-v8 - no changes ... +#define DW_IC_RX_ABRT_SLAVE_RD_INTX(1UL << ABRT_SLAVE_RD_INTX) +#define DW_IC_RX_ABRT_SLAVE_ARBLOST(1UL << ABRT_SLAVE_ARBLOST) +#define DW_IC_RX_ABRT_SLAVE_FLUSH_TXFIF

Re: [PATCH v8 3/6] i2c: designware: MASTER mode as separated driver

=> i2c-designware-master.c} (65%) Acked-by: Jarkko Nikula

Re: [PATCH] i2c: designware: Get selected speed mode sda-hold-time via ACPI

of loading all speed mode settings, only selected speed mode settings are loaded. Signed-off-by: Tan Chin Yew <chin.yew@intel.com> Looks good to me: Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH] i2c: designware: Get selected speed mode sda-hold-time via ACPI

of loading all speed mode settings, only selected speed mode settings are loaded. Signed-off-by: Tan Chin Yew Looks good to me: Reviewed-by: Andy Shevchenko Acked-by: Jarkko Nikula

Re: [RESEND][PATCH v2] i2c: designwear: Fix clk warning on suspend/resume

to using pm_runtime_force_suspend and pm_runtime_force_resume. Cc: Jarkko Nikula <jarkko.nik...@linux.intel.com> Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com> Cc: Mika Westerberg <mika.westerb...@linux.intel.com> Cc: Wolfram Sang <w...@the-dreams.de> Cc: linux-...@v

Re: [RESEND][PATCH v2] i2c: designwear: Fix clk warning on suspend/resume

to using pm_runtime_force_suspend and pm_runtime_force_resume. Cc: Jarkko Nikula Cc: Andy Shevchenko Cc: Mika Westerberg Cc: Wolfram Sang Cc: linux-...@vger.kernel.org Suggested-by: Jarkko Nikula Signed-off-by: John Stultz --- v2: Switch to suggested fix by Jarkko. --- drivers/i2c/busses/i2c

Re: [PATCH v4 1/4] i2c: designware: wait for disable/enable only if necessary

On 03/26/2017 10:44 PM, Andrey Utkin wrote: Regression reported: https://bugzilla.kernel.org/show_bug.cgi?id=194969 Thanks, I commented the bug. -- Jarkko

Re: [PATCH v4 1/4] i2c: designware: wait for disable/enable only if necessary

On 03/26/2017 10:44 PM, Andrey Utkin wrote: Regression reported: https://bugzilla.kernel.org/show_bug.cgi?id=194969 Thanks, I commented the bug. -- Jarkko

Re: [PATCH v1 0/8] gpio: acpi: Make it working

of available function, including GPIO input (interrupt). Current bad behaviour was first reported by Jarkko Nikula few months ago. It was actually due HW reset default is input buffer disabled and BIOS didn't touch that pin at all if I recall correctly. For the set: Tested-by: Jarkko Nikula <jarkko.

Re: [PATCH v1 0/8] gpio: acpi: Make it working

of available function, including GPIO input (interrupt). Current bad behaviour was first reported by Jarkko Nikula few months ago. It was actually due HW reset default is input buffer disabled and BIOS didn't touch that pin at all if I recall correctly. For the set: Tested-by: Jarkko Nikula

Re: [PATCH v7 5/6] i2c: designware: add SLAVE mode functions

On 03/20/17 13:10, Luis Oliveira wrote: - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support - Slave functions added to core library file - Slave abort sources added to common source file - New driver: i2c-designware-slave added - Changes in the Makefile to compile the

Re: [PATCH v7 5/6] i2c: designware: add SLAVE mode functions

On 03/20/17 13:10, Luis Oliveira wrote: - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support - Slave functions added to core library file - Slave abort sources added to common source file - New driver: i2c-designware-slave added - Changes in the Makefile to compile the

Re: [PATCH v7 4/6] i2c: designware: introducing I2C_SLAVE definitions

On 03/20/17 13:10, Luis Oliveira wrote: - Definitions were added to core library - A example was added to designware-core.txt Documentation that shows how the slave can be setup using DTS SLAVE related definitions were added to the core of the controller. Signed-off-by: Luis Oliveira

Re: [PATCH v7 4/6] i2c: designware: introducing I2C_SLAVE definitions

On 03/20/17 13:10, Luis Oliveira wrote: - Definitions were added to core library - A example was added to designware-core.txt Documentation that shows how the slave can be setup using DTS SLAVE related definitions were added to the core of the controller. Signed-off-by: Luis Oliveira

Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver

, 433 insertions(+), 369 deletions(-) create mode 100644 drivers/i2c/busses/i2c-designware-common.c rename drivers/i2c/busses/{i2c-designware-core.c => i2c-designware-master.c} (64%) Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver

2c/busses/i2c-designware-common.c rename drivers/i2c/busses/{i2c-designware-core.c => i2c-designware-master.c} (64%) Acked-by: Jarkko Nikula

Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver

On 03/20/17 13:10, Luis Oliveira wrote: - The functions related to I2C master mode of operation were transformed in a single driver. - Common definitions were moved to i2c-designware-core.h - The i2c-designware-core is now only a library file, the functions associated are in a source file

Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver

On 03/20/17 13:10, Luis Oliveira wrote: - The functions related to I2C master mode of operation were transformed in a single driver. - Common definitions were moved to i2c-designware-core.h - The i2c-designware-core is now only a library file, the functions associated are in a source file

Re: [PATCH v7 4/6] i2c: designware: introducing I2C_SLAVE definitions

e.h | 29 +- For the i2c-designware-core.h Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH v7 4/6] i2c: designware: introducing I2C_SLAVE definitions

Reviewed-by: Andy Shevchenko Acked-by: Rob Herring --- v6-v7 - no changes .../devicetree/bindings/i2c/i2c-designware.txt | 16 +++- drivers/i2c/busses/i2c-designware-core.h | 29 +- For the i2c-designware-core.h Acked-by: Jarkko Nikula

Re: [PATCH] ASoC: omap: constify snd_soc_ops structures

e working on Droid 4's sound support and > added this to my TODO list - stroking it off again now :) > > Reviewed-by: Sebastian Reichel <s...@kernel.org> > Acked-by: Jarkko Nikula <jarkko.nik...@bitmer.com>

Re: [PATCH] ASoC: omap: constify snd_soc_ops structures

rt and > added this to my TODO list - stroking it off again now :) > > Reviewed-by: Sebastian Reichel > Acked-by: Jarkko Nikula

Re: [RESEND PATCH v6 5/6] i2c: designware: add SLAVE mode functions

On 03/17/17 13:24, Luis Oliveira wrote: On 02-Mar-17 15:17, Luis Oliveira wrote: On 02-Mar-17 14:33, Jarkko Nikula wrote: On 03/01/17 17:59, Luis Oliveira wrote: - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support - Slave functions added to core library file - Slave abort sources

Re: [RESEND PATCH v6 5/6] i2c: designware: add SLAVE mode functions

On 03/17/17 13:24, Luis Oliveira wrote: On 02-Mar-17 15:17, Luis Oliveira wrote: On 02-Mar-17 14:33, Jarkko Nikula wrote: On 03/01/17 17:59, Luis Oliveira wrote: - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support - Slave functions added to core library file - Slave abort sources

<    1   2   3   4   5   >