Re: [PATCH] i386: Selectable Frequency of the Timer Interrupt

2005-07-23 Thread Jesper Juhl
On 7/24/05, randy_dunlap <[EMAIL PROTECTED]> wrote: > On Fri, 15 Jul 2005 05:46:44 +0200 Jesper Juhl wrote: > > > +static int __init jiffies_increment_setup(char *str) > > +{ > > + printk(KERN_NOTICE "setting up jiffies_increment : "); > > +

Re: Mouse Freezes in Xorg on ASUS P4C800 Deluxe

2005-07-23 Thread Jesper Juhl
t ACPI enabled (acpi=off or not) the /dev/input/mice USB > mouse freezes after not being used for some time and can only be > awakened by switching to the text-console and back. > What's the last kernel it works OK with? Why do you suspect this to be a kernel problem and not

Re: kernel guide to space

2005-07-22 Thread Jesper Juhl
On 7/22/05, Jesper Juhl <[EMAIL PROTECTED]> wrote: > On 7/21/05, Jesper Juhl <[EMAIL PROTECTED]> wrote: > > On 7/21/05, linux-os (Dick Johnson) <[EMAIL PROTECTED]> wrote: > > > > > > On Thu, 21 Jul 2005, Jesper Juhl wrote: > > > >

Re: kernel guide to space

2005-07-22 Thread Jesper Juhl
On 7/22/05, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Fri, Jul 22, 2005 at 12:12:12PM -0500, Patrick Draper wrote: > > Why isn't a code formatting program used? People could write the code > > as they like to write it, then format it automatically in a standard > > way before it gets put into th

Re: kernel guide to space

2005-07-22 Thread Jesper Juhl
roper patches... It should just be cleaned up by whoever submits it before it gets merged (and if you want to let a tool help you out some of the way, then noone's stopping you). -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plai

Re: kernel guide to space

2005-07-21 Thread Jesper Juhl
On 7/21/05, Jesper Juhl <[EMAIL PROTECTED]> wrote: > On 7/21/05, linux-os (Dick Johnson) <[EMAIL PROTECTED]> wrote: > > > > On Thu, 21 Jul 2005, Jesper Juhl wrote: > > > > > On 7/21/05, Kyle Moffett <[EMAIL PROTECTED]> wrote: > > >> On J

Re: kernel page size explanation

2005-07-21 Thread Jesper Juhl
look at /proc/cpuinfo or /proc/meminfo , IIRC some archs report page size there - not quite sure, can't remember... -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomim

Re: CIFS slowness & crashes

2005-07-21 Thread Jesper Juhl
t it be added to the CIFS MAINTAINERS entry as pr the patch below (also attached since gmail will probably mangle it). Add [EMAIL PROTECTED] to CIFS entry in MAINTAINERS Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- MAINTAINERS |1 + 1 files changed, 1 insertion(+) --- linux-2

Re: CIFS slowness & crashes

2005-07-21 Thread Jesper Juhl
On 7/21/05, Lasse Kärkkäinen / Tronic <[EMAIL PROTECTED]> wrote: > I mailed [EMAIL PROTECTED] (the guy who wrote the driver) about this a > month ago, but didn't get any reply. Is anyone working on that driver > anymore? > As far as I know Steve is still maintaining cifs. If you wrote him and didn

Re: kernel guide to space

2005-07-21 Thread Jesper Juhl
On 7/21/05, linux-os (Dick Johnson) <[EMAIL PROTECTED]> wrote: > > On Thu, 21 Jul 2005, Jesper Juhl wrote: > > > On 7/21/05, Kyle Moffett <[EMAIL PROTECTED]> wrote: > >> On Jul 20, 2005, at 20:45:21, Paul Jackson wrote: > > [...snip.

Re: kernel guide to space

2005-07-21 Thread Jesper Juhl
ctionNaming cleanup of the BusLogic driver, I'll send the patches to LKML in a few hours. -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscri

Re: 2.6.13-rc3 Battery times at 100/250/1000 Hz = Zero difference

2005-07-21 Thread Jesper Juhl
I'd suspect things would be different if the machine was actually doing some work. Would be more interresting to see how long it lasts with a light load and with a heavy load. -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Pla

Re: Linux Benchmarks

2005-07-20 Thread Jesper Juhl
On 7/20/05, Jesper Juhl <[EMAIL PROTECTED]> wrote: > On 7/20/05, eliad lubovsky <[EMAIL PROTECTED]> wrote: > > Where can I find common Linux benchmarks? I added some changes to system > > calls and want to check whether it cause any performance degradation. > >

Re: Linux Benchmarks

2005-07-20 Thread Jesper Juhl
no.com/benchmarks.html And there's plenty more to be found out there on the 'net if need be... -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.ht

Re: [-mm patch] SCSI_QLA2ABC options must select FW_LOADER

2005-07-20 Thread Jesper Juhl
gic ISP24xx host adapter family support" > depends on SCSI_QLA2XXX > -select SCSI_FC_ATTRS > + select SCSI_FC_ATTRS > + select FW_LOADER > ---help--- > This driver supports the QLogic 24xx (ISP2422 and ISP2432) host >

Re: kernel guide to space

2005-07-20 Thread Jesper Juhl
t; Dont use C99 // comments. > s/Dont/Don't/ > 9a. Integer types > int is the default integer type. > Use unsigned type if you perform bit operations (<<,>>,&,|,~). > Use unsigned long if you have to fit a pointer into integer.

[PATCH] clarify KALLSYMS_ALL help text

2005-07-19 Thread Jesper Juhl
Clarify the KALLSYMS_ALL help text slightly. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- init/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.13-rc3-mm1-orig/init/Kconfig 2005-07-17 04:40:00.0 +0200 +++ linux-2.6.13-rc3-mm1/init/K

[patch] QLogic SCSI driver Kconfig fixes

2005-07-19 Thread Jesper Juhl
7;t need it, and it adds a help text. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/Kconfig |6 +- 1 files changed, 5 insertions(+), 1 deletion(-) --- linux-2.6.13-rc3-mm1-orig/drivers/scsi/qla2xxx/Kconfig 2005-07-17 04:39:52.0 +0200 +++ linux

Re: Interbench real time benchmark results

2005-07-19 Thread Jesper Juhl
o was talking about. > If you want to generate a lot of network related interrupts, wouldn't a much simpler way to do that be a simple ping -f targetbox from a host connected to `targetbox' via a crosswired ethernet cable or a fast switch..? Also easy to modify the size of t

Re: how to be (SAFE) a kernel developer ?

2005-07-19 Thread Jesper Juhl
d CC: so it's possible to reply to the proper people, and don't trim the CC: list please. > Jesper Juhl wrote: ... > > much useful advice, almost all of which I agree with _BUT_ > > please do NOT debug kernel mods on your 'main-box', where your > filesystems

Re: repeated Oops on Kernel 2.6.12.2

2005-07-18 Thread Jesper Juhl
dule that spawns a kernel thread to perform a task on a group of packets. Perhaps you could provide the code for that module somewhere? Sorry I can't be of more help. -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain

Re: Fw: Oops in hidinput_hid_event

2005-07-18 Thread Jesper Juhl
On 7/19/05, Jesper Juhl <[EMAIL PROTECTED]> wrote: > On 7/18/05, Pete Zaitcev <[EMAIL PROTECTED]> wrote: > > I think this patch is rather obvious, so maybe I should ask Andrew to > > apply it to -mm for now, to get some testing. Would that help to verify > > i

Re: Fw: Oops in hidinput_hid_event

2005-07-18 Thread Jesper Juhl
gt; { > - struct input_dev *input = &field->hidinput->input; > + struct input_dev *input; > int *quirks = &hid->quirks; > > - if (!input) > + if (!field->hidinput) How about if (!field || !field->hdinput) inste

Re: how to be a kernel developer ?

2005-07-18 Thread Jesper Juhl
On 7/19/05, Jesper Juhl <[EMAIL PROTECTED]> wrote: > On 7/18/05, regatta <[EMAIL PROTECTED]> wrote: > > Hi > > > > I want to join the Kernel community and help in developing Linux > > kernel, I'm good in C,Perl and not that good in C++ > > >

Re: how to be a kernel developer ?

2005-07-18 Thread Jesper Juhl
esting them and learning from the mistakes you make is a great way to learn. -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list:

Re: 2.6.12.3 ompilation errors with linux1394.org rev.1315

2005-07-18 Thread Jesper Juhl
eze() used to take a single argument, it doesn't any more - looks like someone forgot to teach that to ieee1394_core.c. It seems to be fixed in 2.6.13-rc3 though, so try that one. -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.

Re: [PATCH] no more need to check for NULL before calls to crypto_free_tfm

2005-07-18 Thread Jesper Juhl
On 7/18/05, Herbert Xu <[EMAIL PROTECTED]> wrote: > On Sun, Jul 17, 2005 at 12:32:27AM +0200, Jesper Juhl wrote: > > > > --- linux-2.6.13-rc3-orig/drivers/block/cryptoloop.c 2005-06-17 > > 21:48:29.0 +0200 > > +++ linux-2.6.13-rc3/drivers/block/cryptol

[PATCH] add NULL short circuit to fb_dealloc_cmap()

2005-07-17 Thread Jesper Juhl
the place. - removes possible NULL pointer dereferences when a caller forgot to check. This patch makes fb_dealloc_cmap() safe to call with a NULL pointer argument. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- drivers/video/fbcmap.c |3 +++ 1 files changed, 3 inse

Re: [PATCH] fbdev: Update info->cmap when setting cmap from user-/kernelspace.

2005-07-17 Thread Jesper Juhl
> + return -EFAULT; > } > - > - for (i = 0; i < cmap->len; i++, red++, blue++, green++) { > - if (get_user(hred, red) || > - get_user(hgreen, green) || > - get_user(hblue, blue) || > -

[PATCH] make SPEAKUP_DEFAULT depend on SPEAKUP

2005-07-16 Thread Jesper Juhl
I have disabled speakup alltogether in the first place? The patch below makes SPEAKUP_DEFAULT depend on SPEAKUP. I believe that's the sane thing to do :) Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- drivers/char/speakup/Kconfig |1 + 1 files changed, 1 insertion(+) ---

Re: [PATCH] i386: Selectable Frequency of the Timer Interrupt

2005-07-16 Thread Jesper Juhl
On 7/15/05, Jesper Juhl <[EMAIL PROTECTED]> wrote: > On 7/15/05, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > > On Fri, 15 Jul 2005, Jesper Juhl wrote: > > > > > > It's buggy, that I know. setting kernel_hz (the new boot parameter) to > >

Re: NFS and fifos.

2005-07-16 Thread Jesper Juhl
On 7/16/05, Willy Tarreau <[EMAIL PROTECTED]> wrote: > On Sat, Jul 16, 2005 at 11:25:01PM +0530, Dhruv Matani wrote: > > On 7/16/05, Jesper Juhl <[EMAIL PROTECTED]> wrote: > > > On 7/16/05, Dhruv Matani <[EMAIL PROTECTED]> wrote: > > > > On

Re: NFS and fifos.

2005-07-16 Thread Jesper Juhl
but couldn't find any file abstraction for > communication for processes on distinct machines. Do you know of any > such thing, cause I couldn't find any. > sockets. -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-pos

Re: [PATCH] i386: Selectable Frequency of the Timer Interrupt

2005-07-15 Thread Jesper Juhl
On 7/15/05, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > On Fri, 15 Jul 2005, Jesper Juhl wrote: > > > > It's buggy, that I know. setting kernel_hz (the new boot parameter) to > > 250 causes my system clock to run at something like 4-5 times normal >

Re: [PATCH] Filesystem capabilities support

2005-07-14 Thread Jesper Juhl
mp;= caps.mask_permitted; > + cap_t(bprm->cap_permitted) |= caps.permitted; > + > + cap_t(bprm->cap_inheritable) &= caps.mask_inheritable; > + cap_t(bprm->cap_inheritable) |= caps.inheritable; > +

Re: [PATCH] i386: Selectable Frequency of the Timer Interrupt

2005-07-14 Thread Jesper Juhl
rig/kernel/timer.c linux-2.6.13-rc3/kernel/timer.c --- linux-2.6.13-rc3-orig/kernel/timer.c2005-07-14 20:34:24.0 +0200 +++ linux-2.6.13-rc3/kernel/timer.c 2005-07-15 02:55:45.0 +0200 @@ -948,7 +948,7 @@ static inline void update_times(void) void do_timer(struct pt_regs

Re: Why is 2.6.12.2 less stable on my laptop than 2.6.10?

2005-07-14 Thread Jesper Juhl
On 7/15/05, Chris Friesen <[EMAIL PROTECTED]> wrote: > Jesper Juhl wrote: > > > In my oppinion it would be nice if Linus/Andrew had some basic > > regression tests they could run on kernels before releasing them. > > How do you regression test behaviour on broken ha

Re: Why is 2.6.12.2 less stable on my laptop than 2.6.10?

2005-07-14 Thread Jesper Juhl
d then every time a bug was found that could resonably be tested for in the future it would be added to the regression test suite... That would lead to more consistent quality I believe. -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.ht

Re: [PATCH] i386: Selectable Frequency of the Timer Interrupt

2005-07-14 Thread Jesper Juhl
up > to be either 1000, 250, or 100, and then increment "jiffies" by 1, 4 or > 10. > [...] > > Really. I dare you guys. First one to send me a tested patch gets a gold > star. > Testing a patch right now, I'll send it to you as soon as it doesn&#x

Re: [PATCH] i386: Selectable Frequency of the Timer Interrupt

2005-07-14 Thread Jesper Juhl
On 7/15/05, Lee Revell <[EMAIL PROTECTED]> wrote: > On Fri, 2005-07-15 at 02:04 +0200, Jesper Juhl wrote: > > While reading this thread it occoured to me that perhaps what we > > really want (besides sub HZ timers) might be for the kernel to > > auto-tune HZ? >

Re: [PATCH] i386: Selectable Frequency of the Timer Interrupt

2005-07-14 Thread Jesper Juhl
t use the auto detection they can select a certain HZ in their .config instead of CONFIG_HZ_AUTO. Just wanted to throw the idea up in the air in case it made sense. Feel free to pick it apart or simply ignore it. :-) -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.

HDAPS I'll be out of it for a few days

2005-07-07 Thread Jesper Juhl
, comments, suggestions etc that people have send my way, but I won't be doing so for the next few days. I'm sorry, but things turned up that I had not expected - that's real life for you I guess... -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/ja

Re: PROBLEM: please remove reserved word "new" from kernel headers

2005-07-06 Thread Jesper Juhl
ut, if you really want it changed I suggest you create a patch and submit that for review/inclusion and see what feedback you get. -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expit

Re: IBM HDAPS things are looking up (was: Re: [Hdaps-devel] Re: [ltp] IBM HDAPS Someone interested? (Accelerometer))

2005-07-04 Thread Jesper Juhl
On 7/4/05, Pekka Enberg <[EMAIL PROTECTED]> wrote: > Hi Jesper, > > On 7/4/05, Jesper Juhl <[EMAIL PROTECTED]> wrote: > > static int > > ibm_hdaps_open(struct inode *inode, struct file *filp) > > { > > printk("%s() start\n", __func__);

Re: ide-cd? Can burn DVDs, just not read them...

2005-04-22 Thread Jesper Juhl
t that help text describes that personally I would give it a shot and see if it changes anything. -- Jesper Juhl - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/major

[PATCH] rename "---help---" to "help" in Kconfig files

2005-04-20 Thread Jesper Juhl
Ok, I'll admit right up front that this is probably slightly controversial, and most certainly slightly silly as well, and my reasons for doing this may not be the best in the world, but let me try and explain the reasons for this patch. What does it do? : It renames all instances of "---help-

Re: [PATCH] rename rw_verify_area() to rw_access_ok()

2005-04-20 Thread Jesper Juhl
On Wed, 20 Apr 2005, Marcelo Tosatti wrote: > On Sun, Apr 17, 2005 at 11:50:35PM +0200, Jesper Juhl wrote: > > verify_area() will soon be dead and gone, replaced by access_ok(), thus > > the function named rw_verify_area() is badly named and should be renamed. > &g

Re: NForce4 ide problems?

2005-04-20 Thread Jesper Juhl
to try /not/ loading that module and then reproduce the kernel panic and then post that Oops or panic message instead. -- Jesper Juhl - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

test of 'good_bytes' in scsi_io_completion is always true (in drivers/scsi/scsi_lib.c)

2005-04-19 Thread Jesper Juhl
gh to be sure. The patch below makes the change to test if it's > 0, but if the code in the 'if' really wants to run if it's >= 0, then we might as well just remove the 'if'. In any case, the current code looks fishy. Signed-off-by: Jesper Juhl <[EMAIL PRO

[PATCH] sound: trivial warning fix for emu10k1

2005-04-19 Thread Jesper Juhl
When building with gcc -W sound/pci/emu10k1/emupcm.c produces this little warning in 2.6.12-rc2-mm3 : sound/pci/emu10k1/emupcm.c:265: warning: `inline' is not at beginning of declaration No big deal, but trivial to fix. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- sound/

[PATCH 1/1] cifs: cleanups for cifs_unicode.c

2005-04-19 Thread Jesper Juhl
el_patches/fs_cifs-cifs_unicode-cleanup.patch Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> cifs_unicode.c | 42 ++ 1 files changed, 14 insertions(+), 28 deletions(-) --- linux-2.6.12-rc2-mm3-orig/fs/cifs/cifs_unicode.c2005-04-11 21:20:50

[PATCH 2/2] cifs: little cleanups for cifs_unicode.h - spaces

2005-04-19 Thread Jesper Juhl
Here's the second part for fs/cifs/cifs_unicode.h Fix spacing and remove pointless parenthesis from return. This patch is also available at : http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs-cifs_unicode-spacing.patch Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>

[PATCH 1/2] cifs: little cleanups for cifs_unicode.h - functions and comments

2005-04-19 Thread Jesper Juhl
-cifs_unicode-functions_and_comments.patch Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> fs/cifs/cifs_unicode.h | 185 + 1 files changed, 67 insertions(+), 118 deletions(-) --- linux-2.6.12-rc2-mm3-orig/fs/cifs/cifs_unicode.h2005-03-02

Re: [PATCH] sha512: replace open-coded be64 conversions

2005-04-19 Thread Jesper Juhl
On Tue, 19 Apr 2005, Denis Vlasenko wrote: > On Tuesday 19 April 2005 12:04, Jesper Juhl wrote: > > On Tue, 19 Apr 2005, Denis Vlasenko wrote: > > > > > This + next patch were "modprobe tcrypt" tested. > > > See next mail. > > > > Could y

Re: 2.6.12-rc2-mm3 regression - certain applications get SIGSEGV but are fine with 2.6.12-rc2-mm2

2005-04-19 Thread Jesper Juhl
On Tue, 19 Apr 2005, Alexander Nyberg wrote: > tis 2005-04-19 klockan 11:33 +0200 skrev Jesper Juhl: > > Everything is fine with 2.6.12-rc2, 2.6.12-rc2-mm1, 2.6.12-rc2-mm2 & > > earlier kernels as well, but 2.6.12-rc2-mm3 seems to have a problem. > > I don't know

Re: [PATCH] sha512: replace open-coded be64 conversions

2005-04-19 Thread Jesper Juhl
On Tue, 19 Apr 2005, Denis Vlasenko wrote: > This + next patch were "modprobe tcrypt" tested. > See next mail. Could you please send patches inline instead of as attachments. Attachments mean there's more work involved in getting at them to read them, and they are a pain when you want to reply

Re: [PATCH] crypto: resource release functions ought to check for NULL (crypto_free_tfm)

2005-04-19 Thread Jesper Juhl
On Tue, 19 Apr 2005, Herbert Xu wrote: > On Mon, Apr 18, 2005 at 05:23:31PM +0200, Jesper Juhl wrote: > > > > Next step is to then clean up the callers of crypto_free_tfm so they no > > longer do the redundant NULL check. Below is a patch to do that. > > Please wai

Re: [PATCH 1/2] new valid_signal function

2005-04-18 Thread Jesper Juhl
On Mon, 18 Apr 2005, Jesper Juhl wrote: > This patch adds a new function valid_signal() that tests if its argument > is a valid signal number. > > The reasons for adding this new function are: > - some code currently testing _NSIG directly has off-by-one errors. Using

[PATCH 2/2] new valid_signal function - convert code that currently tests _NSIG directly to use the new function instead

2005-04-18 Thread Jesper Juhl
The patch below converts most of the current code that uses _NSIG directly to instead use the valid_signal() function added by the previous patch. This avoids gcc -W warnings and off-by-one errors and it's also nice and readable, no doubt about what the code tests. Signed-off-by: Jesper

[PATCH 1/2] new valid_signal function

2005-04-18 Thread Jesper Juhl
7;s some reason this is a bad choice then please let me know (hints as to a better location are then welcome of course). A patch that converts most of the code that currently uses _NSIG directly to call this function instead is [PATCH 2/2] coming shortly.. Signed-off-by: Jesper Juhl <[EMAI

Re: [PATCH 1/7] procfs privacy: /proc/bus/pci

2005-04-18 Thread Jesper Juhl
On Mon, 18 Apr 2005, Lorenzo Hernández García-Hierro wrote: > This patch changes the permissions of the /proc/bus/pci directory entry, > so, non-root users are restricted of accessing it's content. > It's also available at: > http://pearls.tuxedo-es.org/patches/security/proc-privacy-1_drivers_pci_

Re: [PATCH] crypto: resource release functions ought to check for NULL (crypto_free_tfm)

2005-04-18 Thread Jesper Juhl
On Mon, 18 Apr 2005, Herbert Xu wrote: > On Fri, Apr 15, 2005 at 01:15:58AM +0200, Jesper Juhl wrote: > > > > As far as I'm aware there's a general concensus that functions that are > > responsible for freeing resources should be able to cope with being passed

[PATCH] misc verify_area cleanups - last one, I promise ;)

2005-04-18 Thread Jesper Juhl
ld not be anything left but finally removing verify_area completely, which will happen after a kernel release or two. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- linux-2.6.12-rc2-mm3-orig/./arch/i386/kernel/vm86.c 2005-04-11 21:20:38.0 +0200 +++ linux-2.6.12-rc2-mm3/./arch/i386

Re: Need some help to debug a freeze on 2.6.11

2005-04-18 Thread Jesper Juhl
On Mon, 18 Apr 2005, Jesper Juhl wrote: > On Mon, 18 Apr 2005, Alexander Nyberg wrote: > > > > I'm running Linux on my laptop and it sometimes freezes (about once a > > > week). The only thing which seems to work when it's stuck is SysRq (I > > > can re

Re: Need some help to debug a freeze on 2.6.11

2005-04-18 Thread Jesper Juhl
On Mon, 18 Apr 2005, Alexander Nyberg wrote: > > I'm running Linux on my laptop and it sometimes freezes (about once a > > week). The only thing which seems to work when it's stuck is SysRq (I > > can reboot with SysRq+O), however, I'm in X and I don't have a serial > > port on my laptop so I can'

Re: Kernelpanic - not syncing: VFS: Unable to mount root fs on unknown-block

2005-04-18 Thread Jesper Juhl
wrong. > Perhaps you forgot to build in support for your SCSI controller? That could explain it. Or maybe you forgot to include support for the filesystem used on the / partition? That could also explain it. -- Jesper Juhl - To unsubscribe from this list: send the line "unsubscrib

[PATCH] rename rw_verify_area() to rw_access_ok()

2005-04-17 Thread Jesper Juhl
to it in comments). Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- arch/mips/kernel/linux32.c |4 ++-- fs/compat.c|2 +- fs/locks.c |2 +- fs/read_write.c| 12 ++-- include/linux/fs.h |2 +- 5 files chang

[PATCH] rename TEST_VERIFY_AREA to TEST_ACCESS_OK

2005-04-17 Thread Jesper Juhl
. Is this intended as a debug thing to be set by hand if needed or is it just some old debug stuff that no longer serves a real purpose? I guess my real question is "should these actually just be removed along with the code they wrap instead of just being renamed?" Signed-off-by: Jesp

Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero

2005-04-17 Thread Jesper Juhl
g) && sig > 0) any preference? Personally I would probably go with the 'rewrite as if (valid_signal(sig) && sig > 0)' one to encourage use of the new valid_signal() function and make usage consistent. -- Jesper Juhl - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] drivers/macintosh: Remove redundant NULL check before kfree

2005-04-16 Thread Jesper Juhl
This patch removes a redundant NULL check before kfree() - kfree handles NULL pointers just fine so there's no need to check first. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- drivers/macintosh/adbhid.c |3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) --- linux

[PATCH] ieee1394: remove NULL checks prior to kfree in ieee1394, kfree handles null pointers fine.

2005-04-16 Thread Jesper Juhl
This patch removes redundant NULL pointer checks before kfree() in all of drivers/ieee1394/ Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- drivers/ieee1394/nodemgr.c |3 +-- drivers/ieee1394/ohci1394.c |2 +- drivers/ieee1394/video1394.c | 29 --

Re: [PATCH] sched: fix never executed code due to expression always false

2005-04-16 Thread Jesper Juhl
On Fri, 15 Apr 2005, Ingo Molnar wrote: > > * Jesper Juhl <[EMAIL PROTECTED]> wrote: > > > As per this patch perhaps? : > > > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > > this is still not enough (there was one more comparison to cover).

Re: [PATCH] reiserfs: fix a few 'empty body in an if-statement' warnings.

2005-04-15 Thread Jesper Juhl
On Thu, 14 Apr 2005, Randy.Dunlap wrote: > On Fri, 15 Apr 2005 02:58:54 +0200 (CEST) Jesper Juhl wrote: > > | When building with gcc -W fs/reiserfs/namei.c:602 has a few warnings > | about 'empty body in an if-statement'. This patch silences those warnings. >

Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero

2005-04-15 Thread Jesper Juhl
On Fri, 15 Apr 2005, Matthew Wilcox wrote: > On Fri, Apr 15, 2005 at 03:07:42AM +0200, Jesper Juhl wrote: > > 'arg' is unsigned so it can never be less than zero, so testing for that > > is pointless and also generates a warning when building with gcc -W. This > >

[PATCH] fs/fcntl.c : don't test unsigned value for less than zero

2005-04-14 Thread Jesper Juhl
'arg' is unsigned so it can never be less than zero, so testing for that is pointless and also generates a warning when building with gcc -W. This patch eliminates the pointless check. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- linux-2.6.12-rc2-mm3-orig/fs/fcntl.c

[PATCH] reiserfs: fix a few 'empty body in an if-statement' warnings.

2005-04-14 Thread Jesper Juhl
When building with gcc -W fs/reiserfs/namei.c:602 has a few warnings about 'empty body in an if-statement'. This patch silences those warnings. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- linux-2.6.12-rc2-mm3-orig/fs/reiserfs/namei.c 2005-04-11 21:20:55.0

Re: ALSA Oops (triggered by xmms)

2005-04-14 Thread Jesper Juhl
On Fri, 15 Apr 2005, Christian Kujau wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Jesper Juhl wrote: > > > > ^ you should send such info inline in the email - having to go check > > external links makes a lot of people ignore the stuff righ

Re: [PATCH] sched: fix never executed code due to expression always false

2005-04-14 Thread Jesper Juhl
On Fri, 15 Apr 2005, Nick Piggin wrote: > Jesper Juhl wrote: > > On Fri, 15 Apr 2005, Nick Piggin wrote: > > > > > > > Jesper Juhl wrote: > > > > > > > There are two expressions in kernel/sched.c that are always false since > > > &g

Re: [PATCH] sched: fix never executed code due to expression always false

2005-04-14 Thread Jesper Juhl
On Fri, 15 Apr 2005, Nick Piggin wrote: > Jesper Juhl wrote: > > There are two expressions in kernel/sched.c that are always false since they > > test for <0 but the result of the expression is unsigned so they will never > > be less than zero. This patch implement the

Re: IBM Thinkpad T42 - Looking for a Developer.

2005-04-14 Thread Jesper Juhl
On Fri, 15 Apr 2005, Matti Aarnio wrote: > Could you show what/sbin/lsusb -vvtells in your T42 ? > Do that without external devices attached. Here's /sbin/lsusb -vv output from my Thinkpad T42 Type: 2373-F2G : Bus 004 Device 002: ID 0483:2016 SGS Thomson Microelectronics Device De

[PATCH] sched: fix never executed code due to expression always false

2005-04-14 Thread Jesper Juhl
tch is compile tested only Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- sched.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) --- linux-2.6.12-rc2-mm3-orig/kernel/sched.c2005-04-11 21:20:56.0 +0200 +++ linux-2.6.12-rc2-mm3/kernel/sched.c 2005-04

[PATCH] crypto: resource release functions ought to check for NULL (crypto_free_tfm)

2005-04-14 Thread Jesper Juhl
from the callers. Please consider applying. Please CC: me on replies as I'm not subscribed to linux-crypto Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- api.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) --- linux-2.6.12-rc2-mm3-orig/crypto/api.c

RE: IBM Thinkpad T42 - Looking for a Developer.

2005-04-14 Thread Jesper Juhl
On Thu, 14 Apr 2005, Alejandro Bonilla wrote: > > Jesper, > > Believe me that I would be more happy to have this working... :) > I've got a weeks vacation comming up next week - seems like a good time to play with this :) > This is located in my home PC, Won't be the fastest downlo

Re: IBM Thinkpad T42 - Looking for a Developer.

2005-04-14 Thread Jesper Juhl
boot it cause it > locked up. > I have a ThinkPad T42 and would be interrested in those docs. If you are allowed to distribute those documents then please make them available somewhere and reply back with the URL. -- Jesper Juhl - To unsubscribe from this list: send the line "u

[PATCH] usb: kfree cleanup for drivers/usb/* - no need to check for NULL

2005-04-12 Thread Jesper Juhl
Get rid of a bunch of redundant NULL pointer checks in drivers/usb/*, there's no need to check a pointer for NULL before calling kfree() on it. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- class/audio.c | 48 +++--- clas

Re: bkbits.net is down

2005-04-12 Thread Jesper Juhl
ct, not childish BS like the above. -- Jesper Juhl - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] usb: kfree() cleanups in drivers/usb/core/devio.c

2005-04-12 Thread Jesper Juhl
On Tue, 12 Apr 2005, Greg KH wrote: > Date: Tue, 12 Apr 2005 00:40:56 -0700 > From: Greg KH <[EMAIL PROTECTED]> > To: Jesper Juhl <[EMAIL PROTECTED]> > Cc: linux-kernel@vger.kernel.org, Thomas Sailer <[EMAIL PROTECTED]>, > Greg Kroah-Hartman <[E

Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-12 Thread Jesper Juhl
On Mon, 11 Apr 2005, Matt Mackall wrote: > Date: Mon, 11 Apr 2005 23:37:45 -0700 > From: Matt Mackall <[EMAIL PROTECTED]> > To: Jesper Juhl <[EMAIL PROTECTED]> > Cc: Steven French <[EMAIL PROTECTED]>, Steve French <[EMAIL PROTECTED]>, > linux-kernel@vg

[PATCH] usb: kfree() cleanups in drivers/usb/core/devio.c

2005-04-11 Thread Jesper Juhl
Checking for NULL before calling kfree() is redundant. This patch removes these redundant checks and also makes a few tiny whitespace changes. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- devio.c | 32 1 files changed, 12 insertions(+), 20 del

[PATCH] net: remove redundant NULL pointer checks prior to kfree in drivers/net/slip.c

2005-04-11 Thread Jesper Juhl
kfree() checks for NULL. Checking prior to calling it is redundant. This patch removes these redundant checks from drivers/net/slip.c Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- slip.c | 30 -- 1 files changed, 12 insertions(+), 18 deletions(-) ---

[PATCH] parisc: kfree cleanup in arch/parisc/

2005-04-11 Thread Jesper Juhl
Get rid of redundant NULL pointer checks before kfree() in arch/parisc/ as well as a few blank lines. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> diff -upr linux-2.6.12-rc2-mm3-orig/arch/parisc/kernel/ioctl32.c linux-2.6.12-rc2-mm3/arch/parisc/kernel/ioctl32.c --- linux-2.6.12-rc2-mm

[PATCH] redundant NULL checks before kfree should go away...

2005-04-11 Thread Jesper Juhl
(keeping me on CC when replying will be appreciated, thanks) kfree() checks for NULL pointers. Checking prior to calling it is reundant. This patch removes such redundant checks from arch/ppc64/ Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> diff -upr linux-2.6.12-rc2-mm3-orig/arch

[PATCH 3/3] cifs: md5 cleanup - comments

2005-04-11 Thread Jesper Juhl
clean up comments and make them conform to the style used in other cifs files. this patch can also be fetched from: http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_md5-comments.patch Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- linux-2.6.12-rc2-mm2/fs/cifs/md5.c.with_

[PATCH 2/3] cifs: md5 cleanup - spaces

2005-04-11 Thread Jesper Juhl
clean up spacing, redundant blank lines etc. patch is also at: http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_md5-spaces.patch Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- linux-2.6.12-rc2-mm2/fs/cifs/md5.c.with_patch1 2005-04-09 10:36:44.0 +0200 +++

[PATCH 1/3] cifs: md5 cleanup - functions

2005-04-11 Thread Jesper Juhl
Function names and return types on same line - conform to established fs/cifs/ style. Patch is also available at: http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_md5-funct.patch Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- linux-2.6.12-rc2-mm2-orig/fs/cifs/md5.c 2

[PATCH 1/1] cifs: md5 header cleanup

2005-04-11 Thread Jesper Juhl
Conform to style of other fs/cifs/ files Patch is also available from this URL: http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_md5-header.patch Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- linux-2.6.12-rc2-mm2-orig/fs/cifs/md5.h 2005-03-02 08:37:47.0

[PATCH 2/2] cifs: md4 cleanup - long lines and spaces

2005-04-11 Thread Jesper Juhl
Remove blank line, break long lines and line up two lines. Patch is also available here: http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_md4-lines-and-spaces.patch Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- linux-2.6.12-rc2-mm2/fs/cifs/md4.c.with_patch1 2005

[PATCH 1/2] cifs: md4 cleanup - function definitions

2005-04-11 Thread Jesper Juhl
Function names on same line as return type. Patch is also available here: http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_md4-funct.patch Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- linux-2.6.12-rc2-mm2-orig/fs/cifs/md4.c 2005-04-05 21:21:42.0

[PATCH] s390: drop redundant NULL pointer checks before kfree()

2005-04-11 Thread Jesper Juhl
(please keep me on CC when replying) Checking for NULL before calling kfree() on a pointer is redundant. This patch drops such checks from arch/s390/ Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- extmem.c |8 1 files changed, 4 insertions(+), 4 deletions(-) dif

Re: no need to check for NULL before calling kfree() -fs/ext2/

2005-04-08 Thread Jesper Juhl
On Wed, 30 Mar 2005, Jesper Juhl wrote: > On Tue, 29 Mar 2005, Paul Jackson wrote: > > > Pekka wrote: > > > (4) The cleanups Jesper and others are doing are to remove the > > > _redundant_ NULL checks (i.e. it is now checked twice). > > > > Even

<    4   5   6   7   8   9   10   11   12   >