Re: [PATCH] svc: add missed destroy_workqueue when gb_svc_create fails

2020-07-25 Thread Johan Hovold
On Sat, Jul 25, 2020 at 11:06:37AM +0800, Li Heng wrote: > destroy_workqueue() should be called to destroy svc->wq > when gb_svc_create() init resources fails. > > Fixes: 8465def499c7 ("staging: greybus: move the greybus core to > drivers/greybus") > Reported-by: Hulk Robot > Signed-off-by: Li H

Re: [PATCH for v5.9] USB: serial: Replace HTTP links with HTTPS ones

2020-07-24 Thread Johan Hovold
On Sun, Jul 19, 2020 at 06:19:20PM +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn

Re: drivers/tty/serial/pmac_zilog.c:255:36: sparse: sparse: context imbalance in 'pmz_receive_chars' - unexpected unlock

2020-07-23 Thread Johan Hovold
On Thu, Jul 23, 2020 at 03:26:54PM +0300, Andy Shevchenko wrote: > On Thu, Jul 23, 2020 at 3:19 PM Johan Hovold wrote: > > > > On Thu, Jul 23, 2020 at 05:29:14PM +0800, kernel test robot wrote: > > > tree: > > > https://git.kernel.org/pub/scm/linux/ker

[PATCH v2 0/2] serial: add sparse context annotation

2020-07-23 Thread Johan Hovold
expression even if sparse doesn't seem to care (add the missing ampersand) Johan Hovold (2): serial: pmac_zilog: add sparse context annotation serial: msm_serial: add sparse context annotation drivers/tty/serial/msm_serial.c | 2 ++ drivers/tty/serial/pmac_zilog.c | 1 + 2 files change

[PATCH v2 2/2] serial: msm_serial: add sparse context annotation

2020-07-23 Thread Johan Hovold
l.c:814:28: warning: context imbalance in 'msm_handle_rx' - unexpected unlock Signed-off-by: Johan Hovold --- drivers/tty/serial/msm_serial.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 60a9c53fa7cb..87f00

[PATCH v2 1/2] serial: pmac_zilog: add sparse context annotation

2020-07-23 Thread Johan Hovold
Signed-off-by: Johan Hovold --- drivers/tty/serial/pmac_zilog.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c index ba65a3bbd72a..96e7aa479961 100644 --- a/drivers/tty/serial/pmac_zilog.c +++ b/drivers/tty/serial/pmac_zilog.c

Re: drivers/tty/serial/pmac_zilog.c:255:36: sparse: sparse: context imbalance in 'pmz_receive_chars' - unexpected unlock

2020-07-23 Thread Johan Hovold
On Thu, Jul 23, 2020 at 05:29:14PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: d15be546031cf65a0fc34879beca02fd90fe7ac7 > commit: 08d5470308ac3598e7709d08b8979ce6e9de8da2 serial: core: fix sysrq > overhead regress

[PATCH 0/2] serial: add sparse context annotation

2020-07-23 Thread Johan Hovold
The Intel test robot reported a new sparse warning in pmac_zilog, which wasn't actually new. Add sparse annotation to the two drivers that release and reacquire the port lock in their receive handlers to suppress these warnings. Johan Johan Hovold (2): serial: pmac_zilog: add sparse co

[PATCH 2/2] serial: msm_serial: add sparse context annotation

2020-07-23 Thread Johan Hovold
l.c:814:28: warning: context imbalance in 'msm_handle_rx' - unexpected unlock Signed-off-by: Johan Hovold --- drivers/tty/serial/msm_serial.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 60a9c53fa7cb..7f26c

[PATCH 1/2] serial: pmac_zilog: add sparse context annotation

2020-07-23 Thread Johan Hovold
Signed-off-by: Johan Hovold --- drivers/tty/serial/pmac_zilog.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c index ba65a3bbd72a..b0d8f4a6f9b4 100644 --- a/drivers/tty/serial/pmac_zilog.c +++ b/drivers/tty/serial/pmac_zilog.c

Re: [PATCH 4.19 094/133] USB: serial: iuu_phoenix: fix memory corruption

2020-07-22 Thread Johan Hovold
On Wed, Jul 22, 2020 at 12:52:47PM +0200, Pavel Machek wrote: > > > Ok, so... goto and label is unneccessary, memcpy will do the right > > > thing with count == 0. > > > > That's generally too subtle. Better to clearly mark the error/exception > > path. > > We usually avoid subtle code by introd

Re: [PATCH] USB: serial: qcserial: add EM7305 QDL product ID

2020-07-22 Thread Johan Hovold
On Tue, Jul 21, 2020 at 08:15:04PM +0200, Erik Ekman wrote: > On Tue, 21 Jul 2020 at 09:23, Johan Hovold wrote: > > Would you mind posting the output of "usb-devices" (or "lsusb -v") for > > this device for completeness? > from usb-devices: > > T: B

Re: [PATCH v7 3/3] leds: trigger: implement a tty trigger

2020-07-22 Thread Johan Hovold
On Tue, Jul 21, 2020 at 09:48:15PM +0200, Uwe Kleine-König wrote: > Hello Johan, > > On Tue, Jul 14, 2020 at 09:13:55AM +0200, Johan Hovold wrote: > > On Tue, Jul 07, 2020 at 06:59:58PM +0200, Uwe Kleine-König wrote: > > > + while (firstrun || > > > +

Re: [PATCH 4.19 094/133] USB: serial: iuu_phoenix: fix memory corruption

2020-07-21 Thread Johan Hovold
On Tue, Jul 21, 2020 at 01:33:00PM +0200, Pavel Machek wrote: > Hi! > > > commit e7b931bee739e8a77ae216e613d3b99342b6dec0 upstream. > > > > The driver would happily overwrite its write buffer with user data in > > 256 byte increments due to a removed buffer-space sanity check. > > > +++ b/driver

Re: [PATCH] USB: serial: qcserial: add EM7305 QDL product ID

2020-07-21 Thread Johan Hovold
On Fri, Jul 17, 2020 at 08:51:18PM +0200, Erik Ekman wrote: > When running qmi-firmware-update on the Sierra Wireless EM7305 in a Toshiba > laptop, it changed product ID to 0x9062 when entering QDL mode: > > usb 2-4: new high-speed USB device number 78 using xhci_hcd > usb 2-4: New USB device foun

Re: [PATCH] USB: serial: sierra: clean up special-interface handling

2020-07-14 Thread Johan Hovold
On Mon, Jul 13, 2020 at 05:51:27PM +0200, Greg Kroah-Hartman wrote: > On Mon, Jul 13, 2020 at 05:39:36PM +0200, Johan Hovold wrote: > > Clean up the handling of special interfaces that either should be > > ignored or that need a larger number of URBs. > > > > Commit

Re: [PATCH v7 3/3] leds: trigger: implement a tty trigger

2020-07-14 Thread Johan Hovold
On Tue, Jul 07, 2020 at 06:59:58PM +0200, Uwe Kleine-König wrote: > Usage is as follows: > > myled=ledname > tty=ttyS0 > > echo tty > /sys/class/leds/$myled/trigger > echo $tty > /sys/class/leds/$myled/ttyname > > . When this new trigger is active it periodically checks t

[PATCH] USB: serial: sierra: clean up special-interface handling

2020-07-13 Thread Johan Hovold
ch made it even harder to understand what the interface lists were used for. Rename the interface-list struct, its members and the interface-lookup helper and restructure the code somewhat in order to make it more self-explanatory. Signed-off-by: Johan Hovold --- drivers/usb/serial/sie

[PATCH 0/2] serial: tegra: fix CREAD handling for PIO

2020-07-10 Thread Johan Hovold
Stumbled over these two; compile-tested only. Johan Johan Hovold (2): serial: tegra: fix CREAD handling for PIO serial: tegra: drop bogus NULL tty-port checks drivers/tty/serial/serial-tegra.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) -- 2.26.2

[PATCH 1/2] serial: tegra: fix CREAD handling for PIO

2020-07-10 Thread Johan Hovold
and will be removed by a follow-on patch. Fixes: 33ae787b74fc ("serial: tegra: add support to ignore read") Cc: stable # 5.4 Cc: Shardar Shariff Md Cc: Krishna Yarlagadda Signed-off-by: Johan Hovold --- drivers/tty/serial/serial-tegra.c | 7 +-- 1 file changed, 5 insertions(

[PATCH 2/2] serial: tegra: drop bogus NULL tty-port checks

2020-07-10 Thread Johan Hovold
to using struct tty_port") Signed-off-by: Johan Hovold --- drivers/tty/serial/serial-tegra.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c index b3bbee6b6702..04d1b0807e66 100644 ---

Re: [PATCH] USB: serial: Use fallthrough pseudo-keyword

2020-07-08 Thread Johan Hovold
On Tue, Jul 07, 2020 at 02:57:47PM -0500, Gustavo A. R. Silva wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/h

Re: [PATCH] USB: serial: option: add Quectel EG95 LTE modem

2020-07-07 Thread Johan Hovold
On Tue, Jul 07, 2020 at 04:15:53PM +0800, AceLan Kao wrote: > Add support for Quectel Wireless Solutions Co., Ltd. EG95 LTE modem > > T: Bus=01 Lev=01 Prnt=01 Port=02 Cnt=02 Dev#= 5 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=2c7c ProdID=0195 Rev=0

Re: [PATCH v3 2/2] USB: serial: cp210x: Proper RTS control when buffers fill

2020-07-06 Thread Johan Hovold
On Fri, Jun 26, 2020 at 09:42:06AM +0200, Johan Hovold wrote: > On Fri, Jun 26, 2020 at 04:24:20AM +, Phu Luu wrote: > > From: Brant Merryman > > > > CP210x hardware disables auto-RTS but leaves auto-CTS when > > in hardware flow control mode and UART on cp210x har

Re: [RESEND PATCH v4 1/3] usb: serial: Add MaxLinear/Exar USB to Serial driver

2020-07-01 Thread Johan Hovold
On Sun, Jun 07, 2020 at 09:53:48PM +0530, Manivannan Sadhasivam wrote: > Add support for MaxLinear/Exar USB to Serial converters. This driver > only supports XR21V141X series but it can be extended to other series > from Exar as well in future. > > This driver is inspired from the initial one subm

Re: [RESEND PATCH v4 2/3] usb: serial: xr_serial: Add gpiochip support

2020-07-01 Thread Johan Hovold
On Sun, Jun 07, 2020 at 09:53:49PM +0530, Manivannan Sadhasivam wrote: > Add gpiochip support for Maxlinear/Exar USB to serial converter > for controlling the available gpios. > > Inspired from cp210x usb to serial converter driver. > > Cc: Linus Walleij > Cc: linux-g...@vger.kernel.org > Review

Re: [RESEND PATCH v4 1/3] usb: serial: Add MaxLinear/Exar USB to Serial driver

2020-07-01 Thread Johan Hovold
On Sun, Jun 07, 2020 at 09:53:48PM +0530, Manivannan Sadhasivam wrote: > Add support for MaxLinear/Exar USB to Serial converters. This driver > only supports XR21V141X series but it can be extended to other series > from Exar as well in future. > > This driver is inspired from the initial one subm

Re: [PATCH v4 0/3] Add support for MaxLinear/Exar USB to serial converters

2020-07-01 Thread Johan Hovold
On Fri, Jun 26, 2020 at 08:01:36PM +0530, Manivannan Sadhasivam wrote: > On Sun, Jun 07, 2020 at 09:38:06PM +0530, Manivannan Sadhasivam wrote: > > Hello, > > > > This series adds support for MaxLinear/Exar USB to serial converters. > > This driver only supports XR21V141X series but it can easily

[PATCH] mfd: lm3533: expand control-bank accessors

2020-06-30 Thread Johan Hovold
m3533_ctrlbank_set' 125 | lm3533_ctrlbank_set(brightness, BRIGHTNESS); | ^~~ Signed-off-by: Johan Hovold --- drivers/mfd/lm3533-ctrlbank.c | 94 +-- 1 file changed, 56 insertions(+), 38 deletions(-) diff --git a/drivers/mfd/lm3533-c

Re: [PATCH 2/5] mfd: lm3533-ctrlbank: Cap BRIGHTNESS_MAX to 127 since API uses u8 as carrier

2020-06-30 Thread Johan Hovold
On Mon, Jun 29, 2020 at 02:25:06PM +0100, Lee Jones wrote: > On Mon, 29 Jun 2020, Johan Hovold wrote: > > > On Mon, Jun 29, 2020 at 01:32:12PM +0100, Lee Jones wrote: > > > Since its conception in 2012 brightness has been artificially capped > > > at 127 since the

Re: [PATCH 2/5] mfd: lm3533-ctrlbank: Cap BRIGHTNESS_MAX to 127 since API uses u8 as carrier

2020-06-29 Thread Johan Hovold
e the max value coincides with U8_MAX so that the sanity check becomes redundant. > Cc: Johan Hovold > Signed-off-by: Lee Jones > --- > drivers/mfd/lm3533-ctrlbank.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/lm3533-ctrlbank.c b/driv

Re: [PATCH 4/5] mfd: sprd-sc27xx-spi: Fix divide by zero when allocating register offset/mask

2020-06-29 Thread Johan Hovold
On Mon, Jun 29, 2020 at 01:32:14PM +0100, Lee Jones wrote: > Since ddata->irqs[] is already zeroed when allocated by devm_kcalloc() and > dividing 0 by anything is still 0, there is no need to re-assign > ddata->irqs[i].* values. Instead, it should be safe to begin at 1. > > This fixes the follow

Re: [PATCH 4/5] mfd: sprd-sc27xx-spi: Fix divide by zero when allocating register offset/mask

2020-06-29 Thread Johan Hovold
On Mon, Jun 29, 2020 at 10:35:06PM +0800, Baolin Wang wrote: > On Mon, Jun 29, 2020 at 10:01 PM Lee Jones wrote: > > > > On Mon, 29 Jun 2020, Johan Hovold wrote: > > > > > On Mon, Jun 29, 2020 at 01:32:14PM +0100, Lee Jones wrote: > > > > Since ddata-&

Re: [PATCH v3 2/2] USB: serial: cp210x: Proper RTS control when buffers fill

2020-06-26 Thread Johan Hovold
nto the port. When re-opening the port, if > auto-CTS is enabled on the cp210x, then auto-RTS must be > re-enabled in the driver. > > Signed-off-by: Phu Luu > Signed-off-by: Brant Merryman Please revisit these tags as well. > --- > 06/09/2020: Patch v3 2/2 Modified based on

Re: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle

2020-06-26 Thread Johan Hovold
On Fri, Jun 26, 2020 at 04:22:58AM +, Phu Luu wrote: > From: Brant Merryman > > Assign the .throttle and .unthrottle functions to be generic function > in the driver structure to prevent data loss that can otherwise occur > if the host does not enable USB throttling. > > Signed-off-by: Phu L

Re: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle

2020-06-24 Thread Johan Hovold
On Wed, Jun 24, 2020 at 07:01:33AM +, Phu Luu wrote: > Assign the .throttle and .unthrottle functions to be generic function > in the driver structure to prevent data loss that can otherwise occur > if the host does not enable USB throttling. > > Signed-off-by: Phu Luu > Signed-off-by: Brant

Re: [PATCH v2] USB: Serial: cypress_M8: Enable Simply Automated UPB PIM

2020-06-23 Thread Johan Hovold
On Tue, Jun 23, 2020 at 02:08:57AM -0600, James Hilliard wrote: > On Tue, Jun 23, 2020 at 1:53 AM Johan Hovold wrote: > > Don't you need to add this device to the HID driver's ignore list > > to prevent it from claiming the device (see hid_ignore_list) just like > &

Re: [PATCH v2] USB: Serial: cypress_M8: Enable Simply Automated UPB PIM

2020-06-23 Thread Johan Hovold
On Mon, Jun 22, 2020 at 11:09:51AM -0600, James Hilliard wrote: > On Mon, Jun 22, 2020 at 2:53 AM Johan Hovold wrote: > > > > On Tue, Jun 16, 2020 at 04:04:03PM -0600, James Hilliard wrote: > > > This is a UPB(Universal Powerline Bus) PIM(Powerline Interface Module

Re: [PATCH v2] USB: Serial: cypress_M8: Enable Simply Automated UPB PIM

2020-06-23 Thread Johan Hovold
On Mon, Jun 22, 2020 at 11:04:09AM -0600, James Hilliard wrote: > On Mon, Jun 22, 2020 at 2:53 AM Johan Hovold wrote: > > > > On Tue, Jun 16, 2020 at 04:04:03PM -0600, James Hilliard wrote: > > > This is a UPB(Universal Powerline Bus) PIM(Powerline Interface Module

Re: [PATCH v2] USB: Serial: cypress_M8: Enable Simply Automated UPB PIM

2020-06-22 Thread Johan Hovold
On Tue, Jun 16, 2020 at 04:04:03PM -0600, James Hilliard wrote: > This is a UPB(Universal Powerline Bus) PIM(Powerline Interface Module) > which allows for controlling multiple UPB compatible devices from > Linux using the standard serial interface. > > Based on vendor application source code ther

Re: [PATCH v2 0/3] serial: core: fix up sysrq regressions

2020-06-12 Thread Johan Hovold
On Wed, Jun 10, 2020 at 07:21:34PM +0300, Andy Shevchenko wrote: > On Wed, Jun 10, 2020 at 05:22:29PM +0200, Johan Hovold wrote: > > This series fixes a few regressions introduced by the recent sysrq > > rework that went into 5.6. > > > > The fix for the unneces

Re: [PATCH v2 2/3] serial: core: fix sysrq overhead regression

2020-06-12 Thread Johan Hovold
On Wed, Jun 10, 2020 at 05:24:57PM +0100, Dmitry Safonov wrote: > Hi Johan, > > On 6/10/20 4:22 PM, Johan Hovold wrote: > > Commit 8e20fc391711 ("serial_core: Move sysrq functions from header > > file") converted the inline sysrq helpers to exported functions whi

Re: [PATCH] serial: core: drop unnecessary gpio include

2020-06-11 Thread Johan Hovold
On Thu, Jun 11, 2020 at 10:25:30AM +0200, Lukas Wunner wrote: > [cc += Heiko] > > On Wed, Jun 10, 2020 at 05:51:21PM +0200, Johan Hovold wrote: > > Drop the recently added gpio include from the serial-core header in > > favour of a forward declaration and instead include

[PATCH] serial: core: drop unnecessary gpio include

2020-06-10 Thread Johan Hovold
Drop the recently added gpio include from the serial-core header in favour of a forward declaration and instead include the gpio header only where needed. Signed-off-by: Johan Hovold --- drivers/tty/serial/8250/8250_port.c | 1 + drivers/tty/serial/serial_core.c| 1 + include/linux

[PATCH v2 1/3] Revert "serial: core: Refactor uart_unlock_and_check_sysrq()"

2020-06-10 Thread Johan Hovold
Note that the __releases() attribute won't be needed after the follow-on fix either. Signed-off-by: Johan Hovold --- drivers/tty/serial/serial_core.c | 23 +-- include/linux/serial_core.h | 3 ++- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/d

[PATCH v2 3/3] serial: core: drop redundant sysrq checks

2020-06-10 Thread Johan Hovold
The sysrq timestamp will never be set unless port->has_sysrq is set (see uart_handle_break()) so drop the redundant checks that were added by commit 1997e9dfdc84 ("serial_core: Un-ifdef sysrq SUPPORT_SYSRQ"). Signed-off-by: Johan Hovold --- include/linux/serial_core.h | 4 ++-- 1

[PATCH v2 2/3] serial: core: fix sysrq overhead regression

2020-06-10 Thread Johan Hovold
mail.com> Signed-off-by: Johan Hovold --- drivers/tty/serial/serial_core.c | 99 + include/linux/serial_core.h | 103 +-- 2 files changed, 100 insertions(+), 102 deletions(-) diff --git a/drivers/tty/serial/serial_core.c b/driver

[PATCH v2 0/3] serial: core: fix up sysrq regressions

2020-06-10 Thread Johan Hovold
). Johan Changes in v2 - inline uart_unlock_and_check_sysrq() along with the other helpers (restoring the interrupt state in a helper was never an issue) Johan Hovold (3): Revert "serial: core: Refactor uart_unlock_and_check_sysrq()" serial: core: fix sysrq overhead regressio

Re: [PATCH] tty: serial: cpm_uart: Fix behaviour for non existing GPIOs

2020-06-07 Thread Johan Hovold
On Sat, Jun 06, 2020 at 07:30:21AM +, Christophe Leroy wrote: > devm_gpiod_get_index() doesn't return NULL but -ENOENT when the > requested GPIO doesn't exist, leading to the following messages: > > [2.742468] gpiod_direction_input: invalid GPIO (errorpointer) > [2.748147] can't set d

Re: [PATCH 2/4] serial: core: fix broken sysrq port unlock

2020-06-03 Thread Johan Hovold
On Wed, Jun 03, 2020 at 10:40:51AM +0200, Johan Hovold wrote: > On Tue, Jun 02, 2020 at 04:34:16PM +0100, Dmitry Safonov wrote: > > On 6/2/20 3:48 PM, Andy Shevchenko wrote: > > > On Tue, Jun 2, 2020 at 5:03 PM Johan Hovold wrote: > > >> > > >> Commit d6e

Re: [PATCH 2/4] serial: core: fix broken sysrq port unlock

2020-06-03 Thread Johan Hovold
On Tue, Jun 02, 2020 at 04:34:16PM +0100, Dmitry Safonov wrote: > On 6/2/20 3:48 PM, Andy Shevchenko wrote: > > On Tue, Jun 2, 2020 at 5:03 PM Johan Hovold wrote: > >> > >> Commit d6e1935819db ("serial: core: Allow processing sysrq at port > >> unloc

[PATCH 4/4] serial: core: drop redundant sysrq checks

2020-06-02 Thread Johan Hovold
The sysrq timestamp will never be set unless port->has_sysrq so drop the redundant checks that where added by commit 1997e9dfdc84 ("serial_core: Un-ifdef sysrq SUPPORT_SYSRQ"). Signed-off-by: Johan Hovold --- include/linux/serial_core.h | 4 ++-- 1 file changed, 2 insertions(+)

[PATCH 2/4] serial: core: fix broken sysrq port unlock

2020-06-02 Thread Johan Hovold
mail.com> Signed-off-by: Johan Hovold --- drivers/tty/serial/serial_core.c | 19 --- include/linux/serial_core.h | 21 +++-- 2 files changed, 19 insertions(+), 21 deletions(-) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial

[PATCH 0/4] serial: core: fix up sysrq regressions

2020-06-02 Thread Johan Hovold
This series fixes a few regressions introduced by the recent sysrq rework that went into 5.6. The port unlock fix is tagged for stable, and the fix for the unnecessary per-character overhead probably could be as well although it is a bit more intrusive. Johan Johan Hovold (4): Revert "s

[PATCH 1/4] Revert "serial: core: Refactor uart_unlock_and_check_sysrq()"

2020-06-02 Thread Johan Hovold
that the __releases() attribute won't be needed after the follow-on fix either. Signed-off-by: Johan Hovold --- drivers/tty/serial/serial_core.c | 23 +-- include/linux/serial_core.h | 3 ++- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/

[PATCH 3/4] serial: core: fix sysrq overhead regression

2020-06-02 Thread Johan Hovold
e compiler. Inlining these helpers again also avoids the function call overhead when CONFIG_MAGIC_SYSRQ_SERIAL is enabled. Fixes: 8e20fc391711 ("serial_core: Move sysrq functions from header file") Cc: Dmitry Safonov <0x7f454...@gmail.com> Signed-off-by: Johan Hovold --- driver

Re: [PATCH] serial: 8250_port: Fix imprecise external abort for mctrl if inactive

2020-06-02 Thread Johan Hovold
On Mon, Jun 01, 2020 at 05:18:13PM -0700, Tony Lindgren wrote: > We can get an imprecise external abort on uart_shutdown() at > serial8250_do_set_mctrl() if the UART is autoidled. > > We don't want to add PM runtime calls to serial8250_do_set_mctrl() > beyond checking the usage count as it gets ca

Re: [PATCH 0/6] leds: fix broken devres usage

2020-06-01 Thread Johan Hovold
On Mon, Jun 01, 2020 at 06:09:23PM +0300, Andy Shevchenko wrote: > On Mon, Jun 1, 2020 at 5:29 PM Johan Hovold wrote: > > On Mon, Jun 01, 2020 at 05:08:40PM +0300, Andy Shevchenko wrote: > > > On Mon, Jun 1, 2020 at 5:01 PM Johan Hovold wrote: > > > > On Mon, Ju

Re: [PATCH 0/6] leds: fix broken devres usage

2020-06-01 Thread Johan Hovold
On Mon, Jun 01, 2020 at 05:08:40PM +0300, Andy Shevchenko wrote: > On Mon, Jun 1, 2020 at 5:01 PM Johan Hovold wrote: > > > > On Mon, Jun 01, 2020 at 04:51:01PM +0300, Andy Shevchenko wrote: > > > On Mon, Jun 1, 2020 at 4:42 PM Johan Hovold wrote: > > > &g

Re: [PATCH 0/6] leds: fix broken devres usage

2020-06-01 Thread Johan Hovold
On Mon, Jun 01, 2020 at 04:51:01PM +0300, Andy Shevchenko wrote: > On Mon, Jun 1, 2020 at 4:42 PM Johan Hovold wrote: > > > > Several MFD child drivers register their class devices directly under > > the parent device (about half of the MFD LED drivers do so). > >

[PATCH 1/6] leds: 88pm860x: fix use-after-free on unbind

2020-06-01 Thread Johan Hovold
while still being registered. Fixes: 375446df95ee ("leds: 88pm860x: Use devm_led_classdev_register") Cc: stable # 4.6 Cc: Amitoj Kaur Chawla Signed-off-by: Johan Hovold --- drivers/leds/leds-88pm860x.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[PATCH 0/6] leds: fix broken devres usage

2020-06-01 Thread Johan Hovold
devices. All but the lm3533 one have only been compile tested. Johan Johan Hovold (6): leds: 88pm860x: fix use-after-free on unbind leds: da903x: fix use-after-free on unbind leds: lm3533: fix use-after-free on unbind leds: lm36274: fix use-after-free on unbind leds: wm831x-status: fix use

[PATCH 6/6] leds: drop redundant struct-device pointer casts

2020-06-01 Thread Johan Hovold
Drop the pointless and needlessly confusing casts of struct-device pointers. Signed-off-by: Johan Hovold --- drivers/leds/leds-lm355x.c | 9 +++-- drivers/leds/leds-lm3642.c | 9 +++-- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/leds/leds-lm355x.c b/drivers

[PATCH 4/6] leds: lm36274: fix use-after-free on unbind

2020-06-01 Thread Johan Hovold
registered. Fixes: 11e1bbc116a7 ("leds: lm36274: Introduce the TI LM36274 LED driver") Cc: stable # 5.3 Cc: Dan Murphy Signed-off-by: Johan Hovold --- drivers/leds/leds-lm36274.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/leds/leds-l

[PATCH 2/6] leds: da903x: fix use-after-free on unbind

2020-06-01 Thread Johan Hovold
while still being registered. Fixes: eed16255d66b ("leds: da903x: Use devm_led_classdev_register") Cc: stable # 4.6 Cc: Amitoj Kaur Chawla Signed-off-by: Johan Hovold --- drivers/leds/leds-da903x.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/dr

[PATCH 5/6] leds: wm831x-status: fix use-after-free on unbind

2020-06-01 Thread Johan Hovold
while still being registered. Fixes: 8d3b6a4001ce ("leds: wm831x-status: Use devm_led_classdev_register") Cc: stable # 4.6 Cc: Amitoj Kaur Chawla Signed-off-by: Johan Hovold --- drivers/leds/leds-wm831x-status.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-)

[PATCH 3/6] leds: lm3533: fix use-after-free on unbind

2020-06-01 Thread Johan Hovold
while still being registered. Fixes: 50154e29e5cc ("leds: lm3533: Use devm_led_classdev_register") Cc: stable # 4.6 Cc: Amitoj Kaur Chawla Signed-off-by: Johan Hovold --- drivers/leds/leds-lm3533.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/dr

[tip: timers/core] clocksource/drivers/rda: drop redundant Kconfig dependency

2020-06-01 Thread tip-bot2 for Johan Hovold
The following commit has been merged into the timers/core branch of tip: Commit-ID: 83cba9536905e4f82b726a98fe404400f0c9eb76 Gitweb: https://git.kernel.org/tip/83cba9536905e4f82b726a98fe404400f0c9eb76 Author:Johan Hovold AuthorDate:Wed, 13 May 2020 14:25:48 +02:00

Re: [PATCH 4/5] iio: light: lm3533-als: remove explicit parent assignment

2020-05-29 Thread Johan Hovold
[ Trimming CC to something more reasonable... ] On Fri, May 29, 2020 at 11:08:38AM +, Ardelean, Alexandru wrote: > On Fri, 2020-05-29 at 12:16 +0200, Johan Hovold wrote: > > On Fri, May 22, 2020 at 11:22:07AM +0300, Alexandru Ardelean wrote: > > > This assignment is the mo

Re: [PATCH 4/5] iio: light: lm3533-als: remove explicit parent assignment

2020-05-29 Thread Johan Hovold
On Fri, May 22, 2020 at 11:22:07AM +0300, Alexandru Ardelean wrote: > This assignment is the more peculiar of the bunch as it assigns the parent > of the platform-device's device (i.e. pdev->dev.parent) as the IIO device's > parent. > > It's unclear whether this is intentional or not. > Hence it is

Re: [PATCH v3 2/2] usb: serial: xr_serial: Add gpiochip support

2020-05-29 Thread Johan Hovold
On Wed, May 27, 2020 at 08:39:59AM +0530, Manivannan Sadhasivam wrote: > Hi, > > On Tue, May 19, 2020 at 03:07:40PM +0200, Johan Hovold wrote: > > On Fri, May 01, 2020 at 12:19:24AM +0530, m...@kernel.org wrote: > > > From: Manivannan Sadhasivam > > > > &g

[GIT PULL] GNSS updates for 5.8-rc1

2020-05-29 Thread Johan Hovold
The following changes since commit 2ef96a5bb12be62ef75b5828c0aab838ebb29cb8: Linux 5.7-rc5 (2020-05-10 15:16:58 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/johan/gnss.git tags/gnss-5.8-rc1 for you to fetch changes up to 9b5816b56af6a424619

Re: [PATCH 5/6] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem

2020-05-28 Thread Johan Hovold
419 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Motorola Modem TS 27.010 serdev GNSS driver > + * > + * Copyright (C) 2018 - 2020 Tony Lindgren > + * > + * Based on drivers/gnss/sirf.c driver example: > + * Copyright (C) 2018 Johan Hovold > + */ > + >

Re: [PATCH 4/6] serdev: ngsm: Add generic serdev-ngsm driver

2020-05-28 Thread Johan Hovold
On Tue, May 12, 2020 at 02:47:11PM -0700, Tony Lindgren wrote: > We can have a generic serdev-ngsm driver bring up the TS 27.010 line > discipline on the selected serial ports based on device tree data. > > And we can now do standard Linux device driver for the dedicated > TS 27.010 channels for d

Re: [PATCH 3/6] dt-bindings: serdev: ngsm: Add binding for GNSS child node

2020-05-28 Thread Johan Hovold
On Wed, May 27, 2020 at 01:28:17PM -0600, Rob Herring wrote: > On Tue, May 12, 2020 at 02:47:10PM -0700, Tony Lindgren wrote: > > For motorola modem case, we may have a GNSS device on channel 4. > > Let's add that to the binding and example. > > > > Signed-off-by: Tony Lindgren > > --- > > .../d

Re: [PATCH 2/6] dt-bindings: serdev: ngsm: Add binding for serdev-ngsm

2020-05-28 Thread Johan Hovold
On Tue, May 12, 2020 at 02:47:09PM -0700, Tony Lindgren wrote: > Add a binding document for a generic serdev-ngsm driver that can be > used to bring up TS 27.010 line discipline with Linux n_gsm support > on a serial port. > > As the Motorola Mapphone modems require some custom handling, they > ar

Re: [PATCH 1/6] tty: n_gsm: Add support for serdev drivers

2020-05-28 Thread Johan Hovold
On Tue, May 12, 2020 at 02:47:08PM -0700, Tony Lindgren wrote: > We can make use of serdev drivers to do simple device drivers for > TS 27.010 chanels, and we can handle vendor specific protocols on top > of TS 27.010 with serdev drivers. > > So far this has been tested with Motorola droid4 where

Re: [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4

2020-05-28 Thread Johan Hovold
On Tue, May 12, 2020 at 02:47:07PM -0700, Tony Lindgren wrote: > Hi all, > > Here's the updated set of these patches fixed up for Johan's and > Pavel's earlier comments. > > This series does the following: > > 1. Adds functions to n_gsm.c for serdev-ngsm.c driver to use > > 2. Adds a generic se

Re: [PATCHv6 0/4] n_gsm serdev support and protocol driver for droid4 modem

2020-05-28 Thread Johan Hovold
Hi Tony, Sorry about the late reply on this. On Thu, Apr 23, 2020 at 08:37:56AM -0700, Tony Lindgren wrote: > * Johan Hovold [200423 11:44]: > > I know the location of this driver has been up for discussion already, > > but drivers/tty/serdev/protocol still isn't right (e

[tip: x86/cleanups] x86/apb_timer: Drop unused TSC calibration

2020-05-27 Thread tip-bot2 for Johan Hovold
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: 003d80535180f74f262c40462b9fccd7f004901a Gitweb: https://git.kernel.org/tip/003d80535180f74f262c40462b9fccd7f004901a Author:Johan Hovold AuthorDate:Wed, 13 May 2020 12:09:43 +02:00

[tip: x86/cleanups] x86/apb_timer: Drop unused declaration and macro

2020-05-27 Thread tip-bot2 for Johan Hovold
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: e027a2bc934fd05d52ec5b77d159efdfc485b5b3 Gitweb: https://git.kernel.org/tip/e027a2bc934fd05d52ec5b77d159efdfc485b5b3 Author:Johan Hovold AuthorDate:Wed, 13 May 2020 12:09:44 +02:00

Re: [PATCH 1/2] x86/apb_timer: drop unused TSC calibration

2020-05-27 Thread Johan Hovold
On Wed, May 13, 2020 at 12:09:43PM +0200, Johan Hovold wrote: > Drop the APB-timer TSC calibration, which hasn't been used since the > removal of Moorestown support by commit 1a8359e411eb ("x86/mid: Remove > Intel Moorestown"). > > Signed-off-by: Johan Hovold

Re: [PATCH 1/1] USB: serial: option: add Telit LE910C1-EUX compositions

2020-05-27 Thread Johan Hovold
On Mon, May 25, 2020 at 11:11:06PM +0200, Daniele Palmas wrote: > Add Telit LE910C1-EUX compositions: > > 0x1031: tty, tty, tty, rmnet > 0x1033: tty, tty, tty, ecm > Signed-off-by: Daniele Palmas Thanks, Daniele. Now applied. Johan

Re: [PATCH v2] USB: serial: qcserial: Add DW5816e QDL support

2020-05-25 Thread Johan Hovold
On Thu, May 21, 2020 at 10:43:58AM +1000, Matt Jolly wrote: > Add support for Dell Wireless 5816e Download Mode (AKA boot & hold mode / > QDL download mode) to drivers/usb/serial/qcserial.c > > This is required to update device firmware. > > Signed-off-by: Matt Jolly > --- > v2 changes: typo. H

Re: [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4

2020-05-25 Thread Johan Hovold
On Fri, May 22, 2020 at 11:17:31AM +0200, Greg Kroah-Hartman wrote: > On Tue, May 12, 2020 at 02:47:07PM -0700, Tony Lindgren wrote: > > Hi all, > > > > Here's the updated set of these patches fixed up for Johan's and > > Pavel's earlier comments. > > > > This series does the following: > > > >

Re: [PATCH v3 2/2] usb: serial: xr_serial: Add gpiochip support

2020-05-19 Thread Johan Hovold
On Fri, May 01, 2020 at 12:19:24AM +0530, m...@kernel.org wrote: > From: Manivannan Sadhasivam > > Add gpiochip support for Maxlinear/Exar USB to serial converter > for controlling the available gpios. You should mention that you've based this implementation on the other usb-serial gpio-chip imp

Re: [PATCH v3 1/2] usb: serial: Add MaxLinear/Exar USB to Serial driver

2020-05-19 Thread Johan Hovold
On Fri, May 01, 2020 at 12:19:23AM +0530, m...@kernel.org wrote: > From: Manivannan Sadhasivam > > Add support for MaxLinear/Exar USB to Serial converters. This driver > only supports XR21V141X series but it can be extended to other series > from Exar as well in future. > > This driver is inspir

Re: [PATCH 2/2] usb: serial: xr_serial: Add gpiochip support

2020-05-19 Thread Johan Hovold
On Wed, Apr 29, 2020 at 11:17:27PM +0530, Manivannan Sadhasivam wrote: > On Wed, Apr 29, 2020 at 01:26:51AM +0530, m...@kernel.org wrote: > > From: Manivannan Sadhasivam > > > > Add gpiochip support for Maxlinear/Exar USB to serial converter > > for controlling the available gpios. > > > > Cc:

Re: [PATCH 2/2] usb: serial: xr_serial: Add gpiochip support

2020-05-19 Thread Johan Hovold
On Wed, Apr 29, 2020 at 06:19:18PM +0530, Manivannan Sadhasivam wrote: > On Wed, Apr 29, 2020 at 02:12:24PM +0200, Linus Walleij wrote: > > On Tue, Apr 28, 2020 at 9:57 PM wrote: > > > > > From: Manivannan Sadhasivam > > > > > > Add gpiochip support for Maxlinear/Exar USB to serial converter >

Re: [PATCH 1/3] serdev: ttyport: add devt for tty port

2020-05-18 Thread Johan Hovold
On Wed, May 06, 2020 at 03:23:12PM +0800, Claire Chang wrote: > serial_match_port() uses devt to match devices. However, when serdev > registers a tty port, devt has never been set. This makes > device_find_child() always return NULL. > > Assign devt in serdev_tty_port_register() to fix this. > >

[PATCH] staging: greybus: uart: replace driver line-coding struct

2020-05-14 Thread Johan Hovold
tally made the structures match again. Signed-off-by: Johan Hovold --- drivers/staging/greybus/uart.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 55c51143bb09..84de56800a21 100644 ---

Re: [greybus-dev] [PATCH] greybus: uart: fix uninitialized flow control variable

2020-05-14 Thread Johan Hovold
On Wed, Apr 29, 2020 at 03:00:44PM -0500, Alex Elder wrote: > On 4/29/20 2:00 PM, Arnd Bergmann wrote: > > gcc-10 points out an uninitialized variable use: > > Wow, nice, checking individual uninitialized fields within > the structure. > > The structure should really be zero-initialized anyway; i

Re: [PATCH] staging: greybus: Replace zero-length array with flexible-array

2020-05-13 Thread Johan Hovold
On Wed, May 13, 2020 at 05:39:18PM +0200, Greg Kroah-Hartman wrote: > On Wed, May 13, 2020 at 05:03:43PM +0200, Johan Hovold wrote: > > On Thu, May 07, 2020 at 01:53:18PM -0500, Gustavo A. R. Silva wrote: > > > The current codebase makes use of the zero-length array language >

Re: [PATCH] staging: greybus: Replace zero-length array with flexible-array

2020-05-13 Thread Johan Hovold
On Thu, May 07, 2020 at 01:53:18PM -0500, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced i

Re: [PATCH] treewide: Replace zero-length array with flexible-array

2020-05-13 Thread Johan Hovold
On Thu, May 07, 2020 at 01:53:13PM -0500, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced i

Re: [PATCH -next] gnss: sirf: fix error return code in sirf_probe()

2020-05-13 Thread Johan Hovold
On Thu, May 07, 2020 at 09:42:52AM +, Wei Yongjun wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: d2efbbd18b1e ("gnss: add driver for sirfstar-based receivers") > Reported-by: Hulk Robot > Signed-off-by:

[PATCH] clocksource/drivers/rda: drop redundant Kconfig dependency

2020-05-13 Thread Johan Hovold
Since commit 2f8a26c166eb ("clocksource: Improve GENERIC_CLOCKEVENTS dependency") all clocksource drivers depend on GENERIC_CLOCKEVENTS so drop the redundant attribute from the RDA-timer entry which was added later. Signed-off-by: Johan Hovold --- drivers/clocksource/Kconfig | 1

[PATCH 1/2] x86/apb_timer: drop unused TSC calibration

2020-05-13 Thread Johan Hovold
Drop the APB-timer TSC calibration, which hasn't been used since the removal of Moorestown support by commit 1a8359e411eb ("x86/mid: Remove Intel Moorestown"). Signed-off-by: Johan Hovold --- arch/x86/include/asm/apb_timer.h | 2 -- arch/x86/kernel/apb_ti

[PATCH 2/2] x86/apb_timer: drop unused declaration and macro

2020-05-13 Thread Johan Hovold
Drop an extern declaration that has never been used and a no longer needed macro. Signed-off-by: Johan Hovold --- arch/x86/include/asm/apb_timer.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/x86/include/asm/apb_timer.h b/arch/x86/include/asm/apb_timer.h index 0a9bf8b77a28

Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks

2020-05-07 Thread Johan Hovold
4.4 branch > the following build error found. > > of_mdio: add helper to deregister fixed-link PHYs > commit 3f65047c853a2a5abcd8ac1984af3452b5df4ada upstream. > > Add helper to deregister fixed-link PHYs registered using > of_phy_register_fixed_link(). > > Conver

<    1   2   3   4   5   6   7   8   9   10   >