Re: x86: GEODE fix MFGPT input clock value

2008-01-23 Thread Jordan Crouse
and particularly comments the least possible. Do you want an update ? Please do - I don't mind if you change the comments - better that they are right. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. -- To unsubscribe from this list: send the line

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-22 Thread Jordan Crouse
l we can tell is if the registers are zero or not. Like I said, running the MSR is probably dangerous in 9 out of 10 situations, the one good use being the one you determined. I would support adding the mfgptfix bit though - just as long as it isn't automagic. Thank you very much for your help! Jor

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-22 Thread Jordan Crouse
being enabled on the other vectors. Anyway, please try this test patch and let me know what happens. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. [GEODE] fix a race condition in the MFGPT timer tick From: Jordan Crouse <[EMAIL PROTECTED]>

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-22 Thread Jordan Crouse
On 22/01/08 12:18 +0100, Arnd Hannemann wrote: > Hi Lars, > > Lars Heete schrieb: > > Hello, > > > > On Tuesday 22 January 2008 10:03:08 am Arnd Hannemann wrote: > >> Jordan Crouse wrote: > >>> Okay - I've been exploring a little bit more.

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-22 Thread Jordan Crouse
On 22/01/08 12:18 +0100, Arnd Hannemann wrote: Hi Lars, Lars Heete schrieb: Hello, On Tuesday 22 January 2008 10:03:08 am Arnd Hannemann wrote: Jordan Crouse wrote: Okay - I've been exploring a little bit more. I talked to the TinyBIOS developer, and he verified that TinyBIOS

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-22 Thread Jordan Crouse
enabled on the other vectors. Anyway, please try this test patch and let me know what happens. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. [GEODE] fix a race condition in the MFGPT timer tick From: Jordan Crouse [EMAIL PROTECTED] When we set

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-22 Thread Jordan Crouse
as long as it isn't automagic. Thank you very much for your help! Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-21 Thread Jordan Crouse
disabled if you want. Thanks, Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. diff --git a/arch/x86/kernel/mfgpt_32.c b/arch/x86/kernel/mfgpt_32.c index 0ab680f..5b4fa24 100644 --- a/arch/x86/kernel/mfgpt_32.c +++ b/arch/x86/kernel/mfgpt_32.c

Re: Geode GX/LX watchdog timer (RESEND)

2008-01-21 Thread Jordan Crouse
On 20/01/08 14:22 +0100, Arnd Hannemann wrote: > Hi, > > Jordan Crouse wrote: > > On 17/01/08 23:52 +0100, Arnd Hannemann wrote: > >>>> Watchdog for the new API would be great :-) > >>> Coming soon. > > > > As promised, a watchdog dr

Re: Geode GX/LX watchdog timer (RESEND)

2008-01-21 Thread Jordan Crouse
On 20/01/08 14:22 +0100, Arnd Hannemann wrote: Hi, Jordan Crouse wrote: On 17/01/08 23:52 +0100, Arnd Hannemann wrote: Watchdog for the new API would be great :-) Coming soon. As promised, a watchdog driver for the Geode GX/LX processors is attached. I basically just ported

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-21 Thread Jordan Crouse
, Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. diff --git a/arch/x86/kernel/mfgpt_32.c b/arch/x86/kernel/mfgpt_32.c index 0ab680f..5b4fa24 100644 --- a/arch/x86/kernel/mfgpt_32.c +++ b/arch/x86/kernel/mfgpt_32.c @@ -74,18 +74,31 @@ int __init

Re: Geode GX/LX watchdog timer (was 2.6.24-rc8 hangs at mfgpt-timer)

2008-01-20 Thread Jordan Crouse
On 20/01/08 14:22 +0100, Arnd Hannemann wrote: > Hi, > > Jordan Crouse wrote: > > On 17/01/08 23:52 +0100, Arnd Hannemann wrote: > >>>> Watchdog for the new API would be great :-) > >>> Coming soon. > > > > As promised, a watchdog dr

Re: Geode GX/LX watchdog timer (was 2.6.24-rc8 hangs at mfgpt-timer)

2008-01-20 Thread Jordan Crouse
On 20/01/08 14:22 +0100, Arnd Hannemann wrote: Hi, Jordan Crouse wrote: On 17/01/08 23:52 +0100, Arnd Hannemann wrote: Watchdog for the new API would be great :-) Coming soon. As promised, a watchdog driver for the Geode GX/LX processors is attached. I basically just ported

[GEODE] Geode GX/LX watchdog timer (was 2.6.24-rc8 hangs at mfgpt-timer)

2008-01-18 Thread Jordan Crouse
e. So, anyway, enjoy the watchdog timer - I hope it meets everybody's expectations for the 2.6.25 kernel. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. [GEODE] Add a watchdog driver based on the CS5535/CS5536 MFGPT timers From: Jordan Crouse <[EMAIL PROTECTED

[GEODE] Geode GX/LX watchdog timer (was 2.6.24-rc8 hangs at mfgpt-timer)

2008-01-18 Thread Jordan Crouse
- I hope it meets everybody's expectations for the 2.6.25 kernel. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. [GEODE] Add a watchdog driver based on the CS5535/CS5536 MFGPT timers From: Jordan Crouse [EMAIL PROTECTED] Add a watchdog timer based

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-17 Thread Jordan Crouse
On 18/01/08 00:39 +0100, Arnd Hannemann wrote: > Jordan Crouse schrieb: > > On 17/01/08 23:52 +0100, Arnd Hannemann wrote: > > > > > > > >>> Hmmm - not sure whats happening here. I wonder if we're stuck in an > >>> interrupt storm

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-17 Thread Jordan Crouse
7:ef:5f:f4:bf:d1:95:68 > MSR register 0x51400021 => b7:fd:1f:f4:bf:cf:5a:d8 > MSR register 0x51400022 => b7:f3:bf:f4:bf:f5:fb:a8 > MSR register 0x51400023 => b7:fb:9f:f4:bf:fd:d9:f8 Hmmm - those look wrong. Is /dev/cpu/0/msr there? The applet on the wiki has a bug that doesn't che

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-17 Thread Jordan Crouse
On 17/01/08 22:50 +0100, Arnd Hannemann wrote: > Jordan Crouse schrieb: > > On 17/01/08 20:53 +0100, Arnd Hannemann wrote: > >> Andres Salomon schrieb: > >>> On Thu, 17 Jan 2008 10:54:30 +0100 > >>> Arnd Hannemann <[EMAIL PROTECTED]> wrote: > &g

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-17 Thread Jordan Crouse
On 17/01/08 20:53 +0100, Arnd Hannemann wrote: > Andres Salomon schrieb: > > On Thu, 17 Jan 2008 10:54:30 +0100 > > Arnd Hannemann <[EMAIL PROTECTED]> wrote: > > > >> Andres Salomon schrieb: > >>> On Wed, 16 Jan 2008 16:19:12 -0500 > >>> Andres Salomon <[EMAIL PROTECTED]> wrote: > >>> > On

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-17 Thread Jordan Crouse
On 17/01/08 20:53 +0100, Arnd Hannemann wrote: Andres Salomon schrieb: On Thu, 17 Jan 2008 10:54:30 +0100 Arnd Hannemann [EMAIL PROTECTED] wrote: Andres Salomon schrieb: On Wed, 16 Jan 2008 16:19:12 -0500 Andres Salomon [EMAIL PROTECTED] wrote: On Wed, 16 Jan 2008 18:44:07 +0100

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-17 Thread Jordan Crouse
:9f:f4:bf:fd:d9:f8 Hmmm - those look wrong. Is /dev/cpu/0/msr there? The applet on the wiki has a bug that doesn't check for it. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-17 Thread Jordan Crouse
On 17/01/08 22:50 +0100, Arnd Hannemann wrote: Jordan Crouse schrieb: On 17/01/08 20:53 +0100, Arnd Hannemann wrote: Andres Salomon schrieb: On Thu, 17 Jan 2008 10:54:30 +0100 Arnd Hannemann [EMAIL PROTECTED] wrote: Andres Salomon schrieb: On Wed, 16 Jan 2008 16:19:12 -0500 Andres

Re: 2.6.24-rc8 hangs at mfgpt-timer

2008-01-17 Thread Jordan Crouse
On 18/01/08 00:39 +0100, Arnd Hannemann wrote: Jordan Crouse schrieb: On 17/01/08 23:52 +0100, Arnd Hannemann wrote: snip Hmmm - not sure whats happening here. I wonder if we're stuck in an interrupt storm of some sort as soon as you register the interrupt handler. But I would

Re: drivers/usb: Add missing "space"

2007-11-28 Thread Jordan Crouse
> Date: Mon, 19 Nov 2007 17:53:33 -0800 > > This list [EMAIL PROTECTED] should be removed > from MAINTAINERS if it continues to reject not moderate > emails with patches to the list without subscribing. Okay - moderation should be turned on. Please yell very loudly at me (and ca

Re: drivers/usb: Add missing space

2007-11-28 Thread Jordan Crouse
- moderation should be turned on. Please yell very loudly at me (and call me bad names) if it isn't. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: drivers/usb: Add missing "space"

2007-11-20 Thread Jordan Crouse
> Date: Mon, 19 Nov 2007 17:53:33 -0800 > > This list [EMAIL PROTECTED] should be removed > from MAINTAINERS if it continues to reject not moderate > emails with patches to the list without subscribing. Agreed. I'll switch to moderation. > > > -- Jordan Crouse Systems

Re: drivers/usb: Add missing space

2007-11-20 Thread Jordan Crouse
. I'll switch to moderation. -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: Use the correct MSR number for panel support

2007-10-30 Thread Jordan Crouse
On 29/10/07 17:02 -0700, H. Peter Anvin wrote: > Jordan Crouse wrote: > > From: Jordan Crouse <[EMAIL PROTECTED]> > > > > A relatively recent version of the Geode LX datasheet listed the wrong > > address for one of the MSRs that controls TFT panels, result

Re: Use the correct MSR number for panel support

2007-10-30 Thread Jordan Crouse
On 29/10/07 17:02 -0700, H. Peter Anvin wrote: Jordan Crouse wrote: From: Jordan Crouse [EMAIL PROTECTED] A relatively recent version of the Geode LX datasheet listed the wrong address for one of the MSRs that controls TFT panels, resulting in breakage. This patch corrects the MSR

[PATCH] [LXFB] Use the correct MSR number for panel support

2007-10-26 Thread Jordan Crouse
From: Jordan Crouse <[EMAIL PROTECTED]> A relatively recent version of the Geode LX datasheet listed the wrong address for one of the MSRs that controls TFT panels, resulting in breakage. This patch corrects the MSR address. Signed-off-by: Jordan Crouse <[EMAIL PROTECTED]> --- d

[PATCH] [LXFB] Use the correct MSR number for panel support

2007-10-26 Thread Jordan Crouse
From: Jordan Crouse [EMAIL PROTECTED] A relatively recent version of the Geode LX datasheet listed the wrong address for one of the MSRs that controls TFT panels, resulting in breakage. This patch corrects the MSR address. Signed-off-by: Jordan Crouse [EMAIL PROTECTED] --- drivers/video

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2007-10-19 Thread Jordan Crouse
On Fri, 19 Oct 2007 14:01:56 +0200, Florian Fainelli wrote: > Hi Andres, > > Le jeudi 18 octobre 2007, Andres Salomon a écrit : >> While I certainly would like to see a generic GPIO API, this one isn't >> really useful for geode GPIOs. It would be nice to have one that did >> work for us as

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2007-10-19 Thread Jordan Crouse
On Fri, 19 Oct 2007 14:01:56 +0200, Florian Fainelli wrote: Hi Andres, Le jeudi 18 octobre 2007, Andres Salomon a écrit : While I certainly would like to see a generic GPIO API, this one isn't really useful for geode GPIOs. It would be nice to have one that did work for us as well.

Re: GEODE: update GPIO API to support setting multiple GPIOs at once

2007-10-18 Thread Jordan Crouse
is also adds a bit of sanity checking; it is no > longer possible to use a GPIO above 28. > > > Note the semantics of geode_gpio_isset() have changed: > geode_gpio_isset(geode_gpio(3)|geode_gpio(4), ...) > will only return true iff both GPIOs are set. > > Signed-off-by: Andr

Re: GEODE: use symbolic constant in cs5536 reboot fixup

2007-10-18 Thread Jordan Crouse
On 18/10/07 15:26 -0400, Andres Salomon wrote: > Simple cosmetic update for the cs5536 reboot fixup; define the MSR that's used > for rebooting in geode.h, and use the define. > > Signed-off-by: Andres Salomon <[EMAIL PROTECTED]> Acked-by: Jordan Crouse <[EMAIL PROTECTED]&

Re: GEODE: update GPIO API to support setting multiple GPIOs at once

2007-10-18 Thread Jordan Crouse
the semantics of geode_gpio_isset() have changed: geode_gpio_isset(geode_gpio(3)|geode_gpio(4), ...) will only return true iff both GPIOs are set. Signed-off-by: Andres Salomon [EMAIL PROTECTED] Acked-by: Jordan Crouse [EMAIL PROTECTED] diff --git a/arch/x86/kernel/geode_32.c b/arch/x86

Re: GEODE: use symbolic constant in cs5536 reboot fixup

2007-10-18 Thread Jordan Crouse
On 18/10/07 15:26 -0400, Andres Salomon wrote: Simple cosmetic update for the cs5536 reboot fixup; define the MSR that's used for rebooting in geode.h, and use the define. Signed-off-by: Andres Salomon [EMAIL PROTECTED] Acked-by: Jordan Crouse [EMAIL PROTECTED] diff --git a/arch/x86/kernel

Re: More E820 brokenness

2007-09-27 Thread Jordan Crouse
On 27/09/07 16:36 -0700, H. Peter Anvin wrote: > Jordan Crouse wrote: > >>> > >> Oh bugger, looks like this one might be genuinely my fault after all. > >> The ID check in the new code is buggy. > >> > >> Can you please test this revised patch o

Re: More E820 brokenness

2007-09-27 Thread Jordan Crouse
On 27/09/07 16:27 -0700, H. Peter Anvin wrote: > Jordan Crouse wrote: > > On 27/09/07 15:47 -0700, H. Peter Anvin wrote: > >> Jordan Crouse wrote: > >>> Breaks on the Geode - original behavior. > >>> > >>> I think that having boot_prams.e820_en

Re: More E820 brokenness

2007-09-27 Thread Jordan Crouse
On 27/09/07 15:47 -0700, H. Peter Anvin wrote: > Jordan Crouse wrote: > > > > Breaks on the Geode - original behavior. > > > > I think that having boot_prams.e820_entries != 0 makes the kernel > > assume the e820 data is correct. > > > > Okay, n

Re: More E820 brokenness

2007-09-27 Thread Jordan Crouse
On 27/09/07 15:17 -0700, H. Peter Anvin wrote: > As luck would have it, it's not just an obscure Geode system which has a > broken E820 implementation. Today I received a bug report about a Dell > system (XPS M1330) with broken E820. > > Unfortunately, the workaround for the Geode breaks this

Re: kernel 2.6.23-rc6 hangs on Geode GX1

2007-09-27 Thread Jordan Crouse
with the LX BIOS, so it would be a huge coincidence if they were affected by the same problem. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: kernel 2.6.23-rc6 hangs on Geode GX1

2007-09-27 Thread Jordan Crouse
if they were affected by the same problem. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: More E820 brokenness

2007-09-27 Thread Jordan Crouse
On 27/09/07 15:47 -0700, H. Peter Anvin wrote: Jordan Crouse wrote: Breaks on the Geode - original behavior. I think that having boot_prams.e820_entries != 0 makes the kernel assume the e820 data is correct. Okay, now I'm utterly baffled how 2.6.22 ever worked on this Geode

Re: More E820 brokenness

2007-09-27 Thread Jordan Crouse
On 27/09/07 15:17 -0700, H. Peter Anvin wrote: As luck would have it, it's not just an obscure Geode system which has a broken E820 implementation. Today I received a bug report about a Dell system (XPS M1330) with broken E820. Unfortunately, the workaround for the Geode breaks this system,

Re: More E820 brokenness

2007-09-27 Thread Jordan Crouse
On 27/09/07 16:27 -0700, H. Peter Anvin wrote: Jordan Crouse wrote: On 27/09/07 15:47 -0700, H. Peter Anvin wrote: Jordan Crouse wrote: Breaks on the Geode - original behavior. I think that having boot_prams.e820_entries != 0 makes the kernel assume the e820 data is correct. Okay

Re: More E820 brokenness

2007-09-27 Thread Jordan Crouse
On 27/09/07 16:36 -0700, H. Peter Anvin wrote: Jordan Crouse wrote: Oh bugger, looks like this one might be genuinely my fault after all. The ID check in the new code is buggy. Can you please test this revised patch out (against current -git)? That looks the same as the previous

Re: Regression in 2.6.23-pre Was: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-26 Thread Jordan Crouse
tect this situation, declare the E820 data > unusable and fall back to E801. > > Also, revert to original behavior of always probing all memory > methods; that way all the memory information is available to the > kernel. > > Signed-off-by: H. Peter Anvin <[EMAIL PROTECTED]>

Re: Regression in 2.6.23-pre Was: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-26 Thread Jordan Crouse
On 26/09/07 14:04 -0700, H. Peter Anvin wrote: > Jordan Crouse wrote: > > On 26/09/07 12:14 -0700, H. Peter Anvin wrote: > >> Please try the following debug patch to let us know what is going on. > >> > >>-hpa > > > >> diff --git a/arch/i386

Re: Regression in 2.6.23-pre Was: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-26 Thread Jordan Crouse
the DB800, and so it probably should with the other Geode platforms affected by this. Many thanks to hpa for the guiding hand. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. [i386]: Return an error if the e820 detection goes bad From: Jordan Crouse

Re: Regression in 2.6.23-pre Was: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-26 Thread Jordan Crouse
_pa_symbol(_text), which is page 0x100), then the system gets appropriately angry. As background, I'm using syslinux 3.36 as my loader here - I've used this exact same version for a very long time, so I don't blame it in the least. Something is getting confused in the early kernel, and whatever that

Re: Regression in 2.6.23-pre Was: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-26 Thread Jordan Crouse
is, a still unknown change in a newer version of the BIOS fixed it. The search goes on. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: Regression in 2.6.23-pre Was: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-26 Thread Jordan Crouse
-- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. [i386]: Return an error if the e820 detection goes bad From: Jordan Crouse [EMAIL PROTECTED] Change the e820 code to always return an error if something bad happens while reading the e820 map. This matches

Re: Regression in 2.6.23-pre Was: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-26 Thread Jordan Crouse
On 26/09/07 14:04 -0700, H. Peter Anvin wrote: Jordan Crouse wrote: On 26/09/07 12:14 -0700, H. Peter Anvin wrote: Please try the following debug patch to let us know what is going on. -hpa diff --git a/arch/i386/boot/memory.c b/arch/i386/boot/memory.c index 1a2e62d..a0ccf29

Re: Regression in 2.6.23-pre Was: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-26 Thread Jordan Crouse
back to E801. Also, revert to original behavior of always probing all memory methods; that way all the memory information is available to the kernel. Signed-off-by: H. Peter Anvin [EMAIL PROTECTED] Cc: Jordan Crouse [EMAIL PROTECTED] Cc: Joerg Pommnitz [EMAIL PROTECTED] --- arch/i386/boot

Re: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-25 Thread Jordan Crouse
down the particulars of the fix from the BIOS vendor. I'll let you know. > Do you still need the disassembled reserve_bootmem_core? Sure - you might as well - just to make sure its the same problem. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc.

Re: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-25 Thread Jordan Crouse
of the fix from the BIOS vendor. I'll let you know. Do you still need the disassembled reserve_bootmem_core? Sure - you might as well - just to make sure its the same problem. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. - To unsubscribe from

Re: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-20 Thread Jordan Crouse
figure out whats happening - and I'll check the release notes to see what changed in the BIOS between the failing and working version. If anybody familiar with arch/i386 can think of something new in the kernel that may have precipitated this, do let me know. :) Jordan -- Jordan Crouse Systems S

Re: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-20 Thread Jordan Crouse
can think of something new in the kernel that may have precipitated this, do let me know. :) Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: ALSA: cs5535audio fixes

2007-08-30 Thread Jordan Crouse
opular chip now, so I recommend we put these in, and if by some unlucky coincidence a 5535 bug pops up, we'll deal with it when it happens. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. - To unsubscribe from this list: send the line "unsubscribe

Re: ALSA: cs5535audio: fix ACC_BM[x]_CMD register handling

2007-08-30 Thread Jordan Crouse
; > Signed-off-by: Andres Salomon <[EMAIL PROTECTED]> Acked-by: Jordan Crouse <[EMAIL PROTECTED]> > --- > > sound/pci/cs5535audio/cs5535audio.h | 10 +- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/sound/pci/cs5535audio/cs5535audio.h

Re: ALSA: cs5535audio: update PCI device handling in suspend/resume

2007-08-30 Thread Jordan Crouse
On 29/08/07 23:30 -0400, Andres Salomon wrote: > > Save the PCI state before disabling the device, and add some error checking. > > Signed-off-by: Andres Salomon <[EMAIL PROTECTED]> Acked-by: Jordan Crouse <[EMAIL PROTECTED]> > --- > > sound/pci/cs

Re: ALSA: cs5535audio: fix PRD register save/restore power management race

2007-08-30 Thread Jordan Crouse
ers twice; even powering > down the ACC shouldn't mess with the PRD registers (according to the 5536 > data sheet, section 5.3.7.4, power-down procedure). This patch reworks > all that to first disable DMA, and then save PRD registers. > > Signed-off-by: Andres Salomon <[EMAIL P

Re: ALSA: cs5535audio: drop unused bus master stuff

2007-08-30 Thread Jordan Crouse
ot using.. well, > that warrants spitting out an error message (imo). > > Signed-off-by: Andres Salomon <[EMAIL PROTECTED]> Acked-by: Jordan Crouse <[EMAIL PROTECTED]> > --- > > sound/pci/cs5535audio/cs5535audio.c | 24 +++-

Re: ALSA: cs5535audio: correctly set dma->substream

2007-08-30 Thread Jordan Crouse
is > changes it so that we set the substream when constructing the specific > bus master DMA, and unsetting it when we tear down the BM's DMA. > > Signed-off-by: Andres Salomon <[EMAIL PROTECTED]> Acked-by: Jordan Crouse <[EMAIL PROTECTED]> > --- > > sound/pci

Re: ALSA: cs5535audio: correctly set dma-substream

2007-08-30 Thread Jordan Crouse
set the substream when constructing the specific bus master DMA, and unsetting it when we tear down the BM's DMA. Signed-off-by: Andres Salomon [EMAIL PROTECTED] Acked-by: Jordan Crouse [EMAIL PROTECTED] --- sound/pci/cs5535audio/cs5535audio_pcm.c |2 ++ 1 files changed, 2 insertions

Re: ALSA: cs5535audio: fix PRD register save/restore power management race

2007-08-30 Thread Jordan Crouse
the ACC shouldn't mess with the PRD registers (according to the 5536 data sheet, section 5.3.7.4, power-down procedure). This patch reworks all that to first disable DMA, and then save PRD registers. Signed-off-by: Andres Salomon [EMAIL PROTECTED] Acked-by: Jordan Crouse [EMAIL PROTECTED

Re: ALSA: cs5535audio: drop unused bus master stuff

2007-08-30 Thread Jordan Crouse
, that warrants spitting out an error message (imo). Signed-off-by: Andres Salomon [EMAIL PROTECTED] Acked-by: Jordan Crouse [EMAIL PROTECTED] --- sound/pci/cs5535audio/cs5535audio.c | 24 +++- sound/pci/cs5535audio/cs5535audio.h | 31 +-- 2 files

Re: ALSA: cs5535audio: fix ACC_BM[x]_CMD register handling

2007-08-30 Thread Jordan Crouse
Salomon [EMAIL PROTECTED] Acked-by: Jordan Crouse [EMAIL PROTECTED] --- sound/pci/cs5535audio/cs5535audio.h | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/pci/cs5535audio/cs5535audio.h b/sound/pci/cs5535audio/cs5535audio.h index c7a2044..516219a 100644

Re: ALSA: cs5535audio: update PCI device handling in suspend/resume

2007-08-30 Thread Jordan Crouse
On 29/08/07 23:30 -0400, Andres Salomon wrote: Save the PCI state before disabling the device, and add some error checking. Signed-off-by: Andres Salomon [EMAIL PROTECTED] Acked-by: Jordan Crouse [EMAIL PROTECTED] --- sound/pci/cs5535audio/cs5535audio_pm.c | 12 ++-- 1 files

Re: ALSA: cs5535audio fixes

2007-08-30 Thread Jordan Crouse
put these in, and if by some unlucky coincidence a 5535 bug pops up, we'll deal with it when it happens. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: CS5530 Alsa driver fails

2007-08-02 Thread Jordan Crouse
with the CS5510/20 VSA1 tree I > have here (which isn't under LGPL) Not to get any further off topic - but we're still soliciting volunteers to help port the VSA2 code so that it will build with OSS tools. If you're interested, don't hesitate to dive in. :) Patches always gladly accepted.

Re: CS5530 Alsa driver fails

2007-08-02 Thread Jordan Crouse
e is open, so you can peruse it and discover its secrets for yourself: http://dev.laptop.org/git.do?p=geode-vsa;a=tree;hb=HEAD Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: CS5530 Alsa driver fails

2007-08-02 Thread Jordan Crouse
it and discover its secrets for yourself: http://dev.laptop.org/git.do?p=geode-vsa;a=tree;hb=HEAD Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: CS5530 Alsa driver fails

2007-08-02 Thread Jordan Crouse
here (which isn't under LGPL) Not to get any further off topic - but we're still soliciting volunteers to help port the VSA2 code so that it will build with OSS tools. If you're interested, don't hesitate to dive in. :) Patches always gladly accepted. Jordan -- Jordan Crouse Systems Software

Re: drivers/ide/pci/cs5535.c: array overrun

2007-07-24 Thread Jordan Crouse
zealous - the 5535 only supports up to UDMA4, which matches the array. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. [PATCH] Fix an ovverun found in the 5535 IDE driver From: Jordan Crouse <[EMAIL PROTECTED]> As found by the Coverity checker, a

Re: drivers/ide/pci/cs5535.c: array overrun

2007-07-24 Thread Jordan Crouse
to UDMA4, which matches the array. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. [PATCH] Fix an ovverun found in the 5535 IDE driver From: Jordan Crouse [EMAIL PROTECTED] As found by the Coverity checker, and reported by Adrian Bunk, this fixes a overrun

Re: Geode GX framebuffer driver: Arcom vs. AMD

2007-07-17 Thread Jordan Crouse
On 14/07/07 17:05 -0400, Andrew Paprocki wrote: > Tony, > > Do you have the patch working already? I'd love to try this out in the > meantime on the LX system I am developing with at the moment. I'm > assuming you worked this into the existing Arcom framework (gxfb) and > pulled the necessary

Re: Geode GX framebuffer driver: Arcom vs. AMD

2007-07-17 Thread Jordan Crouse
On 14/07/07 17:05 -0400, Andrew Paprocki wrote: Tony, Do you have the patch working already? I'd love to try this out in the meantime on the LX system I am developing with at the moment. I'm assuming you worked this into the existing Arcom framework (gxfb) and pulled the necessary pieces

[GEODE] Add framebuffer support for the AMD Geode LX

2007-07-09 Thread Jordan Crouse
they have had a chance to soak a little bit more in the OLPC tree. Jordan GEODE: Add framebuffer support for the AMD Geode LX From: Jordan Crouse <[EMAIL PROTECTED]> Add framebuffer support for the AMD Geode LX graphics engine. Signed-off-by: Jordan Crouse <[EMAIL PROTECTED]> --- d

[GEODE] Add framebuffer support for the AMD Geode LX

2007-07-09 Thread Jordan Crouse
they have had a chance to soak a little bit more in the OLPC tree. Jordan GEODE: Add framebuffer support for the AMD Geode LX From: Jordan Crouse [EMAIL PROTECTED] Add framebuffer support for the AMD Geode LX graphics engine. Signed-off-by: Jordan Crouse [EMAIL PROTECTED] --- drivers/video/geode

Re: Bitbanging i2c bus driver using the GPIO API

2007-04-27 Thread Jordan Crouse
On 27/04/07 10:02 +0200, Jean Delvare wrote: > On Thu, 26 Apr 2007 10:03:23 -0400, Lennart Sorensen wrote: > > On Thu, Apr 26, 2007 at 07:39:20AM -0600, Jordan Crouse wrote: > > > There is no ISA on the LX. > > > > Isn't LPC a good equivalent? > > I suspect th

Re: Bitbanging i2c bus driver using the GPIO API

2007-04-27 Thread Jordan Crouse
On 27/04/07 10:02 +0200, Jean Delvare wrote: On Thu, 26 Apr 2007 10:03:23 -0400, Lennart Sorensen wrote: On Thu, Apr 26, 2007 at 07:39:20AM -0600, Jordan Crouse wrote: There is no ISA on the LX. Isn't LPC a good equivalent? I suspect that Jordan meant that there is no LPC either

Re: Bitbanging i2c bus driver using the GPIO API

2007-04-26 Thread Jordan Crouse
On 26/04/07 09:29 -0400, [EMAIL PROTECTED] wrote: > > These return all 0x00 > > On the Geode LX800 where scx200_acb does work all 4 commands return all > 0xff. There is no ISA on the LX. -- Jordan Crouse Senior Linux Engineer Advanced Micro Devices, Inc. - To unsubscribe

Re: Bitbanging i2c bus driver using the GPIO API

2007-04-26 Thread Jordan Crouse
On 26/04/07 09:29 -0400, [EMAIL PROTECTED] wrote: These return all 0x00 On the Geode LX800 where scx200_acb does work all 4 commands return all 0xff. There is no ISA on the LX. -- Jordan Crouse Senior Linux Engineer Advanced Micro Devices, Inc. www.amd.com/embeddedprocessors

Re: Bitbanging i2c bus driver using the GPIO API

2007-04-23 Thread Jordan Crouse
egardless, randomly hitting ISA ports seems scary to me. I know its a pain to use the module params all the time, but thats really probably the cleanest way to to it without carrying around a special patch for your system. Jordan -- Jordan Crouse Senior Linux Engineer Advanced Micro Dev

Re: Bitbanging i2c bus driver using the GPIO API

2007-04-23 Thread Jordan Crouse
, randomly hitting ISA ports seems scary to me. I know its a pain to use the module params all the time, but thats really probably the cleanest way to to it without carrying around a special patch for your system. Jordan -- Jordan Crouse Senior Linux Engineer Advanced Micro Devices, Inc. www.amd.com

Re: Bitbanging i2c bus driver using the GPIO API

2007-04-22 Thread Jordan Crouse
the one used with the geode LX (which does work now). That ISA detection is almost definately suffering from severe bit rot. Once you get past that though, you should be fine - the silicon behind the ACB hasn't changed since the MediaGX days. Jordan -- Jordan Crouse Senior Linux Engineer Advanced M

Re: Bitbanging i2c bus driver using the GPIO API

2007-04-22 Thread Jordan Crouse
with the geode LX (which does work now). That ISA detection is almost definately suffering from severe bit rot. Once you get past that though, you should be fine - the silicon behind the ACB hasn't changed since the MediaGX days. Jordan -- Jordan Crouse Senior Linux Engineer Advanced Micro Devices, Inc

Re: Bitbanging i2c bus driver using the GPIO API

2007-04-19 Thread Jordan Crouse
On 19/04/07 08:54 +0200, Jean Delvare wrote: > Hi Len, > > On Wed, 18 Apr 2007 13:42:56 -0400, Lennart Sorensen wrote: > > On Sat, Apr 14, 2007 at 07:28:07PM +0200, Jean Delvare wrote: > > > Otherwise it looks OK to me, I take the patch. If others have comments > > > or objections, just speak up

Re: Bitbanging i2c bus driver using the GPIO API

2007-04-19 Thread Jordan Crouse
On 19/04/07 08:54 +0200, Jean Delvare wrote: Hi Len, On Wed, 18 Apr 2007 13:42:56 -0400, Lennart Sorensen wrote: On Sat, Apr 14, 2007 at 07:28:07PM +0200, Jean Delvare wrote: Otherwise it looks OK to me, I take the patch. If others have comments or objections, just speak up and submit

Re: geode crypto is PCI device

2006-12-08 Thread Jordan Crouse
On 07/12/06 22:16 -0800, Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > This driver seems to be for a PCI device. Indeed it is. Nice catch. > Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> Acked-by: Jordan Crouse <[EMAIL PROTECTED]> > ---

Re: geode crypto is PCI device

2006-12-08 Thread Jordan Crouse
On 07/12/06 22:16 -0800, Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] This driver seems to be for a PCI device. Indeed it is. Nice catch. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] Acked-by: Jordan Crouse [EMAIL PROTECTED] --- drivers/crypto/Kconfig |2 +- 1 file

[PATCH] Trivial cleanup in the PCI IDs for the CS5535

2006-11-29 Thread Jordan Crouse
Attached is a trivial patch that renames a poorly worded PCI ID for the Geode GX and CS5535 companion chips. The graphics processor and host bridge actually live in the northbridge on the integrated processor, not in the companion chip. --- Jordan Crouse Senior Linux Engineer Advanced Micro

[PATCH] Trivial cleanup in the PCI IDs for the CS5535

2006-11-29 Thread Jordan Crouse
Attached is a trivial patch that renames a poorly worded PCI ID for the Geode GX and CS5535 companion chips. The graphics processor and host bridge actually live in the northbridge on the integrated processor, not in the companion chip. --- Jordan Crouse Senior Linux Engineer Advanced Micro

Re: char: Add MFGPT driver for the CS5535/CS5536

2006-11-27 Thread Jordan Crouse
.Ditto for a watchdog use - although that would be a separate > driver using the kernel hooks anyway. That was the plan - I do have a watchdog driver that I had when I first wrote the MFGPT driver for a now defunct project. I should dust it off and add it in. Thanks, Jordan -- Jordan Crouse Senior

Re: char: Add MFGPT driver for the CS5535/CS5536

2006-11-27 Thread Jordan Crouse
be a separate driver using the kernel hooks anyway. That was the plan - I do have a watchdog driver that I had when I first wrote the MFGPT driver for a now defunct project. I should dust it off and add it in. Thanks, Jordan -- Jordan Crouse Senior Linux Engineer Advanced Micro Devices, Inc. www.amd.com

Re: PowerOP Take 2 0/3 Intro

2005-08-25 Thread Jordan Crouse
Todd - do you have a ChangeLog from Take 1? :) Jordan -- Jordan Crouse Senior Linux Engineer AMD - Personal Connectivity Solutions Group - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: PowerOP Take 2 0/3 Intro

2005-08-25 Thread Jordan Crouse
Todd - do you have a ChangeLog from Take 1? :) Jordan -- Jordan Crouse Senior Linux Engineer AMD - Personal Connectivity Solutions Group www.amd.com/embeddedprocessors - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: PowerOP 2/3: Intel Centrino support

2005-08-11 Thread Jordan Crouse
one might seem more fun, but I hope we can agree its far less productive.. :) Jordan -- Jordan Crouse Senior Linux Engineer AMD - Personal Connectivity Solutions Group - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

<    1   2   3   4   5   6   >