Re: [PATCH] optee: simplify i2c access

2021-02-08 Thread Jorge Ramirez-Ortiz, Foundries
On 08/02/21, Jorge Ramirez-Ortiz, Foundries wrote: > On 08/02/21, Jens Wiklander wrote: > > Hi Jorge, > > > > On Wed, Jan 27, 2021 at 11:41 AM Jens Wiklander > > wrote: > > > > > > Hi Arnd, > > > > > > On Mon, Jan 25, 2021 at 12:

Re: [PATCH] optee: simplify i2c access

2021-02-07 Thread Jorge Ramirez-Ortiz, Foundries
On 08/02/21, Jens Wiklander wrote: > Hi Jorge, > > On Wed, Jan 27, 2021 at 11:41 AM Jens Wiklander > wrote: > > > > Hi Arnd, > > > > On Mon, Jan 25, 2021 at 12:38 PM Arnd Bergmann wrote: > > > > > > From: Arnd Bergmann > > > > > > Storing a bogus i2c_client structure on the stack adds overhead

Re: [PATCH] watchdog: qcom: Remove incorrect usage of QCOM_WDT_ENABLE_IRQ

2021-01-28 Thread Jorge Ramirez-Ortiz, Foundries
On 26/01/21, Sai Prakash Ranjan wrote: > As per register documentation, QCOM_WDT_ENABLE_IRQ which is BIT(1) > of watchdog control register is wakeup interrupt enable bit and > not related to bark interrupt at all, BIT(0) is used for that. > So remove incorrect usage of this bit when supporting

Re: [PATCH] optee: simplify i2c access

2021-01-26 Thread Jorge Ramirez-Ortiz, Foundries
On 25/01/21, Arnd Bergmann wrote: > From: Arnd Bergmann > > Storing a bogus i2c_client structure on the stack adds overhead and > causes a compile-time warning: > > drivers/tee/optee/rpc.c:493:6: error: stack frame size of 1056 bytes in > function 'optee_handle_rpc'

Re: [PATCH] optee: simplify i2c access

2021-01-26 Thread Jorge Ramirez-Ortiz, Foundries
On 26/01/21, Arnd Bergmann wrote: > On Tue, Jan 26, 2021 at 9:08 AM Jorge Ramirez-Ortiz, Foundries > wrote: > > > > On 25/01/21, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > Storing a bogus i2c_client structure on the stack adds ove

Re: [PATCH] drivers: optee: i2c: add bus retry configuration

2020-09-23 Thread Jorge Ramirez-Ortiz, Foundries
On 23/09/20, Jens Wiklander wrote: > On Wed, Sep 23, 2020 at 01:26:31PM +0200, Jorge Ramirez-Ortiz, Foundries > wrote: > > On 23/09/20, Jorge Ramirez-Ortiz, Foundries wrote: > > > On 22/09/20, Jens Wiklander wrote: > > > > On Wed, Sep 16, 2020 at 05:27:32PM

Re: [PATCH] drivers: optee: i2c: add bus retry configuration

2020-09-23 Thread Jorge Ramirez-Ortiz, Foundries
On 23/09/20, Jorge Ramirez-Ortiz, Foundries wrote: > On 22/09/20, Jens Wiklander wrote: > > On Wed, Sep 16, 2020 at 05:27:32PM +0200, Jorge Ramirez-Ortiz wrote: > > > Allow OP-TEE to specify the number of retries in the adaptor. > > > > > >

Re: [PATCH] drivers: optee: i2c: add bus retry configuration

2020-09-23 Thread Jorge Ramirez-Ortiz, Foundries
On 22/09/20, Jens Wiklander wrote: > On Wed, Sep 16, 2020 at 05:27:32PM +0200, Jorge Ramirez-Ortiz wrote: > > Allow OP-TEE to specify the number of retries in the adaptor. > > > > Signed-off-by: Jorge Ramirez-Ortiz > > --- > > drivers/tee/optee/rpc.c |

[PATCH] drivers: optee: i2c: add bus retry configuration

2020-09-16 Thread Jorge Ramirez-Ortiz
Allow OP-TEE to specify the number of retries in the adaptor. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/tee/optee/rpc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/tee/optee/rpc.c b/drivers/tee/optee/rpc.c index 1e3614e4798f..2d46a9ecb1de 100644 --- a/drivers/tee

[PATCHv2] drivers: optee: fix i2c build issue

2020-08-31 Thread Jorge Ramirez-Ortiz
, optee=m i2c=m, optee=y (not supported) Reported-by: kernel test robot Signed-off-by: Jorge Ramirez-Ortiz --- v2: uses IS_REACHABLE instead of macro combination This patch applies on top of https://git.linaro.org/people/jens.wiklander/linux-tee.git/tag/?h=optee-i2c-for-v5.10 drivers

Re: [PATCH] drivers: optee: fix i2c build issue

2020-08-31 Thread Jorge Ramirez-Ortiz, Foundries
On 31/08/20, Randy Dunlap wrote: > On 8/31/20 8:23 AM, Jorge Ramirez-Ortiz wrote: > > When the optee driver is compiled into the kernel while the i2c core > > is configured as a module, the i2c symbols are not available. > > > > This commit addresses the situation b

[PATCH] drivers: optee: fix i2c build issue

2020-08-31 Thread Jorge Ramirez-Ortiz
, optee=m i2c=m, optee=y (not supported) Reported-by: kernel test robot Signed-off-by: Jorge Ramirez-Ortiz --- This patch applies on top of https://git.linaro.org/people/jens.wiklander/linux-tee.git/tag/?h=optee-i2c-for-v5.10 drivers/tee/optee/rpc.c | 2 ++ 1 file changed, 2 insertions

Re: [PATCHv9] drivers: optee: allow op-tee to access devices on the i2c bus

2020-08-21 Thread Jorge Ramirez-Ortiz, Foundries
On 21/08/20, Jens Wiklander wrote: > On Fri, Aug 14, 2020 at 01:12:21PM +0200, Jorge Ramirez-Ortiz wrote: > > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > > control this type of cryptographic devices it needs coordinated access > > to t

[PATCHv9] drivers: optee: allow op-tee to access devices on the i2c bus

2020-08-14 Thread Jorge Ramirez-Ortiz
Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to control this type of cryptographic devices it needs coordinated access to the bus, so collisions and RUNTIME_PM dont get in the way. This trampoline driver allow OP-TEE to access them. Signed-off-by: Jorge Ramirez-Ortiz

Re: [PATCHv8] drivers: optee: allow op-tee to access devices on the i2c bus

2020-08-13 Thread Jorge Ramirez-Ortiz, Foundries
On 13/08/20, Jens Wiklander wrote: > On Wed, Aug 12, 2020 at 02:06:52PM +0200, Jorge Ramirez-Ortiz wrote: > > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > > control this type of cryptographic devices it needs coordinated access > > to t

[PATCHv8] drivers: optee: allow op-tee to access devices on the i2c bus

2020-08-12 Thread Jorge Ramirez-Ortiz
Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to control this type of cryptographic devices it needs coordinated access to the bus, so collisions and RUNTIME_PM dont get in the way. This trampoline driver allow OP-TEE to access them. Signed-off-by: Jorge Ramirez-Ortiz

Re: [PATCHv7] drivers: optee: allow op-tee to access devices on the i2c bus

2020-08-12 Thread Jorge Ramirez-Ortiz, Foundries
On 12/08/20, Jens Wiklander wrote: > On Tue, Aug 11, 2020 at 07:55:31PM +0200, Jorge Ramirez-Ortiz wrote: > > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > > control this type of cryptographic devices it needs coordinated access > > to t

[PATCHv7] drivers: optee: allow op-tee to access devices on the i2c bus

2020-08-11 Thread Jorge Ramirez-Ortiz
Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to control this type of cryptographic devices it needs coordinated access to the bus, so collisions and RUNTIME_PM dont get in the way. This trampoline driver allow OP-TEE to access them. Signed-off-by: Jorge Ramirez-Ortiz

[PATCHv3 1/2] hwrng: optee: handle unlimited data rates

2020-08-06 Thread Jorge Ramirez-Ortiz
Data rates of MAX_UINT32 will schedule an unnecessary one jiffy timeout on the call to msleep. Avoid this scenario by using 0 as the unlimited data rate. Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Sumit Garg --- drivers/char/hw_random/optee-rng.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCHv3 2/2] hwrng: optee: fix wait use case

2020-08-06 Thread Jorge Ramirez-Ortiz
on the first read. Worth noticing that since msleep(0) schedules a one jiffy timeout is better to skip such a call. Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Sumit Garg --- drivers/char/hw_random/optee-rng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char

[PATCHv3 2/2] hwrng: optee: fix wait use case

2020-08-06 Thread Jorge Ramirez-Ortiz
on the first read. Worth noticing that since msleep(0) schedules a one jiffy timeout is better to skip such a call. Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Sumit Garg --- drivers/char/hw_random/optee-rng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-06 Thread Jorge Ramirez-Ortiz, Foundries
On 06/08/20, Sumit Garg wrote: > On Thu, 6 Aug 2020 at 12:00, Jorge Ramirez-Ortiz, Foundries > wrote: > > > > On 06/08/20, Sumit Garg wrote: > > > On Thu, 6 Aug 2020 at 02:08, Jorge Ramirez-Ortiz, Foundries > > > wrote: > > > > > > > &g

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-06 Thread Jorge Ramirez-Ortiz, Foundries
On 06/08/20, Sumit Garg wrote: > On Thu, 6 Aug 2020 at 02:08, Jorge Ramirez-Ortiz, Foundries > wrote: > > > > On 05/08/20, Sumit Garg wrote: > > > Apologies for my delayed response as I was busy with some other tasks > > > along with holidays. > >

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-05 Thread Jorge Ramirez-Ortiz, Foundries
On 05/08/20, Sumit Garg wrote: > Apologies for my delayed response as I was busy with some other tasks > along with holidays. no pb! was just making sure this wasnt falling through some cracks. > > On Fri, 24 Jul 2020 at 19:53, Jorge Ramirez-Ortiz, Foundries > wrote: > > &

Re: [PATCHv6] drivers: optee: allow op-tee to access devices on the i2c bus

2020-08-05 Thread Jorge Ramirez-Ortiz, Foundries
On 05/08/20, Jens Wiklander wrote: > On Wed, Aug 05, 2020 at 03:35:01PM +0200, Jorge Ramirez-Ortiz, Foundries > wrote: > > On 22/07/20, Jorge Ramirez-Ortiz wrote: > > > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > > > control this type of

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-05 Thread Jorge Ramirez-Ortiz, Foundries
On 23/07/20, Jorge Ramirez-Ortiz wrote: > The current code waits for data to be available before attempting a > second read. However the second read would not be executed as the > while loop exits. > > This fix does not wait if all data has been read and reads a second > time if

Re: [PATCHv6] drivers: optee: allow op-tee to access devices on the i2c bus

2020-08-05 Thread Jorge Ramirez-Ortiz, Foundries
On 22/07/20, Jorge Ramirez-Ortiz wrote: > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > control this type of cryptographic devices it needs coordinated access > to the bus, so collisions and RUNTIME_PM dont get in the way. > > This trampoline driv

Re: [PATCHv6] drivers: optee: allow op-tee to access devices on the i2c bus

2020-07-28 Thread Jorge Ramirez-Ortiz, Foundries
On 22/07/20, Jorge Ramirez-Ortiz wrote: > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > control this type of cryptographic devices it needs coordinated access > to the bus, so collisions and RUNTIME_PM dont get in the way. > > This trampoline driv

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-07-28 Thread Jorge Ramirez-Ortiz, Foundries
On 24/07/20, Jorge Ramirez-Ortiz, Foundries wrote: > On 24/07/20, Sumit Garg wrote: > > On Thu, 23 Jul 2020 at 14:16, Jorge Ramirez-Ortiz > > wrote: > > > > > > The current code waits for data to be available before attempting a > > > second read. How

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-07-24 Thread Jorge Ramirez-Ortiz, Foundries
On 24/07/20, Sumit Garg wrote: > On Thu, 23 Jul 2020 at 14:16, Jorge Ramirez-Ortiz wrote: > > > > The current code waits for data to be available before attempting a > > second read. However the second read would not be executed as the > > while loop exits. > >

[PATCHv2 2/2] hwrng: optee: fix wait use case

2020-07-23 Thread Jorge Ramirez-Ortiz
does not attempt to read if not data is requested. Signed-off-by: Jorge Ramirez-Ortiz --- v2: tidy up the while loop to avoid reading when no data is requested drivers/char/hw_random/optee-rng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/hw_random/optee

[PATCHv2 1/2] hwrng: optee: handle unlimited data rates

2020-07-23 Thread Jorge Ramirez-Ortiz
Data rates of MAX_UINT32 will schedule an unnecessary one jiffy timeout on the call to msleep. Avoid this scenario by using 0 as the unlimited data rate. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/char/hw_random/optee-rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCHv6] drivers: optee: allow op-tee to access devices on the i2c bus

2020-07-22 Thread Jorge Ramirez-Ortiz
-by: Jorge Ramirez-Ortiz --- v6: compile out if CONFIG_I2C not enabled v5: alphabetic order of includes v4: remove unnecessary extra line in optee_msg.h v3: use from/to msg param to support all types of memory modify OPTEE_MSG_RPC_CMD_I2C_TRANSFER message id drivers/tee/optee/optee_msg.h

[PATCHv5] drivers: optee: allow op-tee to access devices on the i2c bus

2020-07-22 Thread Jorge Ramirez-Ortiz
Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to control this type of cryptographic devices it needs coordinated access to the bus, so collisions and RUNTIME_PM dont get in the way. This trampoline driver allow OP-TEE to access them. Signed-off-by: Jorge Ramirez-Ortiz

[PATCHv4] drivers: optee: allow op-tee to access devices on the i2c bus

2020-07-22 Thread Jorge Ramirez-Ortiz
Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to control this type of cryptographic devices it needs coordinated access to the bus, so collisions and RUNTIME_PM dont get in the way. This trampoline driver allow OP-TEE to access them. Signed-off-by: Jorge Ramirez-Ortiz

[PATCHv3] drivers: optee: allow op-tee to access devices on the i2c bus

2020-07-22 Thread Jorge Ramirez-Ortiz
Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to control this type of cryptographic devices it needs coordinated access to the bus, so collisions and RUNTIME_PM dont get in the way. This trampoline driver allow OP-TEE to access them. Signed-off-by: Jorge Ramirez-Ortiz

Re: [Tee-dev] [PATCH v2] drivers: optee: allow op-tee to access devices on the i2c bus

2020-06-08 Thread Jorge Ramirez-Ortiz, Foundries
On 08/06/20, Jens Wiklander wrote: > On Mon, Jun 01, 2020 at 09:24:46AM +0200, Jorge Ramirez-Ortiz, Foundries > wrote: > > On 01/06/20, Sumit Garg wrote: > > > Hi Jorge, > > > > hey > > > > > > > > On Mon, 1 Jun 2020 at 04:41, Jorge

Re: [PATCH v2] drivers: optee: allow op-tee to access devices on the i2c bus

2020-06-07 Thread Jorge Ramirez-Ortiz, Foundries
On 01/06/20, Jorge Ramirez-Ortiz wrote: > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > control this type of cryptographic devices it needs coordinated access > to the bus, so collisions and RUNTIME_PM dont get in the way. > > This trampoline driv

Re: [Tee-dev] [PATCH v2] drivers: optee: allow op-tee to access devices on the i2c bus

2020-06-01 Thread Jorge Ramirez-Ortiz, Foundries
On 01/06/20, Sumit Garg wrote: > Hi Jorge, hey > > On Mon, 1 Jun 2020 at 04:41, Jorge Ramirez-Ortiz wrote: > > > > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > > control this type of cryptographic devices it needs coordinated access &g

[PATCH v2] drivers: optee: allow op-tee to access devices on the i2c bus

2020-05-31 Thread Jorge Ramirez-Ortiz
Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to control this type of cryptographic devices it needs coordinated access to the bus, so collisions and RUNTIME_PM dont get in the way. This trampoline driver allow OP-TEE to access them. Signed-off-by: Jorge Ramirez-Ortiz

[PATCH] drivers: optee: allow op-tee to access devices on the i2c bus

2020-05-31 Thread Jorge Ramirez-Ortiz
Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to control this type of cryptographic devices it needs coordinated access to the bus, so collisions and RUNTIME_PM dont get in the way. This trampoline driver allow OP-TEE to access them. Signed-off-by: Jorge Ramirez-Ortiz

[PATCH v2 1/5] misc: fastrpc: add mmap/unmap support

2019-09-16 Thread Jorge Ramirez-Ortiz
Support the allocation/deallocation of buffers mapped to the DSP. When the memory mapped to the DSP at process creation is not enough, the fastrpc library can extend it at runtime. This avoids having to do large preallocations by default. Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Srinivas

[PATCH 5/5] misc: fastrpc: revert max init file size back to 2MB

2019-09-13 Thread Jorge Ramirez-Ortiz
With the integration of the mmap/unmap functionality, it is no longer necessary to allow large memory allocations upfront since they can be handled during runtime. Tested on QCS404 with CDSP Neural Processing test suite. Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Srinivas Kandagatla

[PATCH 0/5] misc: fastrpc: fixes and map/unmap support

2019-09-13 Thread Jorge Ramirez-Ortiz
Hi Greg These patches implement a few fixes identified while working on the QCS404 ML integration plus we now have support for mmap/unmap of buffers (so the process can be created with less initial memory requirements). Jorge Ramirez-Ortiz (4): misc: fastrpc: add mmap/unmap support misc

[PATCH 3/5] misc: fastrpc: do not interrupt kernel calls

2019-09-13 Thread Jorge Ramirez-Ortiz
necessary, this timeout will need to be revisited. Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index bc03500bfe60

[PATCH 4/5] misc: fastrpc: handle interrupted contexts

2019-09-13 Thread Jorge Ramirez-Ortiz
Buffers owned by a context that has been interrupted either by a signal or a timeout might still be being accessed by the DSP. delegate returning the associated memory to a later time when the device is released. Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Srinivas Kandagatla --- drivers

[PATCH 1/5] misc: fastrpc: add mmap/unmap support

2019-09-13 Thread Jorge Ramirez-Ortiz
Support the allocation/deallocation of buffers mapped to the DSP. When the memory mapped to the DSP at process creation is not enough, the fastrpc library can extend it at runtime. This avoids having to do large preallocations by default. Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Srinivas

[PATCH 2/5] misc: fastrpc: fix memory leak from miscdev->name

2019-09-13 Thread Jorge Ramirez-Ortiz
From: Srinivas Kandagatla Fix a memory leak in miscdev->name by using devm_variant Orignally reported by kmemleak: [] kmemleak_alloc+0x50/0x84 [] __kmalloc_track_caller+0xe8/0x168 [] kvasprintf+0x78/0x100 [] kasprintf+0x50/0x74 [] fastrpc_rpmsg_probe+0xd8/0x20c []

[PATCH v2 2/5] clk: qcom: hfpll: register as clock provider

2019-09-12 Thread Jorge Ramirez-Ortiz
Make the output of the high frequency pll a clock provider. On the QCS404 this PLL controls cpu frequency scaling. Co-developed-by: Niklas Cassel Signed-off-by: Niklas Cassel Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bjorn Andersson Acked-by: Stephen Boyd --- drivers/clk/qcom/hfpll.c

[PATCH v2 3/5] clk: qcom: hfpll: CLK_IGNORE_UNUSED

2019-09-12 Thread Jorge Ramirez-Ortiz
k critical and forcing the clock to be always enabled, addresses the above scenario making sure the clock is not disabled but it continues to rely on the firmware to enable the clock. Co-developed-by: Niklas Cassel Signed-off-by: Niklas Cassel Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bjorn

[PATCH v2 0/5] Clock changes to support cpufreq on QCS404

2019-09-12 Thread Jorge Ramirez-Ortiz
The following clock changes are required to enable cpufreq support on the QCS404 v2: sboyd review of v1 --- missing cover letter reorder the patchset use clk_parent data to speficy the parent clock dong ignore the clock position abi Jorge Ramirez-Ortiz (5

[PATCH v2 5/5] clk: qcom: apcs-msm8916: get parent clock names from DT

2019-09-12 Thread Jorge Ramirez-Ortiz
Signed-off-by: Niklas Cassel Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bjorn Andersson --- drivers/clk/qcom/apcs-msm8916.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/apcs-msm8916.c b/drivers/clk/qcom/apcs-msm8916.c index a6c89a310b18

[PATCH v2 4/5] clk: qcom: hfpll: use clk_parent_data to specify the parent

2019-09-12 Thread Jorge Ramirez-Ortiz
Extend support to platorms using different parents. Co-developed-by: Niklas Cassel Signed-off-by: Niklas Cassel Signed-off-by: Jorge Ramirez-Ortiz --- drivers/clk/qcom/hfpll.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/qcom/hfpll.c b/drivers/clk/qcom

[PATCH v2 1/5] clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency

2019-09-12 Thread Jorge Ramirez-Ortiz
Limit the GPLL0_AO_OUT_MAIN operating frequency as per its hardware specifications. Co-developed-by: Niklas Cassel Signed-off-by: Niklas Cassel Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bjorn Andersson Acked-by: Stephen Boyd --- drivers/clk/qcom/clk-alpha-pll.c | 8 drivers

Re: [PATCH 1/2] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-12 Thread Jorge Ramirez-Ortiz, Linaro
On 10/09/19 11:06:55, Guenter Roeck wrote: > On Fri, Sep 06, 2019 at 10:54:10PM +0200, Jorge Ramirez-Ortiz wrote: > > Use the bark interrupt as the pre-timeout notifier whenever this > > interrupt is available. > > > > By default, the pretimeout notification sha

Re: [PATCH 2/5] clk: qcom: apcs-msm8916: get parent clock names from DT

2019-09-10 Thread Jorge Ramirez
On 9/10/19 11:34, Jorge Ramirez wrote: > On 9/10/19 11:14, Stephen Boyd wrote: >> Quoting Jorge Ramirez-Ortiz, Linaro (2019-09-09 09:54:08) >>> On 09/09/19 09:17:03, Stephen Boyd wrote: >>>> But now the binding is different for the same compatible. I'd prefer w

Re: [PATCH 2/5] clk: qcom: apcs-msm8916: get parent clock names from DT

2019-09-10 Thread Jorge Ramirez
On 9/10/19 11:14, Stephen Boyd wrote: > Quoting Jorge Ramirez-Ortiz, Linaro (2019-09-09 09:54:08) >> On 09/09/19 09:17:03, Stephen Boyd wrote: >>> But now the binding is different for the same compatible. I'd prefer we >>> keep using devm_clk_get() and use a devi

Re: [PATCH 2/5] clk: qcom: apcs-msm8916: get parent clock names from DT

2019-09-09 Thread Jorge Ramirez-Ortiz, Linaro
On 09/09/19 09:17:03, Stephen Boyd wrote: > Quoting Jorge Ramirez-Ortiz, Linaro (2019-09-09 07:17:40) > > On 09/09/19 03:21:16, Stephen Boyd wrote: > > > Quoting Jorge Ramirez-Ortiz (2019-08-26 09:45:07) > > > > @@ -76,10 +88,11 @@ static int qcom

Re: [PATCH 2/5] clk: qcom: apcs-msm8916: get parent clock names from DT

2019-09-09 Thread Jorge Ramirez-Ortiz, Linaro
On 09/09/19 03:21:16, Stephen Boyd wrote: > Quoting Jorge Ramirez-Ortiz (2019-08-26 09:45:07) > > @@ -76,10 +88,11 @@ static int qcom_apcs_msm8916_clk_probe(struct > > platform_device *pdev) > > a53cc->src_shift = 8; > > a53cc->parent_map = gpll0_a

[PATCH v2] mailbox: qcom-apcs: fix max_register value

2019-09-09 Thread Jorge Ramirez-Ortiz
The mailbox length is 0x1000 hence the max_register value is 0xFFC. Fixes: c6a8b171ca8e ("mailbox: qcom: Convert APCS IPC driver to use regmap") Signed-off-by: Jorge Ramirez-Ortiz --- v2: added Fixes tag drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 +- 1 file changed, 1 inser

[PATCH v2] clk: qcom: fix QCS404 TuringCC regmap

2019-09-09 Thread Jorge Ramirez-Ortiz
The max register is 0x23004 as per the manual (the current max_register that this commit is fixing is actually out of bounds). Fixes: 892df0191b29 ("clk: qcom: Add QCS404 TuringCC") Signed-off-by: Jorge Ramirez-Ortiz --- v2: add Fixes tag drivers/clk/qcom/turingcc-qcs404.c | 2

[PATCH] mailbox: qcom-apcs: fix max_register value

2019-09-09 Thread Jorge Ramirez-Ortiz
The mailbox length is 0x1000 hence the max_register value is 0xFFC. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc

[PATCH] clk: qcom: fix QCS404 TuringCC regmap

2019-09-06 Thread Jorge Ramirez-Ortiz
The max register is 0x23004 as per the manual (the current max_register that this commit is fixing is actually out of bounds). Signed-off-by: Jorge Ramirez-Ortiz --- drivers/clk/qcom/turingcc-qcs404.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/turingcc

[PATCH 1/2] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-06 Thread Jorge Ramirez-Ortiz
Use the bark interrupt as the pre-timeout notifier whenever this interrupt is available. By default, the pretimeout notification shall occur one second earlier than the timeout. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/watchdog/qcom-wdt.c | 70 ++--- 1

[PATCH 2/2] watchdog: qcom: remove unnecessary variable from private storage

2019-09-06 Thread Jorge Ramirez-Ortiz
there is no need to continue keeping the clock in private storage. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/watchdog/qcom-wdt.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c index 935c78a882a3

[PATCH 0/2] qcom_wdt bark irq support

2019-09-06 Thread Jorge Ramirez-Ortiz
remove unecessary variable from the driver's private storage v2: register the pre-timeout notifier. With the second patch in the set, I took the oportunity to do some cleanup in the same code base removing an unnecesary variable from the driver's private storage. Jorge Ramirez-Ortiz (2

[PATCH 2/2] watchdog: pm8916_wdt: fix missing include

2019-09-06 Thread Jorge Ramirez-Ortiz
As per Documentation/process/submit-checklist.rst, when using a facility #include the file that defines/declares that facility. Don't depend on other header files pulling in ones that you use. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/watchdog/pm8916_wdt.c | 1 + 1 file changed, 1

[PATCH 1/2] watchdog: pm8916_wdt: fix pretimeout registration flow

2019-09-06 Thread Jorge Ramirez-Ortiz
When an IRQ is present in the dts, the probe function shall fail if the interrupt can not be registered. The probe function shall also be retried if getting the irq is being deferred. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/watchdog/pm8916_wdt.c | 16 1 file changed, 12

Re: [PATCH v4] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-06 Thread Jorge Ramirez
On 9/6/19 19:40, Bjorn Andersson wrote: > On Thu 05 Sep 14:00 PDT 2019, Jorge Ramirez-Ortiz wrote: >> diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c > [..] >> +static inline int qcom_get_enable(struct watchdog_device *wdd) >> +{ >> +

Re: [PATCH v4] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-06 Thread Jorge Ramirez
>>> static const u32 reg_offset_data_apcs_tmr[] = { [WDT_RST] = 0x38, [WDT_EN] = 0x40, @@ -54,15 +58,38 @@ struct qcom_wdt *to_qcom_wdt(struct watchdog_device *wdd) return container_of(wdd, struct qcom_wdt, wdd); } +static inline int

Re: [PATCH v4] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-05 Thread Jorge Ramirez
On 9/5/19 23:19, Guenter Roeck wrote: > On Thu, Sep 05, 2019 at 11:00:35PM +0200, Jorge Ramirez-Ortiz wrote: >> Use the bark interrupt as the pre-timeout notifier whenever this >> interrupt is available. >> >> By default, the pretimeout notification shall occur

[PATCH v4] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-05 Thread Jorge Ramirez-Ortiz
Use the bark interrupt as the pre-timeout notifier whenever this interrupt is available. By default, the pretimeout notification shall occur one second earlier than the timeout. Signed-off-by: Jorge Ramirez-Ortiz --- v4: address Guenter Roeck comments as follows: remove unnecessary

Re: [PATCH v3] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-05 Thread Jorge Ramirez
On 9/5/19 20:34, Guenter Roeck wrote: > On Thu, Sep 05, 2019 at 08:24:19PM +0200, Jorge Ramirez-Ortiz wrote: >> Use the bark interrupt as the pre-timeout notifier whenever this >> interrupt is available. >> >> By default, the pretimeout notification shall occur

[PATCH v3] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-05 Thread Jorge Ramirez-Ortiz
Use the bark interrupt as the pre-timeout notifier whenever this interrupt is available. By default, the pretimeout notification shall occur one second earlier than the timeout. Signed-off-by: Jorge Ramirez-Ortiz --- v3: remove unnecesary variable added to private. v2: register

[PATCH v2] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-05 Thread Jorge Ramirez-Ortiz
Use the bark interrupt as the pre-timeout notifier whenever this interrupt is available. By default, the pretimeout notification shall occur one second earlier than the timeout. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/watchdog/qcom-wdt.c | 63 ++--- 1

[no subject]

2019-09-05 Thread Jorge Ramirez-Ortiz
Use the bark interrupt as the pre-timeout notifier whenever this interrupt is available. By default, the pretimeout notification shall occur one second earlier than the timeout. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/watchdog/qcom-wdt.c | 63 ++--- 1

Re: [PATCH] watchdog: qcom: add support for the bark interrupt

2019-09-05 Thread Jorge Ramirez
On 9/5/19 18:39, Bjorn Andersson wrote: > On Thu 05 Sep 09:21 PDT 2019, Jorge Ramirez-Ortiz wrote: > >> Use the bark interrupt to notify the bark event. Since the bark and bite >> timeouts are identical, increase the bite timeout by one second so >> that the

[PATCH] watchdog: qcom: add support for the bark interrupt

2019-09-05 Thread Jorge Ramirez-Ortiz
Use the bark interrupt to notify the bark event. Since the bark and bite timeouts are identical, increase the bite timeout by one second so that the bark event can be logged to the console. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/watchdog/qcom-wdt.c | 42

Re: [PATCH 1/5] clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency

2019-09-05 Thread Jorge Ramirez
On 8/26/19 18:45, Jorge Ramirez-Ortiz wrote: > Limit the GPLL0_AO_OUT_MAIN operating frequency as per its hardware > specifications. > > Co-developed-by: Niklas Cassel > Signed-off-by: Niklas Cassel > Signed-off-by: Jorge Ramirez-Ortiz > Reviewed-by: Bjorn Andersson >

Re: [PATCH 1/6] dt-bindings: mailbox: qcom: Add clock-name optional property

2019-09-05 Thread Jorge Ramirez
On 8/26/19 18:48, Jorge Ramirez-Ortiz wrote: > When the APCS clock is registered (platform dependent), it retrieves > its parent names from hardcoded values in the driver. > > The following commit allows the DT node to provide such clock names to > the platform data based clock d

Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings

2019-09-05 Thread Jorge Ramirez
On 9/4/19 01:34, Bjorn Andersson wrote: > On Tue 03 Sep 14:45 PDT 2019, Stephen Boyd wrote: > >> Quoting Jack Pham (2019-09-03 10:39:24) >>> On Mon, Sep 02, 2019 at 08:23:04AM +0200, Jorge Ramirez wrote: >>>> On 8/30/19 20:28, Stephen Boyd wrote: >>>>&

Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings

2019-09-02 Thread Jorge Ramirez
On 8/30/19 20:28, Stephen Boyd wrote: > Quoting Bjorn Andersson (2019-08-30 09:45:20) >> On Fri 30 Aug 09:01 PDT 2019, Stephen Boyd wrote: >> >>> Quoting Jorge Ramirez (2019-08-29 00:03:48) >>>> On 2/23/19 17:52, Bjorn Andersson wrote: >>>>> On T

[PATCH 2/2] arm64: dts: qcom: qcs404: add the watchdog node

2019-08-29 Thread Jorge Ramirez-Ortiz
Allows QCS404 based designs to enable watchdog support Signed-off-by: Jorge Ramirez-Ortiz --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi index 131d8046d3be

[PATCH 1/2] arm64: dts: qcom: qcs404: add sleep clk fixed rate oscillator

2019-08-29 Thread Jorge Ramirez-Ortiz
This fixed rate clock is required for the operation of some devices (ie watchdog). Signed-off-by: Jorge Ramirez-Ortiz --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi

Re: [PATCH 1/2] mbox: qcom: add APCS child device for QCS404

2019-08-29 Thread Jorge Ramirez
On 8/29/19 00:31, Stephen Boyd wrote: > Quoting Jorge Ramirez-Ortiz (2019-08-26 09:46:24) >> There is clock controller functionality in the APCS hardware block of >> qcs404 devices similar to msm8916. >> >> Co-developed-by: Niklas Cassel >> Signed-off-by: Nikla

[PATCH v2 2/2] mbox: qcom: replace integer with valid macro

2019-08-29 Thread Jorge Ramirez-Ortiz
Use the correct macro when registering the platform device. Co-developed-by: Niklas Cassel Signed-off-by: Niklas Cassel Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bjorn Andersson --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH v2 1/2] mbox: qcom: add APCS child device for QCS404

2019-08-29 Thread Jorge Ramirez-Ortiz
There is clock controller functionality in the APCS hardware block of qcs404 devices similar to msm8916. Co-developed-by: Niklas Cassel Signed-off-by: Niklas Cassel Signed-off-by: Jorge Ramirez-Ortiz --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH v2 0/2] mbox changes for QCS404 DVFS

2019-08-29 Thread Jorge Ramirez-Ortiz
These are the mailbox changes required to enable CPU frequency scaling on Qualcomm's QCS404. v2: sboyd review replace if statement with a of_match_device dont modify platform_set_drvdata Jorge Ramirez-Ortiz (2): mbox: qcom: add APCS child device for QCS404 mbox: qcom: replace integer

Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings

2019-08-29 Thread Jorge Ramirez
On 2/23/19 17:52, Bjorn Andersson wrote: > On Thu 07 Feb 03:17 PST 2019, Jorge Ramirez-Ortiz wrote: > >> Binding description for Qualcomm's Synopsys 1.0.0 SuperSpeed phy >> controller embedded in QCS404. >> >> Based on Sriharsha Allenki's original >> def

Re: [PATCH 4/5] misc: fastrpc: fix double refcounting on dmabuf

2019-08-28 Thread Jorge Ramirez
On 8/28/19 10:48, Srinivas Kandagatla wrote: > > > On 28/08/2019 08:50, Jorge Ramirez wrote: >> On 8/27/19 23:45, Srinivas Kandagatla wrote: >>> On 23/08/2019 16:23, Jorge Ramirez-Ortiz wrote: >>>> can you add me as a co-author to this patch please? >>

Re: [PATCH 4/5] misc: fastrpc: fix double refcounting on dmabuf

2019-08-28 Thread Jorge Ramirez
On 8/27/19 23:45, Srinivas Kandagatla wrote: > > On 23/08/2019 16:23, Jorge Ramirez-Ortiz wrote: >> can you add me as a co-author to this patch please? > > No problem I can do that if you feel so! yes please. thanks! > >> since I spent about a day doing th

Re: [PATCH v4 00/13] Support CPU frequency scaling on QCS404

2019-08-26 Thread Jorge Ramirez
On 8/26/19 08:54, Jorge Ramirez wrote: > On 7/31/19 22:29, Jorge Ramirez-Ortiz wrote: >> The following patchset enables CPU frequency scaling support on the >> QCS404 (with dynamic voltage scaling). >> >> It is important to notice that this functionality will be

[PATCH 3/6] arm64: dts: qcom: qcs404: Add HFPLL node

2019-08-26 Thread Jorge Ramirez-Ortiz
The high frequency pll functionality is required to enable CPU frequency scaling operation. Co-developed-by: Niklas Cassel Signed-off-by: Niklas Cassel Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 9 + 1 file changed, 9

[PATCH 5/6] arm64: dts: qcom: qcs404: Add DVFS support

2019-08-26 Thread Jorge Ramirez-Ortiz
- the following commit will need to be reverted to enable CPUFreq support Author: Jorge Ramirez-Ortiz Date: Thu Jul 25 12:41:36 2019 +0200 cpufreq: Add qcs404 to cpufreq-dt-platdev blacklist Co-developed-by: Niklas Cassel Signed-off-by: Niklas Cassel Signed-off-by: Jorge Ramirez-Ortiz

[PATCH 6/6] arm64: defconfig: Enable HFPLL

2019-08-26 Thread Jorge Ramirez-Ortiz
The high frequency pll is required on compatible Qualcomm SoCs to support the CPU frequency scaling feature. Co-developed-by: Niklas Cassel Signed-off-by: Niklas Cassel Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bjorn Andersson --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1

[PATCH 1/6] dt-bindings: mailbox: qcom: Add clock-name optional property

2019-08-26 Thread Jorge Ramirez-Ortiz
in the clock driver source code. Co-developed-by: Niklas Cassel Signed-off-by: Niklas Cassel Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Rob Herring Reviewed-by: Bjorn Andersson --- .../mailbox/qcom,apcs-kpss-global.txt | 24 --- 1 file changed, 21 insertions(+), 3

[PATCH 4/6] arm64: dts: qcom: qcs404: Add the clocks for APCS mux/divider

2019-08-26 Thread Jorge Ramirez-Ortiz
Specify the clocks that feed the APCS mux/divider instead of using default hardcoded values in the source code. Co-developed-by: Niklas Cassel Signed-off-by: Niklas Cassel Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 3 +++ 1 file

[PATCH 2/6] arm64: dts: qcom: msm8916: Add the clocks for the APCS mux/divider

2019-08-26 Thread Jorge Ramirez-Ortiz
node. Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index 5ea9fb8f2f87..96dc7a12aa94

[PATCH 1/2] mbox: qcom: add APCS child device for QCS404

2019-08-26 Thread Jorge Ramirez-Ortiz
There is clock controller functionality in the APCS hardware block of qcs404 devices similar to msm8916. Co-developed-by: Niklas Cassel Signed-off-by: Niklas Cassel Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bjorn Andersson --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 8 +--- 1

[PATCH 2/2] mbox: qcom: replace integer with valid macro

2019-08-26 Thread Jorge Ramirez-Ortiz
Use the correct macro when registering the platform device. Co-developed-by: Niklas Cassel Signed-off-by: Niklas Cassel Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bjorn Andersson --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

  1   2   3   4   >