Re: [PATCH v3 18/24] wfx: add data_tx.c/data_tx.h

2020-12-22 Thread Kalle Valo
Jerome Pouiller writes: > +static bool ieee80211_is_action_back(struct ieee80211_hdr *hdr) > +{ > + struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)hdr; > + > + if (!ieee80211_is_action(mgmt->frame_control)) > + return false; > + if (mgmt->u.action.category !=

Re: [PATCH v3 00/24] wfx: get out from the staging area

2020-12-22 Thread Kalle Valo
Jerome Pouiller writes: > From: Jérôme Pouiller > > I think the wfx driver is now mature enough to be accepted in the > drivers/net/wireless directory. What's the status with firmware images? Can anyone take the latest kernel and linux-firmware and use this driver normally? --

Re: [PATCH v3 12/24] wfx: add hif_api_*.h

2020-12-22 Thread Kalle Valo
Jerome Pouiller writes: > --- /dev/null > +++ b/drivers/net/wireless/silabs/wfx/hif_api_general.h > @@ -0,0 +1,267 @@ > +/* SPDX-License-Identifier: Apache-2.0 */ > +/* > + * WFx hardware interface definitions > + * > + * Copyright (c) 2018-2020, Silicon Laboratories Inc. > + */ > + > +#ifndef

Re: [PATCH v3 09/24] wfx: add hwio.c/hwio.h

2020-12-22 Thread Kalle Valo
Jerome Pouiller writes: > +/* > + * Internal helpers. > + * > + * About CONFIG_VMAP_STACK: > + * When CONFIG_VMAP_STACK is enabled, it is not possible to run DMA on stack > + * allocated data. Functions below that work with registers (aka functions > + * ending with "32") automatically

Re: [PATCH v3 05/24] wfx: add main.c/main.h

2020-12-22 Thread Kalle Valo
Jerome Pouiller writes: > From: Jérôme Pouiller > > Signed-off-by: Jérôme Pouiller [...] > +static const struct ieee80211_supported_band wfx_band_2ghz = { > + .channels = wfx_2ghz_chantable, > + .n_channels = ARRAY_SIZE(wfx_2ghz_chantable), > + .bitrates = wfx_rates, > +

Re: [PATCH v3 03/24] wfx: add Makefile/Kconfig

2020-12-22 Thread Kalle Valo
Jerome Pouiller writes: > From: Jérôme Pouiller > > Signed-off-by: Jérôme Pouiller > --- > drivers/net/wireless/silabs/wfx/Kconfig | 8 > drivers/net/wireless/silabs/wfx/Makefile | 25 > 2 files changed, 33 insertions(+) > create mode 100644

Re: [PATCH v3 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip

2020-12-22 Thread Kalle Valo
Jerome Pouiller writes: > From: Jérôme Pouiller > > Add Silabs SDIO ID to sdio_ids.h. > > Note that the values used by Silabs are uncommon. A driver cannot fully > rely on the SDIO PnP. It should also check if the device is declared in > the DT. > > Signed-off-by: Jérôme Pouiller > --- >

Re: [PATCH v3 03/24] wfx: add Makefile/Kconfig

2020-12-22 Thread Kalle Valo
Jerome Pouiller writes: > From: Jérôme Pouiller > > Signed-off-by: Jérôme Pouiller [...] > +wfx-$(CONFIG_SPI) += bus_spi.o > +wfx-$(subst m,y,$(CONFIG_MMC)) += bus_sdio.o Why this subst? And why only for MMC? -- https://patchwork.kernel.org/project/linux-wireless/list/

Re: [PATCH -next] scsi: megaraid: Remove unnecessary memset

2020-12-22 Thread Kalle Valo
Zheng Yongjun writes: > memcpy operation is next to memset code, and the size to copy is equals to > the size to > memset, so the memset operation is unnecessary, remove it. > > Signed-off-by: Zheng Yongjun > --- > drivers/net/wireless/ath/wcn36xx/smd.c | 1 - > 1 file changed, 1 deletion(-)

Re: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery

2020-12-21 Thread Kalle Valo
Rakesh Pillai writes: > This patch series includes some fixes when the device > is in recovery mode, i.e. when the firmware goes down. > > - Pausing TX queues when FW goes down > - Removed unwanted/extra error logging in pkt TX path > - Skipping wait for FW response for delete cmds > - Handling

Re: [PATCH] net: ath10k: santity check for ep connectivity

2020-12-21 Thread Kalle Valo
Zekun Shen writes: > Function ep_rx_complete is being called without NULL checking > in ath10k_htc_rx_completion_handler. Without such check, mal- > formed packet is able to cause jump to NULL. > > ep->service_id seems a good candidate for sanity check as it is > used in usb.c. > >

Re: [PATCH] [v11] wireless: Initial driver submission for pureLiFi STA devices

2020-12-20 Thread Kalle Valo
Srinivasan Raju writes: >> I see lots of magic numbers in the driver like 2, 0x33 and 0x34 here. >> Please convert the magic numbers to proper defines explaining the >> meaning. And for vendor commands you could even use enum to group >> them better in .h file somewhere. > > Hi Kalle, > > Thanks

Re: [-next] mt76: mt7915: fix MESH ifdef block

2020-12-20 Thread Kalle Valo
c debugfs knob") > Signed-off-by: Randy Dunlap > Cc: Shayne Chen > Cc: Ryder Lee > Cc: Lorenzo Bianconi > Cc: Felix Fietkau > Cc: linux-wirel...@vger.kernel.org > Cc: Kalle Valo Patch applied to wireless-drivers.git, thanks. 0bd157fa2aaa mt76: mt7915: fix MESH ifde

Re: [PATCH] [v7] wireless: Initial driver submission for pureLiFi STA devices

2020-12-19 Thread Kalle Valo
Srinivasan Raju writes: >> What will be the directory structure in linux-firmware? It should be >> unique so that it's not possible to mix with other drivers. > > I have created the following directory structure, Please let me know if this > is OK. > > LICENCE.purelifi_firmware | 29

Re: [PATCH] [v11] wireless: Initial driver submission for pureLiFi STA devices

2020-12-19 Thread Kalle Valo
Srinivasan Raju writes: > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC > and LiFi-XL USB devices. > > This driver implementation has been based on the zd1211rw driver. > > Driver is based on 802.11 softMAC Architecture and uses > native 802.11 for configuration and management. >

Re: [PATCH] [v11] wireless: Initial driver submission for pureLiFi STA devices

2020-12-19 Thread Kalle Valo
Srinivasan Raju writes: > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC > and LiFi-XL USB devices. > > This driver implementation has been based on the zd1211rw driver. > > Driver is based on 802.11 softMAC Architecture and uses > native 802.11 for configuration and management. >

Re: [PATCH] [v11] wireless: Initial driver submission for pureLiFi STA devices

2020-12-19 Thread Kalle Valo
Srinivasan Raju writes: > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC > and LiFi-XL USB devices. > > This driver implementation has been based on the zd1211rw driver. > > Driver is based on 802.11 softMAC Architecture and uses > native 802.11 for configuration and management. >

Re: [PATCH -next] net: wireless/mediatek/mt7915: fix MESH ifdef block

2020-12-18 Thread Kalle Valo
Randy Dunlap writes: > On 12/18/20 10:48 AM, Kalle Valo wrote: >> Randy Dunlap writes: >> >>> Fix a build error when CONFIG_MAC80211_MESH is not enabled: >>> >>> ../drivers/net/wireless/mediatek/mt76/mt7915/init.c:47:2: error

Re: [PATCH -next] net: wireless/mediatek/mt7915: fix MESH ifdef block

2020-12-18 Thread Kalle Valo
c debugfs knob") > Signed-off-by: Randy Dunlap > Cc: Shayne Chen > Cc: Ryder Lee > Cc: Lorenzo Bianconi > Cc: Felix Fietkau > Cc: linux-wirel...@vger.kernel.org > Cc: Kalle Valo Thanks, but why -next? I would rather queue this to wireless-drivers for

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_config_scan

2020-12-17 Thread Kalle Valo
Brian Norris writes: > On Tue, Dec 8, 2020 at 7:14 AM Xiaohui Zhang wrote: >> >> From: Zhang Xiaohui >> >> mwifiex_config_scan() calls memcpy() without checking >> the destination size may trigger a buffer overflower, >> which a local user could use to cause denial of service >> or the

Re: [PATCH v2] ath10k: Remove voltage regulator votes during wifi disable

2020-12-16 Thread Kalle Valo
wer on/off in SNOC targets, so that these voltage > regulator votes are there only when wlan is enabled. > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > Signed-off-by: Rakesh Pillai > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git,

Re: [PATCH] ath10k: Fix error handling in case of CE pipe init failure

2020-12-16 Thread Kalle Valo
45af5b264f ("ath10k: enable SRRI/DRRI support on ddr for WCN3990") > Signed-off-by: Rakesh Pillai > Reviewed-by: Brian Norris > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 31561e8557cd ath10k: Fix error handling in case of CE pipe init failure

Re: [PATCH][next] ath11k: add missing null check on allocated skb

2020-12-16 Thread Kalle Valo
Fixes: 43ed15e1ee01 ("ath11k: put hw to DBS using WMI_PDEV_SET_HW_MODE_CMDID") > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-current branch of ath.git, thanks. 292bff9480c8 ath11k: add missing null check on allocated skb -- https://patch

Re: [PATCH][next] ath11k: add missing null check on allocated skb

2020-12-16 Thread Kalle Valo
Kalle Valo writes: > Colin King wrote: > >> Currently the null check on a newly allocated skb is missing and >> this can lead to a null pointer dereference is the allocation fails. >> Fix this by adding a null check and returning -ENOMEM. >> >> Addresses

Re: [PATCH][next] ath11k: add missing null check on allocated skb

2020-12-16 Thread Kalle Valo
Fixes: 43ed15e1ee01 ("ath11k: put hw to DBS using WMI_PDEV_SET_HW_MODE_CMDID") > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-current branch of ath.git, thanks. c86a36a621f2 ath11k: add missing null check on allocated skb -- https://patch

Re: [PATCH wireless -next] brcmfmac: Delete useless kfree code

2020-12-16 Thread Kalle Valo
Zheng Yongjun writes: > The parameter of kfree function is NULL, so kfree code is useless, delete it. > Therefore, goto expression is no longer needed, so simplify it. > > Signed-off-by: Zheng Yongjun > --- > .../net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 9 - > 1 file

Re: [RESEND PATCH] ath11k: use MHI provided APIs to allocate and free MHI controller

2020-12-11 Thread Kalle Valo
ivam > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 57449b07eafc ath11k: use MHI provided APIs to allocate and free MHI controller -- https://patchwork.kernel.org/project/linux-wireless/patch/1605634436-36506-1-git-send-email-bbh...@codeaurora.org/ https://wir

Re: [PATCH v3] ath10k: add option for chip-id based BDF selection

2020-12-11 Thread Kalle Valo
t; board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320' > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1 > Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1 > Signed-off-by: Abhishek Kumar > Reviewed-by: Douglas Anderson > Reviewed-by: Rakesh Pillai

Re: mt76: remove unused variable q

2020-12-11 Thread Kalle Valo
Souptick Joarder wrote: > Kernel test robot reported warning: > >drivers/net/wireless/mediatek/mt76/tx.c: In function > 'mt76_txq_schedule': > >> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q' > >> set but not used [-Wunused-but-set-variable] > 499 | struct

Re: [PATCH][next] iwlwifi: mvm: Fix fall-through warnings for Clang

2020-12-11 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly using the fallthrough pseudo-keyword as a > replacement for a number of "fall through" markings. > > Notice that Clang doesn't recognize "fall through" comments as >

Re: [PATCH 02/17] iwlwifi: mvm: rs: Demote non-conformant function documentation headers

2020-12-11 Thread Kalle Valo
_sta' not described in 'rs_program_fix_rate' > drivers/net/wireless/intel/iwlwifi/mvm/rs.c:4213: warning: Function > parameter or member 'mvm' not described in 'iwl_mvm_tx_protection' > > Cc: Johannes Berg > Cc: Emmanuel Grumbach > Cc: Luca Coelho > Cc: Intel Linux Wire

Re: [PATCH 091/141] iwlwifi: iwl-drv: Fix fall-through warnings for Clang

2020-12-11 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a > warning by replacing a /* fall through */ comment with the new > pseudo-keyword macro fallthrough; instead of letting the code fall > through to the next case. > > Notice that Clang doesn't

Re: [PATCH][next] iwlwifi: dvm: Fix fall-through warnings for Clang

2020-12-11 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly using the fallthrough pseudo-keyword as a > replacement for a number of "fall through" markings. > > Notice that Clang doesn't recognize "fall through" comments as >

Re: [PATCH wireless -next] cw1200: txrx: convert comma to semicolon

2020-12-10 Thread Kalle Valo
Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Patch applied to wireless-drivers-next.git, thanks. c42d492c672a cw1200: txrx: convert comma to semicolon --

Re: [PATCH wireless -next] wireless/ath10k: simplify the return expression of ath10k_ahb_chip_reset()

2020-12-10 Thread Kalle Valo
Zheng Yongjun writes: > Simplify the return expression. > > Signed-off-by: Zheng Yongjun > --- > drivers/net/wireless/ath/ath10k/ahb.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/ahb.c >

Re: [PATCH] mt76: Fixed kernel test robot warning

2020-12-09 Thread Kalle Valo
Souptick Joarder writes: > Kernel test robot throws below warning -> > >drivers/net/wireless/mediatek/mt76/tx.c: In function > 'mt76_txq_schedule': >>> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q' >>> set but not used [-Wunused-but-set-variable] > 499 | struct

Re: [PATCH wireless] iwlwifi: fw: simplify the iwl_fw_dbg_collect_trig()

2020-12-09 Thread Kalle Valo
Zheng Yongjun writes: > Simplify the return expression. > > Signed-off-by: Zheng Yongjun > --- > drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c >

Re: [PATCH] PCI: Remove pci_try_set_mwi

2020-12-09 Thread Kalle Valo
> drivers/net/wireless/intersil/p54/p54pci.c| 2 +- > .../intersil/prism54/islpci_hotplug.c | 3 +-- > .../wireless/realtek/rtl818x/rtl8180/dev.c| 2 +- For drivers/wireless: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ http

Re: [PATCH 069/141] ath5k: Fix fall-through warnings for Clang

2020-12-08 Thread Kalle Valo
-off-by: Gustavo A. R. Silva > Signed-off-by: Kalle Valo 3 patches applied to ath-next branch of ath.git, thanks. e64fa6d92ac4 ath5k: Fix fall-through warnings for Clang e2cb11165445 carl9170: Fix fall-through warnings for Clang b6041e1a3020 wcn36xx: Fix fall-through warnings for Clang -

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_uap_bss_param_prepare

2020-12-08 Thread Kalle Valo
Xiaohui Zhang writes: > From: Zhang Xiaohui > > mwifiex_uap_bss_param_prepare() calls memcpy() without checking > the destination size may trigger a buffer overflower, > which a local user could use to cause denial of service or the > execution of arbitrary code. > Fix it by putting the length

Re: [PATCH] [v11] wireless: Initial driver submission for pureLiFi STA devices

2020-12-08 Thread Kalle Valo
Srinivasan Raju writes: > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC > and LiFi-XL USB devices. > > This driver implementation has been based on the zd1211rw driver. > > Driver is based on 802.11 softMAC Architecture and uses > native 802.11 for configuration and management. >

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_config_scan

2020-12-08 Thread Kalle Valo
Xiaohui Zhang writes: > From: Zhang Xiaohui > > mwifiex_config_scan() calls memcpy() without checking > the destination size may trigger a buffer overflower, > which a local user could use to cause denial of service > or the execution of arbitrary code. > Fix it by putting the length check

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_uap_bss_param_prepare

2020-12-08 Thread Kalle Valo
Xiaohui Zhang writes: > From: Zhang Xiaohui > > mwifiex_uap_bss_param_prepare() calls memcpy() without checking > the destination size may trigger a buffer overflower, > which a local user could use to cause denial of service or the > execution of arbitrary code. > Fix it by putting the length

Re: linux-next: build failure after merge of the wireless-drivers-next tree

2020-12-08 Thread Kalle Valo
Stephen Rothwell writes: > After merging the wireless-drivers-next tree, today's linux-next build > (powerpc allyesconfig) failed like this: > > ld: drivers/net/wireless/realtek/rtw88/rtw8822ce.o:(.rodata.rtw_pm_ops+0x0): > multiple definition of `rtw_pm_ops'; >

Re: [PATCH 065/141] airo: Fix fall-through warnings for Clang

2020-12-08 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH v3] ath10k: add option for chip-id based BDF selection

2020-12-07 Thread Kalle Valo
t; board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320' > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1 > Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1 > Signed-off-by: Abhishek Kumar > Reviewed-by: Douglas Anderson > Reviewed-by: Rakesh Pillai &

Re: [PATCH] net: carl9170: remove trailing semicolon in macro definition

2020-12-07 Thread Kalle Valo
t...@redhat.com wrote: > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. e65e8b608f68 carl9170: remove trailing semicolon in macro definition -- https://patchwork.kernel

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_cmd_802_11_ad_hoc_start

2020-12-07 Thread Kalle Valo
Xiaohui Zhang wrote: > From: Zhang Xiaohui > > mwifiex_cmd_802_11_ad_hoc_start() calls memcpy() without checking > the destination size may trigger a buffer overflower, > which a local user could use to cause denial of service > or the execution of arbitrary code. > Fix it by putting the

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-12-07 Thread Kalle Valo
Bjorn Andersson writes: > On Tue 03 Nov 01:48 CST 2020, Amit Pundir wrote: > >> Hi Rob, Bjorn, Kalle, >> >> On Thu, 29 Oct 2020 at 19:10, Bjorn Andersson >> wrote: >> > >> > On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote: >> > >> > > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir

Re: brcmfmac: remove redundant assignment to pointer 'entry'

2020-12-07 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > The pointer 'entry' is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian

Re: [PATCH wireless] adm8211: fix error return code in adm8211_probe()

2020-12-07 Thread Kalle Valo
Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: cc0b88cf5ecf ("[PATCH] Add adm8211 802.11b wireless driver") > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong Patch applied to

Re: [PATCH][next] rtw88: coex: fix missing unitialization of variable 'interval'

2020-12-07 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > Currently the variable 'interval' is not initialized and is only set > to 1 when oex_stat->bt_418_hid_existi is true. Fix this by inintializing > variable interval to 0 (which I'm assuming is the intended default). > > Addresses-Coverity:

Re: [PATCH][next] wilc1000: remove redundant assignment to pointer vif

2020-12-07 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > The assignment to pointer vif is redundant as the assigned value > is never read, hence it can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > Acked-by: Ajay Singh Patch applied to

Re: [PATCH] mwl8k: switch from 'pci_' to 'dma_' API

2020-12-07 Thread Kalle Valo
Christophe JAILLET wrote: > he wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in

Re: [17/17] rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-12-07 Thread Kalle Valo
| void rtw_pci_shutdown(struct pci_dev *pdev) > | ^~~~ > > Cc: Yan-Hsuan Chuang > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-wirel...@vger.kernel.org > Cc: net...@vger.kernel.org > Signed-off-by: Lee Jones

Re: [PATCH v2] brmcfmac: fix compile when DEBUG is defined

2020-12-07 Thread Kalle Valo
hby wrote: > The steps: > 1. add "#define DEBUG" in > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c line 61. > 2. make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=../Out_Linux > bcm2835_defconfig > 3. make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=../Out_Linux/ zImage >

Re: [PATCH] net: ath9k: remove trailing semicolon in macro definition

2020-12-07 Thread Kalle Valo
t...@redhat.com wrote: > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 5a5b820d18c7 ath9k: remove trailing semicolon in macro definition -- https://patchwork.kernel.org/p

Re: [PATCH v2] ath10k: skip the wait for completion to recovery in shutdown path

2020-12-07 Thread Kalle Valo
Brian Norris writes: > On Thu, Nov 26, 2020 at 9:16 AM Youghandhar Chintala > wrote: >> --- a/drivers/net/wireless/ath/ath10k/snoc.c >> +++ b/drivers/net/wireless/ath/ath10k/snoc.c >> @@ -1790,9 +1790,6 @@ static int ath10k_snoc_remove(struct platform_device >> *pdev) >> >>

Re: [PATCH] [v7] wireless: Initial driver submission for pureLiFi STA devices

2020-12-03 Thread Kalle Valo
Srinivasan Raju writes: > we will be submitting to linux-firmware repository @ > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git > I will share the link once it is accpeted, we have sent another > version of the patch v8 , please review and provide your comments What

Re: [PATCH 09/17] ath: regd: Provide description for ath_reg_apply_ir_flags's 'reg' param

2020-12-02 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/regd.c:378: warning: Function parameter or member > 'reg' not described in 'ath_reg_apply_ir_flags' > > Cc: Kalle Valo > Cc: "David S. Miller" > Cc:

Re: wl1251: remove trailing semicolon in macro definition

2020-12-02 Thread Kalle Valo
t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix Patch applied to wireless-drivers-next.git, thanks. fc6877b87982 wl1251: remove trailing semicolon in macro definition --

Re: airo: remove trailing semicolon in macro definition

2020-12-02 Thread Kalle Valo
t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix > Reviewed-by: Kieran Bingham Patch applied to wireless-drivers-next.git, thanks. a460b0e1bab8 airo: remove trailing semicolon in macro definition --

Re: [PATCH v3] brcmfmac: expose firmware config files through modinfo

2020-12-02 Thread Kalle Valo
matthias@kernel.org wrote: > From: Matthias Brugger > > Apart from a firmware binary the chip needs a config file used by the > FW. Add the config files to modinfo so that they can be read by > userspace. > > Signed-off-by: Matthias Brugger > Reviewed-by: Hans de Goede Patch applied to

Re: [PATCH 01/17] wil6210: wmi: Correct misnamed function parameter 'ptr_'

2020-12-02 Thread Kalle Valo
gt; parameter 'ptr' description in 'wmi_buffer_block' > > Cc: Maya Erez > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-wirel...@vger.kernel.org > Cc: wil6...@qti.qualcomm.com > Cc: net...@vger.kernel.org > Signed-off-by: Lee Jon

Re: [PATCH 03/17] ath9k: ar9330_1p1_initvals: Remove unused const variable 'ar9331_common_tx_gain_offset1_1'

2020-12-02 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h:1013:18: warning: > ‘ar9331_common_tx_gain_offset1_1’ defined but not used > [-Wunused-const-variable=] > > Cc: QCA ath9k Development > Cc:

Re: [PATCH net-next 2/2] ath10k: Constify static qmi structs

2020-12-02 Thread Kalle Valo
: Rikard Falkeborn > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. ad37a46e8cb5 ath10k: Constify static qmi structs -- https://patchwork.kernel.org/project/linux-wireless/patch/20201122234031.33432-3-rikard.falkeb...@gmail.com/ https://wireless.wiki.ker

Re: [PATCH 1/2] ath10k: Fix an error handling path

2020-12-02 Thread Kalle Valo
Christophe JAILLET wrote: > If 'ath10k_usb_create()' fails, we should release some resources and report > an error instead of silently continuing. > > Fixes: 4db66499df91 ("ath10k: add initial USB support") > Signed-off-by: Christophe JAILLET > Signed-off-by: Ka

Re: [PATCH v3] ath10k: Fix the parsing error in service available event

2020-12-02 Thread Kalle Valo
Doug Anderson writes: > Hi, > > On Sun, Nov 15, 2020 at 8:35 PM Rakesh Pillai wrote: >> >> The wmi service available event has been >> extended to contain extra 128 bit for new services >> to be indicated by firmware. >> >> Currently the presence of any optional TLVs in >> the wmi service

Re: [PATCH v3] ath10k: Fix the parsing error in service available event

2020-12-02 Thread Kalle Valo
AN.HL.3.2.2-00720-QCAHLSWMTPL-1 > > Fixes: cea19a6ce8bf ("ath10k: add WMI_SERVICE_AVAILABLE_EVENT support") > Signed-off-by: Rakesh Pillai > Reviewed-by: Douglas Anderson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. c7cee9c0f499

Re: [PATCH] ath11k: Fix an error handling path

2020-12-02 Thread Kalle Valo
hristophe JAILLET > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. e7bcc145bcd0 ath11k: Fix an error handling path -- https://patchwork.kernel.org/project/linux-wireless/patch/20201122173943.1366167-1-christophe.jail...@wanadoo.fr/ https://wireless.wiki.kern

Re: [PATCH 01/29] bus: mhi: Remove auto-start option

2020-12-02 Thread Kalle Valo
Manivannan Sadhasivam writes: > On Wed, Dec 02, 2020 at 06:00:05PM +0200, Kalle Valo wrote: >> Manivannan Sadhasivam writes: >> >> > From: Loic Poulain >> > >> > There is really no point having an auto-start for channels. >> > This is co

Re: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-12-02 Thread Kalle Valo
488 | int rtw_pci_probe(struct pci_dev *pdev, >> > > > >  | ^ >> > > > >  drivers/net/wireless/realtek/rtw88/pci.c:1568:6: warning: no >> > > > > previous >> > > > > prototype for ‘rtw_pci_remove’ [-Wmissi

Re: [PATCH 01/29] bus: mhi: Remove auto-start option

2020-12-02 Thread Kalle Valo
may never be used. > > This is really up to the MHI device(channel) driver to manage the state > of its channels. > > While at it, let's also remove the auto-start option from ath11k mhi > controller. > > Signed-off-by: Loic Poulain > Acked-by: Kalle Valo > Reviewed-by

Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs

2020-11-24 Thread Kalle Valo
Jakub Kicinski writes: > On Mon, 23 Nov 2020 00:40:30 +0100 Rikard Falkeborn wrote: >> These are only used as input arguments to qmi_handle_init() which >> accepts const pointers to both qmi_ops and qmi_msg_handler. Make them >> const to allow the compiler to put them in read-only memory. >> >>

Re: cw1200: fix missing destroy_workqueue() on error in cw1200_init_common

2020-11-24 Thread Kalle Valo
Qinglang Miao wrote: > Add the missing destroy_workqueue() before return from > cw1200_init_common in the error handling case. > > Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN > chipsets") > Reported-by: Hulk Robot > Signed-off-by: Qinglang Miao Patch applied

Re: [PATCH] mwifiex: Remove duplicated REG_PORT definition

2020-11-24 Thread Kalle Valo
Jisheng Zhang wrote: > The REG_PORT is defined twice, so remove one of them. > > Signed-off-by: Jisheng Zhang Patch applied to wireless-drivers-next.git, thanks. 3c72d3843e22 mwifiex: Remove duplicated REG_PORT definition --

Re: [PATCH v2 1/4 resend] rtlwifi: rtl8188ee: avoid accessing the data mapped to streaming DMA

2020-11-24 Thread Kalle Valo
Jia-Ju Bai wrote: > In rtl88ee_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on > line 677: > dma_addr_t mapping = dma_map_single(..., skb->data, ...); > > On line 680, skb->data is assigned to hdr after cast: > struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data); > >

Re: [PATCH][next] mwifiex: Fix fall-through warnings for Clang

2020-11-24 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of > letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by:

Re: rsi: fix error return code in rsi_reset_card()

2020-11-24 Thread Kalle Valo
Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 17ff2c794f39 ("rsi: reset device changes for 9116") > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong Patch applied to

Re: [PATCH] brcmsmac: ampdu: Check BA window size before checking block ack

2020-11-24 Thread Kalle Valo
Dmitry Safonov wrote: > bindex can be out of BA window (64): > tid 0 seq 2983, start_seq 2915, bindex 68, index 39 > tid 0 seq 2984, start_seq 2915, bindex 69, index 40 > tid 0 seq 2985, start_seq 2915, bindex 70, index 41 > tid 0 seq 2986, start_seq 2915, bindex 71, index 42 > tid 0

Re: [PATCH] rtlwifi: rtl8192de: remove the useless value assignment

2020-11-24 Thread Kalle Valo
xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > The variable u4tmp is overwritten by the following call and the assignment > is useless, so remove it. > > Reported-by: Tosk Robot > Signed-off-by: Kaixu Xia Patch applied to wireless-drivers-next.git, thanks. 0409d504aa6c rtlwifi:

Re: [PATCH net] qtnfmac: fix error return code in qtnf_pcie_probe()

2020-11-24 Thread Kalle Valo
Wang Hai wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: b7da53cd6cd1 ("qtnfmac_pcie: use single PCIe driver for all platforms") > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Patch applied to

Re: [PATCH] brcmfmac: fix error return code in brcmf_cfg80211_connect()

2020-11-24 Thread Kalle Valo
Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 3b1e0a7bdfee ("brcmfmac: add support for SAE authentication offload") > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong >

Re: cw1200: replace a set of atomic_add()

2020-11-24 Thread Kalle Valo
Yejune Deng wrote: > a set of atomic_inc() looks more readable > > Signed-off-by: Yejune Deng Patch applied to wireless-drivers-next.git, thanks. 07f995ca1951 cw1200: replace a set of atomic_add() --

Re: [PATCH] [v7] wireless: Initial driver submission for pureLiFi STA devices

2020-11-24 Thread Kalle Valo
Srinivasan Raju wrote: > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC > and LiFi-XL USB devices. > > This driver implementation has been based on the zd1211rw driver. > > Driver is based on 802.11 softMAC Architecture and uses > native 802.11 for configuration and management. >

Re: [PATCH v2] brmcfmac: fix compile when DEBUG is defined

2020-11-23 Thread Kalle Valo
hby writes: > I am sorry for the HTML email, and I change the email client. The > patch update. > > From b87d429158b4efc3f6835828f495a261e17d5af4 Mon Sep 17 00:00:00 2001 > From: hby > Date: Tue, 24 Nov 2020 09:16:24 +0800 > Subject: [PATCH] brmcfmac: fix compile when DEBUG is defined > > The

Re: [PATCH 0/9] relay: cleanup and const callbacks, take 2

2020-11-23 Thread Kalle Valo
t; Cc: linux-bl...@vger.kernel.org > Cc: Jens Axboe > Cc: ath...@lists.infradead.org > Cc: ath...@lists.infradead.org > Cc: Kalle Valo > Cc: linux-wirel...@vger.kernel.org > Cc: QCA ath9k Development > Cc: intel-...@lists.freedesktop.org > Cc: Christoph Hellwig

Re: [PATCH] drivers: Fix the Raspberry Pi debug version compile

2020-11-23 Thread Kalle Valo
hby writes: > enable the DEBUG in source code, and it will compile fail, > modify the DEBUG macro, to adapt the compile > > Signed-off-by: hby > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This has nothing to do

Re: [PATCH] drivers: Fix the Raspberry Pi debug version compile

2020-11-23 Thread Kalle Valo
byhoo writes: > The steps: > 1. add "#define DEBUG" in > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c line 61. > 2. make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=../Out_Linux > bcm2835_defconfig > 3. make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=../Out_Linux/ > zImage

Re: [PATCH 4/6] ath11k: make relay callbacks const

2020-11-19 Thread Kalle Valo
Jani Nikula writes: > On Wed, 18 Nov 2020, Jani Nikula wrote: >> Now that relay_open() accepts const callbacks, make relay callbacks >> const. >> >> Cc: Kalle Valo >> Cc: ath...@lists.infradead.org >> Signed-off-by: Jani Nikula > > Kalle, thanks fo

Re: [PATCH] net: cw1200: fix missing destroy_workqueue() on error in cw1200_init_common

2020-11-18 Thread Kalle Valo
Qinglang Miao writes: > Add the missing destroy_workqueue() before return from > cw1200_init_common in the error handling case. > > Fixes:a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN > chipsets") This should be: Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E

Re: [PATCH 5/6] ath9k: make relay callbacks const

2020-11-18 Thread Kalle Valo
Kalle Valo writes: > Jani Nikula writes: > >> Now that relay_open() accepts const callbacks, make relay callbacks >> const. >> >> Cc: Kalle Valo >> Cc: QCA ath9k Development >> Cc: linux-wirel...@vger.kernel.org >> Signed-off-by: Jani Niku

Re: [PATCH 3/6] ath10k: make relay callbacks const

2020-11-18 Thread Kalle Valo
Jani Nikula writes: > Now that relay_open() accepts const callbacks, make relay callbacks > const. > > Cc: Kalle Valo > Cc: ath...@lists.infradead.org > Signed-off-by: Jani Nikula I assume this goes via some other tree: Acked-by: Kalle Valo -- https://patchwork.kernel

Re: [PATCH 5/6] ath9k: make relay callbacks const

2020-11-18 Thread Kalle Valo
Jani Nikula writes: > Now that relay_open() accepts const callbacks, make relay callbacks > const. > > Cc: Kalle Valo > Cc: QCA ath9k Development > Cc: linux-wirel...@vger.kernel.org > Signed-off-by: Jani Nikula Can I take this to my ath tree or what's

Re: linux-next: build failure after merge of the mhi tree

2020-11-17 Thread Kalle Valo
Manivannan Sadhasivam writes: > On Tue, Nov 17, 2020 at 09:53:59AM +0530, Manivannan Sadhasivam wrote: >> +ath11k list, kalle >> > > Oops... adding now > >> On Tue, Nov 17, 2020 at 03:12:25PM +1100, Stephen Rothwell wrote: >> > Hi all, >> > >> > After merging the mhi tree, today's linux-next

Re: [PATCH] rtw88: coex: remove the unreached code in rtw_coex_set_tdma

2020-11-17 Thread Kalle Valo
Pkshih writes: > On Sat, 2020-11-14 at 15:22 +, xiakaixu1...@gmail.com wrote: >> From: Kaixu Xia >> >> The value of the bool variable ap_enable is always false, so the first >> if branch is unreached code. Remove it. >> >> Reported-by: Tosk Robot >> Signed-off-by: Kaixu Xia >> --- >>  

Re: [PATCH] ath11k: use MHI provided APIs to allocate and free MHI controller

2020-11-16 Thread Kalle Valo
Bhaumik Bhatt writes: > Use MHI provided APIs to allocate and free MHI controller to > improve MHI host driver handling. How does it improve the handling? > This also fixes a memory leak as the MHI controller was allocated but > never freed. > > Signed-off-by: Bhaumik Bhatt > --- >

Re: drivers/net/wireless/ath/ath10k/sdio.c:2234:2: warning: Non-boolean value returned from function returning bool

2020-11-15 Thread Kalle Valo
+ ath10k list kernel test robot writes: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 > commit: 3c45f21af84eb05a355919abc80cf70a3a681cee ath10k: sdio: add > firmware coredump support > compiler:

Re: Regression: QCA6390 fails with "mm/page_alloc: place pages to tail in __free_pages_core()"

2020-11-11 Thread Kalle Valo
David Hildenbrand writes: >> Am 05.11.2020 um 11:42 schrieb Vlastimil Babka : >> >> On 11/5/20 10:04 AM, Kalle Valo wrote: >>> (changing the subject, adding more lists and people) >>> Pavel Procopiuc writes: >>>> Op 04.11.2020 om 10:12 schreef

Re: [PATCH] mwifiex: pcie: skip cancel_work_sync() on reset failure path

2020-11-11 Thread Kalle Valo
Tsuchiya Yuto writes: > On Tue, 2020-11-10 at 18:51 +0000, Kalle Valo wrote: >> Tsuchiya Yuto wrote: >> >> > If a reset is performed, but even the reset fails for some reasons (e.g., >> > on Surface devices, the fw reset requires another quirk

<    1   2   3   4   5   6   7   8   9   10   >