Re: [tpmdd-devel] [PATCH v2] drivers/tpm: add xen tpmfront interface

2013-05-28 Thread Kent Yoder
On Fri, May 24, 2013 at 9:37 AM, Konrad Rzeszutek Wilk wrote: > On Wed, May 22, 2013 at 05:12:24PM -0500, Kent Yoder wrote: >> On Wed, May 22, 2013 at 3:57 PM, Konrad Rzeszutek Wilk >> wrote: >> > On Wed, May 22, 2013 at 02:47:01PM -0500, Kent Yoder wrote: >> >&g

Re: [tpmdd-devel] [PATCH v2] drivers/tpm: add xen tpmfront interface

2013-05-28 Thread Kent Yoder
On Fri, May 24, 2013 at 9:37 AM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Wed, May 22, 2013 at 05:12:24PM -0500, Kent Yoder wrote: On Wed, May 22, 2013 at 3:57 PM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Wed, May 22, 2013 at 02:47:01PM -0500, Kent Yoder wrote

Re: [tpmdd-devel] [PATCH v2] drivers/tpm: add xen tpmfront interface

2013-05-22 Thread Kent Yoder
On Wed, May 22, 2013 at 3:57 PM, Konrad Rzeszutek Wilk wrote: > On Wed, May 22, 2013 at 02:47:01PM -0500, Kent Yoder wrote: >> >> + notify_remote_via_evtchn(priv->evtchn); >> >> + >> >> + ordinal = be32_to_cpu(*((__be32 *) (buf + 6))); &

Re: [tpmdd-devel] [PATCH v2] drivers/tpm: add xen tpmfront interface

2013-05-22 Thread Kent Yoder
>> + notify_remote_via_evtchn(priv->evtchn); >> + >> + ordinal = be32_to_cpu(*((__be32 *) (buf + 6))); > > Um, + 6? Why? Is there an #define for that magic constant? > Should this value be read before you do the wait_for_tpm_stat stuff? This is hardcoded to 6 even in tpm.c. Time for a

[PATCHv2] maintainers: remove Kent from maintainers list

2013-05-22 Thread Kent Yoder
Signed-off-by: Kent Yoder --- v2: Replace Kent with other so that NX isn't unmaintained, leave tpmdd-devel as maintainer for TPM MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 829c032..5ec293d 100644 --- a/MAINTAINERS

Re: [PATCH] maintainers: Remove Kent from maintainers

2013-05-22 Thread Kent Yoder
On Wed, May 22, 2013 at 09:37:20AM -0700, Joe Perches wrote: > On Wed, 2013-05-22 at 10:56 -0500, Kent Yoder wrote: > > > diff --git a/MAINTAINERS b/MAINTAINERS > [] > > @@ -3971,7 +3971,8 @@ S:Maintained > > F: arch/ia64/ > > > > IBM Power in-Nest

[PATCH] maintainers: Remove Kent from maintainers

2013-05-22 Thread Kent Yoder
Signed-off-by: Kent Yoder --- MAINTAINERS | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 829c032..592af73 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3971,7 +3971,8 @@ S:Maintained F: arch/ia64/ IBM Power in-Nest

[PULL] TPM driver updates

2013-05-22 Thread Kent Yoder
Hi James, The following changes since commit 4726e8fa1dcad533362475ebf91f70d5b6b6292f: security: clarify cap_inode_getsecctx description (2013-05-12 21:32:38 +1000) are available in the git repository at: git://github.com/shpedoikal/linux.git tpmdd-05-21-13 for you to fetch changes up to

[PULL] TPM driver updates

2013-05-22 Thread Kent Yoder
Hi James, The following changes since commit 4726e8fa1dcad533362475ebf91f70d5b6b6292f: security: clarify cap_inode_getsecctx description (2013-05-12 21:32:38 +1000) are available in the git repository at: git://github.com/shpedoikal/linux.git tpmdd-05-21-13 for you to fetch changes up to

[PATCH] maintainers: Remove Kent from maintainers

2013-05-22 Thread Kent Yoder
Signed-off-by: Kent Yoder k...@linux.vnet.ibm.com --- MAINTAINERS | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 829c032..592af73 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3971,7 +3971,8 @@ S:Maintained F: arch/ia64

Re: [PATCH] maintainers: Remove Kent from maintainers

2013-05-22 Thread Kent Yoder
On Wed, May 22, 2013 at 09:37:20AM -0700, Joe Perches wrote: On Wed, 2013-05-22 at 10:56 -0500, Kent Yoder wrote: diff --git a/MAINTAINERS b/MAINTAINERS [] @@ -3971,7 +3971,8 @@ S:Maintained F: arch/ia64/ IBM Power in-Nest Crypto Acceleration -M: Kent Yoder k

[PATCHv2] maintainers: remove Kent from maintainers list

2013-05-22 Thread Kent Yoder
Signed-off-by: Kent Yoder k...@linux.vnet.ibm.com --- v2: Replace Kent with other so that NX isn't unmaintained, leave tpmdd-devel as maintainer for TPM MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 829c032..5ec293d 100644

Re: [tpmdd-devel] [PATCH v2] drivers/tpm: add xen tpmfront interface

2013-05-22 Thread Kent Yoder
+ notify_remote_via_evtchn(priv-evtchn); + + ordinal = be32_to_cpu(*((__be32 *) (buf + 6))); Um, + 6? Why? Is there an #define for that magic constant? Should this value be read before you do the wait_for_tpm_stat stuff? This is hardcoded to 6 even in tpm.c. Time for a #define...

Re: [tpmdd-devel] [PATCH v2] drivers/tpm: add xen tpmfront interface

2013-05-22 Thread Kent Yoder
On Wed, May 22, 2013 at 3:57 PM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Wed, May 22, 2013 at 02:47:01PM -0500, Kent Yoder wrote: + notify_remote_via_evtchn(priv-evtchn); + + ordinal = be32_to_cpu(*((__be32 *) (buf + 6))); Um, + 6? Why? Is there an #define

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-13 Thread Kent Yoder
instructions, here: http://smatch.sourceforge.net/. Kent > However, these warning will be corrected in the next patch and the others too. > > Regards, > > Mathias Leblanc > > -----Original Message- > From: Kent Yoder [mailto:shpedoi...@gmail.com] > Sent: 10 May, 2013

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-13 Thread Kent Yoder
, with some instructions, here: http://smatch.sourceforge.net/. Kent However, these warning will be corrected in the next patch and the others too. Regards, Mathias Leblanc -Original Message- From: Kent Yoder [mailto:shpedoi...@gmail.com] Sent: 10 May, 2013 17:07 To: Mathias LEBLANC Cc

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-10 Thread Kent Yoder
On Fri, May 10, 2013 at 8:38 AM, Kent Yoder wrote: > Hi Mathias, Sorry, this note got sent before I was done somehow... A few compile warnings left: drivers/char/tpm/tpm_spi_stm_st33.c: In function ‘tpm_stm_spi_status’: drivers/char/tpm/tpm_spi_stm_st33.c:289:2: error: ‘data’ is u

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-10 Thread Kent Yoder
On Fri, May 10, 2013 at 8:38 AM, Kent Yoder shpedoi...@gmail.com wrote: Hi Mathias, Sorry, this note got sent before I was done somehow... A few compile warnings left: drivers/char/tpm/tpm_spi_stm_st33.c: In function ‘tpm_stm_spi_status’: drivers/char/tpm/tpm_spi_stm_st33.c:289:2: error: ‘data

Re: [PATCH] drivers/crypto/nx: fixes for multiple issues

2013-05-06 Thread Kent Yoder
Thanks! Kent On Mon, May 6, 2013 at 4:53 PM, Benjamin Herrenschmidt wrote: > On Mon, 2013-05-06 at 14:24 -0500, Kent Yoder wrote: >> Hi Ben, just a friendly reminder to please apply. > > Oh, I assumed that stuff was going via some drivers/crypto maintainer... > > I can app

Re: [PATCH] drivers/crypto/nx: fixes for multiple issues

2013-05-06 Thread Kent Yoder
Hi Ben, just a friendly reminder to please apply. Thanks, Kent On Fri, Apr 12, 2013 at 12:13:59PM -0500, Kent Yoder wrote: > Fixes a race on driver init with registering algorithms where the > driver status flag wasn't being set before self testing started. > > Added the cra_ali

Re: [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-06 Thread Kent Yoder
Hi Mathias, On Mon, May 06, 2013 at 01:14:44PM +0200, Matthias Leblanc wrote: > From: Mathias Leblanc > > * STMicroelectronics version 1.2.0, Copyright (C) 2010 > * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. > * This is free software, and you are welcome to redistribute it > *

Re: [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-05-06 Thread Kent Yoder
Hi Mathias, On Mon, May 06, 2013 at 01:14:44PM +0200, Matthias Leblanc wrote: From: Mathias Leblanc mathias.lebl...@st.com * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to

Re: [PATCH] drivers/crypto/nx: fixes for multiple issues

2013-05-06 Thread Kent Yoder
Hi Ben, just a friendly reminder to please apply. Thanks, Kent On Fri, Apr 12, 2013 at 12:13:59PM -0500, Kent Yoder wrote: Fixes a race on driver init with registering algorithms where the driver status flag wasn't being set before self testing started. Added the cra_alignmask field

Re: [PATCH] drivers/crypto/nx: fixes for multiple issues

2013-05-06 Thread Kent Yoder
Thanks! Kent On Mon, May 6, 2013 at 4:53 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2013-05-06 at 14:24 -0500, Kent Yoder wrote: Hi Ben, just a friendly reminder to please apply. Oh, I assumed that stuff was going via some drivers/crypto maintainer... I can apply

Re: [PATCH] tpm_tis: fix missing platform_driver_unregister

2013-05-02 Thread Kent Yoder
On Thu, May 02, 2013 at 07:39:50PM +0800, Libo Chen wrote: > > Add missing unregister tis_drv after register pdev fail > > Signed-off-by: Libo Chen Hi Libo - thanks for the contribution, but I got an similar patch last week from Wei Yongjun. Its staged over here [1] and will be pushed soon.

Re: [PATCH] tpm_tis: fix missing platform_driver_unregister

2013-05-02 Thread Kent Yoder
On Thu, May 02, 2013 at 07:39:50PM +0800, Libo Chen wrote: Add missing unregister tis_drv after register pdev fail Signed-off-by: Libo Chen libo.c...@huawei.com Hi Libo - thanks for the contribution, but I got an similar patch last week from Wei Yongjun. Its staged over here [1] and will

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-29 Thread Kent Yoder
On Sun, Apr 28, 2013 at 03:16:33AM +0200, Peter Hüwe wrote: > Hi Matthias, > > it's nice to see that you consider most of the comments, unfortunately I > still > have some left ;) > > > +/* > > + * tpm_st33_spi_init initialize driver > > + * @return: 0 if successful, else non zero value. > > +

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-29 Thread Kent Yoder
On Sun, Apr 28, 2013 at 03:16:33AM +0200, Peter Hüwe wrote: Hi Matthias, it's nice to see that you consider most of the comments, unfortunately I still have some left ;) +/* + * tpm_st33_spi_init initialize driver + * @return: 0 if successful, else non zero value. + */ +static

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-26 Thread Kent Yoder
> Regards, > > Mathias > > -Original Message- > From: Kent Yoder [mailto:shpedoi...@gmail.com] > Sent: 22 April, 2013 20:31 > To: Mathias LEBLANC > Cc: Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG; > tpmdd-de...@lists.sourceforge.net; Jean-Lu

Re: [tpmdd-devel] [PATCH] tpm_tis: missing platform_driver_unregister() on error in init_tis()

2013-04-26 Thread Kent Yoder
On Thu, Apr 25, 2013 at 03:07:47PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Add the missing platform_driver_unregister() before return > from init_tis() in the device register error handling case. > > Signed-off-by: Wei Yongjun Applied and staged here, thanks!

Re: [tpmdd-devel] [PATCH] tpm_tis: missing platform_driver_unregister() on error in init_tis()

2013-04-26 Thread Kent Yoder
On Thu, Apr 25, 2013 at 03:07:47PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing platform_driver_unregister() before return from init_tis() in the device register error handling case. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-26 Thread Kent Yoder
-Original Message- From: Kent Yoder [mailto:shpedoi...@gmail.com] Sent: 22 April, 2013 20:31 To: Mathias LEBLANC Cc: Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG; tpmdd-de...@lists.sourceforge.net; Jean-Luc BLANC; linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH 1/1

Re: [tpmdd-devel] tpm_tis driver failed to suspend, error -62

2013-04-23 Thread Kent Yoder
On Tue, Apr 23, 2013 at 10:03 AM, wrote: > 2013-04-23 16:43 skrev Kent Yoder: > >> On Tue, Apr 23, 2013 at 04:30:53PM +0200, peteraspl...@gentoo.se wrote: >>> >>> 2013-04-11 23:41 skrev Kent Yoder: >>> >On Sat, Apr 06, 2013 at 06:00:59PM +0200, peteraspl

Re: [tpmdd-devel] tpm_tis driver failed to suspend, error -62

2013-04-23 Thread Kent Yoder
On Tue, Apr 23, 2013 at 04:30:53PM +0200, peteraspl...@gentoo.se wrote: > 2013-04-11 23:41 skrev Kent Yoder: > >On Sat, Apr 06, 2013 at 06:00:59PM +0200, peteraspl...@gentoo.se > >wrote: > >>2013-04-02 16:03 skrev Kent Yoder: > >>>Hi Peter, > >>&

Re: [tpmdd-devel] tpm_tis driver failed to suspend, error -62

2013-04-23 Thread Kent Yoder
On Tue, Apr 23, 2013 at 04:30:53PM +0200, peteraspl...@gentoo.se wrote: 2013-04-11 23:41 skrev Kent Yoder: On Sat, Apr 06, 2013 at 06:00:59PM +0200, peteraspl...@gentoo.se wrote: 2013-04-02 16:03 skrev Kent Yoder: Hi Peter, On Mon, Apr 1, 2013 at 4:17 PM, peteraspl...@gentoo.se wrote

Re: [tpmdd-devel] tpm_tis driver failed to suspend, error -62

2013-04-23 Thread Kent Yoder
On Tue, Apr 23, 2013 at 10:03 AM, peteraspl...@gentoo.se wrote: 2013-04-23 16:43 skrev Kent Yoder: On Tue, Apr 23, 2013 at 04:30:53PM +0200, peteraspl...@gentoo.se wrote: 2013-04-11 23:41 skrev Kent Yoder: On Sat, Apr 06, 2013 at 06:00:59PM +0200, peteraspl...@gentoo.se wrote: 2013-04-02

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-22 Thread Kent Yoder
ex, so I think you're safe from other TPM writes, but what about other devices on the bus? Can they contend for the read/write? Kent > Regards, > > Mathias Leblanc > > -Original Message- > From: Kent Yoder [mailto:shpedoi...@gmail.com] > Sent: 22 April, 2013 17:26 > To

Re: [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-22 Thread Kent Yoder
On Mon, Apr 22, 2013 at 06:20:17PM +0200, Matthias Leblanc wrote: > From: Mathias Leblanc > > * STMicroelectronics version 1.2.0, Copyright (C) 2010 > * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. > * This is free software, and you are welcome to redistribute it > * under certain

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-22 Thread Kent Yoder
On Mon, Apr 22, 2013 at 10:50:06AM +0200, Mathias Leblanc wrote: > * STMicroelectronics version 1.2.0, Copyright (C) 2010 > * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. > * This is free software, and you are welcome to redistribute it > * under certain conditions. > > This is the

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-22 Thread Kent Yoder
On Mon, Apr 22, 2013 at 10:50:06AM +0200, Mathias Leblanc wrote: * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver

Re: [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-22 Thread Kent Yoder
On Mon, Apr 22, 2013 at 06:20:17PM +0200, Matthias Leblanc wrote: From: Mathias Leblanc mathias.lebl...@st.com * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it *

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-22 Thread Kent Yoder
, Mathias Leblanc -Original Message- From: Kent Yoder [mailto:shpedoi...@gmail.com] Sent: 22 April, 2013 17:26 To: Mathias LEBLANC Cc: Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG; tpmdd-de...@lists.sourceforge.net; Jean-Luc BLANC; linux-kernel@vger.kernel.org Subject

Re: [tpmdd-devel] [PATCH v2] drivers/tpm: add xen tpmfront interface

2013-04-19 Thread Kent Yoder
Hi Daniel - this looks good, only one minor comment below... On Thu, Apr 11, 2013 at 10:56:01AM -0400, Daniel De Graaf wrote: > This is a complete rewrite of the Xen TPM frontend driver, taking > advantage of a simplified frontend/backend interface and adding support > for cancellation and

Re: [tpmdd-devel] [PATCH v2] drivers/tpm: add xen tpmfront interface

2013-04-19 Thread Kent Yoder
Hi Daniel - this looks good, only one minor comment below... On Thu, Apr 11, 2013 at 10:56:01AM -0400, Daniel De Graaf wrote: This is a complete rewrite of the Xen TPM frontend driver, taking advantage of a simplified frontend/backend interface and adding support for cancellation and timeouts.

[PULL] TPM driver updates

2013-04-18 Thread Kent Yoder
Hi James, The following changes since commit 958d2c2f4ad905e3ffa1711d19184d21d9b00cc1: Smack: include magic.h in smackfs.c (2013-04-03 13:13:51 +1100) are available in the git repository at: git://github.com/shpedoikal/linux.git tpmdd-04-17-13 for you to fetch changes up to

[PULL] TPM driver updates

2013-04-18 Thread Kent Yoder
Hi James, The following changes since commit 958d2c2f4ad905e3ffa1711d19184d21d9b00cc1: Smack: include magic.h in smackfs.c (2013-04-03 13:13:51 +1100) are available in the git repository at: git://github.com/shpedoikal/linux.git tpmdd-04-17-13 for you to fetch changes up to

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-17 Thread Kent Yoder
Hi Matthias, On Fri, Apr 12, 2013 at 10:44:11AM +0200, Matthias Leblanc wrote: > From: Mathias Leblanc > > * STMicroelectronics version 1.2.0, Copyright (C) 2010 > * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. > * This is free software, and you are welcome to redistribute it > *

Re: [PATCH] TPM: Retry SaveState command in suspend path

2013-04-17 Thread Kent Yoder
On Tue, Apr 16, 2013 at 6:57 PM, Greg KH wrote: > On Tue, Mar 19, 2013 at 10:00:02AM -0500, Kent Yoder wrote: >> Hi Duncan, >> >> On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie wrote: >> > If the TPM has already been sent a SaveState command before the driver >&

Re: [PATCH] TPM: Retry SaveState command in suspend path

2013-04-17 Thread Kent Yoder
On Tue, Apr 16, 2013 at 6:57 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Mar 19, 2013 at 10:00:02AM -0500, Kent Yoder wrote: Hi Duncan, On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie dlau...@chromium.org wrote: If the TPM has already been sent a SaveState command before the driver

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-04-17 Thread Kent Yoder
Hi Matthias, On Fri, Apr 12, 2013 at 10:44:11AM +0200, Matthias Leblanc wrote: From: Mathias Leblanc mathias.lebl...@st.com * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to

[PATCH] drivers/crypto/nx: fixes for multiple issues

2013-04-12 Thread Kent Yoder
for number of bytes processed in the sha code. Signed-off-by: Kent Yoder --- Patch v3, was: drivers/crypto/nx: fix init race, alignmasks and GCM bug Applied to: git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git#next drivers/crypto/nx/nx-aes-cbc.c | 1 + drivers/crypto/nx/nx-aes

[PATCH] drivers/crypto/nx: fixes for multiple issues

2013-04-12 Thread Kent Yoder
for number of bytes processed in the sha code. Signed-off-by: Kent Yoder k...@linux.vnet.ibm.com --- Patch v3, was: drivers/crypto/nx: fix init race, alignmasks and GCM bug Applied to: git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git#next drivers/crypto/nx/nx-aes-cbc.c | 1

Re: [tpmdd-devel] tpm_tis driver failed to suspend, error -62

2013-04-11 Thread Kent Yoder
On Sat, Apr 06, 2013 at 06:00:59PM +0200, peteraspl...@gentoo.se wrote: > 2013-04-02 16:03 skrev Kent Yoder: > >Hi Peter, > > > >On Mon, Apr 1, 2013 at 4:17 PM, wrote: > >>2013-03-28 14:12 skrev peter.hu...@infineon.com: > >>>What also might be

Re: [tpmdd-devel] tpm_tis driver failed to suspend, error -62

2013-04-11 Thread Kent Yoder
On Sat, Apr 06, 2013 at 06:00:59PM +0200, peteraspl...@gentoo.se wrote: 2013-04-02 16:03 skrev Kent Yoder: Hi Peter, On Mon, Apr 1, 2013 at 4:17 PM, peteraspl...@gentoo.se wrote: 2013-03-28 14:12 skrev peter.hu...@infineon.com: What also might be worth a look - in your bugzilla it states

Re: Fwd: [PATCH v2] drivers/crypto/nx: fix init race, alignmasks and GCM bug

2013-04-10 Thread Kent Yoder
No problem, turns out I had a few more updates I needed to sneak into the patch anyway. Please see v3 in a new thread, applied to the ppc-dev-next tree. Thanks, Kent On Thu, Mar 28, 2013 at 1:24 PM, Benjamin Herrenschmidt wrote: > On Thu, 2013-03-28 at 11:32 -0500, Kent Yoder wrote: >&g

Re: Fwd: [PATCH v2] drivers/crypto/nx: fix init race, alignmasks and GCM bug

2013-04-10 Thread Kent Yoder
Yoder wrote: Hi Ben, will you carry this patch in the linuxppc-dev tree? I can but I'm on vacation until end of April roughly. Cheers, Ben. Thanks, Kent -- Forwarded message -- From: Kent Yoder shpedoi...@gmail.com Date: Wed, Mar 20, 2013 at 9:22 AM Subject: [PATCH v2

Re: [tpmdd-devel] tpm_tis driver failed to suspend, error -62

2013-04-02 Thread Kent Yoder
Hi Peter, On Mon, Apr 1, 2013 at 4:17 PM, wrote: > 2013-03-28 14:12 skrev peter.hu...@infineon.com: >> What also might be worth a look - in your bugzilla it states: >> [ 0.225891] pnp 00:0a: Plug and Play ACPI device, IDs IFX0102 PNP0c31 >> (active) >> [ 9.150673] tpm_tis 00:0a: 1.2 TPM

Re: [tpmdd-devel] tpm_tis driver failed to suspend, error -62

2013-04-02 Thread Kent Yoder
Hi Peter, On Mon, Apr 1, 2013 at 4:17 PM, peteraspl...@gentoo.se wrote: 2013-03-28 14:12 skrev peter.hu...@infineon.com: What also might be worth a look - in your bugzilla it states: [ 0.225891] pnp 00:0a: Plug and Play ACPI device, IDs IFX0102 PNP0c31 (active) [ 9.150673] tpm_tis 00:0a:

Fwd: [PATCH v2] drivers/crypto/nx: fix init race, alignmasks and GCM bug

2013-03-28 Thread Kent Yoder
Hi Ben, will you carry this patch in the linuxppc-dev tree? Thanks, Kent -- Forwarded message -- From: Kent Yoder Date: Wed, Mar 20, 2013 at 9:22 AM Subject: [PATCH v2] drivers/crypto/nx: fix init race, alignmasks and GCM bug To: linux-kernel@vger.kernel.org Cc: linux-cry

Fwd: [PATCH v2] drivers/crypto/nx: fix init race, alignmasks and GCM bug

2013-03-28 Thread Kent Yoder
Hi Ben, will you carry this patch in the linuxppc-dev tree? Thanks, Kent -- Forwarded message -- From: Kent Yoder shpedoi...@gmail.com Date: Wed, Mar 20, 2013 at 9:22 AM Subject: [PATCH v2] drivers/crypto/nx: fix init race, alignmasks and GCM bug To: linux-kernel@vger.kernel.org

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-03-25 Thread Kent Yoder
On Mon, Mar 25, 2013 at 10:08 AM, Matthias Leblanc wrote: > From: admin01 > > * STMicroelectronics version 1.2.0, Copyright (C) 2010 > * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. > * This is free software, and you are welcome to redistribute it > * under certain conditions. > >

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

2013-03-25 Thread Kent Yoder
On Mon, Mar 25, 2013 at 10:08 AM, Matthias Leblanc mathias.lebl...@st.com wrote: From: admin01 admin01@admin01-desktop.(none) * STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to

[PATCH v2] drivers/crypto/nx: fix init race, alignmasks and GCM bug

2013-03-20 Thread Kent Yoder
Fixes a race on driver init with registering algorithms where the driver status flag wasn't being set before self testing started. Added the cra_alignmask field for CBC and ECB modes. Fixed a bug in GCM where AES block size was being used instead of authsize. Signed-off-by: Kent Yoder

[PATCH v2] drivers/crypto/nx: fix init race, alignmasks and GCM bug

2013-03-20 Thread Kent Yoder
Fixes a race on driver init with registering algorithms where the driver status flag wasn't being set before self testing started. Added the cra_alignmask field for CBC and ECB modes. Fixed a bug in GCM where AES block size was being used instead of authsize. Signed-off-by: Kent Yoder k

Re: [PATCH] TPM: Retry SaveState command in suspend path

2013-03-19 Thread Kent Yoder
Hi Duncan, On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie wrote: > If the TPM has already been sent a SaveState command before the driver > is loaded it may have problems sending that same command again later. > > This issue is seen with the Chromebook Pixel due to a firmware bug in > the legacy

Re: [PATCH] TPM: Retry SaveState command in suspend path

2013-03-19 Thread Kent Yoder
Hi Duncan, On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie dlau...@chromium.org wrote: If the TPM has already been sent a SaveState command before the driver is loaded it may have problems sending that same command again later. This issue is seen with the Chromebook Pixel due to a firmware bug

Re: [PATCH -next] char/tpm/tpm_i2c_stm_st33: remove duplicated include from tpm_i2c_stm_st33.c

2013-03-15 Thread Kent Yoder
On Mon, Mar 11, 2013 at 9:20 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Remove duplicated include. HI Wei, thanks for the patch. I've already staged the same patch for inclusion in the next pull request for TPM drivers here:

Re: [PATCH -next] char/tpm/tpm_i2c_stm_st33: remove duplicated include from tpm_i2c_stm_st33.c

2013-03-15 Thread Kent Yoder
On Mon, Mar 11, 2013 at 9:20 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove duplicated include. HI Wei, thanks for the patch. I've already staged the same patch for inclusion in the next pull request for TPM drivers here:

Re: [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-03-04 Thread Kent Yoder
On Thu, Feb 28, 2013 at 4:06 AM, Jean Delvare wrote: > From: Shubhrajyoti Datta > > Convert the struct i2c_msg initialization to C99 format. This makes > maintaining and editing the code simpler. Also helps once other fields > like transferred are added in future. > > Thanks to Julia Lawall for

Re: [tpmdd-devel] [PATCH v2] tpm: Add support for new Infineon I2C TPM (SLB 9645 TT 1.2 I2C)

2013-03-04 Thread Kent Yoder
On Mon, Mar 4, 2013 at 2:08 PM, Kent Yoder wrote: >>> > >>> > + >>> > +#ifdef CONFIG_OF >>> > +static const struct of_device_id tpm_tis_i2c_of_match[] = { >>> > + { .compatible = "infineon,tpm_i2c_infineon", .data = (void *)

Re: [tpmdd-devel] [PATCH v2] tpm: Add support for new Infineon I2C TPM (SLB 9645 TT 1.2 I2C)

2013-03-04 Thread Kent Yoder
>> > >> > + >> > +#ifdef CONFIG_OF >> > +static const struct of_device_id tpm_tis_i2c_of_match[] = { >> > + { .compatible = "infineon,tpm_i2c_infineon", .data = (void *)0 }, >> > + { .compatible = "infineon,slb9635tt", .data = (void *)0 }, >> > + { .compatible = "infineon,slb9645tt", .data =

[PATCH] drivers/crypto/nx: fix init race, alignmasks and GCM bug

2013-03-04 Thread Kent Yoder
Fixes a race on driver init with registering algorithms where the driver status flag wasn't being set before self testing started. Added the cra_alignmask field for CBC and ECB modes. Fixed a bug in GCM where AES block size was being used instead of authsize. Signed-off-by: Kent Yoder

[PATCH] drivers/crypto/nx: fix init race, alignmasks and GCM bug

2013-03-04 Thread Kent Yoder
Fixes a race on driver init with registering algorithms where the driver status flag wasn't being set before self testing started. Added the cra_alignmask field for CBC and ECB modes. Fixed a bug in GCM where AES block size was being used instead of authsize. Signed-off-by: Kent Yoder k

Re: [tpmdd-devel] [PATCH v2] tpm: Add support for new Infineon I2C TPM (SLB 9645 TT 1.2 I2C)

2013-03-04 Thread Kent Yoder
+ +#ifdef CONFIG_OF +static const struct of_device_id tpm_tis_i2c_of_match[] = { + { .compatible = infineon,tpm_i2c_infineon, .data = (void *)0 }, + { .compatible = infineon,slb9635tt, .data = (void *)0 }, + { .compatible = infineon,slb9645tt, .data = (void *)1 }, Here name

Re: [tpmdd-devel] [PATCH v2] tpm: Add support for new Infineon I2C TPM (SLB 9645 TT 1.2 I2C)

2013-03-04 Thread Kent Yoder
On Mon, Mar 4, 2013 at 2:08 PM, Kent Yoder shpedoi...@gmail.com wrote: + +#ifdef CONFIG_OF +static const struct of_device_id tpm_tis_i2c_of_match[] = { + { .compatible = infineon,tpm_i2c_infineon, .data = (void *)0 }, + { .compatible = infineon,slb9635tt, .data = (void *)0

Re: [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-03-04 Thread Kent Yoder
On Thu, Feb 28, 2013 at 4:06 AM, Jean Delvare kh...@linux-fr.org wrote: From: Shubhrajyoti Datta omaplinuxker...@gmail.com Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in

Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Kent Yoder
On Thu, Feb 28, 2013 at 4:32 PM, Jean Delvare wrote: > On Thu, 28 Feb 2013 23:12:51 +0100, Peter Hüwe wrote: >> thanks for resending. > > You're welcome. > >> Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare: >> > From: Shubhrajyoti Datta >> > >> > Convert the struct i2c_msg

Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Kent Yoder
On Thu, Feb 28, 2013 at 4:32 PM, Jean Delvare kh...@linux-fr.org wrote: On Thu, 28 Feb 2013 23:12:51 +0100, Peter Hüwe wrote: thanks for resending. You're welcome. Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare: From: Shubhrajyoti Datta omaplinuxker...@gmail.com Convert

Re: [GIT PULL] Load keys from signed PE binaries

2013-02-26 Thread Kent Yoder
On Tue, Feb 26, 2013 at 4:21 AM, Matthew Garrett wrote: > On Tue, Feb 26, 2013 at 02:07:22AM -0800, Raymond Jennings wrote: >> Just curious here, but is this as much of an issue if a user is >> somehow able to take ownership of his own machine? > > No, if you're doing your own key management then

Re: [GIT PULL] Load keys from signed PE binaries

2013-02-26 Thread Kent Yoder
On Tue, Feb 26, 2013 at 4:21 AM, Matthew Garrett mj...@srcf.ucam.org wrote: On Tue, Feb 26, 2013 at 02:07:22AM -0800, Raymond Jennings wrote: Just curious here, but is this as much of an issue if a user is somehow able to take ownership of his own machine? No, if you're doing your own key

Re: [tpmdd-devel] [PATCH] TPM: Work around buggy TPMs that block during continue self test

2013-02-01 Thread Kent Yoder
On Mon, Jan 28, 2013 at 8:11 AM, Kent Yoder wrote: > On Fri, Jan 25, 2013 at 01:25:38PM -0700, Jason Gunthorpe wrote: >> On Tue, Jan 22, 2013 at 05:29:23PM -0600, Kent Yoder wrote: >> > Hi Jason, >> > >> > On Wed, Nov 21, 2012 at 3:15 PM, Jason Gunthorpe &g

Re: [tpmdd-devel] [PATCH] TPM: Work around buggy TPMs that block during continue self test

2013-02-01 Thread Kent Yoder
On Mon, Jan 28, 2013 at 8:11 AM, Kent Yoder k...@linux.vnet.ibm.com wrote: On Fri, Jan 25, 2013 at 01:25:38PM -0700, Jason Gunthorpe wrote: On Tue, Jan 22, 2013 at 05:29:23PM -0600, Kent Yoder wrote: Hi Jason, On Wed, Nov 21, 2012 at 3:15 PM, Jason Gunthorpe jguntho

Re: [tpmdd-devel] [PATCH] TPM: Work around buggy TPMs that block during continue self test

2013-01-22 Thread Kent Yoder
Hi Jason, On Wed, Nov 21, 2012 at 3:15 PM, Jason Gunthorpe wrote: > We've been testing an alternative TPM for our embedded products and > found random kernel boot failures due to time outs after the continue > self test command. > > This was happening randomly, and has been *very* hard to track

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x OOPS!

2013-01-22 Thread Kent Yoder
On Wed, Jan 9, 2013 at 1:41 PM, Peter Hüwe wrote: > In my opinion a driver should never ever oops, even if the user does something > stupid (e.g. like probing from userspace ;) Exactly... I've coded up a fix for the oops and staged it here, please test:

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x OOPS!

2013-01-22 Thread Kent Yoder
On Wed, Jan 9, 2013 at 1:41 PM, Peter Hüwe peterhu...@gmx.de wrote: In my opinion a driver should never ever oops, even if the user does something stupid (e.g. like probing from userspace ;) Exactly... I've coded up a fix for the oops and staged it here, please test:

Re: [tpmdd-devel] [PATCH] TPM: Work around buggy TPMs that block during continue self test

2013-01-22 Thread Kent Yoder
Hi Jason, On Wed, Nov 21, 2012 at 3:15 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: We've been testing an alternative TPM for our embedded products and found random kernel boot failures due to time outs after the continue self test command. This was happening randomly, and has

Re: [PATCH] char/tpm: Use struct dev_pm_ops for power management

2012-12-06 Thread Kent Yoder
On Thu, Dec 06, 2012 at 01:20:51AM +0100, Peter Huewe wrote: > This patch converts the suspend and resume functions for > tpm_i2c_stm_st33 to the new dev_pm_ops. > > Signed-off-by: Peter Huewe One minor tweak, the PM funcs need to be inside CONFIG_PM_SLEEP to avoid warnings when compiled

Re: [PATCH] char/tpm: Use struct dev_pm_ops for power management

2012-12-06 Thread Kent Yoder
On Thu, Dec 06, 2012 at 01:20:51AM +0100, Peter Huewe wrote: > This patch converts the suspend and resume functions for > tpm_i2c_stm_st33 to the new dev_pm_ops. Ignore my last mail. I'll take a look at this. Thanks, Kent > Signed-off-by: Peter Huewe > --- > Note: > I'm sending this patch on

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x

2012-12-06 Thread Kent Yoder
On Thu, Dec 06, 2012 at 01:10:32AM +0100, Peter Hüwe wrote: > Am Donnerstag, 6. Dezember 2012, 00:09:41 schrieb Kent Yoder: > > > > > > > static int tpm_st33_i2c_pm_suspend(struct i2c_client *client, > > > > pm_message_t mesg) > > > > > > &g

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x

2012-12-06 Thread Kent Yoder
On Thu, Dec 06, 2012 at 01:10:32AM +0100, Peter Hüwe wrote: Am Donnerstag, 6. Dezember 2012, 00:09:41 schrieb Kent Yoder: static int tpm_st33_i2c_pm_suspend(struct i2c_client *client, pm_message_t mesg) ... static int tpm_st33_i2c_pm_resume(struct i2c_client *client

Re: [PATCH] char/tpm: Use struct dev_pm_ops for power management

2012-12-06 Thread Kent Yoder
On Thu, Dec 06, 2012 at 01:20:51AM +0100, Peter Huewe wrote: This patch converts the suspend and resume functions for tpm_i2c_stm_st33 to the new dev_pm_ops. Ignore my last mail. I'll take a look at this. Thanks, Kent Signed-off-by: Peter Huewe peterhu...@gmx.de --- Note: I'm sending

Re: [PATCH] char/tpm: Use struct dev_pm_ops for power management

2012-12-06 Thread Kent Yoder
On Thu, Dec 06, 2012 at 01:20:51AM +0100, Peter Huewe wrote: This patch converts the suspend and resume functions for tpm_i2c_stm_st33 to the new dev_pm_ops. Signed-off-by: Peter Huewe peterhu...@gmx.de One minor tweak, the PM funcs need to be inside CONFIG_PM_SLEEP to avoid warnings when

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x

2012-12-05 Thread Kent Yoder
On Wed, Dec 05, 2012 at 10:14:48PM +0100, Peter Hüwe wrote: > Hi Kent, Matthias, > > Am Mittwoch, 5. Dezember 2012, 19:07:20 schrieb Kent Yoder: > > Heh, duh, well of course it is. I've now staged everything I'm > > planning on pushing at: > > > > git://github.

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x

2012-12-05 Thread Kent Yoder
On Wed, Dec 05, 2012 at 09:20:47PM +0100, Peter Hüwe wrote: > Hi Kent, > > > > Heh, duh, well of course it is. I've now staged everything I'm > > planning on pushing at: > > > > git://github.com/shpedoikal/linux.git tpmdd-12-05-12 > > > > Please test and let me know if I missed anything. > >

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x

2012-12-05 Thread Kent Yoder
On Wed, Dec 05, 2012 at 11:45:27AM -0600, Kent Yoder wrote: > On Wed, Dec 05, 2012 at 11:13:51AM -0600, Kent Yoder wrote: > > On Wed, Dec 05, 2012 at 05:11:40PM +0100, Mathias LEBLANC wrote: > > > Hi Peter, > > > > > > Thanks for your contribution. > &g

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x

2012-12-05 Thread Kent Yoder
On Wed, Dec 05, 2012 at 11:13:51AM -0600, Kent Yoder wrote: > On Wed, Dec 05, 2012 at 05:11:40PM +0100, Mathias LEBLANC wrote: > > Hi Peter, > > > > Thanks for your contribution. > > I have modified the driver files name and descriptions. > > Regarding the warnin

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x

2012-12-05 Thread Kent Yoder
peterhu...@gmx.de] > Sent: 29 November, 2012 01:05 > To: Mathias LEBLANC > Cc: Kent Yoder; Kent Yoder; Jean-Luc BLANC; linux-kernel@vger.kernel.org; > Rajiv Andrade; tpmdd-de...@lists.sourceforge.net; sir...@jasper.es > Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x

2012-12-05 Thread Kent Yoder
: Kent Yoder; Kent Yoder; Jean-Luc BLANC; linux-kernel@vger.kernel.org; Rajiv Andrade; tpmdd-de...@lists.sourceforge.net; sir...@jasper.es Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x Hi Mathias, please note: I'm writing this email on behalf of myself

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x

2012-12-05 Thread Kent Yoder
On Wed, Dec 05, 2012 at 11:13:51AM -0600, Kent Yoder wrote: On Wed, Dec 05, 2012 at 05:11:40PM +0100, Mathias LEBLANC wrote: Hi Peter, Thanks for your contribution. I have modified the driver files name and descriptions. Regarding the warnings, it's strange. @Kent, could you

Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x

2012-12-05 Thread Kent Yoder
On Wed, Dec 05, 2012 at 11:45:27AM -0600, Kent Yoder wrote: On Wed, Dec 05, 2012 at 11:13:51AM -0600, Kent Yoder wrote: On Wed, Dec 05, 2012 at 05:11:40PM +0100, Mathias LEBLANC wrote: Hi Peter, Thanks for your contribution. I have modified the driver files name and descriptions

  1   2   3   >