Re: [Patch v3 2/2] dmaengine: qcom_bam_dma: Add device tree binding

2014-01-28 Thread Lars-Peter Clausen
On 01/28/2014 07:27 AM, Andy Gross wrote: > Add device tree binding support for the QCOM BAM DMA driver. > > Signed-off-by: Andy Gross > --- > .../devicetree/bindings/dma/qcom_bam_dma.txt | 52 > > 1 file changed, 52 insertions(+) > create mode 100644 Documentation

Re: [alsa-devel] [PATCH v2 1/3] ASoC: atmel_ssc_dai: make option to choose clock

2014-01-26 Thread Lars-Peter Clausen
On 01/27/2014 07:55 AM, Bo Shen wrote: > When SSC works in slave mode, according to the hardware design, the > clock can get from TK pin, also can get from RK pin. So, add one > parameter to choose where the clock from. > > Signed-off-by: Bo Shen > --- > Changes in v2: None > > sound/soc/atmel/

Re: [PATCH v2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-01-26 Thread Lars-Peter Clausen
On 01/26/2014 03:24 PM, Vinod Koul wrote: > On Wed, Jan 22, 2014 at 10:22:45PM +0530, Srikanth Thokala wrote: >> This is the driver for the AXI Video Direct Memory Access (AXI >> VDMA) core, which is a soft Xilinx IP core that provides high- >> bandwidth direct memory access between memory and AXI4

Re: [PATCH v2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-01-26 Thread Lars-Peter Clausen
On 01/26/2014 03:03 PM, Vinod Koul wrote: > On Thu, Jan 23, 2014 at 03:07:32PM +0100, Lars-Peter Clausen wrote: >> On 01/23/2014 03:00 PM, Andy Shevchenko wrote: >>> On Thu, 2014-01-23 at 14:50 +0100, Lars-Peter Clausen wrote: >>>> On 01/23/2014 02:38 PM, Shevchen

Re: [PATCH v2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-01-26 Thread Lars-Peter Clausen
On 01/26/2014 02:59 PM, Vinod Koul wrote: > On Fri, Jan 24, 2014 at 02:24:27PM +0100, Lars-Peter Clausen wrote: >> On 01/24/2014 12:16 PM, Srikanth Thokala wrote: >>> Hi Lars, >>> >>> On Thu, Jan 23, 2014 at 4:55 PM, Lars-Peter Clausen wrote: >>>>

Re: [PATCH] iio: adis16400: Set timestamp as the last element in chan_spec

2014-01-24 Thread Lars-Peter Clausen
On 01/24/2014 12:24 PM, Marcus Folkesson wrote: > This is necessary since timestamp is calculated as the last element > in iio_compute_scan_bytes(). > > Signed-off-by: Marcus Folkesson Looks good, thanks. Acked-by: Lars-Peter Clausen That said, I think we should try to modify the

Re: [PATCH v2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-01-24 Thread Lars-Peter Clausen
On 01/24/2014 12:16 PM, Srikanth Thokala wrote: > Hi Lars, > > On Thu, Jan 23, 2014 at 4:55 PM, Lars-Peter Clausen wrote: >> On 01/22/2014 05:52 PM, Srikanth Thokala wrote: >> [...] >>> +/** >>> + * xilinx_vdma_device_control - Configure DMA channel of

Re: [PATCH v2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-01-23 Thread Lars-Peter Clausen
On 01/23/2014 03:00 PM, Andy Shevchenko wrote: > On Thu, 2014-01-23 at 14:50 +0100, Lars-Peter Clausen wrote: >> On 01/23/2014 02:38 PM, Shevchenko, Andriy wrote: >>> On Thu, 2014-01-23 at 12:25 +0100, Lars-Peter Clausen wrote: >>>> On 01/22/2014 05

Re: [PATCH v2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-01-23 Thread Lars-Peter Clausen
On 01/23/2014 02:38 PM, Shevchenko, Andriy wrote: > On Thu, 2014-01-23 at 12:25 +0100, Lars-Peter Clausen wrote: >> On 01/22/2014 05:52 PM, Srikanth Thokala wrote: > > [...] > >>> + /* Request the interrupt */ >>> + chan->irq = irq_of_parse_and_map(n

Re: [PATCH v2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-01-23 Thread Lars-Peter Clausen
On 01/22/2014 05:52 PM, Srikanth Thokala wrote: [...] > +/** > + * xilinx_vdma_device_control - Configure DMA channel of the device > + * @dchan: DMA Channel pointer > + * @cmd: DMA control command > + * @arg: Channel configuration > + * > + * Return: '0' on success and failure value on error > + *

Re: [alsa-devel] [PATCH] ASoC: core: Use devm_kzalloc() instead kzalloc()

2014-01-16 Thread Lars-Peter Clausen
On 01/16/2014 09:44 AM, Xiubo Li wrote: Makes the code slightly shorter Signed-off-by: Xiubo Li I don't like this. I don't think it is a good design pattern to call devm function from within (especial non-devm) library functions. It creates an asymmetric API. The memory is allocated when sn

Re: [PATCH] ASoC: core: Fix possible NULL pointer dereference of pcm->config

2014-01-16 Thread Lars-Peter Clausen
On 01/16/2014 09:08 AM, Xiubo Li wrote: Since the soc generic dmaengine pcm driver allows using the defualt settings, so the pcm->config maybe NULL. Signed-off-by: Xiubo Li Acked-by: Lars-Peter Clausen Thanks. I actually had the very same patch locally, but overlooked it. It would be g

[PATCH resend] clk: axi-clkgen: Add support for v2

2014-01-13 Thread Lars-Peter Clausen
for v1 and v2 in callback functions. Signed-off-by: Lars-Peter Clausen --- .../devicetree/bindings/clock/axi-clkgen.txt | 2 +- drivers/clk/clk-axi-clkgen.c | 312 ++--- 2 files changed, 270 insertions(+), 44 deletions(-) diff --git a/Documentation

Re: [alsa-devel] [RFC] ASoC: Adding trivial codec drivers

2014-01-05 Thread Lars-Peter Clausen
On 01/05/2014 02:09 PM, Florian Meier wrote: > This is not intended to be a real patch. > I would just like to ask if this is the preferred way > to add codec and machine driver for codecs without > I2C or SPI configuration possibilities or should I > rather use a more generic approach? > Shoul

Re: [PATCH v3 1/2] usb: musb: add support for JZ4740 usb device controller

2014-01-04 Thread Lars-Peter Clausen
layer. JZ4740 UDC not being OTG compatible and missing some hardware registers, this musb glue layer is written from scratch to be used in gadget mode only and take silicon design specifics into account. Signed-off-by: Apelete Seketeli Signed-off-by: Lars-Peter Clausen --- drivers/usb/musb

Re: [alsa-devel] [PATCH] ASoC: generic: add generic compound card with DT support

2014-01-01 Thread Lars-Peter Clausen
On 01/01/2014 09:08 PM, Jean-Francois Moine wrote: > On Wed, 01 Jan 2014 20:05:05 +0100 > Lars-Peter Clausen wrote: > >> As Mark also said, this binding definitely leaks way too much internals of >> the current ASoC implementation. In my opinion the way forward for

Re: [alsa-devel] [PATCH] ASoC: generic: add generic compound card with DT support

2014-01-01 Thread Lars-Peter Clausen
On 12/31/2013 11:31 AM, Jean-Francois Moine wrote: > Some audio cards are built from different hardware components. > When such compound cards don't need specific code, this driver creates > them with the required DAI links and routes from a DT. > > Signed-off-by: Jean-Francois Moine > --- > This

Re: [alsa-devel] [PATCH] ASoC: simple-card: Add device's module clock selection.

2014-01-01 Thread Lars-Peter Clausen
On 12/23/2013 08:25 AM, Xiubo Li wrote: > diff --git a/a.out b/a.out > new file mode 100644 > index 000..e69de29 This patch did add a empty a.out file in the toplevel folder. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord.

Re: [PATCH] mips: qi_lb60: add defconfig for Ben NanoNote

2013-12-21 Thread Lars-Peter Clausen
On 12/18/2013 10:36 PM, Apelete Seketeli wrote: > Add defconfig for the Ben NanoNote handheld computer which is built > around QI_LB60 board and Ingenic JZ4740 MIPS SoC. > > Signed-off-by: Apelete Seketeli Acked-by: Lars-Peter Clausen > --- > arch/mips/configs/qi_lb6

Re: [PATCH] arch: mips: update platform data for JZ4740 usb device controller

2013-12-20 Thread Lars-Peter Clausen
re community. > > Update platform data for JZ4740 USB device controller to be used with > musb driver. > > Signed-off-by: Apelete Seketeli Acked-by: Lars-Peter Clausen > --- > arch/mips/include/asm/mach-jz4740/platform.h |1 + > arch/mips/jz4740/board-qi_lb60.c |

Re: [alsa-devel] [PATCH] ASoC: dmaengine: Add config parameter NULL check.

2013-12-17 Thread Lars-Peter Clausen
using it. > > Signed-off-by: Xiubo Li Acked-by: Lars-Peter Clausen Thanks. > --- > sound/soc/soc-generic-dmaengine-pcm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/soc-generic-dmaengine-pcm.c > b/sound/soc/soc-generic-d

Re: [PATCH v2 03/16] ARM: dts: provide DMA config to pxamci

2013-12-16 Thread Lars-Peter Clausen
On 12/16/2013 12:47 PM, Sergei Ianovich wrote: > On Mon, 2013-12-16 at 10:58 +0100, Daniel Mack wrote: >> On 12/14/2013 08:34 PM, Sergei Ianovich wrote: >>> On Sat, 2013-12-14 at 20:06 +0100, Arnd Bergmann wrote: >> The patch looks ok in case we are merging your patches for 3.14 and Danie

Re: [PATCH v14] dmaengine: Add MOXA ART DMA engine driver

2013-12-13 Thread Lars-Peter Clausen
On 12/12/2013 01:32 PM, Jonas Jensen wrote: > The MOXA ART SoC has a DMA controller capable of offloading expensive > memory operations, such as large copies. This patch adds support for > the controller including four channels. Two of these are used to > handle MMC copy on the UC-7112-LX hardware.

Re: [RFC PATCH] dma: pl330: Change pl330_tx_status()

2013-12-09 Thread Lars-Peter Clausen
On 12/09/2013 12:19 PM, Lukasz Czerwinski wrote: > This patch adds possibility to read status of unfinished transfers > before termination. > > Signed-off-by: Lukasz Czerwinski > Signed-off-by: Kyungmin Park > --- > > I tested patch with Exynos4 board. This is only proof of concept. > Any comme

[PATCH resend 1/2] pwm: jz4740: Pass device to clk_get()

2013-12-07 Thread Lars-Peter Clausen
In preparation to switching the jz4740 clk driver to the common clk framework make sure to pass the device to clk_get(). Signed-off-by: Lars-Peter Clausen --- drivers/pwm/pwm-jz4740.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-jz4740.c b/drivers/pwm

[PATCH resend 2/2] pwm: jz4740: Use devm_clk_get()

2013-12-07 Thread Lars-Peter Clausen
Using the managed version of clk_get() makes the code a bit shorter and the error paths less complicated. Signed-off-by: Lars-Peter Clausen --- drivers/pwm/pwm-jz4740.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/drivers/pwm/pwm-jz4740.c b/drivers

Re: [alsa-devel] [PATCH 1/2] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation

2013-12-03 Thread Lars-Peter Clausen
On 12/03/2013 01:15 PM, Lars-Peter Clausen wrote: > On 12/03/2013 01:04 PM, Lee Jones wrote: >> On Tue, 03 Dec 2013, Lars-Peter Clausen wrote: >> >>> On 12/03/2013 11:27 AM, Lee Jones wrote: >>>> If booting with full DT support (i.e. DMA too, the last piece of

Re: [alsa-devel] [PATCH 1/2] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation

2013-12-03 Thread Lars-Peter Clausen
On 12/03/2013 01:04 PM, Lee Jones wrote: > On Tue, 03 Dec 2013, Lars-Peter Clausen wrote: > >> On 12/03/2013 11:27 AM, Lee Jones wrote: >>> If booting with full DT support (i.e. DMA too, the last piece of the >>> puzzle), then we don't need to use the compatib

Re: [alsa-devel] [PATCH 1/2] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation

2013-12-03 Thread Lars-Peter Clausen
removed soon anyway it should be fine. Reviewed-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [alsa-devel] [PATCH 3/3] ASoC: ux500: Dynamically fill DAI driver data on probe

2013-12-03 Thread Lars-Peter Clausen
On 12/03/2013 09:40 AM, Lee Jones wrote: On Mon, 02 Dec 2013, Lars-Peter Clausen wrote: On 12/02/2013 07:00 PM, Lee Jones wrote: [...] +void ux500_msp_populate_dai_drv(struct snd_soc_dai_driver *ux500_msp_dai_drv) +{ + ux500_msp_dai_drv->probe = ux500_msp_dai_pr

Re: [alsa-devel] [PATCH 2/3] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation

2013-12-03 Thread Lars-Peter Clausen
On 12/03/2013 09:36 AM, Lee Jones wrote: On Mon, 02 Dec 2013, Lars-Peter Clausen wrote: On 12/02/2013 07:00 PM, Lee Jones wrote: If booting with full DT support (i.e. DMA too, the last piece of the puzzle), then we don't need to use the compatible request channel call back. We also re

Re: [alsa-devel] [PATCH 1/3] ASoC: ux500_pcm: Stop pretending that we support varying address widths

2013-12-02 Thread Lars-Peter Clausen
On 12/02/2013 07:00 PM, Lee Jones wrote: > The Slave Config's addr_width attribute is populated by data_width of > dma_cfg, which in turn is derived from dma_params' data_size attribute > and that comes from the slot_width which is always 16 bits (2 Bytes). > We're cutting out the middle man here a

Re: [alsa-devel] [PATCH 2/3] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation

2013-12-02 Thread Lars-Peter Clausen
On 12/02/2013 07:00 PM, Lee Jones wrote: > If booting with full DT support (i.e. DMA too, the last piece of the > puzzle), then we don't need to use the compatible request channel call > back. We also require slightly different flags to inform the core that > we are booting with DT. I don't think

Re: [alsa-devel] [PATCH 3/3] ASoC: ux500: Dynamically fill DAI driver data on probe

2013-12-02 Thread Lars-Peter Clausen
On 12/02/2013 07:00 PM, Lee Jones wrote: [...] > +void ux500_msp_populate_dai_drv(struct snd_soc_dai_driver *ux500_msp_dai_drv) > +{ > + ux500_msp_dai_drv->probe = ux500_msp_dai_probe; > + ux500_msp_dai_drv->suspend = NULL; > + ux500_msp_dai_drv->resume

Re: [PATCH] lib/vsprintf.c: add %paD format specifier for dma_addr_t types

2013-11-29 Thread Lars-Peter Clausen
On 11/29/2013 11:10 PM, Joe Perches wrote: On Fri, 2013-11-29 at 14:56 +0200, Andy Shevchenko wrote: On Thu, 2013-11-28 at 10:32 -0800, Joe Perches wrote: On Thu, 2013-11-28 at 13:28 +0200, user.email wrote: From: Andy Shevchenko Add the %paD format specifier for printing a dma_addr_t type,

Re: [PATCH V2] dma: add common of_dma_slave_xlate()

2013-11-25 Thread Lars-Peter Clausen
On 11/26/2013 02:25 AM, Stephen Warren wrote: [...] > +struct dma_chan *of_dma_slave_xlate(struct of_phandle_args *dma_spec, > + struct of_dma *ofdma) > +{ > + struct of_dma_slave_xlate_info *info = ofdma->of_dma_data; > + struct dma_chan *candidate, *chan; >

[PATCH] clk: axi-clkgen: Add support for v2

2013-11-25 Thread Lars-Peter Clausen
for v1 and v2 in callback functions. Signed-off-by: Lars-Peter Clausen --- .../devicetree/bindings/clock/axi-clkgen.txt | 2 +- drivers/clk/clk-axi-clkgen.c | 312 ++--- 2 files changed, 270 insertions(+), 44 deletions(-) diff --git a/Documentation

Re: [PATCH 08/10] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation

2013-11-19 Thread Lars-Peter Clausen
On 11/19/2013 08:33 PM, Lee Jones wrote: > On Tue, 19 Nov 2013, Mark Brown wrote: > >> On Tue, Nov 19, 2013 at 11:07:47AM +, Lee Jones wrote: >> >>> require slightly different flags to inform the core that we 'are' >>> booting with DT. >> >> Is there some situation when we would want to say we

Re: [PATCHv3] ASoC: Add support for BCM2835

2013-11-18 Thread Lars-Peter Clausen
On 11/18/2013 03:16 PM, Mark Rutland wrote: > >> +static void bcm2835_i2s_stop_clock(struct bcm2835_i2s_dev *dev) >> +{ >> + uint32_t clkreg; > > s/uint32_t/u32/ (and elsewhere...) Please don't do that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [alsa-devel] [RFCv2] ASoC: Add support for BCM2835

2013-11-16 Thread Lars-Peter Clausen
On 11/12/2013 07:41 PM, Florian Meier wrote: > This driver adds support for digital audio (I2S) > for the BCM2835 SoC that is used by the > Raspberry Pi. External audio codecs can be > connected to the Raspberry Pi via P5 header. > > It relies on cyclic DMA engine support for BCM2835. > > Signed-

Re: [alsa-devel] [RFC] ASoC: Add support for BCM2835

2013-11-11 Thread Lars-Peter Clausen
On 11/08/2013 09:56 PM, Florian Meier wrote: Is the I2S clock part of a generic clocking module? If yes it might be better to implement this as a clock chip driver. [...] > +static void bcm2835_i2s_stop(struct bcm2835_i2s_dev *dev, > + struct snd_pcm_substream *substream) > +{ > +

Re: [alsa-devel] [PATCHv2] dmaengine: Add support for BCM2835.

2013-11-11 Thread Lars-Peter Clausen
On 11/11/2013 05:33 PM, Florian Meier wrote: [...] > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include No driver (other than irqchip drivers) should ever need to include irq.h > +#include > +

Re: [alsa-devel] [PATCH 08/13] ASoC: generic-dmaengine-pcm: Clear slave_config memory

2013-11-06 Thread Lars-Peter Clausen
ed to memset it to clear the data area. > > Cc: alsa-de...@alsa-project.org > Cc: Mark Brown > Signed-off-by: Lee Jones Acked-by: Lars-Peter Clausen Thanks. > --- > sound/soc/soc-generic-dmaengine-pcm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sou

Re: [PATCH v3 02/10] spmi: Linux driver framework for SPMI

2013-10-29 Thread Lars-Peter Clausen
On 10/29/2013 04:56 PM, Josh Cartwright wrote: >>> +{ >>> + int dummy; >>> + >>> + if (!ctrl) >>> + return -EINVAL; >>> + >>> + dummy = device_for_each_child(&ctrl->dev, NULL, >>> + spmi_ctrl_remove_device); >>> + device_unregister(&ctrl->dev); >> >

Re: [PATCH v3 02/10] spmi: Linux driver framework for SPMI

2013-10-29 Thread Lars-Peter Clausen
On 10/29/2013 05:30 PM, Stephen Boyd wrote: > On 10/29/13 08:56, Josh Cartwright wrote: >> +#define to_spmi_controller(d) container_of(d, struct spmi_controller, dev) >>> Should be a inline function for better type safety. >> Sounds good. Will change the to_spmi_*() macros. > > I was under t

Re: [PATCH v3 02/10] spmi: Linux driver framework for SPMI

2013-10-29 Thread Lars-Peter Clausen
Couple of high-level comments on the in-kernel API. On 10/28/2013 07:12 PM, Josh Cartwright wrote: > +#ifdef CONFIG_PM_SLEEP > +static int spmi_pm_suspend(struct device *dev) > +{ > + const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL; > + > + if (pm) > + return

Re: [PATCH 2/4] charger-manager: Use IIO subsystem to read battery temperature instead of legacy method

2013-10-26 Thread Lars-Peter Clausen
On 10/22/2013 02:51 PM, Chanwoo Choi wrote: > This patch support charger-manager use IIO(Industrial I/O) subsystem to read > current battery temperature instead of legacy methor about callback function. How does this look in hardware? Do you have a general purpose ADC connected to a temperature se

Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-17 Thread Lars-Peter Clausen
On 10/17/2013 11:01 AM, Xiubo Li wrote: [...] > +static int fsl_sai_hw_params(struct snd_pcm_substream *substream, > + struct snd_pcm_hw_params *params, > + struct snd_soc_dai *cpu_dai) > +{ > + int ret; > + > + ret = fsl_sai_hw_params_tr(substream, params, cpu_dai,

Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-17 Thread Lars-Peter Clausen
On 10/17/2013 03:37 PM, Timur Tabi wrote: > Lars-Peter Clausen wrote: >>> >Maybe I've been out of the loop for too long, but why is that a particular >>> >problem with this driver? > >> It is usually something you'd want to check in general to make su

Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-17 Thread Lars-Peter Clausen
On 10/17/2013 03:22 PM, Timur Tabi wrote: > Lars-Peter Clausen wrote: >>>> >>+res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>>> >>+sai->base = devm_ioremap_resource(&pdev->dev, res); >>> > >>> >Why not u

Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-17 Thread Lars-Peter Clausen
On 10/17/2013 02:15 PM, Timur Tabi wrote: > Xiubo Li wrote: >> +res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> +sai->base = devm_ioremap_resource(&pdev->dev, res); > > Why not use of_iomap()? Because it won't check for conflicting resource regions. - Lars -- To unsubscribe fro

Re: [PATCH] dma: pl330: Support per channel irq allocation

2013-10-13 Thread Lars-Peter Clausen
ill 2. But I will send separate patch for it directly to Russell. Thanks, this patch looks fine, Lars can you try testing this if you have this HW please? ~Vinod Michal and I are using the same hardware, I have his patch in my tree and it is working fine. Tested-by: Lars-Peter Clausen T

Re: [PATCH v3] iio: exynos_adc: use wait_for_completion_timeout instead of interruptible

2013-10-11 Thread Lars-Peter Clausen
9591/ > > Signed-off-by: Naveen Krishna Chatradhi > Cc: Doug Anderson > Cc: Lars-Peter Clausen > --- > Changes since v1: > As per discussion at > http://marc.info/?l=linux-kernel&m=136517637228869&w=3 > > This patch does th

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-11 Thread Lars-Peter Clausen
On 10/11/2013 10:59 AM, Belisko Marek wrote: > Hi Tomi, > > On Fri, Oct 11, 2013 at 10:17 AM, Tomi Valkeinen > wrote: >> On 11/10/13 10:42, Dr. H. Nikolaus Schaller wrote: >> >>> I am not sure if there is a SPI driver for a McBSP port [1]? And to make >>> that >>> work (reliably) and tested it

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-11 Thread Lars-Peter Clausen
On 10/11/2013 06:41 AM, Tomi Valkeinen wrote: On 10/10/13 21:58, Lars-Peter Clausen wrote: According to the datasheet the the panel as a dedicated dout pin. Maybe you did not connect it in your design, which means you won't be able to read any data from the panel at all. I don&#x

Re: [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep

2013-10-10 Thread Lars-Peter Clausen
On 10/10/2013 09:43 PM, Wolfram Sang wrote: On Thu, Oct 10, 2013 at 10:46:41AM +0200, Lars-Peter Clausen wrote: + if (gpio_cansleep(gpio)) + gpio_set_value_cansleep(gpio, val & (1 << i)); + else + gpio_set_value

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-10 Thread Lars-Peter Clausen
On 10/10/2013 03:42 PM, Dr. H. Nikolaus Schaller wrote: Am 10.10.2013 um 14:26 schrieb Lars-Peter Clausen: On 10/10/2013 02:13 PM, Tomi Valkeinen wrote: On 10/10/13 14:52, Dr. H. Nikolaus Schaller wrote: Yes, I agree and I am willing to help if someone comes up with such a SoC. At the

Re: [PATCH] omapdss: Add new panel driver for Topolly td028ttec1 LCD.

2013-10-10 Thread Lars-Peter Clausen
On 10/10/2013 02:13 PM, Tomi Valkeinen wrote: > On 10/10/13 14:52, Dr. H. Nikolaus Schaller wrote: > >> Yes, I agree and I am willing to help if someone comes up with such a SoC. >> At the moment we have connected it to the OMAP3 only. > > True, but even without that kind of SoC, SPI bitbanging s

Re: [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep

2013-10-10 Thread Lars-Peter Clausen
On 10/10/2013 10:39 AM, Ionut Nicu wrote: > Some gpio chips may have get/set operations that > can sleep. For this type of chips we must use the > _cansleep() version of gpio_set_value. > > Signed-off-by: Ionut Nicu > --- > drivers/i2c/muxes/i2c-mux-gpio.c | 11 --- > 1 files changed,

Re: [PATCH] IIO AD7923 iio_consumer support

2013-10-05 Thread Lars-Peter Clausen
On 10/05/2013 11:39 AM, leroy christophe wrote: > > Le 05/10/2013 11:35, Lars-Peter Clausen a écrit : >> On 10/05/2013 11:18 AM, leroy christophe wrote: >>> Le 05/10/2013 10:41, Lars-Peter Clausen a écrit : >>>> On 10/05/2013 10:21 AM, Christophe Leroy wrote:

Re: [PATCH] IIO AD7923 iio_consumer support

2013-10-05 Thread Lars-Peter Clausen
On 10/05/2013 11:18 AM, leroy christophe wrote: > > Le 05/10/2013 10:41, Lars-Peter Clausen a écrit : >> On 10/05/2013 10:21 AM, Christophe Leroy wrote: >>> +.consumer_channel = "channel_0", >>> +.adc_channel_label = "0", >

Re: [PATCH] IIO AD7923 iio_consumer support

2013-10-05 Thread Lars-Peter Clausen
On 10/05/2013 10:21 AM, Christophe Leroy wrote: > This patch adds support for iio_consumer to Analog Devices AD7923 ADC driver. > > Signed-off-by: Christophe Leroy > Verified-by: Patrick Vasseur > > diff -urN a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c > --- a/drivers/iio/adc/ad7923.c

Re: [PATCH v2 2/3] i2c: xilinx: Set tx direction in write operation

2013-10-04 Thread Lars-Peter Clausen
On 10/04/2013 03:09 PM, Michal Simek wrote: > > > On 10/04/2013 02:12 PM, Lars-Peter Clausen wrote: >> On 10/04/2013 01:55 PM, Wolfram Sang wrote: >>> On Fri, Oct 04, 2013 at 11:53:49AM +0200, Michal Simek wrote: >>>> On 10/04/2013 07:46 AM, Wolfram

Re: [PATCH v2 2/3] i2c: xilinx: Set tx direction in write operation

2013-10-04 Thread Lars-Peter Clausen
On 10/04/2013 01:55 PM, Wolfram Sang wrote: > On Fri, Oct 04, 2013 at 11:53:49AM +0200, Michal Simek wrote: >> On 10/04/2013 07:46 AM, Wolfram Sang wrote: >>> + cr = xiic_getreg32(i2c, XIIC_CR_REG_OFFSET); + cr |= XIIC_CR_DIR_IS_TX_MASK; + xiic_setreg32(i2c, XIIC_CR_REG_OFFSET, cr

Re: [PATCH] staging:iio: fix wrong usage of dev_set_name()

2013-10-03 Thread Lars-Peter Clausen
On 10/03/2013 04:57 PM, Sangjung Woo wrote: > The second parameter of dev_set_name() is format string. In order to > avoid any potential accidents such as segmentation fault, basic format > parameter "%s" should be used in this case. Since "iio_evgen" is a constant string there is really no need f

Re: [PATCH 1/3] spi: Add a spi_w8r16be() helper

2013-10-03 Thread Lars-Peter Clausen
On 09/29/2013 02:30 PM, Mark Brown wrote: > On Fri, Sep 27, 2013 at 10:01:36PM +0200, Lars-Peter Clausen wrote: >> On 09/27/2013 09:22 PM, Mark Brown wrote: > >>> Indeed. I don't think that's terribly well thought through though, >>> especially not now we

[PATCH 1/8] [media] s5c73m3: Don't use i2c_client->driver

2013-09-29 Thread Lars-Peter Clausen
The 'driver' field of the i2c_client struct is redundant and is going to be removed. The results of the expressions 'client->driver.driver->field' and 'client->dev.driver->field' are identical, so replace all occurrences of the former with the lat

[PATCH 7/8] ASoC: imx-wm8962: Don't use i2c_client->driver

2013-09-29 Thread Lars-Peter Clausen
The 'driver' field of the i2c_client struct is redundant and is going to be removed. Check i2c_client->dev.driver instead to see if a driver is bound to the device. Signed-off-by: Lars-Peter Clausen --- sound/soc/fsl/imx-wm8962.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH 3/8] [media] core: Don't use i2c_client->driver

2013-09-29 Thread Lars-Peter Clausen
The 'driver' field of the i2c_client struct is redundant and is going to be removed. The results of the expressions 'client->driver.driver->field' and 'client->dev.driver->field' are identical, so replace all occurrences of the former with the

[PATCH 8/8] i2c: Remove redundant 'driver' field from the i2c_client struct

2013-09-29 Thread Lars-Peter Clausen
removes the 'driver' field from the i2c_client struct. Signed-off-by: Lars-Peter Clausen --- drivers/i2c/i2c-core.c | 21 - drivers/i2c/i2c-smbus.c | 10 ++ include/linux/i2c.h | 2 -- 3 files changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/

[PATCH 2/8] [media] exynos4-is: Don't use i2c_client->driver

2013-09-29 Thread Lars-Peter Clausen
The 'driver' field of the i2c_client struct is redundant and is going to be removed. The results of the expressions 'client->driver.driver->field' and 'client->dev.driver->field' are identical, so replace all occurrences of the former with the lat

[PATCH 6/8] ALSA: ppc: keywest: Don't use i2c_client->driver

2013-09-29 Thread Lars-Peter Clausen
The 'driver' field of the i2c_client struct is redundant and is going to be removed. Use 'to_i2c_driver(client->dev.driver)' instead to get direct access to the i2c_driver struct. Signed-off-by: Lars-Peter Clausen --- sound/ppc/keywest.c | 4 ++-- 1 file changed, 2 ins

[PATCH 5/8] drm: nouveau: Don't use i2c_client->driver

2013-09-29 Thread Lars-Peter Clausen
The 'driver' field of the i2c_client struct is redundant and is going to be removed. Use 'to_i2c_driver(client->dev.driver)' instead to get direct access to the i2c_driver struct. Signed-off-by: Lars-Peter Clausen Cc: Martin Peres --- drivers/gpu/drm/nouveau/core/subde

[PATCH 4/8] drm: encoder_slave: Don't use i2c_client->driver

2013-09-29 Thread Lars-Peter Clausen
get direct access to the i2c_driver struct use 'to_i2c_driver(client->dev.driver)'. Signed-off-by: Lars-Peter Clausen --- drivers/gpu/drm/drm_encoder_slave.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_encoder_slave.c b/drivers/gp

[PATCH 0/8] i2c: Remove redundant driver field from the i2c_client struct

2013-09-29 Thread Lars-Peter Clausen
nd of course also the runtime memory footprint of the i2c_client struct is reduced. - Lars Lars-Peter Clausen (8): [media] s5c73m3: Don't use i2c_client->driver [media] exynos4-is: Don't use i2c_client->driver [media] core: Don't use i2c_client->driver drm: encoder_slav

Re: [PATCH 1/3] spi: Add a spi_w8r16be() helper

2013-09-27 Thread Lars-Peter Clausen
On 09/27/2013 09:22 PM, Mark Brown wrote: > On Fri, Sep 27, 2013 at 08:46:56PM +0200, Lars-Peter Clausen wrote: > >> According to the documentation of spi_w8r16() it is a feature. > >> * The number is returned in wire-order, which is at least sometimes >> *

Re: [PATCH 1/3] spi: Add a spi_w8r16be() helper

2013-09-27 Thread Lars-Peter Clausen
On 09/27/2013 08:34 PM, Mark Brown wrote: > On Fri, Sep 27, 2013 at 04:34:27PM +0200, Lars-Peter Clausen wrote: >> This patch adds a new spi_w8r16be() helper, which is similar to spi_w8r16() >> except that it converts the read data word from big endian to native >> endiannes

[PATCH 1/3] spi: Add a spi_w8r16be() helper

2013-09-27 Thread Lars-Peter Clausen
e not mixing different endiannesses in the same variable. Signed-off-by: Lars-Peter Clausen --- I don't expect any conflicts, so in my opinion it should be fine to merge the two users also through the SPI tree. Otherwise we can also just hold them off by one release. --- include/linux/spi/

[PATCH 3/3] staging:iio:ade7753/ade7754/ade7759: Use spi_w8r16be() instead of spi_w8r16()

2013-09-27 Thread Lars-Peter Clausen
type in argument 1 (different base types) drivers/staging/iio/meter/ade7759.c:97:29:expected restricted __be16 const [usertype] *p drivers/staging/iio/meter/ade7759.c:97:29:got unsigned short [usertype] *val Signed-off-by: Lars-Peter Clausen --- drivers/staging/iio/meter

[PATCH 2/3] hwmon: (adt7310) Use spi_w8r16be() instead spi_w8r16()

2013-09-27 Thread Lars-Peter Clausen
Using spi_w8r16be() instead of spi_w8r16() in this driver makes a code a bit shorter and cleaner. Signed-off-by: Lars-Peter Clausen --- drivers/hwmon/adt7310.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/hwmon/adt7310.c b/drivers/hwmon/adt7310.c index

Re: [PATCH] regulator: of_get_regulation_constraints: Use node name as fallback

2013-09-23 Thread Lars-Peter Clausen
On 09/23/2013 12:15 PM, Mark Brown wrote: On Sun, Sep 22, 2013 at 12:47:34PM +0200, Lars-Peter Clausen wrote: If the "regulator-name" property is not present use the name of the devicetree node as a fallback. You're not supposed to use the node name for anything, the go

[PATCH] regulator: of_get_regulation_constraints: Use node name as fallback

2013-09-22 Thread Lars-Peter Clausen
If the "regulator-name" property is not present use the name of the devicetree node as a fallback. Signed-off-by: Lars-Peter Clausen --- drivers/regulator/of_regulator.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_r

Re: [PATCH 0/2] vsprintf: ignore %n again

2013-09-16 Thread Lars-Peter Clausen
On 09/16/2013 05:55 PM, Al Viro wrote: > On Mon, Sep 16, 2013 at 12:43:55AM -0700, Kees Cook wrote: >> Whether seq_printf should return void or error, %n still needs to be removed. >> As such, instead of changing the seq_file structure and adding instructions >> to all callers of seq_printf, just e

Re: [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor device names

2013-09-16 Thread Lars-Peter Clausen
On 09/16/2013 03:31 PM, Lee Jones wrote: >> Honestly I don't care either way on these, but consistency would definitely >> be good so applied to the togreg branch of iio.git > > For clarification, is togreg due for the v3.12 merge window or will be > get a settling period in -next? > Well everyt

Re: [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor device names

2013-09-16 Thread Lars-Peter Clausen
On 09/16/2013 11:21 AM, Denis CIOCCA wrote: > Hi Lars, >> On 09/14/2013 02:27 PM, Jonathan Cameron wrote: >>> On 09/14/13 13:14, Jonathan Cameron wrote: On 09/10/13 13:49, Lee Jones wrote: > Some of ST's sensors are appended with their sensor type and some > are not. For consistency we

[PATCH] kfifo: kfifo_copy_{to,from}_user: Fix copied bytes calculation

2013-09-16 Thread Lars-Peter Clausen
'copied' and 'len' are in bytes, while 'ret' is in elements, so we need to multiply 'ret' with the size of one element to get the correct result. Signed-off-by: Lars-Peter Clausen --- lib/kfifo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor device names

2013-09-16 Thread Lars-Peter Clausen
On 09/14/2013 02:27 PM, Jonathan Cameron wrote: > On 09/14/13 13:14, Jonathan Cameron wrote: >> On 09/10/13 13:49, Lee Jones wrote: >>> Some of ST's sensors are appended with their sensor type and some >>> are not. For consistency we're extending the same naming convention >>> throughout. >>> >>> S

Re: [PATCH 27/38] iio: pressure-core: st: Give some indication if device probing was successful

2013-09-11 Thread Lars-Peter Clausen
On 09/11/2013 09:10 AM, Lee Jones wrote: On Tue, 10 Sep 2013, Jonathan Cameron wrote: Lee Jones wrote: At the moment the driver is silent in some error cases and if successful. Prior to this patch there was no clear way to know if the driver succeeded or not without looking deep into sysfs. S

Re: [PATCH 11/11] iio: pressure-core: st: Provide correct regulator support

2013-09-04 Thread Lars-Peter Clausen
On 09/04/2013 03:11 PM, Mark Rutland wrote: > Hi Lee, > > On Wed, Sep 04, 2013 at 10:31:43AM +0100, Lee Jones wrote: >> The power to some of the sensors are controlled by regulators. In most >> cases these are 'always on', but if not they will fail to work until >> the regulator is enabled using t

Re: [PATCH] dmaengine: dma_slave_caps: remove sg entries

2013-09-02 Thread Lars-Peter Clausen
On 09/02/2013 06:12 PM, Vinod Koul wrote: > On Mon, Sep 02, 2013 at 04:52:06PM +0200, Lars-Peter Clausen wrote: >> On 09/02/2013 02:21 PM, Vinod Koul wrote: >>> As pointed by Russell in [1], the sg properties are already availble in >>> struct device, >>> so n

Re: [PATCH] dmaengine: dma_slave_caps: remove sg entries

2013-09-02 Thread Lars-Peter Clausen
On 09/02/2013 02:21 PM, Vinod Koul wrote: > As pointed by Russell in [1], the sg properties are already availble in > struct device, > so no need to duplicate here. > > [1]: http://marc.info/?l=linux-omap&m=137416733628831 Hm, I guess that will work as well, but shouldn't we update the drivers t

Re: Clock framework deadlock with external SPI clockchip

2013-09-02 Thread Lars-Peter Clausen
On 09/02/2013 01:18 PM, Peter De Schrijver wrote: > On Fri, Aug 30, 2013 at 03:24:45PM +0200, Lars-Peter Clausen wrote: >> Hi, >> >> I'm currently facing a deadlock in the common clock framework that >> unfortunately is not addressed by the reentrancy patches. I ha

[PATCH] ASoC: dapm: Fix auto-disable for inverted controls

2013-08-30 Thread Lars-Peter Clausen
We need to make sure that the control's cached value is initialized to the same value as the control's widget->on_val. Otherwise updates might be lost. Signed-off-by: Lars-Peter Clausen --- sound/soc/soc-dapm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/soc-d

Clock framework deadlock with external SPI clockchip

2013-08-30 Thread Lars-Peter Clausen
Hi, I'm currently facing a deadlock in the common clock framework that unfortunately is not addressed by the reentrancy patches. I have a external clock chip that is controlled via SPI. So for example to configure the rate of the clock chip you need to send a SPI message. Naturally the clock frame

[PATCH v2 3/3] regmap: rbtree: Make cache_present bitmap per node

2013-08-29 Thread Lars-Peter Clausen
. The parameter is optional and if NULL the core assumes that all registers are set. The rbtree cache also needs to implement its own drop callback instead of relying on the core to handle this. Signed-off-by: Lars-Peter Clausen --- No changes since v1 --- drivers/base/regmap/internal.h

[PATCH v2 1/3] regmap: rbtree: Simplify adjacent node look-up

2013-08-29 Thread Lars-Peter Clausen
ether the register comes before the first register or after the last register of the node. Signed-off-by: Lars-Peter Clausen --- No changes since v1. --- drivers/base/regmap/regcache-rbtree.c | 39 +-- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/dr

[PATCH v2 2/3] regmap: rbtree: Reduce number of nodes, take 2

2013-08-29 Thread Lars-Peter Clausen
4. If we find a node that falls within this range it is cheaper or as expensive to add the register to the existing node and have a couple of unused registers in the node's cache compared to allocating a new node. Signed-off-by: Lars-Peter Clausen --- Changes since v1: * Repair commit me

[PATCH 1/3] regmap: rbtree: Simplify adjacent node lookup

2013-08-28 Thread Lars-Peter Clausen
ether the register comes before the first register or after the last register of the node. Signed-off-by: Lars-Peter Clausen --- drivers/base/regmap/regcache-rbtree.c | 39 +-- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/drivers/base/regmap/reg

[PATCH 2/3] regmap: rbtree: Reduce number of nodes, take 2

2013-08-28 Thread Lars-Peter Clausen
in the node's cache compared to allocating a new node. Signed-off-by: Lars-Peter Clausen --- drivers/base/regmap/regcache-rbtree.c | 53 --- 1 file changed, 36 insertions(+), 17 deletions(-) diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base

[PATCH 3/3] regmap: rbtree: Make cache_present bitmap per node

2013-08-28 Thread Lars-Peter Clausen
is optional and if NULL the core assumes that all registers are set. The rbtree cache also needs to implement its own drop callback instead of relying on the core to handle this. Signed-off-by: Lars-Peter Clausen --- drivers/base/regmap/internal.h| 14 +- drivers/base/regmap/regcache

<    4   5   6   7   8   9   10   11   12   13   >