Re: [LKP] Re: [auxdisplay] b26deabb1d: BUG:kernel_NULL_pointer_dereference,address

2020-11-16 Thread Lars Poeschel
On Thu, Nov 12, 2020 at 01:29:31PM +, Sang, Oliver wrote: > > > > -Original Message- > > From: Lars Poeschel > > Sent: Monday, November 9, 2020 8:40 PM > > To: Sang, Oliver > > Cc: Miguel Ojeda ; lkp ; Willy Tarreau > > ; LKML ; Linux Memo

Re: [auxdisplay] b26deabb1d: BUG:kernel_NULL_pointer_dereference,address

2020-11-09 Thread Lars Poeschel
Hi! And thanks for your report. On Mon, Nov 09, 2020 at 02:29:34PM +0800, kernel test robot wrote: > To reproduce: > > # build kernel > cd linux > cp config-5.10.0-rc2-8-gb26deabb1d91 .config > make HOSTCC=gcc-9 CC=gcc-9 ARCH=i386 olddefconfig prepare >

Re: [PATCH] auxdisplay: fix use after free in lcd2s_i2c_remove()

2020-11-09 Thread Lars Poeschel
On Fri, Nov 06, 2020 at 10:24:15PM +0300, Dan Carpenter wrote: > The kfree() needs to be moved down a line to prevent a use after free. > > Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display") > Signed-off-by: Dan Carpenter > --- > drivers/auxdisplay/lcd2s.c | 2 +- > 1

Re: [PATCH v6 00/25] Make charlcd device independent

2020-11-06 Thread Lars Poeschel
On Wed, Nov 04, 2020 at 02:30:04PM +0100, Miguel Ojeda wrote: > Thanks a lot for all the work, Lars. Queued in -next. I got an email [1] with a report about a build failure in hd44780_common. The fix is simple but I don't know the process from here on. Should I post a v7 of the whole patchset or

Re: [PATCH v5 02/25] auxdisplay: Introduce hd44780_common.[ch]

2020-11-03 Thread Lars Poeschel
On Sat, Oct 31, 2020 at 10:26:30AM +0100, Miguel Ojeda wrote: > Hi Lars, > > On Thu, Oct 29, 2020 at 10:57 AM wrote: > > > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > > index 81757eeded68..a56171d1a1ba 100644 > > --- a/drivers/auxdisplay/Kconfig > > +++

Re: [PATCH 00/25] Make charlcd device independent

2020-10-29 Thread Lars Poeschel
This series was sent wrong. Should be v5. Drop this one. Sorry and thanks, Lars On Thu, Oct 29, 2020 at 10:50:07AM +0100, poesc...@lemonage.de wrote: > From: Lars Poeschel > > This tries to make charlcd device independent. At the moment hd44780 > device specific code is co

Re: [PATCH v4 00/32] Make charlcd device independent

2020-10-22 Thread Lars Poeschel
On Fri, Oct 16, 2020 at 05:59:04AM +0200, Miguel Ojeda wrote: > On Fri, Oct 16, 2020 at 4:33 AM Miguel Ojeda > wrote: > > > > Picking these for linux-next (including Rob's Reviewed-by). I have > > spotted a few typos that I corrected -- I will note them by email. > > Hmm, I think we should do

Re: [PATCH v4 00/32] Make charlcd device independent

2020-10-06 Thread Lars Poeschel
On Mon, Oct 05, 2020 at 05:30:59PM +0200, Miguel Ojeda wrote: > Hi Lars, > > On Mon, Oct 5, 2020 at 2:27 PM wrote: > > > > This tries to make charlcd device independent. > > Thanks a lot for the work! > > I see you have written the differences between versions in each patch, > but given there

Re: [PATCH 1/2] pwm: sysfs: Set class on pwm devices

2020-10-05 Thread Lars Poeschel
On Fri, Oct 02, 2020 at 03:35:12PM +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 02, 2020 at 03:08:44PM +0200, Lars Poeschel wrote: > > On Fri, Oct 02, 2020 at 02:46:16PM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Oct 02, 2020 at 02:30:47PM +0200, poesc...@lemonage.de w

Re: [PATCH] pwm: sysfs: Set class on pwm devices

2020-10-05 Thread Lars Poeschel
On Mon, Oct 05, 2020 at 11:30:16AM +0200, Thierry Reding wrote: > On Thu, Oct 01, 2020 at 01:24:49PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Oct 01, 2020 at 11:05:31AM +0200, Lars Poeschel wrote: > > > On Wed, Sep 30, 2020 at 11:41:46AM +0200, Uwe Kleine-König wr

Re: [PATCH v2 32/32] auxdisplay: lcd2s DT binding doc

2020-10-02 Thread Lars Poeschel
On Tue, Sep 22, 2020 at 09:58:36AM -0600, Rob Herring wrote: > On Mon, 21 Sep 2020 16:46:44 +0200, poesc...@lemonage.de wrote: > > From: Lars Poeschel > > > > Add a binding doc for the modtronix lcd2s auxdisplay driver. It also > > adds modtronix to the li

Re: [PATCH v2 33/33] auxdisplay: add a driver for lcd2s character display

2020-10-02 Thread Lars Poeschel
On Fri, Oct 02, 2020 at 02:42:49PM +0200, Pavel Machek wrote: > Hi! > > > From: Lars Poeschel > > > > This driver allows to use a lcd2s 20x4 character display from modtronix > > engineering as an auxdisplay charlcd device. > > Is there userland interface doc

Re: [PATCH 1/2] pwm: sysfs: Set class on pwm devices

2020-10-02 Thread Lars Poeschel
On Fri, Oct 02, 2020 at 02:46:16PM +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 02, 2020 at 02:30:47PM +0200, poesc...@lemonage.de wrote: > > From: Lars Poeschel > > > > This adds a class to exported pwm devices. > > Exporting a pwm through sysf

Re: [PATCH] pwm: sysfs: Set class on pwm devices

2020-10-01 Thread Lars Poeschel
On Thu, Oct 01, 2020 at 01:24:49PM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 01, 2020 at 11:05:31AM +0200, Lars Poeschel wrote: > > On Wed, Sep 30, 2020 at 11:41:46AM +0200, Uwe Kleine-König wrote: > > > Hello, > > > > > > I added Greg Kroah-Hartman who

Re: [PATCH] pwm: sysfs: Set class on pwm devices

2020-10-01 Thread Lars Poeschel
On Wed, Sep 30, 2020 at 11:41:46AM +0200, Uwe Kleine-König wrote: > Hello, > > I added Greg Kroah-Hartman who I discussed this with via irc a bit to > Cc:. > > On Wed, Sep 30, 2020 at 11:20:56AM +0200, Lars Poeschel wrote: > > thank you for your review! > > >

Re: [PATCH] pwm: sysfs: Set class on pwm devices

2020-09-30 Thread Lars Poeschel
On Wed, Sep 30, 2020 at 01:51:06PM +0200, Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 01:27:20PM +0200, Lars Poeschel wrote: > > On Wed, Sep 30, 2020 at 12:52:38PM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Sep 30, 2020 at 12:01:26PM +0200, Uwe Kleine-König wrote: &

Re: [PATCH] pwm: sysfs: Set class on pwm devices

2020-09-30 Thread Lars Poeschel
ote: > > > > Hello, > > > > > > > > I added Greg Kroah-Hartman who I discussed this with via irc a bit to > > > > Cc:. > > > > > > > > On Wed, Sep 30, 2020 at 11:20:56AM +0200, Lars Poeschel wrote: > > > > > thank y

Re: [PATCH] pwm: sysfs: Set class on pwm devices

2020-09-30 Thread Lars Poeschel
Hi Uwe, thank you for your review! On Wed, Sep 30, 2020 at 08:57:26AM +0200, Uwe Kleine-König wrote: > Hello Lars, > > On Tue, Sep 29, 2020 at 02:19:53PM +0200, poesc...@lemonage.de wrote: > > From: Lars Poeschel > > > > This adds a class to exported pwm devices.

Re: [PATCH] driver core: Remove double assignment

2020-09-29 Thread Lars Poeschel
On Tue, Sep 29, 2020 at 02:25:33PM +0200, Greg Kroah-Hartman wrote: > On Tue, Sep 29, 2020 at 01:58:08PM +0200, poesc...@lemonage.de wrote: > > From: Lars Poeschel > > > > This removes an assignment in device_add. It assigned the parent > > kobject to the

Re: [PATCH v2 31/32] auxdisplay: charlcd: Do not print chars at end of line

2020-09-22 Thread Lars Poeschel
On Tue, Sep 22, 2020 at 12:20:36PM +0200, Miguel Ojeda wrote: > Hi Lars, Willy, > > On Tue, Sep 22, 2020 at 12:04 PM Willy Tarreau wrote: > > > > The points you mention are good enough indicators that it's extremely > > unlikely anyone has ever used that feature with these drivers. So I > >

Re: [PATCH v2 28/32] auxdisplay: hd44780: Remove clear_fast

2020-09-22 Thread Lars Poeschel
On Tue, Sep 22, 2020 at 11:21:21AM +0200, Willy Tarreau wrote: > On Tue, Sep 22, 2020 at 10:49:12AM +0200, Lars Poeschel wrote: > > > I might have got confused, but it looks to me like patches 27 and 28 > > > basically undo patch 26: in 26 you moved code to hd44780 and wrote a

Re: [PATCH v2 31/32] auxdisplay: charlcd: Do not print chars at end of line

2020-09-22 Thread Lars Poeschel
On Tue, Sep 22, 2020 at 07:27:01AM +0200, Willy Tarreau wrote: > On Mon, Sep 21, 2020 at 04:46:43PM +0200, poesc...@lemonage.de wrote: > > From: Lars Poeschel > > > > Skip printing characters at the end of a display line. This fits to the > > behaviour we already had

Re: [PATCH v2 28/32] auxdisplay: hd44780: Remove clear_fast

2020-09-22 Thread Lars Poeschel
Hi Willy, On Tue, Sep 22, 2020 at 07:22:27AM +0200, Willy Tarreau wrote: > Hi Lars, > > On Mon, Sep 21, 2020 at 04:46:40PM +0200, poesc...@lemonage.de wrote: > > From: Lars Poeschel > > > > We remove the hd44780_clear_fast (display) clear implementation. charlc

Re: [PATCH 1/3] auxdisplay: Make charlcd.[ch] more general

2019-10-17 Thread Lars Poeschel
On Wed, Oct 16, 2019 at 06:53:20PM +0200, Miguel Ojeda wrote: > On Wed, Oct 16, 2019 at 10:24 AM Lars Poeschel wrote: > > > > charlcd.c contains lots of hd44780 hardware specific stuff. It is nearly > > impossible to reuse the interface for other character based displays.

Re: [PATCH v9 4/7] nfc: pn533: Split pn533 init & nfc_register

2019-10-16 Thread Lars Poeschel
On Tue, Oct 15, 2019 at 09:16:42AM -0700, Jakub Kicinski wrote: > On Tue, 15 Oct 2019 11:51:24 +0200, Lars Poeschel wrote: > > > > - priv->nfc_dev = nfc_allocate_device(_nfc_ops, protocols, > > > > -

[PATCH 3/3] auxdisplay: add a driver for lcd2s character display

2019-10-16 Thread Lars Poeschel
This driver allows to use a lcd2s 20x4 character display from modtronix engineering as an auxdisplay charlcd device. Signed-off-by: Lars Poeschel --- drivers/auxdisplay/Kconfig | 11 + drivers/auxdisplay/Makefile | 1 + drivers/auxdisplay/lcd2s.c | 411

[PATCH 2/3] auxdisplay: lcd2s DT binding doc

2019-10-16 Thread Lars Poeschel
Add a binding doc for the modtronix lcd2s auxdisplay driver. It also adds modtronix to the list of known vendor-prefixes. Signed-off-by: Lars Poeschel --- .../bindings/auxdisplay/modtronix,lcd2s.txt | 24 +++ .../devicetree/bindings/vendor-prefixes.yaml | 2 ++ 2 files

[PATCH 1/3] auxdisplay: Make charlcd.[ch] more general

2019-10-16 Thread Lars Poeschel
hd44780_common. charlcd gets rid of the hd44780 specfics and more generally useable. The hd44780 and panel drivers are modified to use the new hd44780_common. This is tested on a hd44780 connected through the gpios of a pcf8574. Signed-off-by: Lars Poeschel --- drivers/auxdisplay/Kconfig

Re: [PATCH v9 0/7] nfc: pn533: add uart phy driver

2019-10-15 Thread Lars Poeschel
On Wed, Oct 09, 2019 at 05:29:07PM -0700, Jakub Kicinski wrote: > On Tue, 8 Oct 2019 16:05:37 +0200, Lars Poeschel wrote: > > The purpose of this patch series is to add a uart phy driver to the > > pn533 nfc driver. > > It first changes the dt strings and docs. The dt compat

Re: [PATCH v9 4/7] nfc: pn533: Split pn533 init & nfc_register

2019-10-15 Thread Lars Poeschel
On Wed, Oct 09, 2019 at 05:40:23PM -0700, Jakub Kicinski wrote: > On Tue, 8 Oct 2019 16:05:41 +0200, Lars Poeschel wrote: > > There is a problem in the initialisation and setup of the pn533: It > > registers with nfc too early. It could happen, that it finished > >

[PATCH v9 6/7] nfc: pn533: Add autopoll capability

2019-10-08 Thread Lars Poeschel
capability to the pn533 driver. Cc: Johan Hovold Cc: David Miller Signed-off-by: Lars Poeschel --- Changes in v9: - Rebased the patch series on v5.4-rc2 Changes in v8: - Reverse christmas tree order for local variables in pn533_autopoll_complete and pn533_start_poll Changes in v7: - Remove

[PATCH v9 7/7] nfc: pn532_uart: Make use of pn532 autopoll

2019-10-08 Thread Lars Poeschel
This switches the pn532 UART phy driver from manually polling to the new autopoll mechanism. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v9: - Rebased the patch series on v5.4-rc2 Changes in v6: - Rebased the patch series on v5.3-rc5 drivers/nfc/pn533/uart.c | 2 +- 1 file

[PATCH v9 5/7] nfc: pn533: add UART phy driver

2019-10-08 Thread Lars Poeschel
This adds the UART phy interface for the pn533 driver. The pn533 driver can be used through UART interface this way. It is implemented as a serdev device. Cc: Johan Hovold Cc: Claudiu Beznea Cc: David Miller Signed-off-by: Lars Poeschel --- Changes in v9: - Rebased the patch series on v5.4

[PATCH v9 2/7] nfc: pn532: Add uart phy docs and rename it

2019-10-08 Thread Lars Poeschel
Johan Hovold Cc: Simon Horman Signed-off-by: Lars Poeschel --- Changes in v9: - Rebased the patch series on v5.4-rc2 - Produce patch with -M4 to git format-patch to detect the rename - Change DT node name from pn532@24 to nfc@24 in example Changes in v8: - Update existing binding doc instead of addi

[PATCH v9 1/7] nfc: pn533: i2c: "pn532" as dt compatible string

2019-10-08 Thread Lars Poeschel
It is favourable to have one unified compatible string for devices that have multiple interfaces. So this adds simply "pn532" as the devicetree binding compatible string and makes a note that the old ones are deprecated. Cc: Johan Hovold Cc: Simon Horman Signed-off-by: Lar

[PATCH v9 4/7] nfc: pn533: Split pn533 init & nfc_register

2019-10-08 Thread Lars Poeschel
registering (and unregistering) to seperate functions that have to be called late in probe then. Cc: Johan Hovold Cc: Claudiu Beznea Signed-off-by: Lars Poeschel --- Changes in v9: - Rebased the patch series on v5.4-rc2 - This is already rebased with Johans "NFC: pn533: fix use-after

[PATCH v9 3/7] nfc: pn533: Add dev_up/dev_down hooks to phy_ops

2019-10-08 Thread Lars Poeschel
before dev_up and after dev_down. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v9: - Rebased the patch series on v5.4-rc2 Changes in v6: - Rebased the patch series on v5.3-rc5 Changes in v5: - (dev->phy_ops->dev_up) instead (dev->phy_ops) Changes in v4: - This patch is

[PATCH v9 0/7] nfc: pn533: add uart phy driver

2019-10-08 Thread Lars Poeschel
v/20191007164059.5927-1-jo...@kernel.org/ as they would conflict. If for some reason Johans patch will not get merged, I can of course provide the patchset without depending on this patch. Cc: Lars Poeschel Cc: Kate Stewart Cc: Thomas Gleixner Cc: Jilayne Lovejoy Cc: Greg Kroah-Hartman Cc:

Re: [PATCH v8 2/7] nfc: pn532: Add uart phy docs and rename it

2019-09-30 Thread Lars Poeschel
On Fri, Sep 27, 2019 at 10:52:09AM -0500, Rob Herring wrote: > On Thu, Sep 19, 2019 at 11:16:39AM +0200, Lars Poeschel wrote: > > This adds documentation about the uart phy to the pn532 binding doc. As > > the filename "pn533-i2c.txt" is not appropriate any more, rename i

[PATCH v8 7/7] nfc: pn532_uart: Make use of pn532 autopoll

2019-09-19 Thread Lars Poeschel
This switches the pn532 UART phy driver from manually polling to the new autopoll mechanism. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v6: - Rebased the patch series on v5.3-rc5 drivers/nfc/pn533/uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v8 6/7] nfc: pn533: Add autopoll capability

2019-09-19 Thread Lars Poeschel
capability to the pn533 driver. Cc: Johan Hovold Cc: David Miller Signed-off-by: Lars Poeschel --- Changes in v8: - Reverse christmas tree order for local variables in pn533_autopoll_complete and pn533_start_poll Changes in v7: - Remove __packed attribute at struct pn532_autopoll_resp - Add

[PATCH v8 5/7] nfc: pn533: add UART phy driver

2019-09-19 Thread Lars Poeschel
This adds the UART phy interface for the pn533 driver. The pn533 driver can be used through UART interface this way. It is implemented as a serdev device. Cc: Johan Hovold Cc: Claudiu Beznea Cc: David Miller Signed-off-by: Lars Poeschel --- Changes in v8: - Reverse christmas tree order

[PATCH v8 2/7] nfc: pn532: Add uart phy docs and rename it

2019-09-19 Thread Lars Poeschel
Johan Hovold Cc: Simon Horman Signed-off-by: Lars Poeschel --- Changes in v8: - Update existing binding doc instead of adding a new one: - Add uart phy example - Add general "pn532" compatible string - Deprecate "...-i2c" compatible strings - Rename file to a more ge

[PATCH v8 3/7] nfc: pn533: Add dev_up/dev_down hooks to phy_ops

2019-09-19 Thread Lars Poeschel
before dev_up and after dev_down. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v6: - Rebased the patch series on v5.3-rc5 Changes in v5: - (dev->phy_ops->dev_up) instead (dev->phy_ops) Changes in v4: - This patch is new in v4 drivers/nfc/pn533/pn533.c | 12 +++-

[PATCH v8 4/7] nfc: pn533: Split pn533 init & nfc_register

2019-09-19 Thread Lars Poeschel
registering (and unregistering) to seperate functions that have to be called late in probe then. Cc: Johan Hovold Cc: Claudiu Beznea Signed-off-by: Lars Poeschel --- Changes in v7: - Remove an unneeded rc variable initialization - Corrected goto error to err_clean in pn533_usb_probe Changes in v6

[PATCH v8 1/7] nfc: pn533: i2c: "pn532" as dt compatible string

2019-09-19 Thread Lars Poeschel
It is favourable to have one unified compatible string for devices that have multiple interfaces. So this adds simply "pn532" as the devicetree binding compatible string and makes a note that the old ones are deprecated. Cc: Johan Hovold Cc: Simon Horman Signed-off-by: Lar

Re: [PATCH v7 1/7] nfc: pn533: i2c: "pn532" as dt compatible string

2019-09-19 Thread Lars Poeschel
On Wed, Sep 18, 2019 at 02:34:57PM +0200, Simon Horman wrote: > On Tue, Sep 10, 2019 at 11:31:21AM +0200, Lars Poeschel wrote: > > It is favourable to have one unified compatible string for devices that > > have multiple interfaces. So this adds simply "pn532" as t

Re: [PATCH v7 5/7] nfc: pn533: add UART phy driver

2019-09-17 Thread Lars Poeschel
On Wed, Sep 11, 2019 at 10:17:32AM +0200, David Miller wrote: > From: Lars Poeschel > Date: Tue, 10 Sep 2019 11:33:50 +0200 > > > +static int pn532_uart_send_ack(struct pn533 *dev, gfp_t flags) > > +{ > > + struct pn532_uart_phy *pn532 = dev->phy; > > +

Re: [PATCH v7 6/7] nfc: pn533: Add autopoll capability

2019-09-17 Thread Lars Poeschel
On Wed, Sep 11, 2019 at 10:17:59AM +0200, David Miller wrote: > From: Lars Poeschel > Date: Tue, 10 Sep 2019 11:34:12 +0200 > > > +static int pn533_autopoll_complete(struct pn533 *dev, void *arg, > > + struct sk_buff *resp) > > +{ >

Re: [PATCH v7 2/7] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2019-09-17 Thread Lars Poeschel
On Fri, Sep 13, 2019 at 03:32:21PM -0500, Rob Herring wrote: > On Tue, Sep 10, 2019 at 11:32:53AM +0200, Lars Poeschel wrote: > > Add a simple binding doc for the pn532. > > > > Cc: Johan Hovold > > Signed-off-by: Lars Poeschel > > --- > > Changes in v6:

[PATCH v7 7/7] nfc: pn532_uart: Make use of pn532 autopoll

2019-09-10 Thread Lars Poeschel
This switches the pn532 UART phy driver from manually polling to the new autopoll mechanism. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v6: - Rebased the patch series on v5.3-rc5 drivers/nfc/pn533/uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v7 5/7] nfc: pn533: add UART phy driver

2019-09-10 Thread Lars Poeschel
This adds the UART phy interface for the pn533 driver. The pn533 driver can be used through UART interface this way. It is implemented as a serdev device. Cc: Johan Hovold Cc: Claudiu Beznea Signed-off-by: Lars Poeschel --- Changes in v7: - Add comment at send_wakeup variable to document

[PATCH v7 6/7] nfc: pn533: Add autopoll capability

2019-09-10 Thread Lars Poeschel
capability to the pn533 driver. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v7: - Remove __packed attribute at struct pn532_autopoll_resp - Add missing '\n' at the end of dev_dbg and nfc_err strings Changes in v6: - Rebased the patch series on v5.3-rc5 drivers/nfc/pn533/pn533.c

[PATCH v7 2/7] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2019-09-10 Thread Lars Poeschel
Add a simple binding doc for the pn532. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v6: - Rebased the patch series on v5.3-rc5 - Picked up Rob's Reviewed-By Changes in v4: - Add documentation about reg property in case of i2c Changes in v3: - seperate binding doc instead

[PATCH v7 4/7] nfc: pn533: Split pn533 init & nfc_register

2019-09-10 Thread Lars Poeschel
registering (and unregistering) to seperate functions that have to be called late in probe then. Cc: Johan Hovold Cc: Claudiu Beznea Signed-off-by: Lars Poeschel --- Changes in v7: - Remove an unneeded rc variable initialization - Corrected goto error to err_clean in pn533_usb_probe Changes in v6

[PATCH v7 3/7] nfc: pn533: Add dev_up/dev_down hooks to phy_ops

2019-09-10 Thread Lars Poeschel
before dev_up and after dev_down. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v6: - Rebased the patch series on v5.3-rc5 Changes in v5: - (dev->phy_ops->dev_up) instead (dev->phy_ops) Changes in v4: - This patch is new in v4 drivers/nfc/pn533/pn533.c | 12 +++-

[PATCH v7 1/7] nfc: pn533: i2c: "pn532" as dt compatible string

2019-09-10 Thread Lars Poeschel
It is favourable to have one unified compatible string for devices that have multiple interfaces. So this adds simply "pn532" as the devicetree binding compatible string and makes a note that the old ones are deprecated. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v6:

Re: [PATCH v6 5/7] nfc: pn533: add UART phy driver

2019-08-23 Thread Lars Poeschel
On Thu, Aug 22, 2019 at 10:09:09AM +, claudiu.bez...@microchip.com wrote: > Hi Lars, > > On 20.08.2019 15:03, Lars Poeschel wrote: > > This adds the UART phy interface for the pn533 driver. > > The pn533 driver can be used through UART interface this way. > > It

Re: [PATCH v6 4/7] nfc: pn533: Split pn533 init & nfc_register

2019-08-23 Thread Lars Poeschel
On Thu, Aug 22, 2019 at 10:08:40AM +, claudiu.bez...@microchip.com wrote: > > > On 20.08.2019 15:03, Lars Poeschel wrote: > > There is a problem in the initialisation and setup of the pn533: It > > registers with nfc too early. It could happen, that it finished >

Re: [PATCH v6 6/7] nfc: pn533: Add autopoll capability

2019-08-20 Thread Lars Poeschel
On Tue, Aug 20, 2019 at 02:23:44PM +0200, Johan Hovold wrote: > On Tue, Aug 20, 2019 at 02:03:43PM +0200, Lars Poeschel wrote: > > drivers/nfc/pn533/pn533.c | 193 +- > > drivers/nfc/pn533/pn533.h | 10 +- > > 2 files changed, 197 inser

[PATCH v6 7/7] nfc: pn532_uart: Make use of pn532 autopoll

2019-08-20 Thread Lars Poeschel
This switches the pn532 UART phy driver from manually polling to the new autopoll mechanism. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v6: - Rebased the patch series on v5.3-rc5 drivers/nfc/pn533/uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v6 5/7] nfc: pn533: add UART phy driver

2019-08-20 Thread Lars Poeschel
This adds the UART phy interface for the pn533 driver. The pn533 driver can be used through UART interface this way. It is implemented as a serdev device. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v6: - Rebased the patch series on v5.3-rc5 Changes in v5: - Use the splitted

[PATCH v6 4/7] nfc: pn533: Split pn533 init & nfc_register

2019-08-20 Thread Lars Poeschel
registering (and unregistering) to seperate functions that have to be called late in probe then. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v6: - Rebased the patch series on v5.3-rc5 Changes in v5: - This patch is new in v5 drivers/nfc/pn533/i2c.c | 17 +- drivers/nfc

[PATCH v6 6/7] nfc: pn533: Add autopoll capability

2019-08-20 Thread Lars Poeschel
capability to the pn533 driver. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v6: - Rebased the patch series on v5.3-rc5 drivers/nfc/pn533/pn533.c | 193 +- drivers/nfc/pn533/pn533.h | 10 +- 2 files changed, 197 insertions(+), 6 deletions

[PATCH v6 1/7] nfc: pn533: i2c: "pn532" as dt compatible string

2019-08-20 Thread Lars Poeschel
It is favourable to have one unified compatible string for devices that have multiple interfaces. So this adds simply "pn532" as the devicetree binding compatible string and makes a note that the old ones are deprecated. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v6:

[PATCH v6 2/7] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2019-08-20 Thread Lars Poeschel
Add a simple binding doc for the pn532. Reviewed-by: Rob Herring Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v6: - Rebased the patch series on v5.3-rc5 - Picked up Rob's Reviewed-By Changes in v4: - Add documentation about reg property in case of i2c Changes in v3

[PATCH v6 3/7] nfc: pn533: Add dev_up/dev_down hooks to phy_ops

2019-08-20 Thread Lars Poeschel
before dev_up and after dev_down. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v6: - Rebased the patch series on v5.3-rc5 Changes in v5: - (dev->phy_ops->dev_up) instead (dev->phy_ops) Changes in v4: - This patch is new in v4 drivers/nfc/pn533/pn533.c | 12 +++-

Re: [PING 2] [PATCH v5 1/7] nfc: pn533: i2c: "pn532" as dt compatible string

2019-08-12 Thread Lars Poeschel
On Mon, Aug 05, 2019 at 02:42:36PM +0200, Johan Hovold wrote: > You may want to resend this series to netdev now. David Miller will be > picking up NFC patches directly from there. Thank you very much for this information. Johannes Berg did reach out to me already. Rebase, test and resend is

[PING] [PATCH v5 1/7] nfc: pn533: i2c: "pn532" as dt compatible string

2019-02-28 Thread Lars Poeschel
A gentle ping on this whole patch series. Regards, Lars On Fri, Jan 11, 2019 at 05:18:04PM +0100, Lars Poeschel wrote: > It is favourable to have one unified compatible string for devices that > have multiple interfaces. So this adds simply "pn532" as the devicetree > bindin

Re: [PATCH v5 2/7] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2019-01-24 Thread Lars Poeschel
On Tue, Jan 15, 2019 at 01:59:02PM -0600, Rob Herring wrote: > On Fri, 11 Jan 2019 17:18:05 +0100, Lars Poeschel wrote: > > Add a simple binding doc for the pn532. > > > > Cc: Johan Hovold > > Signed-off-by: Lars Poeschel > > --- > > Changes in v4: >

[PATCH] pinctrl: mcp23s08: Allocate irq_chip dynamic

2019-01-11 Thread Lars Poeschel
ition from being driver static into the struct mcp23s08. So a unique irq_chip is used for each gpiochip instance. Signed-off-by: Lars Poeschel --- drivers/pinctrl/pinctrl-mcp23s08.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/pinct

[PATCH v5 6/7] nfc: pn533: Add autopoll capability

2019-01-11 Thread Lars Poeschel
capability to the pn533 driver. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- drivers/nfc/pn533/pn533.c | 193 +- drivers/nfc/pn533/pn533.h | 10 +- 2 files changed, 197 insertions(+), 6 deletions(-) diff --git a/drivers/nfc/pn533/pn533.c b/drivers/nfc

[PATCH v5 5/7] nfc: pn533: add UART phy driver

2019-01-11 Thread Lars Poeschel
This adds the UART phy interface for the pn533 driver. The pn533 driver can be used through UART interface this way. It is implemented as a serdev device. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v5: - Use the splitted pn53x_common_init and pn53x_register_nfc

[PATCH v5 7/7] nfc: pn532_uart: Make use of pn532 autopoll

2019-01-11 Thread Lars Poeschel
This switches the pn532 UART phy driver from manually polling to the new autopoll mechanism. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- drivers/nfc/pn533/uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/pn533/uart.c b/drivers/nfc/pn533/uart.c index

[PATCH v5 4/7] nfc: pn533: Split pn533 init & nfc_register

2019-01-11 Thread Lars Poeschel
registering (and unregistering) to seperate functions that have to be called late in probe then. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v5: - This patch is new in v5 drivers/nfc/pn533/i2c.c | 17 +- drivers/nfc/pn533/pn533.c | 66

[PATCH v5 3/7] nfc: pn533: Add dev_up/dev_down hooks to phy_ops

2019-01-11 Thread Lars Poeschel
before dev_up and after dev_down. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v5: - (dev->phy_ops->dev_up) instead (dev->phy_ops) Changes in v4: - This patch is new in v4 drivers/nfc/pn533/pn533.c | 12 +++- drivers/nfc/pn533/pn533.h | 9 + 2 files ch

[PATCH v5 2/7] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2019-01-11 Thread Lars Poeschel
Add a simple binding doc for the pn532. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Changes in v4: - Add documentation about reg property in case of i2c Changes in v3: - seperate binding doc instead of entry in trivial-devices.txt .../devicetree/bindings/nfc/pn532.txt | 33

[PATCH v5 1/7] nfc: pn533: i2c: "pn532" as dt compatible string

2019-01-11 Thread Lars Poeschel
It is favourable to have one unified compatible string for devices that have multiple interfaces. So this adds simply "pn532" as the devicetree binding compatible string and makes a note that the old ones are deprecated. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Cha

[PATCH v5 1/7] nfc: pn533: i2c: "pn532" as dt compatible string

2019-01-11 Thread Lars Poeschel
It is favourable to have one unified compatible string for devices that have multiple interfaces. So this adds simply "pn532" as the devicetree binding compatible string and makes a note that the old ones are deprecated. Cc: Johan Hovold Signed-off-by: Lars Poeschel --- Cha

[PATCH v4 2/6] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2018-11-01 Thread Lars Poeschel
Add a simple binding doc for the pn532. Signed-off-by: Lars Poeschel --- Changes in v4: - Add documentation about reg property in case of i2c Changes in v3: - seperate binding doc instead of entry in trivial-devices.txt .../devicetree/bindings/nfc/pn532.txt | 33 +++ 1

[PATCH v4 2/6] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2018-11-01 Thread Lars Poeschel
Add a simple binding doc for the pn532. Signed-off-by: Lars Poeschel --- Changes in v4: - Add documentation about reg property in case of i2c Changes in v3: - seperate binding doc instead of entry in trivial-devices.txt .../devicetree/bindings/nfc/pn532.txt | 33 +++ 1

Re: [PATCH v3 2/5] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2018-10-26 Thread Lars Poeschel
On Thu, Oct 25, 2018 at 04:54:45PM -0500, Rob Herring wrote: > On Thu, Oct 25, 2018 at 03:29:33PM +0200, Lars Poeschel wrote: > > Add a simple binding doc for the pn532. > > > > Signed-off-by: Lars Poeschel > > --- > > Changes in v3: > > - seperate

Re: [PATCH v3 2/5] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2018-10-26 Thread Lars Poeschel
On Thu, Oct 25, 2018 at 04:54:45PM -0500, Rob Herring wrote: > On Thu, Oct 25, 2018 at 03:29:33PM +0200, Lars Poeschel wrote: > > Add a simple binding doc for the pn532. > > > > Signed-off-by: Lars Poeschel > > --- > > Changes in v3: > > - seperate

[PATCH v3 2/5] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2018-10-25 Thread Lars Poeschel
Add a simple binding doc for the pn532. Signed-off-by: Lars Poeschel --- Changes in v3: - seperate binding doc instead of entry in trivial-devices.txt .../devicetree/bindings/nfc/pn532.txt | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 Documentation

[PATCH v3 2/5] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2018-10-25 Thread Lars Poeschel
Add a simple binding doc for the pn532. Signed-off-by: Lars Poeschel --- Changes in v3: - seperate binding doc instead of entry in trivial-devices.txt .../devicetree/bindings/nfc/pn532.txt | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 Documentation

Re: [PATCH v2 2/4] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2018-10-19 Thread Lars Poeschel
On Thu, Oct 18, 2018 at 03:41:29PM -0500, Rob Herring wrote: > On Thu, Oct 18, 2018 at 05:03:13PM +0200, Marcel Holtmann wrote: > > Hi Lars, > > > > > Add pn532 to the trivial-devices.txt binding doc. > > > > > > Signed-off-by: Lars Poeschel > &g

Re: [PATCH v2 2/4] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2018-10-19 Thread Lars Poeschel
On Thu, Oct 18, 2018 at 03:41:29PM -0500, Rob Herring wrote: > On Thu, Oct 18, 2018 at 05:03:13PM +0200, Marcel Holtmann wrote: > > Hi Lars, > > > > > Add pn532 to the trivial-devices.txt binding doc. > > > > > > Signed-off-by: Lars Poeschel > &g

[PATCH v2 2/4] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2018-10-18 Thread Lars Poeschel
Add pn532 to the trivial-devices.txt binding doc. Signed-off-by: Lars Poeschel --- Documentation/devicetree/bindings/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial

[PATCH v2 1/4] nfc: pn533: add UART phy driver

2018-10-18 Thread Lars Poeschel
This adds the UART phy interface for the pn533 driver. The pn533 driver can be used through UART interface this way. It is implemented as a serdev device. Signed-off-by: Lars Poeschel --- Changes in v2: - switched from tty line discipline to serdev, resulting in many simplifications - SPDX

[PATCH v2 2/4] nfc: pn532_uart: Add NXP PN532 to devicetree docs

2018-10-18 Thread Lars Poeschel
Add pn532 to the trivial-devices.txt binding doc. Signed-off-by: Lars Poeschel --- Documentation/devicetree/bindings/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial

[PATCH v2 1/4] nfc: pn533: add UART phy driver

2018-10-18 Thread Lars Poeschel
This adds the UART phy interface for the pn533 driver. The pn533 driver can be used through UART interface this way. It is implemented as a serdev device. Signed-off-by: Lars Poeschel --- Changes in v2: - switched from tty line discipline to serdev, resulting in many simplifications - SPDX

Re: [PATCH] video: hd44780: Add hd44780 lcd display driver

2017-12-07 Thread Lars Poeschel
On Wed, Dec 6, 2017 at 16:04:10 CET Geert Uytterhoeven wrote: > Hi Lars, > > On Wed, Dec 6, 2017 at 2:52 PM, Lars Poeschel <poesc...@lemonage.de> wrote: > > This adds a console driver for hd44780 based character lcd displays and > > clones. The driver currently suppo

Re: [PATCH] video: hd44780: Add hd44780 lcd display driver

2017-12-07 Thread Lars Poeschel
On Wed, Dec 6, 2017 at 16:04:10 CET Geert Uytterhoeven wrote: > Hi Lars, > > On Wed, Dec 6, 2017 at 2:52 PM, Lars Poeschel wrote: > > This adds a console driver for hd44780 based character lcd displays and > > clones. The driver currently supports 20x4 character displays wi

[PATCH] video: hd44780: Add hd44780 lcd display driver

2017-12-06 Thread Lars Poeschel
information. There are also tons of these cheap displays sold with a serial interface. Many of them use a simple pcf8574 gpio expanders. An example for using that kind of display is also in the binding doc. Signed-off-by: Lars Poeschel <poesc...@lemonage.de> --- .../bindings/video/console/hd44780c

[PATCH] video: hd44780: Add hd44780 lcd display driver

2017-12-06 Thread Lars Poeschel
information. There are also tons of these cheap displays sold with a serial interface. Many of them use a simple pcf8574 gpio expanders. An example for using that kind of display is also in the binding doc. Signed-off-by: Lars Poeschel --- .../bindings/video/console/hd44780con.txt | 42

[PATCH] dt-bindings: pinctrl: mcp23s08 update binding doc

2017-10-09 Thread Lars Poeschel
The mcp23s08 driver moved to pinctrl recently. It accepts the bias-pull-up pinctrl property since then. This updates the binding doc to reflect that. Thanks to Sebastian Reichel for the working example. Signed-off-by: Lars Poeschel <poesc...@lemonage.de> --- .../bindings/pinctrl/pinctrl-mc

[PATCH] dt-bindings: pinctrl: mcp23s08 update binding doc

2017-10-09 Thread Lars Poeschel
The mcp23s08 driver moved to pinctrl recently. It accepts the bias-pull-up pinctrl property since then. This updates the binding doc to reflect that. Thanks to Sebastian Reichel for the working example. Signed-off-by: Lars Poeschel --- .../bindings/pinctrl/pinctrl-mcp23s08.txt | 58

Re: [PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio

2017-10-09 Thread Lars Poeschel
On Sun, Oct 8, 2017 at 01:58:52 CEST Linus Walleij wrote: CCing-in Sebastian Reichel who did the move to pinctrl and pinctrl support as well. > On Thu, Oct 5, 2017 at 9:50 AM, Lars Poeschel <poesc...@lemonage.de> wrote: > > The mcp23s08 driver was moved from gpio to pinctrl.

Re: [PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio

2017-10-09 Thread Lars Poeschel
On Sun, Oct 8, 2017 at 01:58:52 CEST Linus Walleij wrote: CCing-in Sebastian Reichel who did the move to pinctrl and pinctrl support as well. > On Thu, Oct 5, 2017 at 9:50 AM, Lars Poeschel wrote: > > The mcp23s08 driver was moved from gpio to pinctrl. This moves it's > > dev

[PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio

2017-10-05 Thread Lars Poeschel
The mcp23s08 driver was moved from gpio to pinctrl. This moves it's devicetree binding doc as well. So driver and binding doc are in sync again. Signed-off-by: Lars Poeschel <poesc...@lemonage.de> --- .../bindings/{gpio/gpio-mcp23s08.txt => pinctrl/pinctrl-mcp23s08.txt} | 0 1 fil

  1   2   3   4   >