Re: [PATCH v7 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-13 Thread Lorenzo Pieralisi
On Thu, Dec 06, 2018 at 08:02:38PM +0800, Hanjie Lin wrote: > From: Yue Wang > > The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare > PCI core. This patch adds the driver support for Meson PCIe controller. > > Signed-off-by: Yue Wang > Signed-off-by: Hanjie Lin > --- >

Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support

2018-12-13 Thread Lorenzo Pieralisi
On Thu, Dec 13, 2018 at 03:30:00PM +0100, Miquel Raynal wrote: > Hi Lorenzo, > > > > If that's really the case, then I can see how one device and it's > > > children are suspended and the irq for it is disabled but the providing > > > devices (clk, regulator, bus controller, etc.) are still fully

Re: [v2] PCI: imx: make msi work without pcieportbus

2018-12-13 Thread Lorenzo Pieralisi
On Thu, Dec 13, 2018 at 11:07:16AM +0100, Lucas Stach wrote: > Am Donnerstag, den 13.12.2018, 09:57 + schrieb Richard Zhu: > > Hi Lucas: > > > > > -Original Message- > > > > > From: Lucas Stach [mailto:l.st...@pengutronix.de] > > > Sent: 2018年12月13日 17:19 > > > > > > > To: Richard Zhu

Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support

2018-12-13 Thread Lorenzo Pieralisi
On Thu, Dec 13, 2018 at 01:00:26AM -0800, Stephen Boyd wrote: > Quoting Lorenzo Pieralisi (2018-12-11 06:16:27) > > On Tue, Dec 04, 2018 at 10:42:19PM +0100, Rafael J. Wysocki wrote: > > > On Tuesday, December 4, 2018 10:45:58 AM CET Lorenzo Pieralisi wrote: > > > >

Re: [PATCHv2 4/4] PCI: dwc: add prefetchable memory range support

2018-12-11 Thread Lorenzo Pieralisi
On Tue, Dec 11, 2018 at 10:21:08AM +, Z.q. Hou wrote: [...] > > > + */ > > > + if (pci->num_viewport < 2) { > > > + ret = of_property_read_u32(np, "num-viewport", > > > +>num_viewport); > > > + if (ret || pci->num_viewport < 2) > > > +

Re: [PATCHv2 2/4] PCI: dwc: fix 4GiB outbound window size truncated to zero issue

2018-12-11 Thread Lorenzo Pieralisi
On Thu, Dec 06, 2018 at 01:25:17AM +, Z.q. Hou wrote: > Hi Lorenzo, > > Thanks a lot for your comments! > > > -Original Message- > > From: Lorenzo Pieralisi > > Sent: 2018??12??6?? 0:02 > > To: Z.q. Hou > > Cc: linux-...@vger.kernel.or

Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support

2018-12-11 Thread Lorenzo Pieralisi
On Tue, Dec 04, 2018 at 10:42:19PM +0100, Rafael J. Wysocki wrote: > On Tuesday, December 4, 2018 10:45:58 AM CET Lorenzo Pieralisi wrote: > > On Mon, Dec 03, 2018 at 11:00:20PM +0100, Rafael J. Wysocki wrote: > > > On Monday, December 3, 2018 4:38:46 PM CET Miquel Raynal wrote:

Re: [PATCH] cpuidle: Add 'above' and 'below' idle state metrics

2018-12-07 Thread Lorenzo Pieralisi
On Fri, Dec 07, 2018 at 12:57:00PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > Subject: [PATCH] cpuidle: Add 'above' and 'below' idle state metrics > > Add two new metrics for CPU idle states, "above" and "below", to count > the number of times the given state had been asked for

Re: [PATCH 0/3] PCIE support for i.MX8MQ

2018-12-07 Thread Lorenzo Pieralisi
On Sat, Nov 17, 2018 at 10:12:22AM -0800, Andrey Smirnov wrote: > > Everyone: > > This series contains changes I made in order to enable support of PCIE > IP block on i.MX8MQ SoCs (full tree can be found at [github-v0]). This series > is _very_ preliminary and by no means is ready for inclusion

Re: [PATCH 0/3] PCIE support for i.MX8MQ

2018-12-07 Thread Lorenzo Pieralisi
On Sat, Nov 17, 2018 at 10:12:22AM -0800, Andrey Smirnov wrote: > > Everyone: > > This series contains changes I made in order to enable support of PCIE > IP block on i.MX8MQ SoCs (full tree can be found at [github-v0]). This series > is _very_ preliminary and by no means is ready for inclusion

Re: [PATCH v2 0/3] PCIE support for i.MX8MQ

2018-12-06 Thread Lorenzo Pieralisi
On Wed, Dec 05, 2018 at 11:35:42PM -0800, Andrey Smirnov wrote: > Everyone: > > This series contains changes I made in order to enable support of PCIE > IP block on i.MX8MQ SoCs (full tree can be found at [github-v2]). > > NOTE: The last patch have a Kconfig symbol depenency on [imx8mq-kconfig].

Re: [PATCH v2 0/3] PCIE support for i.MX8MQ

2018-12-06 Thread Lorenzo Pieralisi
On Wed, Dec 05, 2018 at 11:35:42PM -0800, Andrey Smirnov wrote: > Everyone: > > This series contains changes I made in order to enable support of PCIE > IP block on i.MX8MQ SoCs (full tree can be found at [github-v2]). > > NOTE: The last patch have a Kconfig symbol depenency on [imx8mq-kconfig].

Re: [PATCHv2 2/4] PCI: dwc: fix 4GiB outbound window size truncated to zero issue

2018-12-05 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 10:09:10AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > The current type of mem_size is 'u32', so when resource_size() > return 4G it will be truncated to zero. This patch fix it by > changing its type to 'u64'. > > Signed-off-by: Hou Zhiqiang > Acked-by: Gustavo

Re: [PATCHv2 2/4] PCI: dwc: fix 4GiB outbound window size truncated to zero issue

2018-12-05 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 10:09:10AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > The current type of mem_size is 'u32', so when resource_size() > return 4G it will be truncated to zero. This patch fix it by > changing its type to 'u64'. > > Signed-off-by: Hou Zhiqiang > Acked-by: Gustavo

Re: [PATCHv2 1/4] PCI: dwc: fix potential memory leak

2018-12-05 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 10:09:04AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > Free the allocated pci_host_bridge struct when failed to get > host bridge resources, and free the resource windows before > free the bridge. > > Signed-off-by: Hou Zhiqiang > Acked-by: Gustavo Pimentel > --- >

Re: [PATCHv2 1/4] PCI: dwc: fix potential memory leak

2018-12-05 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 10:09:04AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > Free the allocated pci_host_bridge struct when failed to get > host bridge resources, and free the resource windows before > free the bridge. > > Signed-off-by: Hou Zhiqiang > Acked-by: Gustavo Pimentel > --- >

Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support

2018-12-05 Thread Lorenzo Pieralisi
On Tue, Dec 04, 2018 at 10:42:19PM +0100, Rafael J. Wysocki wrote: > On Tuesday, December 4, 2018 10:45:58 AM CET Lorenzo Pieralisi wrote: > > On Mon, Dec 03, 2018 at 11:00:20PM +0100, Rafael J. Wysocki wrote: > > > On Monday, December 3, 2018 4:38:46 PM CET Miquel Raynal wrote:

Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support

2018-12-05 Thread Lorenzo Pieralisi
On Tue, Dec 04, 2018 at 10:42:19PM +0100, Rafael J. Wysocki wrote: > On Tuesday, December 4, 2018 10:45:58 AM CET Lorenzo Pieralisi wrote: > > On Mon, Dec 03, 2018 at 11:00:20PM +0100, Rafael J. Wysocki wrote: > > > On Monday, December 3, 2018 4:38:46 PM CET Miquel Raynal wrote:

Re: [PATCH v4 2/2] PCI: uniphier: Add UniPhier PCIe host controller support

2018-12-04 Thread Lorenzo Pieralisi
On Wed, Nov 28, 2018 at 01:04:26PM +0900, Kunihiko Hayashi wrote: [...] > +static void uniphier_pcie_irq_ack(struct irq_data *d) > +{ > + struct pcie_port *pp = irq_data_get_irq_chip_data(d); > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + struct uniphier_pcie_priv *priv =

Re: [PATCH v4 2/2] PCI: uniphier: Add UniPhier PCIe host controller support

2018-12-04 Thread Lorenzo Pieralisi
On Wed, Nov 28, 2018 at 01:04:26PM +0900, Kunihiko Hayashi wrote: [...] > +static void uniphier_pcie_irq_ack(struct irq_data *d) > +{ > + struct pcie_port *pp = irq_data_get_irq_chip_data(d); > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + struct uniphier_pcie_priv *priv =

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-04 Thread Lorenzo Pieralisi
On Tue, Dec 04, 2018 at 06:40:55PM +0800, Hanjie Lin wrote: > > > On 2018/12/4 6:57, Bjorn Helgaas wrote: > > On Mon, Dec 03, 2018 at 04:41:50PM +, Lorenzo Pieralisi wrote: > >> On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote: > >>

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-04 Thread Lorenzo Pieralisi
On Tue, Dec 04, 2018 at 06:40:55PM +0800, Hanjie Lin wrote: > > > On 2018/12/4 6:57, Bjorn Helgaas wrote: > > On Mon, Dec 03, 2018 at 04:41:50PM +, Lorenzo Pieralisi wrote: > >> On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote: > >>

Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support

2018-12-04 Thread Lorenzo Pieralisi
On Mon, Dec 03, 2018 at 11:00:20PM +0100, Rafael J. Wysocki wrote: > On Monday, December 3, 2018 4:38:46 PM CET Miquel Raynal wrote: > > Hi Lorenzo, > > > > Lorenzo Pieralisi wrote on Mon, 3 Dec 2018 > > 10:27:08 +: > > > > > [+Rafael, Sudeep] >

Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support

2018-12-04 Thread Lorenzo Pieralisi
On Mon, Dec 03, 2018 at 11:00:20PM +0100, Rafael J. Wysocki wrote: > On Monday, December 3, 2018 4:38:46 PM CET Miquel Raynal wrote: > > Hi Lorenzo, > > > > Lorenzo Pieralisi wrote on Mon, 3 Dec 2018 > > 10:27:08 +: > > > > > [+Rafael, Sudeep] >

Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support

2018-12-03 Thread Lorenzo Pieralisi
[+Stephen, Mike] On Mon, Dec 03, 2018 at 04:38:46PM +0100, Miquel Raynal wrote: > Hi Lorenzo, > > Lorenzo Pieralisi wrote on Mon, 3 Dec 2018 > 10:27:08 +: > > > [+Rafael, Sudeep] > > > > On Fri, Nov 23, 2018 at 03:18:24PM +0100, Miquel Raynal wrote: >

Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support

2018-12-03 Thread Lorenzo Pieralisi
[+Stephen, Mike] On Mon, Dec 03, 2018 at 04:38:46PM +0100, Miquel Raynal wrote: > Hi Lorenzo, > > Lorenzo Pieralisi wrote on Mon, 3 Dec 2018 > 10:27:08 +: > > > [+Rafael, Sudeep] > > > > On Fri, Nov 23, 2018 at 03:18:24PM +0100, Miquel Raynal wrote: >

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-03 Thread Lorenzo Pieralisi
On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote: [...] > +static int meson_pcie_rd_own_conf(struct pcie_port *pp, int where, int size, > + u32 *val) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + > + /* > + * there is a bug of

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-03 Thread Lorenzo Pieralisi
On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote: [...] > +static int meson_pcie_rd_own_conf(struct pcie_port *pp, int where, int size, > + u32 *val) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + > + /* > + * there is a bug of

Re: [PATCH 0/3] PCIE support for i.MX8MQ

2018-12-03 Thread Lorenzo Pieralisi
On Sat, Nov 17, 2018 at 10:12:22AM -0800, Andrey Smirnov wrote: > > Everyone: > > This series contains changes I made in order to enable support of PCIE > IP block on i.MX8MQ SoCs (full tree can be found at [github-v0]). This series > is _very_ preliminary and by no means is ready for inclusion

Re: [PATCH 0/3] PCIE support for i.MX8MQ

2018-12-03 Thread Lorenzo Pieralisi
On Sat, Nov 17, 2018 at 10:12:22AM -0800, Andrey Smirnov wrote: > > Everyone: > > This series contains changes I made in order to enable support of PCIE > IP block on i.MX8MQ SoCs (full tree can be found at [github-v0]). This series > is _very_ preliminary and by no means is ready for inclusion

Re: [PATCH 00/23] PCI: refactor the Mobiveil driver and add PCIe support for NXP LX SoCs

2018-12-03 Thread Lorenzo Pieralisi
On Tue, Nov 06, 2018 at 01:19:03PM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > This patch set is aim to refactor the Mobiveil driver and add > PCIe support for NXP LX series SoCs. > > Hou Zhiqiang (23): > PCI: mobiveil: uniform the register accessors > PCI: mobiveil: format the code

Re: [PATCH 00/23] PCI: refactor the Mobiveil driver and add PCIe support for NXP LX SoCs

2018-12-03 Thread Lorenzo Pieralisi
On Tue, Nov 06, 2018 at 01:19:03PM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > This patch set is aim to refactor the Mobiveil driver and add > PCIe support for NXP LX series SoCs. > > Hou Zhiqiang (23): > PCI: mobiveil: uniform the register accessors > PCI: mobiveil: format the code

Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support

2018-12-03 Thread Lorenzo Pieralisi
[+Rafael, Sudeep] On Fri, Nov 23, 2018 at 03:18:24PM +0100, Miquel Raynal wrote: > Add suspend and resume callbacks. The priority of these are > "_noirq()", to workaround early access to the registers done by the > PCI core through the ->read()/->write() callbacks at resume time. > >

Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support

2018-12-03 Thread Lorenzo Pieralisi
[+Rafael, Sudeep] On Fri, Nov 23, 2018 at 03:18:24PM +0100, Miquel Raynal wrote: > Add suspend and resume callbacks. The priority of these are > "_noirq()", to workaround early access to the registers done by the > PCI core through the ->read()/->write() callbacks at resume time. > >

Re: [PATCH v3] PCI: mediatek: Use devm_of_pci_get_host_bridge_resources() to parse DT

2018-11-30 Thread Lorenzo Pieralisi
On Fri, Nov 30, 2018 at 11:33:00AM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > Use the devm_of_pci_get_host_bridge_resources() API in place of the PCI OF > DT parser. > > Signed-off-by: Honghui Zhang > Acked-by: Ryder Lee > --- > drivers/pci/controller/pcie-mediatek.c

Re: [PATCH v3] PCI: mediatek: Use devm_of_pci_get_host_bridge_resources() to parse DT

2018-11-30 Thread Lorenzo Pieralisi
On Fri, Nov 30, 2018 at 11:33:00AM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > Use the devm_of_pci_get_host_bridge_resources() API in place of the PCI OF > DT parser. > > Signed-off-by: Honghui Zhang > Acked-by: Ryder Lee > --- > drivers/pci/controller/pcie-mediatek.c

Re: [PATCH v2] PCI: mediatek: Use devm_of_pci_get_host_bridge_resources() to parse DT

2018-11-29 Thread Lorenzo Pieralisi
On Thu, Nov 08, 2018 at 10:56:55AM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > Use the devm_of_pci_get_host_bridge_resources() API in place of the PCI OF > DT parser. > > Signed-off-by: Honghui Zhang > --- > drivers/pci/controller/pcie-mediatek.c | 98 >

Re: [PATCH v2] PCI: mediatek: Use devm_of_pci_get_host_bridge_resources() to parse DT

2018-11-29 Thread Lorenzo Pieralisi
On Thu, Nov 08, 2018 at 10:56:55AM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > Use the devm_of_pci_get_host_bridge_resources() API in place of the PCI OF > DT parser. > > Signed-off-by: Honghui Zhang > --- > drivers/pci/controller/pcie-mediatek.c | 98 >

Re: [PATCHv2 4/4] PCI: dwc: add prefetchable memory range support

2018-11-28 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 10:09:21AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > The current code only support non-prefetchable memory range, > as the non-prefetchable memory range must not be greater than > 4GiB, one viewport can cover it, which supports upto 4GiB. > > To support

Re: [PATCHv2 4/4] PCI: dwc: add prefetchable memory range support

2018-11-28 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 10:09:21AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > The current code only support non-prefetchable memory range, > as the non-prefetchable memory range must not be greater than > 4GiB, one viewport can cover it, which supports upto 4GiB. > > To support

Re: [PATCH 2/2] arm64: acpi: Prepare for longer MADTs

2018-11-27 Thread Lorenzo Pieralisi
On Fri, Oct 12, 2018 at 02:29:37PM -0500, Jeremy Linton wrote: > The BAD_MADT_GICC_ENTRY check is a little too strict because > it rejects MADT entries that don't match the currently known > lengths. We should remove this restriction to avoid problems > if the table length changes. Future code

Re: [PATCH 2/2] arm64: acpi: Prepare for longer MADTs

2018-11-27 Thread Lorenzo Pieralisi
On Fri, Oct 12, 2018 at 02:29:37PM -0500, Jeremy Linton wrote: > The BAD_MADT_GICC_ENTRY check is a little too strict because > it rejects MADT entries that don't match the currently known > lengths. We should remove this restriction to avoid problems > if the table length changes. Future code

Re: [RESEND PATCH v3 2/2] PCI: uniphier: Add UniPhier PCIe host controller support

2018-11-23 Thread Lorenzo Pieralisi
On Tue, Nov 20, 2018 at 09:15:31PM +0900, Kunihiko Hayashi wrote: [...] > > > +static int uniphier_pcie_link_up(struct dw_pcie *pci) > > > > This function returns a bool value, make it return a bool. > > This function is registered in struct dw_pcie_ops.link_up, that is defined > in

Re: [RESEND PATCH v3 2/2] PCI: uniphier: Add UniPhier PCIe host controller support

2018-11-23 Thread Lorenzo Pieralisi
On Tue, Nov 20, 2018 at 09:15:31PM +0900, Kunihiko Hayashi wrote: [...] > > > +static int uniphier_pcie_link_up(struct dw_pcie *pci) > > > > This function returns a bool value, make it return a bool. > > This function is registered in struct dw_pcie_ops.link_up, that is defined > in

Re: [PATCHv3 0/4] dts/layerscape-pci: removed unsuitable compatible string

2018-11-23 Thread Lorenzo Pieralisi
On Mon, Nov 19, 2018 at 08:01:25PM +0800, Shawn Guo wrote: > On Wed, Nov 07, 2018 at 05:35:12AM +, Z.q. Hou wrote: > > From: Hou Zhiqiang > > > > Removed the compatible string "snps,dw-pcie" from FSL layerscape-pci > > compatible > > string list. > > > > Hou Zhiqiang (4): > >

Re: [PATCHv3 0/4] dts/layerscape-pci: removed unsuitable compatible string

2018-11-23 Thread Lorenzo Pieralisi
On Mon, Nov 19, 2018 at 08:01:25PM +0800, Shawn Guo wrote: > On Wed, Nov 07, 2018 at 05:35:12AM +, Z.q. Hou wrote: > > From: Hou Zhiqiang > > > > Removed the compatible string "snps,dw-pcie" from FSL layerscape-pci > > compatible > > string list. > > > > Hou Zhiqiang (4): > >

Re: [PATCH v2] PCI: imx: Add imx6sx suspend/resume support

2018-11-22 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 01:57:03PM +, Leonard Crestez wrote: > Enable PCI suspend/resume support on imx6sx socs. This is similar to > imx7d with a few differences: > > * The PM_Turn_Off bit is exposed through an IOMUX GPR, like all other > pcie control bits on 6sx. > * The pcie_inbound_axi

Re: [PATCH v2] PCI: imx: Add imx6sx suspend/resume support

2018-11-22 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 01:57:03PM +, Leonard Crestez wrote: > Enable PCI suspend/resume support on imx6sx socs. This is similar to > imx7d with a few differences: > > * The PM_Turn_Off bit is exposed through an IOMUX GPR, like all other > pcie control bits on 6sx. > * The pcie_inbound_axi

Re: [PATCH v2] PCI: imx: Add imx6sx suspend/resume support

2018-11-22 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 01:57:03PM +, Leonard Crestez wrote: > Enable PCI suspend/resume support on imx6sx socs. This is similar to > imx7d with a few differences: > > * The PM_Turn_Off bit is exposed through an IOMUX GPR, like all other > pcie control bits on 6sx. > * The pcie_inbound_axi

Re: [PATCH v2] PCI: imx: Add imx6sx suspend/resume support

2018-11-22 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 01:57:03PM +, Leonard Crestez wrote: > Enable PCI suspend/resume support on imx6sx socs. This is similar to > imx7d with a few differences: > > * The PM_Turn_Off bit is exposed through an IOMUX GPR, like all other > pcie control bits on 6sx. > * The pcie_inbound_axi

Re: [PATCH 2/4] doc/layerscape-pci: removed unsuitable compatible string

2018-11-22 Thread Lorenzo Pieralisi
On Mon, Oct 08, 2018 at 11:14:26AM +0800, Zhiqiang Hou wrote: > From: Hou Zhiqiang > > Removed the compatible string "snps,dw-pcie", it is for the reference > platform driver for PCI RC IP Protoyping Kits based on the ARC SDP, > so it is not suitable for all platform with designware PCIe

Re: [PATCH 2/4] doc/layerscape-pci: removed unsuitable compatible string

2018-11-22 Thread Lorenzo Pieralisi
On Mon, Oct 08, 2018 at 11:14:26AM +0800, Zhiqiang Hou wrote: > From: Hou Zhiqiang > > Removed the compatible string "snps,dw-pcie", it is for the reference > platform driver for PCI RC IP Protoyping Kits based on the ARC SDP, > so it is not suitable for all platform with designware PCIe

Re: [PATCHv2 3/4] PCI: layerscape: initialize the number of viewport

2018-11-22 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 10:09:16AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > FSL implements 6 viewports on Layerscape series SoCs PCIe > controllers. > > Signed-off-by: Hou Zhiqiang > --- > V2: > - Reworded the subject and commit description. > >

Re: [PATCHv2 3/4] PCI: layerscape: initialize the number of viewport

2018-11-22 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 10:09:16AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > FSL implements 6 viewports on Layerscape series SoCs PCIe > controllers. > > Signed-off-by: Hou Zhiqiang > --- > V2: > - Reworded the subject and commit description. > >

Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-21 Thread Lorenzo Pieralisi
On Wed, Nov 21, 2018 at 01:47:05PM +, Leonard Crestez wrote: > On 11/20/2018 11:28 PM, Trent Piepho wrote: > > On Tue, 2018-11-20 at 21:42 +0100, Stefan Agner wrote: > >> On 20.11.2018 20:13, Trent Piepho wrote: > > >>> It also seems to me that this doesn't need to be in the internal pci >

Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-21 Thread Lorenzo Pieralisi
On Wed, Nov 21, 2018 at 01:47:05PM +, Leonard Crestez wrote: > On 11/20/2018 11:28 PM, Trent Piepho wrote: > > On Tue, 2018-11-20 at 21:42 +0100, Stefan Agner wrote: > >> On 20.11.2018 20:13, Trent Piepho wrote: > > >>> It also seems to me that this doesn't need to be in the internal pci >

Re: [PATCH v2] PCI: dwc: Adjust Kconfig to allow IMX6 PCIe host on IMX7

2018-11-20 Thread Lorenzo Pieralisi
On Fri, Nov 16, 2018 at 12:08:33AM +, Trent Piepho wrote: > The IMX6 PCI-e host drier also supports the IMX7d. However, the > Kconfig dependencies of the driver prevented it from being enabled > unless the kernel was built with both IMX6 and IMX7 support. It works > fine to build with only

Re: [PATCH v2] PCI: dwc: Adjust Kconfig to allow IMX6 PCIe host on IMX7

2018-11-20 Thread Lorenzo Pieralisi
On Fri, Nov 16, 2018 at 12:08:33AM +, Trent Piepho wrote: > The IMX6 PCI-e host drier also supports the IMX7d. However, the > Kconfig dependencies of the driver prevented it from being enabled > unless the kernel was built with both IMX6 and IMX7 support. It works > fine to build with only

Re: [PATCH v2 1/3] PCI: dwc: allow to limit registers set length

2018-11-20 Thread Lorenzo Pieralisi
On Tue, Nov 20, 2018 at 02:27:03PM +0100, Stefan Agner wrote: > Add length to the struct dw_pcie and check that the accessors > dw_pcie_(rd|wr)_own_conf() do not read/write beyond that point. > > Signed-off-by: Stefan Agner > --- > drivers/pci/controller/dwc/pcie-designware-host.c | 4 >

Re: [PATCH v2 1/3] PCI: dwc: allow to limit registers set length

2018-11-20 Thread Lorenzo Pieralisi
On Tue, Nov 20, 2018 at 02:27:03PM +0100, Stefan Agner wrote: > Add length to the struct dw_pcie and check that the accessors > dw_pcie_(rd|wr)_own_conf() do not read/write beyond that point. > > Signed-off-by: Stefan Agner > --- > drivers/pci/controller/dwc/pcie-designware-host.c | 4 >

Re: [PATCH] PCI: dwc: layerscape: constify driver data

2018-11-20 Thread Lorenzo Pieralisi
On Mon, Nov 19, 2018 at 11:00:22AM +0100, Stefan Agner wrote: > Constify driver data since they don't get changed at runtime. > > Signed-off-by: Stefan Agner > --- > drivers/pci/controller/dwc/pci-layerscape.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Applied to

Re: [PATCH] PCI: dwc: layerscape: constify driver data

2018-11-20 Thread Lorenzo Pieralisi
On Mon, Nov 19, 2018 at 11:00:22AM +0100, Stefan Agner wrote: > Constify driver data since they don't get changed at runtime. > > Signed-off-by: Stefan Agner > --- > drivers/pci/controller/dwc/pci-layerscape.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Applied to

Re: [PATCH 0/4] dts/layerscape-pci: removed unsuitable compatible string

2018-11-20 Thread Lorenzo Pieralisi
On Mon, Oct 08, 2018 at 11:14:24AM +0800, Zhiqiang Hou wrote: > From: Hou Zhiqiang > > Removed the compatible string "snps,dw-pcie" from FSL layerscape-pci > compatible > string list. > > Hou Zhiqiang (4): > doc/layerscape-pci: update the PCIe compatible strings > doc/layerscape-pci:

Re: [PATCH 0/4] dts/layerscape-pci: removed unsuitable compatible string

2018-11-20 Thread Lorenzo Pieralisi
On Mon, Oct 08, 2018 at 11:14:24AM +0800, Zhiqiang Hou wrote: > From: Hou Zhiqiang > > Removed the compatible string "snps,dw-pcie" from FSL layerscape-pci > compatible > string list. > > Hou Zhiqiang (4): > doc/layerscape-pci: update the PCIe compatible strings > doc/layerscape-pci:

Re: [PATCH] PCI: histb: constify dw_pcie_host_ops structure

2018-11-20 Thread Lorenzo Pieralisi
On Sat, Oct 27, 2018 at 08:31:19PM +0200, Julia Lawall wrote: > The dw_pcie_host_ops structure is only stored in the ops field > of a pcie_port structure, and this field is const, so make the > dw_pcie_host_ops structure const as well. > > Done with the help of Coccinelle. > > Signed-off-by:

Re: [PATCH] PCI: histb: constify dw_pcie_host_ops structure

2018-11-20 Thread Lorenzo Pieralisi
On Sat, Oct 27, 2018 at 08:31:19PM +0200, Julia Lawall wrote: > The dw_pcie_host_ops structure is only stored in the ops field > of a pcie_port structure, and this field is const, so make the > dw_pcie_host_ops structure const as well. > > Done with the help of Coccinelle. > > Signed-off-by:

Re: [PATCHv2] PCI/Layerscape: fix wrongly invoking of outbound window disable accessor

2018-11-20 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 05:16:49AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > The order of parameters is not correct when invoking the outbound > window disable routine. > > Fixes: commit 4a2745d760fac ("PCI: layerscape: Disable outbound > windows configured by bootloader"). > > Cc:

Re: [PATCHv2] PCI/Layerscape: fix wrongly invoking of outbound window disable accessor

2018-11-20 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 05:16:49AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > The order of parameters is not correct when invoking the outbound > window disable routine. > > Fixes: commit 4a2745d760fac ("PCI: layerscape: Disable outbound > windows configured by bootloader"). > > Cc:

Re: [RESEND PATCH v3 2/2] PCI: uniphier: Add UniPhier PCIe host controller support

2018-11-19 Thread Lorenzo Pieralisi
On Tue, Oct 16, 2018 at 02:27:21PM +0900, Kunihiko Hayashi wrote: > This introduces specific glue layer for UniPhier platform to support > PCIe host controller that is based on the DesignWare PCIe core, and > this driver supports Root Complex (host) mode. > > Signed-off-by: Kunihiko Hayashi >

Re: [RESEND PATCH v3 2/2] PCI: uniphier: Add UniPhier PCIe host controller support

2018-11-19 Thread Lorenzo Pieralisi
On Tue, Oct 16, 2018 at 02:27:21PM +0900, Kunihiko Hayashi wrote: > This introduces specific glue layer for UniPhier platform to support > PCIe host controller that is based on the DesignWare PCIe core, and > this driver supports Root Complex (host) mode. > > Signed-off-by: Kunihiko Hayashi >

Re: [RESEND PATCH v3 1/2] dt-bindings: PCI: Add UniPhier PCIe host controller description

2018-11-19 Thread Lorenzo Pieralisi
On Tue, Oct 16, 2018 at 02:27:20PM +0900, Kunihiko Hayashi wrote: > Add DT bindings for PCIe controller implemented in UniPhier SoCs when > configured in Root Complex (host) mode. This controller is based on > the DesignWare PCIe core. > > Signed-off-by: Kunihiko Hayashi > Reviewed-by: Rob

Re: [RESEND PATCH v3 1/2] dt-bindings: PCI: Add UniPhier PCIe host controller description

2018-11-19 Thread Lorenzo Pieralisi
On Tue, Oct 16, 2018 at 02:27:20PM +0900, Kunihiko Hayashi wrote: > Add DT bindings for PCIe controller implemented in UniPhier SoCs when > configured in Root Complex (host) mode. This controller is based on > the DesignWare PCIe core. > > Signed-off-by: Kunihiko Hayashi > Reviewed-by: Rob

Re: [PATCH v5 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-11-16 Thread Lorenzo Pieralisi
On Tue, Oct 09, 2018 at 09:53:10AM +0800, Hanjie Lin wrote: > From: Yue Wang > > The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare > PCI core. This patch adds the driver support for Meson PCIe controller. > > Signed-off-by: Yue Wang > Signed-off-by: Hanjie Lin > --- >

Re: [PATCH v5 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-11-16 Thread Lorenzo Pieralisi
On Tue, Oct 09, 2018 at 09:53:10AM +0800, Hanjie Lin wrote: > From: Yue Wang > > The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare > PCI core. This patch adds the driver support for Meson PCIe controller. > > Signed-off-by: Yue Wang > Signed-off-by: Hanjie Lin > --- >

Re: [PATCH] tools: PCI: exit with error code when test fails

2018-11-16 Thread Lorenzo Pieralisi
On Thu, Oct 04, 2018 at 12:11:44PM +0100, Lorenzo Pieralisi wrote: > On Thu, Sep 20, 2018 at 05:02:53PM +0200, Jean-Jacques Hiblot wrote: > > This makes it easier to use pcitest in automated setups. > > > > Signed-off-by: Jean-Jacques Hiblot > > --- > > tools/p

Re: [PATCH] tools: PCI: exit with error code when test fails

2018-11-16 Thread Lorenzo Pieralisi
On Thu, Oct 04, 2018 at 12:11:44PM +0100, Lorenzo Pieralisi wrote: > On Thu, Sep 20, 2018 at 05:02:53PM +0200, Jean-Jacques Hiblot wrote: > > This makes it easier to use pcitest in automated setups. > > > > Signed-off-by: Jean-Jacques Hiblot > > --- > > tools/p

Re: [PATCH] PCI: mediatek: Use devm_of_pci_get_host_bridge_resources() to parse DT

2018-11-07 Thread Lorenzo Pieralisi
On Thu, Oct 18, 2018 at 11:23:34AM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > Use the devm_of_pci_get_host_bridge_resources() API in place of the PCI OF > DT parser. > > Signed-off-by: Honghui Zhang > --- > drivers/pci/controller/pcie-mediatek.c | 109 >

Re: [PATCH] PCI: mediatek: Use devm_of_pci_get_host_bridge_resources() to parse DT

2018-11-07 Thread Lorenzo Pieralisi
On Thu, Oct 18, 2018 at 11:23:34AM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > Use the devm_of_pci_get_host_bridge_resources() API in place of the PCI OF > DT parser. > > Signed-off-by: Honghui Zhang > --- > drivers/pci/controller/pcie-mediatek.c | 109 >

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Lorenzo Pieralisi
On Tue, Nov 06, 2018 at 09:47:52AM -0700, Keith Busch wrote: > On Tue, Nov 06, 2018 at 04:34:08PM +0000, Lorenzo Pieralisi wrote: > > The question is whether we really need to dynamically patch the kernel > > with ftrace to achieve what that patch does. > > > > Further

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Lorenzo Pieralisi
On Tue, Nov 06, 2018 at 09:47:52AM -0700, Keith Busch wrote: > On Tue, Nov 06, 2018 at 04:34:08PM +0000, Lorenzo Pieralisi wrote: > > The question is whether we really need to dynamically patch the kernel > > with ftrace to achieve what that patch does. > > > > Further

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Lorenzo Pieralisi
On Mon, Oct 08, 2018 at 10:18:47AM -0600, Keith Busch wrote: > On Fri, Oct 05, 2018 at 12:31:45PM -0500, Bjorn Helgaas wrote: > > [+cc arm64 folks, LKML: This conversation is about this patch: > > > > > > https://lore.kernel.org/linux-pci/20180918235848.26694-3-keith.bu...@intel.com > > > >

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Lorenzo Pieralisi
On Mon, Oct 08, 2018 at 10:18:47AM -0600, Keith Busch wrote: > On Fri, Oct 05, 2018 at 12:31:45PM -0500, Bjorn Helgaas wrote: > > [+cc arm64 folks, LKML: This conversation is about this patch: > > > > > > https://lore.kernel.org/linux-pci/20180918235848.26694-3-keith.bu...@intel.com > > > >

Re: [PATCH 2/2] arm64: acpi: Prepare for longer MADTs

2018-11-01 Thread Lorenzo Pieralisi
On Fri, Oct 12, 2018 at 02:29:37PM -0500, Jeremy Linton wrote: > The BAD_MADT_GICC_ENTRY check is a little too strict because > it rejects MADT entries that don't match the currently known > lengths. We should remove this restriction to avoid problems > if the table length changes. Future code

Re: [PATCH 2/2] arm64: acpi: Prepare for longer MADTs

2018-11-01 Thread Lorenzo Pieralisi
On Fri, Oct 12, 2018 at 02:29:37PM -0500, Jeremy Linton wrote: > The BAD_MADT_GICC_ENTRY check is a little too strict because > it rejects MADT entries that don't match the currently known > lengths. We should remove this restriction to avoid problems > if the table length changes. Future code

Re: [PATCH v8 0/9] PCI: mediatek: fixup find_port, enable_msi and add PM, module support

2018-10-17 Thread Lorenzo Pieralisi
On Mon, Oct 15, 2018 at 04:08:51PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > This patchset includes misc patchs: > > The patch 1 fixup the mtk_pcie_find_port logic which will cause system > could not touch the EP's configuration space that connected to PCIe slot 1. > >

Re: [PATCH v8 0/9] PCI: mediatek: fixup find_port, enable_msi and add PM, module support

2018-10-17 Thread Lorenzo Pieralisi
On Mon, Oct 15, 2018 at 04:08:51PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > This patchset includes misc patchs: > > The patch 1 fixup the mtk_pcie_find_port logic which will cause system > could not touch the EP's configuration space that connected to PCIe slot 1. > >

Re: [PATCH v2 00/21] PCI: Cleanup pci-keystone driver

2018-10-17 Thread Lorenzo Pieralisi
On Wed, Oct 17, 2018 at 01:10:53PM +0530, Kishon Vijay Abraham I wrote: > The PCIe controller in AM654 uses Synopsys core revision 4.90a and uses > the same TI wrapper as used in keystone2 with certain modification. > Hence AM654 will use the same pci wrapper driver pci-keystone.c > > In

Re: [PATCH v2 00/21] PCI: Cleanup pci-keystone driver

2018-10-17 Thread Lorenzo Pieralisi
On Wed, Oct 17, 2018 at 01:10:53PM +0530, Kishon Vijay Abraham I wrote: > The PCIe controller in AM654 uses Synopsys core revision 4.90a and uses > the same TI wrapper as used in keystone2 with certain modification. > Hence AM654 will use the same pci wrapper driver pci-keystone.c > > In

Re: [PATCH 11/19] PCI: keystone: Cleanup PHY handling

2018-10-16 Thread Lorenzo Pieralisi
On Mon, Oct 15, 2018 at 06:37:13PM +0530, Kishon Vijay Abraham I wrote: > Cleanup PHY handling by using devm_phy_optional_get to get PHYs if > the PHYs are optional, creating a device link between the PHY device > and the controller device and disable PHY on error cases here. > Also invoke

Re: [PATCH 11/19] PCI: keystone: Cleanup PHY handling

2018-10-16 Thread Lorenzo Pieralisi
On Mon, Oct 15, 2018 at 06:37:13PM +0530, Kishon Vijay Abraham I wrote: > Cleanup PHY handling by using devm_phy_optional_get to get PHYs if > the PHYs are optional, creating a device link between the PHY device > and the controller device and disable PHY on error cases here. > Also invoke

Re: [PATCH v9 2/9] PCI: Using PCI configuration space header type instead of class type to assign resource

2018-10-16 Thread Lorenzo Pieralisi
On Tue, Oct 16, 2018 at 06:44:43PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > The PCI configuration space header type defines the layout of the rest > of the header (PCI r3.0 sec 6.1, PCIe r4.0 sec 7.5.1.1.9) while the > resource assignment is based on the configuration

Re: [PATCH v9 2/9] PCI: Using PCI configuration space header type instead of class type to assign resource

2018-10-16 Thread Lorenzo Pieralisi
On Tue, Oct 16, 2018 at 06:44:43PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > The PCI configuration space header type defines the layout of the rest > of the header (PCI r3.0 sec 6.1, PCIe r4.0 sec 7.5.1.1.9) while the > resource assignment is based on the configuration

Re: [RFC PATCH 00/40] Cleanup pci-keystone.c and Add AM654 PCIe Support

2018-10-12 Thread Lorenzo Pieralisi
On Fri, Sep 21, 2018 at 03:51:15PM +0530, Kishon Vijay Abraham I wrote: > Add PCIe RC support for TI's AM654 SoC. The PCIe controller in AM654 > uses Synopsys core revision 4.90a and uses the same TI wrapper as used > in keystone2 with certain modification. Hence AM654 will use the same > pci

Re: [RFC PATCH 00/40] Cleanup pci-keystone.c and Add AM654 PCIe Support

2018-10-12 Thread Lorenzo Pieralisi
On Fri, Sep 21, 2018 at 03:51:15PM +0530, Kishon Vijay Abraham I wrote: > Add PCIe RC support for TI's AM654 SoC. The PCIe controller in AM654 > uses Synopsys core revision 4.90a and uses the same TI wrapper as used > in keystone2 with certain modification. Hence AM654 will use the same > pci

Re: [PATCH v6 2/9] PCI: mediatek: Fixup class ID for MT7622 as PCI_CLASS_BRIDGE_PCI

2018-10-12 Thread Lorenzo Pieralisi
On Fri, Oct 12, 2018 at 04:01:29PM +0800, Honghui Zhang wrote: > On Thu, 2018-10-11 at 12:38 +0100, Lorenzo Pieralisi wrote: > > On Tue, Oct 09, 2018 at 11:08:15AM +0800, Honghui Zhang wrote: > > > On Mon, 2018-10-08 at 18:23 +0100, Lorenzo Pieralisi wrote: > > > >

Re: [PATCH v6 2/9] PCI: mediatek: Fixup class ID for MT7622 as PCI_CLASS_BRIDGE_PCI

2018-10-12 Thread Lorenzo Pieralisi
On Fri, Oct 12, 2018 at 04:01:29PM +0800, Honghui Zhang wrote: > On Thu, 2018-10-11 at 12:38 +0100, Lorenzo Pieralisi wrote: > > On Tue, Oct 09, 2018 at 11:08:15AM +0800, Honghui Zhang wrote: > > > On Mon, 2018-10-08 at 18:23 +0100, Lorenzo Pieralisi wrote: > > > >

Re: [PATCH v6 2/9] PCI: mediatek: Fixup class ID for MT7622 as PCI_CLASS_BRIDGE_PCI

2018-10-11 Thread Lorenzo Pieralisi
On Tue, Oct 09, 2018 at 11:08:15AM +0800, Honghui Zhang wrote: > On Mon, 2018-10-08 at 18:23 +0100, Lorenzo Pieralisi wrote: > > On Mon, Oct 08, 2018 at 11:24:41AM +0800, honghui.zh...@mediatek.com wrote: > > > From: Honghui Zhang > > > > > > The

Re: [PATCH v6 2/9] PCI: mediatek: Fixup class ID for MT7622 as PCI_CLASS_BRIDGE_PCI

2018-10-11 Thread Lorenzo Pieralisi
On Tue, Oct 09, 2018 at 11:08:15AM +0800, Honghui Zhang wrote: > On Mon, 2018-10-08 at 18:23 +0100, Lorenzo Pieralisi wrote: > > On Mon, Oct 08, 2018 at 11:24:41AM +0800, honghui.zh...@mediatek.com wrote: > > > From: Honghui Zhang > > > > > > The

Re: [PATCH v6 2/9] PCI: mediatek: Fixup class ID for MT7622 as PCI_CLASS_BRIDGE_PCI

2018-10-08 Thread Lorenzo Pieralisi
On Mon, Oct 08, 2018 at 11:24:41AM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > The PCIe controller of MT7622 has TYPE 1 configuration space type, but > the HW default class type values is invalid. > > The commit 101c92dc80c8 ("PCI: mediatek: Set up vendor ID and class >

Re: [PATCH v6 2/9] PCI: mediatek: Fixup class ID for MT7622 as PCI_CLASS_BRIDGE_PCI

2018-10-08 Thread Lorenzo Pieralisi
On Mon, Oct 08, 2018 at 11:24:41AM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > The PCIe controller of MT7622 has TYPE 1 configuration space type, but > the HW default class type values is invalid. > > The commit 101c92dc80c8 ("PCI: mediatek: Set up vendor ID and class >

<    3   4   5   6   7   8   9   10   11   12   >