Re: [PATCH v2 2/2] PCI: controller: dwc: add UniPhier PCIe host controller support

2018-10-08 Thread Lorenzo Pieralisi
On Mon, Oct 08, 2018 at 11:15:59AM +0530, Kishon Vijay Abraham I wrote: > Hi Lorenzo, > > On Friday 28 September 2018 09:13 PM, Lorenzo Pieralisi wrote: > > On Fri, Sep 28, 2018 at 02:17:16PM +0100, Marc Zyngier wrote: > >> On 28/09/18 12:06, Lorenzo Pieralisi wro

Re: [PATCH v2 2/2] PCI: controller: dwc: add UniPhier PCIe host controller support

2018-10-08 Thread Lorenzo Pieralisi
On Mon, Oct 08, 2018 at 11:15:59AM +0530, Kishon Vijay Abraham I wrote: > Hi Lorenzo, > > On Friday 28 September 2018 09:13 PM, Lorenzo Pieralisi wrote: > > On Fri, Sep 28, 2018 at 02:17:16PM +0100, Marc Zyngier wrote: > >> On 28/09/18 12:06, Lorenzo Pieralisi wro

Re: [PATCH v2 4/4] PCI: imx: Add PME_Turn_Off support

2018-10-05 Thread Lorenzo Pieralisi
On Fri, Oct 05, 2018 at 12:59:16PM +0200, Philipp Zabel wrote: > Hi Lorenzo, > > On Fri, 2018-10-05 at 11:29 +0100, Lorenzo Pieralisi wrote: > > On Thu, Oct 04, 2018 at 04:34:30PM +, Leonard Crestez wrote: > > > When the root complex suspends it must send a PME_Turn_

Re: [PATCH v2 4/4] PCI: imx: Add PME_Turn_Off support

2018-10-05 Thread Lorenzo Pieralisi
On Fri, Oct 05, 2018 at 12:59:16PM +0200, Philipp Zabel wrote: > Hi Lorenzo, > > On Fri, 2018-10-05 at 11:29 +0100, Lorenzo Pieralisi wrote: > > On Thu, Oct 04, 2018 at 04:34:30PM +, Leonard Crestez wrote: > > > When the root complex suspends it must send a PME_Turn_

Re: [PATCH v9 00/11] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) (a subset)

2018-10-05 Thread Lorenzo Pieralisi
On Thu, Oct 04, 2018 at 08:36:24PM +0200, Ulf Hansson wrote: > On 4 October 2018 at 19:21, Lorenzo Pieralisi > wrote: > > On Thu, Oct 04, 2018 at 07:07:27PM +0200, Rafael J. Wysocki wrote: > > > > [...] > > > >> > > I don't see any dependency t

Re: [PATCH v9 00/11] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) (a subset)

2018-10-05 Thread Lorenzo Pieralisi
On Thu, Oct 04, 2018 at 08:36:24PM +0200, Ulf Hansson wrote: > On 4 October 2018 at 19:21, Lorenzo Pieralisi > wrote: > > On Thu, Oct 04, 2018 at 07:07:27PM +0200, Rafael J. Wysocki wrote: > > > > [...] > > > >> > > I don't see any dependency t

Re: [PATCH v2 4/4] PCI: imx: Add PME_Turn_Off support

2018-10-05 Thread Lorenzo Pieralisi
On Thu, Oct 04, 2018 at 04:34:30PM +, Leonard Crestez wrote: > When the root complex suspends it must send a PME_Turn_Off TLP. > Implement this by asserting the "turnoff" reset. > > On imx7d this functionality is part of the SRC and exposed through the > linux reset-controller subsystem. On

Re: [PATCH v2 4/4] PCI: imx: Add PME_Turn_Off support

2018-10-05 Thread Lorenzo Pieralisi
On Thu, Oct 04, 2018 at 04:34:30PM +, Leonard Crestez wrote: > When the root complex suspends it must send a PME_Turn_Off TLP. > Implement this by asserting the "turnoff" reset. > > On imx7d this functionality is part of the SRC and exposed through the > linux reset-controller subsystem. On

Re: [PATCH v9 00/11] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) (a subset)

2018-10-04 Thread Lorenzo Pieralisi
On Thu, Oct 04, 2018 at 07:07:27PM +0200, Rafael J. Wysocki wrote: [...] > > > I don't see any dependency there, so I'll queue up the 1-3 in > > > pm-domains and the 4-6 in pm-cpuidle. > > > > I do not see why we should merge patches 4-6 for v4.20; they add legacy > > (DT bindings and related

Re: [PATCH v9 00/11] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) (a subset)

2018-10-04 Thread Lorenzo Pieralisi
On Thu, Oct 04, 2018 at 07:07:27PM +0200, Rafael J. Wysocki wrote: [...] > > > I don't see any dependency there, so I'll queue up the 1-3 in > > > pm-domains and the 4-6 in pm-cpuidle. > > > > I do not see why we should merge patches 4-6 for v4.20; they add legacy > > (DT bindings and related

Re: [PATCH v2 1/4] reset: imx7: Add PCIE_CTRL_APPS_TURNOFF

2018-10-04 Thread Lorenzo Pieralisi
On Thu, Oct 04, 2018 at 06:47:01PM +0200, Philipp Zabel wrote: > Hi Leonard, > > On Thu, 2018-10-04 at 16:34 +, Leonard Crestez wrote: > > This is required for the imx pci driver to send the PME_Turn_Off TLP. > > > > Signed-off-by: Leonard Crestez > > Acked-by: Rob Herring > > --- > >

Re: [PATCH v2 1/4] reset: imx7: Add PCIE_CTRL_APPS_TURNOFF

2018-10-04 Thread Lorenzo Pieralisi
On Thu, Oct 04, 2018 at 06:47:01PM +0200, Philipp Zabel wrote: > Hi Leonard, > > On Thu, 2018-10-04 at 16:34 +, Leonard Crestez wrote: > > This is required for the imx pci driver to send the PME_Turn_Off TLP. > > > > Signed-off-by: Leonard Crestez > > Acked-by: Rob Herring > > --- > >

Re: [PATCH v3 1/3] acpi: arm64: add iort support for PMCG

2018-10-04 Thread Lorenzo Pieralisi
On Fri, Sep 21, 2018 at 04:08:01PM +0100, Shameer Kolothum wrote: > From: Neil Leeder > > Add support for the SMMU Performance Monitor Counter Group > information from ACPI. This is in preparation for its use > in the SMMUv3 PMU driver. > > Signed-off-by: Neil Leeder > Signed-off-by: Hanjun

Re: [PATCH v3 1/3] acpi: arm64: add iort support for PMCG

2018-10-04 Thread Lorenzo Pieralisi
On Fri, Sep 21, 2018 at 04:08:01PM +0100, Shameer Kolothum wrote: > From: Neil Leeder > > Add support for the SMMU Performance Monitor Counter Group > information from ACPI. This is in preparation for its use > in the SMMUv3 PMU driver. > > Signed-off-by: Neil Leeder > Signed-off-by: Hanjun

Re: [PATCH v9 00/11] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) (a subset)

2018-10-04 Thread Lorenzo Pieralisi
> On Wed, Oct 3, 2018 at 4:39 PM Ulf Hansson > > > > wrote: > > > >> > > > >> I have digested the review comments so far, including a recent offlist > > > >> chat > > > >> with with Lorenzo Pieral

Re: [PATCH v9 00/11] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) (a subset)

2018-10-04 Thread Lorenzo Pieralisi
> On Wed, Oct 3, 2018 at 4:39 PM Ulf Hansson > > > > wrote: > > > >> > > > >> I have digested the review comments so far, including a recent offlist > > > >> chat > > > >> with with Lorenzo Pieral

Re: [PATCH] tools: PCI: exit with error code when test fails

2018-10-04 Thread Lorenzo Pieralisi
On Thu, Sep 20, 2018 at 05:02:53PM +0200, Jean-Jacques Hiblot wrote: > This makes it easier to use pcitest in automated setups. > > Signed-off-by: Jean-Jacques Hiblot > --- > tools/pci/pcitest.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/pci/pcitest.c

Re: [PATCH] tools: PCI: exit with error code when test fails

2018-10-04 Thread Lorenzo Pieralisi
On Thu, Sep 20, 2018 at 05:02:53PM +0200, Jean-Jacques Hiblot wrote: > This makes it easier to use pcitest in automated setups. > > Signed-off-by: Jean-Jacques Hiblot > --- > tools/pci/pcitest.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/pci/pcitest.c

Re: [PATCH] tools/pci: Fix compilation warnings

2018-10-03 Thread Lorenzo Pieralisi
On Thu, Aug 23, 2018 at 01:34:53PM +0200, Gustavo Pimentel wrote: > Fix compilation warnings: > - remove unused variables > - change function return from int to void, since it's not used > > Signed-off-by: Gustavo Pimentel > --- > tools/pci/pcitest.c | 7 ++- > 1 file changed, 2

Re: [PATCH] tools/pci: Fix compilation warnings

2018-10-03 Thread Lorenzo Pieralisi
On Thu, Aug 23, 2018 at 01:34:53PM +0200, Gustavo Pimentel wrote: > Fix compilation warnings: > - remove unused variables > - change function return from int to void, since it's not used > > Signed-off-by: Gustavo Pimentel > --- > tools/pci/pcitest.c | 7 ++- > 1 file changed, 2

Re: [PATCH 4/4] PCI: imx: Add PME_Turn_Off support

2018-10-02 Thread Lorenzo Pieralisi
On Mon, Oct 01, 2018 at 10:53:48PM +0300, Leonard Crestez wrote: > When the root complex suspends it must send a PME_Turn_Off TLP. > Implement this by asserting the "turnoff" reset. > > On imx7d this is functionality is part of the SRC and exposed through > the linux reset-controller subsystem.

Re: [PATCH 4/4] PCI: imx: Add PME_Turn_Off support

2018-10-02 Thread Lorenzo Pieralisi
On Mon, Oct 01, 2018 at 10:53:48PM +0300, Leonard Crestez wrote: > When the root complex suspends it must send a PME_Turn_Off TLP. > Implement this by asserting the "turnoff" reset. > > On imx7d this is functionality is part of the SRC and exposed through > the linux reset-controller subsystem.

Re: [PATCH v5 6/9] PCI: mediatek: Enable msi after clock enabled

2018-10-02 Thread Lorenzo Pieralisi
On Fri, Sep 28, 2018 at 06:04:37PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > The clocks was not enabled when enable MSI. This patch fix this > issue by calling mtk_pcie_enable_msi in mtk_pcie_startup_port_v2 > since the clock was all enabled at that time. > >

Re: [PATCH v5 6/9] PCI: mediatek: Enable msi after clock enabled

2018-10-02 Thread Lorenzo Pieralisi
On Fri, Sep 28, 2018 at 06:04:37PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > The clocks was not enabled when enable MSI. This patch fix this > issue by calling mtk_pcie_enable_msi in mtk_pcie_startup_port_v2 > since the clock was all enabled at that time. > >

Re: [PATCH v5 1/9] PCI: mediatek: Using slot's devfn for compare to fix mtk_pcie_find_port logic

2018-10-02 Thread Lorenzo Pieralisi
On Mon, Oct 01, 2018 at 03:36:41PM +0100, Lorenzo Pieralisi wrote: > On Fri, Sep 28, 2018 at 06:04:32PM +0800, honghui.zh...@mediatek.com wrote: > > From: Honghui Zhang > > > > The Mediatek's host controller has two slots, each with it's own control > > regi

Re: [PATCH v5 1/9] PCI: mediatek: Using slot's devfn for compare to fix mtk_pcie_find_port logic

2018-10-02 Thread Lorenzo Pieralisi
On Mon, Oct 01, 2018 at 03:36:41PM +0100, Lorenzo Pieralisi wrote: > On Fri, Sep 28, 2018 at 06:04:32PM +0800, honghui.zh...@mediatek.com wrote: > > From: Honghui Zhang > > > > The Mediatek's host controller has two slots, each with it's own control > > regi

Re: [PATCH v2] PCI: kirin: Fix section mismatch warning

2018-10-01 Thread Lorenzo Pieralisi
On Mon, Oct 01, 2018 at 08:12:05AM -0700, Nathan Chancellor wrote: > On Mon, Oct 01, 2018 at 03:53:41PM +0100, Lorenzo Pieralisi wrote: > > On Thu, Sep 20, 2018 at 11:58:28AM +0100, Lorenzo Pieralisi wrote: > > > [+Paul] > > > > > > On Wed, Sep 19, 2018 at 02:0

Re: [PATCH v2] PCI: kirin: Fix section mismatch warning

2018-10-01 Thread Lorenzo Pieralisi
On Mon, Oct 01, 2018 at 08:12:05AM -0700, Nathan Chancellor wrote: > On Mon, Oct 01, 2018 at 03:53:41PM +0100, Lorenzo Pieralisi wrote: > > On Thu, Sep 20, 2018 at 11:58:28AM +0100, Lorenzo Pieralisi wrote: > > > [+Paul] > > > > > > On Wed, Sep 19, 2018 at 02:0

Re: [PATCH v2] PCI: kirin: Fix section mismatch warning

2018-10-01 Thread Lorenzo Pieralisi
On Thu, Sep 20, 2018 at 11:58:28AM +0100, Lorenzo Pieralisi wrote: > [+Paul] > > On Wed, Sep 19, 2018 at 02:08:08PM -0700, Nick Desaulniers wrote: > > On Wed, Sep 19, 2018 at 11:55 AM Nathan Chancellor > > wrote: > > > > > > WARNING: vmlinux.o(.text+0x4758

Re: [PATCH v2] PCI: kirin: Fix section mismatch warning

2018-10-01 Thread Lorenzo Pieralisi
On Thu, Sep 20, 2018 at 11:58:28AM +0100, Lorenzo Pieralisi wrote: > [+Paul] > > On Wed, Sep 19, 2018 at 02:08:08PM -0700, Nick Desaulniers wrote: > > On Wed, Sep 19, 2018 at 11:55 AM Nathan Chancellor > > wrote: > > > > > > WARNING: vmlinux.o(.text+0x4758

Re: [PATCH v5 1/9] PCI: mediatek: Using slot's devfn for compare to fix mtk_pcie_find_port logic

2018-10-01 Thread Lorenzo Pieralisi
On Fri, Sep 28, 2018 at 06:04:32PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > The Mediatek's host controller has two slots, each with it's own control > registers. The host driver need to identify which slot was connected > in order to access the device's configuration

Re: [PATCH v5 1/9] PCI: mediatek: Using slot's devfn for compare to fix mtk_pcie_find_port logic

2018-10-01 Thread Lorenzo Pieralisi
On Fri, Sep 28, 2018 at 06:04:32PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > The Mediatek's host controller has two slots, each with it's own control > registers. The host driver need to identify which slot was connected > in order to access the device's configuration

Re: [PATCH v2 2/2] PCI: controller: dwc: add UniPhier PCIe host controller support

2018-10-01 Thread Lorenzo Pieralisi
On Fri, Sep 28, 2018 at 02:17:16PM +0100, Marc Zyngier wrote: > On 28/09/18 12:06, Lorenzo Pieralisi wrote: > >[+Murali, Marc] > > > >On Thu, Sep 27, 2018 at 04:44:26PM +0900, Kunihiko Hayashi wrote: > >>Hi Lorenzo, Gustavo, > >> > >>On Wed, 26 Sep

Re: [PATCH v2 2/2] PCI: controller: dwc: add UniPhier PCIe host controller support

2018-10-01 Thread Lorenzo Pieralisi
On Fri, Sep 28, 2018 at 02:17:16PM +0100, Marc Zyngier wrote: > On 28/09/18 12:06, Lorenzo Pieralisi wrote: > >[+Murali, Marc] > > > >On Thu, Sep 27, 2018 at 04:44:26PM +0900, Kunihiko Hayashi wrote: > >>Hi Lorenzo, Gustavo, > >> > >>On Wed, 26 Sep

Re: [PATCH v2 2/2] PCI: controller: dwc: add UniPhier PCIe host controller support

2018-09-28 Thread Lorenzo Pieralisi
On Fri, Sep 28, 2018 at 02:17:16PM +0100, Marc Zyngier wrote: > On 28/09/18 12:06, Lorenzo Pieralisi wrote: > >[+Murali, Marc] > > > >On Thu, Sep 27, 2018 at 04:44:26PM +0900, Kunihiko Hayashi wrote: > >>Hi Lorenzo, Gustavo, > >> > >>On Wed, 26 Sep

Re: [PATCH v2 2/2] PCI: controller: dwc: add UniPhier PCIe host controller support

2018-09-28 Thread Lorenzo Pieralisi
On Fri, Sep 28, 2018 at 02:17:16PM +0100, Marc Zyngier wrote: > On 28/09/18 12:06, Lorenzo Pieralisi wrote: > >[+Murali, Marc] > > > >On Thu, Sep 27, 2018 at 04:44:26PM +0900, Kunihiko Hayashi wrote: > >>Hi Lorenzo, Gustavo, > >> > >>On Wed, 26 Sep

Re: [PATCH v2 2/2] PCI: controller: dwc: add UniPhier PCIe host controller support

2018-09-28 Thread Lorenzo Pieralisi
18:53:01 +0100 > > Gustavo Pimentel wrote: > > > > > On 25/09/2018 17:14, Lorenzo Pieralisi wrote: > > > > [+Gustavo, please have a look at INTX/MSI management] > > > > > > > > On Thu, Sep 06, 2018 at 06:40:32PM +0900, Kunihiko Hayashi wrote: > >

Re: [PATCH v2 2/2] PCI: controller: dwc: add UniPhier PCIe host controller support

2018-09-28 Thread Lorenzo Pieralisi
18:53:01 +0100 > > Gustavo Pimentel wrote: > > > > > On 25/09/2018 17:14, Lorenzo Pieralisi wrote: > > > > [+Gustavo, please have a look at INTX/MSI management] > > > > > > > > On Thu, Sep 06, 2018 at 06:40:32PM +0900, Kunihiko Hayashi wrote: > >

Re: [PATCH v2 2/2] PCI: controller: dwc: add UniPhier PCIe host controller support

2018-09-25 Thread Lorenzo Pieralisi
[+Gustavo, please have a look at INTX/MSI management] On Thu, Sep 06, 2018 at 06:40:32PM +0900, Kunihiko Hayashi wrote: > This introduces specific glue layer for UniPhier platform to support > PCIe host controller that is based on the DesignWare PCIe core, and > this driver supports Root Complex

Re: [PATCH v2 2/2] PCI: controller: dwc: add UniPhier PCIe host controller support

2018-09-25 Thread Lorenzo Pieralisi
[+Gustavo, please have a look at INTX/MSI management] On Thu, Sep 06, 2018 at 06:40:32PM +0900, Kunihiko Hayashi wrote: > This introduces specific glue layer for UniPhier platform to support > PCIe host controller that is based on the DesignWare PCIe core, and > this driver supports Root Complex

Re: [PATCH 1/6] PCI: iproc: Update iProc PCI binding for INTx support

2018-09-25 Thread Lorenzo Pieralisi
On Mon, Sep 24, 2018 at 10:53:13PM +0200, Arnd Bergmann wrote: > On Tue, Sep 18, 2018 at 3:42 PM Lorenzo Pieralisi > wrote: > > > > On Mon, Jun 04, 2018 at 09:17:49AM -0500, Rob Herring wrote: > > > +Arnd > > > > > > On Tue, May 29, 2018 at 4:58 PM,

Re: [PATCH 1/6] PCI: iproc: Update iProc PCI binding for INTx support

2018-09-25 Thread Lorenzo Pieralisi
On Mon, Sep 24, 2018 at 10:53:13PM +0200, Arnd Bergmann wrote: > On Tue, Sep 18, 2018 at 3:42 PM Lorenzo Pieralisi > wrote: > > > > On Mon, Jun 04, 2018 at 09:17:49AM -0500, Rob Herring wrote: > > > +Arnd > > > > > > On Tue, May 29, 2018 at 4:58 PM,

Re: [PATCH v5 0/2] pci-dra7xx: Enable errata i870 workaround for RC mode

2018-09-25 Thread Lorenzo Pieralisi
On Tue, Sep 25, 2018 at 02:00:22PM +0530, Vignesh R wrote: > Make workaround for errata i870 applicable in Host mode as > well(previously it was enabled only for EP mode) as per errata > documentation: http://www.ti.com/lit/er/sprz450/sprz450.pdf > Driver will continue to work with w/o applying

Re: [PATCH v5 0/2] pci-dra7xx: Enable errata i870 workaround for RC mode

2018-09-25 Thread Lorenzo Pieralisi
On Tue, Sep 25, 2018 at 02:00:22PM +0530, Vignesh R wrote: > Make workaround for errata i870 applicable in Host mode as > well(previously it was enabled only for EP mode) as per errata > documentation: http://www.ti.com/lit/er/sprz450/sprz450.pdf > Driver will continue to work with w/o applying

Re: [PATCH] PCI: remove unnecessary check of device_type == pci

2018-09-25 Thread Lorenzo Pieralisi
for finding PCI buses. > > Cc: Will Deacon > Cc: Lorenzo Pieralisi > Cc: Bjorn Helgaas > Cc: Alan Douglas > Cc: Subrahmanya Lingappa > Cc: Michal Simek > Cc: linux-...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Signed-off-by: Rob Herring

Re: [PATCH] PCI: remove unnecessary check of device_type == pci

2018-09-25 Thread Lorenzo Pieralisi
for finding PCI buses. > > Cc: Will Deacon > Cc: Lorenzo Pieralisi > Cc: Bjorn Helgaas > Cc: Alan Douglas > Cc: Subrahmanya Lingappa > Cc: Michal Simek > Cc: linux-...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Signed-off-by: Rob Herring

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-24 Thread Lorenzo Pieralisi
On Mon, Sep 24, 2018 at 04:52:18PM +0200, Thomas Petazzoni wrote: > Hello, > > On Mon, 24 Sep 2018 15:15:12 +0100, Lorenzo Pieralisi wrote: > > > I understand that, I wanted to make sure we come up with a fix asap > > and what I put forward would cover everything

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-24 Thread Lorenzo Pieralisi
On Mon, Sep 24, 2018 at 04:52:18PM +0200, Thomas Petazzoni wrote: > Hello, > > On Mon, 24 Sep 2018 15:15:12 +0100, Lorenzo Pieralisi wrote: > > > I understand that, I wanted to make sure we come up with a fix asap > > and what I put forward would cover everything

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-24 Thread Lorenzo Pieralisi
On Mon, Sep 24, 2018 at 03:10:40PM +0200, Thomas Petazzoni wrote: > Hello, > > On Mon, 24 Sep 2018 13:46:29 +0100, Lorenzo Pieralisi wrote: > > > What I think you can do short term, given that AFAICS MVEBU is not > > removable, instead of using pci_host_probe() y

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-24 Thread Lorenzo Pieralisi
On Mon, Sep 24, 2018 at 03:10:40PM +0200, Thomas Petazzoni wrote: > Hello, > > On Mon, 24 Sep 2018 13:46:29 +0100, Lorenzo Pieralisi wrote: > > > What I think you can do short term, given that AFAICS MVEBU is not > > removable, instead of using pci_host_probe() y

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-24 Thread Lorenzo Pieralisi
On Mon, Sep 24, 2018 at 02:12:03PM +0200, Thomas Petazzoni wrote: [...] > > Trying to address a regression with further development means that > > _that_ development needs thought and review, which is a slower > > process. > > > > I do understand the desire to keep moving forward and never take

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-24 Thread Lorenzo Pieralisi
On Mon, Sep 24, 2018 at 02:12:03PM +0200, Thomas Petazzoni wrote: [...] > > Trying to address a regression with further development means that > > _that_ development needs thought and review, which is a slower > > process. > > > > I do understand the desire to keep moving forward and never take

Re: [PATCH v4 2/4] PCI: mediatek: enable msi after clock enabled

2018-09-21 Thread Lorenzo Pieralisi
On Mon, Sep 10, 2018 at 05:50:21PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > The clocks was not enabled when enable MSI. This patch fix this > issue by calling mtk_pcie_enable_msi in mtk_pcie_startup_port_v2 > since the clock was all enabled at that time. > > The

Re: [PATCH v4 2/4] PCI: mediatek: enable msi after clock enabled

2018-09-21 Thread Lorenzo Pieralisi
On Mon, Sep 10, 2018 at 05:50:21PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > The clocks was not enabled when enable MSI. This patch fix this > issue by calling mtk_pcie_enable_msi in mtk_pcie_startup_port_v2 > since the clock was all enabled at that time. > > The

Re: [PATCH v4 1/4] PCI: mediatek: fixup mtk_pcie_find_port logical

2018-09-21 Thread Lorenzo Pieralisi
On Mon, Sep 10, 2018 at 05:50:20PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > The Mediatek's host controller has two slots, each with it's own control > registers. The host driver need to identify which slot was connected > in order to access the device's configuration

Re: [PATCH v4 1/4] PCI: mediatek: fixup mtk_pcie_find_port logical

2018-09-21 Thread Lorenzo Pieralisi
On Mon, Sep 10, 2018 at 05:50:20PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > The Mediatek's host controller has two slots, each with it's own control > registers. The host driver need to identify which slot was connected > in order to access the device's configuration

Re: [RESEND PATCH v3 2/2] PCI: meson: add the Amlogic Meson PCIe controller driver

2018-09-21 Thread Lorenzo Pieralisi
On Fri, Sep 21, 2018 at 02:03:40PM +0800, Hanjie Lin wrote: > From: Yue Wang > > The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare > PCI core. This patch adds the driver support for Meson PCIe controller. Please read: https://marc.info/?l=linux-pci=150905742808166=2

Re: [RESEND PATCH v3 2/2] PCI: meson: add the Amlogic Meson PCIe controller driver

2018-09-21 Thread Lorenzo Pieralisi
On Fri, Sep 21, 2018 at 02:03:40PM +0800, Hanjie Lin wrote: > From: Yue Wang > > The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare > PCI core. This patch adds the driver support for Meson PCIe controller. Please read: https://marc.info/?l=linux-pci=150905742808166=2

Re: [PATCH] PCI: remove unnecessary check of device_type == pci

2018-09-21 Thread Lorenzo Pieralisi
for finding PCI buses. > > Cc: Will Deacon > Cc: Lorenzo Pieralisi > Cc: Bjorn Helgaas > Cc: Alan Douglas > Cc: Subrahmanya Lingappa > Cc: Michal Simek > Cc: linux-...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Signed-off-by: Rob Herring

Re: [PATCH] PCI: remove unnecessary check of device_type == pci

2018-09-21 Thread Lorenzo Pieralisi
for finding PCI buses. > > Cc: Will Deacon > Cc: Lorenzo Pieralisi > Cc: Bjorn Helgaas > Cc: Alan Douglas > Cc: Subrahmanya Lingappa > Cc: Michal Simek > Cc: linux-...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Signed-off-by: Rob Herring

Re: [PATCH v2] PCI: kirin: Fix section mismatch warning

2018-09-20 Thread Lorenzo Pieralisi
[+Paul] On Wed, Sep 19, 2018 at 02:08:08PM -0700, Nick Desaulniers wrote: > On Wed, Sep 19, 2018 at 11:55 AM Nathan Chancellor > wrote: > > > > WARNING: vmlinux.o(.text+0x4758cc): Section mismatch in reference from > > the function kirin_pcie_probe() to the function > >

Re: [PATCH v2] PCI: kirin: Fix section mismatch warning

2018-09-20 Thread Lorenzo Pieralisi
[+Paul] On Wed, Sep 19, 2018 at 02:08:08PM -0700, Nick Desaulniers wrote: > On Wed, Sep 19, 2018 at 11:55 AM Nathan Chancellor > wrote: > > > > WARNING: vmlinux.o(.text+0x4758cc): Section mismatch in reference from > > the function kirin_pcie_probe() to the function > >

Re: [PATCH] PCI: remove unnecessary check of device_type == pci

2018-09-19 Thread Lorenzo Pieralisi
On Tue, Sep 18, 2018 at 12:05:40PM -0700, Rob Herring wrote: > On Thu, Sep 13, 2018 at 7:51 AM Lorenzo Pieralisi > wrote: > > > > On Wed, Aug 29, 2018 at 01:34:40PM -0500, Rob Herring wrote: > > > PCI host drivers have already matched on compatible strings, so

Re: [PATCH] PCI: remove unnecessary check of device_type == pci

2018-09-19 Thread Lorenzo Pieralisi
On Tue, Sep 18, 2018 at 12:05:40PM -0700, Rob Herring wrote: > On Thu, Sep 13, 2018 at 7:51 AM Lorenzo Pieralisi > wrote: > > > > On Wed, Aug 29, 2018 at 01:34:40PM -0500, Rob Herring wrote: > > > PCI host drivers have already matched on compatible strings, so

Re: [PATCH] PCI: kirin: Fix section mismatch warning

2018-09-19 Thread Lorenzo Pieralisi
Xiaowei, Binghui, On Tue, Sep 18, 2018 at 10:38:29PM -0700, Nathan Chancellor wrote: > WARNING: vmlinux.o(.text+0x4758cc): Section mismatch in reference from > the function kirin_pcie_probe() to the function > .init.text:kirin_add_pcie_port() > The function kirin_pcie_probe() references > the

Re: [PATCH] PCI: kirin: Fix section mismatch warning

2018-09-19 Thread Lorenzo Pieralisi
Xiaowei, Binghui, On Tue, Sep 18, 2018 at 10:38:29PM -0700, Nathan Chancellor wrote: > WARNING: vmlinux.o(.text+0x4758cc): Section mismatch in reference from > the function kirin_pcie_probe() to the function > .init.text:kirin_add_pcie_port() > The function kirin_pcie_probe() references > the

Re: [PATCH] PCI: fix ptr_ret.cocci warnings

2018-09-18 Thread Lorenzo Pieralisi
On Tue, Sep 18, 2018 at 04:47:37PM +0200, Thierry Reding wrote: > On Tue, Sep 18, 2018 at 03:18:38PM +0100, Lorenzo Pieralisi wrote: > > On Thu, Jul 12, 2018 at 07:30:41AM +0800, kbuild test robot wrote: > > > From: kbuild test robot > > > > > > drivers

Re: [PATCH] PCI: fix ptr_ret.cocci warnings

2018-09-18 Thread Lorenzo Pieralisi
On Tue, Sep 18, 2018 at 04:47:37PM +0200, Thierry Reding wrote: > On Tue, Sep 18, 2018 at 03:18:38PM +0100, Lorenzo Pieralisi wrote: > > On Thu, Jul 12, 2018 at 07:30:41AM +0800, kbuild test robot wrote: > > > From: kbuild test robot > > > > > > drivers

Re: [PATCH] PCI: meson: fix ptr_ret.cocci warnings

2018-09-18 Thread Lorenzo Pieralisi
On Tue, Aug 14, 2018 at 07:45:18PM +0800, kbuild test robot wrote: > From: kbuild test robot > > drivers/pci/controller/dwc/pci-meson.c:121:1-3: WARNING: PTR_ERR_OR_ZERO can > be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by:

Re: [PATCH] PCI: meson: fix ptr_ret.cocci warnings

2018-09-18 Thread Lorenzo Pieralisi
On Tue, Aug 14, 2018 at 07:45:18PM +0800, kbuild test robot wrote: > From: kbuild test robot > > drivers/pci/controller/dwc/pci-meson.c:121:1-3: WARNING: PTR_ERR_OR_ZERO can > be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by:

Re: [PATCH] PCI: fix ptr_ret.cocci warnings

2018-09-18 Thread Lorenzo Pieralisi
On Fri, Jul 20, 2018 at 07:42:43AM +0800, kbuild test robot wrote: > From: kbuild test robot > > drivers/pci/controller/dwc/pcie-kirin.c:141:1-3: WARNING: PTR_ERR_OR_ZERO can > be used > drivers/pci/controller/dwc/pcie-kirin.c:177:1-3: WARNING: PTR_ERR_OR_ZERO can > be used > > > Use

Re: [PATCH] PCI: fix ptr_ret.cocci warnings

2018-09-18 Thread Lorenzo Pieralisi
On Fri, Jul 20, 2018 at 07:42:43AM +0800, kbuild test robot wrote: > From: kbuild test robot > > drivers/pci/controller/dwc/pcie-kirin.c:141:1-3: WARNING: PTR_ERR_OR_ZERO can > be used > drivers/pci/controller/dwc/pcie-kirin.c:177:1-3: WARNING: PTR_ERR_OR_ZERO can > be used > > > Use

Re: [PATCH] PCI: fix ptr_ret.cocci warnings

2018-09-18 Thread Lorenzo Pieralisi
On Thu, Jul 12, 2018 at 07:30:41AM +0800, kbuild test robot wrote: > From: kbuild test robot > > drivers/pci/controller/pci-tegra.c:1132:1-3: WARNING: PTR_ERR_OR_ZERO can be > used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by:

Re: [PATCH] PCI: fix ptr_ret.cocci warnings

2018-09-18 Thread Lorenzo Pieralisi
On Thu, Jul 12, 2018 at 07:30:41AM +0800, kbuild test robot wrote: > From: kbuild test robot > > drivers/pci/controller/pci-tegra.c:1132:1-3: WARNING: PTR_ERR_OR_ZERO can be > used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by:

Re: [PATCH 1/6] PCI: iproc: Update iProc PCI binding for INTx support

2018-09-18 Thread Lorenzo Pieralisi
On Mon, Jun 04, 2018 at 09:17:49AM -0500, Rob Herring wrote: > +Arnd > > On Tue, May 29, 2018 at 4:58 PM, Ray Jui wrote: > > Update the iProc PCIe binding document for better modeling of the legacy > > interrupt (INTx) support > > > > Signed-off-by: Ray Jui > > --- > >

Re: [PATCH 1/6] PCI: iproc: Update iProc PCI binding for INTx support

2018-09-18 Thread Lorenzo Pieralisi
On Mon, Jun 04, 2018 at 09:17:49AM -0500, Rob Herring wrote: > +Arnd > > On Tue, May 29, 2018 at 4:58 PM, Ray Jui wrote: > > Update the iProc PCIe binding document for better modeling of the legacy > > interrupt (INTx) support > > > > Signed-off-by: Ray Jui > > --- > >

Re: [PATCH] PCI: mediatek: Fix unchecked return value

2018-09-18 Thread Lorenzo Pieralisi
On Fri, Jul 20, 2018 at 10:01:58AM -0500, Gustavo A. R. Silva wrote: > Check return value of devm_pci_remap_iospace. > > Notice that, currently, all instances of devm_pci_remap_iospace > are being checked. > > Addresses-Coverity-ID: 1471965 ("Unchecked return value") > Signed-off-by: Gustavo A.

Re: [PATCH] PCI: mediatek: Fix unchecked return value

2018-09-18 Thread Lorenzo Pieralisi
On Fri, Jul 20, 2018 at 10:01:58AM -0500, Gustavo A. R. Silva wrote: > Check return value of devm_pci_remap_iospace. > > Notice that, currently, all instances of devm_pci_remap_iospace > are being checked. > > Addresses-Coverity-ID: 1471965 ("Unchecked return value") > Signed-off-by: Gustavo A.

Re: [PATCH v4 2/2] pci: dwc: pci-dra7xx: Enable errata i870 for both EP and RC mode

2018-09-18 Thread Lorenzo Pieralisi
on place. So, that errata workaround is applied for both modes of > operation. > > Reported-by: Chris Welch > Signed-off-by: Vignesh R > Acked-by: Kishon Vijay Abraham I > Acked-by: Lorenzo Pieralisi > --- > drivers/pci/controller/dwc/pci-dra7xx.c | 12 ++-- > 1 fil

Re: [PATCH v4 2/2] pci: dwc: pci-dra7xx: Enable errata i870 for both EP and RC mode

2018-09-18 Thread Lorenzo Pieralisi
on place. So, that errata workaround is applied for both modes of > operation. > > Reported-by: Chris Welch > Signed-off-by: Vignesh R > Acked-by: Kishon Vijay Abraham I > Acked-by: Lorenzo Pieralisi > --- > drivers/pci/controller/dwc/pci-dra7xx.c | 12 ++-- > 1 fil

Re: [PATCH v4 0/6] PCI: imx: Initial imx7d suspend/resume support

2018-09-17 Thread Lorenzo Pieralisi
On Mon, Sep 17, 2018 at 04:01:21PM +, Leonard Crestez wrote: > On Mon, 2018-09-17 at 16:09 +0100, Lorenzo Pieralisi wrote: > > On Tue, Aug 14, 2018 at 07:50:14PM +0300, Leonard Crestez wrote: > > > > V4 adds 4 more patches with PME_Turn_Off support on top, using a n

Re: [PATCH v4 0/6] PCI: imx: Initial imx7d suspend/resume support

2018-09-17 Thread Lorenzo Pieralisi
On Mon, Sep 17, 2018 at 04:01:21PM +, Leonard Crestez wrote: > On Mon, 2018-09-17 at 16:09 +0100, Lorenzo Pieralisi wrote: > > On Tue, Aug 14, 2018 at 07:50:14PM +0300, Leonard Crestez wrote: > > > > V4 adds 4 more patches with PME_Turn_Off support on top, using a n

Re: [PATCH v4 0/6] PCI: imx: Initial imx7d suspend/resume support

2018-09-17 Thread Lorenzo Pieralisi
On Tue, Aug 14, 2018 at 07:50:14PM +0300, Leonard Crestez wrote: > On imx7d the pcie-phy power domain is turned off in suspend and this can > make the system hang on resume when attempting any read from PCI. > > Fix this by adding PM_SLEEP support to the imx6 pci driver. This is > currently only

Re: [PATCH v4 0/6] PCI: imx: Initial imx7d suspend/resume support

2018-09-17 Thread Lorenzo Pieralisi
On Tue, Aug 14, 2018 at 07:50:14PM +0300, Leonard Crestez wrote: > On imx7d the pcie-phy power domain is turned off in suspend and this can > make the system hang on resume when attempting any read from PCI. > > Fix this by adding PM_SLEEP support to the imx6 pci driver. This is > currently only

Re: [PATCH] PCI: iproc: Remove PAXC slot check to allow VF support

2018-09-17 Thread Lorenzo Pieralisi
On Tue, Aug 28, 2018 at 10:22:58AM -0700, Ray Jui wrote: > From: Jitendra Bhivare > > Fix previous incorrect logic that limits PAXC slot number to zero only. > In order for SRIOV/VF to work, we need to allow the slot number to be > greater than zero. > > Fixes: 46560388c476c ("PCI: iproc: Allow

Re: [PATCH] PCI: iproc: Remove PAXC slot check to allow VF support

2018-09-17 Thread Lorenzo Pieralisi
On Tue, Aug 28, 2018 at 10:22:58AM -0700, Ray Jui wrote: > From: Jitendra Bhivare > > Fix previous incorrect logic that limits PAXC slot number to zero only. > In order for SRIOV/VF to work, we need to allow the slot number to be > greater than zero. > > Fixes: 46560388c476c ("PCI: iproc: Allow

Re: [PATCH] ARM: dts: qcom-apq8064: use correct pci address for address translation

2018-09-17 Thread Lorenzo Pieralisi
On Wed, May 09, 2018 at 02:01:34PM +0200, Niklas Cassel wrote: > For PCI, the second and third cell in ranges specifies the upper and > lower target address for address translation. This target address will > be used to program the internal address translation unit (iATU). > > The current device

Re: [PATCH] ARM: dts: qcom-apq8064: use correct pci address for address translation

2018-09-17 Thread Lorenzo Pieralisi
On Wed, May 09, 2018 at 02:01:34PM +0200, Niklas Cassel wrote: > For PCI, the second and third cell in ranges specifies the upper and > lower target address for address translation. This target address will > be used to program the internal address translation unit (iATU). > > The current device

Re: [PATCH v2] PCI: qcom: Fix error handling in pm_runtime support

2018-09-17 Thread Lorenzo Pieralisi
On Fri, Aug 31, 2018 at 03:55:10PM -0700, Bjorn Andersson wrote: > The driver does not cope with the fact that probe can fail in a number > of cases after enabling pm_runtime on the device, this results in > warnings about "Unbalanced pm_runtime_enable". Further more if probe > fails after

Re: [PATCH v2] PCI: qcom: Fix error handling in pm_runtime support

2018-09-17 Thread Lorenzo Pieralisi
On Fri, Aug 31, 2018 at 03:55:10PM -0700, Bjorn Andersson wrote: > The driver does not cope with the fact that probe can fail in a number > of cases after enabling pm_runtime on the device, this results in > warnings about "Unbalanced pm_runtime_enable". Further more if probe > fails after

Re: [RESEND] PCI: imx: Initial imx7d pm support

2018-09-17 Thread Lorenzo Pieralisi
On Mon, Aug 27, 2018 at 02:28:37PM +0300, Leonard Crestez wrote: > On imx7d the pcie-phy power domain is turned off in suspend and this can > make the system hang after resume when attempting any read from PCI. > > Fix this by adding minimal suspend/resume code from the nxp internal > tree. This

Re: [RESEND] PCI: imx: Initial imx7d pm support

2018-09-17 Thread Lorenzo Pieralisi
On Mon, Aug 27, 2018 at 02:28:37PM +0300, Leonard Crestez wrote: > On imx7d the pcie-phy power domain is turned off in suspend and this can > make the system hang after resume when attempting any read from PCI. > > Fix this by adding minimal suspend/resume code from the nxp internal > tree. This

Re: [PATCH v3 0/4] pci-dra7xx: Enable errata i870 workaround for RC mode

2018-09-17 Thread Lorenzo Pieralisi
On Fri, Sep 07, 2018 at 10:00:09AM -0700, Tony Lindgren wrote: > * Vignesh R [180810 10:10]: > > > > > > On Wednesday 08 August 2018 10:27 PM, Lorenzo Pieralisi wrote: > > > On Tue, Jul 24, 2018 at 11:01:46PM +0530, Vignesh R wrote: > > >> Make workarou

Re: [PATCH v3 0/4] pci-dra7xx: Enable errata i870 workaround for RC mode

2018-09-17 Thread Lorenzo Pieralisi
On Fri, Sep 07, 2018 at 10:00:09AM -0700, Tony Lindgren wrote: > * Vignesh R [180810 10:10]: > > > > > > On Wednesday 08 August 2018 10:27 PM, Lorenzo Pieralisi wrote: > > > On Tue, Jul 24, 2018 at 11:01:46PM +0530, Vignesh R wrote: > > >> Make workarou

Re: [PATCH v8 07/26] PM / Domains: Add genpd governor for CPUs

2018-09-14 Thread Lorenzo Pieralisi
On Fri, Sep 14, 2018 at 01:34:14PM +0200, Rafael J. Wysocki wrote: [...] > > > So for example, if your logical CPU has an idle state A that may trigger > > > an > > > idle state X at the cluster level (if the other logical CPUs happen to be > > > in > > > the right states and so on), then the

Re: [PATCH v8 07/26] PM / Domains: Add genpd governor for CPUs

2018-09-14 Thread Lorenzo Pieralisi
On Fri, Sep 14, 2018 at 01:34:14PM +0200, Rafael J. Wysocki wrote: [...] > > > So for example, if your logical CPU has an idle state A that may trigger > > > an > > > idle state X at the cluster level (if the other logical CPUs happen to be > > > in > > > the right states and so on), then the

Re: [PATCH v8 07/26] PM / Domains: Add genpd governor for CPUs

2018-09-14 Thread Lorenzo Pieralisi
On Fri, Sep 14, 2018 at 11:50:15AM +0200, Rafael J. Wysocki wrote: > On Thursday, August 9, 2018 5:39:25 PM CEST Lorenzo Pieralisi wrote: > > On Mon, Aug 06, 2018 at 11:20:59AM +0200, Rafael J. Wysocki wrote: > > > > [...] > > > > > >>> > @@ -245,

Re: [PATCH v8 07/26] PM / Domains: Add genpd governor for CPUs

2018-09-14 Thread Lorenzo Pieralisi
On Fri, Sep 14, 2018 at 11:50:15AM +0200, Rafael J. Wysocki wrote: > On Thursday, August 9, 2018 5:39:25 PM CEST Lorenzo Pieralisi wrote: > > On Mon, Aug 06, 2018 at 11:20:59AM +0200, Rafael J. Wysocki wrote: > > > > [...] > > > > > >>> > @@ -245,

Re: [PATCH v8 07/26] PM / Domains: Add genpd governor for CPUs

2018-09-13 Thread Lorenzo Pieralisi
On Thu, Aug 30, 2018 at 03:36:02PM +0200, Ulf Hansson wrote: > On 24 August 2018 at 12:38, Lorenzo Pieralisi > wrote: > > On Fri, Aug 24, 2018 at 11:26:19AM +0200, Ulf Hansson wrote: > > > > [...] > > > >> > That's a good question an

Re: [PATCH v8 07/26] PM / Domains: Add genpd governor for CPUs

2018-09-13 Thread Lorenzo Pieralisi
On Thu, Aug 30, 2018 at 03:36:02PM +0200, Ulf Hansson wrote: > On 24 August 2018 at 12:38, Lorenzo Pieralisi > wrote: > > On Fri, Aug 24, 2018 at 11:26:19AM +0200, Ulf Hansson wrote: > > > > [...] > > > >> > That's a good question an

<    4   5   6   7   8   9   10   11   12   13   >