RE: [EXT] [PATCH] scsi: qedi: emove redundant assignment to variable err

2021-03-30 Thread Manish Rangankar
> -Original Message- > From: Colin King > Sent: Sunday, March 28, 2021 4:37 AM > To: Nilesh Javali ; Manish Rangankar > ; GR-QLogic-Storage-Upstream storage-upstr...@marvell.com>; James E . J . Bottomley > ; Martin K . Petersen ; > linux-s...@vger.kerne

RE: [EXT] [PATCH] scsi: qedi: fix error return code of qedi_alloc_global_queues()

2021-03-22 Thread Manish Rangankar
> -Original Message- > From: Jia-Ju Bai > Sent: Monday, March 8, 2021 9:00 AM > To: Nilesh Javali ; Manish Rangankar > ; j...@linux.ibm.com; > martin.peter...@oracle.com > Cc: GR-QLogic-Storage-Upstream upstr...@marvell.com>; linux-s...@vger.kernel.org; linux-

RE: [PATCH] scsi: qedi: add printf attribute to log function

2020-12-27 Thread Manish Rangankar
> -Original Message- > From: t...@redhat.com > Sent: Monday, December 21, 2020 9:54 PM > To: Nilesh Javali ; Manish Rangankar > ; j...@linux.ibm.com; > martin.peter...@oracle.com > Cc: GR-QLogic-Storage-Upstream upstr...@marvell.com>; linux-s...@vger.

RE: [EXT] [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()

2020-09-16 Thread Manish Rangankar
> -Original Message- > From: Qinglang Miao > Sent: Wednesday, September 16, 2020 11:52 AM > To: Nilesh Javali ; Manish Rangankar > ; GR-QLogic-Storage-Upstream storage-upstr...@marvell.com>; James E.J. Bottomley > ; Martin K. Petersen > Cc: linux-s...@vger.

RE: [EXT] [PATCH] scsi: qedi: remove Comparison of 0/1 to bool variable

2020-05-05 Thread Manish Rangankar
> -Original Message- > From: Jason Yan > Sent: Thursday, April 30, 2020 5:47 PM > To: qlogic-storage-upstr...@cavium.com; j...@linux.ibm.com; > martin.peter...@oracle.com; Manish Rangankar > ; linux-s...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: Ja

RE: [PATCH] scsi: qla4xxx: fix a potential NULL pointer dereference

2019-03-25 Thread Manish Rangankar
return -EINVAL; > conn = cls_conn->dd_data; > qla_conn = conn->dd_data; > qla_conn->qla_ep = ep->dd_data; > -- > 2.17.1 Thanks Acked-by: Manish Rangankar

RE: [PATCH 6/7] scsi: qlogic: no need to check return value of debugfs_create functions

2019-01-22 Thread Manish Rangankar
debugfs_remove_recursive(qedi->bdf_dentry); > - return; > - } > + debugfs_create_file(dops->name, 0600, qedi->bdf_dentry, qedi, > + fops); > dops++; > fops++; > } > @@ -60,8 +49,6 @@ void > qedi_dbg_init(char *drv_name) > { > qedi_dbg_root = debugfs_create_dir(drv_name, NULL); > - if (!qedi_dbg_root) > - QEDI_INFO(NULL, QEDI_LOG_DEBUGFS, "Init of debugfs failed\n"); > } > > void > -- > 2.20.1 Thanks Acked-by: Manish Rangankar

RE: [EXT] [PATCH] scsi: bnx2i: fix indentation issue, remove a tab

2019-01-07 Thread Manish Rangankar
> hba->dummy_buffer = NULL; > } > - return; > + return; > } > > /** > -- > 2.19.1 Thanks Acked-by: Manish Rangankar

RE: [EXT] [PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param

2018-12-24 Thread Manish Rangankar
f (rc) > + goto free_sess; > > ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n", >__func__, fnode_sess->dev.kobj.name); > -- > 2.7.0 > Thanks Acked-by: Manish Rangankar