Re: [PATCH v2] lzo: fix ip overrun during compress.

2018-12-16 Thread Markus F.X.J. Oberhumer
t; >> On Wed, Dec 12, 2018 at 1:37 PM Markus F.X.J. Oberhumer >> wrote: >>> >>> I still claim that (0xf000, 4096) is not a valid C "pointer >>> to an object" according to the C standard - please see my reply below. >>> >&

Re: [PATCH v2] lzo: fix ip overrun during compress.

2018-12-12 Thread Markus F.X.J. Oberhumer
s. Cheers, Markus On 2018-12-12 06:21, Yueyi Li wrote: > Hi Markus, > > OK, thanks. I`ll change it in v3. > > Thanks, > Yueyi > > On 2018/12/6 23:03, Markus F.X.J. Oberhumer wrote: >> Hi Yueyi, >> >> yes, my LZO patch works for all cases. >> &g

Re: [PATCH 6/8] lib/lzo: implement run-length encoding

2018-12-06 Thread Markus F.X.J. Oberhumer
63-7-dave.rodg...@arm.com > Signed-off-by: Dave Rodgman > Cc: David S. Miller > Cc: Greg Kroah-Hartman > Cc: Herbert Xu > Cc: Markus F.X.J. Oberhumer > Cc: Matt Sealey > Cc: Minchan Kim > Cc: Nitin Gupta > Cc: Richard Purdie > Cc: Sergey Senozhatsky >

Re: [PATCH 2/8] lib/lzo: clean-up by introducing COPY16

2018-12-06 Thread Markus F.X.J. Oberhumer
iteback or simply positively incrementing offsets which > seems to positively affect performance. It is, at least, fewer > instructions to do the same job. > > Link: http://lkml.kernel.org/r/20181127161913.23863-3-dave.rodg...@arm.com > Signed-off-by: Matt Sealey > Signed-off-by:

Re: [PATCH 5/8] lib/lzo: fast 8-byte copy on arm64

2018-12-06 Thread Markus F.X.J. Oberhumer
Acked-by: Markus F.X.J. Oberhumer On 2018-11-30 15:26, Dave Rodgman wrote: > From: Matt Sealey > > Enable faster 8-byte copies on arm64. > > Link: http://lkml.kernel.org/r/20181127161913.23863-6-dave.rodg...@arm.com > Signed-off-by: Matt Sealey > Signed-off-by: Dave R

Re: [PATCH 4/8] lib/lzo: 64-bit CTZ on arm64

2018-12-06 Thread Markus F.X.J. Oberhumer
Acked-by: Markus F.X.J. Oberhumer On 2018-11-30 15:26, Dave Rodgman wrote: > From: Matt Sealey > > LZO leaves some performance on the table by not realising that arm64 can > optimize count-trailing-zeros bit operations. > > Add CONFIG_ARM64 to the checked definitions along

Re: [PATCH 3/8] lib/lzo: enable 64-bit CTZ on Arm

2018-12-06 Thread Markus F.X.J. Oberhumer
thing as the LZO_USE_CTZ32 code, only with more > register pressure. > > Link: http://lkml.kernel.org/r/20181127161913.23863-4-dave.rodg...@arm.com > Signed-off-by: Matt Sealey > Signed-off-by: Dave Rodgman > Cc: David S. Miller > Cc: Greg Kroah-Hartman > Cc: Herbert Xu

Re: [PATCH 1/8] lib/lzo: tidy-up ifdefs

2018-12-06 Thread Markus F.X.J. Oberhumer
Acked-by: Markus F.X.J. Oberhumer On 2018-11-30 15:26, Dave Rodgman wrote: > Modify the ifdefs in lzodefs.h to be more consistent with normal kernel > macros (e.g., change __aarch64__ to CONFIG_ARM64). > > Signed-off-by: Dave Rodgman > Cc: Herbert Xu > Cc: David S. Miller

Re: [PATCH v4 0/7] lib/lzo: performance improvements

2018-12-06 Thread Markus F.X.J. Oberhumer
On 2018-11-30 15:26, Dave Rodgman wrote: > This patch series introduces performance improvements for lzo. > > The previous version of this patchset is here: > https://lkml.org/lkml/2018/11/30/807 > > This version of the patchset fixes a maybe-used-uninitialized warning > (although the previous ve

Re: [PATCH v2] lzo: fix ip overrun during compress.

2018-12-06 Thread Markus F.X.J. Oberhumer
= 0; } Valid code like this will fail horribly when (p, len) is the very last virtual page (because end will be the NULL pointer in this case). Cheers, Markus On 2018-12-05 04:07, Yueyi Li wrote: > Hi Markus, > > Thanks for your review. > > On 2018/12/4 18:20, Markus F.X.J

Re: [PATCH v2] lzo: fix ip overrun during compress.

2018-12-04 Thread Markus F.X.J. Oberhumer
Hi, I don't think that address space wraparound is legal in C, but I understand that we are in kernel land and if you really want to compress the last virtual page 0xf000 the following small patch should fix that dubious case. This also avoids slowing down the the hot path of the comp

Re: [PATCH 2/6] lib/lzo: enable 64-bit CTZ on Arm

2018-11-21 Thread Markus F.X.J. Oberhumer
On 2018-11-21 18:31, Christoph Hellwig wrote: >> #define LZO_USE_CTZ32 1 >> #elif defined(__i386__) || defined(__powerpc__) >> #define LZO_USE_CTZ32 1 >> -#elif defined(__arm__) && (__LINUX_ARM_ARCH__ >= 5) >> +#elif defined(__arm__) >> +#if (__LINUX_ARM_ARCH__ >= 5) >> #define LZO_

Re: [PATCH 0/6] lib/lzo: performance improvements

2018-11-21 Thread Markus F.X.J. Oberhumer
Hi Dave, thanks for your patch set. Just some initial comments: I think the three patches [PATCH 2/6] lib/lzo: enable 64-bit CTZ on Arm [PATCH 3/6] lib/lzo: 64-bit CTZ on Arm aarch64 [PATCH 4/6] lib/lzo: fast 8-byte copy on arm64 should be applied in any case - could you please make an e

Re: [RFC PATCH v2 0/4] Add support for LZ4-compressed kernel

2013-02-26 Thread Markus F.X.J. Oberhumer
mpress_unlz4.c > create mode 100644 lib/lz4/Makefile > create mode 100644 lib/lz4/lz4_decompress.c > create mode 100644 lib/lz4/lz4defs.h > -- Markus Oberhumer, , http://www.oberhumer.com/ commit 8745b927fcfcd6953ada9bd1220a73083db5948a Author: Markus F.X.J. Oberhumer Date: Mon

Re: [GIT PULL] Update LZO compression code for v3.9

2013-02-26 Thread Markus F.X.J. Oberhumer
On 2013-02-26 18:28, Linus Torvalds wrote: > On Thu, Feb 21, 2013 at 9:26 PM, Markus F.X.J. Oberhumer > wrote: >> >> please pull my "lzo-update" branch from >> >> git://github.com/markus-oberhumer/linux.git lzo-update > > I *really* want github (

[PATCH] PM: align buffers for LZO compression

2013-02-21 Thread Markus F.X.J. Oberhumer
essed buffer */ + unsigned char unc[LZO_UNC_SIZE] cacheline_aligned; /* uncompressed buffer */ + unsigned char cmp[LZO_CMP_SIZE] cacheline_aligned; /* compressed buffer */ }; /** Signed-off-by: Markus F.X.J. Oberhumer -- Markus Oberhumer, , http://www.oberhume

[GIT PULL] Update LZO compression code for v3.9

2013-02-21 Thread Markus F.X.J. Oberhumer
m version which features significant performance improvements on modern machines. $ git shortlog v3.8..lzo-update Markus F.X.J. Oberhumer (3): lib/lzo: Rename lzo1x_decompress.c to lzo1x_decompress_safe.c lib/lzo: Update LZO compression to current upstream version crypto: testm

Re: [RFC PATCH 0/4] Add support for LZ4-compressed kernels

2013-02-03 Thread Markus F.X.J. Oberhumer
On 2013-02-01 08:00, kyungsik.lee wrote: > On 2013-01-30 오전 6:09, Rajesh Pawar wrote: >>> Andrew Morton wrote: >>> >>> On Sat, 26 Jan 2013 14:50:43 +0900 >>> Kyungsik Lee wrote: [...] >>> What's this "with enabled unaligned memory access" thing? You mean "if >>> the arch supports CONFIG

Re: [RFC PATCH 0/4] Add support for LZ4-compressed kernels

2013-02-03 Thread Markus F.X.J. Oberhumer
sec 117 MB/sec LZO-2013-UA : 47 MB/sec 167 MB/sec Legend: LZO-2005: LZO version in current 3.8 rc6 kernel (which is based on the LZO 2.02 release from 2005) LZO-2012: updated LZO version available in linux-next LZO-2013-UA : updated

Re: [PATCH 0/3] Update LZO compression

2012-10-15 Thread Markus F.X.J. Oberhumer
On 2012-10-15 21:19, Seth Jennings wrote: >> As requested by akpm I am sending my "lzo-update" branch at >> >> git://github.com/markus-oberhumer/linux.git lzo-update >> >> to lkml as a patch series created by "git format-patch -M v3.5..lzo-update". >> >> You can also browse the branch at >> >>

Re: [PATCH] lib: decompress_unlzo: Change include file name

2012-10-15 Thread Markus F.X.J. Oberhumer
Thanks Fabio, that should already be fixed on the "lzo-update" branch at git://github.com/markus-oberhumer/linux.git lzo-update Cheers, Markus On 2012-10-14 20:13, Fabio Estevam wrote: > From: Fabio Estevam > > Commit 7c979cebc (lib/lzo: Rename lzo1x_decompress.c to > lzo1x_decompress_safe

Re: [PATCH 0/3] Update LZO compression

2012-10-11 Thread Markus F.X.J. Oberhumer
Thanks Arnd, On 2012-10-11 13:41, Arnd Bergmann wrote: > On Tuesday 09 October 2012, Markus F.X.J. Oberhumer wrote: >>> >>> : This commit updates the kernel LZO code to the current upsteam version >>> : which features a significant speed improvement - benchmarking

Re: [PATCH 0/3] Update LZO compression

2012-10-09 Thread Markus F.X.J. Oberhumer
Hi Stephen, On 2012-10-09 21:26, Andrew Morton wrote: > On Sun, 7 Oct 2012 17:07:55 +0200 > "Markus F.X.J. Oberhumer" wrote: > >> As requested by akpm I am sending my "lzo-update" branch at >> >> git://github.com/markus-oberhumer/linux.git lzo-up

[PATCH 3/3] lib/lzo: Optimize code for CPUs with inefficient unaligned access

2012-10-07 Thread Markus F.X.J. Oberhumer
Some code paths are only benefical on machines with fast unaligned loads, so only use these if CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS defined. Signed-off-by: Markus F.X.J. Oberhumer --- lib/lzo/lzo1x_compress.c|4 ++-- lib/lzo/lzo1x_decompress_safe.c | 15 --- lib/lzo

[PATCH 2/3] lib/lzo: Update LZO compression to current upstream version

2012-10-07 Thread Markus F.X.J. Oberhumer
-by: Markus F.X.J. Oberhumer --- include/linux/lzo.h | 15 +- lib/lzo/lzo1x_compress.c| 309 +++ lib/lzo/lzo1x_decompress_safe.c | 341 ++- lib/lzo/lzodefs.h | 34 +++- 4 files changed, 360

[PATCH 1/3] lib/lzo: Rename lzo1x_decompress.c to lzo1x_decompress_safe.c

2012-10-07 Thread Markus F.X.J. Oberhumer
Rename the source file to match the function name and thereby also make room for a possible future even slightly faster "non-safe" decompressor version. Signed-off-by: Markus F.X.J. Oberhumer --- lib/lzo/Makefile |2 +- ...{lzo1x_de

[PATCH 0/3] Update LZO compression

2012-10-07 Thread Markus F.X.J. Oberhumer
erhumer/linux/commit/5f702781f158cb59075cfa97e5c21f52275057f1 Share and enjoy, Markus Markus F.X.J. Oberhumer (3): lib/lzo: Rename lzo1x_decompress.c to lzo1x_decompress_safe.c lib/lzo: Update LZO compression to current upstream version lib/lzo: Optimize code for CPUs with inefficient unaligned access include/linux/lzo.

Re: [GIT PULL v2] Update LZO compression

2012-10-03 Thread Markus F.X.J. Oberhumer
Hi all, is there some official maintainer who feels responsible for pushing the LZO update to Linus? Otherwise I also could issue a pull-request on github, but somehow I don't think that this is the preferred workflow. Cheers, Markus On 2012-08-21 17:21, Markus F.X.J. Oberhumer wrote: >

[GIT PULL v2] Update LZO compression

2012-08-21 Thread Markus F.X.J. Oberhumer
#x27;d ask some official kernel maintainer for review and to push this into linux-next so that it will hopefully land in the 3.7 release. Share and enjoy, Markus Signed-off-by: Markus F.X.J. Oberhumer [ Changes in v2: Optimize code for CPUs with inefficient unaligned access => significant

Re: [GIT PULL] Update LZO compression

2012-08-15 Thread Markus F.X.J. Oberhumer
On 2012-08-15 16:45, Johannes Stezenbach wrote: > On Wed, Aug 15, 2012 at 02:02:43PM +0200, Markus F.X.J. Oberhumer wrote: >> On 2012-08-14 14:39, Johannes Stezenbach wrote: >>> On Tue, Aug 14, 2012 at 01:44:02AM +0200, Markus F.X.J. Oberhumer wrote: >>>> On

Re: [GIT PULL] Update LZO compression

2012-08-15 Thread Markus F.X.J. Oberhumer
Hi Johannes, On 2012-08-14 14:39, Johannes Stezenbach wrote: > On Tue, Aug 14, 2012 at 01:44:02AM +0200, Markus F.X.J. Oberhumer wrote: >> On 2012-07-16 20:30, Markus F.X.J. Oberhumer wrote: >>> >>> As stated in the README this version is significantly faster (typi

Re: [GIT PULL] Update LZO compression

2012-08-14 Thread Markus F.X.J. Oberhumer
On 2012-08-14 05:15, Andi Kleen wrote: > On Tue, Aug 14, 2012 at 01:44:02AM +0200, Markus F.X.J. Oberhumer wrote: >> Hi all, >> >> as suggested on the mailing list I have converted the updated LZO >> code into git, so please pull my "lzo-update" branch

[GIT PULL] Update LZO compression

2012-08-13 Thread Markus F.X.J. Oberhumer
#x27;d ask some official kernel maintainer for review and to push this into linux-next so that it will hopefully land in the 3.7 release. Share and enjoy, Markus Signed-off-by: Markus F.X.J. Oberhumer On 2012-07-16 20:30, Markus F.X.J. Oberhumer wrote: > Hi all, > > I finally have prepa