Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-29 Thread Mathias Nyman
On 08/28/2014 06:09 PM, Ricardo Ribalda Delgado wrote: Sure, but the hw leaves my desk until next monday in 30 minutes. So unless you send the patch right now you will have to wait for results until next Monday Thanks! Great, anytime you can test it is appreciated. Added the patch to

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-28 Thread Mathias Nyman
On 08/28/2014 03:36 PM, Ricardo Ribalda Delgado wrote: > Hello Mathias > > This is the dmesg output after your patch. No WARN(), no crash :), but > still some weird messages: > > [ 146.511623] usb 2-2: new SuperSpeed USB device number 2 using xhci_hcd > [ 146.531652] usb 2-2: New USB device

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-28 Thread Mathias Nyman
On 08/27/2014 07:10 PM, Ricardo Ribalda Delgado wrote: > Perhaps we could apply both patches to current tree and backport mine > to older kernels? > The already applied patch fixes many other issues than just this one. backporting it to stable < 3.13 turned out to not be that difficult, stable

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-28 Thread Mathias Nyman
On 08/27/2014 07:10 PM, Ricardo Ribalda Delgado wrote: Perhaps we could apply both patches to current tree and backport mine to older kernels? The already applied patch fixes many other issues than just this one. backporting it to stable 3.13 turned out to not be that difficult, stable

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-28 Thread Mathias Nyman
On 08/28/2014 03:36 PM, Ricardo Ribalda Delgado wrote: Hello Mathias This is the dmesg output after your patch. No WARN(), no crash :), but still some weird messages: [ 146.511623] usb 2-2: new SuperSpeed USB device number 2 using xhci_hcd [ 146.531652] usb 2-2: New USB device found,

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-27 Thread Mathias Nyman
On 08/27/2014 05:14 PM, Ricardo Ribalda Delgado wrote: > At least I have seen the issue on Debian 3.14 and 3.16. Is your patch > going to be backported to linux-stable? The computer crashes very very > badly > Yes, it is, but it might need some additional work as it won't apply cleanly on older

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-27 Thread Mathias Nyman
On 08/26/2014 06:47 PM, Ricardo Ribalda Delgado wrote: > While testing a usb gadget I managed to crash completely the host > computer. This was due to a NULL pointer derefence. > > This patch avoids the crash although the kernel still outputs some > warnings. > > Without this patch, kernels from

Re: [PATCH 3/3] xhci: rework cycle bit checking for new dequeue pointers

2014-08-27 Thread Mathias Nyman
On 08/21/2014 01:06 AM, Joseph Salisbury wrote: > On 08/19/2014 08:17 AM, Mathias Nyman wrote: >> When we manually need to move the TR dequeue pointer we need to set the >> correct cycle bit as well. Previously we used the trb pointer from the >> last event received as a base,

Re: [PATCH 3/3] xhci: rework cycle bit checking for new dequeue pointers

2014-08-27 Thread Mathias Nyman
On 08/21/2014 01:06 AM, Joseph Salisbury wrote: On 08/19/2014 08:17 AM, Mathias Nyman wrote: When we manually need to move the TR dequeue pointer we need to set the correct cycle bit as well. Previously we used the trb pointer from the last event received as a base, but this was changed

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-27 Thread Mathias Nyman
On 08/26/2014 06:47 PM, Ricardo Ribalda Delgado wrote: While testing a usb gadget I managed to crash completely the host computer. This was due to a NULL pointer derefence. This patch avoids the crash although the kernel still outputs some warnings. Without this patch, kernels from (at

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-27 Thread Mathias Nyman
On 08/27/2014 05:14 PM, Ricardo Ribalda Delgado wrote: At least I have seen the issue on Debian 3.14 and 3.16. Is your patch going to be backported to linux-stable? The computer crashes very very badly Yes, it is, but it might need some additional work as it won't apply cleanly on older

[PATCHv2] gpio-lynxpoint: enable input sensing in resume

2014-08-19 Thread Mathias Nyman
It appears that input sensing bit might be reset during suspend/resume. Set input sensing again for all requested gpios in resume Tested-by: Jerome Blin Signed-off-by: Mathias Nyman --- drivers/gpio/gpio-lynxpoint.c | 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [PATCH] gpio-lynxpoint: enable input sensing in resume

2014-08-19 Thread Mathias Nyman
On 08/19/2014 01:22 PM, Mika Westerberg wrote: > On Tue, Aug 19, 2014 at 01:30:28PM +0300, Mathias Nyman wrote: >> It appears that input sensing bit might be reset during >> suspend/resume. Set input sensing again for all requested gpios >> in resume >> >> Test

[PATCH] gpio-lynxpoint: enable input sensing in resume

2014-08-19 Thread Mathias Nyman
It appears that input sensing bit might be reset during suspend/resume. Set input sensing again for all requested gpios in resume Tested-by: Jerome Blin Signed-off-by: Mathias Nyman --- drivers/gpio/gpio-lynxpoint.c | 24 1 file changed, 24 insertions(+) diff --git

[PATCH] gpio-lynxpoint: enable input sensing in resume

2014-08-19 Thread Mathias Nyman
It appears that input sensing bit might be reset during suspend/resume. Set input sensing again for all requested gpios in resume Tested-by: Jerome Blin jerome.b...@intel.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/gpio/gpio-lynxpoint.c | 24

Re: [PATCH] gpio-lynxpoint: enable input sensing in resume

2014-08-19 Thread Mathias Nyman
On 08/19/2014 01:22 PM, Mika Westerberg wrote: On Tue, Aug 19, 2014 at 01:30:28PM +0300, Mathias Nyman wrote: It appears that input sensing bit might be reset during suspend/resume. Set input sensing again for all requested gpios in resume Tested-by: Jerome Blin jerome.b...@intel.com Signed

[PATCHv2] gpio-lynxpoint: enable input sensing in resume

2014-08-19 Thread Mathias Nyman
It appears that input sensing bit might be reset during suspend/resume. Set input sensing again for all requested gpios in resume Tested-by: Jerome Blin jerome.b...@intel.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/gpio/gpio-lynxpoint.c | 18 ++ 1

[PATCH] pinctrl: baytrail: resolve unbalanced IRQ wake disable warning

2014-08-11 Thread Mathias Nyman
Add the IRQCHIP_SKIP_SET_WAKE flag to baytrail gpio irq_chip to resolve unbalaced IRQ wake disable warnings. Suggested-by: Borun Fu Signed-off-by: Mathias Nyman --- drivers/pinctrl/pinctrl-baytrail.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-baytrail.c b

[PATCH] pinctrl: baytrail: resolve unbalanced IRQ wake disable warning

2014-08-11 Thread Mathias Nyman
Add the IRQCHIP_SKIP_SET_WAKE flag to baytrail gpio irq_chip to resolve unbalaced IRQ wake disable warnings. Suggested-by: Borun Fu borun...@intel.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/pinctrl/pinctrl-baytrail.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] usb: xhci: Fix Set TR Dequeue Pointer cycle state for quirky xHCs

2014-07-24 Thread Mathias Nyman
On 07/17/2014 10:50 PM, Julius Werner wrote: >> Hmm. Wouldn't it be safer to have a quirk for this, and only enable >> the workaround if the Asmedia controller is detected? This code is so >> complicated that it is difficult to see whether this could have a >> harmful effect on controllers without

Re: [PATCH 06/10 linux-next] xhci: remove unnecessary break after return

2014-07-24 Thread Mathias Nyman
On 07/24/2014 11:18 AM, Fabian Frederick wrote: > Signed-off-by: Fabian Frederick > --- Acked-by: Mathias Nyman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http:/

Re: [PATCH 06/10 linux-next] xhci: remove unnecessary break after return

2014-07-24 Thread Mathias Nyman
On 07/24/2014 11:18 AM, Fabian Frederick wrote: Signed-off-by: Fabian Frederick f...@skynet.be --- Acked-by: Mathias Nyman mathias.ny...@linux.intel.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] usb: xhci: Fix Set TR Dequeue Pointer cycle state for quirky xHCs

2014-07-24 Thread Mathias Nyman
On 07/17/2014 10:50 PM, Julius Werner wrote: Hmm. Wouldn't it be safer to have a quirk for this, and only enable the workaround if the Asmedia controller is detected? This code is so complicated that it is difficult to see whether this could have a harmful effect on controllers without the

Re: [PATCH 3/5] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-06-24 Thread Mathias Nyman
On 06/24/2014 05:10 PM, Greg KH wrote: > On Tue, Jun 24, 2014 at 05:14:42PM +0300, Mathias Nyman wrote: >> From: Julius Werner >> >> The current XHCI driver recalculates the Context Entries field in the >> Slot Context on every add_endpoint() and drop_endp

[PATCH 5/5] xhci: Fix runtime suspended xhci from blocking system suspend.

2014-06-24 Thread Mathias Nyman
Acked-by: Alan Stern [use readl() instead of removed xhci_readl(), reword commit message -Mathias] Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c ind

[PATCH 4/5] xhci: clear root port wake on bits if controller isn't wake-up capable

2014-06-24 Thread Mathias Nyman
as 2.6.37, that contains the commit 9777e3ce907d4cb5a513902a87ecd03b52499569 "USB: xHCI: bus power management implementation". Cc: sta...@vger.kernel.org # 2.6.37 Signed-off-by: Lu Baolu Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-hub.c | 5 - 1 file changed, 4 insert

[PATCH 3/5] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-06-24 Thread Mathias Nyman
-off-by: Julius Werner Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.c | 51 + 1 file changed, 18 insertions(+), 33 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 2b8d9a2..013aabb 100644 --- a/drivers/usb

[PATCH 1/5] xhci: Use correct SLOT ID when handling a reset device command

2014-06-24 Thread Mathias Nyman
3 Reported-by: Saran Neti Tested-by: Saran Neti Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index d67ff71..71657d3 100644 --- a/drivers/usb

[PATCH 2/5] xhci: correct burst count field for isoc transfers on 1.0 xhci hosts

2014-06-24 Thread Mathias Nyman
Descriptor Packet Count / Max Burst Size +1 ) - 1 This patch should be applied to stable kernels since 3.0 that contain the commit 5cd43e33b9519143f06f507dd7cbee6b7a621885 "xhci 1.0: Set transfer burst count field." Cc: sta...@vger.kernel.org # 3.0 Suggested-by: ShiChun Ma Signed-off-b

[PATCH 0/5] xhci fixes for 3.16-rc usb-linus

2014-06-24 Thread Mathias Nyman
dpoint Lu Baolu (1): xhci: clear root port wake on bits if controller isn't wake-up capable Mathias Nyman (2): xhci: Use correct SLOT ID when handling a reset device command xhci: correct burst count field for isoc transfers on 1.0 xhci hosts Wang, Yu (1): xhci: Fix runtime suspended

[PATCH 0/5] xhci fixes for 3.16-rc usb-linus

2014-06-24 Thread Mathias Nyman
Baolu (1): xhci: clear root port wake on bits if controller isn't wake-up capable Mathias Nyman (2): xhci: Use correct SLOT ID when handling a reset device command xhci: correct burst count field for isoc transfers on 1.0 xhci hosts Wang, Yu (1): xhci: Fix runtime suspended xhci from blocking

[PATCH 2/5] xhci: correct burst count field for isoc transfers on 1.0 xhci hosts

2014-06-24 Thread Mathias Nyman
-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 71657d3..749fc68 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci

[PATCH 1/5] xhci: Use correct SLOT ID when handling a reset device command

2014-06-24 Thread Mathias Nyman
-by: Saran Neti saran...@gmail.com Tested-by: Saran Neti saran...@gmail.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-ring.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci

[PATCH 4/5] xhci: clear root port wake on bits if controller isn't wake-up capable

2014-06-24 Thread Mathias Nyman
to kernels as old as 2.6.37, that contains the commit 9777e3ce907d4cb5a513902a87ecd03b52499569 USB: xHCI: bus power management implementation. Cc: sta...@vger.kernel.org # 2.6.37 Signed-off-by: Lu Baolu baolu...@linux.intel.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com

[PATCH 3/5] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-06-24 Thread Mathias Nyman
() and drop_endpoint(). Signed-off-by: Julius Werner jwer...@chromium.org Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci.c | 51 + 1 file changed, 18 insertions(+), 33 deletions(-) diff --git a/drivers/usb/host/xhci.c b

[PATCH 5/5] xhci: Fix runtime suspended xhci from blocking system suspend.

2014-06-24 Thread Mathias Nyman
...@intel.com Acked-by: Alan Stern st...@rowland.harvard.edu [use readl() instead of removed xhci_readl(), reword commit message -Mathias] Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff

Re: [PATCH 3/5] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-06-24 Thread Mathias Nyman
On 06/24/2014 05:10 PM, Greg KH wrote: On Tue, Jun 24, 2014 at 05:14:42PM +0300, Mathias Nyman wrote: From: Julius Werner jwer...@chromium.org The current XHCI driver recalculates the Context Entries field in the Slot Context on every add_endpoint() and drop_endpoint() call. In the case

Re: [PATCH v2 1/1] xhci: clear root port wake on bits if controller isn't wake-up capable

2014-06-17 Thread Mathias Nyman
On 06/13/2014 03:06 AM, Lu Baolu wrote: > When xHCI PCI host is suspended, if do_wakeup is false in xhci_pci_suspend, > xhci_bus_suspend needs to clear all root port wake on bits. Otherwise some > Intel > platforms may get a spurious wakeup, even if PCI PME# is disabled. > > This patch should be

Re: [PATCH v2 1/1] xhci: clear root port wake on bits if controller isn't wake-up capable

2014-06-17 Thread Mathias Nyman
On 06/13/2014 03:06 AM, Lu Baolu wrote: When xHCI PCI host is suspended, if do_wakeup is false in xhci_pci_suspend, xhci_bus_suspend needs to clear all root port wake on bits. Otherwise some Intel platforms may get a spurious wakeup, even if PCI PME# is disabled. This patch should be

Re: [PATCH 07/10] xhci: Use command structures when queuing commands on the command ring

2014-06-06 Thread Mathias Nyman
On 06/06/2014 01:16 AM, Dan Williams wrote: > Hi Mathias, hit a small issue playing with -next: > > On Thu, May 8, 2014 at 9:26 AM, Mathias Nyman > wrote: >> To create a global command queue we require that each command put on the >> command ring is submitted

Re: [PATCH 07/10] xhci: Use command structures when queuing commands on the command ring

2014-06-06 Thread Mathias Nyman
On 06/06/2014 01:16 AM, Dan Williams wrote: Hi Mathias, hit a small issue playing with -next: On Thu, May 8, 2014 at 9:26 AM, Mathias Nyman mathias.ny...@linux.intel.com wrote: To create a global command queue we require that each command put on the command ring is submitted with a command

Re: [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-20 Thread Mathias Nyman
On 05/20/2014 04:01 AM, Greg KH wrote: > On Thu, May 08, 2014 at 07:25:55PM +0300, Mathias Nyman wrote: >> From: Dan Williams >> >> Add a command line switch for disabling ehci port switchover. Useful >> for working around / debugging xhci incompatibilities where ehc

Re: [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-20 Thread Mathias Nyman
On 05/20/2014 04:01 AM, Greg KH wrote: On Thu, May 08, 2014 at 07:25:55PM +0300, Mathias Nyman wrote: From: Dan Williams dan.j.willi...@intel.com Add a command line switch for disabling ehci port switchover. Useful for working around / debugging xhci incompatibilities where ehci operation

Re: [PATCH] gpio: Add support for Intel SoC PMIC (Crystal Cove)

2014-05-19 Thread Mathias Nyman
On 05/19/2014 03:27 AM, Zhu, Lejun wrote: > > > On 5/17/2014 1:33 AM, Linus Walleij wrote: >> On Wed, May 14, 2014 at 5:44 PM, Zhu, Lejun >> wrote: >> >>> Devices based on Intel SoC products such as Baytrail have a Power >>> Management IC. In the PMIC there are subsystems for voltage

Re: [PATCH] gpio: Add support for Intel SoC PMIC (Crystal Cove)

2014-05-19 Thread Mathias Nyman
On 05/19/2014 03:27 AM, Zhu, Lejun wrote: On 5/17/2014 1:33 AM, Linus Walleij wrote: On Wed, May 14, 2014 at 5:44 PM, Zhu, Lejun lejun@linux.intel.com wrote: Devices based on Intel SoC products such as Baytrail have a Power Management IC. In the PMIC there are subsystems for voltage

Re: [PATCH] pinctrl: baytrail: Add pull type, strength and open drain to debugfs output

2014-05-16 Thread Mathias Nyman
On 05/16/2014 12:18 PM, Mika Westerberg wrote: > In case of resolving power management or similar issues it might be useful > to have these properties included in the debugfs output. > > Signed-off-by: Mika Westerberg Looks good to me Acked-by: Mathias Nyman -Mathias >

Re: [PATCH] pinctrl: baytrail: Add pull type, strength and open drain to debugfs output

2014-05-16 Thread Mathias Nyman
On 05/16/2014 12:18 PM, Mika Westerberg wrote: In case of resolving power management or similar issues it might be useful to have these properties included in the debugfs output. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Looks good to me Acked-by: Mathias Nyman

Re: [PATCH 00/10] xhci: features for usb-next

2014-05-15 Thread Mathias Nyman
On 05/08/2014 07:25 PM, Mathias Nyman wrote: > Hi Greg > > These following xhci patches are for usb-next and hopefully for 3.16 > > This patcheseries includes a bigger change in xhci command queue code, > (last four patches), a task that I've been working on for a longer

Re: [PATCH 00/10] xhci: features for usb-next

2014-05-15 Thread Mathias Nyman
On 05/08/2014 07:25 PM, Mathias Nyman wrote: Hi Greg These following xhci patches are for usb-next and hopefully for 3.16 This patcheseries includes a bigger change in xhci command queue code, (last four patches), a task that I've been working on for a longer time. Sarah gave green light

Re: [PATCH 03/10] usb: catch attempts to submit urbs with a vmalloc'd transfer buffer

2014-05-12 Thread Mathias Nyman
On 05/08/2014 07:21 PM, Dan Williams wrote: On Thu, May 8, 2014 at 9:25 AM, Mathias Nyman wrote: From: Dan Williams Save someone else the debug cycles of figuring out why a driver's transfer request is failing or causing undefined system behavior. Buffers submitted for dma must come from GFP

Re: [PATCH 03/10] usb: catch attempts to submit urbs with a vmalloc'd transfer buffer

2014-05-12 Thread Mathias Nyman
On 05/08/2014 07:21 PM, Dan Williams wrote: On Thu, May 8, 2014 at 9:25 AM, Mathias Nyman mathias.ny...@linux.intel.com wrote: From: Dan Williams dan.j.willi...@intel.com Save someone else the debug cycles of figuring out why a driver's transfer request is failing or causing undefined system

Re: [regression 3.15-rc3] Resume from s4 broken by 1f81b6d22a5980955b01e08cf27fb745dc9b686f

2014-05-09 Thread Mathias Nyman
I can't see how this relates to Julius patch though, and I'm not sure yet why it only triggers when devices are connected to SS ports. Maybe just unlucky timing? I think the non-SS ports are connected to the EHCI controllers rather than the XHCI controllers. So that explains at least one

Re: [regression 3.15-rc3] Resume from s4 broken by 1f81b6d22a5980955b01e08cf27fb745dc9b686f

2014-05-09 Thread Mathias Nyman
I can't see how this relates to Julius patch though, and I'm not sure yet why it only triggers when devices are connected to SS ports. Maybe just unlucky timing? I think the non-SS ports are connected to the EHCI controllers rather than the XHCI controllers. So that explains at least one

[PATCH 05/10] xhci: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-05-08 Thread Mathias Nyman
() or pci_enable_msix_exact() interfaces. Signed-off-by: Alexander Gordeev Cc: Sarah Sharp Cc: Greg Kroah-Hartman Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb

[PATCH 06/10] xhci: Report max device limit when Enable Slot command fails.

2014-05-08 Thread Mathias Nyman
are plugged in. Signed-off-by: Sarah Sharp Reported-by: Amund Hov Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 88ec076..92e1dda 100644 --- a/drivers/usb/host/xhci.c +++ b

[PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-08 Thread Mathias Nyman
From: Dan Williams Add a command line switch for disabling ehci port switchover. Useful for working around / debugging xhci incompatibilities where ehci operation is available. Reference: http://marc.info/?l=linux-usb=138920063001509=2 Cc: Sarah Sharp Cc: Mathias Nyman Cc: Holger Hans Peter

[PATCH 04/10] usb: xhci: Use IS_ENABLED() macro

2014-05-08 Thread Mathias Nyman
From: Fabio Estevam Using the IS_ENABLED() macro can make the code shorter and easier to read. Signed-off-by: Fabio Estevam Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.h b/drivers/usb

[PATCH 09/10] xhci: Use completion and status in global command queue

2014-05-08 Thread Mathias Nyman
Remove the per-device command list and handle_cmd_in_cmd_wait_list() and use the completion and status variables found in the command structure in the global command list. Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-hub.c | 11 -- drivers/usb/host/xhci-mem.c | 1 - drivers/usb

[PATCH 10/10] xhci: rework command timeout and cancellation,

2014-05-08 Thread Mathias Nyman
o-op right away. All these changes allows us to remove the entire cancel_cmd_list code. The functions waiting for a command to finish no longer have their own timeouts. They will wait either until the command completes normally, or until the whole command abortion is done. Signed-off-by: Mat

[PATCH 08/10] xhci: Add a global command queue

2014-05-08 Thread Mathias Nyman
are freed in the command completion event handler. Also add a check that prevents queuing commands if host is dying Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-mem.c | 2 ++ drivers/usb/host/xhci-ring.c | 34 ++ drivers/usb/host/xhci.c | 2

[PATCH 07/10] xhci: Use command structures when queuing commands on the command ring

2014-05-08 Thread Mathias Nyman
d queue up.(Just so that we won't leak memory in the middle of the patch set) Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-hub.c | 21 +++-- drivers/usb/host/xhci-ring.c | 107 +--- drivers/usb/host/xhci.c | 194 --- d

[PATCH 00/10] xhci: features for usb-next

2014-05-08 Thread Mathias Nyman
: xhci: Use IS_ENABLED() macro Lin Wang (1): xhci: fix wrong port number reported when setting USB2.0 hardware LPM. Mathias Nyman (4): xhci: Use command structures when queuing commands on the command ring xhci: Add a global command queue xhci: Use completion and status in global command

[PATCH 01/10] xhci: fix wrong port number reported when setting USB2.0 hardware LPM.

2014-05-08 Thread Mathias Nyman
From: Lin Wang This patch fix wrong port number reported when trying to enable/disable USB2.0 hardware LPM. Signed-off-by: Lin Wang Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci.c b/drivers

[PATCH 03/10] usb: catch attempts to submit urbs with a vmalloc'd transfer buffer

2014-05-08 Thread Mathias Nyman
. Cc: Alan Stern Cc: Sarah Sharp Cc: Mathias Nyman Signed-off-by: Dan Williams Signed-off-by: Mathias Nyman --- drivers/usb/core/hcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 9c4e292..adddc66 100644 --- a/drivers/usb/core

[PATCH 00/10] xhci: features for usb-next

2014-05-08 Thread Mathias Nyman
: xhci: Use IS_ENABLED() macro Lin Wang (1): xhci: fix wrong port number reported when setting USB2.0 hardware LPM. Mathias Nyman (4): xhci: Use command structures when queuing commands on the command ring xhci: Add a global command queue xhci: Use completion and status in global command

[PATCH 01/10] xhci: fix wrong port number reported when setting USB2.0 hardware LPM.

2014-05-08 Thread Mathias Nyman
From: Lin Wang bupt.wang...@gmail.com This patch fix wrong port number reported when trying to enable/disable USB2.0 hardware LPM. Signed-off-by: Lin Wang lin.x.w...@intel.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci.c | 2 +- 1 file changed, 1

[PATCH 03/10] usb: catch attempts to submit urbs with a vmalloc'd transfer buffer

2014-05-08 Thread Mathias Nyman
for dma_mapping_error() cases. Cc: Alan Stern st...@rowland.harvard.edu Cc: Sarah Sharp sarah.a.sh...@linux.intel.com Cc: Mathias Nyman mathias.ny...@linux.intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/core

[PATCH 08/10] xhci: Add a global command queue

2014-05-08 Thread Mathias Nyman
are freed in the command completion event handler. Also add a check that prevents queuing commands if host is dying Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-mem.c | 2 ++ drivers/usb/host/xhci-ring.c | 34 ++ drivers

[PATCH 07/10] xhci: Use command structures when queuing commands on the command ring

2014-05-08 Thread Mathias Nyman
.(Just so that we won't leak memory in the middle of the patch set) Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 21 +++-- drivers/usb/host/xhci-ring.c | 107 +--- drivers/usb/host/xhci.c | 194

[PATCH 09/10] xhci: Use completion and status in global command queue

2014-05-08 Thread Mathias Nyman
Remove the per-device command list and handle_cmd_in_cmd_wait_list() and use the completion and status variables found in the command structure in the global command list. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 11 -- drivers/usb/host

[PATCH 10/10] xhci: rework command timeout and cancellation,

2014-05-08 Thread Mathias Nyman
away. All these changes allows us to remove the entire cancel_cmd_list code. The functions waiting for a command to finish no longer have their own timeouts. They will wait either until the command completes normally, or until the whole command abortion is done. Signed-off-by: Mathias Nyman

[PATCH 04/10] usb: xhci: Use IS_ENABLED() macro

2014-05-08 Thread Mathias Nyman
From: Fabio Estevam fabio.este...@freescale.com Using the IS_ENABLED() macro can make the code shorter and easier to read. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci.h | 3 +-- 1 file changed, 1

[PATCH 06/10] xhci: Report max device limit when Enable Slot command fails.

2014-05-08 Thread Mathias Nyman
mysteriously fails when too many devices are plugged in. Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com Reported-by: Amund Hov amund@silabs.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

[PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-08 Thread Mathias Nyman
...@linux.intel.com Cc: Mathias Nyman mathias.ny...@linux.intel.com Cc: Holger Hans Peter Freyther hol...@moiji-mobile.com Suggested-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Dan Williams dan.j.willi...@intel.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- Documentation

[PATCH 05/10] xhci: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-05-08 Thread Mathias Nyman
() or pci_enable_msix_exact() interfaces. Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: Sarah Sharp sarah.a.sh...@linux.intel.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Mathias Nyman mathias.ny

Re: [regression 3.15-rc3] Resume from s4 broken by 1f81b6d22a5980955b01e08cf27fb745dc9b686f

2014-05-07 Thread Mathias Nyman
On 05/06/2014 02:41 PM, Ville Syrjälä wrote: On Mon, May 05, 2014 at 12:32:22PM -0700, Julius Werner wrote: Hmmm... very odd. I unfortunately don't have a machine that can easily do S4 at hand, but I did test this on an IVB with XHCI_RESET_ON_RESUME in S3 (essentially the same code path), and I

Re: [regression 3.15-rc3] Resume from s4 broken by 1f81b6d22a5980955b01e08cf27fb745dc9b686f

2014-05-07 Thread Mathias Nyman
On 05/06/2014 02:41 PM, Ville Syrjälä wrote: On Mon, May 05, 2014 at 12:32:22PM -0700, Julius Werner wrote: Hmmm... very odd. I unfortunately don't have a machine that can easily do S4 at hand, but I did test this on an IVB with XHCI_RESET_ON_RESUME in S3 (essentially the same code path), and I

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-29 Thread Mathias Nyman
On 04/29/2014 06:11 AM, Julius Werner wrote: *bump* Sarah, Mathias, can we decide how to proceed with this? I think the section Alan quoted is a pretty good argument in favor of my interpretation (although of course this would not be the first time that two sections of a spec contradict each

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-29 Thread Mathias Nyman
On 04/29/2014 06:11 AM, Julius Werner wrote: *bump* Sarah, Mathias, can we decide how to proceed with this? I think the section Alan quoted is a pretty good argument in favor of my interpretation (although of course this would not be the first time that two sections of a spec contradict each

Re: [PATCH v2 0/4] xhci: fixes for 3.15-rc usb-linus

2014-04-28 Thread Mathias Nyman
On 04/25/2014 07:35 PM, Greg KH wrote: On Fri, Apr 25, 2014 at 07:20:12PM +0300, Mathias Nyman wrote: Hi Greg Second try at this xhci fixes series for 3.15-rc usb-linus. Most of them are very small fixes that didn't make it to 3.14, sitting and waiting for 3.15-rc1 to come out. Only

Re: [PATCH v2 0/4] xhci: fixes for 3.15-rc usb-linus

2014-04-28 Thread Mathias Nyman
On 04/25/2014 07:35 PM, Greg KH wrote: On Fri, Apr 25, 2014 at 07:20:12PM +0300, Mathias Nyman wrote: Hi Greg Second try at this xhci fixes series for 3.15-rc usb-linus. Most of them are very small fixes that didn't make it to 3.14, sitting and waiting for 3.15-rc1 to come out. Only

[PATCH v2 1/4] usb: xhci: Prefer endpoint context dequeue pointer over stopped_trb

2014-04-25 Thread Mathias Nyman
ae636747146ea97efa18e04576acd3416e2514f5 "USB: xhci: URB cancellation support." Signed-off-by: Julius Werner Cc: sta...@vger.kernel.org Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 67 drivers/usb/host/xhci.c | 1 - driver

[PATCH v2 4/4] usb/xhci: fix compilation warning when !CONFIG_PCI && !CONFIG_PM

2014-04-25 Thread Mathias Nyman
3.2 Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 988ed5f..3008369 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -408,16 +408,16 @@

[PATCH v2 3/4] xhci: extend quirk for Renesas cards

2014-04-25 Thread Mathias Nyman
y: Anatoly Kharchenko Reference: http://redmine.russianfedora.pro/issues/1315 Signed-off-by: Igor Gnatenko Cc: sta...@vger.kernel.org # 3.14 Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/host/xh

[PATCH v2 2/4] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.

2014-04-25 Thread Mathias Nyman
Turischev Cc: sta...@vger.kernel.org Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index 47390e3..1715063 100644 --- a/drivers/usb/host/xhci-pci.c +++ b/drivers/usb/host/

[PATCH v2 0/4] xhci: fixes for 3.15-rc usb-linus

2014-04-25 Thread Mathias Nyman
Hi Greg Second try at this xhci fixes series for 3.15-rc usb-linus.

Re: [PATCH 2/5] xhci: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-25 Thread Mathias Nyman
On 04/24/2014 10:49 PM, Greg KH wrote: On Tue, Apr 22, 2014 at 03:22:59PM +0300, Mathias Nyman wrote: From: Alexander Gordeev As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated

Re: [PATCH 0/5] xhci: fixes for 3.15-rc usb-linus

2014-04-25 Thread Mathias Nyman
On 04/24/2014 10:50 PM, Greg KH wrote: On Tue, Apr 22, 2014 at 03:22:57PM +0300, Mathias Nyman wrote: Hi Greg Here are the xhci fixes for 3.15-rc usb-linus. Most of them are very small fixes that didn't make it to 3.14, sitting and waiting for 3.15-rc1 to come out. Only the "Prefer end

Re: [PATCH 0/5] xhci: fixes for 3.15-rc usb-linus

2014-04-25 Thread Mathias Nyman
On 04/24/2014 10:50 PM, Greg KH wrote: On Tue, Apr 22, 2014 at 03:22:57PM +0300, Mathias Nyman wrote: Hi Greg Here are the xhci fixes for 3.15-rc usb-linus. Most of them are very small fixes that didn't make it to 3.14, sitting and waiting for 3.15-rc1 to come out. Only the Prefer endpoint

Re: [PATCH 2/5] xhci: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-25 Thread Mathias Nyman
On 04/24/2014 10:49 PM, Greg KH wrote: On Tue, Apr 22, 2014 at 03:22:59PM +0300, Mathias Nyman wrote: From: Alexander Gordeev agord...@redhat.com As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need

[PATCH v2 0/4] xhci: fixes for 3.15-rc usb-linus

2014-04-25 Thread Mathias Nyman
Hi Greg Second try at this xhci fixes series for 3.15-rc usb-linus.

[PATCH v2 2/4] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.

2014-04-25 Thread Mathias Nyman
Signed-off-by: Denis Turischev de...@compulab.co.il Cc: sta...@vger.kernel.org Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index 47390e3

[PATCH v2 4/4] usb/xhci: fix compilation warning when !CONFIG_PCI !CONFIG_PM

2014-04-25 Thread Mathias Nyman
...@linux.intel.com Cc: sta...@vger.kernel.org # 3.2 Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 988ed5f..3008369 100644

[PATCH v2 3/4] xhci: extend quirk for Renesas cards

2014-04-25 Thread Mathias Nyman
-and-tested-by: Anatoly Kharchenko rfr-b...@yandex.ru Reference: http://redmine.russianfedora.pro/issues/1315 Signed-off-by: Igor Gnatenko i.gnatenko.br...@gmail.com Cc: sta...@vger.kernel.org # 3.14 Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-pci.c | 4

[PATCH v2 1/4] usb: xhci: Prefer endpoint context dequeue pointer over stopped_trb

2014-04-25 Thread Mathias Nyman
the commit ae636747146ea97efa18e04576acd3416e2514f5 USB: xhci: URB cancellation support. Signed-off-by: Julius Werner jwer...@chromium.org Cc: sta...@vger.kernel.org Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-ring.c | 67

Re: [PATCH v3 1/1] pinctrl: add Intel BayTrail GPIO/pinctrl support

2014-04-23 Thread Mathias Nyman
On 04/17/2014 07:47 PM, Timur Tabi wrote: On 04/15/2014 05:01 AM, Mathias Nyman wrote: This device will only be used on an ACPI system, right? And isn't ACPI supposed to hide all the pinctrl programming from the OS? I thought that was the whole point behind ACPI and the reason why ARM64

Re: [PATCH] pinctrl-baytrail: workaround for irq descriptor conflict on ASUS T100TA

2014-04-23 Thread Mathias Nyman
Urgent fix and the maintainers did not react in a week? Well maybe they need to be on the To: line... Mathias: can you send a patch adding yourself as maintainer of this driver in the MAINTAINERS file so stuff like this does not fall to the floor (me)? Hi, Sorry about the delay. I'm taking

Re: [PATCH] pinctrl-baytrail: workaround for irq descriptor conflict on ASUS T100TA

2014-04-23 Thread Mathias Nyman
Urgent fix and the maintainers did not react in a week? Well maybe they need to be on the To: line... Mathias: can you send a patch adding yourself as maintainer of this driver in the MAINTAINERS file so stuff like this does not fall to the floor (me)? Hi, Sorry about the delay. I'm taking

Re: [PATCH v3 1/1] pinctrl: add Intel BayTrail GPIO/pinctrl support

2014-04-23 Thread Mathias Nyman
On 04/17/2014 07:47 PM, Timur Tabi wrote: On 04/15/2014 05:01 AM, Mathias Nyman wrote: This device will only be used on an ACPI system, right? And isn't ACPI supposed to hide all the pinctrl programming from the OS? I thought that was the whole point behind ACPI and the reason why ARM64

Re: [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.

2014-04-22 Thread Mathias Nyman
On 04/22/2014 02:04 PM, Denis Turischev wrote: Hi Mathias, Just want to remind you about the patch, thanks. Sent to Greg a minute ago, thanks -Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

<    2   3   4   5   6   7   8   9   10   >