[PATCH v5 5/6] dmaengine: pl330: Make sure microcode is privileged

2016-07-27 Thread Mitchel Humpherys
DMA_ATTR_PRIVILEGED attribute, which will ensure that the microcode IOMMU mapping is only accessible to the privileged level. Cc: Dan Williams Cc: Vinod Koul Reviewed-by: Robin Murphy Tested-by: Robin Murphy Signed-off-by: Mitchel Humpherys --- Notes: v3..v4 - Reworked against the new dma

[PATCH v5 6/6] Revert "iommu/arm-smmu: Treat all device transactions as unprivileged"

2016-07-27 Thread Mitchel Humpherys
This reverts commit d346180e70b9 ("iommu/arm-smmu: Treat all device transactions as unprivileged") since some platforms actually make use of privileged transactions. Reviewed-by: Robin Murphy Tested-by: Robin Murphy Signed-off-by: Mitchel Humpherys --- Notes: v2..v3

[PATCH v5 1/6] iommu: add IOMMU_PRIV attribute

2016-07-27 Thread Mitchel Humpherys
Add the IOMMU_PRIV attribute, which is used to indicate privileged mappings. Reviewed-by: Robin Murphy Tested-by: Robin Murphy Signed-off-by: Mitchel Humpherys --- Notes: v2..v3 - Added comment include/linux/iommu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include

[PATCH v5 2/6] iommu/io-pgtable-arm: add support for the IOMMU_PRIV flag

2016-07-27 Thread Mitchel Humpherys
From: Jeremy Gebben Allow the creation of privileged mode mappings, for stage 1 only. Reviewed-by: Robin Murphy Tested-by: Robin Murphy Signed-off-by: Jeremy Gebben --- Notes: v2..v3 - Use existing bit definitions. drivers/iommu/io-pgtable-arm.c | 5 - 1 file changed, 4

[PATCH v5 4/6] arm64/dma-mapping: Implement DMA_ATTR_PRIVILEGED

2016-07-27 Thread Mitchel Humpherys
The newly added DMA_ATTR_PRIVILEGED is useful for creating mappings that are only accessible to privileged DMA engines. Implement it in dma-iommu.c so that the ARM64 DMA IOMMU mapper can make use of it. Reviewed-by: Robin Murphy Tested-by: Robin Murphy Signed-off-by: Mitchel Humpherys

[PATCH v5 0/6] Add support for privileged mappings

2016-07-27 Thread Mitchel Humpherys
use that in the pl330 driver (suggested by Will). Jeremy Gebben (1): iommu/io-pgtable-arm: add support for the IOMMU_PRIV flag Mitchel Humpherys (5): iommu: add IOMMU_PRIV attribute common: DMA-mapping: add DMA_ATTR_PRIVILEGED attribute arm64/dma-mapping: Implement DMA_ATTR_PRIVILEGED dma

[PATCH v5 3/6] common: DMA-mapping: add DMA_ATTR_PRIVILEGED attribute

2016-07-27 Thread Mitchel Humpherys
e to the DMA-mapping subsystem that the buffer is fully accessible at the elevated privilege level (and ideally inaccessible or at least read-only at the lesser-privileged levels). Cc: linux-...@vger.kernel.org Reviewed-by: Robin Murphy Tested-by: Robin Murphy Signed-off-by: Mitchel Humpherys --

Re: [PATCH v4 4/6] arm64/dma-mapping: Implement DMA_ATTR_PRIVILEGED

2016-07-27 Thread Mitchel Humpherys
On Tue, Jul 26 2016 at 04:05:17 PM, Robin Murphy wrote: > + if (attrs & DMA_ATTR_PRIVILEGED) > + prot |= IOMMU_PRIV; > + > > then drop the rest of the changes to the switch statement below. It's > taken me an embarrassingly long time to work out why things were blowing > up in __io

[PATCH v4 5/6] dmaengine: pl330: Make sure microcode is privileged

2016-07-25 Thread Mitchel Humpherys
DMA_ATTR_PRIVILEGED attribute, which will ensure that the microcode IOMMU mapping is only accessible to the privileged level. Cc: Dan Williams Cc: Jassi Brar Signed-off-by: Mitchel Humpherys --- Notes: v3..v4 - Reworked against the new dma attrs format. drivers/dma/pl330.c | 6 -- 1

[PATCH v4 6/6] Revert "iommu/arm-smmu: Treat all device transactions as unprivileged"

2016-07-25 Thread Mitchel Humpherys
This reverts commit d346180e70b9 ("iommu/arm-smmu: Treat all device transactions as unprivileged") since some platforms actually make use of privileged transactions. Signed-off-by: Mitchel Humpherys --- Notes: v2..v3 - Moved to the end of the series. drivers/iommu/

[PATCH v4 1/6] iommu: add IOMMU_PRIV attribute

2016-07-25 Thread Mitchel Humpherys
Add the IOMMU_PRIV attribute, which is used to indicate privileged mappings. Signed-off-by: Mitchel Humpherys --- Notes: v2..v3 - Added comment include/linux/iommu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/iommu.h b/include/linux/iommu.h index

[PATCH v4 2/6] iommu/io-pgtable-arm: add support for the IOMMU_PRIV flag

2016-07-25 Thread Mitchel Humpherys
From: Jeremy Gebben Allow the creation of privileged mode mappings, for stage 1 only. Signed-off-by: Jeremy Gebben --- Notes: v2..v3 - Use existing bit definitions. drivers/iommu/io-pgtable-arm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i

[PATCH v4 4/6] arm64/dma-mapping: Implement DMA_ATTR_PRIVILEGED

2016-07-25 Thread Mitchel Humpherys
The newly added DMA_ATTR_PRIVILEGED is useful for creating mappings that are only accessible to privileged DMA engines. Implement it in dma-iommu.c so that the ARM64 DMA IOMMU mapper can make use of it. Signed-off-by: Mitchel Humpherys --- Notes: v3..v4 - Reworked against the

[PATCH v4 3/6] common: DMA-mapping: add DMA_ATTR_PRIVILEGED attribute

2016-07-25 Thread Mitchel Humpherys
e to the DMA-mapping subsystem that the buffer is fully accessible at the elevated privilege level (and ideally inaccessible or at least read-only at the lesser-privileged levels). Cc: linux-...@vger.kernel.org Signed-off-by: Mitchel Humpherys --- Notes: v3..v4 - Reworked against the

[PATCH v4 0/6] Add support for privileged mappings

2016-07-25 Thread Mitchel Humpherys
s work, and use that in the pl330 driver (suggested by Will). Jeremy Gebben (1): iommu/io-pgtable-arm: add support for the IOMMU_PRIV flag Mitchel Humpherys (5): iommu: add IOMMU_PRIV attribute common: DMA-mapping: add DMA_ATTR_PRIVILEGED attribute arm64/dma-mapping: Implement DMA_A

Re: [PATCH v3 0/6] Add support for privileged mappings

2016-07-25 Thread Mitchel Humpherys
On Mon, Jul 25 2016 at 10:50:13 AM, Will Deacon wrote: > On Fri, Jul 22, 2016 at 01:39:45PM -0700, Mitchel Humpherys wrote: >> On Fri, Jul 22 2016 at 05:51:07 PM, Will Deacon wrote: >> > On Tue, Jul 19, 2016 at 01:36:49PM -0700, Mitchel Humpherys wrote: >> >> The f

Re: [PATCH v3 0/6] Add support for privileged mappings

2016-07-22 Thread Mitchel Humpherys
On Fri, Jul 22 2016 at 05:51:07 PM, Will Deacon wrote: > On Tue, Jul 19, 2016 at 01:36:49PM -0700, Mitchel Humpherys wrote: >> The following patch to the ARM SMMU driver: >> >> commit d346180e70b91b3d5a1ae7e5603e65593d4622bc >> Author: Robin Murphy >>

[PATCH v3 0/6] Add support for privileged mappings

2016-07-19 Thread Mitchel Humpherys
* Don't worry about executability in new DMA attr. v1..v2 - Added a new DMA attribute to make executable privileged mappings work, and use that in the pl330 driver (suggested by Will). Jeremy Gebben (1): iommu/io-pgtable-arm: add support for the IOMMU_PRIV flag Mitchel Humpherys

[PATCH v3 2/6] iommu/io-pgtable-arm: add support for the IOMMU_PRIV flag

2016-07-19 Thread Mitchel Humpherys
From: Jeremy Gebben Allow the creation of privileged mode mappings, for stage 1 only. Signed-off-by: Jeremy Gebben --- Notes: v2..v3 - Use existing bit definitions. drivers/iommu/io-pgtable-arm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i

[PATCH v3 5/6] dmaengine: pl330: Make sure microcode is privileged

2016-07-19 Thread Mitchel Humpherys
DMA_ATTR_PRIVILEGED attribute, which will ensure that the microcode IOMMU mapping is only accessible to the privileged level. Cc: Dan Williams Cc: Jassi Brar Signed-off-by: Mitchel Humpherys --- drivers/dma/pl330.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/dma/pl330

[PATCH v3 4/6] arm64/dma-mapping: Implement DMA_ATTR_PRIVILEGED

2016-07-19 Thread Mitchel Humpherys
The newly added DMA_ATTR_PRIVILEGED is useful for creating mappings that are only accessible to privileged DMA engines. Implement it in dma-iommu.c so that the ARM64 DMA IOMMU mapper can make use of it. Signed-off-by: Mitchel Humpherys --- Notes: v2..v3 - Renamed and

[PATCH v3 3/6] common: DMA-mapping: add DMA_ATTR_PRIVILEGED attribute

2016-07-19 Thread Mitchel Humpherys
e to the DMA-mapping subsystem that the buffer is fully accessible at the elevated privilege level (and ideally inaccessible or at least read-only at the lesser-privileged levels). Cc: linux-...@vger.kernel.org Signed-off-by: Mitchel Humpherys --- Notes: v2..v3 - Not worrying

[PATCH v3 6/6] Revert "iommu/arm-smmu: Treat all device transactions as unprivileged"

2016-07-19 Thread Mitchel Humpherys
This reverts commit d346180e70b9 ("iommu/arm-smmu: Treat all device transactions as unprivileged") since some platforms actually make use of privileged transactions. Signed-off-by: Mitchel Humpherys --- Notes: v2..v3 - Moved to the end of the series. drivers/iommu/

[PATCH v3 1/6] iommu: add IOMMU_PRIV attribute

2016-07-19 Thread Mitchel Humpherys
Add the IOMMU_PRIV attribute, which is used to indicate privileged mappings. Signed-off-by: Mitchel Humpherys --- Notes: v2..v3 - Added comment include/linux/iommu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/iommu.h b/include/linux/iommu.h index

[PATCH v2 2/6] iommu/io-pgtable-arm: add support for the IOMMU_PRIV flag

2016-07-08 Thread Mitchel Humpherys
From: Jeremy Gebben Allow the creation of privileged mode mappings, for stage 1 only. Signed-off-by: Jeremy Gebben --- drivers/iommu/io-pgtable-arm.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-

[PATCH v2 3/6] Revert "iommu/arm-smmu: Treat all device transactions as unprivileged"

2016-07-08 Thread Mitchel Humpherys
This reverts commit d346180e70b9 ("iommu/arm-smmu: Treat all device transactions as unprivileged") since some platforms actually make use of privileged transactions. Signed-off-by: Mitchel Humpherys --- drivers/iommu/arm-smmu.c | 5 + 1 file changed, 1 insertion(+), 4 deletion

[PATCH v2 5/6] arm64/dma-mapping: Implement DMA_ATTR_PRIVILEGED_EXECUTABLE

2016-07-08 Thread Mitchel Humpherys
The newly added DMA_ATTR_PRIVILEGED_EXECUTABLE is useful for creating mappings that are executable by privileged DMA engines. Implement it in dma-iommu.c so that the ARM64 DMA IOMMU mapper can make use of it. Signed-off-by: Mitchel Humpherys --- arch/arm64/mm/dma-mapping.c | 6 +++--- drivers

[PATCH v2 4/6] common: DMA-mapping: add DMA_ATTR_PRIVILEGED_EXECUTABLE attribute

2016-07-08 Thread Mitchel Humpherys
is necessary to ensure that the buffer is executable at an elevated privilege level (by making it read-only at the lesser-privileged levels, for example). Cc: linux-...@vger.kernel.org Signed-off-by: Mitchel Humpherys --- Documentation/DMA-attributes.txt | 9 + include/linux/dma-attrs.h

[PATCH v2 1/6] iommu: add IOMMU_PRIV attribute

2016-07-08 Thread Mitchel Humpherys
Add the IOMMU_PRIV attribute, which is used to indicate privileged mappings. Signed-off-by: Mitchel Humpherys --- include/linux/iommu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 664683aedcce..01c9f2667f2b 100644 --- a/include/linux

[PATCH v2 0/6] Add support for privileged mappings

2016-07-08 Thread Mitchel Humpherys
y Changelog: v1..v2 - Added a new DMA attribute to make executable privileged mappings work, and use that in the pl330 driver (suggested by Will). Jeremy Gebben (1): iommu/io-pgtable-arm: add support for the IOMMU_PRIV flag Mitchel Humpherys (5): iommu: add IOMMU_PRIV attribute

[PATCH v2 6/6] dmaengine: pl330: Make sure microcode is privileged-executable

2016-07-08 Thread Mitchel Humpherys
DMA_ATTR_PRIVILEGED_EXECUTABLE attribute, which will ensure that the microcode IOMMU mapping is not writeable. Cc: Dan Williams Cc: Jassi Brar Signed-off-by: Mitchel Humpherys --- drivers/dma/pl330.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers

Re: [PATCH v2] of: Check for overlap in reserved memory regions

2015-12-04 Thread Mitchel Humpherys
On Thu, Nov 12 2015 at 01:19:59 PM, Michael Ellerman wrote: > On Tue, 2015-09-15 at 18:30 -0700, Mitchel Humpherys wrote: > >> Any overlap in the reserved memory regions (those specified in the >> reserved-memory DT node) is a bug. > > Can you expand a bit on why you th

Re: [PATCH] of: Fix comparison of reserved memory regions

2015-12-04 Thread Mitchel Humpherys
Fixes: ae1add247bf8 ("of: Check for overlap in reserved memory regions") > Signed-off-by: Michael Ellerman > --- > drivers/of/of_reserved_mem.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) Woops, thanks. Tested-by: Mitchel Humpherys -Mitch -- Qualcomm

Re: [RFC][PATCH 1/2] WIP: Devicetree bindings for Ion

2015-10-20 Thread Mitchel Humpherys
On Tue, Oct 13 2015 at 11:14:23 AM, Andrew wrote: > On 2015-10-12 21:39, Mitchel Humpherys wrote: >> On Tue, Oct 06 2015 at 05:35:41 PM, Rob Herring >> wrote: >>> On Tue, Oct 6, 2015 at 3:47 PM, Laura Abbott >>> wrote: >> >> [.

Re: [RFC][PATCH 1/2] WIP: Devicetree bindings for Ion

2015-10-12 Thread Mitchel Humpherys
On Tue, Oct 06 2015 at 05:35:41 PM, Rob Herring wrote: > On Tue, Oct 6, 2015 at 3:47 PM, Laura Abbott > wrote: [...] >> +Example: >> + >> + ion { >> + compatbile = "linux,ion"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> +

[PATCH v2] of: Check for overlap in reserved memory regions

2015-09-15 Thread Mitchel Humpherys
rning during boot if overlap is detected. Signed-off-by: Mitchel Humpherys --- v1..v2: - Suggestions from Rob Herring (remove superfluous array and print statement) --- drivers/of/of_reserved_mem.c | 43 ++- 1 file changed, 42 insertions(+), 1 del

Re: [PATCH] of: Check for overlap in reserved memory regions

2015-09-14 Thread Mitchel Humpherys
On Mon, Sep 14 2015 at 02:21:04 PM, Rob Herring wrote: > On Fri, Sep 11, 2015 at 12:31 PM, Mitchel Humpherys > wrote: >> Any overlap in the reserved memory regions (those specified in the >> reserved-memory DT node) is a bug. These bugs might go undetected as >> long

[PATCH] of: Check for overlap in reserved memory regions

2015-09-11 Thread Mitchel Humpherys
rning during boot if overlap is detected. Signed-off-by: Mitchel Humpherys --- drivers/of/of_reserved_mem.c | 45 +++- 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index 726ebe7

Re: [PATCH v2 2/2] staging: ion: chunk_heap: use %pad for printing dma_addr_t's

2015-05-04 Thread Mitchel Humpherys
On Mon, May 04 2015 at 01:05:50 PM, Colin Cross wrote: > On Mon, May 4, 2015 at 1:22 AM, Dan Carpenter > wrote: >> On Thu, Apr 09, 2015 at 06:10:04PM -0700, Mitchel Humpherys wrote: >>> We're currently using %lu and %ld to print some variables of type >>&g

[PATCH] ion: improve ion_phys error message

2015-03-10 Thread Mitchel Humpherys
Clients often get confused when ion_phys errors out due to some heap being used that they didn't expect. Add the heap name and heap type to the error message to make it more obvious. Signed-off-by: Mitchel Humpherys --- drivers/staging/android/ion/ion.c | 4 ++-- 1 file changed, 2 inser

Re: [PATCH 2/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-03-09 Thread Mitchel Humpherys
On Mon, Mar 09 2015 at 05:16:26 AM, Yong Wu wrote: > Dear Mitchel, > Thanks very much for your review. > > On Fri, 2015-03-06 at 09:15 -0800, Mitchel Humpherys wrote: >> On Fri, Mar 06 2015 at 02:48:17 AM, wrote: >> > From: Yong Wu >> > >>

Re: [PATCH 2/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-03-06 Thread Mitchel Humpherys
On Fri, Mar 06 2015 at 02:48:17 AM, wrote: > From: Yong Wu > > This patch adds support for mediatek m4u (MultiMedia Memory Management Unit). > Currently this only supports m4u gen 2 with 2 levels of page table on mt8173. [...] > +static int mtk_iommu_invalidate_tlb(const struct mtk_iommu_info *

[PATCH] ion: improve ion_phys error message

2015-02-13 Thread Mitchel Humpherys
Clients often get confused when ion_phys errors out due to some heap being used that they didn't expect. Add the heap name and heap type to the error message to make it more obvious. Signed-off-by: Mitchel Humpherys --- drivers/staging/android/ion/ion.c | 4 ++-- 1 file changed, 2 inser

Re: [PATCH v10] iopoll: Introduce memory-mapped IO polling macros

2015-01-14 Thread Mitchel Humpherys
On Tue, Dec 16 2014 at 01:45:27 AM, Will Deacon wrote: > On Mon, Dec 15, 2014 at 11:47:23PM +0000, Mitchel Humpherys wrote: >> From: Matt Wagantall >> >> It is sometimes necessary to poll a memory-mapped register until its value >> satisfies some condition. Introd

[PATCH] staging: ion: always initialize the free list parameters

2015-01-08 Thread Mitchel Humpherys
ly in ion_device_add_heap, which is always called no matter which heap features are being used. Signed-off-by: Mitchel Humpherys --- drivers/staging/android/ion/ion.c | 3 +++ drivers/staging/android/ion/ion_heap.c | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/androi

[PATCH v10] iopoll: Introduce memory-mapped IO polling macros

2014-12-15 Thread Mitchel Humpherys
Deacon Cc: Arnd Bergmann Cc: Andrew Morton Cc: Robert Elliott Signed-off-by: Matt Wagantall Signed-off-by: Mitchel Humpherys --- v9..10: - Actually added the comments mentioned in v8..v9 (doh!) v8..v9: - Added note in comments about max sleep time (Rob Elliott) v7..v8: - sorted helper

Re: [PATCH v9] iopoll: Introduce memory-mapped IO polling macros

2014-12-15 Thread Mitchel Humpherys
On Mon, Dec 15 2014 at 03:31:20 PM, Mitchel Humpherys wrote: > From: Matt Wagantall > > It is sometimes necessary to poll a memory-mapped register until its value > satisfies some condition. Introduce a family of convenience macros that do > this. Tight-looping, sleeping, and tim

[PATCH v9] iopoll: Introduce memory-mapped IO polling macros

2014-12-15 Thread Mitchel Humpherys
Deacon Cc: Arnd Bergmann Cc: Andrew Morton Cc: Robert Elliott Signed-off-by: Matt Wagantall Signed-off-by: Mitchel Humpherys --- v8..v9: - Added note in comments about max sleep time (Rob Elliott) v7..v8: - sorted helper macros by size (b, w, l, q) - removed some of the more esoteric (or

Re: [PATCH RESEND v8] iopoll: Introduce memory-mapped IO polling macros

2014-11-24 Thread Mitchel Humpherys
On Mon, Nov 24 2014 at 04:53:19 PM, "Elliott, Robert (Server Storage)" wrote: >> -Original Message- >> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- >> ow...@vger.kernel.org] On Behalf Of Mitchel Humpherys >> Sent: Monday, 24 November

[PATCH RESEND v8] iopoll: Introduce memory-mapped IO polling macros

2014-11-24 Thread Mitchel Humpherys
Deacon Cc: Arnd Bergmann Cc: Andrew Morton Signed-off-by: Matt Wagantall Signed-off-by: Mitchel Humpherys --- This patch was originally part of a series [1] for adding support for IOMMU address translations through an ARM SMMU hardware register. The other patch in the series (the one that actually

Re: [RFC] add a struct page* parameter to dma_map_ops.unmap_page

2014-11-21 Thread Mitchel Humpherys
On Fri, Nov 21 2014 at 03:48:33 AM, Stefano Stabellini wrote: > On Mon, 17 Nov 2014, Stefano Stabellini wrote: >> Hi all, >> I am writing this email to ask for your advice. >> >> On architectures where dma addresses are different from physical >> addresses, it can be difficult to retrieve the ph

[PATCH RESEND v8] iopoll: Introduce memory-mapped IO polling macros

2014-11-17 Thread Mitchel Humpherys
Deacon Cc: Arnd Bergmann Signed-off-by: Matt Wagantall Signed-off-by: Mitchel Humpherys --- Sorry for any confusion regarding the genesis of this patch. Let me try to clarify the history here. This patch was originally part of a series [1] for adding support for IOMMU address translations through

[PATCH RESEND v8] iopoll: Introduce memory-mapped IO polling macros

2014-11-06 Thread Mitchel Humpherys
Deacon Cc: Arnd Bergmann Signed-off-by: Matt Wagantall Signed-off-by: Mitchel Humpherys --- Changes since v7: - sorted helper macros by size (b, w, l, q) - removed some of the more esoteric (or flat-out bogus) helper macros --- include/linux/iopoll.h | 140

[PATCH v8] iopoll: Introduce memory-mapped IO polling macros

2014-10-30 Thread Mitchel Humpherys
Deacon Cc: Arnd Bergmann Signed-off-by: Matt Wagantall Signed-off-by: Mitchel Humpherys --- Changes since v7: - sorted helper macros by size (b, w, l, q) - removed some of the more esoteric (or flat-out bogus) helper macros --- include/linux/iopoll.h | 140

Re: [PATCH v2 0/9] staging: ion: system heap and page pool fixes

2014-05-28 Thread Mitchel Humpherys
learned a new trick with page.lru :). Reviewed-by: Mitchel Humpherys > > Heesub Shin (9): > staging: ion: tidy up a bit > staging: ion: simplify ion_page_pool_total() > staging: ion: remove struct ion_page_pool_item > staging: ion: use compound pages on high order pages for

Re: [PATCH 7/9] staging: ion: remove order argument from free_buffer_page()

2014-05-27 Thread Mitchel Humpherys
On Mon, May 26 2014 at 03:04:59 AM, Heesub Shin wrote: > Not that the pages returned from the pool are compound pages, we do not > need to pass the order information to free_buffer_page(). s/Not/Now/ -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Li

Re: [PATCH 6/9] staging: ion: remove struct page_info

2014-05-27 Thread Mitchel Humpherys
On Mon, May 26 2014 at 03:04:58 AM, Heesub Shin wrote: > ION system heap uses a temporary list holding meta data on pages > allocated to build scatter/gather table. Now that the pages are compound > pages, we do not need to introduce a new data type redundantly. > > Signed-off-by: Heesub Shin > -

[RESEND PATCH] staging: ion: WARN when the handle kmap_cnt is going to wrap around

2014-05-23 Thread Mitchel Humpherys
akes a long time to complete when kmap_cnt starts at ~0 and can result in a watchdog timeout. WARN and bail when kmap_cnt is about to wrap around from zero. Signed-off-by: Mitchel Humpherys Acked-by: Colin Cross --- Resending since I missed a few folks on the original. Also retaining Colin'

Re: [PATCH] staging: ion: WARN when the handle kmap_cnt is going to wrap around

2014-05-23 Thread Mitchel Humpherys
++greg-kh and de...@driverdev.osuosl.org (my bad for missing you the first time around) On Thu, May 22 2014 at 06:09:11 PM, Colin Cross wrote: > On Thu, May 22, 2014 at 5:51 PM, Mitchel Humpherys > wrote: >> There are certain client bugs (double unmap, for example) that can cause &

[PATCH] staging: ion: WARN when the handle kmap_cnt is going to wrap around

2014-05-22 Thread Mitchel Humpherys
akes a long time to complete when kmap_cnt starts at ~0 and can result in a watchdog timeout. WARN and bail when kmap_cnt is about to wrap around from zero. Signed-off-by: Mitchel Humpherys --- drivers/staging/android/ion/ion.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/s

Re: [PATCH v4 1/7] arm64: Use pr_* instead of printk

2014-04-29 Thread Mitchel Humpherys
On Mon, Apr 28 2014 at 09:59:14 PM, Jungseok Lee wrote: > This patch fixed the following checkpatch complaint as using pr_* > instead of printk. > > WARNING: printk() should include KERN_ facility level > > Cc: Catalin Marinas > Signed-off-by: Jungseok Lee > Reviewed-by: Sungjinn Chung > --- >

[PATCH] ion: only use the CMA heap when CONFIG_CMA is enabled

2014-04-17 Thread Mitchel Humpherys
A API routines) but the fact that the memory isn't coming from CMA is confusing. Signed-off-by: Mitchel Humpherys --- drivers/staging/android/ion/Makefile | 3 ++- drivers/staging/android/ion/ion_heap.c | 4 drivers/staging/android/ion/ion_priv.h | 3 +++ 3 files changed, 9 insertions(+),

[PATCH v4] Some printk cleanup in mm

2014-04-15 Thread Mitchel Humpherys
s probably just churn to convert everything to the pr_ macros. - v2: Suggestions by Joe Perches (pr_fmt, pr_cont, pr_err, __func__, missing \n) Mitchel Humpherys (1): mm: convert some level-less printks to pr_* mm/bounce.c| 7 +-- mm/mempolicy.c | 5 - mm/m

[PATCH v4] mm: convert some level-less printks to pr_*

2014-04-15 Thread Mitchel Humpherys
print statements can be easily traced back to the modules where they occur, correlated one with another, etc. This will require the removal of some (now redundant) prefixes on a few print statements. Signed-off-by: Mitchel Humpherys --- mm/bounce.c| 7 +-- mm/mempolicy.c | 5 - mm

Re: [PATCH v2] mm: convert some level-less printks to pr_*

2014-04-15 Thread Mitchel Humpherys
On Tue, Apr 15 2014 at 04:58:21 PM, Mitchel Humpherys wrote: > On Mon, Apr 14 2014 at 03:55:26 PM, Andrew Morton > wrote: >> And all of this should be described and justified in the changelog, >> please. > > Will send a v3 shortly. Thanks for your comments. Make that

Re: [PATCH v2] mm: convert some level-less printks to pr_*

2014-04-15 Thread Mitchel Humpherys
On Mon, Apr 14 2014 at 03:55:26 PM, Andrew Morton wrote: > On Thu, 27 Mar 2014 10:54:19 -0700 Mitchel Humpherys > wrote: >> #include >> #include >> #include >> @@ -15,6 +17,7 @@ >> #include >> #include >> #include >> +#inclu

[PATCH v3] mm: convert some level-less printks to pr_*

2014-04-07 Thread Mitchel Humpherys
printk is meant to be used with an associated log level. There are some instances of printk scattered around the mm code where the log level is missing. Add a log level and adhere to suggestions by scripts/checkpatch.pl by moving to the pr_* macros. Signed-off-by: Mitchel Humpherys --- mm

[PATCH v3] Some printk cleanup in mm

2014-04-07 Thread Mitchel Humpherys
pr_fmt, pr_cont, pr_err, __func__, missing \n) Mitchel Humpherys (1): mm: convert some level-less printks to pr_* mm/bounce.c| 7 +-- mm/mempolicy.c | 5 - mm/mmap.c | 21 - mm/nommu.c | 5 - mm/vmscan.c| 5 - 5 files changed, 29 in

Re: [PATCH v2] mm: convert some level-less printks to pr_*

2014-04-03 Thread Mitchel Humpherys
On Thu, Apr 03 2014 at 09:33:15 AM, Christoph Lameter wrote: > On Mon, 31 Mar 2014, Joe Perches wrote: > >> On Mon, 2014-03-31 at 13:35 -0500, Christoph Lameter wrote: >> > On Thu, 27 Mar 2014, Mitchel Humpherys wrote: >> > >> > > diff --git a/mm/sl

Re: [PATCH] arm: ftrace: work with CONFIG_DEBUG_SET_MODULE_RONX

2014-04-03 Thread Mitchel Humpherys
On Wed, Apr 02 2014 at 06:04:29 PM, Laura Abbott wrote: > I think Mitch tested this on our internal targets. I'll let him reply with > his Tested-by > > Laura Indeed: Tested-by: Mitchel Humpherys -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora For

[PATCH v2] mm: convert some level-less printks to pr_*

2014-03-27 Thread Mitchel Humpherys
printk is meant to be used with an associated log level. There are some instances of printk scattered around the mm code where the log level is missing. Add a log level and adhere to suggestions by scripts/checkpatch.pl by moving to the pr_* macros. Signed-off-by: Mitchel Humpherys --- mm

[PATCH v2] Some printk cleanup in mm

2014-03-27 Thread Mitchel Humpherys
This series cleans up some printks in the mm code that were missing log levels. Changelog: - v2: Suggestions by Joe Perches (pr_fmt, pr_cont, pr_err, __func__, missing \n) Mitchel Humpherys (1): mm: convert some level-less printks to pr_* mm/bounce.c| 7 +-- mm/mempolicy.c

[PATCH] mm: convert some level-less printks to pr_*

2014-03-26 Thread Mitchel Humpherys
printk is meant to be used with an associated log level. There are some instances of printk scattered around the mm code where the log level is missing. Add a log level and adhere to suggestions by scripts/checkpatch.pl by moving to the pr_* macros. Signed-off-by: Mitchel Humpherys --- mm

[PATCH] Some printk cleanup in mm

2014-03-26 Thread Mitchel Humpherys
This series cleans up some printks in the mm code that were missing log levels. Mitchel Humpherys (1): mm: convert some level-less printks to pr_* mm/bounce.c| 5 +++-- mm/mempolicy.c | 3 ++- mm/mmap.c | 19 ++- mm/nommu.c | 3 ++- mm/slub.c | 7

[PATCH 1/2] Documentation/SubmittingPatches: update some dead URLs

2014-03-25 Thread Mitchel Humpherys
The links to "The perfect patch" and "NO No more huge patch bombs..." have gone stale. Update them to some working locations. Signed-off-by: Mitchel Humpherys --- Documentation/SubmittingPatches | 4 ++-- Documentation/ja_JP/SubmittingPatches | 4 ++--

[PATCH 2/2] Documentation/SubmittingPatches: remove references to patch-scripts

2014-03-25 Thread Mitchel Humpherys
The link to the tarball for Andrew Morton's patch scripts is dead. These scripts don't seem to be used for kernel development these days anyways so just rip out all references to them. Signed-off-by: Mitchel Humpherys --- Documentation/SubmittingPatches | 5 - Documenta

[PATCH 0/2] URL cleanup in Documentation/SubmittingPatches

2014-03-25 Thread Mitchel Humpherys
Some URLs in Documentation/SubmittingPatches have gone stale. This series cleans some of them up by removing or updating them. Mitchel Humpherys (2): Documentation/SubmittingPatches: update some dead URLs Documentation/SubmittingPatches: remove references to patch-scripts Documentation