Re: [PATCH] Filesystem capabilities support

2005-07-14 Thread Nicholas Hans Simmonds
On Fri, Jul 15, 2005 at 05:45:58AM +0200, Jesper Juhl wrote: > On 7/16/05, Nicholas Hans Simmonds <[EMAIL PROTECTED]> wrote: > > While I'm not qualified to comment on the implementation I do have a > few small codingstyle comments :-) > > > > diff --git a/fs/

Re: [PATCH] Filesystem capabilities support

2005-07-14 Thread Nicholas Hans Simmonds
On Thu, Jul 14, 2005 at 04:05:17PM -0400, Horst von Brand wrote: > Nicholas Hans Simmonds <[EMAIL PROTECTED]> wrote: > > [...] > > > Other than this, what are the general thoughts about this method as > > opposed to just using a well defined byte order? >

Re: [PATCH] Filesystem capabilities support

2005-07-14 Thread Nicholas Hans Simmonds
On Thu, Jul 14, 2005 at 04:05:17PM -0400, Horst von Brand wrote: Nicholas Hans Simmonds [EMAIL PROTECTED] wrote: [...] Other than this, what are the general thoughts about this method as opposed to just using a well defined byte order? I'd prefer a defined byte order. That way

Re: [PATCH] Filesystem capabilities support

2005-07-14 Thread Nicholas Hans Simmonds
On Fri, Jul 15, 2005 at 05:45:58AM +0200, Jesper Juhl wrote: On 7/16/05, Nicholas Hans Simmonds [EMAIL PROTECTED] wrote: While I'm not qualified to comment on the implementation I do have a few small codingstyle comments :-) diff --git a/fs/read_write.c b/fs/read_write.c --- a/fs

Re: [PATCH] Filesystem capabilities support

2005-07-13 Thread Nicholas Hans Simmonds
On Wed, Jul 13, 2005 at 01:51:46PM -0400, Horst von Brand wrote: > Nicholas Hans Simmonds <[EMAIL PROTECTED]> wrote: > > Sorry, my earlier reply seems to have gotten lost somewhere. I've been > > pondering this issue for some time and am still not sure what's the best >

Re: [PATCH] Filesystem capabilities support

2005-07-13 Thread Nicholas Hans Simmonds
On Wed, Jul 06, 2005 at 02:56:52PM +1000, Nathan Scott wrote: > Hi Nicholas, > > On Sat, Jul 02, 2005 at 10:41:08PM +0100, Nicholas Hans Simmonds wrote: > > This is a simple attempt at providing capability support through extended > > attributes. > > ...

Re: [PATCH] Filesystem capabilities support

2005-07-13 Thread Nicholas Hans Simmonds
On Wed, Jul 06, 2005 at 02:56:52PM +1000, Nathan Scott wrote: Hi Nicholas, On Sat, Jul 02, 2005 at 10:41:08PM +0100, Nicholas Hans Simmonds wrote: This is a simple attempt at providing capability support through extended attributes. ... +#define XATTR_CAP_SET XATTR_SECURITY_PREFIX

Re: [PATCH] Filesystem capabilities support

2005-07-13 Thread Nicholas Hans Simmonds
On Wed, Jul 13, 2005 at 01:51:46PM -0400, Horst von Brand wrote: Nicholas Hans Simmonds [EMAIL PROTECTED] wrote: Sorry, my earlier reply seems to have gotten lost somewhere. I've been pondering this issue for some time and am still not sure what's the best answer. I've attached a small

Re: [PATCH] Filesystem capabilities support

2005-07-07 Thread Nicholas Hans Simmonds
On Wed, Jul 06, 2005 at 02:56:52PM +1000, Nathan Scott wrote: > Hi Nicholas, > > On Sat, Jul 02, 2005 at 10:41:08PM +0100, Nicholas Hans Simmonds wrote: > > This is a simple attempt at providing capability support through extended > > attributes. > > ...

Re: [PATCH] Filesystem capabilities support

2005-07-07 Thread Nicholas Hans Simmonds
On Wed, Jul 06, 2005 at 02:56:52PM +1000, Nathan Scott wrote: Hi Nicholas, On Sat, Jul 02, 2005 at 10:41:08PM +0100, Nicholas Hans Simmonds wrote: This is a simple attempt at providing capability support through extended attributes. ... +#define XATTR_CAP_SET XATTR_SECURITY_PREFIX

Re: [PATCH] Filesystem capabilities support

2005-07-05 Thread Nicholas Hans Simmonds
On Sunday 03 July 2005 00:01, Alexey Dobriyan wrote: > On Sunday 03 July 2005 01:41, Nicholas Hans Simmonds wrote: > > This is a simple attempt at providing capability support through > > extended > > attributes. Setting security.cap_set to contain a struct > > cap_x

Re: [PATCH] Filesystem capabilities support

2005-07-05 Thread Nicholas Hans Simmonds
On Sunday 03 July 2005 00:01, Alexey Dobriyan wrote: On Sunday 03 July 2005 01:41, Nicholas Hans Simmonds wrote: This is a simple attempt at providing capability support through extended attributes. Setting security.cap_set to contain a struct cap_xattr_data which defines the desired