Re: [PATCH v2] selftest: txtimestamp: fix net ns entry logic

2020-07-22 Thread Paolo Pisati
On Tue, Jul 21, 2020 at 6:26 PM Willem de Bruijn wrote: > > Fixes: cda261f421ba ("selftests: add txtimestamp kselftest") > > Acked-by: Willem de Bruijn Besides, is it just me or this test fails frequently? I've been running it on 5.4.x, 5.7.x and 5.8-rcX and it often fails: ... USR:

[PATCH v2] selftest: txtimestamp: fix net ns entry logic

2020-07-21 Thread Paolo Pisati
According to 'man 8 ip-netns', if `ip netns identify` returns an empty string, there's no net namespace associated with current PID: fix the net ns entrance logic. Signed-off-by: Paolo Pisati --- tools/testing/selftests/net/txtimestamp.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] selftests: txtimestamp: tear down setup() 'tc' and 'ip' env on EXIT

2020-07-21 Thread Paolo Pisati
modify. Signed-off-by: Paolo Pisati --- tools/testing/selftests/net/txtimestamp.sh | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tools/testing/selftests/net/txtimestamp.sh b/tools/testing/selftests/net/txtimestamp.sh index eea6f5193693..77f29cabff87 100755 --- a/tools/testing

[PATCH v2] selftests: net: ip_defrag: modprobe missing nf_defrag_ipv6 support

2020-07-16 Thread Paolo Pisati
': No such file or directory $ sudo modprobe nf_defrag_ipv6 $ ls -la /proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh -rw-r--r-- 1 root root 0 Jul 14 12:34 /proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh Signed-off-by: Paolo Pisati --- tools/testing/selftests/net/ip_defrag.sh | 2 ++ 1 file

Re: [PATCH] selftests: net: ip_defrag: modprobe missing nf_defrag_ipv6 support

2020-07-16 Thread Paolo Pisati
On Thu, Jul 16, 2020 at 5:38 PM Jakub Kicinski wrote: > > I don't think modprobe fails when code is built in. > > $ sudo modprobe pstore > $ echo $? > 0 > $ grep CONFIG_PSTORE= /boot/config-5.7.8-200.fc32.x86_64 > CONFIG_PSTORE=y > $ lsmod | grep pstore > $ Ah, i didn't know - i'll send a V2

Re: [PATCH] selftests: net: ip_defrag: modprobe missing nf_defrag_ipv6 support

2020-07-16 Thread Paolo Pisati
On Thu, Jul 16, 2020 at 3:01 AM Jakub Kicinski wrote: > > Any reason you add this command before set -e ? > > It seems we want the script to fail if module can't be loaded. Cause if CONFIG_NF_DEFRAG_IPV6=y, the script would unnecessarily fail. -- bye, p.

[PATCH] selftests: fib_nexthop_multiprefix: fix cleanup() netns deletion

2020-07-14 Thread Paolo Pisati
n-zero return code, make kselftests fail (even if the test itself is fine): ... not ok 34 selftests: net: fib_nexthop_multiprefix.sh # exit=1 ... Signed-off-by: Paolo Pisati --- tools/testing/selftests/net/fib_nexthop_multiprefix.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] selftests: net: ip_defrag: modprobe missing nf_defrag_ipv6 support

2020-07-14 Thread Paolo Pisati
': No such file or directory $ sudo modprobe nf_defrag_ipv6 $ ls -la /proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh -rw-r--r-- 1 root root 0 Jul 14 12:34 /proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh Signed-off-by: Paolo Pisati --- tools/testing/selftests/net/ip_defrag.sh | 2 ++ 1 file

Re: msm8996: sdhci-msm: apq8096-db820c sdhci fails to init - "Timeout waiting for hardware interrupt."

2019-10-11 Thread Paolo Pisati
On Fri, Oct 11, 2019 at 02:47:05PM +0200, Loic Poulain wrote: > > No dice, same exact problem. > > > > But the patch is present downstream[1]: > > > > commit c26727f853308dc4a6645dad09e9565429f8604f > > Author: Loic Poulain > > Date: Wed Dec 12 17:51:48 2018 +0100 > > > > arm64: dts:

Re: msm8996: sdhci-msm: apq8096-db820c sdhci fails to init - "Timeout waiting for hardware interrupt."

2019-10-11 Thread Paolo Pisati
On Fri, Oct 11, 2019 at 02:01:30AM -0400, Brian Masney wrote: > I encountered that same error working on the Nexus 5 support upstream. > Here's the fix: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=03864e57770a9541e7ff3990bacf2d9a2fffcd5d No dice, same exact

Re: msm8996: sdhci-msm: apq8096-db820c sdhci fails to init - "Timeout waiting for hardware interrupt."

2019-10-10 Thread Paolo Pisati
On Thu, Oct 10, 2019 at 4:36 PM Jeffrey Hugo wrote: > > I'm using sdhci-msm on msm8998, so its not completely broken upstream. > > What speed card are you trying to use? Sandisk SDHC 4 - i forgot to mention that the sd slot / card works fine when using the qcomlt-4.14 branch[1], so it's

msm8996: sdhci-msm: apq8096-db820c sdhci fails to init - "Timeout waiting for hardware interrupt."

2019-10-10 Thread Paolo Pisati
Sdhci consistenlty fails to initialize (and thus work) on my apq8096-db820c. The issue is present since v5.0[*] mainline up to latest v5.4-rc2, using defconfig and: CONFIG_SCSI_UFS_QCOM=y CONFIG_PHY_QCOM_QMP=y CONFIG_PHY_QCOM_UFS=y CONFIG_ATL1C=y but can be 100% reproduced with a clean

[PATCH 2/2] bpf, selftest: fix checksum value for test #13

2019-07-11 Thread Paolo Pisati
From: Paolo Pisati Signed-off-by: Paolo Pisati --- tools/testing/selftests/bpf/verifier/array_access.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/verifier/array_access.c b/tools/testing/selftests/bpf/verifier/array_access.c index

[PATCH 0/2] [RESEND] Fold checksum at the end of bpf_csum_diff and fix

2019-07-11 Thread Paolo Pisati
From: Paolo Pisati After applying patch 0001, all checksum implementations i could test (x86-64, arm64 and arm), now agree on the return value. Patch 0002 fix the expected return value for test #13: i did the calculation manually, and it correspond. Unfortunately, after applying patch 0001

[PATCH 1/2] bpf: bpf_csum_diff: fold the checksum before returning the value

2019-07-11 Thread Paolo Pisati
From: Paolo Pisati With this change, bpf_csum_diff behave homogeneously among different checksum calculation code / csum_partial() (tested on x86-64, arm64 and arm). Signed-off-by: Paolo Pisati --- net/core/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core

[PATCH 0/2] Fold checksum at the end of bpf_csum_diff and fix

2019-07-11 Thread Paolo Pisati
From: Paolo Pisati After applying patch 0001, all checksum implementations i could test (x86-64, arm64 and arm), now agree on the return value. Patch 0002 fix the expected return value for test #13: i did the calculation manually, and it correspond. Unfortunately, after applying patch 0001

[PATCH 2/2] bpf, selftest: fix checksum value for test #13

2019-07-11 Thread Paolo Pisati
From: Paolo Pisati Signed-off-by: Paolo Pisati --- tools/testing/selftests/bpf/verifier/array_access.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/verifier/array_access.c b/tools/testing/selftests/bpf/verifier/array_access.c index

[PATCH 1/2] bpf: bpf_csum_diff: fold the checksum before returning the value

2019-07-11 Thread Paolo Pisati
From: Paolo Pisati With this change, bpf_csum_diff behave homogeneously among different checksum calculation code / csum_partial() (tested on x86-64, arm64 and arm). Signed-off-by: Paolo Pisati --- net/core/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core

Re: msm8996: qcom-qmp: apq8096-db820c fails to boot, reset back to fastboot and locks up

2019-06-13 Thread Paolo Pisati
On Wed, Jun 12, 2019 at 06:20:48PM +0200, Niklas Cassel wrote: > > Can you still reproduce the reboot? --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi @@ -447,12 +447,12 @@ }; pcie@608000 { -

Re: msm8996: qcom-qmp: apq8096-db820c fails to boot, reset back to fastboot and locks up

2019-06-12 Thread Paolo Pisati
On Wed, Jun 12, 2019 at 03:17:35PM +0200, Niklas Cassel wrote: > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c > > b/drivers/phy/qualcomm/phy-qcom-qmp.c > > index cd91b4179b10..22352e3b0ec5 100644 > > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > >

msm8996: qcom-qmp: apq8096-db820c fails to boot, reset back to fastboot and locks up

2019-06-10 Thread Paolo Pisati
>From time to time, my apq8096-db820c fails to boot to userspace, reset back to fastboot and locks up: to easily reproduce the issue, i'm boot looping using a cron job with a 1 min reboot entry on the board while leaving a "while 1; do fastboot boot boot.img; done" on the host pc. The issue is

Re: [PATCH] [stable, netdev 4.4+] lan78xx: make sure RX_ADDRL & RX_ADDRH regs are always up to date

2018-11-09 Thread Paolo Pisati
On Thu, Nov 08, 2018 at 10:49:04AM -0500, Sasha Levin wrote: > > Can you confirm it actually works on 4.4? Yes, built and tested on 4.4.y: Tested-by: Paolo Pisati -- bye, p.

Re: [PATCH] [stable, netdev 4.4+] lan78xx: make sure RX_ADDRL & RX_ADDRH regs are always up to date

2018-11-09 Thread Paolo Pisati
On Thu, Nov 08, 2018 at 10:49:04AM -0500, Sasha Levin wrote: > > Can you confirm it actually works on 4.4? Yes, built and tested on 4.4.y: Tested-by: Paolo Pisati -- bye, p.

Re: 4.19-rcX: WARN_ON() arch/arm64/kernel/setup.c:271 reserve_memblock_reserved_regions

2018-10-09 Thread Paolo Pisati
On Mon, Oct 08, 2018 at 05:03:27PM +0100, James Morse wrote: > But! DT's that have this reserved-but-not-memory are already out there, so we > should work around this in the kernel. Ack, thanks for the explanation. -- bye, p.

Re: 4.19-rcX: WARN_ON() arch/arm64/kernel/setup.c:271 reserve_memblock_reserved_regions

2018-10-09 Thread Paolo Pisati
On Mon, Oct 08, 2018 at 05:03:27PM +0100, James Morse wrote: > But! DT's that have this reserved-but-not-memory are already out there, so we > should work around this in the kernel. Ack, thanks for the explanation. -- bye, p.

4.19-rcX: WARN_ON() arch/arm64/kernel/setup.c:271 reserve_memblock_reserved_regions

2018-10-08 Thread Paolo Pisati
This on my dragonboard 410c: ... [0.170657] WARNING: CPU: 2 PID: 1 at arch/arm64/kernel/setup.c:271 reserve_memblock_reserved_regions+0xd4/0x150 [0.170666] Modules linked in: [0.170680] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 4.19.0-rc7-dirty #3 [0.170687] Hardware name:

4.19-rcX: WARN_ON() arch/arm64/kernel/setup.c:271 reserve_memblock_reserved_regions

2018-10-08 Thread Paolo Pisati
This on my dragonboard 410c: ... [0.170657] WARNING: CPU: 2 PID: 1 at arch/arm64/kernel/setup.c:271 reserve_memblock_reserved_regions+0xd4/0x150 [0.170666] Modules linked in: [0.170680] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 4.19.0-rc7-dirty #3 [0.170687] Hardware name:

[PATCH] ARM: tango: register pm ops only if running on tango hw

2018-08-22 Thread Paolo Pisati
In a multiplatform kernel, avoid invoking hardware specific pm ops, when running on a different SOC. Signed-off-by: Paolo Pisati --- arch/arm/mach-tango/pm.c| 5 + arch/arm/mach-tango/setup.c | 7 +++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-tango

[PATCH] ARM: tango: register pm ops only if running on tango hw

2018-08-22 Thread Paolo Pisati
In a multiplatform kernel, avoid invoking hardware specific pm ops, when running on a different SOC. Signed-off-by: Paolo Pisati --- arch/arm/mach-tango/pm.c| 5 + arch/arm/mach-tango/setup.c | 7 +++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-tango

Re: [PATCH v10 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-04-05 Thread Paolo Pisati
On Thu, Apr 05, 2018 at 10:12:05AM -0500, Alan Tull wrote: > On Tue, Apr 3, 2018 at 2:02 PM, Paolo Pisati <p.pis...@gmail.com> wrote: > > Hi Paolo, > > Looks good, except that I have to fix up the calls to > fpga_mgr_register/unregister since my API changes didn't go in

Re: [PATCH v10 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-04-05 Thread Paolo Pisati
On Thu, Apr 05, 2018 at 10:12:05AM -0500, Alan Tull wrote: > On Tue, Apr 3, 2018 at 2:02 PM, Paolo Pisati wrote: > > Hi Paolo, > > Looks good, except that I have to fix up the calls to > fpga_mgr_register/unregister since my API changes didn't go in. I've > fixe

[PATCH v10 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2018-04-03 Thread Paolo Pisati
Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati <p.pis...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> Acked-by: Alan Tull <at...@kernel.org>

[PATCH v10 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2018-04-03 Thread Paolo Pisati
Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati Acked-by: Rob Herring Acked-by: Moritz Fischer Acked-by: Alan Tull --- .../bindings/fpga/lattice-machxo2-spi.txt | 29 ++ 1 file

[PATCH v10 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-04-03 Thread Paolo Pisati
This patch adds support to the FPGA manager for programming MachXO2 device’s internal flash memory, via slave SPI. Signed-off-by: Paolo Pisati <p.pis...@gmail.com> --- drivers/fpga/Kconfig | 7 + drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c

[PATCH v10 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-04-03 Thread Paolo Pisati
This patch adds support to the FPGA manager for programming MachXO2 device’s internal flash memory, via slave SPI. Signed-off-by: Paolo Pisati --- drivers/fpga/Kconfig | 7 + drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c | 413

[PATCH v10 0/2] fpga: Lattice MachXO2 Slave SPI FPGA Manager support

2018-04-03 Thread Paolo Pisati
slave mode with varying bus speed. Changes since v9: * implemented machxo2_spi_state() Paolo Pisati (2): dt: bindings: fpga: add lattice machxo2 slave spi binding description fpga: lattice machxo2: Add Lattice MachXO2 support .../bindings/fpga/lattice-machxo2-spi.txt | 29 ++ drivers

[PATCH v10 0/2] fpga: Lattice MachXO2 Slave SPI FPGA Manager support

2018-04-03 Thread Paolo Pisati
slave mode with varying bus speed. Changes since v9: * implemented machxo2_spi_state() Paolo Pisati (2): dt: bindings: fpga: add lattice machxo2 slave spi binding description fpga: lattice machxo2: Add Lattice MachXO2 support .../bindings/fpga/lattice-machxo2-spi.txt | 29 ++ drivers

Re: [PATCH v9 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-04-02 Thread Paolo Pisati
On Mon, Apr 02, 2018 at 10:39:04AM -0500, Alan Tull wrote: > On Mon, Apr 2, 2018 at 10:13 AM, Paolo Pisati <p.pis...@gmail.com> wrote: > > Hi Paolo, > > Thanks for making the changes I asked for. Except... is there a > reason to not get state in machxo2_spi_state

Re: [PATCH v9 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-04-02 Thread Paolo Pisati
On Mon, Apr 02, 2018 at 10:39:04AM -0500, Alan Tull wrote: > On Mon, Apr 2, 2018 at 10:13 AM, Paolo Pisati wrote: > > Hi Paolo, > > Thanks for making the changes I asked for. Except... is there a > reason to not get state in machxo2_spi_state? I love your attention for th

[PATCH v9 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2018-04-02 Thread Paolo Pisati
Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati <p.pis...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> Acked-by: Alan Tull <at...@kernel.org>

[PATCH v9 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2018-04-02 Thread Paolo Pisati
Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati Acked-by: Rob Herring Acked-by: Moritz Fischer Acked-by: Alan Tull --- .../bindings/fpga/lattice-machxo2-spi.txt | 29 ++ 1 file

[PATCH v9 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-04-02 Thread Paolo Pisati
This patch adds support to the FPGA manager for programming MachXO2 device’s internal flash memory, via slave SPI. Signed-off-by: Paolo Pisati <p.pis...@gmail.com> --- drivers/fpga/Kconfig | 7 + drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c

[PATCH v9 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-04-02 Thread Paolo Pisati
This patch adds support to the FPGA manager for programming MachXO2 device’s internal flash memory, via slave SPI. Signed-off-by: Paolo Pisati --- drivers/fpga/Kconfig | 7 + drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c | 405

[PATCH v9 0/2] fpga: Lattice MachXO2 Slave SPI FPGA Manager support

2018-04-02 Thread Paolo Pisati
slave mode with varying bus speed. Changes since v8: * style fixes pointed out by Alan * rebase on the new fpga_mgr_register() API Paolo Pisati (2): dt: bindings: fpga: add lattice machxo2 slave spi binding description fpga: lattice machxo2: Add Lattice MachXO2 support .../bindings/fpga/lattice

[PATCH v9 0/2] fpga: Lattice MachXO2 Slave SPI FPGA Manager support

2018-04-02 Thread Paolo Pisati
slave mode with varying bus speed. Changes since v8: * style fixes pointed out by Alan * rebase on the new fpga_mgr_register() API Paolo Pisati (2): dt: bindings: fpga: add lattice machxo2 slave spi binding description fpga: lattice machxo2: Add Lattice MachXO2 support .../bindings/fpga/lattice

Re: [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-03-29 Thread Paolo Pisati
On Wed, Mar 28, 2018 at 03:03:42PM -0500, Alan Tull wrote: > On Wed, Mar 28, 2018 at 11:26 AM, Alan Tull <at...@kernel.org> wrote: > > On Fri, Mar 23, 2018 at 7:27 AM, Paolo Pisati <p.pis...@gmail.com> wrote: > > > > Hi Paolo, > > One more thing.

Re: [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-03-29 Thread Paolo Pisati
On Wed, Mar 28, 2018 at 03:03:42PM -0500, Alan Tull wrote: > On Wed, Mar 28, 2018 at 11:26 AM, Alan Tull wrote: > > On Fri, Mar 23, 2018 at 7:27 AM, Paolo Pisati wrote: > > > > Hi Paolo, > > One more thing. The api for registering a FPGA manager is changing. > It

[PATCH 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2018-03-23 Thread Paolo Pisati
Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati <p.pis...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> Acked-by: Alan Tull <at...@kernel.org>

[PATCH 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2018-03-23 Thread Paolo Pisati
Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati Acked-by: Rob Herring Acked-by: Moritz Fischer Acked-by: Alan Tull --- .../bindings/fpga/lattice-machxo2-spi.txt | 29 ++ 1 file

[PATCH 0/2 v8] Lattice MachXO2 Slave SPI FPGA Manager support

2018-03-23 Thread Paolo Pisati
slave mode with varying bus speed. Changes since v7: * misc style fixes, among which: * static const u8 cmd[] * #ifdef DEBUG ... #endif reorder * introduction of get_err_string() * direct returns to reduce line count * indentation Paolo Pisati (2): dt: bindings: fpga: add lattice machxo2

[PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-03-23 Thread Paolo Pisati
This patch adds support to the FPGA manager for programming MachXO2 device’s internal flash memory, via slave SPI. Signed-off-by: Paolo Pisati <p.pis...@gmail.com> --- drivers/fpga/Kconfig | 8 + drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c

[PATCH 0/2 v8] Lattice MachXO2 Slave SPI FPGA Manager support

2018-03-23 Thread Paolo Pisati
slave mode with varying bus speed. Changes since v7: * misc style fixes, among which: * static const u8 cmd[] * #ifdef DEBUG ... #endif reorder * introduction of get_err_string() * direct returns to reduce line count * indentation Paolo Pisati (2): dt: bindings: fpga: add lattice machxo2

[PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-03-23 Thread Paolo Pisati
This patch adds support to the FPGA manager for programming MachXO2 device’s internal flash memory, via slave SPI. Signed-off-by: Paolo Pisati --- drivers/fpga/Kconfig | 8 + drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c | 388

Re: [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-03-22 Thread Paolo Pisati
On Wed, Mar 21, 2018 at 11:04:52AM -0700, Joe Perches wrote: > > static const u8 cmd[] > here and everywhere else as all the tx_buf assignments > of cmd are to const void * Ok > Instead of multiple declarations of dump_status_reg > it's frequently nicer to use a style like > > static void

Re: [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-03-22 Thread Paolo Pisati
On Wed, Mar 21, 2018 at 11:04:52AM -0700, Joe Perches wrote: > > static const u8 cmd[] > here and everywhere else as all the tx_buf assignments > of cmd are to const void * Ok > Instead of multiple declarations of dump_status_reg > it's frequently nicer to use a style like > > static void

[PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-03-21 Thread Paolo Pisati
This patch adds support to the FPGA manager for programming MachXO2 device’s internal flash memory, via slave SPI. Signed-off-by: Paolo Pisati <p.pis...@gmail.com> --- drivers/fpga/Kconfig | 8 + drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c

[PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-03-21 Thread Paolo Pisati
This patch adds support to the FPGA manager for programming MachXO2 device’s internal flash memory, via slave SPI. Signed-off-by: Paolo Pisati --- drivers/fpga/Kconfig | 8 + drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c | 405

[PATCH 0/2 v7] Lattice MachXO2 Slave SPI FPGA Manager support

2018-03-21 Thread Paolo Pisati
slave mode with varying bus speed. Changes since v6: * added the SPDX boilerplate * switched to pr_debug() and renamed MACHXO2_DEBUG to DEBUG Paolo Pisati (2): dt: bindings: fpga: add lattice machxo2 slave spi binding description fpga: lattice machxo2: Add Lattice MachXO2 support .../bindings

[PATCH 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2018-03-21 Thread Paolo Pisati
Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati <p.pis...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> Acked-by: Alan Tull <at...@kernel.org>

[PATCH 0/2 v7] Lattice MachXO2 Slave SPI FPGA Manager support

2018-03-21 Thread Paolo Pisati
slave mode with varying bus speed. Changes since v6: * added the SPDX boilerplate * switched to pr_debug() and renamed MACHXO2_DEBUG to DEBUG Paolo Pisati (2): dt: bindings: fpga: add lattice machxo2 slave spi binding description fpga: lattice machxo2: Add Lattice MachXO2 support .../bindings

[PATCH 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2018-03-21 Thread Paolo Pisati
Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati Acked-by: Rob Herring Acked-by: Moritz Fischer Acked-by: Alan Tull --- .../bindings/fpga/lattice-machxo2-spi.txt | 29 ++ 1 file

Re: [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-03-19 Thread Paolo Pisati
On Fri, Mar 16, 2018 at 09:26:54AM -0700, Moritz Fischer wrote: > > > > +static enum fpga_mgr_states machxo2_spi_state(struct fpga_manager *mgr) > > +{ > > + return FPGA_MGR_STATE_UNKNOWN; > > +} > > To understand this correctly: Further up you have a way to determine the > state you're in, but

Re: [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-03-19 Thread Paolo Pisati
On Fri, Mar 16, 2018 at 09:26:54AM -0700, Moritz Fischer wrote: > > > > +static enum fpga_mgr_states machxo2_spi_state(struct fpga_manager *mgr) > > +{ > > + return FPGA_MGR_STATE_UNKNOWN; > > +} > > To understand this correctly: Further up you have a way to determine the > state you're in, but

[PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-03-16 Thread Paolo Pisati
This patch adds support to the FPGA manager for programming MachXO2 device’s internal flash memory, via slave SPI. Signed-off-by: Paolo Pisati <p.pis...@gmail.com> --- drivers/fpga/Kconfig | 8 + drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c

[PATCH 0/2 v6] Lattice MachXO2 Slave SPI FPGA Manager support

2018-03-16 Thread Paolo Pisati
() at the end, but that, sometimes, resulted in the REFRESH command to fail with a CMD_ERR, depending on the SPI bus speed) Paolo Pisati (2): dt: bindings: fpga: add lattice machxo2 slave spi binding description fpga: lattice machxo2: Add Lattice MachXO2 support .../bindings/fpga/lattice-machxo2

[PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-03-16 Thread Paolo Pisati
This patch adds support to the FPGA manager for programming MachXO2 device’s internal flash memory, via slave SPI. Signed-off-by: Paolo Pisati --- drivers/fpga/Kconfig | 8 + drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c | 410

[PATCH 0/2 v6] Lattice MachXO2 Slave SPI FPGA Manager support

2018-03-16 Thread Paolo Pisati
() at the end, but that, sometimes, resulted in the REFRESH command to fail with a CMD_ERR, depending on the SPI bus speed) Paolo Pisati (2): dt: bindings: fpga: add lattice machxo2 slave spi binding description fpga: lattice machxo2: Add Lattice MachXO2 support .../bindings/fpga/lattice-machxo2

[PATCH 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2018-03-16 Thread Paolo Pisati
Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati <p.pis...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> --- .../bindings/fpga/lattice-machxo2-spi.txt | 29 ++ 1 file

[PATCH 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2018-03-16 Thread Paolo Pisati
Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati Acked-by: Rob Herring --- .../bindings/fpga/lattice-machxo2-spi.txt | 29 ++ 1 file changed, 29 insertions(+) create mode 100644

Re: [PATCH v3] scripts/package: snap-pkg target

2017-12-06 Thread Paolo Pisati
On Wed, Dec 6, 2017 at 11:36 AM, Masahiro Yamada wrote: > Just one question to Paolo: > > If some change like firmware removal happens in the future, > patching for snapcraft is necessary? > (i.e. users are required to upgrade snapcraft from --edge ?) > > I

Re: [PATCH v3] scripts/package: snap-pkg target

2017-12-06 Thread Paolo Pisati
On Wed, Dec 6, 2017 at 11:36 AM, Masahiro Yamada wrote: > Just one question to Paolo: > > If some change like firmware removal happens in the future, > patching for snapcraft is necessary? > (i.e. users are required to upgrade snapcraft from --edge ?) > > I guess the answer is yes,

Re: [PATCH v3] scripts/package: snap-pkg target

2017-12-05 Thread Paolo Pisati
On Fri, Dec 1, 2017 at 12:15 AM, Jim Davis wrote: > > If I run /snap/bin/snapcraft --version now on that Ubuntu 16.04 VM I > am getting 2.36+git2.ae61453. Yep, the edge channel follows the bleeding edge: $ snap info snapcraft ... channels: stable:2.35

Re: [PATCH v3] scripts/package: snap-pkg target

2017-12-05 Thread Paolo Pisati
On Fri, Dec 1, 2017 at 12:15 AM, Jim Davis wrote: > > If I run /snap/bin/snapcraft --version now on that Ubuntu 16.04 VM I > am getting 2.36+git2.ae61453. Yep, the edge channel follows the bleeding edge: $ snap info snapcraft ... channels: stable:2.35(794) 53MB classic

Re: [PATCH v3] scripts/package: snap-pkg target

2017-12-05 Thread Paolo Pisati
On Fri, Dec 1, 2017 at 1:03 PM, Riku Voipio wrote: > > Since you are already patching snapcraft for this, why not embed the > whole support in snapcraft? Eg something like snapcraft --kernel > /path/to/kernel > > The key advantage you'll get is being able to support old

Re: [PATCH v3] scripts/package: snap-pkg target

2017-12-05 Thread Paolo Pisati
On Fri, Dec 1, 2017 at 1:03 PM, Riku Voipio wrote: > > Since you are already patching snapcraft for this, why not embed the > whole support in snapcraft? Eg something like snapcraft --kernel > /path/to/kernel > > The key advantage you'll get is being able to support old kernel versions too.

Re: [PATCH v3] scripts/package: snap-pkg target

2017-11-29 Thread Paolo Pisati
On Wed, Nov 29, 2017 at 8:33 AM, Masahiro Yamada wrote: > > Worked for me too, > after updating snapcraft. > > > Is it really impossible to check the snapcraft version? > What is the minimum version? 2.35 ? The minimum version is 2.35+ - what is about to become

Re: [PATCH v3] scripts/package: snap-pkg target

2017-11-29 Thread Paolo Pisati
On Wed, Nov 29, 2017 at 8:33 AM, Masahiro Yamada wrote: > > Worked for me too, > after updating snapcraft. > > > Is it really impossible to check the snapcraft version? > What is the minimum version? 2.35 ? The minimum version is 2.35+ - what is about to become 2.36 anytime soon now. -- bye,

Re: [PATCH v3] scripts/package: snap-pkg target

2017-11-29 Thread Paolo Pisati
PM, Jim Davis <jim.ep...@gmail.com> wrote: > On Tue, Nov 28, 2017 at 10:14 AM, Paolo Pisati > <paolo.pis...@canonical.com> wrote: >> On Mon, Nov 27, 2017 at 7:33 PM, Jim Davis <jim.ep...@gmail.com> wrote: >>> >>> With this patch applied to the 4

Re: [PATCH v3] scripts/package: snap-pkg target

2017-11-29 Thread Paolo Pisati
PM, Jim Davis wrote: > On Tue, Nov 28, 2017 at 10:14 AM, Paolo Pisati > wrote: >> On Mon, Nov 27, 2017 at 7:33 PM, Jim Davis wrote: >>> >>> With this patch applied to the 4.14 kernel source, and running make >>> snap-pkg on a Ubuntu 16.04 VM with the lat

Re: [PATCH v3] scripts/package: snap-pkg target

2017-11-28 Thread Paolo Pisati
On Mon, Nov 27, 2017 at 7:33 PM, Jim Davis wrote: > > With this patch applied to the 4.14 kernel source, and running make > snap-pkg on a Ubuntu 16.04 VM with the latest 16.04 kernel config > file, I ran into > > Traceback (most recent call last): > File

Re: [PATCH v3] scripts/package: snap-pkg target

2017-11-28 Thread Paolo Pisati
On Mon, Nov 27, 2017 at 7:33 PM, Jim Davis wrote: > > With this patch applied to the 4.14 kernel source, and running make > snap-pkg on a Ubuntu 16.04 VM with the latest 16.04 kernel config > file, I ran into > > Traceback (most recent call last): > File "/usr/lib/python3.5/shutil.py", line

[PATCH v3] scripts/package: snap-pkg target

2017-11-27 Thread Paolo Pisati
is to carry the Linux kernel during the creation of a system image, eg. Ubuntu Core, and its subsequent upgrades. For more information on snap packages: https://snapcraft.io/docs/ Signed-off-by: Paolo Pisati <paolo.pis...@canonical.com> --- Changes since v2: - use a tarball to instead of c

[PATCH v3] scripts/package: snap-pkg target

2017-11-27 Thread Paolo Pisati
is to carry the Linux kernel during the creation of a system image, eg. Ubuntu Core, and its subsequent upgrades. For more information on snap packages: https://snapcraft.io/docs/ Signed-off-by: Paolo Pisati --- Changes since v2: - use a tarball to instead of cloning the src tree via git - set

Re: [PATCH v2] scripts/package: snap-pkg target

2017-11-27 Thread Paolo Pisati
On Wed, Sep 20, 2017 at 11:28 AM, Masahiro Yamada wrote: >> @@ -0,0 +1,14 @@ >> +name: kernel >> +version: KERNELRELEASE >> +summary: Linux kernel >> +description: The upstream Linux kernel >> +grade: stable >> +confinement: strict >> +type: kernel >> + >> +parts:

Re: [PATCH v2] scripts/package: snap-pkg target

2017-11-27 Thread Paolo Pisati
On Wed, Sep 20, 2017 at 11:28 AM, Masahiro Yamada wrote: >> @@ -0,0 +1,14 @@ >> +name: kernel >> +version: KERNELRELEASE >> +summary: Linux kernel >> +description: The upstream Linux kernel >> +grade: stable >> +confinement: strict >> +type: kernel >> + >> +parts: >> + kernel: >> +plugin:

[PATCH v2] scripts/package: snap-pkg target

2017-09-12 Thread Paolo Pisati
is to carry the Linux kernel during the creation of a system image, eg. Ubuntu Core, and its subsequent upgrades. For more information on snap packages: https://snapcraft.io/docs/ Signed-off-by: Paolo Pisati <paolo.pis...@canonical.com> --- Changes since v1: - slightly improve the mes

[PATCH v2] scripts/package: snap-pkg target

2017-09-12 Thread Paolo Pisati
is to carry the Linux kernel during the creation of a system image, eg. Ubuntu Core, and its subsequent upgrades. For more information on snap packages: https://snapcraft.io/docs/ Signed-off-by: Paolo Pisati --- Changes since v1: - slightly improve the messaging --- .gitignore

Re: [PATCH] scripts/package: snap-pkg target

2017-09-08 Thread Paolo Pisati
Apologise for the late reply. On Wed, Jul 19, 2017 at 2:02 AM, Jim Davis wrote: > > Once I fed the snap into ubuntu-image, after hunting down a plausible > model file, I did get an image file that booted under qemu. I guess > if you're in the know about snap (and I don't

Re: [PATCH] scripts/package: snap-pkg target

2017-09-08 Thread Paolo Pisati
Apologise for the late reply. On Wed, Jul 19, 2017 at 2:02 AM, Jim Davis wrote: > > Once I fed the snap into ubuntu-image, after hunting down a plausible > model file, I did get an image file that booted under qemu. I guess > if you're in the know about snap (and I don't include myself in that

Re: [PATCH] scripts/package: snap-pkg target

2017-07-11 Thread Paolo Pisati
On Mon, Jul 10, 2017 at 6:46 PM, Jim Davis wrote: >> >> For more information on snap packages: https://snapcraft.io/docs/ > > Is this something a user could do with the existing deb target, and > then running deb2snap? No, the kernel snap is a special case, it requires

Re: [PATCH] scripts/package: snap-pkg target

2017-07-11 Thread Paolo Pisati
On Mon, Jul 10, 2017 at 6:46 PM, Jim Davis wrote: >> >> For more information on snap packages: https://snapcraft.io/docs/ > > Is this something a user could do with the existing deb target, and > then running deb2snap? No, the kernel snap is a special case, it requires communication with the

[PATCH] scripts/package: snap-pkg target

2017-07-10 Thread Paolo Pisati
is to carry the Linux kernel during the creation of a system image, eg. Ubuntu Core, and it's subsequent upgrades. For more information on snap packages: https://snapcraft.io/docs/ Signed-off-by: Paolo Pisati <paolo.pis...@canonical.com> --- .gitignore | 5 + s

[PATCH] scripts/package: snap-pkg target

2017-07-10 Thread Paolo Pisati
is to carry the Linux kernel during the creation of a system image, eg. Ubuntu Core, and it's subsequent upgrades. For more information on snap packages: https://snapcraft.io/docs/ Signed-off-by: Paolo Pisati --- .gitignore | 5 + scripts/package/Makefile | 14

[PATCH 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2017-07-06 Thread Paolo Pisati
Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati <p.pis...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> --- .../bindings/fpga/lattice-machxo2-spi.txt | 29 ++ 1 file

[PATCH 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2017-07-06 Thread Paolo Pisati
Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati Acked-by: Rob Herring --- .../bindings/fpga/lattice-machxo2-spi.txt | 29 ++ 1 file changed, 29 insertions(+) create mode 100644

[PATCH v5 0/2] Lattice MachXO2 Slave SPI FPGA Manager support

2017-07-06 Thread Paolo Pisati
v4: * rebased on 3.12 Paolo Pisati (2): dt: bindings: fpga: add lattice machxo2 slave spi binding description fpga: lattice machxo2: Add Lattice MachXO2 support .../bindings/fpga/lattice-machxo2-spi.txt | 29 ++ drivers/fpga/Kconfig | 7 + drivers

[PATCH v5 0/2] Lattice MachXO2 Slave SPI FPGA Manager support

2017-07-06 Thread Paolo Pisati
v4: * rebased on 3.12 Paolo Pisati (2): dt: bindings: fpga: add lattice machxo2 slave spi binding description fpga: lattice machxo2: Add Lattice MachXO2 support .../bindings/fpga/lattice-machxo2-spi.txt | 29 ++ drivers/fpga/Kconfig | 7 + drivers

[PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2017-07-06 Thread Paolo Pisati
This patch adds support to the FPGA manager for programming MachXO2 device’s internal flash memory, via slave SPI. Signed-off-by: Paolo Pisati <p.pis...@gmail.com> --- drivers/fpga/Kconfig | 7 ++ drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c

[PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2017-07-06 Thread Paolo Pisati
This patch adds support to the FPGA manager for programming MachXO2 device’s internal flash memory, via slave SPI. Signed-off-by: Paolo Pisati --- drivers/fpga/Kconfig | 7 ++ drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c | 298

[PATCH v4 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2017-06-26 Thread Paolo Pisati
This patch adds support to the FPGA manager for programming MachXO2 device’s internal flash memory, via slave SPI. Signed-off-by: Paolo Pisati <p.pis...@gmail.com> --- drivers/fpga/Kconfig | 7 ++ drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c

  1   2   3   >