Re: [PATCH tip/core/rcu 1/4] rcu: Expedite deboost in case of deferred quiescent state

2021-01-27 Thread Paul E. McKenney
On Wed, Jan 27, 2021 at 03:05:24PM +0800, Boqun Feng wrote: > On Tue, Jan 26, 2021 at 08:40:24PM -0800, Paul E. McKenney wrote: > > On Wed, Jan 27, 2021 at 10:42:35AM +0800, Boqun Feng wrote: > > > Hi Paul, > > > > > > On Tue, Jan 19, 2021 at 08:32:

Re: [PATCH tip/core/rcu 1/4] rcu: Expedite deboost in case of deferred quiescent state

2021-01-26 Thread Paul E. McKenney
On Wed, Jan 27, 2021 at 10:42:35AM +0800, Boqun Feng wrote: > Hi Paul, > > On Tue, Jan 19, 2021 at 08:32:33PM -0800, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > Historically, a task that has been subjected to RCU priority boosting is &g

Re: [PATCH 8/8] rcu: deprecate "all" option to rcu_nocbs=

2021-01-26 Thread Paul E. McKenney
eople out there are using it currently, but since it > > is in an __init area anyway, it isn't worth losing sleep over. > > > > Cc: Yury Norov > > Cc: Peter Zijlstra > > Cc: "Paul E. McKenney" > > Cc: Josh Triplett > > Signed-off-by: Paul Gortm

Re: [PATCH 2/2] kcsan: Switch to KUNIT_CASE_PARAM for parameterized tests

2021-01-26 Thread Paul E. McKenney
On Tue, Jan 26, 2021 at 12:35:47PM +0800, David Gow wrote: > On Thu, Jan 14, 2021 at 12:06 AM Marco Elver wrote: > > > > Since KUnit now support parameterized tests via KUNIT_CASE_PARAM, update > > KCSAN's test to switch to it for parameterized tests. This simplifies > > parameterized tests and

Re: [PATCH] s390: allow reschedule on syscall restart

2021-01-26 Thread Paul E. McKenney
On Tue, Jan 26, 2021 at 09:25:53PM +1100, Stephen Rothwell wrote: > Hi all, > > On Tue, 26 Jan 2021 07:59:51 +0100 Christian Borntraeger > wrote: > > > > On 21.01.21 15:39, Sven Schnelle wrote: > > > Commit 845f44e8ef28 ("sched: Report local wake up on resched blind zone > > > within idle

Re: [PATCH] rcu-tasks: rectify kernel-doc for struct rcu_tasks

2021-01-25 Thread Paul E. McKenney
On Mon, Jan 25, 2021 at 08:41:05AM +0100, Lukas Bulwahn wrote: > The command 'find ./kernel/rcu/ | xargs ./scripts/kernel-doc -none' > reported an issue with the kernel-doc of struct rcu_tasks. > > Rectify the kernel-doc, such that no issues remain for ./kernel/rcu/. > > Signed-off-by: Lukas

Re: [PATCH] rcutorture: replace the function name with %s

2021-01-23 Thread Paul E. McKenney
On Sat, Jan 23, 2021 at 05:54:17PM +0800, Stephen Zhang wrote: > Better to replace the function name with %s in case of changes. > > Signed-off-by: Stephen Zhang I queued both for the v5.13 merge window with the usual wordsmithing, thank you!

Re: rcu-torture: Internal error: Oops: 96000006

2021-01-22 Thread Paul E. McKenney
On Fri, Jan 22, 2021 at 09:16:38PM +0530, Naresh Kamboju wrote: > On Fri, 22 Jan 2021 at 21:07, Paul E. McKenney wrote: > > > > On Fri, Jan 22, 2021 at 03:21:07PM +0530, Naresh Kamboju wrote: > > > On Fri, 22 Jan 2021 at 03:13, Paul E. McKenney wrote: > > > >

Re: [PATCH 0/9] tools/nolibc: fix build issues on aarch64 after unistd cleanup

2021-01-22 Thread Paul E. McKenney
On Fri, Jan 22, 2021 at 12:25:42PM +, Mark Rutland wrote: > On Fri, Jan 22, 2021 at 04:03:26AM -0800, Paul E. McKenney wrote: > > On Thu, Jan 21, 2021 at 11:11:17AM +, Mark Rutland wrote: > > > > [ . . . ] > > > > > I've given this a spin atop v

Re: rcu-torture: Internal error: Oops: 96000006

2021-01-22 Thread Paul E. McKenney
On Fri, Jan 22, 2021 at 03:21:07PM +0530, Naresh Kamboju wrote: > On Fri, 22 Jan 2021 at 03:13, Paul E. McKenney wrote: > > > > On Thu, Jan 21, 2021 at 09:31:10PM +, Will Deacon wrote: > > > On Thu, Jan 21, 2021 at 10:55:21AM -0800, Paul E. McKenney wrote: > >

Re: [RFC][PATCH 4/7] smp: Optimize send_call_function_single_ipi()

2021-01-22 Thread Paul E. McKenney
On Fri, Jan 22, 2021 at 09:31:37AM +0100, Peter Zijlstra wrote: > On Thu, Jan 21, 2021 at 04:20:12PM -0800, Paul E. McKenney wrote: > > > > --- > > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > > > index 368749008ae8..2c8d4c3e341e 100644 > > >

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-22 Thread Paul E. McKenney
On Fri, Jan 22, 2021 at 12:17:33PM +0100, Sebastian Andrzej Siewior wrote: > On 2021-01-20 13:54:03 [-0800], Paul E. McKenney wrote: > > > > +// Record ptr in a page managed by krcp, with the > > > > pre-krc_this_cpu_lock() > > > > +// state specified by f

Re: [RFC PATCH 0/7] preempt: Tune preemption flavour on boot v4

2021-01-22 Thread Paul E. McKenney
On Mon, Jan 18, 2021 at 03:12:15PM +0100, Frederic Weisbecker wrote: > Hi, > > Here is a new version of the feature that can select the preempt flavour > on boot time. Note that it doesn't entirely mimic the actual real > config-based preemption flavours, because at least preempt-RCU >

Re: [PATCH 0/9] tools/nolibc: fix build issues on aarch64 after unistd cleanup

2021-01-22 Thread Paul E. McKenney
On Thu, Jan 21, 2021 at 11:11:17AM +, Mark Rutland wrote: [ . . . ] > I've given this a spin atop v5.11-rc4, building natively on arm64 on a > Debian 10.7 system, and with the whole series applied I'm able to run > the rcutorture kvm.sh script without issue (the CONFIG warnings are >

Re: [RFC][PATCH 4/7] smp: Optimize send_call_function_single_ipi()

2021-01-21 Thread Paul E. McKenney
On Thu, Jan 21, 2021 at 05:56:53PM +0100, Peter Zijlstra wrote: > On Wed, May 27, 2020 at 07:12:36PM +0200, Peter Zijlstra wrote: > > Subject: rcu: Allow for smp_call_function() running callbacks from idle > > > > Current RCU hard relies on smp_call_function() callbacks running from > > interrupt

Re: [PATCH] s390: allow reschedule on syscall restart

2021-01-21 Thread Paul E. McKenney
On Fri, Jan 22, 2021 at 08:32:49AM +1100, Stephen Rothwell wrote: > Hi all, > > On Thu, 21 Jan 2021 15:39:26 +0100 Sven Schnelle wrote: > > > > Commit 845f44e8ef28 ("sched: Report local wake up on resched blind zone > > within idle loop") from next-20210121 causes a warning because s390 > >

Re: rcu-torture: Internal error: Oops: 96000006

2021-01-21 Thread Paul E. McKenney
On Thu, Jan 21, 2021 at 09:31:10PM +, Will Deacon wrote: > On Thu, Jan 21, 2021 at 10:55:21AM -0800, Paul E. McKenney wrote: > > On Thu, Jan 21, 2021 at 10:37:21PM +0530, Naresh Kamboju wrote: > > > While running rcu-torture test on qemu_arm64 and arm64 Juno-r2 device &

Re: [PATCH RFC cpumask] Allow "all", "none", and "last" in cpumask strings

2021-01-21 Thread Paul E. McKenney
On Thu, Jan 21, 2021 at 08:57:25AM -0800, Paul E. McKenney wrote: > On Wed, Jan 20, 2021 at 11:11:48PM -0800, Yury Norov wrote: > > On Wed, Jan 6, 2021 at 12:49 AM Yury Norov wrote: > > > > > > On Tue, Jan 5, 2021 at 4:48 PM Paul E. McKenney > &g

Re: [PATCH 0/9] tools/nolibc: fix build issues on aarch64 after unistd cleanup

2021-01-21 Thread Paul E. McKenney
On Thu, Jan 21, 2021 at 09:17:14PM +0100, Willy Tarreau wrote: > On Thu, Jan 21, 2021 at 11:54:32AM -0800, Paul E. McKenney wrote: > > > > It would be great if this could be applied soon so that it's possible to > > > > use the rcutorture scripts without applying loca

Re: [PATCH -v3 0/9] sched: Fix hot-unplug regression

2021-01-21 Thread Paul E. McKenney
On Thu, Jan 21, 2021 at 11:17:02AM +0100, Peter Zijlstra wrote: > Hi, > > Some cautious optimism lets me post v3 of these patches. They (knock on wood) > fix the regression introduced by commit: > > 1cf12e08bc4d ("sched/hotplug: Consolidate task migration on CPU unplug") > > These patches

Re: [PATCH 0/9] tools/nolibc: fix build issues on aarch64 after unistd cleanup

2021-01-21 Thread Paul E. McKenney
On Thu, Jan 21, 2021 at 03:18:09PM +0100, Willy Tarreau wrote: > On Thu, Jan 21, 2021 at 11:11:17AM +, Mark Rutland wrote: > > So FWIW: > > > > Tested-by: Mark Rutland [arm64] Thank you all! > Perfect, thanks! Paul, may I let you copy-paste the tested-by yourself ? > If you prefer I'm fine

Re: [PATCH] rcu: Release per-cpu krcp page cache when CPU going offline

2021-01-21 Thread Paul E. McKenney
On Thu, Jan 21, 2021 at 02:49:49PM +0800, qiang.zh...@windriver.com wrote: > From: Zqiang > > If CPUs go offline, the corresponding krcp's page cache can > not be use util the CPU come back online, or maybe the CPU > will never go online again, this commit therefore free krcp's > page cache when

Re: rcu-torture: Internal error: Oops: 96000006

2021-01-21 Thread Paul E. McKenney
On Thu, Jan 21, 2021 at 10:37:21PM +0530, Naresh Kamboju wrote: > While running rcu-torture test on qemu_arm64 and arm64 Juno-r2 device > the following kernel crash noticed. This started happening from Linux next > next-20210111 tag to next-20210121. > > metadata: > git branch: master > git

Re: [PATCH RFC cpumask] Allow "all", "none", and "last" in cpumask strings

2021-01-21 Thread Paul E. McKenney
On Wed, Jan 20, 2021 at 11:11:48PM -0800, Yury Norov wrote: > On Wed, Jan 6, 2021 at 12:49 AM Yury Norov wrote: > > > > On Tue, Jan 5, 2021 at 4:48 PM Paul E. McKenney wrote: > > > > > > Hello! > > > > > > This series allows "all&

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-21 Thread Paul E. McKenney
On Thu, Jan 21, 2021 at 02:35:10PM +0100, Uladzislau Rezki wrote: > On Wed, Jan 20, 2021 at 01:54:03PM -0800, Paul E. McKenney wrote: > > On Wed, Jan 20, 2021 at 08:57:57PM +0100, Sebastian Andrzej Siewior wrote: [ . . . ] > > > so if bnode is NULL you could retry get_ca

Re: [PATCH 3/3] kvfree_rcu: use migrate_disable/enable()

2021-01-20 Thread Paul E. McKenney
> raw_spin_unlock_irqrestore() will reschedule if the flag is set, > local_irq_restore() will not. Good catch, thank you! This one is already in mainline, so I queued the following patch. Thanx, Paul --

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-20 Thread Paul E. McKenney
; > Single-argument kvfree_rcu() therefore uses GFP_KERNEL|__GFP_RETRY_MAYFAIL > > to allow limited sleeping within the memory allocator. > > > > [ paulmck: Add add_ptr_to_bulk_krc_lock header comment per Michal Hocko. ] > > Signed-off-by: Uladzislau R

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-20 Thread Paul E. McKenney
sleeping within the memory allocator. > > [ paulmck: Add add_ptr_to_bulk_krc_lock header comment per Michal Hocko. ] > Signed-off-by: Uladzislau Rezki (Sony) > Signed-off-by: Paul E. McKenney Queued all three for review and testing, thank you!

[PATCH tip/core/rcu 0/4] Fix RCU priority boosting

2021-01-19 Thread Paul E. McKenney
Hello! This series fixes a bug in which an RCU-priority-boosted task can stay boosted for some time after it has exited its RCU read-side critical section. This bug arose during the RCU flavor consolidation effort. The patches are as follows: 1. Expedite deboost in case of deferred

rcutorture initrd/nolibc build on ARMv8?

2021-01-19 Thread Paul E. McKenney
Hello, Willy, Some people are having trouble running rcutorture on ARMv8. They get things like this from the nolibc build of initrd: https://paste.debian.net/1181762/ The nolibc.h file says this: /* Some archs (at least aarch64) don't expose the regular syscalls anymore by * default, either

Re: [x86/mce] 7bb39313cd: netperf.Throughput_tps -4.5% regression

2021-01-18 Thread Paul E. McKenney
On Sun, Jan 17, 2021 at 12:09:21AM +0800, Feng Tang wrote: > On Sat, Jan 16, 2021 at 07:34:26AM -0800, Paul E. McKenney wrote: > > On Sat, Jan 16, 2021 at 11:52:51AM +0800, Feng Tang wrote: > > > Hi Boris, > > > > > > On Tue, Jan 12, 2021 at 03:14:38PM +0100, B

Re: [PATCH 0/8] sched: Fix hot-unplug regressions

2021-01-17 Thread Paul E. McKenney
On Sat, Jan 16, 2021 at 07:48:59AM -0800, Paul E. McKenney wrote: > On Sat, Jan 16, 2021 at 12:30:33PM +0100, Peter Zijlstra wrote: > > Hi, > > > > These patches (no longer 4), seems to fix all the hotplug regressions as per > > nearly a 100 18*SRCU-P runs over-night

Re: [PATCH 0/8] sched: Fix hot-unplug regressions

2021-01-16 Thread Paul E. McKenney
On Sat, Jan 16, 2021 at 12:30:33PM +0100, Peter Zijlstra wrote: > Hi, > > These patches (no longer 4), seems to fix all the hotplug regressions as per > nearly a 100 18*SRCU-P runs over-night. Nice!!! > I did clean up the patches, so possibly I wrecked it again. I've started new > runs and will

Re: [x86/mce] 7bb39313cd: netperf.Throughput_tps -4.5% regression

2021-01-16 Thread Paul E. McKenney
On Sat, Jan 16, 2021 at 11:52:51AM +0800, Feng Tang wrote: > Hi Boris, > > On Tue, Jan 12, 2021 at 03:14:38PM +0100, Borislav Petkov wrote: > > On Tue, Jan 12, 2021 at 10:21:09PM +0800, kernel test robot wrote: > > > > > > Greeting, > > > > > > FYI, we noticed a -4.5% regression of

Re: [PATCH 0/8] sched: Fix hot-unplug regressions

2021-01-16 Thread Paul E. McKenney
On Sat, Jan 16, 2021 at 04:25:58PM +0100, Peter Zijlstra wrote: > On Sat, Jan 16, 2021 at 12:30:33PM +0100, Peter Zijlstra wrote: > > Hi, > > > > These patches (no longer 4), seems to fix all the hotplug regressions as per > > nearly a 100 18*SRCU-P runs over-night. > > > > I did clean up the

Re: [PATCH] kcsan: Add missing license and copyright headers

2021-01-15 Thread Paul E. McKenney
On Sat, Jan 16, 2021 at 12:21:53AM +0100, Marco Elver wrote: > On Fri, 15 Jan 2021 at 22:58, Paul E. McKenney wrote: > > > This one seemed straightforward and I heard no objections to the previous > > two-patch series, so I queued them for the v5.13 merge window, thank y

Re: [PATCH] kcsan: Add missing license and copyright headers

2021-01-15 Thread Paul E. McKenney
On Fri, Jan 15, 2021 at 06:09:53PM +0100, Marco Elver wrote: > Adds missing license and/or copyright headers for KCSAN source files. > > Signed-off-by: Marco Elver This one seemed straightforward and I heard no objections to the previous two-patch series, so I queued them for the v5.13 merge

Re: [PATCH] rcu: better document kfree_rcu()

2021-01-15 Thread Paul E. McKenney
On Thu, Jan 14, 2021 at 12:36:19PM +0100, Uladzislau Rezki wrote: > On Thu, Jan 14, 2021 at 08:22:02AM +0100, Mauro Carvalho Chehab wrote: > > After changeset 5130b8fd0690 ("rcu: Introduce kfree_rcu() single-argument > > macro"), > > kernel-doc now emits two warnings: > > > >

Re: [PATCH -rcu] rculist: Replace reference to atomic_ops.rst

2021-01-15 Thread Paul E. McKenney
On Sat, Jan 16, 2021 at 12:11:45AM +0900, Akira Yokosawa wrote: > >From f92cae321e9a42a1d4bc8a2d5d1a2cd62ab35410 Mon Sep 17 00:00:00 2001 > From: Akira Yokosawa > Date: Fri, 15 Jan 2021 23:39:03 +0900 > Subject: [PATCH -rcu] rculist: Replace reference to atomic_ops.rst > > atomic_ops.rst was

Re: [PATCH] sched/core: Print out straggler tasks in sched_cpu_dying()

2021-01-15 Thread Paul E. McKenney
On Thu, Jan 14, 2021 at 09:13:17AM -0800, Paul E. McKenney wrote: > On Thu, Jan 14, 2021 at 03:52:56PM +, Valentin Schneider wrote: > > On 14/01/21 07:22, Paul E. McKenney wrote: > > > If someone can identify Lai's series to me, I would be happy to give it > > >

Re: [PATCH] sched/core: Print out straggler tasks in sched_cpu_dying()

2021-01-14 Thread Paul E. McKenney
On Thu, Jan 14, 2021 at 03:52:56PM +, Valentin Schneider wrote: > On 14/01/21 07:22, Paul E. McKenney wrote: > > If someone can identify Lai's series to me, I would be happy to give it > > a try as well. All I see are workqueue-specific patches and patches > > contribut

Re: [PATCH] sched/core: Print out straggler tasks in sched_cpu_dying()

2021-01-14 Thread Paul E. McKenney
On Thu, Jan 14, 2021 at 10:37:35AM +, Valentin Schneider wrote: > On 13/01/21 16:36, Paul E. McKenney wrote: > > On Thu, Jan 14, 2021 at 12:15:24AM +, Valentin Schneider wrote: > >> On 13/01/21 14:02, Paul E. McKenney wrote: > >> Thanks for giving it a spin! I th

Re: [RFC PATCH 6/8] sched: Report local wake up on resched blind zone within idle loop

2021-01-14 Thread Paul E. McKenney
On Thu, Jan 14, 2021 at 11:46:06AM +, Chris Wilson wrote: > Quoting Frederic Weisbecker (2021-01-09 02:05:34) > > +void noinstr sched_resched_local_assert_allowed(void) > > +{ > > + if (this_rq()->resched_local_allow) > > + return; > > + > > + /* > > +* Idle

Re: [PATCH -rcu] tools/memory-model: Remove reference to atomic_ops.rst

2021-01-14 Thread Paul E. McKenney
On Thu, Jan 14, 2021 at 11:40:26PM +0900, Akira Yokosawa wrote: > >From 1d7642add7f74ca307f1bf70569e23edf8b1a023 Mon Sep 17 00:00:00 2001 > From: Akira Yokosawa > Date: Thu, 14 Jan 2021 23:09:07 +0900 > Subject: [PATCH -rcu] tools/memory-model: Remove reference to atomic_ops.rst > >

Re: [PATCH 17/18] drivers: Remove CONFIG_OPROFILE support

2021-01-14 Thread Paul E. McKenney
e support. > > Suggested-by: Christoph Hellwig > Suggested-by: Linus Torvalds > Signed-off-by: Viresh Kumar For the RCU update: Acked-by: Paul E. McKenney > --- > Documentation/RCU/NMI-RCU.rst | 3 +- > .../admin-guide/kernel-parameters.txt |

Re: [rcu:rcu/next] BUILD SUCCESS WITH WARNING f81f6edb74f27c5c8917d20a2bc128aca39aae11

2021-01-13 Thread Paul E. McKenney
On Thu, Jan 14, 2021 at 09:38:47AM +0800, Rong Chen wrote: > > > On 1/13/21 11:14 PM, Paul E. McKenney wrote: > > On Wed, Jan 13, 2021 at 08:24:24PM +0800, kernel test robot wrote: > > > tree/branch: > > > https://git.kernel.org/pub/scm/linux/kernel/git/paulm

Re: [PATCH] sched/core: Print out straggler tasks in sched_cpu_dying()

2021-01-13 Thread Paul E. McKenney
On Thu, Jan 14, 2021 at 12:15:24AM +, Valentin Schneider wrote: > On 13/01/21 14:02, Paul E. McKenney wrote: > > > > Given that I am not seeing much sched_cpu_dying(), this patch didn't > > produce any output. (I will try other configurations.) > > Thanks fo

Re: [PATCH] sched/core: Print out straggler tasks in sched_cpu_dying()

2021-01-13 Thread Paul E. McKenney
On Wed, Jan 13, 2021 at 06:31:41PM +, Valentin Schneider wrote: > Since commit > > 1cf12e08bc4d ("sched/hotplug: Consolidate task migration on CPU unplug") > > tasks are expected to move themselves out of a out-going CPU. For most > tasks this will be done automagically via BALANCE_PUSH,

Re: [PATCH 3/4] workqueue: Tag bound workers with KTHREAD_IS_PER_CPU

2021-01-13 Thread Paul E. McKenney
On Wed, Jan 13, 2021 at 06:43:57PM +, Valentin Schneider wrote: > On 13/01/21 09:52, Paul E. McKenney wrote: > > On Wed, Jan 13, 2021 at 02:16:10PM +, Valentin Schneider wrote: > >> You might be right; at this point we would still have BALANCE_PUSH set, > >>

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-13 Thread Paul E. McKenney
On Wed, Jan 13, 2021 at 07:00:33PM +0100, Borislav Petkov wrote: > On Wed, Jan 13, 2021 at 09:46:02AM -0800, Paul E. McKenney wrote: > > < Lemme trim that mail fat > > > > It seems to me that loading and unloading SGX enclaves qualifies as a > > c

Re: [PATCH 3/4] workqueue: Tag bound workers with KTHREAD_IS_PER_CPU

2021-01-13 Thread Paul E. McKenney
On Wed, Jan 13, 2021 at 02:16:10PM +, Valentin Schneider wrote: > On 13/01/21 21:28, Lai Jiangshan wrote: > > On Tue, Jan 12, 2021 at 10:51 PM Peter Zijlstra > > wrote: > >> @@ -4972,9 +4977,11 @@ static void rebind_workers(struct worker > >> * of all workers first and then clear

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-13 Thread Paul E. McKenney
On Wed, Jan 13, 2021 at 07:18:23PM +0200, Jarkko Sakkinen wrote: > On Tue, Jan 12, 2021 at 07:35:50PM +0100, Borislav Petkov wrote: > > + paulmck. > > > > On Tue, Jan 12, 2021 at 02:08:10AM +0200, Jarkko Sakkinen wrote: > > > On Tue, Jan 05, 2021 at 03:57:49PM +0100, Borislav Petkov wrote: > > >

Re: [PATCH 0/2] irq: detect slow IRQ handlers

2021-01-13 Thread Paul E. McKenney
On Wed, Jan 13, 2021 at 12:39:15PM +, Mark Rutland wrote: > On Tue, Jan 12, 2021 at 04:09:53PM -0800, Paul E. McKenney wrote: > > On Tue, Jan 12, 2021 at 01:59:48PM +, Mark Rutland wrote: > > > Hi, > > > > > > While fuzzing arm64 with Syzk

Re: [rcu:rcu/next] BUILD SUCCESS WITH WARNING f81f6edb74f27c5c8917d20a2bc128aca39aae11

2021-01-13 Thread Paul E. McKenney
On Wed, Jan 13, 2021 at 08:24:24PM +0800, kernel test robot wrote: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > rcu/next > branch HEAD: f81f6edb74f27c5c8917d20a2bc128aca39aae11 rcu: Remove spurious > instrumentation_end() in rcu_nmi_enter() > >

Re: [PATCH 19/24] doc: update rcu_dereference.rst reference

2021-01-13 Thread Paul E. McKenney
On Wed, Jan 13, 2021 at 11:59:20AM +0100, Mauro Carvalho Chehab wrote: > Changeset b00aedf978aa ("doc: Convert to rcu_dereference.txt to > rcu_dereference.rst") > renamed: Documentation/RCU/rcu_dereference.txt > to: Documentation/RCU/rcu_dereference.rst. > > Update its cross-reference

Re: [PATCH -tip V3 0/8] workqueue: break affinity initiatively

2021-01-12 Thread Paul E. McKenney
On Tue, Jan 12, 2021 at 09:14:11AM -0800, Paul E. McKenney wrote: > On Mon, Jan 11, 2021 at 01:50:52PM -0800, Paul E. McKenney wrote: > > On Mon, Jan 11, 2021 at 10:09:07AM -0800, Paul E. McKenney wrote: > > > On Mon, Jan 11, 2021 at 06:16:39PM +0100, Peter Zijlstra wrote: >

Re: [PATCH 0/2] irq: detect slow IRQ handlers

2021-01-12 Thread Paul E. McKenney
but I've tested with smaller timeout periods in the > 1 > millisecond range by overloading the host, so I'm confident that the check > works. > > Thanks, > Mark. Nice! Acked-by: Paul E. McKenney I added the patch below to add a three-second delay to the scheduling clock in

Re: linux-next: Signed-off-by missing for commits in the rcu tree

2021-01-12 Thread Paul E. McKenney
On Wed, Jan 13, 2021 at 09:03:56AM +1100, Stephen Rothwell wrote: > Hi all, > > Commits > > 32678deac9cd ("timer: Report ignored local enqueue in nohz mode") > 8beeef08bd76 ("entry: Report local wake up on resched blind zone while > resuming to user") > 7b3f45a1ad1f ("sched: Report local

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-12 Thread Paul E. McKenney
On Tue, Jan 12, 2021 at 07:35:50PM +0100, Borislav Petkov wrote: > + paulmck. > > On Tue, Jan 12, 2021 at 02:08:10AM +0200, Jarkko Sakkinen wrote: > > On Tue, Jan 05, 2021 at 03:57:49PM +0100, Borislav Petkov wrote: > > > On Wed, Dec 16, 2020 at 03:49:20PM +0200, Jarkko Sakkinen wrote: > > > >

Re: [PATCH] rcu: remove surplus instrumentation_end in rcu_nmi_enter

2021-01-12 Thread Paul E. McKenney
a495bd6 ("rcu: Mark rcu_nmi_enter() call to rcu_cleanup_after_idle() noinstr") Reported-by Neeraj Upadhyay Signed-off-by: Zhouyi Zhou Signed-off-by: Paul E. McKenney diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 63c6dba..e04e336 100644 --- a/kernel/r

Re: [PATCH] rcu: Correct cpu offline trace in rcutree_dying_cpu

2021-01-12 Thread Paul E. McKenney
the "-bgp" stands for "blocking grace period", this is at best misleading. This commit therefore switches these strings in order to correctly trace whether the outgoing cpu blocks the current grace period. Signed-off-by: Neeraj Upadhyay Signed-off-by: Paul E. Mc

Re: [PATCH -tip V3 0/8] workqueue: break affinity initiatively

2021-01-12 Thread Paul E. McKenney
On Mon, Jan 11, 2021 at 01:50:52PM -0800, Paul E. McKenney wrote: > On Mon, Jan 11, 2021 at 10:09:07AM -0800, Paul E. McKenney wrote: > > On Mon, Jan 11, 2021 at 06:16:39PM +0100, Peter Zijlstra wrote: > > > > > > While thinking more about this, I'm thinkin

[PATCH v2 clocksource] Do not mark clocks unstable due to delays

2021-01-11 Thread Paul E. McKenney
Hello! If there is a sufficient delay between reading the watchdog clock and the clock under test, the clock under test will be marked unstable through no fault of its own. This series checks for this, doing limited retries to get a good set of clock reads. If the clock is marked unstable and

Re: [PATCH -tip V3 0/8] workqueue: break affinity initiatively

2021-01-11 Thread Paul E. McKenney
On Mon, Jan 11, 2021 at 10:09:07AM -0800, Paul E. McKenney wrote: > On Mon, Jan 11, 2021 at 06:16:39PM +0100, Peter Zijlstra wrote: > > > > While thinking more about this, I'm thinking a big part of the problem > > is that we're not dinstinguishing between geni

Re: [PATCH -tip V3 0/8] workqueue: break affinity initiatively

2021-01-11 Thread Paul E. McKenney
On Mon, Jan 11, 2021 at 06:16:39PM +0100, Peter Zijlstra wrote: > > While thinking more about this, I'm thinking a big part of the problem > is that we're not dinstinguishing between geniuine per-cpu kthreads and > kthreads that just happen to be per-cpu. > > Geniuine per-cpu kthreads are

Re: lockdep splat in v5.11-rc1 involving console_sem and rq locks

2021-01-11 Thread Paul E. McKenney
On Mon, Jan 11, 2021 at 03:42:28PM +0100, Peter Zijlstra wrote: > On Tue, Jan 05, 2021 at 02:01:15PM -0800, Paul E. McKenney wrote: > > Hello! > > > > The RUDE01 rcutorture scenario (and less often, the TASKS01 scenario) > > Is: > > tools/testing/selftests/rc

Re: [PATCH -tip V3 0/8] workqueue: break affinity initiatively

2021-01-11 Thread Paul E. McKenney
umber of other bugs involving other parts of the kernel. It would be good to have a rationale for why this is safe beforehand rather than random experiment-driven changes like that added "if" condition in the patch below. Thanx, Paul --

Re: [RFC PATCH 5/8] entry: Explicitly flush pending rcuog wakeup before last rescheduling points

2021-01-10 Thread Paul E. McKenney
> > way we can avoid to do it from rcu_user_enter() with the last resort > > self-IPI hack that enforces rescheduling. > > > > Signed-off-by: Frederic Weisbecker > > Cc: Peter Zijlstra > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: Paul E.

Re: linux-next: Signed-off-by missing for commit in the rcu tree

2021-01-09 Thread Paul E. McKenney
On Sun, Jan 10, 2021 at 01:24:32PM +1100, Stephen Rothwell wrote: > Hi all, > > Commit > > cffdc9c7c24c ("EXP sched: Print list of runnable tasks in the current rq") > > is missing a Signed-off-by from its author. > > Paul, remember the rules for -next: > > You will need to ensure that the

Re: [PATCH mm,percpu_ref,rcu 1/6] mm: Add mem_dump_obj() to print source of memory block

2021-01-08 Thread Paul E. McKenney
On Fri, Jan 08, 2021 at 02:50:35PM +0100, Vlastimil Babka wrote: > On 1/6/21 2:17 AM, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > There are kernel facilities such as per-CPU reference counts that give > > error messages in generic

Re: [PATCH v4 sl-b 0/6] Export return addresses etc. for better diagnostics

2021-01-08 Thread Paul E. McKenney
On Fri, Jan 08, 2021 at 04:35:57PM +0100, Vlastimil Babka wrote: > On 1/8/21 1:26 AM, Paul E. McKenney wrote: > > On Wed, Jan 06, 2021 at 03:42:12PM -0800, Paul E. McKenney wrote: > >> On Wed, Jan 06, 2021 at 01:48:43PM -0800, Andrew Morton wrote: > >> > On Tue, 5 J

[tip: ras/core] x86/mce: Make mce_timed_out() identify holdout CPUs

2021-01-08 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the ras/core branch of tip: Commit-ID: 7bb39313cd6239e7eb95198950a02b4ad2a08316 Gitweb: https://git.kernel.org/tip/7bb39313cd6239e7eb95198950a02b4ad2a08316 Author:Paul E. McKenney AuthorDate:Wed, 23 Dec 2020 17:04:19 -08:00

Re: [PATCH RFC x86/mce] Make mce_timed_out() identify holdout CPUs

2021-01-08 Thread Paul E. McKenney
On Fri, Jan 08, 2021 at 01:31:56PM +0100, Borislav Petkov wrote: > On Thu, Jan 07, 2021 at 09:08:44AM -0800, Paul E. McKenney wrote: > > Some information is usually better than none. And I bet that failing > > hardware is capable of all sorts of tricks at all sorts of levels. ;

Re: [PATCH v4 sl-b 0/6] Export return addresses etc. for better diagnostics

2021-01-07 Thread Paul E. McKenney
On Wed, Jan 06, 2021 at 03:42:12PM -0800, Paul E. McKenney wrote: > On Wed, Jan 06, 2021 at 01:48:43PM -0800, Andrew Morton wrote: > > On Tue, 5 Jan 2021 17:16:03 -0800 "Paul E. McKenney" > > wrote: > > > > > This is v4 of the series the

Re: [PATCH RFC x86/mce] Make mce_timed_out() identify holdout CPUs

2021-01-07 Thread Paul E. McKenney
On Thu, Jan 07, 2021 at 08:07:24AM +0100, Borislav Petkov wrote: > On Wed, Jan 06, 2021 at 11:13:53AM -0800, Paul E. McKenney wrote: > > Not yet, it isn't! Well, except in -rcu. ;-) > > Of course it is - saying "This commit" in this commit's commit message &

Re: [PATCH RFC cpumask 4/5] cpumask: Add "last" alias for cpu list specifications

2021-01-07 Thread Paul E. McKenney
On Thu, Jan 07, 2021 at 03:59:42PM +0100, Peter Zijlstra wrote: > On Thu, Jan 07, 2021 at 06:47:57AM -0800, Paul E. McKenney wrote: > > > I don't really see the use of the ranges thing, CPU enumeration just > > > isn't sane like that. Also, I should really add th

Re: [PATCH RFC cpumask 4/5] cpumask: Add "last" alias for cpu list specifications

2021-01-07 Thread Paul E. McKenney
On Thu, Jan 07, 2021 at 03:18:47PM +0100, Peter Zijlstra wrote: > On Wed, Jan 06, 2021 at 01:16:50PM -0800, Yury Norov wrote: > > On Wed, Jan 6, 2021 at 1:50 AM Peter Zijlstra wrote: > > > > Aside from the comments Yury made, on how all this is better in > > > bitmap_parselist(), how about doing

Re: [PATCH RFC cpumask 4/5] cpumask: Add "last" alias for cpu list specifications

2021-01-07 Thread Paul E. McKenney
On Thu, Jan 07, 2021 at 03:18:47PM +0100, Peter Zijlstra wrote: > On Wed, Jan 06, 2021 at 01:16:50PM -0800, Yury Norov wrote: > > On Wed, Jan 6, 2021 at 1:50 AM Peter Zijlstra wrote: > > > > Aside from the comments Yury made, on how all this is better in > > > bitmap_parselist(), how about doing

Re: [PATCH RFC x86/mce] Make mce_timed_out() identify holdout CPUs

2021-01-06 Thread Paul E. McKenney
On Thu, Jan 07, 2021 at 12:26:19AM +, Luck, Tony wrote: > > Please see below for an updated patch. > > Yes. That worked: > > [ 78.946069] mce: mce_timed_out: MCE holdout CPUs (may include false > positives): 24-47,120-143 > [ 78.946151] mce: mce_timed_out: MCE holdout CPUs (may include

Re: [PATCH v4 sl-b 0/6] Export return addresses etc. for better diagnostics

2021-01-06 Thread Paul E. McKenney
On Wed, Jan 06, 2021 at 01:48:43PM -0800, Andrew Morton wrote: > On Tue, 5 Jan 2021 17:16:03 -0800 "Paul E. McKenney" > wrote: > > > This is v4 of the series the improves diagnostics by providing access > > to additional information including the return add

Re: [PATCH RFC x86/mce] Make mce_timed_out() identify holdout CPUs

2021-01-06 Thread Paul E. McKenney
On Wed, Jan 06, 2021 at 02:49:18PM -0800, Luck, Tony wrote: > On Wed, Jan 06, 2021 at 11:17:08AM -0800, Paul E. McKenney wrote: > > On Wed, Jan 06, 2021 at 06:39:30PM +, Luck, Tony wrote: > > > > The "Timeout: Not all CPUs entered broadcast exception handler" m

Re: [PATCH RFC clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-01-06 Thread Paul E. McKenney
On Wed, Jan 06, 2021 at 11:28:00AM -0500, Rik van Riel wrote: > On Tue, 2021-01-05 at 16:41 -0800, paul...@kernel.org wrote: > > > > @@ -203,7 +204,6 @@ static void > > clocksource_watchdog_inject_delay(void) > > injectfail = inject_delay_run; > > if (!(++injectfail /

Re: [PATCH RFC x86/mce] Make mce_timed_out() identify holdout CPUs

2021-01-06 Thread Paul E. McKenney
On Wed, Jan 06, 2021 at 06:39:30PM +, Luck, Tony wrote: > > The "Timeout: Not all CPUs entered broadcast exception handler" message > > will appear from time to time given enough systems, but this message does > > not identify which CPUs failed to enter the broadcast exception handler. > >

Re: [PATCH RFC x86/mce] Make mce_timed_out() identify holdout CPUs

2021-01-06 Thread Paul E. McKenney
On Wed, Jan 06, 2021 at 07:32:44PM +0100, Borislav Petkov wrote: > On Wed, Jan 06, 2021 at 09:41:02AM -0800, Paul E. McKenney wrote: > > The "Timeout: Not all CPUs entered broadcast exception handler" message > > will appear from time to time given enough syste

Re: lockdep splat in v5.11-rc1 involving console_sem and rq locks

2021-01-06 Thread Paul E. McKenney
On Wed, Jan 06, 2021 at 03:49:46PM +, Valentin Schneider wrote: > On 06/01/21 16:44, Peter Zijlstra wrote: > > On Wed, Jan 06, 2021 at 06:46:21AM -0800, Paul E. McKenney wrote: > >> What would break if I made the code dump out a few entries in the > >> runque

[PATCH RFC x86/mce] Make mce_timed_out() identify holdout CPUs

2021-01-06 Thread Paul E. McKenney
ngo Molnar Cc: "H. Peter Anvin" Cc: Cc: Reported-by: Jonathan Lemon Signed-off-by: Paul E. McKenney diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index 13d3f1c..44d2b99 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core

[PATCH memory-model 0/3] LKMM updates for v5.12

2021-01-06 Thread Paul E. McKenney
Hello! This series provides a few LKMM updates: 1. tools/memory-model: Tie acquire loads to reads-from. 2. tools/memory-model: Remove redundant initialization in litmus tests, courtesy of Akira Yokosawa. 3. tools/memory-model: Fix typo in klitmus7 compatibility table,

[PATCH kcsan 0/2] KCSAN updates for v5.12

2021-01-06 Thread Paul E. McKenney
Hello! This series provides KCSAN updates involving random32. 1. Rewrite kcsan_prandom_u32_max() without prandom_u32_state(), courtesy of Marco Elver. 2. Re-enable KCSAN instrumentation, courtesy of Marco Elver. Thanx, Paul

[PATCH tip/core/rcu 0/18] Add a torture-all acceptance-test script for v5.12

2021-01-06 Thread Paul E. McKenney
Hello! This series adds a script to run a full set of tests. My earlier practice of testing just what changed proved inappropriate for the high-distraction environment of a few months ago. 1. Do Kconfig analysis only once per scenario. 2. Add torture.sh torture-everything script. 3.

[PATCH tip/core/rcu 0/20] Torture scripting updates for v5.12

2021-01-06 Thread Paul E. McKenney
Hello! This series contains torture-test updates for the rcutorture scripting in tools/testing/selftests/rcutorture. 1. Make --kcsan specify lockdep. 2. Make kvm.sh "--dryrun sched" summarize number of batches. 3. Make kvm.sh "--dryrun sched" summarize number of builds. 4.

[PATCH tip/core/rcu 0/17] Torture-test updates for v5.12

2021-01-06 Thread Paul E. McKenney
Hello! This series provides torture-test updates, and must be applied on top of the SRCU series. 1. Add testing for RCU's global memory ordering. 2. Add debug output for wrong-CPU warning. 3. Allow summarization of verbose output. 4. Require entire stutter period be

[PATCH tip/core/rcu 0/10] SRCU updates for v5.12

2021-01-06 Thread Paul E. McKenney
Hello! This series contains SRCU updates, most notably the polling grace-period API requested by Kent Overstreet. 1. Make Tiny SRCU use multi-bit grace-period counter. 2. Provide internal interface to start a Tiny SRCU grace period. 3. Provide internal interface to start a Tree

[PATCH tip/core/rcu 0/4] Stall-warning updates for v5.12

2021-01-06 Thread Paul E. McKenney
Hello! This series enhances RCU CPU stall-warning messages. 1. Mark obtuse portion of stall warning as internal debug. 2. For RCU grace-period kthread starvation, dump last CPU it ran on. 3. Do not NMI offline CPUs. 4. Check and report missed fqs timer wakeup on RCU stall,

[PATCH tip/core/rcu 0/3] Real-time updates for v5.12

2021-01-06 Thread Paul E. McKenney
Hello! This series provides some real-time enhancements: 1. Make RCU_BOOST default on CONFIG_PREEMPT_RT, courtesy of Sebastian Andrzej Siewior. 2. Unconditionally use rcuc threads on PREEMPT_RT, courtesy of Scott Wood. 3. Enable rcu_normal_after_boot

Re: lockdep splat in v5.11-rc1 involving console_sem and rq locks

2021-01-06 Thread Paul E. McKenney
On Wed, Jan 06, 2021 at 10:52:14AM +0100, Peter Zijlstra wrote: > On Tue, Jan 05, 2021 at 02:01:15PM -0800, Paul E. McKenney wrote: > > Hello! > > > > The RUDE01 rcutorture scenario (and less often, the TASKS01 scenario) > > results in occasional lockdep splats on v5.1

[PATCH tip/core/rcu 0/21] Provide runtime switching of offloaded CPUs

2021-01-05 Thread Paul E. McKenney
Hello! Currently, it is necessary to reboot to change a given CPU between invoking its own RCU callbacks via softirq and offloading callback invocation to an rcuo kthread. This series allows CPUs that were initially offloaded to be toggled back and forth at runtime, without requiring a reboot.

[PATCH tip/core/rcu 0/6] Track callbacks on a per-segment basis

2021-01-05 Thread Paul E. McKenney
Hello! This series adds counts to the rcu_segcblist structure that track the number of callbacks in each segment, allowing RCU to distinguish between (for example) a need to get grace periods done or get callbacks invoked (or, for that matter, both). 1. Make rcu_do_batch count how many

[PATCH v4 sl-b 0/6] Export return addresses etc. for better diagnostics

2021-01-05 Thread Paul E. McKenney
Hello! This is v4 of the series the improves diagnostics by providing access to additional information including the return addresses, slab names, offsets, and sizes collected by the sl*b allocators and by vmalloc(). If the allocator is not configured to collect this information, the diagnostics

[PATCH tip/core/rcu 0/3] kfree_rcu() updates for v5.12

2021-01-05 Thread Paul E. McKenney
Hello! This series provides kfree_rcu() updates: 1. Record kvfree_call_rcu() call stack for KASAN, courtesy of Zqiang. 2. Introduce kfree_rcu() single-argument macro, courtesy of Uladzislau Rezki. 3. Eliminate the __kvfree_rcu() macro, courtesy of Uladzislau Rezki.

[PATCH tip/core/rcu 0/6] Miscellaneous fixes for v5.12

2021-01-05 Thread Paul E. McKenney
Hello! This series contains miscellaneous fixes. 1. Allow try_invoke_on_locked_down_task() with irqs disabled, courtesy of Peter Zijlstra. 2. Remove duplicate include of percpu-rwsem.h, courtesy of Wang Qing. 3. Add lockdep_assert_irqs_disabled() to rcu_sched_clock_irq()

<    1   2   3   4   5   6   7   8   9   10   >