Re: [PATCHv2 1/2] bus: arm-ccn: Enable stats for CCN-512 interconnect

2019-10-16 Thread Pawel Moll
compatible = "arm,ccn-502", }, > { .compatible = "arm,ccn-504", }, > + { .compatible = "arm,ccn-512", }, > {}, > }; > MODULE_DEVICE_TABLE(of, arm_ccn_match); Acked-by: Pawel Moll Thanks! Pawel

Re: [PATCH] bus: arm-ccn: fix module unloading Error: Removing state 147 which has instances left.

2017-10-12 Thread Pawel Moll
On Wed, 2017-10-11 at 22:33 +0100, Kim Phillips wrote: > Unregistering the driver before calling cpuhp_remove_multi_state() > removes > any remaining hotplug cpu instances so > __cpuhp_remove_state_cpuslocked() > doesn't emit this warning: Cool, thanks! I'm getting together a series of fixes

Re: [PATCH] bus: arm-ccn: fix module unloading Error: Removing state 147 which has instances left.

2017-10-12 Thread Pawel Moll
On Wed, 2017-10-11 at 22:33 +0100, Kim Phillips wrote: > Unregistering the driver before calling cpuhp_remove_multi_state() > removes > any remaining hotplug cpu instances so > __cpuhp_remove_state_cpuslocked() > doesn't emit this warning: Cool, thanks! I'm getting together a series of fixes

Re: [PATCH v2 1/2] bus: arm-ccn: Fix use of smp_processor_id() in preemptible context

2017-10-04 Thread Pawel Moll
On Wed, 2017-10-04 at 13:32 +0100, Marc Zyngier wrote: >  > > Acked-by: Pawel Moll <pawel.m...@arm.com> > >  > > I assume you'll get this merged yourself? Or do you want me to > relay > > the CCN one (I've got a couple of other small changes to the driver >

Re: [PATCH v2 1/2] bus: arm-ccn: Fix use of smp_processor_id() in preemptible context

2017-10-04 Thread Pawel Moll
On Wed, 2017-10-04 at 13:32 +0100, Marc Zyngier wrote: >  > > Acked-by: Pawel Moll > >  > > I assume you'll get this merged yourself? Or do you want me to > relay > > the CCN one (I've got a couple of other small changes to the driver > in > > the queue). &g

Re: [PATCH v2 1/2] bus: arm-ccn: Fix use of smp_processor_id() in preemptible context

2017-10-04 Thread Pawel Moll
istration, making sure that we don't race against a CPU down > operation. > > Signed-off-by: Marc Zyngier <marc.zyng...@arm.com> Acked-by: Pawel Moll <pawel.m...@arm.com> I assume you'll get this merged yourself? Or do you want me to relay the CCN one (I've got a couple of other s

Re: [PATCH v2 1/2] bus: arm-ccn: Fix use of smp_processor_id() in preemptible context

2017-10-04 Thread Pawel Moll
istration, making sure that we don't race against a CPU down > operation. > > Signed-off-by: Marc Zyngier Acked-by: Pawel Moll I assume you'll get this merged yourself? Or do you want me to relay the CCN one (I've got a couple of other small changes to the driver in the queue). Paweł I

Re: [PATCH] bus: arm-ccn: constify attribute_group structures.

2017-07-04 Thread Pawel Moll
On Mon, 2017-07-03 at 13:01 +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: >    text    data

Re: [PATCH] bus: arm-ccn: constify attribute_group structures.

2017-07-04 Thread Pawel Moll
On Mon, 2017-07-03 at 13:01 +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: >    text    data

Re: [PATCH RESEND 0/2] Add support for ARM CCN-502 interconnect

2017-06-19 Thread Pawel Moll
On Fri, 2017-06-16 at 13:39 -0700, Scott Branden wrote: > Arnd, > > Should this patchset go through the ARM maintainers? Unless something changed in the last months, these patches should go through arm-soc. Arnd is probably just waiting for me to send a pull request. And indeed shame on me that

Re: [PATCH RESEND 0/2] Add support for ARM CCN-502 interconnect

2017-06-19 Thread Pawel Moll
On Fri, 2017-06-16 at 13:39 -0700, Scott Branden wrote: > Arnd, > > Should this patchset go through the ARM maintainers? Unless something changed in the last months, these patches should go through arm-soc. Arnd is probably just waiting for me to send a pull request. And indeed shame on me that

Re: [PATCH] bus: arm-ccn: Use devm_kcalloc() in arm_ccn_probe()

2017-04-19 Thread Pawel Moll
On Wed, 2017-04-19 at 09:29 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 19 Apr 2017 09:12:43 +0200 > > Multiplications for the size determination of memory allocations > indicated that array data structures should be processed. > Thus use

Re: [PATCH] bus: arm-ccn: Use devm_kcalloc() in arm_ccn_probe()

2017-04-19 Thread Pawel Moll
On Wed, 2017-04-19 at 09:29 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 19 Apr 2017 09:12:43 +0200 > > Multiplications for the size determination of memory allocations > indicated that array data structures should be processed. > Thus use the corresponding function

Re: [PATCH 1/2] dt-bindings: arm-ccn: Add bindings info for CCN-502 compatible string

2017-02-20 Thread Pawel Moll
On Tue, 2017-02-14 at 17:48 +, Mark Rutland wrote: > On Fri, Feb 10, 2017 at 12:42:47PM -0800, Velibor Markovski wrote: > > > > Add CCN-502 to the list of supported devices by ARM CCN PMU driver. > > > > Signed-off-by: Velibor Markovski > Acked-by: Mark

Re: [PATCH 1/2] dt-bindings: arm-ccn: Add bindings info for CCN-502 compatible string

2017-02-20 Thread Pawel Moll
On Tue, 2017-02-14 at 17:48 +, Mark Rutland wrote: > On Fri, Feb 10, 2017 at 12:42:47PM -0800, Velibor Markovski wrote: > > > > Add CCN-502 to the list of supported devices by ARM CCN PMU driver. > > > > Signed-off-by: Velibor Markovski > Acked-by: Mark Rutland > > I assume Pawel will

Re: [PATCH] bus: arm-ccn: Fix module autoload

2017-02-06 Thread Pawel Moll
On Fri, 2017-02-03 at 18:31 -0300, Javier Martinez Canillas wrote: > On 01/02/2017 10:02 AM, Javier Martinez Canillas wrote: > > > > If the driver is built as a module, autoload won't work because the module > > alias information is not filled. So user-space can't match the registered > > device

Re: [PATCH] bus: arm-ccn: Fix module autoload

2017-02-06 Thread Pawel Moll
On Fri, 2017-02-03 at 18:31 -0300, Javier Martinez Canillas wrote: > On 01/02/2017 10:02 AM, Javier Martinez Canillas wrote: > > > > If the driver is built as a module, autoload won't work because the module > > alias information is not filled. So user-space can't match the registered > > device

Re: [PATCH] bus: arm-ccn: Fix module autoload

2017-02-06 Thread Pawel Moll
On Fri, 2017-02-03 at 18:31 -0300, Javier Martinez Canillas wrote: > On 01/02/2017 10:02 AM, Javier Martinez Canillas wrote: > > > > If the driver is built as a module, autoload won't work because the module > > alias information is not filled. So user-space can't match the registered > > device

Re: [PATCH] bus: arm-ccn: Fix module autoload

2017-02-06 Thread Pawel Moll
On Fri, 2017-02-03 at 18:31 -0300, Javier Martinez Canillas wrote: > On 01/02/2017 10:02 AM, Javier Martinez Canillas wrote: > > > > If the driver is built as a module, autoload won't work because the module > > alias information is not filled. So user-space can't match the registered > > device

Re: [patch V2 23/67] bus/arm-ccn: Convert to hotplug statemachine

2016-07-18 Thread Pawel Moll
an Andrzej Siewior <bige...@linutronix.de> > Cc: Arnd Bergmann <a...@arndb.de> > Cc: Dan Carpenter <dan.carpen...@oracle.com> > Cc: Linus Torvalds <torva...@linux-foundation.org> > Cc: Pawel Moll <pawel.m...@arm.com> > Cc: Peter Zijlstra <pet...@inf

Re: [patch V2 23/67] bus/arm-ccn: Convert to hotplug statemachine

2016-07-18 Thread Pawel Moll
: Arnd Bergmann > Cc: Dan Carpenter > Cc: Linus Torvalds > Cc: Pawel Moll > Cc: Peter Zijlstra > Cc: Suzuki K Poulose > Cc: Thomas Gleixner > Signed-off-by: Anna-Maria Gleixner > @@ -1316,7 +1309,6 @@ static void arm_ccn_pmu_cleanup(struct a >

Re: [patch 22/66] bus: arm-ccn: convert to hotplug statemachine

2016-07-12 Thread Pawel Moll
On Mon, 2016-07-11 at 12:28 +, Anna-Maria Gleixner wrote: > @@ -1270,9 +1262,10 @@ static int arm_ccn_pmu_init(struct arm_c >* ... and change the selection when it goes offline. > Priority is >* picked to have a chance to migrate events before perf is > notified. >*/ >

Re: [patch 22/66] bus: arm-ccn: convert to hotplug statemachine

2016-07-12 Thread Pawel Moll
On Mon, 2016-07-11 at 12:28 +, Anna-Maria Gleixner wrote: > @@ -1270,9 +1262,10 @@ static int arm_ccn_pmu_init(struct arm_c >* ... and change the selection when it goes offline. > Priority is >* picked to have a chance to migrate events before perf is > notified. >*/ >

Re: [patch 22/66] bus: arm-ccn: convert to hotplug statemachine

2016-07-12 Thread Pawel Moll
an Andrzej Siewior <bige...@linutronix.de> > Cc: Pawel Moll <pawel.m...@arm.com> > Signed-off-by: Anna-Maria Gleixner <anna-ma...@linutronix.de> Although I won't shed a tear over the notifiers going, there's a problem with this patc

Re: [patch 22/66] bus: arm-ccn: convert to hotplug statemachine

2016-07-12 Thread Pawel Moll
On Mon, 2016-07-11 at 12:28 +, Anna-Maria Gleixner wrote: > From: Sebastian Andrzej Siewior > > Install the callbacks via the state machine and let the core invoke > the callbacks on the already online CPUs. > > Signed-off-by: Sebastian Andrzej Siewior > Cc: Paw

Re: [PATCH 4/4] drivers/bus: make arm-ccn.c driver explicitly non-modular

2016-03-29 Thread Pawel Moll
On Tue, 2016-03-29 at 13:30 +0100, Will Deacon wrote: > On Tue, Mar 29, 2016 at 12:53:06PM +0100, Pawel Moll wrote: > > Dnia 2016-03-29, Tue o godzinie 12:45 +0100, Will Deacon pisze: > > > I'd much rather fix the driver to build as a module, if at all > > > possible. &g

Re: [PATCH 4/4] drivers/bus: make arm-ccn.c driver explicitly non-modular

2016-03-29 Thread Pawel Moll
On Tue, 2016-03-29 at 13:30 +0100, Will Deacon wrote: > On Tue, Mar 29, 2016 at 12:53:06PM +0100, Pawel Moll wrote: > > Dnia 2016-03-29, Tue o godzinie 12:45 +0100, Will Deacon pisze: > > > I'd much rather fix the driver to build as a module, if at all > > > possible. &g

Re: [PATCH 4/4] drivers/bus: make arm-ccn.c driver explicitly non-modular

2016-03-29 Thread Pawel Moll
Dnia 2016-03-29, Tue o godzinie 12:45 +0100, Will Deacon pisze: > I'd much rather fix the driver to build as a module, if at all > possible. > Suzuki (CC'd) is taking a look at that, so please drop this patch for > now. There's no problem with building arm-ccn.c as a module - all it's really

Re: [PATCH 4/4] drivers/bus: make arm-ccn.c driver explicitly non-modular

2016-03-29 Thread Pawel Moll
Dnia 2016-03-29, Tue o godzinie 12:45 +0100, Will Deacon pisze: > I'd much rather fix the driver to build as a module, if at all > possible. > Suzuki (CC'd) is taking a look at that, so please drop this patch for > now. There's no problem with building arm-ccn.c as a module - all it's really

Re: [PATCH v5 2/2] arm: perf: Add event descriptions

2015-10-15 Thread Pawel Moll
On Thu, 2015-10-15 at 16:42 +0100, Mark Rutland wrote: > On Thu, Oct 15, 2015 at 04:20:37PM +0100, Pawel Moll wrote: > > On Thu, 2015-10-15 at 08:15 -0700, Drew Richardson wrote: > > > On Thu, Oct 15, 2015 at 02:21:12PM +0100, Will Deacon wrote: > > > > On Tue, Oc

Re: [PATCH v5 2/2] arm: perf: Add event descriptions

2015-10-15 Thread Pawel Moll
On Thu, 2015-10-15 at 08:15 -0700, Drew Richardson wrote: > On Thu, Oct 15, 2015 at 02:21:12PM +0100, Will Deacon wrote: > > On Tue, Oct 13, 2015 at 08:36:45AM -0700, Drew Richardson wrote: > > > Add additional information about the ARM architected hardware events > > > to make counters self

Re: [PATCH v5 2/2] arm: perf: Add event descriptions

2015-10-15 Thread Pawel Moll
On Thu, 2015-10-15 at 16:42 +0100, Mark Rutland wrote: > On Thu, Oct 15, 2015 at 04:20:37PM +0100, Pawel Moll wrote: > > On Thu, 2015-10-15 at 08:15 -0700, Drew Richardson wrote: > > > On Thu, Oct 15, 2015 at 02:21:12PM +0100, Will Deacon wrote: > > > > On Tue, Oc

Re: [PATCH v5 2/2] arm: perf: Add event descriptions

2015-10-15 Thread Pawel Moll
On Thu, 2015-10-15 at 08:15 -0700, Drew Richardson wrote: > On Thu, Oct 15, 2015 at 02:21:12PM +0100, Will Deacon wrote: > > On Tue, Oct 13, 2015 at 08:36:45AM -0700, Drew Richardson wrote: > > > Add additional information about the ARM architected hardware events > > > to make counters self

Re: [PATCH 02/38] bus: arm-ccn: fix handling cpumask_any_but return value

2015-09-21 Thread Pawel Moll
> > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed-off-by: Andrzej Hajda This has been already reported and discussed: http://thread.gmane.org/gmane.linux.kernel.janitors/34058 but apparently slipped through cracks :-( therefore: Acked-by: Pawel Moll Thanks for b

Re: [PATCH 02/38] bus: arm-ccn: fix handling cpumask_any_but return value

2015-09-21 Thread Pawel Moll
> > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> This has been already reported and discussed: http://thread.gmane.org/gmane.linux.kernel.janitors/34058 but apparently slipped through cracks :-( therefore: Acked-b

Re: [PATCH 1/3] clk: versatile: Switch to assigned clock parents

2015-08-06 Thread Pawel Moll
On Wed, 2015-08-05 at 18:56 +0100, Stephen Boyd wrote: > On 08/05/2015 03:29 AM, Pawel Moll wrote: > > > > Right, that's probably my fault. The sp810 nodes appeared in the VE > > trees very early (in terms of the "DT era"), when we weren't so strict > >

Re: [PATCH 1/3] clk: versatile: Switch to assigned clock parents

2015-08-06 Thread Pawel Moll
On Wed, 2015-08-05 at 18:56 +0100, Stephen Boyd wrote: On 08/05/2015 03:29 AM, Pawel Moll wrote: Right, that's probably my fault. The sp810 nodes appeared in the VE trees very early (in terms of the DT era), when we weren't so strict about documentation. So far, it would be fairly simple

Re: [PATCH 1/3] clk: versatile: Switch to assigned clock parents

2015-08-05 Thread Pawel Moll
On Mon, 2015-08-03 at 18:55 +0100, Stephen Boyd wrote: > On 08/03/2015 07:01 AM, Pawel Moll wrote: > > On Sat, 2015-08-01 at 00:44 +0100, Stephen Boyd wrote: > >> @@ -179,6 +124,15 @@ static void __init clk_sp810_of_setup(struct > >> device_node *node) > >>

Re: [PATCH 1/3] clk: versatile: Switch to assigned clock parents

2015-08-05 Thread Pawel Moll
On Mon, 2015-08-03 at 18:55 +0100, Stephen Boyd wrote: On 08/03/2015 07:01 AM, Pawel Moll wrote: On Sat, 2015-08-01 at 00:44 +0100, Stephen Boyd wrote: @@ -179,6 +124,15 @@ static void __init clk_sp810_of_setup(struct device_node *node) sp810-timerclken[i].channel = i

Re: [PATCH 1/3] clk: versatile: Switch to assigned clock parents

2015-08-03 Thread Pawel Moll
On Sat, 2015-08-01 at 00:44 +0100, Stephen Boyd wrote: > @@ -179,6 +124,15 @@ static void __init clk_sp810_of_setup(struct device_node > *node) > sp810->timerclken[i].channel = i; > sp810->timerclken[i].hw.init = > > + /* > + * If DT isn't

Re: [PATCH 1/3] clk: versatile: Switch to assigned clock parents

2015-08-03 Thread Pawel Moll
On Sat, 2015-08-01 at 00:44 +0100, Stephen Boyd wrote: @@ -179,6 +124,15 @@ static void __init clk_sp810_of_setup(struct device_node *node) sp810-timerclken[i].channel = i; sp810-timerclken[i].hw.init = init; + /* + * If DT isn't

Re: [PATCH 24/26] clk: versatile: Convert to clk_hw based provider APIs

2015-07-31 Thread Pawel Moll
On Fri, 2015-07-31 at 18:04 +0100, Stephen Boyd wrote: > We're removing struct clk from the clk provider API, so switch > this code to using the clk_hw based provider APIs. > > Cc: Pawel Moll > Cc: Linus Walleij > Signed-off-by: Stephen Boyd > --- > drivers/clk/v

[tip:perf/core] perf tools: Fix test build error when bindir contains double slash

2015-07-31 Thread tip-bot for Pawel Moll
Commit-ID: 0927beeca5f9d1a7978f8da9c9d28647859816d3 Gitweb: http://git.kernel.org/tip/0927beeca5f9d1a7978f8da9c9d28647859816d3 Author: Pawel Moll AuthorDate: Tue, 28 Jul 2015 15:10:13 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 28 Jul 2015 13:03:49 -0300 perf tools: Fix

[tip:perf/core] perf tools: Fix test build error when bindir contains double slash

2015-07-31 Thread tip-bot for Pawel Moll
Commit-ID: 0927beeca5f9d1a7978f8da9c9d28647859816d3 Gitweb: http://git.kernel.org/tip/0927beeca5f9d1a7978f8da9c9d28647859816d3 Author: Pawel Moll pawel.m...@arm.com AuthorDate: Tue, 28 Jul 2015 15:10:13 +0100 Committer: Arnaldo Carvalho de Melo a...@redhat.com CommitDate: Tue, 28 Jul

Re: [PATCH 24/26] clk: versatile: Convert to clk_hw based provider APIs

2015-07-31 Thread Pawel Moll
On Fri, 2015-07-31 at 18:04 +0100, Stephen Boyd wrote: We're removing struct clk from the clk provider API, so switch this code to using the clk_hw based provider APIs. Cc: Pawel Moll pawel.m...@arm.com Cc: Linus Walleij linus.wall...@linaro.org Signed-off-by: Stephen Boyd sb

[PATCH v2] tools: perf: Fix test build error when bindir contains double slash

2015-07-28 Thread Pawel Moll
ir string using make's abspath function. Signed-off-by: Pawel Moll --- tools/perf/config/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index b4a9c29..e8d987a 100644 --- a/tools/perf/config/Makefile +++ b/tools/

Re: [PATCH] perf tests: Adding build test for having ending slash in double slash

2015-07-28 Thread Pawel Moll
On Tue, 2015-07-28 at 13:40 +0100, Pawel Moll wrote: > Interesting. Building from a perf-tar-src-pkg tarball works: > > $ rm -rf /tmp/krava/ && make install prefix=/tmp/krava > [...] > LINK perf > LINK libperf-gtk.so > INSTALL GTK UI > INST

Re: [PATCH] tools: perf: Avoid error message when building with no python installed

2015-07-28 Thread Pawel Moll
On Mon, 2015-07-27 at 19:36 +0100, Jiri Olsa wrote: > > @@ -150,7 +150,7 @@ ifndef NO_LIBPYTHON > >PYTHON2 := $(if $(call get-executable,python2),python2,python) > >override PYTHON := $(call get-executable-or-default,PYTHON,$(PYTHON2)) > >PYTHON2_CONFIG := \ > > -$(if $(call > >

Re: [PATCH] perf tests: Adding build test for having ending slash in double slash

2015-07-28 Thread Pawel Moll
On Mon, 2015-07-27 at 19:24 +0100, Jiri Olsa wrote: > I'm getting install error with your patch: > > [jolsa@krava perf]$ rm -rf /tmp/krava/ && make install prefix=/tmp/krava > > SNIP > > LINK perf > INSTALL binaries > INSTALL tests > install: cannot create directory ‘’: No such file

Re: [PATCH] perf tests: Adding build test for having ending slash in double slash

2015-07-28 Thread Pawel Moll
On Tue, 2015-07-28 at 13:40 +0100, Pawel Moll wrote: Interesting. Building from a perf-tar-src-pkg tarball works: $ rm -rf /tmp/krava/ make install prefix=/tmp/krava [...] LINK perf LINK libperf-gtk.so INSTALL GTK UI INSTALL binaries INSTALL tests INSTALL

[PATCH v2] tools: perf: Fix test build error when bindir contains double slash

2015-07-28 Thread Pawel Moll
function. Signed-off-by: Pawel Moll pawel.m...@arm.com --- tools/perf/config/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index b4a9c29..e8d987a 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config

Re: [PATCH] tools: perf: Avoid error message when building with no python installed

2015-07-28 Thread Pawel Moll
On Mon, 2015-07-27 at 19:36 +0100, Jiri Olsa wrote: @@ -150,7 +150,7 @@ ifndef NO_LIBPYTHON PYTHON2 := $(if $(call get-executable,python2),python2,python) override PYTHON := $(call get-executable-or-default,PYTHON,$(PYTHON2)) PYTHON2_CONFIG := \ -$(if $(call

Re: [PATCH] perf tests: Adding build test for having ending slash in double slash

2015-07-28 Thread Pawel Moll
On Mon, 2015-07-27 at 19:24 +0100, Jiri Olsa wrote: I'm getting install error with your patch: [jolsa@krava perf]$ rm -rf /tmp/krava/ make install prefix=/tmp/krava SNIP LINK perf INSTALL binaries INSTALL tests install: cannot create directory ‘’: No such file or

[PATCH] tools: perf: Fix test build error when bindir contains double slash

2015-07-27 Thread Pawel Moll
r string using make's realpath function. Signed-off-by: Pawel Moll --- tools/perf/config/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index b4a9c29..59e8376 100644 --- a/tools/perf/config/Makefile +++ b/tools/

[PATCH] tools: perf: Avoid error message when building with no python installed

2015-07-27 Thread Pawel Moll
option -c Although harmless, the message can be quite confusing and hard to track. Signed-off-by: Pawel Moll --- tools/perf/config/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index 094ddae..b4a9c29 100644

[PATCH] tools: perf: Avoid error message when building with no python installed

2015-07-27 Thread Pawel Moll
option -c Although harmless, the message can be quite confusing and hard to track. Signed-off-by: Pawel Moll pawel.m...@arm.com --- tools/perf/config/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index 094ddae

[PATCH] tools: perf: Fix test build error when bindir contains double slash

2015-07-27 Thread Pawel Moll
function. Signed-off-by: Pawel Moll pawel.m...@arm.com --- tools/perf/config/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index b4a9c29..59e8376 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config

Re: [RFC PATCH] perf: Add PERF_RECORD_SWITCH to indicate context switches

2015-06-12 Thread Pawel Moll
On Fri, 2015-06-12 at 14:28 +0100, Pawel Moll wrote: > On Fri, 2015-06-12 at 14:15 +0100, Adrian Hunter wrote: > > >>>> all 3 are already part of sample_id. > > >>> > > >>> You have to decide whether you expect to be able to use an event without &

Re: [RFC PATCH] perf: Add PERF_RECORD_SWITCH to indicate context switches

2015-06-12 Thread Pawel Moll
On Fri, 2015-06-12 at 14:15 +0100, Adrian Hunter wrote: > all 3 are already part of sample_id. > >>> > >>> You have to decide whether you expect to be able to use an event without > >>> sample_id. MMAP and MMAP2 both have pid, tid which are in sample_id, LOST > >>> has id, EXIT and FORK have

Re: [RFC PATCH] perf: Add PERF_RECORD_SWITCH to indicate context switches

2015-06-12 Thread Pawel Moll
On Fri, 2015-06-12 at 14:15 +0100, Adrian Hunter wrote: all 3 are already part of sample_id. You have to decide whether you expect to be able to use an event without sample_id. MMAP and MMAP2 both have pid, tid which are in sample_id, LOST has id, EXIT and FORK have time, all of the

Re: [RFC PATCH] perf: Add PERF_RECORD_SWITCH to indicate context switches

2015-06-12 Thread Pawel Moll
On Fri, 2015-06-12 at 14:28 +0100, Pawel Moll wrote: On Fri, 2015-06-12 at 14:15 +0100, Adrian Hunter wrote: all 3 are already part of sample_id. You have to decide whether you expect to be able to use an event without sample_id. MMAP and MMAP2 both have pid, tid which

Re: [PATCH 14/19] clk: versatile: Silence sparse warnings

2015-05-06 Thread Pawel Moll
k/versatile/clk-sp810.c:138:13: warning: symbol 'clk_sp810_of_setup' > was not declared. Should it be static? > > Cc: Pawel Moll > Signed-off-by: Stephen Boyd Acked-by: Pawel Moll > @@ -156,7 +156,7 @@ void __init clk_sp810_of_setup(struct device_node *node) >

Re: [PATCH 14/19] clk: versatile: Silence sparse warnings

2015-05-06 Thread Pawel Moll
: symbol 'clk_sp810_of_setup' was not declared. Should it be static? Cc: Pawel Moll pawel.m...@arm.com Signed-off-by: Stephen Boyd sb...@codeaurora.org Acked-by: Pawel Moll pawel.m...@arm.com @@ -156,7 +156,7 @@ void __init clk_sp810_of_setup(struct device_node *node

Re: [PATCH] tracing: Export key trace event symbols

2015-04-23 Thread Pawel Moll
On Thu, 2015-04-23 at 16:28 +0100, Pawel Moll wrote: > On Wed, 2015-04-22 at 16:36 +0100, David Ahern wrote: > > On 4/22/15 8:47 AM, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Apr 22, 2015 at 08:53:14AM -0400, Steven Rostedt escreveu: > > >> >On Tue, 21 Ap

Re: [PATCH] tracing: Export key trace event symbols

2015-04-23 Thread Pawel Moll
On Wed, 2015-04-22 at 16:36 +0100, David Ahern wrote: > On 4/22/15 8:47 AM, Arnaldo Carvalho de Melo wrote: > > Em Wed, Apr 22, 2015 at 08:53:14AM -0400, Steven Rostedt escreveu: > >> >On Tue, 21 Apr 2015 21:24:51 -0500 > >> >Ron Rechenmacher wrote: > >>> > >I've looked at the above reference

Re: [PATCH] tracing: Export key trace event symbols

2015-04-23 Thread Pawel Moll
On Thu, 2015-04-23 at 16:28 +0100, Pawel Moll wrote: On Wed, 2015-04-22 at 16:36 +0100, David Ahern wrote: On 4/22/15 8:47 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Apr 22, 2015 at 08:53:14AM -0400, Steven Rostedt escreveu: On Tue, 21 Apr 2015 21:24:51 -0500 Ron Rechenmacherr

Re: [PATCH] tracing: Export key trace event symbols

2015-04-23 Thread Pawel Moll
On Wed, 2015-04-22 at 16:36 +0100, David Ahern wrote: On 4/22/15 8:47 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Apr 22, 2015 at 08:53:14AM -0400, Steven Rostedt escreveu: On Tue, 21 Apr 2015 21:24:51 -0500 Ron Rechenmacherr...@fnal.gov wrote: I've looked at the above reference briefly

Re: [PATCH 4/6] virtio_mmio: support non-legacy balloon devices

2015-03-31 Thread Pawel Moll
On Mon, 2015-03-30 at 18:37 +0100, Michael S. Tsirkin wrote: > virtio_device_is_legacy_only is always false now, > drop the test from virtio mmio. > > Signed-off-by: Michael S. Tsirkin Slightly ironic ack ;-) after all the battle you fought for this: Acked-by: Pawel Moll Th

Re: [PATCH 4/6] virtio_mmio: support non-legacy balloon devices

2015-03-31 Thread Pawel Moll
On Mon, 2015-03-30 at 18:37 +0100, Michael S. Tsirkin wrote: virtio_device_is_legacy_only is always false now, drop the test from virtio mmio. Signed-off-by: Michael S. Tsirkin m...@redhat.com Slightly ironic ack ;-) after all the battle you fought for this: Acked-by: Pawel Moll pawel.m

Re: [PATCH 19/35 linux-next] virtio_mmio: constify of_device_id array

2015-03-23 Thread Pawel Moll
; /* Platform driver */ > > -static struct of_device_id virtio_mmio_match[] = { > +static const struct of_device_id virtio_mmio_match[] = { > { .compatible = "virtio,mmio", }, > {}, > }; Acked-by: Pawel Moll Thanks! Pawel -- To unsubscribe from thi

Re: [PATCH] virtio_mmio: generation support

2015-03-23 Thread Pawel Moll
ng we can do for version 1, so return > > generation id 0. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > > > Pawel, you mentioned you have a working virtio 1.0 > > hypervisor, can you pls confirm this works correctly? Again, belated Acked-by: Pawe

Re: [PATCH] virtio_mmio: fix endian-ness for mmio

2015-03-23 Thread Pawel Moll
(with your updated commit message) to my > pending-rebases and give him the weekend to Ack. Not that it matters any more, but a belated Acked-by: Pawel Moll Thanks, Michael, for fixing this! (although, I must admit, I haven't tested it yet - all in right time :-) Pawel -- To unsubscrib

Re: [PATCH] virtio_mmio: generation support

2015-03-23 Thread Pawel Moll
return generation id 0. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Pawel, you mentioned you have a working virtio 1.0 hypervisor, can you pls confirm this works correctly? Again, belated Acked-by: Pawel Moll pawel.m...@arm.com although not yet tested-by... Paweł

Re: [PATCH 19/35 linux-next] virtio_mmio: constify of_device_id array

2015-03-23 Thread Pawel Moll
of_device_id virtio_mmio_match[] = { +static const struct of_device_id virtio_mmio_match[] = { { .compatible = virtio,mmio, }, {}, }; Acked-by: Pawel Moll pawel.m...@arm.com Thanks! Pawel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] virtio_mmio: fix endian-ness for mmio

2015-03-23 Thread Pawel Moll
commit message) to my pending-rebases and give him the weekend to Ack. Not that it matters any more, but a belated Acked-by: Pawel Moll pawel.m...@arm.com Thanks, Michael, for fixing this! (although, I must admit, I haven't tested it yet - all in right time :-) Pawel -- To unsubscribe from

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

2015-03-05 Thread Pawel Moll
On Wed, 2015-03-04 at 00:37 +, Arun Ramamurthy wrote: > > That way you're precisely describing the way the hardware is wired up. > > And the driver simply tries to get clcdclk first, if it's defined - > > cool, set clksel to 1, if not - try hclk and set clksel to 0. If neither > > of them is

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

2015-03-05 Thread Pawel Moll
On Wed, 2015-03-04 at 00:37 +, Arun Ramamurthy wrote: That way you're precisely describing the way the hardware is wired up. And the driver simply tries to get clcdclk first, if it's defined - cool, set clksel to 1, if not - try hclk and set clksel to 0. If neither of them is present -

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

2015-03-03 Thread Pawel Moll
On Tue, 2015-03-03 at 10:02 +, Pawel Moll wrote: > On Mon, 2015-03-02 at 19:09 +, Arun Ramamurthy wrote: > > > The existing bindings intentionally avoided quoting internal registers - > > > they are supposed to describe how the hardware is wired up... > > >

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

2015-03-03 Thread Pawel Moll
On Mon, 2015-03-02 at 19:09 +, Arun Ramamurthy wrote: > > The existing bindings intentionally avoided quoting internal registers - > > they are supposed to describe how the hardware is wired up... > > > > So how about something like "arm,pl11x,tft-invert-clac"? Then the driver > > sets the bit

Re: [PATCH] video: ARM CLCD: Added support for FBIO_WAITFORVSYNC

2015-03-03 Thread Pawel Moll
On Mon, 2015-03-02 at 19:09 +, Arun Ramamurthy wrote: > On 15-03-02 08:00 AM, Pawel Moll wrote: > > On Wed, 2015-02-25 at 21:01 +, Arun Ramamurthy wrote: > >> Added ioctl and interrupt handler functions to support FBIO_WAITFORVSYNC > >> Also corrected docum

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

2015-03-03 Thread Pawel Moll
On Mon, 2015-03-02 at 19:09 +, Arun Ramamurthy wrote: The existing bindings intentionally avoided quoting internal registers - they are supposed to describe how the hardware is wired up... So how about something like arm,pl11x,tft-invert-clac? Then the driver sets the bit or not,

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

2015-03-03 Thread Pawel Moll
On Tue, 2015-03-03 at 10:02 +, Pawel Moll wrote: On Mon, 2015-03-02 at 19:09 +, Arun Ramamurthy wrote: The existing bindings intentionally avoided quoting internal registers - they are supposed to describe how the hardware is wired up... So how about something like arm,pl11x

Re: [PATCH] video: ARM CLCD: Added support for FBIO_WAITFORVSYNC

2015-03-03 Thread Pawel Moll
On Mon, 2015-03-02 at 19:09 +, Arun Ramamurthy wrote: On 15-03-02 08:00 AM, Pawel Moll wrote: On Wed, 2015-02-25 at 21:01 +, Arun Ramamurthy wrote: Added ioctl and interrupt handler functions to support FBIO_WAITFORVSYNC Also corrected documentation to make interrupts and interrupt

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

2015-03-02 Thread Pawel Moll
On Wed, 2015-02-25 at 21:01 +, Arun Ramamurthy wrote: > Added code based on linaro tree: > http://git.linaro.org/kernel/linux-linaro-stable.git > with commit id:6846e7822c4cab5a84672baace3b768c2d0db142 > at drivers/video/amba-clcd.c. This lets the driver set > certain tim2 register bits after

Re: [PATCH] video: ARM CLCD: Added support for FBIOPAN_DISPLAY and virtual y resolution

2015-03-02 Thread Pawel Moll
On Wed, 2015-02-25 at 21:01 +, Arun Ramamurthy wrote: > Added code to support FBIOPAN_DISPLAY. Also added yres_virtual > parameter to device tree to set the virtual y resolution > > Reviewed-by: Ray Jui > Reviewed-by: Scott Branden > Signed-off-by: Arun Ramamurthy > --- >

Re: [PATCH] video: ARM CLCD: Added support for FBIO_WAITFORVSYNC

2015-03-02 Thread Pawel Moll
On Wed, 2015-02-25 at 21:01 +, Arun Ramamurthy wrote: > Added ioctl and interrupt handler functions to support FBIO_WAITFORVSYNC > Also corrected documentation to make interrupts and interrupt-names > optional as they are not required properties. You may not be aware of this fact, but its the

Re: [PATCH] video: ARM CLCD: Added support for FBIOPAN_DISPLAY and virtual y resolution

2015-03-02 Thread Pawel Moll
On Wed, 2015-02-25 at 21:01 +, Arun Ramamurthy wrote: Added code to support FBIOPAN_DISPLAY. Also added yres_virtual parameter to device tree to set the virtual y resolution Reviewed-by: Ray Jui r...@broadcom.com Reviewed-by: Scott Branden sbran...@broadcom.com Signed-off-by: Arun

Re: [PATCH] video: ARM CLCD: Added support for FBIO_WAITFORVSYNC

2015-03-02 Thread Pawel Moll
On Wed, 2015-02-25 at 21:01 +, Arun Ramamurthy wrote: Added ioctl and interrupt handler functions to support FBIO_WAITFORVSYNC Also corrected documentation to make interrupts and interrupt-names optional as they are not required properties. You may not be aware of this fact, but its the

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

2015-03-02 Thread Pawel Moll
On Wed, 2015-02-25 at 21:01 +, Arun Ramamurthy wrote: Added code based on linaro tree: http://git.linaro.org/kernel/linux-linaro-stable.git with commit id:6846e7822c4cab5a84672baace3b768c2d0db142 at drivers/video/amba-clcd.c. This lets the driver set certain tim2 register bits after

Re: [RFC][PATCH 2/2] perf: Add per event clockid support

2015-02-20 Thread Pawel Moll
On Fri, 2015-02-20 at 14:29 +, Peter Zijlstra wrote: > The below patch makes the distinction between these two cases by > adding perf_event_clock() which is used for the second case. It > further makes this configurable on a per-event basis, but adds a few > sanity checks such that we cannot

Re: [RFC][PATCH 2/2] perf: Add per event clockid support

2015-02-20 Thread Pawel Moll
On Fri, 2015-02-20 at 14:29 +, Peter Zijlstra wrote: The below patch makes the distinction between these two cases by adding perf_event_clock() which is used for the second case. It further makes this configurable on a per-event basis, but adds a few sanity checks such that we cannot

Re: [PATCH 0/2] perf/x86: Add ability to sample TSC

2015-02-19 Thread Pawel Moll
On Thu, 2015-02-19 at 17:58 +, Pawel Moll wrote: > and what Adrian did, explicitly > defining possible timestamps at perf_event_attr level instead of > relating them to to posix clock ids is the way to go. No strong opinion > here. One note here: I'd rather make it "proc

Re: [PATCH 0/2] perf/x86: Add ability to sample TSC

2015-02-19 Thread Pawel Moll
On Thu, 2015-02-19 at 17:50 +, John Stultz wrote: > On Thu, Feb 19, 2015 at 9:40 AM, Adrian Hunter > wrote: > > On 19/02/2015 7:24 p.m., John Stultz wrote: > >> > >> On Thu, Feb 19, 2015 at 4:11 AM, Adrian Hunter > >> wrote: > >>> > >>> Hi > >>> > >>> With the advent of switching perf_clock

Re: [PATCH 0/2] perf/x86: Add ability to sample TSC

2015-02-19 Thread Pawel Moll
On Thu, 2015-02-19 at 17:50 +, John Stultz wrote: On Thu, Feb 19, 2015 at 9:40 AM, Adrian Hunter adrian.hun...@intel.com wrote: On 19/02/2015 7:24 p.m., John Stultz wrote: On Thu, Feb 19, 2015 at 4:11 AM, Adrian Hunter adrian.hun...@intel.com wrote: Hi With the advent of

Re: [PATCH 0/2] perf/x86: Add ability to sample TSC

2015-02-19 Thread Pawel Moll
On Thu, 2015-02-19 at 17:58 +, Pawel Moll wrote: and what Adrian did, explicitly defining possible timestamps at perf_event_attr level instead of relating them to to posix clock ids is the way to go. No strong opinion here. One note here: I'd rather make it processor trace clock, rather

Re: [PATCH RFC v5 net-next 4/6] virtio-net: add basic interrupt coalescing support

2015-02-13 Thread Pawel Moll
On Fri, 2015-02-13 at 02:52 +, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > On Tue, Feb 10, 2015 at 12:02:37PM +1030, Rusty Russell wrote: > >> Jason Wang writes: > >> > This patch enables the interrupt coalescing setting through ethtool. > >> > >> The problem is that there's

Re: [PATCH RFC v5 net-next 4/6] virtio-net: add basic interrupt coalescing support

2015-02-13 Thread Pawel Moll
On Fri, 2015-02-13 at 02:52 +, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: On Tue, Feb 10, 2015 at 12:02:37PM +1030, Rusty Russell wrote: Jason Wang jasow...@redhat.com writes: This patch enables the interrupt coalescing setting through ethtool. The problem is

Re: [PATCH v5] perf: Use monotonic clock as a source for timestamps

2015-02-03 Thread Pawel Moll
On Tue, 2015-02-03 at 08:30 +, ajh mls wrote: > There is still > > http://marc.info/?l=linux-kernel=142141223902303 Uh. I have no idea why, but I haven't got this mail at all :-( Thanks for pointing it out! Pawel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v5] perf: Use monotonic clock as a source for timestamps

2015-02-03 Thread Pawel Moll
On Tue, 2015-02-03 at 08:30 +, ajh mls wrote: There is still http://marc.info/?l=linux-kernelm=142141223902303 Uh. I have no idea why, but I haven't got this mail at all :-( Thanks for pointing it out! Pawel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [PATCH v5] perf: Use monotonic clock as a source for timestamps

2015-02-02 Thread Pawel Moll
Afternoon, Peter, On Wed, 2015-01-21 at 20:27 +, Pawel Moll wrote: > Until now, perf framework never defined the meaning of the timestamps > captured as PERF_SAMPLE_TIME sample type. The values were obtaining > from local (sched) clock, which is unavailable in userspace.

  1   2   3   4   5   6   7   8   >