Re: [PATCH v4 2/3] dt-bindings: reset: imx7: Document usage on i.MX8MQ SoCs

2019-01-23 Thread Philipp Zabel
On Thu, 2019-01-17 at 14:38 -0800, Andrey Smirnov wrote: [...] > > To be honest, I don't like these two, I'm not convinced anymore that > > they actually qualify as reset signals. To me it looks like this is > > something that the PCIe glue code should handle via syscon like i.MX6. > > Leonard,

Re: [PATCH v5 3/3] reset: imx7: Add support for i.MX8MQ IP block variant

2019-01-23 Thread Philipp Zabel
Hi Andrey, On Mon, 2019-01-21 at 18:10 -0800, Andrey Smirnov wrote: > Add bits and pieces needed to support IP block variant found on > i.MX8MQ SoCs. > > Cc: p.za...@pengutronix.de > Cc: Fabio Estevam > Cc: cphe...@gmail.com > Cc: l.st...@pengutronix.de > Cc: Leonard Crestez > Cc: "A.s. Dong"

Re: [PATCH reset-next 0/2] reset: brcmstb: Misc fixes

2019-01-23 Thread Philipp Zabel
On Tue, 2019-01-22 at 16:33 -0800, Florian Fainelli wrote: > Hi Philipp, > > These two patches fix some recent issues brought up by Paul and Randy, > feel free to squash into c196cdc7659d ("reset: Add Broadcom STB SW_INIT > reset controller driver") since this is only in reset/next and >

Re: [PATCH reset-next 2/2] reset: brcmstb: Fix 32-bit build with 64-bit resource_size_t

2019-01-23 Thread Philipp Zabel
Hi Florian, On Tue, 2019-01-22 at 16:33 -0800, Florian Fainelli wrote: > On 32-bit architectures defining resource_size_t as 64-bit (because of > PAE), we can run into a linker failure because of the modulo and the > division against resource_size(), replace the two problematic operations > with

Re: [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel

2019-01-22 Thread Philipp Zabel
On Mon, 2019-01-21 at 10:46 -0800, Steve Longerbeam wrote: > > On 1/21/19 10:43 AM, Steve Longerbeam wrote: > > > > > > On 1/21/19 3:49 AM, Philipp Zabel wrote: > > > Also ipu_smfc_disable is refcounted, so if the other CSI is capturing > > >

Re: [PATCH 4/4] media: imx: Don't register IPU subdevs/links if CSI port missing

2019-01-21 Thread Philipp Zabel
212df5 ("[media] media: Add i.MX media core driver") > > Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH 3/4] media: imx: Rename functions that add IPU-internal subdevs/links

2019-01-21 Thread Philipp Zabel
ta structure for the internal IPU subdevices. > No functional changes. > > Signed-off-by: Steve Longerbeam Acked-by: Philipp Zabel regards Philipp

Re: [PATCH 1/4] media: imx: csi: Allow unknown nearest upstream entities

2019-01-21 Thread Philipp Zabel
On Sat, 2019-01-19 at 13:45 -0800, Steve Longerbeam wrote: > On i.MX6, the nearest upstream entity to the CSI can only be the > CSI video muxes or the Synopsys DW MIPI CSI-2 receiver. > > However the i.MX53 has no CSI video muxes or a MIPI CSI-2 receiver. > So allow for the nearest upstream

Re: [PATCH v2 2/2] reset: Add Broadcom STB SW_INIT reset controller driver

2019-01-21 Thread Philipp Zabel
Hi Scott, On Wed, 2019-01-16 at 10:15 -0800, Scott Branden wrote: > On 2019-01-15 10:44 a.m., Florian Fainelli wrote: > > Add support for resetting blocks through the Linux reset controller > > subsystem when reset lines are provided through a SW_INIT-style reset > > controller on Broadcom STB

Re: [PATCH v2 1/2] dt-bindings: reset: Add document for Broadcom STB reset controller

2019-01-21 Thread Philipp Zabel
Hi Florian, On Tue, 2019-01-15 at 10:44 -0800, Florian Fainelli wrote: > Add a binding document for the Broadcom STB reset controller, also known > as SW_INIT-style reset controller. > > Signed-off-by: Florian Fainelli Thank you, both applied to reset/next. regards Philipp

Re: [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel

2019-01-21 Thread Philipp Zabel
Hi, On Fri, 2019-01-18 at 17:04 -0800, Steve Longerbeam wrote: > Disable the SMFC before disabling the IDMA channel, instead of after, > in csi_idmac_unsetup(). > > This fixes a complete system hard lockup on the SabreAuto when streaming > from the ADV7180, by repeatedly sending a stream off

Re: linux-next: build failure after merge of the imx-drm tree

2019-01-18 Thread Philipp Zabel
On Fri, 2019-01-18 at 14:19 +1100, Stephen Rothwell wrote: > Hi Lucas, > > After merging the imx-drm tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/gpu/drm/imx/imx-tve.c: At top level: > drivers/gpu/drm/imx/imx-tve.c:437:29: error: storage size of

Re: [PATCH v2 1/2] media: imx: csi: Disable CSI immediately after last EOF

2019-01-18 Thread Philipp Zabel
v, priv->eof_irq, priv); > devm_free_irq(priv->dev, priv->nfb4eof_irq, priv); > > @@ -793,9 +795,9 @@ static void csi_stop(struct csi_priv *priv) > /* stop the frame interval monitor */ > if (priv->fim) > imx_me

Re: [PATCH v4 1/3] reset: imx7: Add plubming to support multiple IP variants

2019-01-17 Thread Philipp Zabel
On Wed, 2018-12-19 at 17:06 -0800, Andrey Smirnov wrote: > In order to enable supporting i.MX8MQ with this driver, convert it to > expect variant specific bits to be passed via driver data. > > Cc: p.za...@pengutronix.de > Cc: Fabio Estevam > Cc: cphe...@gmail.com > Cc: l.st...@pengutronix.de >

Re: [PATCH v4 2/3] dt-bindings: reset: imx7: Document usage on i.MX8MQ SoCs

2019-01-17 Thread Philipp Zabel
Hi Andrey, sorry for the delay. Thank you for the update, apart from the comments below, the list now looks to be complete. On Wed, 2018-12-19 at 17:06 -0800, Andrey Smirnov wrote: > The driver now supports i.MX8MQ, so update bindings accordingly. > > Cc: p.za...@pengutronix.de > Cc: Fabio

Re: [PATCH 2/4] drm/imx: imx-ldb: add missing of_node_puts

2019-01-17 Thread Philipp Zabel
Hi Julia, On Sun, 2019-01-13 at 09:47 +0100, Julia Lawall wrote: > The device node iterators perform an of_node_get on each > iteration, so a jump out of the loop requires an of_node_put. > > Move the initialization channel->child = child; down to just > before the call to imx_ldb_register so

Re: [PATCH] media: imx-csi: Input connections to CSI should be optional

2019-01-10 Thread Philipp Zabel
rn -ENOTCONN in imx_csi_parse_endpoint() so that v4l2-fwnode > endpoint parsing will not treat an unconnected CSI input port as > an error. > > Fixes: c893500a16baf ("media: imx: csi: Register a subdev notifier") > > Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel r

Re: [PATCH v6 12/12] media: imx.rst: Update doc to reflect fixes to interlaced capture

2019-01-09 Thread Philipp Zabel
On Tue, 2019-01-08 at 16:15 -0800, Steve Longerbeam wrote: > Also add an example pipeline for unconverted capture with interweave > on SabreAuto. > > Cleanup some language in various places in the process. > > Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH v6 05/12] media: imx-csi: Input connections to CSI should be optional

2019-01-09 Thread Philipp Zabel
On Tue, 2019-01-08 at 16:15 -0800, Steve Longerbeam wrote: > Some imx platforms do not have fwnode connections to all CSI input > ports, and should not be treated as an error. This includes the > imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0. > Return -ENOTCONN in

Re: [PATCH v6 02/12] gpu: ipu-csi: Swap fields according to input/output field types

2019-01-09 Thread Philipp Zabel
d from the input frame width/height, > make sure to double height if input field type is alternate, since > in that case input height only includes lines for one field. > > Signed-off-by: Steve Longerbeam > Reviewed-by: Philipp Zabel Also Acked-by: Philipp Zabel to be merged via the media tree regards Philipp

[PATCH] MAINTAINERS: use include/linux/reset for reset controller related headers

2019-01-07 Thread Philipp Zabel
drivers that do. Signed-off-by: Philipp Zabel --- See for example https://patchwork.kernel.org/patch/10728595/ --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 32d76a90..826f7ea03f80 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12954,6 +12954,7

Re: [PATCH 2/2] reset: Add Broadcom STB SW_INIT reset controller driver

2019-01-02 Thread Philipp Zabel
Hi Florian, On Thu, 2018-12-20 at 17:34 -0800, Florian Fainelli wrote: > Add support for resetting blocks through the Linux reset controller > subsystem when reset lines are provided through a SW_INIT-style reset > controller on Broadcom STB SoCs. > > Signed-off-by: Florian Fainelli Thank you,

Re: [PATCH v5 02/12] gpu: ipu-csi: Swap fields according to input/output field types

2018-12-13 Thread Philipp Zabel
andard from the input frame width/height, > make sure to double height if input field type is alternate, since > in that case input height only includes lines for one field. > > Signed-off-by: Steve Longerbeam > --- > Changes since v4: > - Cleaned up some convoluted code i

[PATCH 0/2] reset: socfpga, sunxi: declare _reset_init functions in header files

2018-12-13 Thread Philipp Zabel
tree, I'd like to apply this to the reset/next branch before sending a pull request. regards Philipp Philipp Zabel (2): reset: sunxi: declare sun6i_reset_init in a header file reset: socfpga: declare socfpga_reset_init in a header file arch/arm/mach-socfpga/socfpga.c | 3 +-- arch/arm/mach

[PATCH 2/2] reset: socfpga: declare socfpga_reset_init in a header file

2018-12-13 Thread Philipp Zabel
Avoid declaring extern functions in c files. To make sure function definition and usage don't get out of sync, declare socfpga_reset_init in a common header. Suggested-by: Stephen Rothwell Signed-off-by: Philipp Zabel --- arch/arm/mach-socfpga/socfpga.c | 3 +-- drivers/reset/reset-socfpga.c

[PATCH 1/2] reset: sunxi: declare sun6i_reset_init in a header file

2018-12-13 Thread Philipp Zabel
Avoid declaring extern functions in c files. To make sure function definition and usage don't get out of sync, declare sun6i_reset_init in a common header. Suggested-by: Stephen Rothwell Signed-off-by: Philipp Zabel --- arch/arm/mach-sunxi/sunxi.c | 2 +- drivers/reset/reset-sunxi.c | 1

Re: [PATCH v8 2/4] pps: descriptor-based gpio, capture-clear addition

2018-11-22 Thread Philipp Zabel
> { > @@ -90,53 +121,23 @@ get_irqf_trigger_flags(const struct pps_gpio_device_data > *data) > static int pps_gpio_probe(struct platform_device *pdev) > { > struct pps_gpio_device_data *data; > - const char *gpio_label; > int ret; > int pps_default_params; > - const struct pps_gpio_platform_data *pdata = pdev->dev.platform_data; > - struct device_node *np = pdev->dev.of_node; > > /* allocate space for device info */ > data = devm_kzalloc(>dev, sizeof(struct pps_gpio_device_data), Could use sizeof(*data) here. Otherwise, Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH v8 2/4] pps: descriptor-based gpio, capture-clear addition

2018-11-22 Thread Philipp Zabel
> { > @@ -90,53 +121,23 @@ get_irqf_trigger_flags(const struct pps_gpio_device_data > *data) > static int pps_gpio_probe(struct platform_device *pdev) > { > struct pps_gpio_device_data *data; > - const char *gpio_label; > int ret; > int pps_default_params; > - const struct pps_gpio_platform_data *pdata = pdev->dev.platform_data; > - struct device_node *np = pdev->dev.of_node; > > /* allocate space for device info */ > data = devm_kzalloc(>dev, sizeof(struct pps_gpio_device_data), Could use sizeof(*data) here. Otherwise, Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH 1/1] reset: imx7: Add support for i.MX8MQ

2018-11-19 Thread Philipp Zabel
Hi Andrey, thank you for the patch. In general, sharing the lookup table with i.MX7 is fine iff it is a strict superset. But I don't think that is the case (see below). Even so, this will change if there ever is another i.MX7 or i.MX8M variant that is also a superset of i.MX7, but not a superset

Re: [PATCH 1/1] reset: imx7: Add support for i.MX8MQ

2018-11-19 Thread Philipp Zabel
Hi Andrey, thank you for the patch. In general, sharing the lookup table with i.MX7 is fine iff it is a strict superset. But I don't think that is the case (see below). Even so, this will change if there ever is another i.MX7 or i.MX8M variant that is also a superset of i.MX7, but not a superset

Re: [PATCH 0/4] reset: uniphier: Rename from USB3 reset to glue reset and add AHCI reset support

2018-11-19 Thread Philipp Zabel
On Fri, 2018-11-09 at 10:42 +0900, Kunihiko Hayashi wrote: > This series renames the reset control of core reset included in USB3 glue > layer with in the glue layer for generic peripherals to allow other devices > to use it. > > And this series adds support for the core reset included in AHCI

Re: [PATCH 0/4] reset: uniphier: Rename from USB3 reset to glue reset and add AHCI reset support

2018-11-19 Thread Philipp Zabel
On Fri, 2018-11-09 at 10:42 +0900, Kunihiko Hayashi wrote: > This series renames the reset control of core reset included in USB3 glue > layer with in the glue layer for generic peripherals to allow other devices > to use it. > > And this series adds support for the core reset included in AHCI

Re: [PATCH v6 2/4] pps: descriptor-based gpio, capture-clear addition

2018-11-17 Thread Philipp Zabel
Hi Tom, On Tue, Nov 13, 2018 at 5:08 AM Tom Burkart wrote: > > This patch changes the GPIO access for the pps-gpio driver from the > integer based API to the descriptor based API. It also adds > documentation for the device tree capture-clear option and > device tree capture-clear extraction. >

Re: [PATCH v6 2/4] pps: descriptor-based gpio, capture-clear addition

2018-11-17 Thread Philipp Zabel
Hi Tom, On Tue, Nov 13, 2018 at 5:08 AM Tom Burkart wrote: > > This patch changes the GPIO access for the pps-gpio driver from the > integer based API to the descriptor based API. It also adds > documentation for the device tree capture-clear option and > device tree capture-clear extraction. >

Re: [PATCHv4] reset: socfpga: add an early reset driver for SoCFPGA

2018-11-15 Thread Philipp Zabel
Hi Dinh, On Tue, 2018-11-13 at 12:50 -0600, Dinh Nguyen wrote: > @@ -120,7 +120,8 @@ static const struct reset_simple_devdata > reset_simple_active_low = { > }; > > static const struct of_device_id reset_simple_dt_ids[] = { > - { .compatible = "altr,rst-mgr", .data = _simple_socfpga }, >

Re: [PATCHv4] reset: socfpga: add an early reset driver for SoCFPGA

2018-11-15 Thread Philipp Zabel
Hi Dinh, On Tue, 2018-11-13 at 12:50 -0600, Dinh Nguyen wrote: > @@ -120,7 +120,8 @@ static const struct reset_simple_devdata > reset_simple_active_low = { > }; > > static const struct of_device_id reset_simple_dt_ids[] = { > - { .compatible = "altr,rst-mgr", .data = _simple_socfpga }, >

Re: [PATCH][next] reset: fix null pointer dereference on dev by dev_name

2018-11-15 Thread Philipp Zabel
Hi Colin, On Wed, 2018-11-14 at 21:49 +, Colin King wrote: > From: Colin Ian King > > The call to dev_name will dereference dev, however, dev is later > being null checked, so there is a possibility of a null pointer > dereference on dev by the call to dev_name. Fix this by null > checking

Re: [PATCH][next] reset: fix null pointer dereference on dev by dev_name

2018-11-15 Thread Philipp Zabel
Hi Colin, On Wed, 2018-11-14 at 21:49 +, Colin King wrote: > From: Colin Ian King > > The call to dev_name will dereference dev, however, dev is later > being null checked, so there is a possibility of a null pointer > dereference on dev by the call to dev_name. Fix this by null > checking

Re: [PATCH 1/3] arm64: dts: stratix10: use "altr,stratix10-rst-mgr" binding

2018-11-15 Thread Philipp Zabel
Hi Dinh, On Mon, 2018-11-05 at 14:05 -0600, Dinh Nguyen wrote: > From: Dinh Nguyen > > The standard reset-simple driver the uses the "altr,rst-mgr" binding is > not getting initialized early enough in the boot process, so timers > that the kernel needs are still left in reset. Thus an early >

Re: [PATCH 3/3] ARM: socfpga: dts: document "altr,stratix10-rst-mgr" binding

2018-11-15 Thread Philipp Zabel
Hi Dinh, On Mon, 2018-11-05 at 14:05 -0600, Dinh Nguyen wrote: > "altr,stratix10-rst-mgr" is used for the Stratix10 reset manager. > > Signed-off-by: Dinh Nguyen > --- > Documentation/devicetree/bindings/reset/socfpga-reset.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

Re: [PATCH 1/3] arm64: dts: stratix10: use "altr,stratix10-rst-mgr" binding

2018-11-15 Thread Philipp Zabel
Hi Dinh, On Mon, 2018-11-05 at 14:05 -0600, Dinh Nguyen wrote: > From: Dinh Nguyen > > The standard reset-simple driver the uses the "altr,rst-mgr" binding is > not getting initialized early enough in the boot process, so timers > that the kernel needs are still left in reset. Thus an early >

Re: [PATCH 3/3] ARM: socfpga: dts: document "altr,stratix10-rst-mgr" binding

2018-11-15 Thread Philipp Zabel
Hi Dinh, On Mon, 2018-11-05 at 14:05 -0600, Dinh Nguyen wrote: > "altr,stratix10-rst-mgr" is used for the Stratix10 reset manager. > > Signed-off-by: Dinh Nguyen > --- > Documentation/devicetree/bindings/reset/socfpga-reset.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

Re: [PATCH trivial] reset: Improve reset controller kernel docs

2018-11-13 Thread Philipp Zabel
Hi Geert, On Mon, 2018-10-08 at 13:15 +0200, Geert Uytterhoeven wrote: > Grammar and indentation fixes. > > Signed-off-by: Geert Uytterhoeven > --- > include/linux/reset.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/reset.h

Re: [PATCH trivial] reset: Improve reset controller kernel docs

2018-11-13 Thread Philipp Zabel
Hi Geert, On Mon, 2018-10-08 at 13:15 +0200, Geert Uytterhoeven wrote: > Grammar and indentation fixes. > > Signed-off-by: Geert Uytterhoeven > --- > include/linux/reset.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/reset.h

Re: [PATCHv3 2/3] reset: socfpga: add an early reset driver for SoCFPGA

2018-11-13 Thread Philipp Zabel
Hi Dinh, On Mon, 2018-11-05 at 14:05 -0600, Dinh Nguyen wrote: > From: Dinh Nguyen > > Create a separate reset driver that uses the reset operations in > reset-simple. The reset driver for the SoCFPGA platform needs to > register early in order to be able bring online timers that needed > early

Re: [PATCHv3 2/3] reset: socfpga: add an early reset driver for SoCFPGA

2018-11-13 Thread Philipp Zabel
Hi Dinh, On Mon, 2018-11-05 at 14:05 -0600, Dinh Nguyen wrote: > From: Dinh Nguyen > > Create a separate reset driver that uses the reset operations in > reset-simple. The reset driver for the SoCFPGA platform needs to > register early in order to be able bring online timers that needed > early

Re: [PATCH 3/4] dt-bindings: reset: uniphier: Add AHCI core reset description

2018-11-12 Thread Philipp Zabel
Hi, On Mon, 2018-11-12 at 21:02 +0900, Kunihiko Hayashi wrote: > Hi, > > Thank you for some comments and pointing out. > > On Sat, 10 Nov 2018 01:14:06 +0900 wrote: > > > On Sat, Nov 10, 2018 at 12:02 AM Philipp Zabel > > wrote: > > > > > &

Re: [PATCH 3/4] dt-bindings: reset: uniphier: Add AHCI core reset description

2018-11-12 Thread Philipp Zabel
Hi, On Mon, 2018-11-12 at 21:02 +0900, Kunihiko Hayashi wrote: > Hi, > > Thank you for some comments and pointing out. > > On Sat, 10 Nov 2018 01:14:06 +0900 wrote: > > > On Sat, Nov 10, 2018 at 12:02 AM Philipp Zabel > > wrote: > > > > > &

Re: [PATCH 3/4] dt-bindings: reset: uniphier: Add AHCI core reset description

2018-11-09 Thread Philipp Zabel
Hi Kunihiko, On Fri, 2018-11-09 at 10:42 +0900, Kunihiko Hayashi wrote: > Add compatible strings for reset control of AHCI core implemented in > UniPhier SoCs. The reset control belongs to AHCI glue layer. > > Signed-off-by: Kunihiko Hayashi > --- >

Re: [PATCH 3/4] dt-bindings: reset: uniphier: Add AHCI core reset description

2018-11-09 Thread Philipp Zabel
Hi Kunihiko, On Fri, 2018-11-09 at 10:42 +0900, Kunihiko Hayashi wrote: > Add compatible strings for reset control of AHCI core implemented in > UniPhier SoCs. The reset control belongs to AHCI glue layer. > > Signed-off-by: Kunihiko Hayashi > --- >

Re: [PATCH] PCI: imx: Add imx6sx suspend/resume support

2018-11-01 Thread Philipp Zabel
Hi Leonard, On Wed, 2018-10-31 at 11:02 +, Leonard Crestez wrote: > On 10/8/2018 8:38 PM, Leonard Crestez wrote: > > Enable PCI suspend/resume support on imx6sx socs. This is similar to > > imx7d with a few differences: > > > > * The PM_Turn_Off bit is exposed through an IOMUX GPR, like all

Re: [PATCH] PCI: imx: Add imx6sx suspend/resume support

2018-11-01 Thread Philipp Zabel
Hi Leonard, On Wed, 2018-10-31 at 11:02 +, Leonard Crestez wrote: > On 10/8/2018 8:38 PM, Leonard Crestez wrote: > > Enable PCI suspend/resume support on imx6sx socs. This is similar to > > imx7d with a few differences: > > > > * The PM_Turn_Off bit is exposed through an IOMUX GPR, like all

Re: [PATCH v2 3/3] reset: reset-zynqmp: Adding support for Xilinx zynqmp reset controller.

2018-10-26 Thread Philipp Zabel
On Fri, Oct 26, 2018 at 05:54:24PM +0530, Nava kishore Manne wrote: [...] > +static int zynqmp_reset_status(struct reset_controller_dev *rcdev, > +unsigned long id) > +{ > + struct zynqmp_reset_data *priv = to_zynqmp_reset_data(rcdev); > + int val, err; > + > +

Re: [PATCH v2 3/3] reset: reset-zynqmp: Adding support for Xilinx zynqmp reset controller.

2018-10-26 Thread Philipp Zabel
On Fri, Oct 26, 2018 at 05:54:24PM +0530, Nava kishore Manne wrote: [...] > +static int zynqmp_reset_status(struct reset_controller_dev *rcdev, > +unsigned long id) > +{ > + struct zynqmp_reset_data *priv = to_zynqmp_reset_data(rcdev); > + int val, err; > + > +

Re: [PATCH 3/3] reset: reset-zynqmp: Adding support for Xilinx zynqmp reset controller.

2018-10-19 Thread Philipp Zabel
Hi Nava, On Sat, 2018-10-20 at 14:11 +0530, Nava kishore Manne wrote: > Add a reset controller driver for Xilinx Zynq UltraScale+ MPSoC. > The zynqmp reset-controller has the ability to reset lines > connected to different blocks and peripheral in the Soc. > > Signed-off-by: Nava kishore Manne

Re: [PATCH 3/3] reset: reset-zynqmp: Adding support for Xilinx zynqmp reset controller.

2018-10-19 Thread Philipp Zabel
Hi Nava, On Sat, 2018-10-20 at 14:11 +0530, Nava kishore Manne wrote: > Add a reset controller driver for Xilinx Zynq UltraScale+ MPSoC. > The zynqmp reset-controller has the ability to reset lines > connected to different blocks and peripheral in the Soc. > > Signed-off-by: Nava kishore Manne

Re: [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-10-17 Thread Philipp Zabel
Hi Maxime, On Fri, 2018-10-12 at 15:46 +0200, Maxime Ripard wrote: > On Fri, Oct 12, 2018 at 12:05:16PM +0200, Philipp Zabel wrote: [...] > > What I would like better would be to let the consumers keep their reset- > > gpios bindings, but add an optional hold time ove

Re: [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-10-17 Thread Philipp Zabel
Hi Maxime, On Fri, 2018-10-12 at 15:46 +0200, Maxime Ripard wrote: > On Fri, Oct 12, 2018 at 12:05:16PM +0200, Philipp Zabel wrote: [...] > > What I would like better would be to let the consumers keep their reset- > > gpios bindings, but add an optional hold time ove

Re: [PATCHv2] reset: socfpga: add an early reset driver for SoCFPGA

2018-10-17 Thread Philipp Zabel
Hi Dinh, On Wed, 2018-10-17 at 10:02 -0500, Dinh Nguyen wrote: [...] > > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > > > index 13d28fdbdbb5..f10de5ce4753 100644 > > > --- a/drivers/reset/Kconfig > > > +++ b/drivers/reset/Kconfig > > > @@ -100,7 +100,7 @@ config RESET_QCOM_AOSS

Re: [PATCHv2] reset: socfpga: add an early reset driver for SoCFPGA

2018-10-17 Thread Philipp Zabel
Hi Dinh, On Wed, 2018-10-17 at 10:02 -0500, Dinh Nguyen wrote: [...] > > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > > > index 13d28fdbdbb5..f10de5ce4753 100644 > > > --- a/drivers/reset/Kconfig > > > +++ b/drivers/reset/Kconfig > > > @@ -100,7 +100,7 @@ config RESET_QCOM_AOSS

Re: [PATCHv2] reset: socfpga: add an early reset driver for SoCFPGA

2018-10-17 Thread Philipp Zabel
Hi Dinh, On Thu, 2018-10-11 at 08:52 -0500, Dinh Nguyen wrote: > Create a separate reset driver that uses the reset operations in > reset-simple. The reset driver for the SoCFPGA platform needs to > register early in order to be able bring online timers that needed > early in the kernel bootup. >

Re: [PATCHv2] reset: socfpga: add an early reset driver for SoCFPGA

2018-10-17 Thread Philipp Zabel
Hi Dinh, On Thu, 2018-10-11 at 08:52 -0500, Dinh Nguyen wrote: > Create a separate reset driver that uses the reset operations in > reset-simple. The reset driver for the SoCFPGA platform needs to > register early in order to be able bring online timers that needed > early in the kernel bootup. >

Re: [PATCH v2] ARC: HSDK: improve reset driver

2018-10-12 Thread Philipp Zabel
Hi Eugeniy, thank you for the update. On Fri, 2018-09-28 at 19:28 +0300, Eugeniy Paltsev wrote: > As for today HSDK reset driver implements only > .reset() callback. > > In case of driver which implements one of standard > reset controller usage pattern > (call *_deassert() in probe(), call

Re: [PATCH v2] ARC: HSDK: improve reset driver

2018-10-12 Thread Philipp Zabel
Hi Eugeniy, thank you for the update. On Fri, 2018-09-28 at 19:28 +0300, Eugeniy Paltsev wrote: > As for today HSDK reset driver implements only > .reset() callback. > > In case of driver which implements one of standard > reset controller usage pattern > (call *_deassert() in probe(), call

Re: [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-10-12 Thread Philipp Zabel
Hi Cheng-yi, [adding Maxime, devicetree to Cc:, the old discussion about GPIO resets in [4] has never been resolved] On Tue, 2018-10-09 at 21:46 +0800, Cheng-yi Chiang wrote: > +reset controller maintainer Philipp > > Hi Mark, > Sorry for the late reply. It took me a while to investigate

Re: [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-10-12 Thread Philipp Zabel
Hi Cheng-yi, [adding Maxime, devicetree to Cc:, the old discussion about GPIO resets in [4] has never been resolved] On Tue, 2018-10-09 at 21:46 +0800, Cheng-yi Chiang wrote: > +reset controller maintainer Philipp > > Hi Mark, > Sorry for the late reply. It took me a while to investigate

Re: [PATCH] reset: Fix potential use-after-free in __of_reset_control_get()

2018-10-08 Thread Philipp Zabel
On Mon, 2018-10-08 at 15:12 +0200, Geert Uytterhoeven wrote: > Hi Philipp, > > On Mon, Oct 8, 2018 at 2:56 PM Philipp Zabel wrote: > > On Mon, 2018-10-08 at 13:14 +0200, Geert Uytterhoeven wrote: > > > Calling of_node_put() decreases the reference count of a device tr

Re: [PATCH] reset: Fix potential use-after-free in __of_reset_control_get()

2018-10-08 Thread Philipp Zabel
On Mon, 2018-10-08 at 15:12 +0200, Geert Uytterhoeven wrote: > Hi Philipp, > > On Mon, Oct 8, 2018 at 2:56 PM Philipp Zabel wrote: > > On Mon, 2018-10-08 at 13:14 +0200, Geert Uytterhoeven wrote: > > > Calling of_node_put() decreases the reference count of a device tr

Re: [PATCH] reset: Fix potential use-after-free in __of_reset_control_get()

2018-10-08 Thread Philipp Zabel
Hi Geert, On Mon, 2018-10-08 at 13:14 +0200, Geert Uytterhoeven wrote: > Calling of_node_put() decreases the reference count of a device tree > object, and may free some data. > > However, the of_phandle_args structure embedding it is passed to > reset_controller_dev.of_xlate() after that, so it

Re: [PATCH] reset: Fix potential use-after-free in __of_reset_control_get()

2018-10-08 Thread Philipp Zabel
Hi Geert, On Mon, 2018-10-08 at 13:14 +0200, Geert Uytterhoeven wrote: > Calling of_node_put() decreases the reference count of a device tree > object, and may free some data. > > However, the of_phandle_args structure embedding it is passed to > reset_controller_dev.of_xlate() after that, so it

Re: [PATCH trivial] reset: Improve reset controller kernel docs

2018-10-08 Thread Philipp Zabel
Hi Geert, On Mon, 2018-10-08 at 13:15 +0200, Geert Uytterhoeven wrote: > Grammar and indentation fixes. > > Signed-off-by: Geert Uytterhoeven > --- > include/linux/reset.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/reset.h

Re: [PATCH trivial] reset: Improve reset controller kernel docs

2018-10-08 Thread Philipp Zabel
Hi Geert, On Mon, 2018-10-08 at 13:15 +0200, Geert Uytterhoeven wrote: > Grammar and indentation fixes. > > Signed-off-by: Geert Uytterhoeven > --- > include/linux/reset.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/reset.h

Re: [PATCH] reset: socfpga: add an early reset driver for SoCFPGA

2018-10-08 Thread Philipp Zabel
Hi Dinh, On Fri, 2018-10-05 at 15:23 -0500, Dinh Nguyen wrote: > Hi Philipp, > > I apologize, but I just realized that I forgot to test this patch > against the SoCFPGA ARM64 platform. I just tested against that platform > and this patch is preventing that board from booting. > > I need to redo

Re: [PATCH] reset: socfpga: add an early reset driver for SoCFPGA

2018-10-08 Thread Philipp Zabel
Hi Dinh, On Fri, 2018-10-05 at 15:23 -0500, Dinh Nguyen wrote: > Hi Philipp, > > I apologize, but I just realized that I forgot to test this patch > against the SoCFPGA ARM64 platform. I just tested against that platform > and this patch is preventing that board from booting. > > I need to redo

Re: [PATCH] reset: socfpga: add an early reset driver for SoCFPGA

2018-10-05 Thread Philipp Zabel
Hi Dinh, On Fri, 2018-10-05 at 10:17 -0500, Dinh Nguyen wrote: [...] > > > +static int a10_reset_init(struct device_node *np) > > > +{ > > > + struct reset_simple_data *data; > > > + struct resource res; > > > + resource_size_t size; > > > + int ret; > > > + u32 reg_offset = 0; > > > > ... now

Re: [PATCH] reset: socfpga: add an early reset driver for SoCFPGA

2018-10-05 Thread Philipp Zabel
Hi Dinh, On Fri, 2018-10-05 at 10:17 -0500, Dinh Nguyen wrote: [...] > > > +static int a10_reset_init(struct device_node *np) > > > +{ > > > + struct reset_simple_data *data; > > > + struct resource res; > > > + resource_size_t size; > > > + int ret; > > > + u32 reg_offset = 0; > > > > ... now

Re: [PATCH v2 4/4] PCI: imx: Add PME_Turn_Off support

2018-10-05 Thread Philipp Zabel
Hi Lorenzo, On Fri, 2018-10-05 at 11:29 +0100, Lorenzo Pieralisi wrote: > On Thu, Oct 04, 2018 at 04:34:30PM +, Leonard Crestez wrote: > > When the root complex suspends it must send a PME_Turn_Off TLP. > > Implement this by asserting the "turnoff" reset. > > > > On imx7d this functionality

Re: [PATCH v2 4/4] PCI: imx: Add PME_Turn_Off support

2018-10-05 Thread Philipp Zabel
Hi Lorenzo, On Fri, 2018-10-05 at 11:29 +0100, Lorenzo Pieralisi wrote: > On Thu, Oct 04, 2018 at 04:34:30PM +, Leonard Crestez wrote: > > When the root complex suspends it must send a PME_Turn_Off TLP. > > Implement this by asserting the "turnoff" reset. > > > > On imx7d this functionality

Re: [PATCH v4 03/11] gpu: ipu-v3: Add planar support to interlaced scan

2018-10-05 Thread Philipp Zabel
LO, ilo); > ipu_ch_param_write_field(ch, IPU_FIELD_SLY, sly); > + if (sluv) > + ipu_ch_param_write_field(ch, IPU_FIELD_SLUV, sluv); > }; > EXPORT_SYMBOL_GPL(ipu_cpmem_interlaced_scan); [...] Reviewed-by: Philipp Zabel and Acked-by: Philipp Zabel to be merged with the rest of the series via the media tree. I'll take care not to introduce nontrivial conflicts in imx-drm. regards Philipp

Re: [PATCH v4 03/11] gpu: ipu-v3: Add planar support to interlaced scan

2018-10-05 Thread Philipp Zabel
LO, ilo); > ipu_ch_param_write_field(ch, IPU_FIELD_SLY, sly); > + if (sluv) > + ipu_ch_param_write_field(ch, IPU_FIELD_SLUV, sluv); > }; > EXPORT_SYMBOL_GPL(ipu_cpmem_interlaced_scan); [...] Reviewed-by: Philipp Zabel and Acked-by: Philipp Zabel to be merged with the rest of the series via the media tree. I'll take care not to introduce nontrivial conflicts in imx-drm. regards Philipp

Re: [PATCH v3 0/6] Add support for PDC Global on SDM845 SoCs

2018-10-05 Thread Philipp Zabel
Hi Sibi, Bjorn, On Thu, 2018-10-04 at 23:57 +0530, Sibi Sankar wrote: > On 09/04/2018 01:06 AM, Bjorn Andersson wrote: [...] > > Philipp, there's no compile time dependencies between the PDC and > > remoteproc patches in this series. Will you take these two through your > > tree and I'll take the

Re: [PATCH v3 0/6] Add support for PDC Global on SDM845 SoCs

2018-10-05 Thread Philipp Zabel
Hi Sibi, Bjorn, On Thu, 2018-10-04 at 23:57 +0530, Sibi Sankar wrote: > On 09/04/2018 01:06 AM, Bjorn Andersson wrote: [...] > > Philipp, there's no compile time dependencies between the PDC and > > remoteproc patches in this series. Will you take these two through your > > tree and I'll take the

Re: [PATCH v2 1/4] reset: imx7: Add PCIE_CTRL_APPS_TURNOFF

2018-10-04 Thread Philipp Zabel
T 24 > > -#define IMX7_RESET_NUM 25 > +#define IMX7_RESET_PCIE_CTRL_APPS_TURNOFF 25 > + > +#define IMX7_RESET_NUM 26 > > #endif This is contained enough to be merged with the rest of the series, patches 1 and 2: Acked-by: Philipp Zabel Let me know if I should pick them up instead. regards Philipp

Re: [PATCH v2 1/4] reset: imx7: Add PCIE_CTRL_APPS_TURNOFF

2018-10-04 Thread Philipp Zabel
T 24 > > -#define IMX7_RESET_NUM 25 > +#define IMX7_RESET_PCIE_CTRL_APPS_TURNOFF 25 > + > +#define IMX7_RESET_NUM 26 > > #endif This is contained enough to be merged with the rest of the series, patches 1 and 2: Acked-by: Philipp Zabel Let me know if I should pick them up instead. regards Philipp

Re: [PATCH 4/4] PCI: imx: Add PME_Turn_Off support

2018-10-04 Thread Philipp Zabel
On Thu, 2018-10-04 at 13:20 +, Leonard Crestez wrote: > On Thu, 2018-10-04 at 10:59 +0200, Lucas Stach wrote: > > Am Montag, den 01.10.2018, 22:53 +0300 schrieb Leonard Crestez: > > > When the root complex suspends it must send a PME_Turn_Off TLP. > > > Implement this by asserting the

Re: [PATCH 4/4] PCI: imx: Add PME_Turn_Off support

2018-10-04 Thread Philipp Zabel
On Thu, 2018-10-04 at 13:20 +, Leonard Crestez wrote: > On Thu, 2018-10-04 at 10:59 +0200, Lucas Stach wrote: > > Am Montag, den 01.10.2018, 22:53 +0300 schrieb Leonard Crestez: > > > When the root complex suspends it must send a PME_Turn_Off TLP. > > > Implement this by asserting the

Re: [PATCH trivial] reset: Grammar s/more then once/more than once/

2018-10-04 Thread Philipp Zabel
On Wed, 2018-09-26 at 15:20 +0200, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > include/linux/reset.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/reset.h b/include/linux/reset.h > index 09732c36f3515a1e..29af6d6b2f4b8103 100644

Re: [PATCH] reset: socfpga: add an early reset driver for SoCFPGA

2018-10-04 Thread Philipp Zabel
Hi Dinh, On Mon, 2018-09-17 at 09:50 -0500, Dinh Nguyen wrote: > Create a separate reset driver that uses the reset operations in reset-simple. > The reset driver for the SoCFPGA platform needs to register early in order to > be able bring online timers that needed early in the kernel bootup. >

Re: [PATCH trivial] reset: Grammar s/more then once/more than once/

2018-10-04 Thread Philipp Zabel
On Wed, 2018-09-26 at 15:20 +0200, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > include/linux/reset.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/reset.h b/include/linux/reset.h > index 09732c36f3515a1e..29af6d6b2f4b8103 100644

Re: [PATCH] reset: socfpga: add an early reset driver for SoCFPGA

2018-10-04 Thread Philipp Zabel
Hi Dinh, On Mon, 2018-09-17 at 09:50 -0500, Dinh Nguyen wrote: > Create a separate reset driver that uses the reset operations in reset-simple. > The reset driver for the SoCFPGA platform needs to register early in order to > be able bring online timers that needed early in the kernel bootup. >

Re: [PATCH/RFC v4 1/2] reset: Add support for dedicated reset controls

2018-09-20 Thread Philipp Zabel
Hi Geert, On Wed, 2018-09-19 at 17:24 +0200, Geert Uytterhoeven wrote: > On Wed, Sep 19, 2018 at 4:58 PM Philipp Zabel wrote: [...] > > I consider requesting exclusive access to a shared reset line a misuse > > of the API. Are there such cases? Can they be fixed? > > I g

Re: [PATCH/RFC v4 1/2] reset: Add support for dedicated reset controls

2018-09-20 Thread Philipp Zabel
Hi Geert, On Wed, 2018-09-19 at 17:24 +0200, Geert Uytterhoeven wrote: > On Wed, Sep 19, 2018 at 4:58 PM Philipp Zabel wrote: [...] > > I consider requesting exclusive access to a shared reset line a misuse > > of the API. Are there such cases? Can they be fixed? > > I g

Re: [PATCH v2 6/8] drm/imx: support handling bridge timings bus flags

2018-09-13 Thread Philipp Zabel
On Wed, 2018-09-12 at 11:32 -0700, Stefan Agner wrote: > A bridge might require specific settings for the pixel data on > the bus. On which bus? The bridge has input and output. > Copy the bus flags from the bridge timings if a bridge > is in use. > > Signed-off-by: Stefan Agner > --- >

Re: [PATCH v2 6/8] drm/imx: support handling bridge timings bus flags

2018-09-13 Thread Philipp Zabel
On Wed, 2018-09-12 at 11:32 -0700, Stefan Agner wrote: > A bridge might require specific settings for the pixel data on > the bus. On which bus? The bridge has input and output. > Copy the bus flags from the bridge timings if a bridge > is in use. > > Signed-off-by: Stefan Agner > --- >

Re: [RFC] reset: make reset controller driver initialize early

2018-09-11 Thread Philipp Zabel
Hi Dinh, On Mon, 2018-09-10 at 14:59 -0500, Dinh Nguyen wrote: > Hi Philipp, > > I need to make the reset controller on the SoCFPGA platform initialize > early. What does early mean in this context? > I have one solution which is similar to what reset-sunxi is > doing, making the

Re: [RFC] reset: make reset controller driver initialize early

2018-09-11 Thread Philipp Zabel
Hi Dinh, On Mon, 2018-09-10 at 14:59 -0500, Dinh Nguyen wrote: > Hi Philipp, > > I need to make the reset controller on the SoCFPGA platform initialize > early. What does early mean in this context? > I have one solution which is similar to what reset-sunxi is > doing, making the

Re: [RFC PATCH v3 1/3] firmware: xilinx: Add reset API's

2018-09-05 Thread Philipp Zabel
Hi, On Wed, 2018-09-05 at 12:39 +0530, Nava kishore Manne wrote: > This Patch Adds reset API's to support release, assert > and status functionalities by using firmware interface. > > Signed-off-by: Nava kishore Manne > --- > Changes for v3: > -None. > Changes for v2: >

Re: [RFC PATCH v3 1/3] firmware: xilinx: Add reset API's

2018-09-05 Thread Philipp Zabel
Hi, On Wed, 2018-09-05 at 12:39 +0530, Nava kishore Manne wrote: > This Patch Adds reset API's to support release, assert > and status functionalities by using firmware interface. > > Signed-off-by: Nava kishore Manne > --- > Changes for v3: > -None. > Changes for v2: >

Re: [RFC PATCH v3 3/3] reset: reset-zynqmp: Adding support for Xilinx zynqmp reset controller.

2018-09-05 Thread Philipp Zabel
Hi, thank you for the patch. I have a few comments below: On Wed, 2018-09-05 at 12:39 +0530, Nava kishore Manne wrote: > Add a reset controller driver for Xilinx Zynq UltraScale+ MPSoC. > The zynqmp reset-controller has the ability to reset lines > connected to different blocks and peripheral in

Re: [RFC PATCH v3 3/3] reset: reset-zynqmp: Adding support for Xilinx zynqmp reset controller.

2018-09-05 Thread Philipp Zabel
Hi, thank you for the patch. I have a few comments below: On Wed, 2018-09-05 at 12:39 +0530, Nava kishore Manne wrote: > Add a reset controller driver for Xilinx Zynq UltraScale+ MPSoC. > The zynqmp reset-controller has the ability to reset lines > connected to different blocks and peripheral in

<    1   2   3   4   5   6   7   8   9   10   >