;
}
#ifdef CONFIG_SQUASHFS_XZ
diff --git a/fs/squashfs/decompressor_single.c
b/fs/squashfs/decompressor_single.c
new file mode 100644
index 000..c5bb694
--- /dev/null
+++ b/fs/squashfs/decompressor_single.c
@@ -0,0 +1,86 @@
+/*
+ * Copyright (c) 2013
+ * Phillip Lougher phil...@squashfs.org.uk
be
because we've been VM reclaimed, but the other pages are
still in the page cache and uptodate.
* Make Kconfig option a choice, making the either-other nature of
the option more explicit, and also tidying up the ifdef in the
Makefile
Signed-off-by: Phillip Lougher phil
Signed-off-by: Phillip Lougher phil...@squashfs.org.uk
---
fs/squashfs/Kconfig | 13 +++
fs/squashfs/Makefile |9 +-
fs/squashfs/decompressor_multi.c | 200 ++
3 files changed, 221 insertions(+), 1 deletion(-)
create mode 100644
update the code in decompressor_multi*.c
Signed-off-by: Phillip Lougher phil...@squashfs.org.uk
---
fs/squashfs/block.c | 27 +---
fs/squashfs/cache.c | 28 +---
fs/squashfs/decompressor.c | 14 ++--
fs
On 01/11/13 03:06, Phillip Lougher wrote:
On 01/11/13 00:57, Stephen Rothwell wrote:
Hi Phillip,
After merging the squashfs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
fs/squashfs/decompressor_single.c: In function 'squashfs_decompressor_create':
fs/squashfs
committer Phillip Lougher 2013-10-31 23:06:37 (GMT)
These things happen when you rush to get the patches ready for the linux-next
tree.
Squashfs is spare-time work for me, which means I often have no choice to
work on it during the night. Previously when pushing such work for the
linux-next tree I
committer Phillip Lougher phil...@squashfs.org.uk 2013-10-31 23:06:37 (GMT)
These things happen when you rush to get the patches ready for the linux-next
tree.
Squashfs is spare-time work for me, which means I often have no choice to
work on it during the night. Previously when pushing such work
On 01/11/13 03:06, Phillip Lougher wrote:
On 01/11/13 00:57, Stephen Rothwell wrote:
Hi Phillip,
After merging the squashfs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
fs/squashfs/decompressor_single.c: In function 'squashfs_decompressor_create':
fs/squashfs
Squashfs: Refactor decompressor interface and code
Cc: Phillip Lougher
Signed-off-by: Minchan Kim
---
fs/squashfs/Kconfig | 12 +++
fs/squashfs/Makefile |9 +-
fs/squashfs/decompressor_multi.c | 194 ++
3 files changed, 214 insert
: Refactor decompressor interface and code
Cc: Phillip Lougher phil...@squashfs.org.uk
Signed-off-by: Minchan Kim minc...@kernel.org
---
fs/squashfs/Kconfig | 12 +++
fs/squashfs/Makefile |9 +-
fs/squashfs/decompressor_multi.c | 194
dd if=file2 of=/dev/null bs=4096 &
dd if=file3 of=/dev/null bs=4096 &
dd if=file4 of=/dev/null bs=4096
Before:
629145600 bytes (629 MB) copied, 45.8046 s, 13.7 MB/s
After:
629145600 bytes (629 MB) copied, 9.29414 s, 67.7 MB/s
Signed-off-by: Phillip Lougher
---
fs/squa
-by: Phillip Lougher
---
fs/squashfs/Makefile | 1 +
fs/squashfs/file.c | 142 ---
fs/squashfs/file_cache.c | 38 +
fs/squashfs/squashfs.h | 7 +++
4 files changed, 118 insertions(+), 70 deletions(-)
create mode 100644 fs/squashfs
This patch-set introduces an implementation of
squashfs_readpage() that directly decompresses into the
page cache.
It first generalises the decompressors by adding a page handler
abstraction. This adds helpers to allow the decompressors
to access and process the output buffers in an
-by: Phillip Lougher
---
fs/squashfs/block.c | 27 +++-
fs/squashfs/cache.c | 28
fs/squashfs/decompressor.c| 14 +++---
fs/squashfs/decompressor.h| 5 ++--
fs/squashfs/decompressor_single.c | 9 +++
fs/squashfs
-by: Phillip Lougher phil...@squashfs.org.uk
---
fs/squashfs/block.c | 27 +++-
fs/squashfs/cache.c | 28
fs/squashfs/decompressor.c| 14 +++---
fs/squashfs/decompressor.h| 5 ++--
fs/squashfs/decompressor_single.c | 9
This patch-set introduces an implementation of
squashfs_readpage() that directly decompresses into the
page cache.
It first generalises the decompressors by adding a page handler
abstraction. This adds helpers to allow the decompressors
to access and process the output buffers in an
-by: Phillip Lougher phil...@squashfs.org.uk
---
fs/squashfs/Makefile | 1 +
fs/squashfs/file.c | 142 ---
fs/squashfs/file_cache.c | 38 +
fs/squashfs/squashfs.h | 7 +++
4 files changed, 118 insertions(+), 70 deletions(-)
create mode
if=file2 of=/dev/null bs=4096
dd if=file3 of=/dev/null bs=4096
dd if=file4 of=/dev/null bs=4096
Before:
629145600 bytes (629 MB) copied, 45.8046 s, 13.7 MB/s
After:
629145600 bytes (629 MB) copied, 9.29414 s, 67.7 MB/s
Signed-off-by: Phillip Lougher phil...@squashfs.org.uk
to/or should need
to access anything within it.
Signed-off-by: Phillip Lougher
---
fs/squashfs/Makefile | 2 +-
fs/squashfs/block.c | 11 ++--
fs/squashfs/decompressor.c| 47 +++--
fs/squashfs/decompressor.h| 21 +++-
fs/squashfs
to/or should need
to access anything within it.
Signed-off-by: Phillip Lougher phil...@squashfs.org.uk
---
fs/squashfs/Makefile | 2 +-
fs/squashfs/block.c | 11 ++--
fs/squashfs/decompressor.c| 47 +++--
fs/squashfs/decompressor.h| 21
Hi,
This a partial review, based on the stuff I've managed to review
so far!
1. This is a substantial performance improvement, which is great
stuff!
But like the "squashfs: remove cache for normal data page" patch
it needs to be optional, with the previous behaviour retained as
Hi,
This a partial review, based on the stuff I've managed to review
so far!
1. This is a substantial performance improvement, which is great
stuff!
But like the squashfs: remove cache for normal data page patch
it needs to be optional, with the previous behaviour retained as
Minchan Kim wrote:
Sqsuashfs have used cache for normal data pages but it's pointless
because MM already has cache layer and squashfs adds extra pages
into MM's page cache when it reads a page from compressed block.
This patch removes cache usage for normal data pages so it could
remove
Minchan Kim wrote:
The squashfs_read_data functions has a role to read a block and
decompress for datablock and metadata.
This patch cleans it up so it has squashfs_read_datablock and
squashfs_meta_datablock and morever, squashfs_read_datablock
has two part, one is just request I/O and other
Minchan Kim minc...@kernel.org wrote:
The squashfs_read_data functions has a role to read a block and
decompress for datablock and metadata.
This patch cleans it up so it has squashfs_read_datablock and
squashfs_meta_datablock and morever, squashfs_read_datablock
has two part, one is just
Minchan Kim minc...@kernel.org wrote:
Sqsuashfs have used cache for normal data pages but it's pointless
because MM already has cache layer and squashfs adds extra pages
into MM's page cache when it reads a page from compressed block.
This patch removes cache usage for normal data pages so it
Minchan Kim wrote:
Hello chintu,
On Wed, Sep 25, 2013 at 5:13 PM, chintu kumar wrote:
Hi Minchan,
Thanks for the response!
I checked add_to_page_cache_lru and you are right for existing pages in page
cache it won't add the page you allocated so my questions are answered thank
you.
Minchan Kim minc...@kernel.org wrote:
Hello chintu,
On Wed, Sep 25, 2013 at 5:13 PM, chintu kumar chintu.k...@gmail.com wrote:
Hi Minchan,
Thanks for the response!
I checked add_to_page_cache_lru and you are right for existing pages in page
cache it won't add the page you allocated so my
.
Dan Carpenter (1):
Squashfs: sanity check information from disk
Manish Sharma (1):
Squashfs: Optimized uncompressed buffer loop
Phillip Lougher (5):
Squashfs: fix corruption check in get_dir_index_using_name
.
Dan Carpenter (1):
Squashfs: sanity check information from disk
Manish Sharma (1):
Squashfs: Optimized uncompressed buffer loop
Phillip Lougher (5):
Squashfs: fix corruption check in get_dir_index_using_name
hen
trying to decompress the metadata. So corrupted data does not normally
get as far as the code paths in question here.
Phillip Lougher (5):
Squashfs: fix corruption check in get_dir_index_using_name()
Squashfs: fix corruption checks in squashfs_lookup()
Squashfs: fix corrupt
are not trapped.
Signed-off-by: Phillip Lougher
---
fs/squashfs/namei.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/squashfs/namei.c b/fs/squashfs/namei.c
index 342a5aa..67cad77 100644
--- a/fs/squashfs/namei.c
+++ b/fs/squashfs/namei.c
@@ -147,7 +147,8 @@ static struct
buffer overflow, merely
lots of unnecessary amounts of data to be read.
Signed-off-by: Phillip Lougher
---
fs/squashfs/dir.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/fs/squashfs/dir.c b/fs/squashfs/dir.c
index 1192084..bd7155b 100644
--- a/fs/squashfs/dir.c
+++ b
are not trapped.
Signed-off-by: Phillip Lougher
---
fs/squashfs/dir.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/squashfs/dir.c b/fs/squashfs/dir.c
index f7f527b..1192084 100644
--- a/fs/squashfs/dir.c
+++ b/fs/squashfs/dir.c
@@ -105,9 +105,8 @@ static int
We read the type field from disk. This value should be sanity
checked for correctness to avoid an out of bounds access when
reading the squashfs_filetype_table array.
Signed-off-by: Phillip Lougher
---
fs/squashfs/dir.c | 7 +--
fs/squashfs/squashfs_fs.h | 5 -
2 files changed
edundant. So remove it.
Errors in reading the index are deliberately non-fatal. If we
get an error in reading the index we just return the part of the
index we have managed to read - the index isn't essential,
just quicker.
Signed-off-by: Phillip Lougher
---
fs/squashfs/namei.c | 4 +---
1 file
buffer overflow, merely
lots of unnecessary amounts of data to be read.
Signed-off-by: Phillip Lougher phil...@squashfs.org.uk
---
fs/squashfs/dir.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/fs/squashfs/dir.c b/fs/squashfs/dir.c
index 1192084..bd7155b 100644
are not trapped.
Signed-off-by: Phillip Lougher phil...@squashfs.org.uk
---
fs/squashfs/dir.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/squashfs/dir.c b/fs/squashfs/dir.c
index f7f527b..1192084 100644
--- a/fs/squashfs/dir.c
+++ b/fs/squashfs/dir.c
@@ -105,9 +105,8
We read the type field from disk. This value should be sanity
checked for correctness to avoid an out of bounds access when
reading the squashfs_filetype_table array.
Signed-off-by: Phillip Lougher phil...@squashfs.org.uk
---
fs/squashfs/dir.c | 7 +--
fs/squashfs/squashfs_fs.h | 5
it.
Errors in reading the index are deliberately non-fatal. If we
get an error in reading the index we just return the part of the
index we have managed to read - the index isn't essential,
just quicker.
Signed-off-by: Phillip Lougher phil...@squashfs.org.uk
---
fs/squashfs/namei.c | 4 +---
1 file
are not trapped.
Signed-off-by: Phillip Lougher phil...@squashfs.org.uk
---
fs/squashfs/namei.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/squashfs/namei.c b/fs/squashfs/namei.c
index 342a5aa..67cad77 100644
--- a/fs/squashfs/namei.c
+++ b/fs/squashfs/namei.c
@@ -147,7
to decompress the metadata. So corrupted data does not normally
get as far as the code paths in question here.
Phillip Lougher (5):
Squashfs: fix corruption check in get_dir_index_using_name()
Squashfs: fix corruption checks in squashfs_lookup()
Squashfs: fix corruption checks
Manish Sharma wrote:
Merged the two for loops. We might get a little gain by overlapping
wait_on_bh and the memcpy operations.
---
fs/squashfs/block.c |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/fs/squashfs/block.c b/fs/squashfs/block.c
index
Manish Sharma manish...@gmail.com wrote:
Merged the two for loops. We might get a little gain by overlapping
wait_on_bh and the memcpy operations.
---
fs/squashfs/block.c |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/fs/squashfs/block.c b/fs/squashfs/block.c
On 25 July 2013 16:16, Dhaval Giani wrote:
> On 07/24/2013 07:36 PM, Jörn Engel wrote:
>
>> Assuming you use the chattr approach, that pretty much comes down to
>> adding compression support to ext4. There have been old patches for
>> ext2 around that never got merged. Reading up on the
On 25 July 2013 16:16, Dhaval Giani dgi...@mozilla.com wrote:
On 07/24/2013 07:36 PM, Jörn Engel wrote:
Assuming you use the chattr approach, that pretty much comes down to
adding compression support to ext4. There have been old patches for
ext2 around that never got merged. Reading up on
On 23 July 2013 16:10, Bruno Wolff III wrote:
> On Mon, Jul 22, 2013 at 03:21:01 +0100,
> Phillip Lougher wrote:
>>
>> Hi
>>
>> Now that LZ4 compression support is in 3.11-rc1, I have written the
>> following two patches for Squashfs to use it.
>
>
>
On 23 July 2013 16:10, Bruno Wolff III br...@wolff.to wrote:
On Mon, Jul 22, 2013 at 03:21:01 +0100,
Phillip Lougher phil...@squashfs.org.uk wrote:
Hi
Now that LZ4 compression support is in 3.11-rc1, I have written the
following two patches for Squashfs to use it.
If this gets accepted
On 22 July 2013 07:04, Gu Zheng wrote:
> On 07/22/2013 01:07 PM, Phillip Lougher wrote:
>
>> On 22 July 2013 04:05, Gu Zheng wrote:
>>> Hi Phillip,
>>> Have some tests been carried out to confirm that Squashfs really
>>> can get benefit f
On 22 July 2013 07:04, Gu Zheng guz.f...@cn.fujitsu.com wrote:
On 07/22/2013 01:07 PM, Phillip Lougher wrote:
On 22 July 2013 04:05, Gu Zheng guz.f...@cn.fujitsu.com wrote:
Hi Phillip,
Have some tests been carried out to confirm that Squashfs really
can get benefit from LZ4
to compress kernels and
initramfs data. Ultimately it is up to people to experiment and
choose whatever compression is best for their systems.
People are welcome to try the patches out and report their findings.
Phillip
>
> Thanks,
> Gu
>
> On 07/22/2013 10:21 AM, Phillip Lougher
Add the glue code, and also update the documentation.
Signed-off-by: Phillip Lougher
---
Documentation/filesystems/squashfs.txt |8
fs/squashfs/Kconfig| 15 +++
fs/squashfs/Makefile |1 +
fs/squashfs/decompressor.c
Add support for reading file systems compressed with the
LZ4 compression algorithm.
This patch adds the LZ4 decompressor wrapper code.
Signed-off-by: Phillip Lougher
---
fs/squashfs/lz4_wrapper.c | 163 +
fs/squashfs/squashfs_fs.h |1 +
2 files
Hi
Now that LZ4 compression support is in 3.11-rc1, I have written the
following two patches for Squashfs to use it.
Phillip Lougher (2):
Squashfs: add LZ4 compression support
Squashfs: Add LZ4 compression configuration option
Documentation/filesystems/squashfs.txt |8 +-
fs/squashfs
Hi
Now that LZ4 compression support is in 3.11-rc1, I have written the
following two patches for Squashfs to use it.
Phillip Lougher (2):
Squashfs: add LZ4 compression support
Squashfs: Add LZ4 compression configuration option
Documentation/filesystems/squashfs.txt |8 +-
fs/squashfs
Add the glue code, and also update the documentation.
Signed-off-by: Phillip Lougher phil...@squashfs.org.uk
---
Documentation/filesystems/squashfs.txt |8
fs/squashfs/Kconfig| 15 +++
fs/squashfs/Makefile |1 +
fs/squashfs
Add support for reading file systems compressed with the
LZ4 compression algorithm.
This patch adds the LZ4 decompressor wrapper code.
Signed-off-by: Phillip Lougher phil...@squashfs.org.uk
---
fs/squashfs/lz4_wrapper.c | 163 +
fs/squashfs
kernels and
initramfs data. Ultimately it is up to people to experiment and
choose whatever compression is best for their systems.
People are welcome to try the patches out and report their findings.
Phillip
Thanks,
Gu
On 07/22/2013 10:21 AM, Phillip Lougher wrote:
Hi
Now that LZ4
lization of mutex for each core */
> +i = 0;
> +msblk->read_data_mutex = kmalloc((processors)*sizeof(struct mutex),
> GFP_KERNEL);
> +if (NULL == msblk->read_data_mutex) {
> +ERROR("unable to allocate Mutex Mem \n");
> +goto failed_mount;
> +
On 15 July 2013 17:17, Dan Carpenter wrote:
> We read the size of the name from the disk, but a larger name than
> expected would cause memory corruption.
Thanks for the patch, it's queued for the next merge window. There's
one mistake with the patch, but I can fix it when it's applied, or you
On 15 July 2013 17:17, Dan Carpenter dan.carpen...@oracle.com wrote:
We read the size of the name from the disk, but a larger name than
expected would cause memory corruption.
Thanks for the patch, it's queued for the next merge window. There's
one mistake with the patch, but I can fix it when
+* As of now max queue request will not be more than 64.
+*/
+/* M.S Adding Threads here */
+initialise_threads(SQFS_QBUFFER_SIZE);
+
+#endif
printk(KERN_INFO squashfs: version 4.0 (2009/01/31)
Phillip Lougher\n);
@@ -456,6 +504,11 @@ static int __init init_squashfs_fs(void
> /lib/modules/3.9.0-rc2-next20130313-4-iniza-small/kernel/fs/overlayfs/overlayfs.ko
>> license:GPL
>> author: Miklos Szeredi
>> description:overlayfs v17, provides overlay-filesystem functionality
>> alias: fs-overlayfs
>> license:
: 3.9.0-rc2-next20130313-4-iniza-small SMP mod_unload
modversions
$ sudo modinfo squashfs
filename:
/lib/modules/3.9.0-rc2-next20130313-4-iniza-small/kernel/fs/squashfs/squashfs.ko
license:GPL
author: Phillip Lougher phil...@squashfs.org.uk
description:squashfs 4.0
On Thu, Sep 27, 2012 at 10:03 PM, Greg KH wrote:
> On Tue, Sep 04, 2012 at 08:52:44PM +0200, Geert Uytterhoeven wrote:
>>
>> So I think this warrants application to the stable 3.0, 3.1, and 3.2
>> branches.
>> Commit cc37f75a9ffbbfcb1c3297534f293c8284e3c5a6 ("Squashfs: fix
>> mount time sanity
On Thu, Sep 27, 2012 at 10:03 PM, Greg KH g...@kroah.com wrote:
On Tue, Sep 04, 2012 at 08:52:44PM +0200, Geert Uytterhoeven wrote:
So I think this warrants application to the stable 3.0, 3.1, and 3.2
branches.
Commit cc37f75a9ffbbfcb1c3297534f293c8284e3c5a6 (Squashfs: fix
mount time sanity
On Sun, Sep 9, 2012 at 7:17 PM, Ben Hutchings wrote:
>
> I've queued this up for 3.2, thanks.
Thanks Ben
Phillip
.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Sun, Sep 9, 2012 at 7:17 PM, Ben Hutchings b...@decadent.org.uk wrote:
I've queued this up for 3.2, thanks.
Thanks Ben
Phillip
.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Christoph Hellwig wrote:
On Wed, Nov 21, 2007 at 02:02:43PM +, Phillip Lougher wrote:
Unfortunately the move to fixed little endian filesystem will involve
another filesystem layout change. The current filesystem layout still
uses packed bitfield structures, and it is impossible to swap
Dave Jones wrote:
The biggest problem we've seen with it (asides from having to rediff
it every time we rebase when there isn't a newer upstream)
Yes, this is mainly my fault. There was a gap of 10 months between the
3.2 release in January this year, and the latest in November. With the
Dave Jones wrote:
The biggest problem we've seen with it (asides from having to rediff
it every time we rebase when there isn't a newer upstream)
Yes, this is mainly my fault. There was a gap of 10 months between the
3.2 release in January this year, and the latest in November. With the
Christoph Hellwig wrote:
On Wed, Nov 21, 2007 at 02:02:43PM +, Phillip Lougher wrote:
Unfortunately the move to fixed little endian filesystem will involve
another filesystem layout change. The current filesystem layout still
uses packed bitfield structures, and it is impossible to swap
maximilian attems wrote:
On Mon, Nov 05, 2007 at 11:13:14AM +, Phillip Lougher wrote:
The next stage after this release is to fix the one remaining blocking issue
(filesystem endianness), and then try to get Squashfs mainlined into the
Linux kernel again.
that would be very cool!
Yes
maximilian attems wrote:
On Mon, Nov 05, 2007 at 11:13:14AM +, Phillip Lougher wrote:
The next stage after this release is to fix the one remaining blocking issue
(filesystem endianness), and then try to get Squashfs mainlined into the
Linux kernel again.
that would be very cool!
Yes
in
squashfs_readpage() if I/O error occurs.
4.2. Fixed Squashfs kernel code bug preventing file
seeking beyond 2GB.
4.3. Mksquashfs now detects file size changes between
first phase directory scan and second phase filesystem create.
Regards
Phillip Lougher
-
To unsubscribe
in
squashfs_readpage() if I/O error occurs.
4.2. Fixed Squashfs kernel code bug preventing file
seeking beyond 2GB.
4.3. Mksquashfs now detects file size changes between
first phase directory scan and second phase filesystem create.
Regards
Phillip Lougher
-
To unsubscribe
Nate Diller wrote:
wow, you're right. I was sure I compile-tested this ... oh, "depends
on MTD". oops.
thanks for reviewing. does it look OK to you otherwise?
Yes..
NATE
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL
Nate Diller wrote:
+ page = read_cache_page(OFNI_EDONI_2SFFJ(f)->i_mapping,
+ start >> PAGE_CACHE_SHIFT,
+ (void *)jffs2_do_readpage_unlock,
+ OFNI_EDONI_2SFFJ(f));
- if (IS_ERR(pg_ptr)) {
+
Nate Diller wrote:
+ page = read_cache_page(OFNI_EDONI_2SFFJ(f)-i_mapping,
+ start PAGE_CACHE_SHIFT,
+ (void *)jffs2_do_readpage_unlock,
+ OFNI_EDONI_2SFFJ(f));
- if (IS_ERR(pg_ptr)) {
+ if
Nate Diller wrote:
wow, you're right. I was sure I compile-tested this ... oh, depends
on MTD. oops.
thanks for reviewing. does it look OK to you otherwise?
Yes..
NATE
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL
Hi,
I'm pleased to announce the release of Squashfs 3.2. NFS exporting
is now supported, and the kernel code has been hardened against
accidently or maliciously corrupted filesystems. The new release
correctly handles all corrupted filesystems generated by the fsfuzzer
tool (written by
Hi,
I'm pleased to announce the release of Squashfs 3.2. NFS exporting
is now supported, and the kernel code has been hardened against
accidently or maliciously corrupted filesystems. The new release
correctly handles all corrupted filesystems generated by the fsfuzzer
tool (written by
Dave Johnson wrote:
Patch below fixes this by making get_cramfs_inode() use the inode
cache before blindly creating a new entry every time. This eliminates
the duplicate inodes and duplicate buffer cache.
> + struct inode * inode = iget_locked(sb, CRAMINO(cramfs_inode));
Doesn't
Dave Johnson wrote:
Patch below fixes this by making get_cramfs_inode() use the inode
cache before blindly creating a new entry every time. This eliminates
the duplicate inodes and duplicate buffer cache.
+ struct inode * inode = iget_locked(sb, CRAMINO(cramfs_inode));
Doesn't
Jan Engelhardt wrote:
After a short flash of
idea and comparison, it turns out that squashfs is missing
sb->s_export->get_parent (the only requirement as it seems). Includes that you
have sb->s_export non-null, of course. sb->s_export can be set within
fill_super().
Ok, thanks. I'll try
Jan Engelhardt wrote:
After a short flash of
idea and comparison, it turns out that squashfs is missing
sb-s_export-get_parent (the only requirement as it seems). Includes that you
have sb-s_export non-null, of course. sb-s_export can be set within
fill_super().
Ok, thanks. I'll try and
On 8/2/05, Jan Engelhardt <[EMAIL PROTECTED]> wrote:
>
> I found out that you cannot mount an exported squash fs. The exports(5) fsid=
> parameter does not help it [like it did with unionfs].
>
The exports(5) man page says fsid=num is necessary for filesystems on
non-block devices - I don't
On 8/2/05, Jan Engelhardt [EMAIL PROTECTED] wrote:
I found out that you cannot mount an exported squash fs. The exports(5) fsid=
parameter does not help it [like it did with unionfs].
The exports(5) man page says fsid=num is necessary for filesystems on
non-block devices - I don't know
Jörn Engel wrote:
Your definition of _unnecessary_ casts may differ from mine.
Basically, every cast is unnecessary, except for maybe one or two - if
that many.
Well we agree to differ then. In my experience casts are sometimes
necessary, and are often less clumsy than the alternatives (such as
Jörn Engel wrote:
Squashfs is extremely cast-happy. This patch makes it less so.
Jörn
Hi,
Thanks for the patch. Unnecessary casts were one of the things
mentioned when I submitted the patches to the LKML, and therefore I
suspect most of them have been already fixed (but I will apply your
Jörn Engel wrote:
Squashfs is extremely cast-happy. This patch makes it less so.
Jörn
Hi,
Thanks for the patch. Unnecessary casts were one of the things
mentioned when I submitted the patches to the LKML, and therefore I
suspect most of them have been already fixed (but I will apply your
Jörn Engel wrote:
Your definition of _unnecessary_ casts may differ from mine.
Basically, every cast is unnecessary, except for maybe one or two - if
that many.
Well we agree to differ then. In my experience casts are sometimes
necessary, and are often less clumsy than the alternatives (such as
On Apr 10, 2005 2:42 AM, Petr Baudis <[EMAIL PROTECTED]> wrote:
> Dear diary, on Sun, Apr 10, 2005 at 03:01:12AM CEST, I got a letter
> where Phillip Lougher <[EMAIL PROTECTED]> told me that...
> > On Apr 9, 2005 3:53 AM, Petr Baudis <[EMAIL PROTECTED]> wrote:
>
On Apr 9, 2005 3:53 AM, Petr Baudis <[EMAIL PROTECTED]> wrote:
> FWIW, I made few small fixes (to prevent some trivial usage errors to
> cause cache corruption) and added scripts gitcommit.sh, gitadd.sh and
> gitlog.sh - heavily inspired by what already went through the mailing
> list.
On Apr 9, 2005 3:53 AM, Petr Baudis [EMAIL PROTECTED] wrote:
FWIW, I made few small fixes (to prevent some trivial usage errors to
cause cache corruption) and added scripts gitcommit.sh, gitadd.sh and
gitlog.sh - heavily inspired by what already went through the mailing
list. Everything is
On Apr 10, 2005 2:42 AM, Petr Baudis [EMAIL PROTECTED] wrote:
Dear diary, on Sun, Apr 10, 2005 at 03:01:12AM CEST, I got a letter
where Phillip Lougher [EMAIL PROTECTED] told me that...
On Apr 9, 2005 3:53 AM, Petr Baudis [EMAIL PROTECTED] wrote:
FWIW, I made few small fixes (to prevent
H. Peter Anvin wrote:
Phil Lougher wrote:
Making readdir return '.' and '..' is trivially easy, as all the
required information to fake '.' and '..' entries are present.
The lack of '.' and '..' entries hasn't caused any problems despite
cramfs/squashfs being used for a large number of years. I'm
H. Peter Anvin wrote:
Phil Lougher wrote:
Making readdir return '.' and '..' is trivially easy, as all the
required information to fake '.' and '..' entries are present.
The lack of '.' and '..' entries hasn't caused any problems despite
cramfs/squashfs being used for a large number of years. I'm
Pavel Machek wrote:
And people merging xfs/reiserfs4/etc did address problems pointed out
in their code.
Where did I say I wasn't addressing the problems pointed out in the
code. All the issues I can fix I am addressing.
Pavel
-
Pavel Machek wrote:
Hi!
Perhaps squashfs is good enough improvement over cramfs... But I'd
like those 4Gb limits to go away.
So would I. But it is a totally groundless reason to refuse kernel
submission because of that, Squashfs users are quite happily using it
with such a "terrible"
101 - 200 of 226 matches
Mail list logo