Re: [PATCH v2 1/3] dmaengine: qcom_bam_dma: Generalize BAM register offset calculations

2014-10-01 Thread Pramod Gurav
On Tuesday 30 September 2014 03:44 AM, Andy Gross wrote: > On Mon, Sep 29, 2014 at 10:03:07AM +0530, Archit Taneja wrote: >> The BAM DMA IP comes in different versions. The register offset layout varies >> among these versions. The layouts depend on which generation/family of SoCs >> they >> belon

Re: [PATCH] HID: cp2112: remove use of gpiochip_remove() retval

2014-10-01 Thread Pramod Gurav
On Wednesday 01 October 2014 01:31 PM, Jiri Kosina wrote: > On Wed, 1 Oct 2014, Pramod Gurav wrote: > >>>>> Cc: Linus Walleij >>>>> Cc: Alexandre Courbot >>>>> Cc: Jiri Kosina >>>>> Cc: linux-in...@vger.kernel.org >>&g

Re: [PATCH 1/2] gpio: remove remaining users of gpiochip_remove() retval

2014-10-01 Thread Pramod Gurav
On Wednesday 01 October 2014 01:13 PM, Linus Walleij wrote: > On Tue, Sep 30, 2014 at 4:15 PM, Pramod Gurav > wrote: > >> Some driver in gpio still check for return value from gpiochip_remove >> Get rid of the check for return value. >> >> Cc: Linus Walleij

Re: [PATCH] ssb: Fix Sparse error in main

2014-10-01 Thread Pramod Gurav
On Wednesday 01 October 2014 12:59 PM, Paul Bolle wrote: > On Wed, 2014-10-01 at 12:36 +0530, Pramod Gurav wrote: >> This change fixes below sparse error: >> >> drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus' >> was not declared. Should i

Re: [PATCH] HID: cp2112: remove use of gpiochip_remove() retval

2014-10-01 Thread Pramod Gurav
inux-in...@vger.kernel.org >> > Cc: linux-g...@vger.kernel.org >> > >> > Signed-off-by: Pramod Gurav > I guess this depends on some other patch that hasn't gone to Linus yet, > right? As Linus' tree currently has this prototype: > > int gpio

[PATCH] ssb: Fix Sparse error in main

2014-10-01 Thread Pramod Gurav
This change fixes below sparse error: drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus' was not declared. Should it be static? Cc: Michael Buesch Cc: net...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/ssb/ssb_private.h |1 + 1 file changed, 1 insertio

[PATCH] ssb: gpio: remove use of gpiochip_remove() retval

2014-09-30 Thread Pramod Gurav
Get rid of using return value from gpiochip_remove() as it returns void with a new change in kernel. Cc: Linus Walleij Cc: Alexandre Courbot Cc: Michael Buesch Cc: net...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/ssb/driver_gpio.c |3 ++- 1 file changed, 2 insertions(+), 1

[PATCH] serial: remove use of gpiochip_remove() retval

2014-09-30 Thread Pramod Gurav
Get rid of using return value from gpiochip_remove() as it returns void with a new change in kernel. Cc: Linus Walleij Cc: Alexandre Courbot Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: linux-ser...@vger.kernel.org Cc: linux-g...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/tty

[PATCH] ASoC: remove use of gpiochip_remove() retval

2014-09-30 Thread Pramod Gurav
: Pramod Gurav --- sound/soc/codecs/wm5100.c |5 + sound/soc/codecs/wm8903.c |6 +- sound/soc/codecs/wm8962.c |5 + sound/soc/codecs/wm8996.c |6 +- 4 files changed, 4 insertions(+), 18 deletions(-) diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c

[PATCH 2/2] led: remove use of gpiochip_remove() retval

2014-09-30 Thread Pramod Gurav
Get rid of using return value from gpiochip_remove() as it returns void. Cc: Linus Walleij Cc: Alexandre Courbot Cc: Bryan Wu Cc: Richard Purdie Cc: linux-l...@vger.kernel.org Cc: linux-g...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/leds/leds-pca9532.c | 10

[PATCH 1/2] input: remove use of gpiochip_remove() retval

2014-09-30 Thread Pramod Gurav
Get rid of using return value from gpiochip_remove() as it returns void. Cc: Linus Walleij Cc: Alexandre Courbot Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Cc: linux-g...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/input/keyboard/adp5588-keys.c |4 +--- drivers

[PATCH] HID: cp2112: remove use of gpiochip_remove() retval

2014-09-30 Thread Pramod Gurav
Get rid of using return value from gpiochip_remove() as it returns void. Cc: Linus Walleij Cc: Alexandre Courbot Cc: Jiri Kosina Cc: linux-in...@vger.kernel.org Cc: linux-g...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/hid/hid-cp2112.c |6 ++ 1 file changed, 2

[PATCH 2/2] mfd: remove use of gpiochip_remove() retval

2014-09-30 Thread Pramod Gurav
Get rid of using return value from gpiochip_remove() as it returns void. Cc: Linus Walleij Cc: Alexandre Courbot Cc: Samuel Ortiz CC: Lee Jones Cc: linux-g...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mfd/asic3.c|3 ++- drivers/mfd/htc-i2cpld.c |6

[PATCH 1/2] gpio: remove remaining users of gpiochip_remove() retval

2014-09-30 Thread Pramod Gurav
Some driver in gpio still check for return value from gpiochip_remove Get rid of the check for return value. Cc: Linus Walleij Cc: Alexandre Courbot Cc: linux-g...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/gpio/gpio-crystalcove.c | 12 drivers/gpio/gpio-omap.c

[PATCH v2] pinctrl: st: Fix Sparse error

2014-09-29 Thread Pramod Gurav
lin Cc: Patrice Chotard CC: Linus Walleij Cc: Srinivas Kandagatla Signed-off-by: Pramod Gurav --- drivers/pinctrl/pinctrl-st.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index 5475374..2ff0da8 100644 --

Re: [PATCH] pinctrl: st: Fix Sparse error

2014-09-29 Thread Pramod Gurav
On Mon, Sep 29, 2014 at 9:08 PM, Srinivas Kandagatla wrote: > > > On 29/09/14 16:05, Pramod Gurav wrote: >>> >>> >I think the correct fix is: >>> > >>> >diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c >>> &g

Re: [PATCH] pinctrl: st: Fix Sparse error

2014-09-29 Thread Pramod Gurav
Hi Srini, Thanks for review. On Mon, Sep 29, 2014 at 8:16 PM, Srinivas Kandagatla wrote: > On 29/09/14 14:48, Pramod Gurav wrote: >> >> This change fixes below sparse error, >> drivers/pinctrl/pinctrl-st.c:1515:31: error: incompatible types for >> operation (>) &

[PATCH] pinctrl: st: Fix Sparse error

2014-09-29 Thread Pramod Gurav
by removing a check on info->irqmux_base as info->irqmux_base has already been checked for error when allocating it. Hence there is no need to redo the check. Cc: Maxime Coquelin Cc: Patrice Chotard CC: Linus Walleij Cc: Srinivas Kandagatla Signed-off-by: Pramod Gurav --- drivers/pinctr

[PATCH] mmc: sdhci-pxav3: Fix Sparse warning of duplicate set_uhs_signaling entry

2014-09-29 Thread Pramod Gurav
: Russell King Cc: Ulf Hansson Cc: Chris Ball Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/sdhci-pxav3.c | 37 - 1 file changed, 37 deletions(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c

[PATCH] usb: phy: msm: Fix Sparse warning

2014-09-29 Thread Pramod Gurav
This change fixes below sparse warning: drivers/usb/phy/phy-msm-usb.c:1397:30: warning: symbol 'msm_otg_mode_fops' was not declared.Should it be static? Cc: Srinivas Kandagatla Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- d

Re: [PATCH v4] power: reset: use restart_notifier mechanism for msm-poweroff

2014-09-26 Thread Pramod Gurav
On 27-09-2014 01:55 AM, Sebastian Reichel wrote: > Hi, > > On Thu, Sep 25, 2014 at 05:03:51PM +0530, Pramod Gurav wrote: >> This change replaces use of arm_pm_restart with recently introduced >> reset mechanism in Linux kernel called restart_notifier. >> >> Choosi

Re: [PATCH] mmc: atmel-mci: fix mismatched section on atmci_cleanup_slot

2014-09-26 Thread Pramod Gurav
Hi Arnd, On Sat, Sep 27, 2014 at 1:04 AM, Arnd Bergmann wrote: > As of 528bc7808f4e ("mmc: atmel-mci: Release mmc resources on failure in > probe"), > the atmci_probe() function calls atmci_cleanup_slot in the failure path. > > This causes a new warning whenever the driver is built: > > WARNING:

[PATCH] ARM: multi_v7_defconfig: Add Support for QCOM SDHCI Controller

2014-09-26 Thread Pramod Gurav
: Georgi Djakov Signed-off-by: Pramod Gurav --- arch/arm/configs/multi_v7_defconfig |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index bad9d92..cc55117 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm

[PATCH] mmc: davinci: Fix and simplify probe failure path

2014-09-26 Thread Pramod Gurav
-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/davinci_mmc.c | 91 +++- 1 file changed, 33 insertions(+), 58 deletions(-) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index 5d4c5e0..160b7e8 100644 --- a

Re: linux-next: build failure after merge of the watchdog tree

2014-09-25 Thread Pramod Gurav
On Friday 26 September 2014 11:10 AM, Stephen Rothwell wrote: > Hi Wim, > > After merging the watchdog tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > > drivers/watchdog/meson_wdt.c: In function 'meson_wdt_probe': > drivers/watchdog/meson_wdt.c:178:2: error: impli

[PATCH] ARM: multi_v7_defconfig: Add Support for QCOM APQ8074 reset

2014-09-25 Thread Pramod Gurav
This change adds support for reset driver for apq8074 based platform. With this we should be able to reboot the board from command prompt. Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org Cc: linux-arm-...@vger.kernel.org Signed-off-by: Pramod Gurav --- arch/arm/configs

[PATCH v4] power: reset: use restart_notifier mechanism for msm-poweroff

2014-09-25 Thread Pramod Gurav
Cartwright Cc: Sebastian Reichel Cc: Dmitry Eremin-Solenikov Cc: David Woodhouse Cc: Stephen Boyd Cc: linux...@vger.kernel.org Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd Signed-off-by: Pramod Gurav --- Why reset handler in pinctrl-msm wont collide with reset in poweroff-msm.c in

Re: [PATCH] thermal: ti-soc-thermal: Switch to using managed resources

2014-09-25 Thread Pramod Gurav
+Valentin On Friday 19 September 2014 11:35 PM, Pramod Gurav wrote: > This change switches to managed resource APIs to allocated resources > such as irq, clock. Hence does away with release statements of the > same resorces in error lables and remove function. > > Cc: Eduardo

Re: [PATCH v3] power: reset: use restart_notifier mechanism for msm-poweroff

2014-09-23 Thread Pramod Gurav
Hi Kumar, On 23-09-2014 11:18 PM, Kumar Gala wrote: > > On Sep 23, 2014, at 1:28 AM, Pramod Gurav > wrote: > >> +linux-arm-msm >> On Tuesday 23 September 2014 11:38 AM, Pramod Gurav wrote: >>> This change replaces use of arm_pm_restart with recently introd

[PATCH v2 1/2] mmc: atmel-mci: Switch to using managed resource in probe

2014-09-23 Thread Pramod Gurav
: Chris Ball Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- Changes since v1: - Dropped using devm_request_irq as suggested by Ludovic Desroches as it seems there are race conditions seen with them. - Added another patch to fix failure path in probe to call

[PATCH v2 2/2] mmc: atmel-mci: Release mmc resources on failure in probe

2014-09-23 Thread Pramod Gurav
This change takes care of releasing mmc resources on error cases in probe function which was missing. Also release timer in remove function. Cc: Ludovic Desroches Cc: Chris Ball Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- Changes since v1: None drivers/mmc

[PATCH v2 1/2] mmc: atmel-mci: Switch to using managed resource in probe

2014-09-23 Thread Pramod Gurav
: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- Changes since v1: - Dropped using devm_request_irq as suggested by Ludovic Desroches as it seems there are race conditions seen with them. - Added another patch to fix failure path in probe to call atmci_cleanup_slot after

Re: [PATCH v3] power: reset: use restart_notifier mechanism for msm-poweroff

2014-09-22 Thread Pramod Gurav
+linux-arm-msm On Tuesday 23 September 2014 11:38 AM, Pramod Gurav wrote: > This change replaces use of arm_pm_restart with recently introduced > reset mechanism in Linux kernel called restart_notifier. > > Reviewed-by: Guenter Roeck > Cc: Guenter Roeck > Cc: Josh Cartwrigh

[PATCH v3] power: reset: use restart_notifier mechanism for msm-poweroff

2014-09-22 Thread Pramod Gurav
...@vger.kernel.org Signed-off-by: Pramod Gurav --- Tested on Dragonboard APQ8074 Changes since v2: - Removed unwanted header file and added linux/pm.h Changes since v1: - Initialized restart_nb with its declaration - Removed return check for register_restart_handler as it always returns 0 as per

Re: [PATCH 1/2] mmc: atmel-mci: Switch to using managed resource in probe

2014-09-22 Thread Pramod Gurav
uest_irq and free_irq the time it takes to solve this issue > is probably better. Oh, Thanks for letting me know this. I will resend this patch keeping request_irq and free_irq in driver. > > Regards > > Ludovic > > On Sat, Sep 20, 2014 at 12:22:30PM +0530, Pramod Gurav wrote:

[PATCH] mmc: omap_hsmmc: Switch to using managed version to gpio request

2014-09-22 Thread Pramod Gurav
This change switches to managed version of gpio_request to simplify module unloading and failure cases and does away with code to release gpio resources. Cc: Balaji T K Cc: Chris Ball Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/omap_hsmmc.c

[PATCH v2] power: reset: use restart_notifier mechanism for msm-poweroff

2014-09-22 Thread Pramod Gurav
-by: Pramod Gurav --- Tested on Dragonboard APQ8074 Changes since v1: - Initialized restart_nb with its declaration - Removed return check for register_restart_handler as it always returns 0 as per Guenter's suggestion to Josh's similar patch. This takes care of Guenter's comment

[PATCH] mmc: usdhi6rol0: Remove unnecessary header files

2014-09-20 Thread Pramod Gurav
These headers are not required hence this change removes them from the driver. Cc: Guennadi Liakhovetski Cc: Chris Ball Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/usdhi6rol0.c | 7 --- 1 file changed, 7 deletions(-) diff --git a

[PATCH] mmc: android-goldfish: Remove unnecessary NULL check on host

2014-09-20 Thread Pramod Gurav
This change removes unwanted NULL check around mmc private data structure in remove function as the probe would not have succeeded with this structure variable as NULL. Cc: Chris Ball Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/android

[PATCH 1/2] mmc: atmel-mci: Switch to using managed resource in probe

2014-09-19 Thread Pramod Gurav
Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/atmel-mci.c | 57 1 file changed, 20 insertions(+), 37 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index bb585d9..21a222c 100644

[PATCH 2/2] mmc: atmel-mci: Release mmc resources on failure in probe

2014-09-19 Thread Pramod Gurav
This change takes care of releasing mmc resources on error cases in probe function which was missing. Also release timer in remove function. Cc: Ludovic Desroches Cc: Chris Ball Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/atmel-mci.c | 13

[PATCH] thermal: ti-soc-thermal: Switch to using managed resources

2014-09-19 Thread Pramod Gurav
This change switches to managed resource APIs to allocated resources such as irq, clock. Hence does away with release statements of the same resorces in error lables and remove function. Cc: Eduardo Valentin Cc: Zhang Rui Cc: linux...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers

Re: [PATCH] power: reset: use restart_notifier mechanism for msm poweroff

2014-09-19 Thread Pramod Gurav
Hi Guenter, Thanks for you. On 19-09-2014 07:23 PM, Guenter Roeck wrote: > On 09/19/2014 05:06 AM, Pramod Gurav wrote: >> This change uses replaces use of arm_pm_restart with recently introduced >> reset mechanism in Linux kernel called restart_notifier. >> >> Cc:

Re: [PATCH v7 00/11] kernel: Add support for restart handler call chain

2014-09-19 Thread Pramod Gurav
Hello Guenter, Thanks for the patches. Tested patches 1,2 & 4 from this series on qcom apq8064 based IFC6410 with Josh's patches which replace arm restart with restart notifier for this target. Tested-by: pramod.gu...@smartplayin.com On Wednesday 20 August 2014 06:15 AM, Guenter Roeck wrote: > V

Re: [PATCH 3/3] watchdog: qcom: register a restart notifier

2014-09-19 Thread Pramod Gurav
Hi Josh, Tested this patch on IFC6410 by disabling pinctrl ps_hold reset implementation and on top of Guenter's patchset for restart_notifier. Tested-by: pramod.gu...@smartplayin.com I picked up DT changes from bindings as they are from this patchset. Thanks Pramod On Friday 19 September 2014 0

Re: [PATCH] pinctrl: qcom: use restart_notifier mechanism for ps_hold

2014-09-19 Thread Pramod Gurav
ase where PS_HOLD has failed to reset the chip. > > Choose priority 128, as according to documentation, this mechanism "is > sufficient to restart the entire system". > > Cc: Pramod Gurav > Cc: Guenter Roeck > Signed-off-by: Josh Cartwright > --- -- To unsubscribe

[PATCH] power: reset: use restart_notifier mechanism for msm poweroff

2014-09-19 Thread Pramod Gurav
-off-by: Pramod Gurav --- This patch is tested on DB8074 Target and are based on patchset [1] by Guenter Roeck. [1]: https://patchwork.kernel.org/patch/4746721/ drivers/power/reset/msm-poweroff.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 4/5] mmc: msm_sdcc: Remove duplicate check around dmares

2014-09-16 Thread Pramod Gurav
ux-arm-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/msm_sdcc.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c index 2111c03..5025364 100644 --- a/drivers/mmc/host/msm_sdcc.c +++ b/drivers/mmc/host/msm_

[PATCH 5/5] mmc: msm_sdcc: Remove unwanted initializations in probe

2014-09-16 Thread Pramod Gurav
This removes unnecessary initialisations of resource pointers and does away with a lable and just returns error on fail instead. Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman CC: Ulf Hansson CC: linux-...@vger.kernel.org CC: linux-arm-...@vger.kernel.org Signed-off-by: Pramod Gurav

[PATCH 2/5] mmc: msm_sdcc: Add support for platform_driver remove function

2014-09-16 Thread Pramod Gurav
This change adds remove function in platform_driver to clean unloading Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman CC: Ulf Hansson CC: linux-...@vger.kernel.org CC: linux-arm-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/msm_sdcc.c | 18

[PATCH 3/5] mmc: msm_sdcc: Replace pr_ with dev_

2014-09-16 Thread Pramod Gurav
This replaces pr_* with dev_ for message logging and also does away with printing function names in logs. Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman CC: Ulf Hansson CC: linux-...@vger.kernel.org CC: linux-arm-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host

[PATCH 1/5] mmc: msm_sdcc: Switch to using managed resources

2014-09-16 Thread Pramod Gurav
-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/msm_sdcc.c | 43 +-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c index 9405ecd..2b8ac9c 100644 --- a/drivers/mmc

[PATCH 0/5] mmc: msm_sdcc: Cleanups

2014-09-16 Thread Pramod Gurav
This patchset does some cleanups in msm sdcc driver. Pramod Gurav (5): mmc: msm_sdcc: Switch to using managed resources mmc: msm_sdcc: Add support for platform_driver remove function mmc: msm_sdcc: Replace pr_ with dev_ mmc: msm_sdcc: Remove duplicate check around dmares mmc: msm_sdcc

Re: [Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-09-12 Thread Pramod Gurav
On 13-09-2014 01:59 AM, Felipe Balbi wrote: > Hi, > > On Sat, Sep 13, 2014 at 01:55:50AM +0530, Pramod Gurav wrote: >>>>> + qdwc = devm_kzalloc(&pdev->dev, sizeof(*qdwc), GFP_KERNEL); >>>>> + if (!qdwc) >>>>> +

Re: [Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-09-12 Thread Pramod Gurav
Hi Felipe, On 13-09-2014 01:50 AM, Felipe Balbi wrote: > On Sat, Sep 13, 2014 at 01:44:25AM +0530, Pramod Gurav wrote: >> Andy, >> Couple of minor comments. >> >> On Sat, Sep 13, 2014 at 12:58 AM, Andy Gross wrote: >> >>> From: "Ivan T. Ivanov&quo

[PATCH v2 2/2] pinctrl: at91: Fix error handling while doing gpiochio_irqchip_add

2014-09-09 Thread Pramod Gurav
ce. CC: Jean-Christophe Plagniol-Villard CC: Linus Walleij Signed-off-by: Pramod Gurav --- Changes since v1: FIxed the error massage on gpiochio_irqchip_add failure to indicate failure to add irqchip to gpiochip. drivers/pinctrl/pinctrl-at91.c | 14 ++ 1 file changed, 10 ins

[PATCH v2 1/2] pinctrl: at91: Fix failure path in at91_gpio_probe path

2014-09-09 Thread Pramod Gurav
This fixes the whole error handling in probe function by capturing and returning error values on kernel function like clk_prepare, clk_enable, gpiochip_add etc. CC: Jean-Christophe Plagniol-Villard CC: Linus Walleij Signed-off-by: Pramod Gurav --- Changes since v1: Used PTR_ERR instead of

[PATCH v2] pinctrl: lantiq: Release gpiochip resources in fail case

2014-09-09 Thread Pramod Gurav
This patch releases gpiochip resources with of_gpiochip_remove and gpiochip_remove in failure cases. CC: John Crispin CC: Linus Walleij Signed-off-by: Pramod Gurav --- Changes since v1: Dropped call to of_gpiochip_remove() when ltq_pinctrl_register fails as gpiochip_remove() calls

[PATCH v1] pinctrl: lantiq: Release gpiochip resources in fail case

2014-09-09 Thread Pramod Gurav
This patch releases gpiochip resources with of_gpiochip_remove and gpiochip_remove in failure cases. CC: John Crispin CC: Linus Walleij Signed-off-by: Pramod Gurav --- Changes since v1: Dropped call to of_gpiochip_remove() when ltq_pinctrl_register fails as gpiochip_remove() calls

[PATCH v2] pinctrl: st: remove gpiochip in failure cases

2014-09-09 Thread Pramod Gurav
This patch releases gpiochip related resources by calling gpiochip_remove when gpiochip_irqchip_add fails. CC: Srinivas Kandagatla CC: Srinivas Kandagatla CC: Maxime Coquelin CC: Patrice Chotard CC: Linus Walleij CC: Bjorn Andersson Signed-off-by: Pramod Gurav --- Changes since v1

Re: [PATCH v2 00/15] Krait clocks + Krait CPUfreq

2014-09-08 Thread Pramod Gurav
Sorry Stephen for spaming. I read the full patch cover letter and found your note. Somehow I missed on that. Thanks Pramod On Monday 08 September 2014 03:12 PM, Pramod Gurav wrote: > Hi Stephen, > Looks like one patch is missing from v1. Is this removed from v2 > patchset from so

Re: [PATCH v2 00/15] Krait clocks + Krait CPUfreq

2014-09-08 Thread Pramod Gurav
Hi Stephen, Looks like one patch is missing from v1. Is this removed from v2 patchset from some reason? ARM: Add Krait L2 register accessor functions But there are references to this in v2 set and build fails while compiling drivers/clk/qcom/clk-krait.c. Thanks and Regards Pramod On Satu

Re: [PATCH] pinctrl: st: Add remove function and remove gpio_chip on failure

2014-09-04 Thread Pramod Gurav
Hi Srini, Thanks for review. On 04-09-2014 11:38 PM, Srinivas Kandagatla wrote: > Pramod, > sorry for delay in reply as I was travelling, still in Jet lag. >> Signed-off-by: Pramod Gurav >> --- >> drivers/pinctrl/pinctrl-st.c | 25 +

[PATCH] pinctrl: lantiq: Release gpiochip resources in fail case

2014-08-31 Thread Pramod Gurav
This patch releases gpiochip resources with of_gpiochip_remove gpiochip_remove in failure cases. CC: John Crispin CC: Linus Walleij Signed-off-by: Pramod Gurav --- drivers/pinctrl/pinctrl-xway.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/pinctrl/pinctrl

[PATCH 2/4] pinctrl: at91: Fix failure path in at91_gpio_probe path

2014-08-31 Thread Pramod Gurav
This fixes the whole error handling in probe function by capturing and returning error values on kernel function like clk_prepare, clk_enable, gpiochip_add etc. CC: Jean-Christophe Plagniol-Villard CC: Linus Walleij Signed-off-by: Pramod Gurav --- drivers/pinctrl/pinctrl-at91.c | 20

[PATCH 4/4] pinctrl: at91: Add remove function in platform_driver at91_gpio_driver

2014-08-31 Thread Pramod Gurav
This adds remove function in at91_gpio_driver platform_driver so that driver can be unloaded cleanly. CC: Jean-Christophe Plagniol-Villard CC: Linus Walleij Signed-off-by: Pramod Gurav --- drivers/pinctrl/pinctrl-at91.c | 13 + 1 files changed, 13 insertions(+), 0 deletions

[PATCH 3/4] pinctrl: at91: Fix error handling while doing gpiochio_irqchip_add

2014-08-31 Thread Pramod Gurav
from struct device_node to struct platform_device. Because The device_node argument was anyway not being used. Passed pdev so that on failure dev_err can use &pdev->dev and log can be associated with proper device. CC: Jean-Christophe Plagniol-Villard CC: Linus Walleij Signed-off-by: Pramo

[PATCH 1/4] pinctrl: at91: Switch to using managed clk_get

2014-08-31 Thread Pramod Gurav
This patch switches to using managed version of clk_get and hence removes clk_put from failure path. CC: Jean-Christophe Plagniol-Villard CC: Linus Walleij Signed-off-by: Pramod Gurav --- drivers/pinctrl/pinctrl-at91.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff

[PATCH 0/4] pinctrl: at91: Fixes in probe function

2014-08-31 Thread Pramod Gurav
This patchset modifies the probe function to do some changes such as switching to manage version of clk_get, fixing the error path by releasing resources etc. The last patch adds a remove function for clean unload. Pramod Gurav (4): pinctrl: at91: Switch to using managed clk_get pinctrl

[PATCH] pinctrl: adi2: Remove duplicate gpiochip_remove_pin_ranges from remove function

2014-08-30 Thread Pramod Gurav
This patch removes call to gpiochip_remove_pin_ranges() from platform_driver remove function as it will anway be called by gpiochip_remove(). CC: Sonic Zhang CC: Linus Walleij Signed-off-by: Pramod Gurav --- drivers/pinctrl/pinctrl-adi2.c |1 - 1 files changed, 0 insertions(+), 1

[PATCH] pinctrl: bcm281xx: Add remove function to pinctrl_unregister

2014-08-30 Thread Pramod Gurav
This patch adds a remove function in platform_driver to pinctrl_unregister for clean unloading. This makes local struct pinctrl_dev a part of struct bcm281xx_pinctrl_data to be accessed from pdev in remove function. CC: Sherman Yin CC: Linus Walleij Signed-off-by: Pramod Gurav --- drivers

[PATCH] pinctrl: st: Add remove function and remove gpio_chip on failure

2014-08-30 Thread Pramod Gurav
: Linus Walleij CC: Bjorn Andersson Signed-off-by: Pramod Gurav --- drivers/pinctrl/pinctrl-st.c | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index 5475374..9296845 100644 --- a/drivers

[PATCH] pinctrl: sirf: Remove gpiochip on failure cases

2014-08-30 Thread Pramod Gurav
This patch releases gpiochip related resources by calling gpiochip_remove when gpiochip_irqchip_add fails. CC: Linus Walleij CC: Barry Song CC: Rongjun Ying CC: Yuping Luo Signed-off-by: Pramod Gurav --- drivers/pinctrl/sirf/pinctrl-sirf.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064

2014-08-29 Thread Pramod Gurav
Bjorn, Thanks for review. :) On 30-08-2014 12:12 AM, Bjorn Andersson wrote: > On Fri 29 Aug 07:30 PDT 2014, Pramod Gurav wrote: > >> This patch adds support for reset functions to reboot the boards >> with soc apq8064. >> >> CC: Linus Walleij >> CC: Bjo

Re: [PATCH v2] pinctrl: qcom: remove gpiochip in failure cases

2014-08-29 Thread Pramod Gurav
Hi Bjorn, On 30-08-2014 12:27 AM, Bjorn Andersson wrote: > On Fri 29 Aug 01:11 PDT 2014, Pramod Gurav wrote: > >> This patch releases gpiochip related resources by calling >> gpiochip_remove when either of gpiochip_add_pin_range and >> gpiochip_irqchip_add fails. >&g

Re: [PATCH v2] pinctrl: qcom: remove gpiochip in failure cases

2014-08-29 Thread Pramod Gurav
Hi Bjorn, On 30-08-2014 12:27 AM, Bjorn Andersson wrote: > On Fri 29 Aug 01:11 PDT 2014, Pramod Gurav wrote: > >> This patch releases gpiochip related resources by calling >> gpiochip_remove when either of gpiochip_add_pin_range and >> gpiochip_irqchip_add fails. >&g

[PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064

2014-08-29 Thread Pramod Gurav
This patch adds support for reset functions to reboot the boards with soc apq8064. CC: Linus Walleij CC: Bjorn Andersson CC: "Ivan T. Ivanov" CC: Stephen Boyd CC: Andy Gross Signed-off-by: Pramod Gurav --- drivers/pinctrl/qcom/pinctrl-apq8064.c |7 ++- drivers/pinctrl/qc

[PATCH v3 3/4] pinctrl: msm: Add ps_hold function in pinctrl-apq8064 binding documentation

2014-08-29 Thread Pramod Gurav
This adds a function ps_hold (Power Suppy Hold Signal) in pinctrl-ap8064 documentation which was missing. This function is used to reset the targets with apq8064 soc. CC: Linus Walleij Acked-by: Bjorn Andersson CC: "Ivan T. Ivanov" CC: Stephen Boyd CC: Andy Gross Signed-off-by: Pr

[PATCH v3 1/4] ARM: DT: APQ8064: Add pinctrl support

2014-08-29 Thread Pramod Gurav
This patch adds device tree nodes to support pinctrl for apq8064 SOC CC: Rob Herring CC: Pawel Moll CC: Mark Rutland CC: Ian Campbell CC: Kumar Gala CC: devicet...@vger.kernel.org CC: linux-arm-ker...@lists.infradead.org Signed-off-by: Pramod Gurav --- arch/arm/boot/dts/qcom-apq8064.dtsi

[PATCH v3 2/4] ARM: DT: APQ8064: Add node for ps_hold function in pinctrl

2014-08-29 Thread Pramod Gurav
This patch adds DT support to configure GPIO_78 as function ps_hold on apq8064. CC: Rob Herring CC: Pawel Moll CC: Mark Rutland CC: Ian Campbell CC: Kumar Gala CC: devicet...@vger.kernel.org CC: linux-arm-ker...@lists.infradead.org Signed-off-by: Pramod Gurav --- arch/arm/boot/dts/qcom

[PATCH v3 0/4] Add reset support for apq8064

2014-08-29 Thread Pramod Gurav
anges since v1 to v2: 1. Added #error log as suggested by Kumar Gala 2. Correct interrupts in DT from 32 to 16 based on Bjorn's new patch in bindings 3. Replaced hardcoding in DT with IRQ_TYPE_LEVEL_HIGH for interrupt level type Pramod Gurav (4): ARM: DT: APQ8064: Add pinctrl support

Re: [PATCH 4/4] pinctrl: qcom: Add support for reset for apq8064

2014-08-29 Thread Pramod Gurav
Hi Bjorn, On 29-08-2014 06:58 AM, Bjorn Andersson wrote: > On Thu 28 Aug 20:22 PDT 2014, Pramod Gurav wrote: > >> This patch adds support for reset functions to reboot the boards >> with soc apq8064. >> >> CC: Linus Walleij >> CC: Bjorn Andersson >>

[PATCH v2] pinctrl: qcom: remove gpiochip in failure cases

2014-08-29 Thread Pramod Gurav
This patch releases gpiochip related resources by calling gpiochip_remove when either of gpiochip_add_pin_range and gpiochip_irqchip_add fails. CC: Linus Walleij CC: Bjorn Andersson CC: "Ivan T. Ivanov" Signed-off-by: Pramod Gurav --- Changes since v1: - In v1 of this patch gpioc

Re: [PATCH] pinctrl: qcom: Release pin ranges when gpiochip_irqchip_add fails

2014-08-29 Thread Pramod Gurav
On 29-08-2014 09:19 AM, Bjorn Andersson wrote: > On Thu 28 Aug 00:13 PDT 2014, Pramod Gurav wrote: > >> On Thursday 28 August 2014 02:54 AM, Bjorn Andersson wrote: >>> On Wed, Aug 27, 2014 at 3:57 AM, Pramod Gurav >>> wrote: >>>> This patches adds

[PATCH 4/4] pinctrl: qcom: Add support for reset for apq8064

2014-08-28 Thread Pramod Gurav
This patch adds support for reset functions to reboot the boards with soc apq8064. CC: Linus Walleij CC: Bjorn Andersson CC: "Ivan T. Ivanov" CC: Stephen Boyd CC: Andy Gross Signed-off-by: Pramod Gurav --- drivers/pinctrl/qcom/pinctrl-apq8064.c |7 +- drivers/pinctrl/qc

[PATCH 2/4] ARM: DT: APQ8064: Add node for ps_hold function in pinctrl

2014-08-28 Thread Pramod Gurav
This patch adds DT support to configure GPIO_78 as function ps_hold on apq8064. CC: Rob Herring CC: Pawel Moll CC: Mark Rutland CC: Ian Campbell CC: Kumar Gala CC: devicet...@vger.kernel.org CC: linux-arm-ker...@lists.infradead.org Signed-off-by: Pramod Gurav --- arch/arm/boot/dts/qcom

[PATCH 0/4] Add reset support for apq8064

2014-08-28 Thread Pramod Gurav
Kumar Gala 2. Correct interrupts in DT from 32 to 16 based on Bjorn's new patch in bindings 3. Replaced hardcoding in DT with IRQ_TYPE_LEVEL_HIGH for interrupt level type Pramod Gurav (4): ARM: DT: APQ8064: Add pinctrl support ARM: DT: APQ8064: Add node for ps_hold function in pinctrl pi

[PATCH 3/4] pinctrl: msm: Add ps_hold function in pinctrl-apq8064 binding documentation

2014-08-28 Thread Pramod Gurav
This adds a function ps_hold (Power Suppy Hold Signal) in pinctrl-ap8064 documentation which was missing. This function is used to reset the targets with apq8064 soc. CC: Linus Walleij CC: Bjorn Andersson CC: "Ivan T. Ivanov" CC: Stephen Boyd CC: Andy Gross Signed-off-by: Pr

[PATCH 1/4] ARM: DT: APQ8064: Add pinctrl support

2014-08-28 Thread Pramod Gurav
This patch adds device tree nodes to support pinctrl for apq8064 SOC CC: Rob Herring CC: Pawel Moll CC: Mark Rutland CC: Ian Campbell CC: Kumar Gala CC: devicet...@vger.kernel.org CC: linux-arm-ker...@lists.infradead.org Signed-off-by: Pramod Gurav --- arch/arm/boot/dts/qcom-apq8064.dtsi

Re: [PATCH] pinctrl: qcom: Release pin ranges when gpiochip_irqchip_add fails

2014-08-28 Thread Pramod Gurav
On Thursday 28 August 2014 02:54 AM, Bjorn Andersson wrote: > On Wed, Aug 27, 2014 at 3:57 AM, Pramod Gurav > wrote: >> This patches adds a call to gpiochip_remove_pin_ranges when >> gpiochip_irqchip_add fails to release memory allocated for pin_ranges. >> >> dif

[PATCH 2/3] cpufreq: cpu0: Removes unnecessary IS_ERR check on clk

2014-08-27 Thread Pramod Gurav
This removes unnecessary IS_ERR check on clk when in failure path as execution wont reach till there with clk being a err. CC: Shawn Guo CC: "Rafael J. Wysocki" CC: Viresh Kumar Signed-off-by: Pramod Gurav --- drivers/cpufreq/cpufreq-cpu0.c |3 +-- 1 files changed, 1 insert

[PATCH 1/3] cpufreq: cpu0: Release clk and regulator in remove function

2014-08-27 Thread Pramod Gurav
This function releases clk and regulator in remove function for clean unloading. CC: Shawn Guo CC: "Rafael J. Wysocki" CC: Viresh Kumar Signed-off-by: Pramod Gurav --- drivers/cpufreq/cpufreq-cpu0.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drive

[PATCH 3/3] cpufreq: cpu0: Convert pr_ to dev_ as struct device is available

2014-08-27 Thread Pramod Gurav
CC: Shawn Guo CC: "Rafael J. Wysocki" CC: Viresh Kumar Signed-off-by: Pramod Gurav --- drivers/cpufreq/cpufreq-cpu0.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c index 0652ce

[PATCH] pinctrl: qcom: Release pin ranges when gpiochip_irqchip_add fails

2014-08-27 Thread Pramod Gurav
This patches adds a call to gpiochip_remove_pin_ranges when gpiochip_irqchip_add fails to release memory allocated for pin_ranges. CC: Ivan T. Ivanov CC: Bjorn Andersson CC: Linus Walleij Signed-off-by: Pramod Gurav --- drivers/pinctrl/qcom/pinctrl-msm.c |1 + 1 file changed, 1 insertion

[PATCH 3/4] pinctrl: msm: Add ps_hold function in pinctrl-apq8064 binding documentation

2014-08-27 Thread Pramod Gurav
This adds a function ps_hold (Power Suppy Hold Signal) in pinctrl-ap8064 documentation which was missing. This function is used to reset the targets with apq8064 soc. CC: Linus Walleij CC: Bjorn Andersson CC: "Ivan T. Ivanov" CC: Stephen Boyd CC: Andy Gross Signed-off-by: Pr

[PATCH 4/4] ARM: DT: APQ8064: Add node for ps_hold function in pinctrl

2014-08-27 Thread Pramod Gurav
This patch adds DT support to configure GPIO_78 as function ps_hold on apq8064. CC: Rob Herring CC: Pawel Moll CC: Mark Rutland CC: Ian Campbell CC: Kumar Gala CC: devicet...@vger.kernel.org CC: linux-arm-ker...@lists.infradead.org Signed-off-by: Pramod Gurav --- arch/arm/boot/dts/qcom

[PATCH 1/2] ARM: DT: APQ8064: Add pinctrl support This patch adds device tree nodes to support pinctrl for apq8064 SOC

2014-08-26 Thread Pramod Gurav
CC: Rob Herring CC: Pawel Moll CC: Mark Rutland CC: Ian Campbell CC: Kumar Gala CC: devicet...@vger.kernel.org CC: linux-arm-ker...@lists.infradead.org Signed-off-by: Pramod Gurav --- arch/arm/boot/dts/qcom-apq8064.dtsi | 11 +++ 1 files changed, 11 insertions(+), 0 deletions

[PATCH 2/2] pinctrl: qcom: Add support for reset for apq8064

2014-08-26 Thread Pramod Gurav
This patch adds support for reset functions to reboot the boards with soc apq8064. CC: Linus Walleij CC: Bjorn Andersson CC: "Ivan T. Ivanov" CC: Stephen Boyd CC: Andy Gross Signed-off-by: Pramod Gurav --- drivers/pinctrl/qcom/pinctrl-apq8064.c |7 +- drivers/pinctrl/qc

[PATCH v2 2/2] msm: msm_fb: Move to using managed resources of kzalloc

2014-08-26 Thread Pramod Gurav
Move to managed verion of kzalloc. Also checks return for failure case which was missing. Signed-off-by: Pramod Gurav CC: Jean-Christophe Plagniol-Villard CC: Tomi Valkeinen CC: Stephen Boyd CC: Jingoo Han CC: Rob Clark --- drivers/video/fbdev/msm/msm_fb.c |9 +++-- 1 file

[PATCH v2 1/2] msm: msm_fb: Add remove function for platform driver for clean unloading

2014-08-26 Thread Pramod Gurav
This adds a remove function to platform driver structure so that resources are released when driver is unloaded. Signed-off-by: Pramod Gurav CC: Jean-Christophe Plagniol-Villard CC: Tomi Valkeinen CC: Stephen Boyd CC: Jingoo Han CC: Rob Clark --- drivers/video/fbdev/msm/msm_fb.c | 16

<    1   2   3   >