the license issue, if it is still
needed and actually used by anyone, we can add it back later once the
license is cleared up.
Looks good:
Acked-by: Christoph Hellwig
Ditto.
Acked-by: Prarit Bhargava
P.
On 9/26/23 04:02, Greg KH wrote:
On Tue, Sep 26, 2023 at 12:34:03AM -0700, Christoph Hellwig wrote:
On Fri, Sep 15, 2023 at 09:39:05AM -0400, Prarit Bhargava wrote:
To be clear, I am not asking for their removal, however, I do think a better
license should be issued for these files. The files
affinity is broken.
>
> If no node is assigned then only the full affinity mask and if that fails
> the full online mask is tried.
>
> Fixes: d6ffc6ac83b1 ("x86/vector: Respect affinity mask in irq descriptor")
> Reported-by: Shung-Hsi Yu
> Reported-by: Prarit B
On 11/10/20 3:56 PM, Thomas Gleixner wrote:
> Prarit,
>
> On Tue, Nov 10 2020 at 14:24, Prarit Bhargava wrote:
>> Occasionally when logging out of the ttyS0 aka serial console I see that
>>
>> irq 4: Affinity broken due to vector space exhaustion.
>>
>
Occasionally when logging out of the ttyS0 aka serial console I see that
irq 4: Affinity broken due to vector space exhaustion.
is output to the console.
At boot the default smp_affinity is
/proc/irq/4/smp_affinity:00ff,,00ff
The irqbalance service runs and can change
On 9/1/20 4:17 PM, Lucas De Marchi wrote:
> On Tue, Sep 1, 2020 at 12:56 PM Prarit Bhargava wrote:
>>
>>
>>
>> On 9/1/20 2:50 PM, Lucas De Marchi wrote:
>>> On Sat, Aug 29, 2020 at 4:15 AM Qu Wenruo wrote:
>>>>
>>>>
On 9/1/20 2:50 PM, Lucas De Marchi wrote:
> On Sat, Aug 29, 2020 at 4:15 AM Qu Wenruo wrote:
>>
>> When kernel module loading failed, user space only get one of the
>> following error messages:
>> - -ENOEXEC
>> This is the most confusing one. From corrupted ELF header to bad
>> WRITE|EXEC
On 8/11/20 9:02 AM, Petr Mladek wrote:
> On Tue 2020-08-11 14:05:12, Thomas Gleixner wrote:
>> Petr Mladek writes:
>>> At least "crash" tool would need an update anyway. AFAIK, it checks
>>> the size of struct printk_log and refuses to read it when it changes.
>>>
>>> It means that the hack
On 8/5/20 10:04 AM, Petr Mladek wrote:
> On Wed 2020-07-29 08:22:36, Prarit Bhargava wrote:
>> Chunyan Zhang wrote:
>>> From: Prarit Bhargava
>>>
>>> printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock
>>> timestamp to pri
Chunyan Zhang wrote:
> From: Prarit Bhargava
>
> printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock
> timestamp to printk messages. The local hardware clock loses time each
> day making it difficult to determine exactly when an issue has occurred in
&
Just re-pinging on this.
P.
On 6/16/20 7:32 AM, Prarit Bhargava wrote:
> There are two problems with kernel messages in fatal mode that were found
> during testing of guests and userspace programs.
>
> The first is that no kernel message is output when the split lock detector
&g
Disabling cpu 0 results in an error
turbostat: /sys/devices/system/cpu/cpu0/topology/thread_siblings: open failed:
No such file or directory
Use sched_getcpu() instead of a hardcoded cpu 0 to get the max cpu number.
Signed-off-by: Prarit Bhargava
Cc: Len Brown
Cc: linux...@vger.kernel.org
Cc
noticed that the same message was being output
three times so I'm cleaning that up too.
Fix fatal mode output, and use consistent messages for fatal and
warn modes for both userspace and guests.
Co-developed-by: Sean Christopherson
Signed-off-by: Sean Christopherson
Signed-off-by: Prarit Bhargava
Cc
This was sent in error.
Sorry,
P.
On 6/16/20 7:27 AM, Prarit Bhargava wrote:
> There are two problems with kernel messages in fatal mode that were found
> during testing of guests and userspace programs.
>
> The first is that no kernel message is output when the split l
There are two problems with kernel messages in fatal mode that were found
during testing of guests and userspace programs.
The first is that no kernel message is output when the split lock detector
is triggered with a userspace program. As a result the userspace process
dies from receiving
noticed that the same message was being output
three times so I'm cleaning that up too.
Fix fatal mode output, and use consistent messages for fatal and
warn modes for both userspace and guests.
Signed-off-by: Prarit Bhargava
Signed-off-by: Sean Christopherson
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc
On 6/8/20 1:15 PM, Sean Christopherson wrote:
> On Mon, Jun 08, 2020 at 08:21:14AM -0400, Prarit Bhargava wrote:
>> diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
>> index 166d7c355896..e02ec81fe1eb 100644
>> --- a/arch/x86/kernel/cpu/intel.c
>>
On 6/8/20 1:15 PM, Sean Christopherson wrote:
> On Mon, Jun 08, 2020 at 08:21:14AM -0400, Prarit Bhargava wrote:
>> diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
>> index 166d7c355896..e02ec81fe1eb 100644
>> --- a/arch/x86/kernel/cpu/intel.c
>>
noticed that the same message was being output
three times so I'm cleaning that up too.
Fix fatal mode output, and use consistent messages for fatal and
warn modes for both userspace and guests.
Signed-off-by: Prarit Bhargava
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: Borislav Petkov
Cc: x
On 6/5/20 11:29 AM, Xiaoyao Li wrote:
> On 6/5/2020 7:44 PM, Prarit Bhargava wrote:
>> There are two problems with kernel messages in fatal mode that
>> were found during testing of guests and userspace programs.
>>
>> The first is that no kernel message is output w
noticed that the same message was being output
three times so I'm cleaning that up too.
Fix fatal mode output, and use consistent messages for fatal and
warn modes for both userspace and guests.
Signed-off-by: Prarit Bhargava
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: Borislav Petkov
Cc: x
On 5/1/20 5:40 AM, John Ogness wrote:
> Hello,
>
> Here is a v2 for the first series to rework the printk subsystem. The
> v1 and history are here [0]. This first series only replaces the
> existing ringbuffer implementation. No locking is removed. No
> semantics/behavior of printk are
Package strings for json") prettied this output so that it is a single line for
some json output commands and the same should be done for other commands.
Output package, die, and cpu info in a single line when using json output.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
/disable
> One of the patch for config only change folded to next one where it is
> used.
>
> The patch 1 has nothing to do with the CLX-N. It saves some bytes in the
> size.
>
Reviewed-by: Prarit Bhargava
P.
On 10/4/19 1:15 PM, Srinivas Pandruvada wrote:
> On Thu, 2019-10-03 at 08:11 -0400, Prarit Bhargava wrote:
>> Three CascadeLake-N models (6252N, 6230N, and 5218N) have SST-PBF
>> support.
>>
>> Return an error if the CascadeLake processor is not one of
Add functionality for perf-profile info on CascadeLake-N.
Signed-off-by: Prarit Bhargava
---
.../x86/intel-speed-select/isst-config.c | 20 +++
.../x86/intel-speed-select/isst-display.c | 12 +++
tools/power/x86/intel-speed-select/isst.h | 1 +
3 files
Add functionality for base-freq info|enable|disable info on CascadeLake-N.
The enable command always returns success, and the disable command always
returns failed because SST-BF cannot be enabled or disabled from the OS on
CascadeLake-N.
Signed-off-by: Prarit Bhargava
---
.../x86/intel-speed
Three CascadeLake-N models (6252N, 6230N, and 5218N) have SST-PBF support.
Return an error if the CascadeLake processor is not one of these specific
models.
v2: Add is_clx_n_platform()
Signed-off-by: Prarit Bhargava
---
.../x86/intel-speed-select/isst-config.c | 44 ++-
1
Bhargava
Prarit Bhargava (7):
intel-speed-select: Add int argument to command functions
intel-speed-select: Make process_command generic
intel-speed-select: Add check for CascadeLake-N models
intel-speed-select: Add configuration for CascadeLake-N
intel-speed-select: Implement
functions.
Add int argument to the command function structure.
Signed-off-by: Prarit Bhargava
---
.../x86/intel-speed-select/isst-config.c | 216 +++---
1 file changed, 88 insertions(+), 128 deletions(-)
diff --git a/tools/power/x86/intel-speed-select/isst-config.c
b/tools
Create a 'dummy' pkg_dev struct for use by CascadeLake-N processors. This
struct will be used in later patches to implement info and status calls
for CascadeLake-N SST-BF.
Signed-off-by: Prarit Bhargava
---
.../x86/intel-speed-select/isst-config.c | 98 ++-
.../x86/intel
-by: Prarit Bhargava
---
.../x86/intel-speed-select/isst-config.c | 37 ++-
1 file changed, 27 insertions(+), 10 deletions(-)
diff --git a/tools/power/x86/intel-speed-select/isst-config.c
b/tools/power/x86/intel-speed-select/isst-config.c
index 164c4e5e6ccb..3ab0edade5ec 100644
Make the process_command take any help command and command list. This
will make it easier to help commands and a command list for CascadeLake-N.
Signed-off-by: Prarit Bhargava
---
.../x86/intel-speed-select/isst-config.c | 20 ++-
1 file changed, 11 insertions(+), 9
On 9/26/19 4:21 PM, Srinivas Pandruvada wrote:
> On Thu, 2019-09-26 at 08:54 -0400, Prarit Bhargava wrote:
>> The current code structure has similar but separate command functions
>> for
>> the enable and disable operations. This can be improved by adding an
>> int
Add support for SST-BF on CascadeLake-N support. The CascadeLake-N
processor only support SST-BF and not other SST functionality.
Prarit Bhargava (7):
intel-speed-select: Add int argument to command functions
intel-speed-select: Make process_command generic
intel-speed-select: Add check
Make the process_command take any help command and command list. This
will make it easier to help commands and a command list for CascadeLake-N.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
---
.../x86/intel-speed-select/isst-config.c | 20 ++-
1 file changed
-by: Prarit Bhargava
Cc: Srinivas Pandruvada
---
.../x86/intel-speed-select/isst-config.c | 37 ++-
1 file changed, 27 insertions(+), 10 deletions(-)
diff --git a/tools/power/x86/intel-speed-select/isst-config.c
b/tools/power/x86/intel-speed-select/isst-config.c
index
functions.
Add int argument to the command function structure.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
---
.../x86/intel-speed-select/isst-config.c | 184 +++---
1 file changed, 69 insertions(+), 115 deletions(-)
diff --git a/tools/power/x86/intel-speed-select
Create a 'dummy' pkg_dev struct for use by CascadeLake-N processors. This
struct will be used in later patches to implement info and status calls
for CascadeLake-N SST-BF.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
---
.../x86/intel-speed-select/isst-config.c | 98
Three CascadeLake-N models (6252N, 6230N, and 5218N) have SST-PBF support.
Return an error if the CascadeLake processor is not one of these specific
models.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
---
.../x86/intel-speed-select/isst-config.c | 32 +--
1
Add functionality for perf-profile info on CascadeLake-N.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
---
.../x86/intel-speed-select/isst-config.c | 24 +++
.../x86/intel-speed-select/isst-display.c | 22 +
tools/power/x86/intel-speed-select
Add functionality for base-freq info|enable|disable info on CascadeLake-N.
The enable command always returns success, and the disable command always
returns failed because SST-BF cannot be enabled or disabled from the OS on
CascadeLake-N.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
The output of the Turbo Ratio Limits is 75 lines long (each bucket has
3 lines and the headers). This can be shrunk down into a table that is
easier to consume for both scripts and humans.
Display Turbo Ratio Limits in a table.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
The turbo ratio limits and turbo frequencies add a large amount of
lines to the output. The output can be truncated into human and
machine readable tables to reduce the number of lines of output.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Prarit Bhargava (2):
intel-speed-select
The output of turbo frequencies is also long (each bucket has
3 lines and the headers). This can be shrunk down into a table that is
easier to consume for both scripts and humans.
Display the turbo and clip frequencies in a table.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
On 9/7/19 2:18 PM, Andy Shevchenko wrote:
> On Fri, Sep 6, 2019 at 10:47 PM Srinivas Pandruvada
> wrote:
>>
>> On Fri, 2019-09-06 at 07:50 -0700, Srinivas Pandruvada wrote:
>>> On Fri, 2019-09-06 at 16:46 +0300, Andy Shevchenko wrote:
>>>> On Fri, S
On 9/5/19 7:37 PM, Srinivas Pandruvada wrote:
> Read the bucket and core count relationship via MSR and display
> when displaying turbo ratio limits.
>
> Signed-off-by: Srinivas Pandruvada
> ---
> .../power/x86/intel-speed-select/isst-core.c | 22 +++
>
On 9/5/19 3:42 PM, Srinivas Pandruvada wrote:
> On Thu, 2019-09-05 at 08:03 -0400, Prarit Bhargava wrote:
>> cpumasks are allocated by calling the alloc_cpu_mask() function and
>> are
>> never free'd. They should be free'd after the commands have run.
>>
>>
On 9/5/19 3:42 PM, Srinivas Pandruvada wrote:
> On Thu, 2019-09-05 at 08:03 -0400, Prarit Bhargava wrote:
>> cpumasks are allocated by calling the alloc_cpu_mask() function and
>> are
>> never free'd. They should be free'd after the commands have run.
>>
>>
cpumasks are allocated by calling the alloc_cpu_mask() function and are
never free'd. They should be free'd after the commands have run.
Fix the memory leaks by calling free_cpu_set().
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
The intel-speed-select tool currently outputs the turbo ratio for every
bucket. Make the output more user-friendly by changing the output to the
maximum turbo frequency.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
---
.../x86/intel
status of disabled,
enabled, and unsupported.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
---
.../x86/intel-speed-select/isst-display.c | 30 ++-
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/tools
I have a system with 28 threads/socket but intel-speed-select reports
a cpu-count of 29.
Fix an off-by-one error in the cpu_count() function.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
---
tools/power/x86/intel-speed-select/isst
These features are introduced on new processors that will never operate
in the KHz range.
Save some zeros and switch the output to MHz.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
---
.../x86/intel-speed-select/isst-display.c
Help is -h, not --h.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
---
tools/power/x86/intel-speed-select/isst-config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/power/x86/intel-speed-select/isst
.
- avoiding reporting "0|1" as success|fail as these can be confusing for a
user.
v2: Add additional patch to fix memory leak and remove help text in 8/9.
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
Prarit Bhargava (9):
tools/power/x86/intel-speed-select: F
he command output to 'success' or 'failed'.
v2: Remove help output line.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
---
tools/power/x86/intel-speed-select/isst-config.c | 1 -
tools/power/x86/intel-speed-select/isst-display.c | 5
The intel-speed-select tool currently only outputs a hexidecimal CPU mask,
which requires translation for use with kernel parameters such as
isolcpus.
Along with the CPU mask, output a human readable CPU list.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux
packag_ should be package_.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
---
tools/power/x86/intel-speed-select/isst-display.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/power/x86/intel-speed
On 9/4/19 4:06 PM, Srinivas Pandruvada wrote:
> On Tue, 2019-09-03 at 11:37 -0400, Prarit Bhargava wrote:
>> Some general fixes and updates for intel-speed-select. Fixes include
>> some
>> typos as well as an off-by-one cpu count reporting error. Updates
I have a system with 28 threads/socket but intel-speed-select reports
a cpu-count of 29.
Fix an off-by-one error in the cpu_count() function.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
---
tools/power/x86/intel-speed-select/isst
packag_ should be package_.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
---
tools/power/x86/intel-speed-select/isst-display.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/power/x86/intel-speed
The intel-speed-select tool currently outputs the turbo ratio for every
bucket. Make the output more user-friendly by changing the output to the
maximum turbo frequency.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
---
.../x86/intel
status of disabled,
enabled, and unsupported.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
---
.../x86/intel-speed-select/isst-display.c | 30 ++-
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/tools
These features are introduced on new processors that will never operate
in the KHz range.
Save some zeros and switch the output to MHz.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
---
.../x86/intel-speed-select/isst-display.c
he command output to 'success' or 'failed'.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
---
tools/power/x86/intel-speed-select/isst-display.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/power/x86/i
The intel-speed-select tool currently only outputs a hexidecimal CPU mask,
which requires translation for use with kernel parameters such as
isolcpus.
Along with the CPU mask, output a human readable CPU list.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux
Help is -h, not --h.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
---
tools/power/x86/intel-speed-select/isst-config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/power/x86/intel-speed-select/isst
.
- avoiding reporting "0|1" as success|fail as these can be confusing for a
user.
Signed-off-by: Prarit Bhargava
Cc: Srinivas Pandruvada
Cc: David Arcari
Cc: linux-kernel@vger.kernel.org
Prarit Bhargava (8):
tools/power/x86/intel-speed-select: Fix package typo
tools/power/x86/intel-sp
On 7/26/19 9:38 AM, Sasha Levin wrote:
> From: Prarit Bhargava
>
> [ Upstream commit 6e6de3dee51a439f76eb73c22ae2ffd2c9384712 ]
>
> Microsoft HyperV disables the X86_FEATURE_SMCA bit on AMD systems, and
> linux guests boot with repeated errors:
>
Hey Sasha, I'd pre
On 7/18/19 3:20 PM, Linus Torvalds wrote:
> On Thu, Jul 18, 2019 at 4:33 AM Jessica Yu wrote:
>>
>> Modules updates for v5.3
>>
>> - Fix bug where -EEXIST was being returned for going modules
>
> Hmm.
>
> I have pulled this, but this change makes me a bit nervous.
>
> I have this dim memory
Commit-ID: c7563e62a6d720aa3b068e26ddffab5f0df29263
Gitweb: https://git.kernel.org/tip/c7563e62a6d720aa3b068e26ddffab5f0df29263
Author: Prarit Bhargava
AuthorDate: Mon, 10 Jun 2019 13:15:44 -0400
Committer: Thomas Gleixner
CommitDate: Wed, 12 Jun 2019 10:31:50 +0200
x86/resctrl
bandwith update loop if the system has local MBM enabled.
Signed-off-by: Prarit Bhargava
Cc: Fenghua Yu
Cc: Reinette Chatre
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: Borislav Petkov
Cc: "H. Peter Anvin"
Cc: x...@kernel.org
---
arch/x86/kernel/cpu/resctrl/monitor.c | 3 +++
1 file change
attempts to load amd64_edac_mod, which
fails because of unknown symbols from edac_mce_amd.
add_unformed_module() must wait to return for any case other than
MODULE_STATE_LIVE to prevent a race between multiple loads of
dependent modules.
Signed-off-by: Prarit Bhargava
Signed-off-by: Barret Rhoden
Cc
On 5/22/19 1:08 PM, Prarit Bhargava wrote:
>
>
> On 5/13/19 10:37 AM, Barret Rhoden wrote:
>> Hi -
>>
>
> Hey Barret, my apologies for not getting back to you earlier. I got caught up
> in something that took me away from this issue.
>
>> On 5/13/19 7
On 5/13/19 10:37 AM, Barret Rhoden wrote:
> Hi -
>
Hey Barret, my apologies for not getting back to you earlier. I got caught up
in something that took me away from this issue.
> On 5/13/19 7:23 AM, Prarit Bhargava wrote:
> [snip]
>> A module is loaded once for each cpu.
On 5/10/19 2:42 PM, Barret Rhoden wrote:
> When add_unformed_module() finds an existing module with the same name,
> it waits until the preexisting module finished loading. Prior to commit
> f9a75c1d717f, this meant if the module was either UNFORMED or COMING,
> we'd wait. That commit changed
erruptible() puts each thread
to sleep until the a module finishes loading an executes the module_wq
workqueue. The result is a long delay during the boot. Switching to
wait_event_interruptible_timeout() resolves the sleep problem.
Signed-off-by: Prarit Bhargava
Cc: Jessica Yu
Cc: Heiko Ca
On 5/2/19 8:41 AM, Prarit Bhargava wrote:
>
>
> On 5/2/19 5:48 AM, Jessica Yu wrote:
>> +++ Prarit Bhargava [01/05/19 17:26 -0400]:
>>>
>>>
>>> On 4/30/19 6:22 PM, Prarit Bhargava wrote:
>>>> On a s390 z14 LAR with 2 cpus about stalls ab
On 5/2/19 5:48 AM, Jessica Yu wrote:
> +++ Prarit Bhargava [01/05/19 17:26 -0400]:
>>
>>
>> On 4/30/19 6:22 PM, Prarit Bhargava wrote:
>>> On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while
>>> loading the s390_trng.ko module.
>
On 4/30/19 6:22 PM, Prarit Bhargava wrote:
> On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while
> loading the s390_trng.ko module.
>
> Add a reschedule point to the loop that waits for modules to complete
> loading.
>
> v3: cleanup Fixes
EXIST for modules that have
finished loading")
Signed-off-by: Prarit Bhargava
Cc: Jessica Yu
Cc: Heiko Carstens
---
kernel/module.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/module.c b/kernel/module.c
index 410eeb7e4f1d..48748cfec991 100644
--- a/kernel/module.c
+++ b/kerne
On 4/30/19 6:18 PM, Prarit Bhargava wrote:
> On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while
> loading the s390_trng.ko module.
>
> Add a reschedule point to the loop that waits for modules to complete
> loading.
>
Sorry, sent in error.
P.
> v
EXIST for modules that have
finished loading")
Signed-off-by: Prarit Bhargava
Cc: Jessica Yu
Cc: Heiko Carstens
---
kernel/module.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/module.c b/kernel/module.c
index 410eeb7e4f1d..48748cfec991 100644
--- a/kernel/module.c
+++ b/kerne
On 4/30/19 6:10 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 7e470ea99bcd ("kernel/module: Reschedule while waiting for modules to
> finish loading")
>
> Fixes tag
>
> Fixes: linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for
> modules that have finished
On 4/30/19 3:51 AM, Jessica Yu wrote:
> +++ Prarit Bhargava [29/04/19 11:17 -0400]:
>> Heiko, do you want a Signed-off-by or a Reported-by? Either one works
>> for me.
>>
>> P.
>
> I think you forgot to CC Heiko :)
#oops.
I forgot that git-send-email
iko Carstens
Fixes: linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for
modules that have finished loading")
Signed-off-by: Prarit Bhargava
Cc: Jessica Yu
---
kernel/module.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/module.c b/kernel/module.c
index
On 4/27/19 6:24 AM, Heiko Carstens wrote:
>
> diff --git a/kernel/module.c b/kernel/module.c
> index 410eeb7e4f1d..48748cfec991 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -3585,6 +3585,7 @@ again:
> finished_loading(mod->name));
>
On 4/27/19 6:24 AM, Heiko Carstens wrote:
> On Fri, Apr 26, 2019 at 08:20:52PM -0400, Prarit Bhargava wrote:
>> Heiko and Jessica,
>>
>> The issue doesn't appear to be with my patch AFAICT. The s390_trng fails to
>> load and then the kernel occasionally hangs (
On 4/26/19 3:45 PM, Prarit Bhargava wrote:
>
>
> On 4/26/19 2:10 PM, Prarit Bhargava wrote:
>>
>>
>> On 4/26/19 12:09 PM, Jessica Yu wrote:
>>> +++ Heiko Carstens [26/04/19 17:07 +0200]:
>>>> On Fri, Apr 26, 2019 at 09:22:34AM -0400, Prarit
On 4/26/19 2:10 PM, Prarit Bhargava wrote:
>
>
> On 4/26/19 12:09 PM, Jessica Yu wrote:
>> +++ Heiko Carstens [26/04/19 17:07 +0200]:
>>> On Fri, Apr 26, 2019 at 09:22:34AM -0400, Prarit Bhargava wrote:
>>>> On 4/26/19 9:07 AM, Heiko Carstens wrote:
>
On 4/26/19 12:09 PM, Jessica Yu wrote:
> +++ Heiko Carstens [26/04/19 17:07 +0200]:
>> On Fri, Apr 26, 2019 at 09:22:34AM -0400, Prarit Bhargava wrote:
>>> On 4/26/19 9:07 AM, Heiko Carstens wrote:
>>> > Hello Prarit,
>>> >
>>> > it look
On 4/26/19 12:09 PM, Jessica Yu wrote:
> +++ Heiko Carstens [26/04/19 17:07 +0200]:
>> On Fri, Apr 26, 2019 at 09:22:34AM -0400, Prarit Bhargava wrote:
>>> On 4/26/19 9:07 AM, Heiko Carstens wrote:
>>> > Hello Prarit,
>>> >
>>> > it look
On 4/26/19 9:07 AM, Heiko Carstens wrote:
> Hello Prarit,
>
> it looks like your commit f9a75c1d717f ("modules: Only return -EEXIST
> for modules that have finished loading") _sometimes_ causes hangs on
> s390. This is unfortunately not 100% reproducible, however the
> mentioned commit seems
On 4/15/19 7:23 AM, Jessica Yu wrote:
> +++ Prarit Bhargava [02/04/19 09:39 -0400]:
>> Microsoft HyperV disables the X86_FEATURE_SMCA bit on AMD systems, and
>> linux guests boot with repeated errors:
>>
>> amd64_edac_mod: Unknown symbol amd_unregister_ecc_decoder
t: Warn on bad ACPI LPIT data")
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Prarit Bhargava
P.
> ---
> tools/power/x86/turbostat/turbostat.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/power/x86/turbostat/turbostat.c
> b/tools/power/x
Jessica? ping?
P.
On 4/2/19 9:39 AM, Prarit Bhargava wrote:
> Microsoft HyperV disables the X86_FEATURE_SMCA bit on AMD systems, and
> linux guests boot with repeated errors:
>
> amd64_edac_mod: Unknown symbol amd_unregister_ecc_decoder (err -2)
> amd64_edac_mod:
On 4/3/19 3:02 AM, Naoya Horiguchi wrote:
> turbostat could be terminated by general protection fault on some latest
> hardwares which (for example) support 9 levels of C-states and show 18
> "tADDED" lines. That bloats the total output and finally causes buffer
> overrun. So let's extend the
attempts to load amd64_edac_mod, which
fails because of unknown symbols from edac_mce_amd.
add_unformed_module() must wait to return for any case other than
MODULE_STATE_LIVE to prevent a race between multiple loads of
dependent modules.
Signed-off-by: Prarit Bhargava
Reported-by: Cathy Avery
Cc
Kernel 4.18.0 has a partial data loss when an NMI occurs but 5.0.0 has
complete data loss.
I tested with this simple kernel lockup code on kernels 4.18.0 through
5.0.0. On 4.18.0 (and after) the expected lockup messages
Uhhuh. NMI received for unknown reason 25 on CPU 0.
Do you have a strange
1 - 100 of 2027 matches
Mail list logo
