[PATCH] ASoC: wm9713: add gpio chip

2015-11-04 Thread Robert Jarzmik
The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the kernel, declare a gpio chip. Signed-off-by: Robert Jarzmik --- sound/soc/codecs/wm9713.c | 123 ++ sound/soc/codecs/wm9713.h | 1 + 2 files changed, 124 insertions(+) diff --git

[PATCH v4 1/2] ASoC: wm9713: convert to regmap

2015-11-01 Thread Robert Jarzmik
/resume. Signed-off-by: Robert Jarzmik --- Since v1: fix suspend/resume (that specific part is not tested yet) Since v2: split out the snd_soc_*() from regmap support Since v3: remove suspend/resume regmap cache operations, rely on regmap volatile registers --- sound/soc/codecs/Kconfig

[PATCH v4 2/2] ASoC: wm9713: use snd_soc_*() calls to update ac97 registers

2015-11-01 Thread Robert Jarzmik
Convert wm9713 to use the more modern registers manipulation functions, such as snd_soc_read(), snd_soc_write() and snd_soc_update_bits(). Signed-off-by: Robert Jarzmik --- sound/soc/codecs/wm9713.c | 140 +- 1 file changed, 52 insertions(+), 88

Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node

2015-10-29 Thread Robert Jarzmik
Boris Brezillon writes: > On Thu, 29 Oct 2015 18:23:47 +0100 > Marek Vasut wrote: > Except it's now how devices supporting 16 bits data bus are supposed to > work, which means your NAND controller will probably not be able to > send the command/address value on the higher 8 bits... Correct. >>

Re: [PATCH v3 1/2] ASoC: wm9713: convert to regmap

2015-10-29 Thread Robert Jarzmik
Charles Keepax writes: > Yeah that solution looks a lot more like what I was expecting. Okay, so I'm ready to fire the v4. I'll wait a couple of days for others reviews and if none I'll send the v4. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node

2015-10-28 Thread Robert Jarzmik
Marek Vasut writes: >> Isn't there the case of a single NAND controller with 2 identical chips, >> each a 8 bit NAND chip, and the controller aggregating them to offer the >> OS a single 16-bit NAND chip ? > > Is that using 1 or 2 physical chipselect lines on the CPU (controller) ? I think it's 2

Re: [PATCH v2 1/3] dmaengine: virt-dma: don't always free descriptor upon completion

2015-10-28 Thread Robert Jarzmik
Vinod Koul writes: >> Hi Vinod, >> >> Is this serie good for you or do you have remaining comments to be addressed >> ? > > Hi Robert, > > This series looks good, but I am afraid we are very close to merge window I > would like this to be deffered to next one for more stabililty tests and > cov

Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node

2015-10-28 Thread Robert Jarzmik
Brian Norris writes: >> > >> > Do some sorts of chipselects come into play here ? Ie. you can have one >> > master >> > with multiple NAND chips connected to it. >> >> Most NAND controllers support interacting with several chips (or >> dies in case your chip embeds several NAND dies), but I ke

Re: [PATCH v3 1/2] ASoC: wm9713: convert to regmap

2015-10-28 Thread Robert Jarzmik
Charles Keepax writes: >> @@ -1158,6 +1199,9 @@ static int wm9713_soc_suspend(struct snd_soc_codec >> *codec) >> { >> u16 reg; >> >> +snd_soc_cache_sync(codec); > > There doesn't seem to be much point in syncing the cache at the > start of a suspend, in theory I would expect the cach

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-10-27 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > Hi Robert, > > Didn't you tell me, that your dmaengine patch got rejected and therefore > these your patches were on hold? They were reverted, and then revamped into DMA_CTRL_REUSE, upstreamed and merged, as in the commit 272420214d26 ("dmaengine: Add DMA_CTRL_REU

[PATCH v3 2/2] ASoC: wm9713: use snd_soc_*() calls to update ac97 registers

2015-10-27 Thread Robert Jarzmik
Convert wm9713 to use the more modern registers manipulation functions, such as snd_soc_read(), snd_soc_write() and snd_soc_update_bits(). Signed-off-by: Robert Jarzmik --- sound/soc/codecs/wm9713.c | 140 +- 1 file changed, 52 insertions(+), 88

[PATCH v3 1/2] ASoC: wm9713: convert to regmap

2015-10-27 Thread Robert Jarzmik
Convert the Wolfson WM9713 to regmap API. This will leverage all the regmap functions (debug, registers update, etc ...). As a bonus, this will pave the path to gpio chip introduction, and devicetree support. Signed-off-by: Robert Jarzmik --- Since v1: fix suspend/resume (that specific part is

Re: [alsa-devel] [PATCH v2] ASoC: wm9713: convert to regmap

2015-10-26 Thread Robert Jarzmik
Lars-Peter Clausen writes: > On 10/24/2015 11:37 PM, Robert Jarzmik wrote: > [...] >> -static unsigned int ac97_read(struct snd_soc_codec *codec, >> -unsigned int reg); >> -static int ac97_write(struct snd_soc_codec *codec, >> -unsigned int reg, unsigned int

Re: [PATCH v2] ASoC: wm9713: convert to regmap

2015-10-26 Thread Robert Jarzmik
Charles Keepax writes: > On Sat, Oct 24, 2015 at 11:37:07PM +0200, Robert Jarzmik wrote: >> Convert the Wolfson WM9713 to regmap API. This will leverage all the >> regmap functions (debug, registers update, etc ...). >> >> As a bonus, this will pave the path to

Re: [PATCH v4 0/5] mtd: pxa3xx_nand: rework the timing setup

2015-10-25 Thread Robert Jarzmik
Antoine Tenart writes: > Hello, > > Let's try one more time to get this merged. > > This series was part of a bigger one[1], which was split into smaller > ones as asked by Ezequiel[2]. When we take this into account this is > v9; with a v1 sent in January, 9 months ago. > > Another series, intro

[PATCH v2] ASoC: wm9713: convert to regmap

2015-10-24 Thread Robert Jarzmik
Convert the Wolfson WM9713 to regmap API. This will leverage all the regmap functions (debug, registers update, etc ...). As a bonus, this will pave the path to gpio chip introduction, and devicetree support. Signed-off-by: Robert Jarzmik --- Since v1: fix suspend/resume (that specific part is

[PATCH] ASoC: wm9713: convert to regmap

2015-10-24 Thread Robert Jarzmik
Convert the Wolfson WM9713 to regmap API. This will leverage all the regmap functions (debug, registers update, etc ...). As a bonus, this will pave the path to gpio chip introduction, and devicetree support. Signed-off-by: Robert Jarzmik --- sound/soc/codecs/Kconfig | 1 + sound/soc/codecs

Re: [PATCH v2 1/3] dmaengine: virt-dma: don't always free descriptor upon completion

2015-10-24 Thread Robert Jarzmik
Robert Jarzmik writes: > This patch attempts to enhance the case of a transfer submitted multiple > times, and where the cost of creating the descriptors chain is not > negligible. > > This happens with big video buffers (several megabytes, ie. several > thousands of linked

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-10-24 Thread Robert Jarzmik
Robert Jarzmik writes: > Fix the error path where the video buffer wasn't allocated nor > mapped. In this case, in the driver free path don't try to unmap memory > which was not mapped in the first place. > > Signed-off-by: Robert Jarzmik > --- > Since v3

Re: [PATCH v2 2/2] video: fbdev: pxafb: initial devicetree conversion

2015-10-22 Thread Robert Jarzmik
kbuild test robot writes: > Hi Robert, > > [auto build test ERROR on v4.3-rc5 -- if it's inappropriate base, please > suggest rules for selecting the more suitable base] ... >>> FATAL: drivers/video/fbdev/pxafb: struct of_device_id is not terminated >>> with a NULL entry! Ah silly me ... It pro

Re: [PATCH v3 0/4] mtd: pxa3xx_nand: rework the timing setup

2015-10-20 Thread Robert Jarzmik
Antoine Tenart writes: > Hi Ezequiel, > > On Thu, Oct 15, 2015 at 03:30:50PM -0300, Ezequiel Garcia wrote: >> Ccing Robert as he can provide valuable test on PXA boards. > > Sorry for this, I tried to cc Robert but forgot when sending my > series... Maybe for v4. I appreciate even more git tree I

Re: [PATCH] ARM: pxa: fix pxa3xx DFI lockup hack

2015-10-14 Thread Robert Jarzmik
Arnd Bergmann writes: > On Monday 12 October 2015 19:03:44 Robert Jarzmik wrote: >> Arnd Bergmann writes: >> >> > Some recently added code to avoid a bug introduced a build error >> > when CONFIG_PM is disabled and a macro is hidden: >> > &g

Re: [PATCH v4 22/26] ARM: pxa: magician: Remove pdata for pasic3-leds

2015-10-13 Thread Robert Jarzmik
Philipp Zabel writes: > Am Montag, den 28.09.2015, 23:39 +0200 schrieb Petr Cvek: >> The pasic3-leds driver was never in vanilla kernel. Actual >> configuration >> data for a hypothetical driver does not describe hardware completely, >> so >> remove them. >> >> This patch prepare HTC Magician ma

Re: [PATCH v4 21/26] ARM: pxa: magician: Add support for PXA27x UDC

2015-10-13 Thread Robert Jarzmik
Philipp Zabel writes: > Acked-by: Philipp Zabel Comments used and pushed into pxa/for-next, thanks. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v4 20/26] ARM: pxa: magician: Add support for MAX1587A Vcore regulator

2015-10-13 Thread Robert Jarzmik
Philipp Zabel writes: >> +static struct regulator_init_data magician_max1587a_v3_info = { >> +.constraints = { >> +.name = "vcc_core range", >> +.min_uV = 70, >> +.max_uV = 150, > > Wouldn't that be 1475000 for MAX1587A wit

Re: [PATCH v4 07/26] ARM: pxa: magician: Fix HTC Magician pin mux definitions

2015-10-13 Thread Robert Jarzmik
Petr Cvek writes: > Dne 3.10.2015 v 14:30 Philipp Zabel napsal(a): >> Am Montag, den 28.09.2015, 23:15 +0200 schrieb Petr Cvek: >>> This patch fixes a pin mux for the HTC Magician machine. Wrong and >>> missing >>> definitions caused a bad LCD operation and an unavailability of >>> several >>> pe

Re: [PATCH v4 02/26] ARM: pxa: magician: Change comments to be more informative

2015-10-13 Thread Robert Jarzmik
Philipp Zabel writes: > Am Montag, den 28.09.2015, 23:10 +0200 schrieb Petr Cvek: >> This patch changes the comments in the HTC Magician machine source >> code >> to better describe used devices and interfaces. >> >> Signed-off-by: Petr Cvek Queued to pxa/for-next with Philipp's comments taken

[PATCH v2 2/3] dmaengine: enable DMA_CTRL_REUSE

2015-10-13 Thread Robert Jarzmik
: Add DMA_CTRL_REUSE") Signed-off-by: Robert Jarzmik --- drivers/dma/dmaengine.c | 1 + include/linux/dmaengine.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c index 09479d4be4db..0d64dc8627a8 100644 --- a/drivers/dma/dmaengine.c +++ b/d

[PATCH v2 1/3] dmaengine: virt-dma: don't always free descriptor upon completion

2015-10-13 Thread Robert Jarzmik
set in the transfer. This patch is a respin of the former DMA_CTRL_ACK approach, which was reverted due to a regression in audio drivers. Signed-off-by: Robert Jarzmik --- Since v1: added doxygen commit to vchan_tx_desc_free --- drivers/dma/virt-dma.

[PATCH v2 3/3] dmaengine: pxa_dma: declare transfer are reusable

2015-10-13 Thread Robert Jarzmik
As this driver provides a mechanism to reuse transfers, declare it in its probe function. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index fc4156afa070..f2a0310ae771 100644 --- a

[PATCH v2 2/2] video: fbdev: pxafb: initial devicetree conversion

2015-10-13 Thread Robert Jarzmik
uffer configurations with different bits per pixel, only the LCD hardware bus width is used. The patch was tested on both pxa25x, pxa27x and pxa3xx platform (namely lubbock, mainstone and zylonite). Signed-off-by: Robert Jarzmik --- Since v1: Philipp's review: of_graph usage --- drivers/v

[PATCH v2 1/2] video: fbdev: pxafb: loosen the platform data bond

2015-10-13 Thread Robert Jarzmik
In order to prepare the transition to a mixed platform data and device-tree initialization, remove all the platform data references all over the driver. Copy the platform data into the internal structure of the pxafb, and only use this afterward. Signed-off-by: Robert Jarzmik --- drivers/video

Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode

2015-10-12 Thread Robert Jarzmik
Arnd Bergmann writes: >> It looks to me the powermode should be initialized once and for all in the >> machine init code. So unless I've overseen something, I'll keep Thierry's >> patch. > > Ah, sorry. I should have looked at the link you sent. > > Thierry's patch indeed looks much nicer if that

Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode

2015-10-12 Thread Robert Jarzmik
Robert Jarzmik writes: > Arnd Bergmann writes: > >> The z2 machine calls pxa27x_set_pwrmode() in order to power off >> the machine, but this function gets discarded early at boot because >> it is marked __init, as pointed out by kbuild: >> >> WARNING: vmlinu

Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode

2015-10-12 Thread Robert Jarzmik
Arnd Bergmann writes: > The z2 machine calls pxa27x_set_pwrmode() in order to power off > the machine, but this function gets discarded early at boot because > it is marked __init, as pointed out by kbuild: > > WARNING: vmlinux.o(.text+0x145c4): Section mismatch in reference from the > function

Re: [PATCH] ARM: pxa: fix pxa3xx DFI lockup hack

2015-10-12 Thread Robert Jarzmik
kups on startup") > --- > We merged the patch that introduced this as a fix for 4.3, so we should > probably add this one too. Oh yes, didn't see that ifdef, and all my non-regression defconfigs have CONFIG_PM ... Acked-by: Robert Jarzmik So do you want to take it direc

[PATCH v3] video: fbdev: add Marvell PXA LCD controller binding

2015-10-12 Thread Robert Jarzmik
Add documentation for the PXA LCD controller devicetree binding. Signed-off-by: Robert Jarzmik --- Since v1: Philipp's review on the whole binding Since v2: moved to display/, Philipp's and Rob's review dropped panel description, should be a simple panel with a

Re: [PATCH v4 00/26] ARM: pxa: magician: Rework HTC Magician support

2015-10-11 Thread Robert Jarzmik
Robert Jarzmik writes: > Petr Cvek writes: > >>> Thanks (a pozdrav :-), >>> >>> Pavel > Hi Petr, > > I'll start applying part of this serie today evening (my evening). > All Phil

Re: [PATCH v4 00/26] ARM: pxa: magician: Rework HTC Magician support

2015-10-11 Thread Robert Jarzmik
Petr Cvek writes: >> Thanks (a pozdrav :-), >> >> Pavel Hi Petr, I'll start applying part of this serie today evening (my evening). All Philipp's acked patches for a start. For the minor changes required by Philipp (comments, ...), i

Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding

2015-10-08 Thread Robert Jarzmik
Rob Herring writes: >> The pxafb driver acts today on the subset of registers which are the same >> across >> all pxaXXX variants. This is what made me think only one compatible property >> was >> required. >> >> If I'm wrong, I could add "marvell,pxa3xx-lcdc", is that what you think I >> shou

Re: [PATCH v4 19/26] ARM: pxa: magician: Add support for Omnivision OV9640 camera

2015-10-07 Thread Robert Jarzmik
Philipp Zabel writes: > Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek: >> This patch adds support for an OV9640 camera to the HTC Magician >> machine. >> >> Signed-off-by: Petr Cvek > > Still untested, but looks good to me. I'm still reluctant to have the reset with the timings handl

Re: [PATCH v4 11/26] ARM: pxa: magician: Optimize EGPIO initial values

2015-10-07 Thread Robert Jarzmik
Philipp Zabel writes: > Am Montag, den 28.09.2015, 23:32 +0200 schrieb Petr Cvek: >> This patch optimizes initial values of the EGPIO chip driver. >> >> GSM and sound should be powered off during boot. A weak accumulator >> and >> a powered GSM sometimes cause a system reboot. A charging current

Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding

2015-10-06 Thread Robert Jarzmik
Rob Herring writes: > On Sun, Oct 4, 2015 at 5:31 AM, Robert Jarzmik wrote: >> Add documentation for the PXA frambuffer devicetree binding. > > Strictly speaking this is a binding for PXA display controller, not a > Linux FB driver. There are lots of "framebuffer" an

Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding

2015-10-06 Thread Robert Jarzmik
Philipp Zabel writes: > On Sun, Oct 4, 2015 at 12:31 PM, Robert Jarzmik > wrote: >> + lcd-controller@4050 { >> + compatible = "marvell,pxa2xx-lcdc"; >> + reg = <0x4400 0x1>; >> + interru

[PATCH v2] video: fbdev: add Marvell PXA framebuffer binding

2015-10-04 Thread Robert Jarzmik
Add documentation for the PXA frambuffer devicetree binding. Signed-off-by: Robert Jarzmik --- Since v1: Philipp's review on the whole binding --- .../devicetree/bindings/video/marvell,pxafb.txt| 80 ++ 1 file changed, 80 insertions(+) create mode 100644 Document

Re: [PATCH] video: fbdev: add Marvell PXA framebuffer binding

2015-10-03 Thread Robert Jarzmik
Philipp Zabel writes: > On Sat, Oct 3, 2015 at 6:11 PM, Robert Jarzmik wrote: >> Add documentation for the PXA frambuffer devicetree binding. >> >> Signed-off-by: Robert Jarzmik >> Cc: Jean-Christophe Plagniol-Villard >> Cc: Tomi Valkeinen &

Re: [PATCH 2/2] video: fbdev: pxafb: initial devicetree conversion

2015-10-03 Thread Robert Jarzmik
Philipp Zabel writes: > Hi Robert, > > On Sat, Oct 3, 2015 at 6:11 PM, Robert Jarzmik wrote: >> This patch brings a first support of pxa framebuffer devices to a >> devicetree pxa platform, as was before platform data. >> >> There are restrictions with this por

[PATCH 0/2] video: fbdev: pxafb: devicetree conversion

2015-10-03 Thread Robert Jarzmik
This patchset aims at bringing support for the pxa framebuffer driver to a devicetree pxa platform. This was tested on a pxa27x platform, in both a devicetree build and a classic platform data one. Robert Jarzmik (2): video: fbdev: pxafb: loosen the platform data bond video: fbdev: pxafb

[PATCH 1/2] video: fbdev: pxafb: loosen the platform data bond

2015-10-03 Thread Robert Jarzmik
In order to prepare the transition to a mixed platform data and device-tree initialization, remove all the platform data references all over the driver. Copy the platform data into the internal structure of the pxafb, and only use this afterward. Signed-off-by: Robert Jarzmik --- drivers/video

[PATCH 2/2] video: fbdev: pxafb: initial devicetree conversion

2015-10-03 Thread Robert Jarzmik
uffer configurations with different bits per pixel, only the LCD hardware bus width is used. The patch was tested on both pxa25x, pxa27x and pxa3xx platform (namely lubbock, mainstone and zylonite). Signed-off-by: Robert Jarzmik --- drivers/video/fbdev/Kconfig | 2 + drivers/video/fbdev/pxafb.c

[PATCH] video: fbdev: add Marvell PXA framebuffer binding

2015-10-03 Thread Robert Jarzmik
Add documentation for the PXA frambuffer devicetree binding. Signed-off-by: Robert Jarzmik Cc: Jean-Christophe Plagniol-Villard Cc: Tomi Valkeinen Cc: linux-fb...@vger.kernel.org --- .../devicetree/bindings/video/marvell,pxafb.txt| 75 ++ 1 file changed, 75 insertions

Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while requesting the PWM"

2015-10-01 Thread Robert Jarzmik
Nicolas Ferre writes: > Le 30/09/2015 21:29, Robert Jarzmik a écrit : >> Robert Jarzmik writes: >> >>> This reverts commit 68feaca0b13e453aa14ee064c1736202b48b342f. >>> This commit breaks legacy platforms, for which : >>> (a) no pwm table is added (l

Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while requesting the PWM"

2015-10-01 Thread Robert Jarzmik
Nicolas Ferre writes: > Le 30/09/2015 21:29, Robert Jarzmik a écrit : >> Robert Jarzmik writes: >> >>> This reverts commit 68feaca0b13e453aa14ee064c1736202b48b342f. >>> This commit breaks legacy platforms, for which : >>> (a) no pwm table is added (l

[PATCH] ASoC: pxa: pxa-pcm-lib: switch over to snd-soc-dmaengine-pcm

2015-09-30 Thread Robert Jarzmik
small as possible. This was tested on the mioa701 pxa27x board. Signed-off-by: Daniel Mack [trivial change from mmp-dma to pxa-dma] Signed-off-by: Robert Jarzmik --- include/sound/pxa2xx-lib.h | 1 - sound/arm/pxa2xx-ac97.c | 13 ++- sound/arm/pxa2xx-pcm-lib.c | 201

Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while requesting the PWM"

2015-09-30 Thread Robert Jarzmik
Robert Jarzmik writes: > This reverts commit 68feaca0b13e453aa14ee064c1736202b48b342f. > This commit breaks legacy platforms, for which : > (a) no pwm table is added (legacy platforms) > (b) in this case, in pwm_get(), pmw_lookup_list is empty, and therefore > chos

[PATCH v2 2/2] dma: pxa_dma: fix residue corner case

2015-09-30 Thread Robert Jarzmik
_tx_status() } while (residue > 0 || status != DMA_ERROR) Signed-off-by: Robert Jarzmik --- Since v1: reworded the commit message for typos --- drivers/dma/pxa_dma.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index 7d3ff56caa0a..51f294

[PATCH v2 1/2] dma: pxa_dma: fix the no-requestor case

2015-09-30 Thread Robert Jarzmik
A very small number of devices don't use the flow control offered by requestor lines. In these specific cases, the pxa dma driver should be aware of that and not try to use a requestor line. Signed-off-by: Robert Jarzmik --- Since v1: rebase on v4.3-rc3 --- drivers/dma/pxa_dma.c

Re: [PATCH 1/2] dma: pxa_dma: fix the no-requestor case

2015-09-30 Thread Robert Jarzmik
Vinod Koul writes: > On Thu, Sep 10, 2015 at 07:17:45PM +0200, Robert Jarzmik wrote: >> A very small number of devices don't use the flow control offered by >> requestor lines. In these specific cases, the pxa dma driver should be >> aware of that and not try to use

Re: [PATCH 2/2] dma: pxa_dma: fix residue corner case

2015-09-30 Thread Robert Jarzmik
Vinod Koul writes: > On Thu, Sep 10, 2015 at 07:17:46PM +0200, Robert Jarzmik wrote: >> A very tiny temporal window exists in the residue calculation where : >> - upon entering residue calculation, the transfer is ongoing >> - when reading the current transfer pointe

Re: [PATCH v3] mmc: pxamci: fix card detect with slot-gpio API

2015-09-29 Thread Robert Jarzmik
Ulf Hansson writes: > On 26 September 2015 at 21:41, Robert Jarzmik wrote: > Thanks, applied for fixes! > > Kind regards > Uffe Thanks. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kerne

[PATCH v2 REBASED] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

2015-09-28 Thread Robert Jarzmik
. This effectively prevents a lockup on zylonite when removing pxa3xx-nand module, and using ethernet afterwards. Signed-off-by: Robert Jarzmik --- Since v1: add comment, switch to NFCV1/NCFV2 registers naming Since v2: rebase on top of Brian's tree --- drivers/mtd/nand/pxa3xx_nand.c

Re: [PATCH v2] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

2015-09-28 Thread Robert Jarzmik
Brian Norris writes: > On Sat, Sep 26, 2015 at 10:19:07PM +0200, Robert Jarzmik wrote: >> Robert Jarzmik writes: >> >> > After the conversion of pxa architecture to common clock framework, the >> > NAND clock can be disabled on driver exit. >> > >&g

Re: [PATCH v2] mtd: nand: pxa3xx-nand: switch to dmaengine

2015-09-28 Thread Robert Jarzmik
Brian Norris writes: > On Sun, Sep 27, 2015 at 05:18:56PM -0700, Brian Norris wrote: >> Sparse has one complaint, but I have no others: >> >> On Sun, Sep 06, 2015 at 03:12:47PM +0200, Robert Jarzmik wrote: >> > diff --git a/drivers/mtd/nand/pxa3xx_nand.c >>

Re: [PATCH v2] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

2015-09-26 Thread Robert Jarzmik
Robert Jarzmik writes: > After the conversion of pxa architecture to common clock framework, the > NAND clock can be disabled on driver exit. > > In this case, it happens that if the driver used the NAND and set the > DFI arbitration bit, the next access to a static memory

Re: [PATCH v2] mtd: nand: pxa3xx-nand: switch to dmaengine

2015-09-26 Thread Robert Jarzmik
Robert Jarzmik writes: > Now pxa architecture has a dmaengine driver, remove the access to direct > dma registers in favor of the more generic dmaengine code. > > This should be also applicable for mmp and orion, provided they work in > device-tree environment. > > This p

Re: [PATCH] ARM: pxa: Remove unused clock_enable field from struct pxa2xx_spi_master

2015-09-26 Thread Robert Jarzmik
Robert Jarzmik writes: > Jarkko Nikula writes: > >> Use for struct pxa2xx_spi_master clock_enable field was removed years ago >> from the pxa2xx-spi driver by the commit 2f1a74e5a2de ("[ARM] pxa: make >> pxa2xx_spi driver use ssp_request()/ssp_free()"). >&g

[PATCH v3] mmc: pxamci: fix card detect with slot-gpio API

2015-09-26 Thread Robert Jarzmik
cannot be a nested interrupt from a threaded interrupt (set __setup_irq()). This was tested on zylonite and mioa701 boards. Signed-off-by: Robert Jarzmik Cc: Petr Cvek --- Since v1: trade threaded interrupt for slot-gpio API Since v2: remove gpio_free() calls --- drivers/mmc/host/pxamci.c | 66

Re: [PATCH v2] ARM: pxa: mioa701: add wm9713 codec

2015-09-26 Thread Robert Jarzmik
Robert Jarzmik writes: > The mioa701 is using the wm9713 for audio, battery and touchscreen. Add > the missing audio part, which disappeared. > > Signed-off-by: Robert Jarzmik > --- > Since v1: Igor's catch of subject prefix issue Queued in pxa/for-next. -- Robert -- T

[PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while requesting the PWM"

2015-09-26 Thread Robert Jarzmik
mongst which pxa have been tested as broken. Signed-off-by: Robert Jarzmik --- drivers/video/backlight/pwm_bl.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index eff379b234cc..57cb9ec8be43 100644 --- a/drivers/vide

Re: [PATCH] ARM: pxa: add resources to pxaficp_ir

2015-09-26 Thread Robert Jarzmik
Petr Cvek writes: > Tested-by: Petr Cvek Thanks for the test. Applied to pxa/for-next. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-in

[PATCH v3 3/3] net: irda: pxaficp_ir: dmaengine conversion

2015-09-26 Thread Robert Jarzmik
Convert pxaficp_ir to dmaengine. As pxa architecture is shifting from raw DMA registers access to pxa_dma dmaengine driver, convert this driver to dmaengine. Signed-off-by: Robert Jarzmik Tested-by: Petr Cvek --- Since v1: removed mach/dma.h include, which is the goal --- drivers/net/irda

[PATCH v3 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-26 Thread Robert Jarzmik
Convert the pxa IRDA driver to readl and writel primitives, and remove another set of direct registers access. This leaves only the DMA registers access, which will be dealt with dmaengine conversion. Signed-off-by: Robert Jarzmik Tested-by: Petr Cvek --- Since v1: modified __REG macro to cope

[PATCH v3 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-26 Thread Robert Jarzmik
previously the minimum turnaround time was counted in 76ns steps, while with this patch it is counted in microsecond steps. The strictly equal formula would have been : while ((sched_clock() - si->last_clk) * 76 < mtt) Signed-off-by: Robert Jarzmik --- Since v2: fixed clock calculat

Re: [PATCH 1/3] dmaengine: virt-dma: don't always free descriptor upon completion

2015-09-24 Thread Robert Jarzmik
Vinod Koul writes: > On Sun, Sep 06, 2015 at 01:40:52PM +0200, Robert Jarzmik wrote: >> @@ -29,7 +29,7 @@ dma_cookie_t vchan_tx_submit(struct >> dma_async_tx_descriptor *tx) >> spin_lock_irqsave(&vc->lock, flags); >> cookie = dma_cookie_assign(tx); &g

Re: [PATCH] dmaengine: pxa_dma: fix initial list move

2015-09-24 Thread Robert Jarzmik
Vinod Koul writes: > On Mon, Sep 21, 2015 at 11:06:32AM +0200, Robert Jarzmik wrote: >> Since the commit to have an allocated list of virtual descriptors was >> reverted, the pxa_dma driver is broken, as it assumes the descriptor is >> placed on the allocated list upon alloc

Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-22 Thread Robert Jarzmik
David Miller writes: > From: Robert Jarzmik > Date: Fri, 18 Sep 2015 18:36:56 +0200 > >> Which brings me to wonder which is the more correct : >> (a) replace to reproduce the same calculation >> Previously mtt was compared to a difference of 76ns steps (as 3

[PATCH v2] ASoC: pxa: pxa2xx-ac97: fix dma requestor lines

2015-09-22 Thread Robert Jarzmik
: use snd_dmaengine_dai_dma_data") Signed-off-by: Robert Jarzmik --- Since v1: rebase on Linus's master, not my dmaengine tip branch. --- sound/soc/pxa/pxa2xx-ac97.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/pxa/pxa2xx-ac97.c b/sound/soc/pxa/pxa2xx-ac97.c ind

Re: [PATCH v3 01/12] pwm: introduce default period and polarity concepts

2015-09-21 Thread Robert Jarzmik
the default helpers should > be used in place of the standard ones. > > Signed-off-by: Boris Brezillon For pwm-pxa.c : Acked-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

[PATCH] dmaengine: pxa_dma: fix initial list move

2015-09-21 Thread Robert Jarzmik
evert "dmaengine: virt-dma: don't always free descriptor upon completion"") Signed-off-by: Robert Jarzmik --- Vinod, this is my fallback plan as I'm getting no answer on https://lkml.org/lkml/2015/9/6/112. If I get no answer before v4.3-rc3, I'll put that into the p

Re: [PATCH] ARM: pxa: Remove unused clock_enable field from struct pxa2xx_spi_master

2015-09-20 Thread Robert Jarzmik
Jarkko Nikula writes: > Use for struct pxa2xx_spi_master clock_enable field was removed years ago > from the pxa2xx-spi driver by the commit 2f1a74e5a2de ("[ARM] pxa: make > pxa2xx_spi driver use ssp_request()/ssp_free()"). > > Therefore remove it from structure definition, documentation and from

[PATCH v2] ARM: pxa: mioa701: add wm9713 codec

2015-09-18 Thread Robert Jarzmik
The mioa701 is using the wm9713 for audio, battery and touchscreen. Add the missing audio part, which disappeared. Signed-off-by: Robert Jarzmik --- Since v1: Igor's catch of subject prefix issue --- arch/arm/mach-pxa/mioa701.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm

Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-18 Thread Robert Jarzmik
David Miller writes: >> My understanding is that the flow will be : >> sched_clock() >>rd->read_sched_clock() (cyc_to_ns() transformed for return) >> pxa_read_sched_clock() >>readl_relaxed(OSCR) >> >> I didn't see any timings issue, as the flow looks equivalent to the >> readl

Re: [PATCH] ARM: pxa: add wm9713 codec

2015-09-18 Thread Robert Jarzmik
Igor Grinberg writes: > Hi Robert, > > On 09/16/15 22:42, Robert Jarzmik wrote: >> The mioa701 is using the wm9713 for audio, battery and touchscreen. Add >> the missing audio part, which disappeared. >> >> Signed-off-by: Robert Jarzmik > > The subjec

Re: [PATCH v2] mmc: pxamci: fix card detect with slot-gpio API

2015-09-17 Thread Robert Jarzmik
Ulf Hansson writes: >> + if (gpio_is_valid(gpio_ro)) >> + ret = mmc_gpio_request_ro(mmc, gpio_ro); > > Would it be possible for you to use the mmc_gpiod_request_ro() instead? I don't think so. Most of pxamci users are old platform data based machine code, which passes an integ

[PATCH] ARM: pxa: add wm9713 codec

2015-09-16 Thread Robert Jarzmik
The mioa701 is using the wm9713 for audio, battery and touchscreen. Add the missing audio part, which disappeared. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/mioa701.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-pxa/mioa701.c b/arch/arm/mach-pxa/mioa701.c index

Re: [PATCH 1/3] dmaengine: virt-dma: don't always free descriptor upon completion

2015-09-16 Thread Robert Jarzmik
Robert Jarzmik writes: > Robert Jarzmik writes: > Hi Jun, Lars-Peter and Vinod, > > The revert of the former patch of this type, 8c8fe97b2b8a ("Revert "dmaengine: > virt-dma: don't always free descriptor upon completion"") broke pxa_dma > driver. So

[PATCH v2] mmc: pxamci: fix card detect with slot-gpio API

2015-09-16 Thread Robert Jarzmik
cannot be a nested interrupt from a threaded interrupt (set __setup_irq()). This was tested on zylonite and mioa701 boards. Signed-off-by: Robert Jarzmik Cc: Petr Cvek --- Since v1: trade threaded interrupt for slot-gpio API --- drivers/mmc/host/pxamci.c | 58

Re: [PATCH] net: smc91x: convert pxa dma to dmaengine

2015-09-16 Thread Robert Jarzmik
David Miller writes: > From: Robert Jarzmik > Date: Thu, 10 Sep 2015 21:26:04 +0200 > >> Convert the dma transfers to be dmaengine based, now pxa has a dmaengine >> slave driver. This makes this driver a bit more PXA agnostic. >> >> The driver was tested

Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-16 Thread Robert Jarzmik
David Miller writes: > From: Robert Jarzmik > Date: Sat, 12 Sep 2015 13:45:22 +0200 > >> Instead of using directly the OS timer through direct register access, >> use the standard sched_clock(), which will end up in OSCR reading >> anyway. >> >> This is

Re: [PATCH] mmc: pxamci: fix card detect threaded interrupt

2015-09-16 Thread Robert Jarzmik
Ulf Hansson writes: > On 12 September 2015 at 11:03, Robert Jarzmik wrote: >> Change the interrupt flavor of the card detection, from a hard interrupt >> to a threaded interrupt. There is no strong requirement for a hard >> interrupt. >> >> It fixes the case

[PATCH] ASoC: fix broken pxa SoC support

2015-09-15 Thread Robert Jarzmik
xa2xx-ac97 compilation. Fixes: 846172dfe33c ("ASoC: fix SND_PXA2XX_LIB Kconfig warning") Signed-off-by: Robert Jarzmik --- sound/arm/Kconfig | 15 --- sound/soc/pxa/Kconfig | 2 -- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/sound/arm/Kconfig b/sou

Re: [BUG] Kernel error when first driver unbind with empty MMC slot

2015-09-13 Thread Robert Jarzmik
Petr Cvek writes: > During testing of these patches > > [PATCH] mmc: pxamci: fix card detect threaded interrupt > [PATCH 1/3] dmaengine: virt-dma: don't always free descriptor upon > completion > > I have found unrelated error. > > How to reproduce: > > 1) Remove any SD card > 2) No

Re: [PATCH] ARM: pxa: fix DFI bus lockups on startup

2015-09-12 Thread Robert Jarzmik
Robert Jarzmik writes: > After the conversion of pxa architecture to common clock framework, the > NAND clock can be disabled on startup if no nand driver claims it. > > In this case, it happens that if the bootloader used the NAND and set > the DFI arbitration bit, the next acc

Re: [PATCH 1/3] dmaengine: virt-dma: don't always free descriptor upon completion

2015-09-12 Thread Robert Jarzmik
Robert Jarzmik writes: > This patch attempts to enhance the case of a transfer submitted multiple > times, and where the cost of creating the descriptors chain is not > negligible. > > This happens with big video buffers (several megabytes, ie. several > thousands of linked

[PATCH v2 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-12 Thread Robert Jarzmik
Convert the pxa IRDA driver to readl and writel primitives, and remove another set of direct registers access. This leaves only the DMA registers access, which will be dealt with dmaengine conversion. Signed-off-by: Robert Jarzmik --- Since v1: modified __REG macro to cope with STIER, ST

[PATCH v2 3/3] net: irda: pxaficp_ir: dmaengine conversion

2015-09-12 Thread Robert Jarzmik
Convert pxaficp_ir to dmaengine. As pxa architecture is shifting from raw DMA registers access to pxa_dma dmaengine driver, convert this driver to dmaengine. Signed-off-by: Robert Jarzmik --- Since v1: removed mach/dma.h include, which is the goal --- drivers/net/irda/pxaficp_ir.c | 149

[PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-12 Thread Robert Jarzmik
Instead of using directly the OS timer through direct register access, use the standard sched_clock(), which will end up in OSCR reading anyway. This is a first step for direct access register removal and machine specific code removal from this driver. Signed-off-by: Robert Jarzmik --- drivers

[PATCH] ARM: pxa: add resources to pxaficp_ir

2015-09-12 Thread Robert Jarzmik
Add io memory and dma requestor lines to the irda pxa device. This is part of the conversion of pxaficp_ir to dmaengine, and to shrink its adherence to 'mach' includes. Signed-off-by: Robert Jarzmik Cc: Petr Cvek --- arch/arm/mach-pxa/devices.c | 20 1 file c

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-12 Thread Robert Jarzmik
Petr Cvek writes: And it is true I have not tested the rootfs special case, where drivers are not yet initialized (and more specifically gpio and interrupt chip). Your backtrace should tell me if you fall into this category of issues ... but I digress, this h

[PATCH] mmc: pxamci: fix card detect threaded interrupt

2015-09-12 Thread Robert Jarzmik
interrupt is called from a threaded interrupt. The request_irq() fails, because a hard irq cannot be a nested interrupt from a threaded interrupt (set __setup_irq()). This was tested on zylonite and mioa701 boards. Signed-off-by: Robert Jarzmik Cc: Petr Cvek --- drivers/mmc/host/pxamci.c | 6

<    4   5   6   7   8   9   10   11   12   13   >