RE: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-20 Thread Robin Gong
On 2021/04/19 17:46 Lucas Stach wrote: > Am Montag, dem 19.04.2021 um 07:17 + schrieb Robin Gong: > > Hi Lucas, > > > > On 2021/04/14 Lucas Stach wrote: > > > Hi Robin, > > > > > > Am Mittwoch, dem 14.04.2021 um 14:33 + schrieb Robin Gong

RE: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-19 Thread Robin Gong
Hi Lucas, On 2021/04/14 Lucas Stach wrote: > Hi Robin, > > Am Mittwoch, dem 14.04.2021 um 14:33 + schrieb Robin Gong: > > On 2020/05/20 17:43 Lucas Stach wrote: > > > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > > > > Hi > > &

RE: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-14 Thread Robin Gong
On 2020/05/20 17:43 Lucas Stach wrote: > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > > Hi > > > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach > wrote: > > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > > > There are two requirements that we need to

RE: [PATCH v14 12/12] dmaengine: imx-sdma: add terminated list for freed descriptor in worker

2021-04-12 Thread Robin Gong
On 2021/04/12 17:39, Vinod Koul wrote: > On 07-04-21, 23:30, Robin Gong wrote: > > Add terminated list for keeping descriptor so that it could be freed > > in worker without any potential involving next descriptor raised up > > before this descriptor freed, because vcha

[PATCH v14 12/12] dmaengine: imx-sdma: add terminated list for freed descriptor in worker

2021-04-07 Thread Robin Gong
, the next descriptor maybe freed unexpectly when it's done in worker without this patch. https://www.spinics.net/lists/dmaengine/msg23367.html Signed-off-by: Robin Gong Reported-by: Richard Leitner --- drivers/dma/imx-sdma.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions

[PATCH v14 11/12] dmaengine: imx-sdma: add uart rom script

2021-04-07 Thread Robin Gong
the below and put them into the path (/lib/firmware/imx/sdma/): https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git /tree/imx/sdma Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 17 +++-- include/linux/platform_data

[PATCH v14 10/12] dma: imx-sdma: add i.mx6ul compatible name

2021-04-07 Thread Robin Gong
Add i.mx6ul compatible name in binding doc. Signed-off-by: Robin Gong Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt b/Documentation/devicetree

[PATCH v14 09/12] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul

2021-04-07 Thread Robin Gong
ECSPI issue fixed from i.mx6ul at hardware level, no need ERR009165 anymore on those chips such as i.mx8mq. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/dma/imx

[PATCH v14 08/12] spi: imx: remove ERR009165 workaround on i.mx6ul

2021-04-07 Thread Robin Gong
ERR009165 fixed on i.mx6ul/6ull/6sll. All other i.mx6/7 and i.mx8m/8mm still need this errata. Please refer to nxp official errata document from https://www.nxp.com/ . For removing workaround on those chips. Add new i.mx6ul type. Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi

[PATCH v14 07/12] spi: imx: fix ERR009165

2021-04-07 Thread Robin Gong
Change to XCH mode even in dma mode, please refer to the below errata: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi/spi-imx.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-imx.c

[PATCH v14 06/12] dmaengine: imx-sdma: add mcu_2_ecspi script

2021-04-07 Thread Robin Gong
Add mcu_2_ecspi script to fix ecspi errata ERR009165. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 78dcfe2..86bd383 100644 --- a/drivers/dma/imx-sdma.c

[PATCH v14 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script

2021-04-07 Thread Robin Gong
fallback into pio while dma transfer failed by sdma firmware not ready(next ERR009165 patch depends on sdma RAM scripts/firmware). Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/dma/imx-sdma.c

[PATCH v14 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context

2021-04-07 Thread Robin Gong
Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Fixes: ad0d92d7ba6a ("dmaengine: imx-sdma: refine to load context only once") Cc: Signed-off-by: Robin Gong Acked-by: Vinod Koul Tested-by: Richard Leitner --

[PATCH v14 03/12] Revert "dmaengine: imx-sdma: refine to load context only once"

2021-04-07 Thread Robin Gong
This reverts commit ad0d92d7ba6aecbe2705907c38ff8d8be4da1e9c, because in spi-imx case, burst length may be changed dynamically. Fixes: ad0d92d7ba6a ("dmaengine: imx-sdma: refine to load context only once") Cc: Signed-off-by: Robin Gong Acked-by: Sascha Hauer Tested-by: Richa

[PATCH v14 02/12] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"

2021-04-07 Thread Robin Gong
can cause the current FIFO transfer to be sent twice So revert commit 'dd4b487b32a3' firstly. Signed-off-by: Robin Gong Acked-by: Sascha Hauer --- arch/arm/boot/dts/imx6qdl.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b

[PATCH v14 01/12] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"

2021-04-07 Thread Robin Gong
litch can cause the current FIFO transfer to be sent twice So revert commit 'df07101e1c4a' firstly. Signed-off-by: Robin Gong Acked-by: Sascha Hauer --- arch/arm/boot/dts/imx6q.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm

[PATCH v14 00/12] add ecspi ERR009165 for i.mx6/7 soc family

2021-04-07 Thread Robin Gong
ps://lkml.org/lkml/2020/8/17/39 https://www.spinics.net/lists/dmaengine/msg23489.html 4. fix potential descriptor free unexpected on the next transfer before the last channel terminated: https://www.spinics.net/lists/dmaengine/msg23400.html v14: 1. rebase with latest linux-next.

[PATCH v1 ] ALSA: core: memalloc: add page alignment for iram

2020-12-17 Thread Robin Gong
Since mmap for userspace is based on page alignment, add page alignment for iram alloc from pool, otherwise, some good data located in the same page of dmab->area maybe touched wrongly by userspace like pulseaudio. Signed-off-by: Robin Gong --- sound/core/memalloc.c | 3 ++- 1 file changed

RE: [PATCH v1 1/2] regulator: pca9450: add enable_val for all bucks

2020-09-29 Thread Robin Gong
On 2020/09/01 9:58 Robin Gong wrote: > On 2020/08/31 18:53 Marco Felsch wrote: > > Hi Robin, > > > > On 20-09-01 00:48, Robin Gong wrote: > > > BuckX enable mode > > > 00b = OFF > > > 01b = ON by PMIC_ON_REQ = H > > > 10b

RE: [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line pull-up

2020-09-28 Thread Robin Gong
dts: imx8mm: correct interrupt flags") > Fixes: aa71d0648318 ("arm64: dts: imx8mm: Split the imx8mm evk board dts > to a common dtsi") > Signed-off-by: Krzysztof Kozlowski Please tag me with the whole patch set, thanks. Reviewed-by: Robin Gong > --- > arch/arm64/boot/dts

RE: [PATCH v13 00/12] add ecspi ERR009165 for i.mx6/7 soc family

2020-09-21 Thread Robin Gong
On 2020/09/12 0:40 Marco Felsch wrote: > Hi Robin, > > I took your patches and did a few test on the mainline available > fsl,imx6q-sabrelite. I used a vanilla linux version v5.9-rc1 for all my tests > except > the needed SPI-NOR patches [1]. Following are my results: Marco, thanks for your

RE: [PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting

2020-08-31 Thread Robin Gong
On 2020/08/31 19:12 Fabio Estevam wrote: > Hi Robin, > > On Mon, Aug 31, 2020 at 6:22 AM Robin Gong wrote: > > > > Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so > > that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 >

[PATCH v1 RESEND] ARM64: dts: imx8mp: correct sdma1 clk setting

2020-08-31 Thread Robin Gong
Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 use 1:1. Fixes: 6d9b8d20431f ("arm64: dts: freescale: Add i.MX8MP dtsi support") Cc: Signed-off-by: Robin Gong --- arch/arm64/boot/dts

RE: [PATCH v1 1/2] regulator: pca9450: add enable_val for all bucks

2020-08-31 Thread Robin Gong
On 2020/08/31 18:53 Marco Felsch wrote: > Hi Robin, > > On 20-09-01 00:48, Robin Gong wrote: > > BuckX enable mode > > 00b = OFF > > 01b = ON by PMIC_ON_REQ = H > > 10b = ON by PMIC_ON_REQ = H && PMIC_STBY_REQ = L 11b = Always ON > > > > For

[PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting

2020-08-31 Thread Robin Gong
Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 use 1:1. Signed-off-by: Robin Gong --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch

[PATCH v1 2/2] ARM64: dts: imx8mp-evk: add pca9450 node

2020-08-31 Thread Robin Gong
Add pca9450c pmic for imx8mp-evk board. Signed-off-by: Robin Gong --- arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 115 +++ 1 file changed, 115 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts

[PATCH v1 1/2] regulator: pca9450: add enable_val for all bucks

2020-08-31 Thread Robin Gong
gned-off-by: Robin Gong --- drivers/regulator/pca9450-regulator.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c index eb5822b..79f2a5a 100644 --- a/drivers/regulator/pca9450-reg

[PATCH v13 11/12] dmaengine: imx-sdma: add uart rom script

2020-08-31 Thread Robin Gong
the below and put them into the path (/lib/firmware/imx/sdma/): https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git /tree/imx/sdma Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 17 +++-- include/linux/platform_data

[PATCH v13 12/12] dmaengine: imx-sdma: add terminated list for freed descriptor in worker

2020-08-31 Thread Robin Gong
, the next descriptor maybe freed unexpectly when it's done in worker without this patch. https://www.spinics.net/lists/dmaengine/msg23367.html Signed-off-by: Robin Gong Reported-by: Richard Leitner --- drivers/dma/imx-sdma.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions

[PATCH v13 10/12] dma: imx-sdma: add i.mx6ul compatible name

2020-08-31 Thread Robin Gong
Add i.mx6ul compatible name in binding doc. Signed-off-by: Robin Gong Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt b/Documentation/devicetree

[PATCH v13 09/12] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul

2020-08-31 Thread Robin Gong
ECSPI issue fixed from i.mx6ul at hardware level, no need ERR009165 anymore on those chips such as i.mx8mq. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/dma

[PATCH v13 07/12] spi: imx: fix ERR009165

2020-08-31 Thread Robin Gong
Change to XCH mode even in dma mode, please refer to the below errata: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi/spi-imx.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-imx.c

[PATCH v13 08/12] spi: imx: remove ERR009165 workaround on i.mx6ul

2020-08-31 Thread Robin Gong
ERR009165 fixed on i.mx6ul/6ull/6sll. All other i.mx6/7 and i.mx8m/8mm still need this errata. Please refer to nxp official errata document from https://www.nxp.com/ . For removing workaround on those chips. Add new i.mx6ul type. Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi

[PATCH v13 06/12] dmaengine: imx-sdma: add mcu_2_ecspi script

2020-08-31 Thread Robin Gong
Add mcu_2_ecspi script to fix ecspi errata ERR009165. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 10214bb..fb522a1 100644 --- a/drivers/dma/imx-sdma.c

[PATCH v13 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script

2020-08-31 Thread Robin Gong
fallback into pio while dma transfer failed by sdma firmware not ready(next ERR009165 patch depends on sdma RAM scripts/firmware). Signed-off-by: Robin Gong Acked-By: Vinod Koul --- drivers/dma/imx-sdma.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/dma/imx-sdma.c

[PATCH v13 02/12] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"

2020-08-31 Thread Robin Gong
can cause the current FIFO transfer to be sent twice So revert commit 'dd4b487b32a3' firstly. Signed-off-by: Robin Gong Acked-by: Sascha Hauer --- arch/arm/boot/dts/imx6qdl.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b

[PATCH v13 03/12] Revert "dmaengine: imx-sdma: refine to load context only once"

2020-08-31 Thread Robin Gong
This reverts commit ad0d92d7ba6aecbe2705907c38ff8d8be4da1e9c, because in spi-imx case, burst length may be changed dynamically. Fixes: ad0d92d7ba6a ("dmaengine: imx-sdma: refine to load context only once") Cc: Signed-off-by: Robin Gong Acked-by: Sascha Hauer Tested-by: Richa

[PATCH v13 01/12] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"

2020-08-31 Thread Robin Gong
litch can cause the current FIFO transfer to be sent twice So revert commit 'df07101e1c4a' firstly. Signed-off-by: Robin Gong Acked-by: Sascha Hauer --- arch/arm/boot/dts/imx6q.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm

[PATCH v13 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context

2020-08-31 Thread Robin Gong
Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Fixes: ad0d92d7ba6a ("dmaengine: imx-sdma: refine to load context only once") Cc: Signed-off-by: Robin Gong Acked-by: Vinod Koul Tested-by: Richard Leitner --

[PATCH v13 00/12] add ecspi ERR009165 for i.mx6/7 soc family

2020-08-31 Thread Robin Gong
ps://lkml.org/lkml/2020/8/17/39 https://www.spinics.net/lists/dmaengine/msg23489.html 4. fix potential descriptor free unexpected on the next transfer before the last channel terminated: https://www.spinics.net/lists/dmaengine/msg23400.html Robin Gong (12): Revert "ARM:

RE: pcm|dmaengine|imx-sdma race condition on i.MX6

2020-08-21 Thread Robin Gong
On 2020/08/20 14:52 Sascha Hauer wrote: > On Wed, Aug 19, 2020 at 01:08:29PM +0200, Lars-Peter Clausen wrote: > > > For the first option, which is potentially more performant, we have > > > to leave the atomic PCM context and we are not sure if we are allowed to. > > > For the second option, we

RE: pcm|dmaengine|imx-sdma race condition on i.MX6

2020-08-21 Thread Robin Gong
On 2020/08/21 12:34 Richard Leitner wrote: > On Thu, Aug 20, 2020 at 03:01:44PM +0000, Robin Gong wrote: > > On 2020/08/19 22:26 Benjamin Bara - SKIDATA > wrote: > > > > > > @Robin: > > > Is it possible to tag the commits for the stable-tree > > >

RE: pcm|dmaengine|imx-sdma race condition on i.MX6

2020-08-20 Thread Robin Gong
On 2020/08/19 22:26 Benjamin Bara - SKIDATA wrote: > > -Original Message- > > From: Lars-Peter Clausen > > Sent: Mittwoch, 19. August 2020 13:08 > > I think this might be an sdma specific problem after all. > > dmaengine_terminate_async() will issue a request to stop the DMA. But > > it

RE: pcm|dmaengine|imx-sdma race condition on i.MX6

2020-08-18 Thread Robin Gong
On 2020/08/17 19:38 Benjamin Bara - SKIDATA wrote: > > -Original Message- > > From: Robin Gong > > Sent: Montag, 17. August 2020 11:23 > > busy_wait is not good I think, would you please have a try with the > > attached patch which

RE: pcm|dmaengine|imx-sdma race condition on i.MX6

2020-08-17 Thread Robin Gong
On 2020/08/17 15:29 Benjamin Bara - SKIDATA wrote: > We think this is not an i.MX6-specific problem, but a problem of the > DMAengine usage from the PCM. > In case of a XRUN, the DMA channel is never closed but first a > SNDRV_PCM_TRIGGER_STOP next a SNDRV_PCM_TRIGGER_START is triggered. > The

RE: pcm|dmaengine|imx-sdma race condition on i.MX6

2020-08-14 Thread Robin Gong
On 2020/08/13 19:23: Richard Leitner wrote: > Hi, > we've found a race condition with the PCM on the i.MX6 which results in an > -EIO for the SNDRV_PCM_IOCTL_READI_FRAMES ioctl after an -EPIPE (XRUN). > > A possible reproduction may look like the following reduced call graph during > a > PCM

[PATCH v12 06/12] dmaengine: imx-sdma: add mcu_2_ecspi script

2020-08-11 Thread Robin Gong
Add mcu_2_ecspi script to fix ecspi errata ERR009165. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index cf02c3e..d5d5d40 100644 --- a/drivers/dma/imx-sdma.c

[PATCH v12 11/12] dma: imx-sdma: add i.mx6ul compatible name

2020-08-11 Thread Robin Gong
Add i.mx6ul compatible name in binding doc. Signed-off-by: Robin Gong Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt b/Documentation/devicetree

[PATCH v12 08/12] spi: imx: remove ERR009165 workaround on i.mx6ul

2020-08-11 Thread Robin Gong
ERR009165 fixed on i.mx6ul/6ull/6sll. All other i.mx6/7 and i.mx8m/8mm still need this errata. Please refer to nxp official errata document from https://www.nxp.com/ . For removing workaround on those chips. Add new i.mx6ul type. Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi

[PATCH v12 12/12] dmaengine: imx-sdma: add uart rom script

2020-08-11 Thread Robin Gong
the below and put them into the path (/lib/firmware/imx/sdma/): https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git /tree/imx/sdma Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 17 +++-- include/linux/platform_data

[PATCH v12 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script

2020-08-11 Thread Robin Gong
fallback into pio while dma transfer failed by sdma firmware not ready(next ERR009165 patch depends on sdma RAM scripts/firmware). Signed-off-by: Robin Gong Acked-By: Vinod Koul --- drivers/dma/imx-sdma.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/dma/imx-sdma.c

[PATCH v12 07/12] spi: imx: fix ERR009165

2020-08-11 Thread Robin Gong
Change to XCH mode even in dma mode, please refer to the below errata: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi/spi-imx.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-imx.c

[PATCH v12 10/12] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul

2020-08-11 Thread Robin Gong
ECSPI issue fixed from i.mx6ul at hardware level, no need ERR009165 anymore on those chips such as i.mx8mq. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/dma

[PATCH v12 09/12] spi: imx: add new i.mx6ul compatible name in binding doc

2020-08-11 Thread Robin Gong
ERR009165 fixed from i.mx6ul, add its compatible name in binding doc. Signed-off-by: Robin Gong Acked-by: Mark Brown Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/spi

[PATCH v12 03/12] Revert "dmaengine: imx-sdma: refine to load context only once"

2020-08-11 Thread Robin Gong
This reverts commit ad0d92d7ba6aecbe2705907c38ff8d8be4da1e9c, because in spi-imx case, burst length may be changed dynamically. Signed-off-by: Robin Gong Acked-by: Sascha Hauer --- drivers/dma/imx-sdma.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/dma/imx-sdma.c b

[PATCH v12 00/12] add ecspi ERR009165 for i.mx6/7 soc family

2020-08-11 Thread Robin Gong
nt. v12: 1. take care uart_2_mcu_addr/uartsh_2_mcu_addr since such rom scripts are now located in the bottom part of sdma_script_start_addrs which are beyond the SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1. Reported by Frieder as below: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2263544.html Robin

[PATCH v12 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context

2020-08-11 Thread Robin Gong
Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/imx-sdma.c b

[PATCH v12 02/12] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"

2020-08-11 Thread Robin Gong
can cause the current FIFO transfer to be sent twice So revert commit 'dd4b487b32a3' firstly. Signed-off-by: Robin Gong Acked-by: Sascha Hauer --- arch/arm/boot/dts/imx6qdl.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b

[PATCH v12 01/12] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"

2020-08-11 Thread Robin Gong
litch can cause the current FIFO transfer to be sent twice So revert commit 'df07101e1c4a' firstly. Signed-off-by: Robin Gong Acked-by: Sascha Hauer --- arch/arm/boot/dts/imx6q.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm

RE: [PATCH v11 12/12] dmaengine: imx-sdma: add uart rom script

2020-08-10 Thread Robin Gong
On 2020/08/10 15:33 Frieder Schrempf wrote: > Hi Robin, > > This patch seems to break UART DMA in case the ROM firmware is used. In that > case sdma->script_number is set to SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1, so > the ROM scripts at uart_2_mcu_addr and uartsh_2_mcu_addr will never be > added in

[PATCH v11 11/12] dma: imx-sdma: add i.mx6ul compatible name

2020-07-24 Thread Robin Gong
Add i.mx6ul compatible name in binding doc. Signed-off-by: Robin Gong Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt b/Documentation/devicetree

[PATCH v11 12/12] dmaengine: imx-sdma: add uart rom script

2020-07-24 Thread Robin Gong
the below and put them into the path (/lib/firmware/imx/sdma/): https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git /tree/imx/sdma Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 4 ++-- include/linux/platform_data/dma-imx-sdma.h

[PATCH v11 02/12] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"

2020-07-24 Thread Robin Gong
can cause the current FIFO transfer to be sent twice So revert commit 'dd4b487b32a3' firstly. Signed-off-by: Robin Gong Acked-by: Sascha Hauer --- arch/arm/boot/dts/imx6qdl.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b

[PATCH v11 03/12] Revert "dmaengine: imx-sdma: refine to load context only once"

2020-07-24 Thread Robin Gong
This reverts commit ad0d92d7ba6aecbe2705907c38ff8d8be4da1e9c, because in spi-imx case, burst length may be changed dynamically. Signed-off-by: Robin Gong Acked-by: Sascha Hauer --- drivers/dma/imx-sdma.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/dma/imx-sdma.c b

[PATCH v11 10/12] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul

2020-07-24 Thread Robin Gong
ECSPI issue fixed from i.mx6ul at hardware level, no need ERR009165 anymore on those chips such as i.mx8mq. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/dma

[PATCH v11 08/12] spi: imx: remove ERR009165 workaround on i.mx6ul

2020-07-24 Thread Robin Gong
ERR009165 fixed on i.mx6ul/6ull/6sll. All other i.mx6/7 and i.mx8m/8mm still need this errata. Please refer to nxp official errata document from https://www.nxp.com/ . For removing workaround on those chips. Add new i.mx6ul type. Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi

[PATCH v11 09/12] spi: imx: add new i.mx6ul compatible name in binding doc

2020-07-24 Thread Robin Gong
ERR009165 fixed from i.mx6ul, add its compatible name in binding doc. Signed-off-by: Robin Gong Acked-by: Mark Brown Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/spi

[PATCH v11 07/12] spi: imx: fix ERR009165

2020-07-24 Thread Robin Gong
Change to XCH mode even in dma mode, please refer to the below errata: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi/spi-imx.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-imx.c

[PATCH v11 06/12] dmaengine: imx-sdma: add mcu_2_ecspi script

2020-07-24 Thread Robin Gong
Add mcu_2_ecspi script to fix ecspi errata ERR009165. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index cf02c3e..d5d5d40 100644 --- a/drivers/dma/imx-sdma.c

[PATCH v11 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script

2020-07-24 Thread Robin Gong
fallback into pio while dma transfer failed by sdma firmware not ready(next ERR009165 patch depends on sdma RAM scripts/firmware). Signed-off-by: Robin Gong Acked-By: Vinod Koul --- drivers/dma/imx-sdma.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/dma/imx-sdma.c

[PATCH v11 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context

2020-07-24 Thread Robin Gong
Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/imx-sdma.c b

[PATCH v11 01/12] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"

2020-07-24 Thread Robin Gong
litch can cause the current FIFO transfer to be sent twice So revert commit 'df07101e1c4a' firstly. Signed-off-by: Robin Gong Acked-by: Sascha Hauer --- arch/arm/boot/dts/imx6q.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm

[PATCH v11 00/12] add ecspi ERR009165 for i.mx6/7 soc family

2020-07-24 Thread Robin Gong
check to include RX event for UART6") -- commit 2f57b8d57673 ("dmaengine: imx-sdma: Fix: Remove 'always true' comparison") v11: 1. change dev_err() to dev_warn_once() in case sdma firmware not loaded to eliminate meaningless duplicate log print. Robin Gong (

RE: [PATCH v2 6/9] dt-bindings: dma: add fsl-edma3 yaml

2020-07-24 Thread Robin Gong
On 2020/07/17 3:48 Rob Herring wrote: > > + > > + reg: > > +minItems: 2 > > +maxItems: 32 > > Needs some sort of description as to what each region is. Okay, will add it in v3. > > > + > > + interrupts: > > +minItems: 2 > > +maxItems: 32 > > ditto Will add it in v3. > > > +

RE: [PATCH v10 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script

2020-07-23 Thread Robin Gong
On 2020/07/23 19:52 Frieder Schrempf wrote: > > > The warning log comes out during spi > > transfer start and sdma firmware loading done, but if sdma driver > > building as module could ensure firmware loading done in > > sdma_driver_probe_phase-> spi_imx_probe_phase, which means sdma > >

RE: [PATCH v10 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script

2020-07-23 Thread Robin Gong
> On 2020/07/23 17:04 Frieder Schrempf > wrote: > > Hi Robin, > > > > On 30.06.20 15:31, Robin Gong wrote: > > > Add 'fw_loaded' and 'is_ram_script' to check if the script used by > > > channel is ram script and it's loaded or not, so that could prev

RE: [PATCH v10 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script

2020-07-23 Thread Robin Gong
On 2020/07/23 17:04 Frieder Schrempf wrote: > Hi Robin, > > On 30.06.20 15:31, Robin Gong wrote: > > Add 'fw_loaded' and 'is_ram_script' to check if the script used by > > channel is ram script and it's loaded or not, so that could prevent > > meaningless following m

[PATCH v2 8/9] arm64: dts: imx8qxp: add edma2

2020-07-14 Thread Robin Gong
add edma2 on i.mx8qxp. Signed-off-by: Robin Gong --- arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 38 ++ 1 file changed, 38 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi index e46faac..3f4fa59d

[PATCH v2 7/9] firmware: imx: scu-pd: correct dma resource

2020-07-14 Thread Robin Gong
enlarge dma0/dma1 channel resource to 32 and split two parts of dma2 since their resource id are not continouse. Signed-off-by: Robin Gong --- drivers/firmware/imx/scu-pd.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/imx/scu-pd.c b/drivers

[PATCH v2 5/9] dmaengine: fsl-edma3: add fsl-edma3 driver

2020-07-14 Thread Robin Gong
edma but split on edma3. 3. per interrupt per channel on edma3. 4. totally different register layer and add some register such as SBR 5. power domain support, per domain per channel. Signed-off-by: Robin Gong --- drivers/dma/Kconfig | 12 + drivers/dma/Makefile | 1

[PATCH v2 4/9] dmaengine: fsl-edma-common: export fsl_edma_set_tcd_regs

2020-07-14 Thread Robin Gong
Preparing for edma3 since it need to be called in fsl-edma3.c Signed-off-by: Robin Gong --- drivers/dma/fsl-edma-common.c | 3 ++- drivers/dma/fsl-edma-common.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c

[PATCH v2 9/9] arm64: defconfig: add CONFIG_FSL_EDMA3

2020-07-14 Thread Robin Gong
Add CONFIG_FSL_EDMA3 for i.mx8qxp/i.mx8qm. Signed-off-by: Robin Gong --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index ae76fae..d786bd9 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64

[PATCH v2 6/9] dt-bindings: dma: add fsl-edma3 yaml

2020-07-14 Thread Robin Gong
Add device binding doc for fsl-edma3 driver. Signed-off-by: Robin Gong --- .../devicetree/bindings/dma/nxp,fsl-edma3.yaml | 134 + 1 file changed, 134 insertions(+) create mode 100644 Documentation/devicetree/bindings/dma/nxp,fsl-edma3.yaml diff --git a/Documentation

[PATCH v2 3/9] dmaengine: fsl-edma-common: add fsl_chan into fsl_edma_fill_tcd

2020-07-14 Thread Robin Gong
For preparing for next edma3 merged so that any member of 'struct fsl_chan' could be used in fsl_edma_fill_tcd. Signed-off-by: Robin Gong --- drivers/dma/fsl-edma-common.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/dma/fsl-edma

[PATCH v2 1/9] dmaengine: fsl-edma: move edma_request functions into drvdata

2020-07-14 Thread Robin Gong
Move fsl_edma_enable_request/fsl_edma_disable_request into drvdata so that later edma3 could easily be added. Signed-off-by: Robin Gong --- drivers/dma/fsl-edma-common.c | 13 +++-- drivers/dma/fsl-edma-common.h | 3 +++ drivers/dma/fsl-edma.c| 10 -- drivers/dma/mcf

[PATCH v2 2/9] dmaengine: fsl-edma-common: add condition check for fsl_edma_chan_mux

2020-07-14 Thread Robin Gong
Since next edma3 don't have dmamux, add condition check in the common fsl_edma_free_chan_resources(). Signed-off-by: Robin Gong --- drivers/dma/fsl-edma-common.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c

[PATCH v2 0/9] add fsl-edma3 support

2020-07-14 Thread Robin Gong
. v2: 1. fix yaml binding doc build warning. Robin Gong (9): dmaengine: fsl-edma: move edma_request functions into drvdata dmaengine: fsl-edma-common: add condition check for fsl_edma_chan_mux dmaengine: fsl-edma-common: add fsl_chan into fsl_edma_fill_tcd dmaengine: fsl-edma-common

[PATCH v2 1/4] regulator: pca9450: add pca9450 pmic driver

2020-07-03 Thread Robin Gong
Add NXP pca9450 pmic driver. Signed-off-by: Robin Gong --- drivers/regulator/Kconfig | 8 + drivers/regulator/Makefile| 1 + drivers/regulator/pca9450-regulator.c | 843 ++ include/linux/regulator/pca9450.h | 219 + 4 files

[PATCH v2 2/4] dt-bindings: regulator: add pca9450 regulator yaml

2020-07-03 Thread Robin Gong
Add device binding doc for pca9450 pmic driver. Signed-off-by: Robin Gong Reviewed-by: Rob Herring --- .../bindings/regulator/nxp,pca9450-regulator.yaml | 190 + 1 file changed, 190 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/nxp,pca9450

[PATCH v2 3/4] arm64: dts: imx8mn-evk: add pca9450 for i.mx8mn-evk board

2020-07-03 Thread Robin Gong
Add pca9450 pmic driver for i.mx8mn-evk board. Signed-off-by: Robin Gong --- arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 96 +++ arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 6 ++ 2 files changed, 102 insertions(+) diff --git a/arch/arm64/boot/dts/freescale

[PATCH v2 4/4] arm64: configs: add pca9450 pmic driver

2020-07-03 Thread Robin Gong
Add pca9450 pmic driver. Signed-off-by: Robin Gong --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index d786bd9..abd0438 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig

[PATCH v2 0/4] Add pca9450 driver

2020-07-03 Thread Robin Gong
, such as dulipcated buck4 description, debug info added etc. Robin Gong (4): regulator: pca9450: add pca9450 pmic driver dt-bindings: regulator: add pca9450 regulator yaml arm64: dts: imx8mn-evk: add pca9450 for i.mx8mn-evk board arm64: configs: add pca9450 pmic driver .../bindings/regulator/nxp

RE: [PATCH v1 6/9] dt-bindings: dma: add fsl-edma3 yaml

2020-07-03 Thread Robin Gong
On 2020/07/03 5:01 Rob Herring > > Please check and re-submit. Thanks, will fix it in v2.

RE: [PATCH v1 1/4] regulator: pca9450: add pca9450 pmic driver

2020-07-02 Thread Robin Gong
On 2020/07/02 20:05 Schrempf Frieder wrote: > Hi Robin, > > On 20.05.20 00:05, Robin Gong wrote: > > Add NXP pca9450 pmic driver. > > > > Signed-off-by: Robin Gong > > I rebased and applied on v5.8-rc3 an tested this with our i.MX8MM board with > PCA9450A.

[PATCH v1 9/9] arm64: configs: defconfig: add CONFIG_FSL_EDMA3

2020-07-02 Thread Robin Gong
Add CONFIG_FSL_EDMA3 for i.mx8qxp/i.mx8qm. Signed-off-by: Robin Gong --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index ae76fae..d786bd9 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64

[PATCH v1 7/9] firmware: imx: scu-pd: correct dma resource

2020-07-02 Thread Robin Gong
enlarge dma0/dma1 channel resource to 32 and split two parts of dma2 since their resource id are not continouse. Signed-off-by: Robin Gong --- drivers/firmware/imx/scu-pd.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/imx/scu-pd.c b/drivers

[PATCH v1 6/9] dt-bindings: dma: add fsl-edma3 yaml

2020-07-02 Thread Robin Gong
Add device binding doc for fsl-edma3 driver. Signed-off-by: Robin Gong --- .../devicetree/bindings/dma/nxp,fsl-edma3.yaml | 129 + 1 file changed, 129 insertions(+) create mode 100644 Documentation/devicetree/bindings/dma/nxp,fsl-edma3.yaml diff --git a/Documentation

[PATCH v1 8/9] arm64: dts: imx8qxp: add edma2

2020-07-02 Thread Robin Gong
add edma2 on i.mx8qxp. Signed-off-by: Robin Gong --- arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 38 ++ 1 file changed, 38 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi index e46faac..3f4fa59d

[PATCH v1 1/9] dmaengine: fsl-edma: move edma_request functions into drvdata

2020-07-02 Thread Robin Gong
Move fsl_edma_enable_request/fsl_edma_disable_request into drvdata so that later edma3 could easily be added. Signed-off-by: Robin Gong --- drivers/dma/fsl-edma-common.c | 13 +++-- drivers/dma/fsl-edma-common.h | 3 +++ drivers/dma/fsl-edma.c| 10 -- drivers/dma/mcf

[PATCH v1 4/9] dmaengine: fsl-edma-common: export fsl_edma_set_tcd_regs

2020-07-02 Thread Robin Gong
Preparing for edma3 since it need to be called in fsl-edma3.c Signed-off-by: Robin Gong --- drivers/dma/fsl-edma-common.c | 3 ++- drivers/dma/fsl-edma-common.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c

  1   2   3   4   5   6   7   8   9   >