support pfuze200 chip which remove SW1C and SW4 based on pfuze100.
Signed-off-by: Robin Gong b38...@freescale.com
---
drivers/regulator/pfuze100-regulator.c | 196 +++-
include/linux/regulator/pfuze100.h | 14 +++
2 files changed, 157 insertions(+), 53
Add basical dma support for ecspi. Validate on i.MX6qsabresd board.
Signed-off-by: Robin Gong
---
drivers/spi/spi-imx.c | 221 ++--
1 files changed, 211 insertions(+), 10 deletions(-)
diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index
Add basical dma support for ecspi. Validate on i.MX6qsabresd board.
Signed-off-by: Robin Gong b38...@freescale.com
---
drivers/spi/spi-imx.c | 221 ++--
1 files changed, 211 insertions(+), 10 deletions(-)
diff --git a/drivers/spi/spi-imx.c b/drivers
Some gpio-leds need retain the state even in suspend, such as charger led.
But this property missed in devicetree, add it.
Signed-off-by: Robin Gong
---
drivers/leds/leds-gpio.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds
Update the binding doc for new property: "retain-state-suspended"
Signed-off-by: Robin Gong
---
.../devicetree/bindings/leds/leds-gpio.txt | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/leds-g
Update the binding doc for new property: retain-state-suspended
Signed-off-by: Robin Gong b38...@freescale.com
---
.../devicetree/bindings/leds/leds-gpio.txt | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/leds
Some gpio-leds need retain the state even in suspend, such as charger led.
But this property missed in devicetree, add it.
Signed-off-by: Robin Gong b38...@freescale.com
---
drivers/leds/leds-gpio.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/leds/leds
Acked-by: Robin gong
On Mon, Dec 23, 2013 at 05:35:35PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Make PFUZE100 entry consistent with other Freescale PMIC entries, so that now
> we can have:
>
> <*> Freescale MC13783 regulator driver
>
Acked-by: Robin gong yibin.g...@freescale.com
On Mon, Dec 23, 2013 at 05:35:35PM -0200, Fabio Estevam wrote:
From: Fabio Estevam fabio.este...@freescale.com
Make PFUZE100 entry consistent with other Freescale PMIC entries, so that now
we can have:
* Freescale MC13783 regulator
unt, I think this fix is required.
>
Yes, you are right.
Reviewed-by: Robin Gong
Thanks.
> Thanks,
> Axel
> drivers/regulator/pfuze100-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/pfuze100-regulator.c
> b/drivers/r
this fix is required.
Yes, you are right.
Reviewed-by: Robin Gong b38...@freescale.com
Thanks.
Thanks,
Axel
drivers/regulator/pfuze100-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/pfuze100-regulator.c
b/drivers/regulator/pfuze100
>From software view this patch looks better, although original code match better
with the data sheet. Thanks Axel.
Reviewed-by: Robin Gong
Thanks.
On Tue, Jul 30, 2013 at 10:47:44PM +0800, Axel Lin wrote:
> Simplify the equation to calculate ramp_delay.
> Below equations are e
From software view this patch looks better, although original code match better
with the data sheet. Thanks Axel.
Reviewed-by: Robin Gong b38...@freescale.com
Thanks.
On Tue, Jul 30, 2013 at 10:47:44PM +0800, Axel Lin wrote:
Simplify the equation to calculate ramp_delay.
Below equations
Hi Mark,
Thanks for your kindly remind.
On Tue, Jul 30, 2013 at 11:21:10AM +0100, Mark Brown wrote:
> On Tue, Jul 30, 2013 at 11:23:11AM +0800, Robin Gong wrote:
> > Ok for me.
>
> For Linux kernel process you should say
>
> Acked-by: Robin Gong
>
> or
Hi Mark,
Thanks for your kindly remind.
On Tue, Jul 30, 2013 at 11:21:10AM +0100, Mark Brown wrote:
On Tue, Jul 30, 2013 at 11:23:11AM +0800, Robin Gong wrote:
Ok for me.
For Linux kernel process you should say
Acked-by: Robin Gong b38...@freescale.com
or
Reviewed
Ok for me.
On Tue, Jul 30, 2013 at 10:46:28AM +0800, Axel Lin wrote:
> Current code adjust min_uV and uV_step but missed adjusting the n_voltages
> setting.
>
> When BIT6 is clear:
> n_voltages = (1975000 - 40) / 25000 + 1 = 64
> When BIT6 is set:
> n_voltages = (330 -
On Tue, Jul 30, 2013 at 10:26:40AM +0800, Axel Lin wrote:
> 2013/7/30 Robin Gong :
> > On Mon, Jul 29, 2013 at 11:44:40PM +0800, Axel Lin wrote:
> >> >> Current code adjust min_uV and uV_step when SW2~SW4 high bit is set.
> >> >> I'm wondering if n_voltages
On Mon, Jul 29, 2013 at 11:44:40PM +0800, Axel Lin wrote:
> >> Current code adjust min_uV and uV_step when SW2~SW4 high bit is set.
> >> I'm wondering if n_voltages is correct or not in this case because
> >> the n_voltages is calculated by original equation (max-min/step + 1).
> >> What is the
Yes, it's reasonable from performance view.
On Mon, Jul 29, 2013 at 03:38:58PM +0800, Axel Lin wrote:
> All table based voltage list have ascendant order.
> Use regulator_map_voltage_ascend for them.
>
> Signed-off-by: Axel Lin
> ---
> drivers/regulator/pfuze100-regulator.c | 1 +
> 1 file
On Mon, Jul 29, 2013 at 04:20:03PM +0800, Axel Lin wrote:
> 2013/7/29 Axel Lin :
> > Hi Robin,
> > 2 questions about the code in pfuze100 driver:
> >
> > 1)
> > Both PFUZE100_REVID and PFUZE100_FABID are defined as 0x3.
> > So I'm wondering if it's a typo in one of the register address?
> > If
On Mon, Jul 29, 2013 at 04:20:03PM +0800, Axel Lin wrote:
2013/7/29 Axel Lin axel@ingics.com:
Hi Robin,
2 questions about the code in pfuze100 driver:
1)
Both PFUZE100_REVID and PFUZE100_FABID are defined as 0x3.
So I'm wondering if it's a typo in one of the register address?
If
Yes, it's reasonable from performance view.
On Mon, Jul 29, 2013 at 03:38:58PM +0800, Axel Lin wrote:
All table based voltage list have ascendant order.
Use regulator_map_voltage_ascend for them.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/pfuze100-regulator.c | 1 +
On Mon, Jul 29, 2013 at 11:44:40PM +0800, Axel Lin wrote:
Current code adjust min_uV and uV_step when SW2~SW4 high bit is set.
I'm wondering if n_voltages is correct or not in this case because
the n_voltages is calculated by original equation (max-min/step + 1).
What is the max_uV when
On Tue, Jul 30, 2013 at 10:26:40AM +0800, Axel Lin wrote:
2013/7/30 Robin Gong b38...@freescale.com:
On Mon, Jul 29, 2013 at 11:44:40PM +0800, Axel Lin wrote:
Current code adjust min_uV and uV_step when SW2~SW4 high bit is set.
I'm wondering if n_voltages is correct or not in this case
Ok for me.
On Tue, Jul 30, 2013 at 10:46:28AM +0800, Axel Lin wrote:
Current code adjust min_uV and uV_step but missed adjusting the n_voltages
setting.
When BIT6 is clear:
n_voltages = (1975000 - 40) / 25000 + 1 = 64
When BIT6 is set:
n_voltages = (330 - 80) /
@ -451,4 +451,4 @@ module_i2c_driver(pfuze_driver);
>
> MODULE_AUTHOR("Robin Gong ");
> MODULE_DESCRIPTION("Regulator Driver for Freescale PFUZE100 PMIC");
> -MODULE_ALIAS("pfuze100-regulator");
> +MODULE_ALIAS("i2c:pfuze100-regulator");
> --
&g
Fix building error on x86_64 and i386:
WARNING: modpost: missing MODULE_LICENSE() in
drivers/regulator/pfuze100-regulator.o
Signed-off-by: Robin Gong
---
drivers/regulator/pfuze100-regulator.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/pfuze100
Fix building error on x86_64 and i386:
WARNING: modpost: missing MODULE_LICENSE() in
drivers/regulator/pfuze100-regulator.o
Signed-off-by: Robin Gong b38...@freescale.com
---
drivers/regulator/pfuze100-regulator.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers
);
MODULE_AUTHOR(Robin Gong b38...@freescale.com);
MODULE_DESCRIPTION(Regulator Driver for Freescale PFUZE100 PMIC);
-MODULE_ALIAS(pfuze100-regulator);
+MODULE_ALIAS(i2c:pfuze100-regulator);
--
1.8.1.2
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
fix building warning and correct the binding doc
Signed-off-by: Robin Gong
---
.../devicetree/bindings/regulator/pfuze100.txt |2 ++
drivers/regulator/pfuze100-regulator.c |2 +-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/Documentation/devicetree
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong
Tested-by: Steffen Trumtrar
---
.../devicetree/bindings/regulator/pfuze100.txt | 115 +
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |1 +
drivers/regulator
On Thu, Jul 25, 2013 at 10:16:42AM +0100, Mark Brown wrote:
> On Thu, Jul 25, 2013 at 04:58:10PM +0800, Robin Gong wrote:
>
> > Shawn, I notice there are the same descriptions in the many docs of
> > regulator
> > drivers, can we consider the 'regulators' chil
On Thu, Jul 25, 2013 at 04:40:44PM +0800, Shawn Guo wrote:
> On Thu, Jul 25, 2013 at 11:33:18AM +0800, Robin Gong wrote:
> > @@ -0,0 +1,113 @@
> > +PFUZE100 family of regulators
> > +
> > +Required properties:
> > +- compatible: "fsl,pfuze100"
>
On Thu, Jul 25, 2013 at 04:40:44PM +0800, Shawn Guo wrote:
On Thu, Jul 25, 2013 at 11:33:18AM +0800, Robin Gong wrote:
@@ -0,0 +1,113 @@
+PFUZE100 family of regulators
+
+Required properties:
+- compatible: fsl,pfuze100
+- reg: I2C slave address
+- regulators: This is the list
On Thu, Jul 25, 2013 at 10:16:42AM +0100, Mark Brown wrote:
On Thu, Jul 25, 2013 at 04:58:10PM +0800, Robin Gong wrote:
Shawn, I notice there are the same descriptions in the many docs of
regulator
drivers, can we consider the 'regulators' child node as one of special
property
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong b38...@freescale.com
Tested-by: Steffen Trumtrar s.trumt...@pengutronix.de
---
.../devicetree/bindings/regulator/pfuze100.txt | 115 +
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile
fix building warning and correct the binding doc
Signed-off-by: Robin Gong b38...@freescale.com
---
.../devicetree/bindings/regulator/pfuze100.txt |2 ++
drivers/regulator/pfuze100-regulator.c |2 +-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong
---
.../devicetree/bindings/regulator/pfuze100.txt | 113 +
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |1 +
drivers/regulator/pfuze100-regulator.c
On Wed, Jul 24, 2013 at 10:30:41AM +0200, Steffen Trumtrar wrote:
> Hi!
>
> I tested your patch and had to change two things to actually make it
> work. See below...
>
> On Sun, Jul 21, 2013 at 05:17:27PM +0800, Robin Gong wrote:
> > Add pfuze100 regulator driver.
>
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong b38...@freescale.com
---
.../devicetree/bindings/regulator/pfuze100.txt | 113 +
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |1 +
drivers/regulator/pfuze100
On Wed, Jul 24, 2013 at 10:30:41AM +0200, Steffen Trumtrar wrote:
Hi!
I tested your patch and had to change two things to actually make it
work. See below...
On Sun, Jul 21, 2013 at 05:17:27PM +0800, Robin Gong wrote:
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong b38
On Mon, Jul 22, 2013 at 05:11:00PM +0800, Shawn Guo wrote:
> On Sun, Jul 21, 2013 at 05:17:27PM +0800, Robin Gong wrote:
> > Add pfuze100 regulator driver.
> >
> > Signed-off-by: Robin Gong
> > ---
> > .../devicetree/bindings/regulator/pfuze100.txt |
On Mon, Jul 22, 2013 at 05:11:00PM +0800, Shawn Guo wrote:
On Sun, Jul 21, 2013 at 05:17:27PM +0800, Robin Gong wrote:
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong b38...@freescale.com
---
.../devicetree/bindings/regulator/pfuze100.txt | 113 +
drivers/regulator
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong
---
.../devicetree/bindings/regulator/pfuze100.txt | 113 +
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |1 +
drivers/regulator/pfuze100-regulator.c
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong b38...@freescale.com
---
.../devicetree/bindings/regulator/pfuze100.txt | 113 +
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |1 +
drivers/regulator/pfuze100
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong
---
.../devicetree/bindings/regulator/pfuze100.txt | 113 +
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |1 +
drivers/regulator/pfuze100-regulator.c
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong b38...@freescale.com
---
.../devicetree/bindings/regulator/pfuze100.txt | 113 +
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |1 +
drivers/regulator/pfuze100
Shawn, Thanks for your carefully review and I will correct it and send the
patch again. some comments below:
> > +
> > +struct pfuze_regulator {
> > + struct regulator_desc desc;
> > + unsigned char stby_reg;
> > + unsigned char stby_mask;
> > +};
> > +
> > +enum pfuze_id {
> > +
Shawn, Thanks for your carefully review and I will correct it and send the
patch again. some comments below:
+
+struct pfuze_regulator {
+ struct regulator_desc desc;
+ unsigned char stby_reg;
+ unsigned char stby_mask;
+};
+
+enum pfuze_id {
+ PFUZE_ID_PFUZE100,
+
Mark,
Thanks for your kindly review, please see below comments.
On Fri, Jul 12, 2013 at 03:40:37PM +0100, Mark Brown wrote:
> On Fri, Jul 12, 2013 at 12:54:15PM +0800, Robin Gong wrote:
> > Add pfuze100 regulator driver.
>
> This looks mostly good. A few small issues be
Mark,
Thanks for your kindly review, please see below comments.
On Fri, Jul 12, 2013 at 03:40:37PM +0100, Mark Brown wrote:
On Fri, Jul 12, 2013 at 12:54:15PM +0800, Robin Gong wrote:
Add pfuze100 regulator driver.
This looks mostly good. A few small issues below but nothing major
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong
---
.../devicetree/bindings/regulator/pfuze100.txt | 113 +
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |1 +
drivers/regulator/pfuze100-regulator.c
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong
---
.../devicetree/bindings/regulator/pfuze100.txt | 113 +
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |1 +
drivers/regulator/pfuze100-regulator.c
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong b38...@freescale.com
---
.../devicetree/bindings/regulator/pfuze100.txt | 113 +
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |1 +
drivers/regulator/pfuze100
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong b38...@freescale.com
---
.../devicetree/bindings/regulator/pfuze100.txt | 113 +
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |1 +
drivers/regulator/pfuze100
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong
---
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |2 +
drivers/regulator/pfuze-regulator.h| 110
drivers/regulator/pfuze100-regulator.c | 993
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong b38...@freescale.com
---
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |2 +
drivers/regulator/pfuze-regulator.h| 110
drivers/regulator/pfuze100-regulator.c | 993
801 - 857 of 857 matches
Mail list logo
