Re: [PATCH v1 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line

2021-03-09 Thread Rodolfo Giometti
On 09/03/21 12:28, Andy Shevchenko wrote: > On Tue, Mar 09, 2021 at 11:51:58AM +0100, Rodolfo Giometti wrote: >> On 09/03/21 11:47, Andy Shevchenko wrote: >>> +Cc: Greg >>> >>> On Fri, Feb 26, 2021 at 07:03:32PM +0200, Andy Shevchenko wrote: >>>>

Re: [PATCH resend v1 7/7] pps: clients: gpio: Rearrange optional stuff in pps_gpio_setup()

2021-03-09 Thread Rodolfo Giometti
ev, "assert-falling-edge"); > + /* sanity check on echo_active_ms */ > + if (!value || value > 999) { > + dev_err(dev, "echo-active-ms: %u - bad value from FW\n", value); > + return -EINVAL; > + } > + > + data->echo_

Re: [PATCH resend v1 6/7] pps: clients: gpio: Use struct device pointer directly

2021-03-09 Thread Rodolfo Giometti
data->irq); > return PTR_ERR(data->pps); > } > > /* register IRQ interrupt handler */ > - ret = devm_request_irq(>dev, data->irq, pps_gpio_irq_handler, > + ret = devm_request_irq(dev, data->irq, pps_gpio_irq_handler, > get_irqf_trigger_flags(data), data->info.name, data); > if (ret) { > pps_unregister_source(data->pps); > - dev_err(>dev, "failed to acquire IRQ %d\n", data->irq); > + dev_err(dev, "failed to acquire IRQ %d\n", data->irq); > return -EINVAL; > } > > Acked-by: Rodolfo Giometti -- GNU/Linux Solutions e-mail: giome...@enneenne.com Linux Device Driver giome...@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti

Re: [PATCH resend v1 5/7] pps: clients: gpio: Make use of device properties

2021-03-09 Thread Rodolfo Giometti
, > data->echo_active_ms); > return -EINVAL; > } > } > > - if (of_property_read_bool(np, "assert-falling-edge")) > - data->assert_falling_edge = true; > + data->assert_falling_edge = &

Re: [PATCH resend v1 4/7] pps: clients: gpio: Get rid of legacy platform data

2021-03-09 Thread Rodolfo Giometti
h -- PPS client for GPIOs > - * > - * Copyright (C) 2011 James Nuss > - */ > - > -#ifndef _PPS_GPIO_H > -#define _PPS_GPIO_H > - > -struct pps_gpio_platform_data { > - struct gpio_desc *gpio_pin; > - struct gpio_desc *echo_pin; > - bool assert_falling_edge;

Re: [PATCH resend v1 3/7] pps: clients: gpio: Remove redundant condition in ->remove()

2021-03-09 Thread Rodolfo Giometti
n in any case */ > - gpiod_set_value(data->echo_pin, 0); > - } > + del_timer_sync(>echo_timer); > + /* reset echo pin in any case */ > + gpiod_set_value(data->echo_pin, 0); > dev_info(>dev, "removed IRQ %d as PPS source\n", data->irq); > return

Re: [PATCH resend v1 2/7] pps: clients: gpio: Use dev_err_probe() to avoid log noise

2021-03-09 Thread Rodolfo Giometti
pin)) { > - dev_err(>dev, "failed to request ECHO GPIO\n"); > - return PTR_ERR(data->echo_pin); > - } > + if (IS_ERR(data->echo_pin)) > + return dev_err_probe(>dev, PTR_ERR(data->echo_pin), > +

Re: [PATCH resend v1 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line

2021-03-09 Thread Rodolfo Giometti
return PTR_ERR(data->echo_pin); > + } > > + if (data->echo_pin) { > ret = of_property_read_u32(np, > "echo-active-ms", > ); > Acked-by: Rodolfo Giometti -- GNU/Linux Solutions

Re: [PATCH v1 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line

2021-03-09 Thread Rodolfo Giometti
On 09/03/21 11:47, Andy Shevchenko wrote: > +Cc: Greg > > On Fri, Feb 26, 2021 at 07:03:32PM +0200, Andy Shevchenko wrote: >> On Tue, Feb 16, 2021 at 01:31:48PM +0200, Andy Shevchenko wrote: >>> When requesting optional GPIO echo line, bail out on error, >>> so user will know that something wrong

Re: [PATCH v2 3/4] pps: Use subdir-ccflags-* to inherit debug flag

2021-02-09 Thread Rodolfo Giometti
PS)+= kc.o > obj-$(CONFIG_PPS):= pps_core.o > obj-y+= clients/ generators/ > > -ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG > +subdir-ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG > Acked-by: Rodolfo Giometti -- GNU/Linux Solutions e-mai

Re: [PATCH 1/2] misc: c2port: core: Make copying name from userspace more secure

2020-11-03 Thread Rodolfo Giometti
On 03/11/2020 09:57, Lee Jones wrote: > On Mon, 02 Nov 2020, Rodolfo Giometti wrote: > >> On 02/11/2020 14:47, Lee Jones wrote: >>> On Mon, 02 Nov 2020, gre...@linuxfoundation.org wrote: >>> >>>> On Mon, Nov 02, 2020 at 12:43:01PM +, Lee J

Re: [PATCH 1/2] misc: c2port: core: Make copying name from userspace more secure

2020-11-02 Thread Rodolfo Giometti
a NUL terminator, which means that a 1-byte >>>>>>> leak would be possible *if* this was ever copied to userspace. Ensure >>>>>>> the buffer will always be NUL terminated by using the kernel's >>>>>>> strscpy() which a) uses

Re: [PATCH 01/10] misc: c2port: core: Ensure source size does not equal destination size in strncpy()

2020-06-26 Thread Rodolfo Giometti
ing_strncpy’ > 307 | return __underlying_strncpy(p, q, size); > | ^~~~ > > Cc: Rodolfo Giometti > Cc: "Eurotech S.p.A" > Signed-off-by: Lee Jones > --- > drivers/misc/c2port/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: [PATCH v15 3/3] pps: pps-gpio pps-echo implementation

2019-02-04 Thread Rodolfo Giometti
for inclusion into the linux kernel by Tom Burkart. Signed-off-by: Lukas Senger Signed-off-by: Tom Burkart Acked-by: Rodolfo Giometti -- GNU/Linux Solutions e-mail: giome...@enneenne.com Linux Device Driver giome...@linux.it Embedded Systems

Re: [PATCH v15 1/3] pps: descriptor-based gpio

2019-02-04 Thread Rodolfo Giometti
On 02/02/2019 11:57, Tom Burkart wrote: This patch changes the GPIO access for the pps-gpio driver from the integer based API to the descriptor based API. Reviewed-by: Philipp Zabel Signed-off-by: Tom Burkart Acked-by: Rodolfo Giometti -- GNU/Linux Solutions e-mail: giome

Re: UBSAN: Undefined behaviour in drivers/pps/pps.c

2019-01-09 Thread Rodolfo Giometti
On 08/01/2019 21:24, Kyungtae Kim wrote: We report a bug in linux-4.20: "UBSAN: Undefined behaviour in drivers/pps/pps.c" kernel config: https://kt0755.github.io/etc/config_v4.20_stable repro: https://kt0755.github.io/etc/repro.a6372.c pps_cdev_pps_fetch() lacks the bounds checking for

Re: [PATCH v14 3/3] pps: pps-gpio pps-echo implementation

2019-01-04 Thread Rodolfo Giometti
On 30/12/2018 09:33, Tom Burkart wrote: This patch implements the pps echo functionality for pps-gpio, that sysfs claims is available already. Configuration is done via device tree bindings. This patch was originally written by Lukas Senger as part of a masters thesis project and modified for

Re: [PATCH v14 2/3] dt-bindings: pps: pps-gpio PPS ECHO implementation

2019-01-04 Thread Rodolfo Giometti
On 30/12/2018 09:33, Tom Burkart wrote: This patch implements the device tree binding changes required for the pps echo functionality for pps-gpio, that sysfs claims is available already. This patch was originally written by Lukas Senger as part of a masters thesis project and modified for

Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails

2018-11-27 Thread Rodolfo Giometti
On 27/11/2018 08:34, Greg KH wrote: On Mon, Nov 26, 2018 at 11:43:06AM +0100, Rodolfo Giometti wrote: On 26/11/2018 11:24, YueHaibing wrote: pps_register_source() has keeps error codes in a local variable, but it does not make use of the code. This patch let it return the errcode in case

Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails

2018-11-27 Thread Rodolfo Giometti
On 27/11/2018 08:34, Greg KH wrote: On Mon, Nov 26, 2018 at 11:43:06AM +0100, Rodolfo Giometti wrote: On 26/11/2018 11:24, YueHaibing wrote: pps_register_source() has keeps error codes in a local variable, but it does not make use of the code. This patch let it return the errcode in case

Re: [PATCH 2/2] pps-gpio: Set echo GPIO pin via devicetree

2018-02-15 Thread Rodolfo Giometti
On 15/02/18 16:08, Lukas Senger wrote: @@ -20,18 +21,20 @@ target = <>; __overlay__ { pps_pins: pps_pins@12 { - brcm,pins = <18>; - brcm,function = <0>;// in -

Re: [PATCH 2/2] pps-gpio: Set echo GPIO pin via devicetree

2018-02-15 Thread Rodolfo Giometti
On 15/02/18 16:08, Lukas Senger wrote: @@ -20,18 +21,20 @@ target = <>; __overlay__ { pps_pins: pps_pins@12 { - brcm,pins = <18>; - brcm,function = <0>;// in -

Re: [PATCH 1/2] pps-gpio: Avoid flooding syslog

2018-02-15 Thread Rodolfo Giometti
On 15/02/18 16:12, Lukas Senger wrote: Why a void function? You should use it to toggle echoing GPIO... =8-o RFC 2783 says to generate the echo pulse "as rapidly as possible" which is why I do the toggling in the irq handler. However this leaves the default echo function installed which just

Re: [PATCH 1/2] pps-gpio: Avoid flooding syslog

2018-02-15 Thread Rodolfo Giometti
On 15/02/18 16:12, Lukas Senger wrote: Why a void function? You should use it to toggle echoing GPIO... =8-o RFC 2783 says to generate the echo pulse "as rapidly as possible" which is why I do the toggling in the irq handler. However this leaves the default echo function installed which just

Re: [PATCH 2/2] pps-gpio: Set echo GPIO pin via devicetree

2018-02-15 Thread Rodolfo Giometti
On 15/02/18 13:59, Lukas Senger wrote: --- arch/arm/boot/dts/overlays/pps-gpio-overlay.dts | 13 - drivers/pps/clients/pps-gpio.c | 26 ++--- include/linux/pps-gpio.h| 1 + 3 files changed, 24 insertions(+), 16

Re: [PATCH 2/2] pps-gpio: Set echo GPIO pin via devicetree

2018-02-15 Thread Rodolfo Giometti
On 15/02/18 13:59, Lukas Senger wrote: --- arch/arm/boot/dts/overlays/pps-gpio-overlay.dts | 13 - drivers/pps/clients/pps-gpio.c | 26 ++--- include/linux/pps-gpio.h| 1 + 3 files changed, 24 insertions(+), 16

Re: [PATCH 1/2] pps-gpio: Avoid flooding syslog

2018-02-15 Thread Rodolfo Giometti
On 15/02/18 13:59, Lukas Senger wrote: ^^^ Missing description and signatures... --- drivers/pps/clients/pps-gpio.c | 1 + include/linux/pps-gpio.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c

Re: [PATCH 1/2] pps-gpio: Avoid flooding syslog

2018-02-15 Thread Rodolfo Giometti
On 15/02/18 13:59, Lukas Senger wrote: ^^^ Missing description and signatures... --- drivers/pps/clients/pps-gpio.c | 1 + include/linux/pps-gpio.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c

Re: [PATCH] pps-gpio: implement echo pulses

2018-02-07 Thread Rodolfo Giometti
On 06/02/18 16:58, Lukas Senger wrote: pps-gpio reports as having echo capability via sysfs, which is not actually the case. This patch implements it. The output pin is hardcoded as 17. This should probably be configurable via the dtoverlay in the same way as the input pin. No hardcoded stuff

Re: [PATCH] pps-gpio: implement echo pulses

2018-02-07 Thread Rodolfo Giometti
On 06/02/18 16:58, Lukas Senger wrote: pps-gpio reports as having echo capability via sysfs, which is not actually the case. This patch implements it. The output pin is hardcoded as 17. This should probably be configurable via the dtoverlay in the same way as the input pin. No hardcoded stuff

Re: [PATCH 2/2] pps: generator: use new parport device model

2018-01-29 Thread Rodolfo Giometti
On 29/01/18 00:22, Sudip Mukherjee wrote: Modify pps generator driver to use the new parallel port device model. Signed-off-by: Sudip Mukherjee <sudipm.mukher...@gmail.com> Acked-by: Rodolfo Giometti <giome...@enneenne.com> -- HCE Engineering e-mail:

Re: [PATCH 2/2] pps: generator: use new parport device model

2018-01-29 Thread Rodolfo Giometti
On 29/01/18 00:22, Sudip Mukherjee wrote: Modify pps generator driver to use the new parallel port device model. Signed-off-by: Sudip Mukherjee Acked-by: Rodolfo Giometti -- HCE Engineering e-mail: giome...@hce-engineering.it GNU/Linux Solutions

Re: [PATCH 1/2] pps: client: use new parport device model

2018-01-29 Thread Rodolfo Giometti
On 29/01/18 00:22, Sudip Mukherjee wrote: Modify pps client driver to use the new parallel port device model. In that process, added an index to mention the device number when we have more than one parallel port. Signed-off-by: Sudip Mukherjee <sudipm.mukher...@gmail.com> Acked-by: R

Re: [PATCH 1/2] pps: client: use new parport device model

2018-01-29 Thread Rodolfo Giometti
On 29/01/18 00:22, Sudip Mukherjee wrote: Modify pps client driver to use the new parallel port device model. In that process, added an index to mention the device number when we have more than one parallel port. Signed-off-by: Sudip Mukherjee Acked-by: Rodolfo Giometti -- HCE Engineering

Re: [PATCH] pps: parport: use timespec64 instead of timespec

2017-11-28 Thread Rodolfo Giometti
cycle, which seems worse. Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Rodolfo Giometti <giome...@enneenne.com> -- HCE Engineering e-mail: giome...@hce-engineering.it GNU/Linux Solutions giome...@enneenne.com Linux D

Re: [PATCH] pps: parport: use timespec64 instead of timespec

2017-11-28 Thread Rodolfo Giometti
cycle, which seems worse. Signed-off-by: Arnd Bergmann Acked-by: Rodolfo Giometti -- HCE Engineering e-mail: giome...@hce-engineering.it GNU/Linux Solutions giome...@enneenne.com Linux Device Driver giome...@linux.it

Re: [PATCH] pps-gpio: use IRQ edge config when not capturing both edges

2017-09-12 Thread Rodolfo Giometti
On 12/09/2017 17:54, Tim Harvey wrote: On Sun, Sep 10, 2017 at 3:43 AM, Rodolfo Giometti <giome...@enneenne.com> wrote: On 08/09/2017 21:53, Tim Harvey wrote: PPS signals with very short pulse-widths can be missed if their state changes by the time the interrupt handler reads the GP

Re: [PATCH] pps-gpio: use IRQ edge config when not capturing both edges

2017-09-12 Thread Rodolfo Giometti
On 12/09/2017 17:54, Tim Harvey wrote: On Sun, Sep 10, 2017 at 3:43 AM, Rodolfo Giometti wrote: On 08/09/2017 21:53, Tim Harvey wrote: PPS signals with very short pulse-widths can be missed if their state changes by the time the interrupt handler reads the GPIO pin state. To avoid

Re: [PATCH] MAINTAINERS: update linuxpps mailing list

2017-09-10 Thread Rodolfo Giometti
7 @@ F: drivers/net/ppp/ppp_* PPS SUPPORT M:Rodolfo Giometti <giome...@enneenne.com> W:http://wiki.enneenne.com/index.php/LinuxPPS_support -L: linux...@ml.enneenne.com (subscribers-only) +L: discussi...@linuxpps.org S:Maintained F:Documentation/pps/ F:

Re: [PATCH] MAINTAINERS: update linuxpps mailing list

2017-09-10 Thread Rodolfo Giometti
/ppp_* PPS SUPPORT M:Rodolfo Giometti W:http://wiki.enneenne.com/index.php/LinuxPPS_support -L: linux...@ml.enneenne.com (subscribers-only) +L: discussi...@linuxpps.org S:Maintained F:Documentation/pps/ F:drivers/pps/ The list is discussi...@linuxpps.org

Re: [PATCH] pps-gpio: use IRQ edge config when not capturing both edges

2017-09-10 Thread Rodolfo Giometti
On 08/09/2017 21:53, Tim Harvey wrote: PPS signals with very short pulse-widths can be missed if their state changes by the time the interrupt handler reads the GPIO pin state. To avoid this in the case where we are only looking for one edge we can use the edge configuration for the pin state

Re: [PATCH] pps-gpio: use IRQ edge config when not capturing both edges

2017-09-10 Thread Rodolfo Giometti
On 08/09/2017 21:53, Tim Harvey wrote: PPS signals with very short pulse-widths can be missed if their state changes by the time the interrupt handler reads the GPIO pin state. To avoid this in the case where we are only looking for one edge we can use the edge configuration for the pin state

Re: Support for BQ28Z610 Battery Monitor IC

2017-09-05 Thread Rodolfo Giometti
On 04/09/2017 15:53, rajender.re...@stesalit.in wrote: Dear Rodolfo Giometti, As discussed please find attached patch. Please let me know if you need more details. It looks OK to me... however: - rewrite the patch's title as "power bq27xxx_battery: add support for BQ28Z610 battery mo

Re: Support for BQ28Z610 Battery Monitor IC

2017-09-05 Thread Rodolfo Giometti
On 04/09/2017 15:53, rajender.re...@stesalit.in wrote: Dear Rodolfo Giometti, As discussed please find attached patch. Please let me know if you need more details. It looks OK to me... however: - rewrite the patch's title as "power bq27xxx_battery: add support for BQ28Z610 battery mo

Re: [PATCH] PPS: Use surrounding "if PPS" to remove numerous dependency checks

2017-08-28 Thread Rodolfo Giometti
On 26/08/2017 16:55, Robert P. J. Day wrote: Adding high-level "if PPS" makes lower-level dependency tests superfluous. Signed-off-by: Robert P. J. Day <rpj...@crashcourse.ca> Acked-by: Rodolfo Giometti <giome...@enneenne.com> -- HCE Engineering

Re: [PATCH] PPS: Use surrounding "if PPS" to remove numerous dependency checks

2017-08-28 Thread Rodolfo Giometti
On 26/08/2017 16:55, Robert P. J. Day wrote: Adding high-level "if PPS" makes lower-level dependency tests superfluous. Signed-off-by: Robert P. J. Day Acked-by: Rodolfo Giometti -- HCE Engineering e-mail: giome...@hce-engineering.it GNU/Linux

Re: [PATCH v2] PPS: Aesthetic tweaks to PPS-related content

2017-08-28 Thread Rodolfo Giometti
| 2 +- include/linux/pps_kernel.h | 16 +++- include/uapi/linux/pps.h | 4 ++-- kernel/time/timekeeping.c | 2 +- 7 files changed, 43 insertions(+), 36 deletions(-)

Re: [PATCH v2] PPS: Aesthetic tweaks to PPS-related content

2017-08-28 Thread Rodolfo Giometti
| 2 +- include/linux/pps_kernel.h | 16 +++- include/uapi/linux/pps.h | 4 ++-- kernel/time/timekeeping.c | 2 +- 7 files changed, 43 insertions(+), 36 deleti

Re: [PATCH] Make PPS into a menuconfig to ease disabling

2017-05-09 Thread Rodolfo Giometti
On 04/11/17 16:26, Vincent Legoll wrote: So that there's no need to get into the submenu to disable all related config entries. The BROKEN PPS_GENERATOR_PARPORT now also depends on PPS Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> Acked-by: Rodolfo Giometti <giome...@enn

Re: [PATCH] Make PPS into a menuconfig to ease disabling

2017-05-09 Thread Rodolfo Giometti
On 04/11/17 16:26, Vincent Legoll wrote: So that there's no need to get into the submenu to disable all related config entries. The BROKEN PPS_GENERATOR_PARPORT now also depends on PPS Signed-off-by: Vincent Legoll Acked-by: Rodolfo Giometti -- HCE Engineering e-mail

Re: [PATCH] c2port: checking for NULL instead of IS_ERR()

2017-04-12 Thread Rodolfo Giometti
On 04/12/17 10:33, Dan Carpenter wrote: c2port_device_register() never returns NULL, it uses error pointers. Fixes: 65131cd52b9e ("c2port: add c2port support for Eurotech Duramar 2150") Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Acked-by: Rodolfo Giometti &l

Re: [PATCH] c2port: checking for NULL instead of IS_ERR()

2017-04-12 Thread Rodolfo Giometti
On 04/12/17 10:33, Dan Carpenter wrote: c2port_device_register() never returns NULL, it uses error pointers. Fixes: 65131cd52b9e ("c2port: add c2port support for Eurotech Duramar 2150") Signed-off-by: Dan Carpenter Acked-by: Rodolfo Giometti diff --git a/drivers/misc/c2p

Re: [PATCH 8/8] LinuxPPS: pps_gen_parport: Add check for bad clocksource.

2017-03-04 Thread Rodolfo Giometti
On 03/04/17 10:19, Alexander Gerasiov wrote: Hello Rodolfo, I should say, that I found this solution is not the best. For example on high speed PCs (I think over 3GHz) 5 iteration is not enough and module stops working after several hours. That makes it not user-friendly, cause user had to

Re: [PATCH 8/8] LinuxPPS: pps_gen_parport: Add check for bad clocksource.

2017-03-04 Thread Rodolfo Giometti
On 03/04/17 10:19, Alexander Gerasiov wrote: Hello Rodolfo, I should say, that I found this solution is not the best. For example on high speed PCs (I think over 3GHz) 5 iteration is not enough and module stops working after several hours. That makes it not user-friendly, cause user had to

Re: [PATCH 2/2] pps: fix padding issue with PPS_FETCH for ioctl_compat

2017-03-04 Thread Rodolfo Giometti
On 02/24/17 21:23, Matt Ranostay wrote: Issue is that x86 32-bit aligns to 4-bytes instead of 8-bytes so this patchset works around the issue and corrects the data returned in pps_fdata_compat. Cc: Rodolfo Giometti <giome...@enneenne.com> Cc: Moritz Fischer <m...@kernel.org>

Re: [PATCH 2/2] pps: fix padding issue with PPS_FETCH for ioctl_compat

2017-03-04 Thread Rodolfo Giometti
On 02/24/17 21:23, Matt Ranostay wrote: Issue is that x86 32-bit aligns to 4-bytes instead of 8-bytes so this patchset works around the issue and corrects the data returned in pps_fdata_compat. Cc: Rodolfo Giometti Cc: Moritz Fischer Cc: George McCollister Signed-off-by: Matt Ranostay

Re: [PATCH 8/8] LinuxPPS: pps_gen_parport: Add check for bad clocksource.

2017-03-04 Thread Rodolfo Giometti
arport. For explanation of the problem see this thread on lkml: https://lkml.org/lkml/2011/2/18/310 Signed-off-by: Nikita Edward Baruzdin <nebaruz...@lvk.cs.msu.su> Signed-off-by: Alexander GQ Gerasiov <g...@cs.msu.su> Acked-by: Rodolfo Giometti <giome...@enneenne.com>

Re: [PATCH 8/8] LinuxPPS: pps_gen_parport: Add check for bad clocksource.

2017-03-04 Thread Rodolfo Giometti
see this thread on lkml: https://lkml.org/lkml/2011/2/18/310 Signed-off-by: Nikita Edward Baruzdin Signed-off-by: Alexander GQ Gerasiov Acked-by: Rodolfo Giometti

Re: [PATCH 2/8] ntp/pps: ignore pps_valid decreasing if there is no pps signal.

2017-03-04 Thread Rodolfo Giometti
On 02/15/17 15:31, Andrey Drobyshev wrote: From: Alexander GQ Gerasiov <g...@cs.msu.su> In case pps_dec_valid() is called from second_overflow() in the absence of pps signal, there is no need to decrease pps_valid. Signed-off-by: Alexander GQ Gerasiov <g...@cs.msu.su> Acked

Re: [PATCH 2/8] ntp/pps: ignore pps_valid decreasing if there is no pps signal.

2017-03-04 Thread Rodolfo Giometti
On 02/15/17 15:31, Andrey Drobyshev wrote: From: Alexander GQ Gerasiov In case pps_dec_valid() is called from second_overflow() in the absence of pps signal, there is no need to decrease pps_valid. Signed-off-by: Alexander GQ Gerasiov Acked-by: Rodolfo Giometti

Re: [PATCH 7/8] LinuxPPS: pps_gen_parport: Add polarity parameter for inverted signal.

2017-03-03 Thread Rodolfo Giometti
the high level (1)."); +module_param(polarity, uint, 0); #define SAFETY_INTERVAL3000/* set the hrtimer earlier for safety (ns) */ Acked-by: Rodolfo Giometti <giome...@enneenne.com>

Re: [PATCH 7/8] LinuxPPS: pps_gen_parport: Add polarity parameter for inverted signal.

2017-03-03 Thread Rodolfo Giometti
(polarity, uint, 0); #define SAFETY_INTERVAL3000/* set the hrtimer earlier for safety (ns) */ Acked-by: Rodolfo Giometti

Re: [PATCH 6/8] LinuxPPS: pps_parport: Ignore interrupt invoked less than 0.5sec after previous.

2017-03-03 Thread Rodolfo Giometti
> Acked-by: Rodolfo Giometti <giome...@enneenne.com>

Re: [PATCH 1/2] pps: add ioctl_compat function to correct ioctl definitions

2017-03-03 Thread Rodolfo Giometti
size. Cc: Rodolfo Giometti <giome...@enneenne.com> Cc: Moritz Fischer <m...@kernel.org> Cc: George McCollister <george.mccollis...@gmail.com> Signed-off-by: Matt Ranostay <matt.ranos...@konsulko.com> --- drivers/pps/pps.c | 13 + 1 file changed, 13 insertion

Re: [PATCH 6/8] LinuxPPS: pps_parport: Ignore interrupt invoked less than 0.5sec after previous.

2017-03-03 Thread Rodolfo Giometti
On 02/15/17 15:31, Andrey Drobyshev wrote: From: Alexander GQ Gerasiov On some devices interrupt may be invoked by parasitic assert event produced while switching from high to low. Such interrupt should be ignored. Signed-off-by: Alexander GQ Gerasiov Acked-by: Rodolfo Giometti

Re: [PATCH 1/2] pps: add ioctl_compat function to correct ioctl definitions

2017-03-03 Thread Rodolfo Giometti
size. Cc: Rodolfo Giometti Cc: Moritz Fischer Cc: George McCollister Signed-off-by: Matt Ranostay --- drivers/pps/pps.c | 13 + 1 file changed, 13 insertions(+) Acked-by: Rodolfo Giometti -- HCE Engineering e-mail: giome...@hce-engineering.com GNU/Linux

Re: [PATCH 5/8] LinuxPPS: pps_parport: Do not generate assert in case of lost signal.

2017-03-03 Thread Rodolfo Giometti
> Acked-by: Rodolfo Giometti <giome...@enneenne.com>

Re: [PATCH 5/8] LinuxPPS: pps_parport: Do not generate assert in case of lost signal.

2017-03-03 Thread Rodolfo Giometti
On 02/15/17 15:31, Andrey Drobyshev wrote: From: Alexander GQ Gerasiov Since clear timeout is non-zero, some clear event capture is requested. Therefore, if signal is lost we shouldn't generate assert event alone. Signed-off-by: Alexander GQ Gerasiov Acked-by: Rodolfo Giometti

Re: [PATCH 4/8] LinuxPPS: kapi: Unlock before waking up events queue in pps_event().

2017-03-03 Thread Rodolfo Giometti
On 02/15/17 15:31, Andrey Drobyshev wrote: From: Alexander GQ Gerasiov <g...@redlab-i.ru> Otherwise we get "scheduling while atomic" problem. Signed-off-by: Alexander GQ Gerasiov <g...@redlab-i.ru> Acked-by: Rodolfo Giometti <giome...@enneenne.com>

Re: [PATCH 4/8] LinuxPPS: kapi: Unlock before waking up events queue in pps_event().

2017-03-03 Thread Rodolfo Giometti
On 02/15/17 15:31, Andrey Drobyshev wrote: From: Alexander GQ Gerasiov Otherwise we get "scheduling while atomic" problem. Signed-off-by: Alexander GQ Gerasiov Acked-by: Rodolfo Giometti

Re: [PATCH 3/8] hardpps: fix some pps_jitter issues.

2017-03-03 Thread Rodolfo Giometti
On 02/15/17 15:31, Andrey Drobyshev wrote: Handle possible overflow, implementation-defined result of signed right shift and replace unsuitable constant. Signed-off-by: Andrey Drobyshev <immortalguardi...@gmail.com> Signed-off-by: Alexander GQ Gerasiov <g...@cs.msu.su> Acked

Re: [PATCH 3/8] hardpps: fix some pps_jitter issues.

2017-03-03 Thread Rodolfo Giometti
On 02/15/17 15:31, Andrey Drobyshev wrote: Handle possible overflow, implementation-defined result of signed right shift and replace unsuitable constant. Signed-off-by: Andrey Drobyshev Signed-off-by: Alexander GQ Gerasiov Acked-by: Rodolfo Giometti

Re: [PATCH 1/8] hardpps: simple fixes replacing clumsy code with abs() macro.

2017-03-03 Thread Rodolfo Giometti
iov <g...@cs.msu.su> Acked-by: Rodolfo Giometti <giome...@enneenne.com>

Re: [PATCH 1/8] hardpps: simple fixes replacing clumsy code with abs() macro.

2017-03-03 Thread Rodolfo Giometti
On 02/15/17 15:31, Andrey Drobyshev wrote: From: Alexander GQ Gerasiov Here are some trivial fixes, including: * simplify comparisons by using abs() macro * remove unnecessary variables * remove duplicate headers * fix typos Signed-off-by: Alexander GQ Gerasiov Acked-by: Rodolfo

Re: [RFC] pps: fixing CONFIG_COMPAT issues

2016-12-23 Thread Rodolfo Giometti
On 12/22/16 21:39, Matt Ranostay wrote: What would be the best way to fix the padding issue without breaking userspace applications? Just fixing the alignment with explicit padding is of course the clean easy way, but bashing the data in compat_ioctl would avoid breakage. Hi Matt, I've no

Re: [RFC] pps: fixing CONFIG_COMPAT issues

2016-12-23 Thread Rodolfo Giometti
On 12/22/16 21:39, Matt Ranostay wrote: What would be the best way to fix the padding issue without breaking userspace applications? Just fixing the alignment with explicit padding is of course the clean easy way, but bashing the data in compat_ioctl would avoid breakage. Hi Matt, I've no

Re: [PATCH][RESEND] pps: kc: fix non-tickless system config dependency

2016-09-21 Thread Rodolfo Giometti
please? Acked-by: Rodolfo Giometti <giome...@enneenne.com> -- HCE Engineering e-mail: giome...@hce-engineering.com GNU/Linux Solutions giome...@enneenne.com Linux Device Driver giome...@linux.it Embe

Re: [PATCH][RESEND] pps: kc: fix non-tickless system config dependency

2016-09-21 Thread Rodolfo Giometti
system which has CONFIG_NO_HZ not set and CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set. Signed-off-by: Maciej S. Szmigiero --- This is a resend without functional changes since previous submission and resubmission weren't picked up. @Rodolfo: Could you ack this, please? Acked-by: Rodolfo Giometti

Re: [PATCH -resend] pps: do not crash when failed to register

2016-07-14 Thread Rodolfo Giometti
r NULL in the test there too. Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Rodolfo Giometti <giome...@enneenne.com> --- drivers/pps/clients/pps_parport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pps/clients/pps_parport.c b/drivers/pps/clients/p

Re: [PATCH -resend] pps: do not crash when failed to register

2016-07-14 Thread Rodolfo Giometti
r NULL in the test there too. Signed-off-by: Jiri Slaby Cc: Rodolfo Giometti --- drivers/pps/clients/pps_parport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pps/clients/pps_parport.c b/drivers/pps/clients/pps_parport.c index 38a8bbe74810..83797d89c30f 100644 --- a/d

Re: [PATCH] pps: kc: fix non-tickless system config dependency

2016-03-21 Thread Rodolfo Giometti
On Mon, Mar 21, 2016 at 03:28:26PM +0100, Maciej S. Szmigiero wrote: > Hi Rodolfo, > > On 06.03.2016 20:13, Rodolfo Giometti wrote: > > On Sat, Mar 05, 2016 at 06:37:39PM +0100, Maciej S. Szmigiero wrote: > >> CONFIG_NO_HZ currently only sets the default value > >

Re: [PATCH] pps: kc: fix non-tickless system config dependency

2016-03-21 Thread Rodolfo Giometti
On Mon, Mar 21, 2016 at 03:28:26PM +0100, Maciej S. Szmigiero wrote: > Hi Rodolfo, > > On 06.03.2016 20:13, Rodolfo Giometti wrote: > > On Sat, Mar 05, 2016 at 06:37:39PM +0100, Maciej S. Szmigiero wrote: > >> CONFIG_NO_HZ currently only sets the default value > >

Re: [PATCH] pps: kc: fix non-tickless system config dependency

2016-03-06 Thread Rodolfo Giometti
On Sat, Mar 05, 2016 at 06:37:39PM +0100, Maciej S. Szmigiero wrote: > CONFIG_NO_HZ currently only sets the default value > of dynticks config so if PPS kernel consumer needs > periodic timer ticks it should depend on > !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ. > > Otherwise it is possible

Re: [PATCH] pps: kc: fix non-tickless system config dependency

2016-03-06 Thread Rodolfo Giometti
On Sat, Mar 05, 2016 at 06:37:39PM +0100, Maciej S. Szmigiero wrote: > CONFIG_NO_HZ currently only sets the default value > of dynticks config so if PPS kernel consumer needs > periodic timer ticks it should depend on > !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ. > > Otherwise it is possible

Re: [PATCH] Doc: pps: Fix file name in pps.txt

2015-07-13 Thread Rodolfo Giometti
On Mon, Jul 13, 2015 at 07:21:50AM -0600, Jonathan Corbet wrote: > On Mon, 13 Jul 2015 08:23:15 +0200 > Rodolfo Giometti wrote: > > > On Mon, Jul 13, 2015 at 12:29:11PM +0900, Masanari Iida wrote: > > > This patch fix a file name of example code. > > > &

Re: [PATCH] Doc: pps: Fix file name in pps.txt

2015-07-13 Thread Rodolfo Giometti
On Mon, Jul 13, 2015 at 12:29:11PM +0900, Masanari Iida wrote: > This patch fix a file name of example code. > > Signed-off-by: Masanari Iida Signed-off-by: Rodolfo Giometti -- HCE Engineering e-mail: giome...@hce-engineering.com GNU/Linux

Re: [PATCH] Doc: pps: Fix file name in pps.txt

2015-07-13 Thread Rodolfo Giometti
On Mon, Jul 13, 2015 at 07:21:50AM -0600, Jonathan Corbet wrote: On Mon, 13 Jul 2015 08:23:15 +0200 Rodolfo Giometti giome...@enneenne.com wrote: On Mon, Jul 13, 2015 at 12:29:11PM +0900, Masanari Iida wrote: This patch fix a file name of example code. Signed-off-by: Masanari Iida

Re: [PATCH] Doc: pps: Fix file name in pps.txt

2015-07-13 Thread Rodolfo Giometti
On Mon, Jul 13, 2015 at 12:29:11PM +0900, Masanari Iida wrote: This patch fix a file name of example code. Signed-off-by: Masanari Iida standby2...@gmail.com Signed-off-by: Rodolfo Giometti giome...@enneenne.com -- HCE Engineering e-mail: giome...@hce-engineering.com

Re: [PATCH] Doc:pps: Fix typo in pps.txt

2015-06-10 Thread Rodolfo Giometti
On Wed, Jun 10, 2015 at 12:53:47PM +0900, Masanari Iida wrote: > This patch fix a spelling typo in Documentation/pps/pps.txt > > Signed-off-by: Masanari Iida Acked-by: Rodolfo Giometti -- HCE Engineering e-mail: giome...@hce-engineering.com GNU/Linux

Re: [PATCH] Doc:pps: Fix typo in pps.txt

2015-06-10 Thread Rodolfo Giometti
On Wed, Jun 10, 2015 at 12:53:47PM +0900, Masanari Iida wrote: This patch fix a spelling typo in Documentation/pps/pps.txt Signed-off-by: Masanari Iida standby2...@gmail.com Acked-by: Rodolfo Giometti giome...@enneenne.com -- HCE Engineering e-mail: giome...@hce

Re: [PATCH] pps: Add support for read operations and return a useful value in poll

2015-04-01 Thread Rodolfo Giometti
On Tue, Mar 31, 2015 at 11:31:22PM +0200, Christian Riesch wrote: > The PPS_FETCH ioctl in drivers/pps/pps.c blocks until a new PPS event > occurs, then returns the time stamp data. While this is fine for > lots of applications, sometimes it would be nice if the poll system > call and a subsequent

Re: [PATCH] pps: Add support for read operations and return a useful value in poll

2015-04-01 Thread Rodolfo Giometti
On Tue, Mar 31, 2015 at 11:31:22PM +0200, Christian Riesch wrote: The PPS_FETCH ioctl in drivers/pps/pps.c blocks until a new PPS event occurs, then returns the time stamp data. While this is fine for lots of applications, sometimes it would be nice if the poll system call and a subsequent

Re: [PATCH v2 15/15] ARM: at91/dt: at91-cosino_mega2560 remove useless tsadcc node

2014-03-17 Thread Rodolfo Giometti
On Mon, Mar 17, 2014 at 02:57:08PM +0100, Alexandre Belloni wrote: > The tsadcc node is useless as it doesn't refer to anything and the touchscreen > is handled by the adc0 node. > > Signed-off-by: Alexandre Belloni > Cc: Rodolfo Giometti Acked. Rodolfo -- GNU/

Re: [PATCH v2 15/15] ARM: at91/dt: at91-cosino_mega2560 remove useless tsadcc node

2014-03-17 Thread Rodolfo Giometti
On Mon, Mar 17, 2014 at 02:57:08PM +0100, Alexandre Belloni wrote: The tsadcc node is useless as it doesn't refer to anything and the touchscreen is handled by the adc0 node. Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com Cc: Rodolfo Giometti giome...@linux.it Acked

Re: [PATCH] pps : add non blocking option to PPS_FETCH ioctl.

2013-10-16 Thread Rodolfo Giometti
On Wed, Oct 16, 2013 at 08:52:47AM +0200, Paul Chavent wrote: > > I would also prefer the separate ioctl. As you said it, it's a bit > annoying to switch from blocking mode to non blocking mode if we > need both mode. But i was not sure about the preferences of the > maintainer : (i) change the

Re: [PATCH] pps : add non blocking option to PPS_FETCH ioctl.

2013-10-16 Thread Rodolfo Giometti
On Wed, Oct 16, 2013 at 08:52:47AM +0200, Paul Chavent wrote: I would also prefer the separate ioctl. As you said it, it's a bit annoying to switch from blocking mode to non blocking mode if we need both mode. But i was not sure about the preferences of the maintainer : (i) change the api,

Re: [PATCH] pps : add non blocking option to PPS_FETCH ioctl.

2013-10-15 Thread Rodolfo Giometti
On Fri, Oct 11, 2013 at 12:47:20PM -0700, Andrew Morton wrote: > On Fri, 11 Oct 2013 14:40:32 +0200 Paul Chavent wrote: > > > The PPS_FETCH ioctl is blocking still the reception of a PPS > > event. But, in some case, one may immediately need the last event > > date. This patch allow to get the

Re: [PATCH] pps : add non blocking option to PPS_FETCH ioctl.

2013-10-15 Thread Rodolfo Giometti
On Fri, Oct 11, 2013 at 12:47:20PM -0700, Andrew Morton wrote: On Fri, 11 Oct 2013 14:40:32 +0200 Paul Chavent paul.chav...@onera.fr wrote: The PPS_FETCH ioctl is blocking still the reception of a PPS event. But, in some case, one may immediately need the last event date. This patch allow

Re: [PATCH] pps : add non blocking option to PPS_FETCH ioctl.

2013-10-11 Thread Rodolfo Giometti
On Fri, Oct 11, 2013 at 10:42:56AM +0200, Paul Chavent wrote: > Hi. > > I haven't had any feedback for weeks. I join a patch with more > details in the commit message if needed. If I well remember I already acked this patch. So please add my Acked-by line to the patch. > Do you know someone

Re: [PATCH] pps : add non blocking option to PPS_FETCH ioctl.

2013-10-11 Thread Rodolfo Giometti
On Fri, Oct 11, 2013 at 10:42:56AM +0200, Paul Chavent wrote: Hi. I haven't had any feedback for weeks. I join a patch with more details in the commit message if needed. If I well remember I already acked this patch. So please add my Acked-by line to the patch. Do you know someone

  1   2   3   4   5   >