Re: [PATCH v2] net/mlx5: Fix use-after-free

resses-Coverity-ID: 1466041 ("Read from pointer after free") > Fixes: 05564d0ae075 ("net/mlx5: Add flow-steering commands for FPGA > IPSec implementation") > Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> > Signed-off-by: Gustavo A. R. Silva <gu

Re: [PATCH v2] net/mlx5: Fix use-after-free

resses-Coverity-ID: 1466041 ("Read from pointer after free") > Fixes: 05564d0ae075 ("net/mlx5: Add flow-steering commands for FPGA > IPSec implementation") > Reviewed-by: Yuval Shaia > Signed-off-by: Gustavo A. R. Silva Acked-by: Saeed Mahameed > --- > Cha

Re: linux-next: manual merge of the net-next tree with the rdma-fixes tree

On Thu, 2018-03-15 at 21:18 -0400, Doug Ledford wrote: > On Fri, 2018-03-16 at 11:56 +1100, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the net-next tree got a conflict in: > > > > drivers/infiniband/hw/mlx5/main.c > > > > between commit: > > > > 42cea83f9524

Re: linux-next: manual merge of the net-next tree with the rdma-fixes tree

On Thu, 2018-03-15 at 21:18 -0400, Doug Ledford wrote: > On Fri, 2018-03-16 at 11:56 +1100, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the net-next tree got a conflict in: > > > > drivers/infiniband/hw/mlx5/main.c > > > > between commit: > > > > 42cea83f9524

Re: [PATCH] net: mlx5: remove pointless memcpy

On 02/02/2018 12:26 PM, Arnd Bergmann wrote: > On Fri, Feb 2, 2018 at 8:06 PM, Jason Gunthorpe wrote: >> On Fri, Feb 02, 2018 at 04:46:30PM +0100, Arnd Bergmann wrote: >>> gcc-8 notices that the memcpy in mlx5_core_query_xsrq() makes no >>> sense because the source and

Re: [PATCH] net: mlx5: remove pointless memcpy

On 02/02/2018 12:26 PM, Arnd Bergmann wrote: > On Fri, Feb 2, 2018 at 8:06 PM, Jason Gunthorpe wrote: >> On Fri, Feb 02, 2018 at 04:46:30PM +0100, Arnd Bergmann wrote: >>> gcc-8 notices that the memcpy in mlx5_core_query_xsrq() makes no >>> sense because the source and destination variables are

Re: [PATCH] net/mlx5e: Fix trailing semicolon

On 01/17/2018 04:09 AM, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. > > Signed-off-by: Luis de Bethencourt <lui...@kernel.org> Looks Good, Thanks Luis. Reviewed-by: S

Re: [PATCH] net/mlx5e: Fix trailing semicolon

On 01/17/2018 04:09 AM, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. > > Signed-off-by: Luis de Bethencourt Looks Good, Thanks Luis. Reviewed-by: Saeed Mahameed

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

On 01/12/2018 12:16 PM, Eric Dumazet wrote: > On Fri, 2018-01-12 at 11:53 -0800, Saeed Mahameed wrote: >> >> On 01/12/2018 08:46 AM, Eric Dumazet wrote: >>> On Fri, 2018-01-12 at 09:32 -0700, Jason Gunthorpe wrote: >>>> On Fri, Jan 12, 2018 at 1

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

On 01/12/2018 12:16 PM, Eric Dumazet wrote: > On Fri, 2018-01-12 at 11:53 -0800, Saeed Mahameed wrote: >> >> On 01/12/2018 08:46 AM, Eric Dumazet wrote: >>> On Fri, 2018-01-12 at 09:32 -0700, Jason Gunthorpe wrote: >>>> On Fri, Jan 12, 2018 at 1

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

On 01/12/2018 08:46 AM, Eric Dumazet wrote: On Fri, 2018-01-12 at 09:32 -0700, Jason Gunthorpe wrote: On Fri, Jan 12, 2018 at 11:42:22AM +0800, Jianchao Wang wrote: Customer reported memory corruption issue on previous mlx4_en driver version where the order-3 pages and multiple page

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

On 01/12/2018 08:46 AM, Eric Dumazet wrote: On Fri, 2018-01-12 at 09:32 -0700, Jason Gunthorpe wrote: On Fri, Jan 12, 2018 at 11:42:22AM +0800, Jianchao Wang wrote: Customer reported memory corruption issue on previous mlx4_en driver version where the order-3 pages and multiple page

Re: [PATCH] net/mlx5e: hide an unused variable

: unused variable 'uplink_rpriv' [-Werror=unused-variable] This moves the declaration into that #ifdef as well. Fixes: 5ed99fb421d4 ("net/mlx5e: Move ethernet representors data into separate struct") Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Saeed Mahameed <

Re: [PATCH] net/mlx5e: hide an unused variable

: unused variable 'uplink_rpriv' [-Werror=unused-variable] This moves the declaration into that #ifdef as well. Fixes: 5ed99fb421d4 ("net/mlx5e: Move ethernet representors data into separate struct") Signed-off-by: Arnd Bergmann Acked-by: Saeed Mahameed Thank you Arnd.

Re: Creating cyclecounter and lock member in timecounter structure [ Was Re: [RFC 1/4] drm/i915/perf: Add support to correlate GPU timestamp with system time]

On Mon, Nov 27, 2017 at 2:05 AM, Sagar Arun Kamble wrote: > > > On 11/24/2017 7:01 PM, Thomas Gleixner wrote: >> >> On Fri, 24 Nov 2017, Sagar Arun Kamble wrote: >>> >>> On 11/24/2017 12:29 AM, Thomas Gleixner wrote: On Thu, 23 Nov 2017, Sagar Arun Kamble

Re: Creating cyclecounter and lock member in timecounter structure [ Was Re: [RFC 1/4] drm/i915/perf: Add support to correlate GPU timestamp with system time]

On Mon, Nov 27, 2017 at 2:05 AM, Sagar Arun Kamble wrote: > > > On 11/24/2017 7:01 PM, Thomas Gleixner wrote: >> >> On Fri, 24 Nov 2017, Sagar Arun Kamble wrote: >>> >>> On 11/24/2017 12:29 AM, Thomas Gleixner wrote: On Thu, 23 Nov 2017, Sagar Arun Kamble wrote: > > We needed

Re: [PATCH] net/mlx5e/core/en_fs: fix pointer dereference after free in mlx5e_execute_l2_action

possible execution paths within function mlx5e_execute_l2_action. > > Addresses-Coverity-ID: 1417789 > Fixes: eeb66cdb6826 ("net/mlx5: Separate between E-Switch and MPFS") > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Acked-by: Saeed Mahameed

Re: [PATCH] net/mlx5e/core/en_fs: fix pointer dereference after free in mlx5e_execute_l2_action

hs within function mlx5e_execute_l2_action. > > Addresses-Coverity-ID: 1417789 > Fixes: eeb66cdb6826 ("net/mlx5: Separate between E-Switch and MPFS") > Signed-off-by: Gustavo A. R. Silva Acked-by: Saeed Mahameed Looks good. Thank you Gustavo. > --- > drivers/net/ethernet/mell

Re: [PATCH] net/mlx5: fpga: avoid uninitialized return codes

On Thu, Sep 14, 2017 at 5:54 AM, Leon Romanovsky wrote: > On Thu, Sep 14, 2017 at 01:06:18PM +0200, Arnd Bergmann wrote: >> calling mlx5_fpga_mem_{read,write}_i2c() with a zero length on >> older compiler version such as gcc-4.6 results in a warning that >> the return code is

Re: [PATCH] net/mlx5: fpga: avoid uninitialized return codes

On Thu, Sep 14, 2017 at 5:54 AM, Leon Romanovsky wrote: > On Thu, Sep 14, 2017 at 01:06:18PM +0200, Arnd Bergmann wrote: >> calling mlx5_fpga_mem_{read,write}_i2c() with a zero length on >> older compiler version such as gcc-4.6 results in a warning that >> the return code is not initialized: >>

Re: linux-next: manual merge of the net-next tree with the net tree

On Mon, Jul 3, 2017 at 4:43 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got conflicts in: > > drivers/net/ethernet/mellanox/mlx5/core/health.c > include/linux/mlx5/driver.h > > between commit: > > 2a0165a034ac ("net/mlx5:

Re: linux-next: manual merge of the net-next tree with the net tree

On Mon, Jul 3, 2017 at 4:43 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got conflicts in: > > drivers/net/ethernet/mellanox/mlx5/core/health.c > include/linux/mlx5/driver.h > > between commit: > > 2a0165a034ac ("net/mlx5: Cancel delayed recovery

Re: [PATCH] [net-next] net/mlx5: include wq.o in non-ethernet build for FPGA

On Fri, Jun 30, 2017 at 10:25 PM, Arnd Bergmann wrote: > On Fri, Jun 30, 2017 at 8:58 PM, Ilan Tayari wrote: > >>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Makefile >>> b/drivers/net/ethernet/mellanox/mlx5/core/Makefile >>> index

Re: [PATCH] [net-next] net/mlx5: include wq.o in non-ethernet build for FPGA

On Fri, Jun 30, 2017 at 10:25 PM, Arnd Bergmann wrote: > On Fri, Jun 30, 2017 at 8:58 PM, Ilan Tayari wrote: > >>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Makefile >>> b/drivers/net/ethernet/mellanox/mlx5/core/Makefile >>> index ca367445f864..50fe9e3c5dc2 100644 >>> ---

Re: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> "Allocating"

On Sun, Jul 2, 2017 at 12:40 AM, David Miller wrote: > From: Colin King > Date: Fri, 30 Jun 2017 11:59:22 +0100 > >> From: Colin Ian King >> >> Trivial fix to spelling mistake in mlx5_core_dbg debug message >> >>

Re: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> "Allocating"

On Sun, Jul 2, 2017 at 12:40 AM, David Miller wrote: > From: Colin King > Date: Fri, 30 Jun 2017 11:59:22 +0100 > >> From: Colin Ian King >> >> Trivial fix to spelling mistake in mlx5_core_dbg debug message >> >> Signed-off-by: Colin Ian King > > Applied, thanks Colin. > > Mellanox folks, I

Re: [PATCH net] net/mlx5: avoid build warning for uniprocessor

ED(CONFIG_SMP) && > + irq_set_affinity_hint(irq, priv->irq_info[i].mask)) > mlx5_core_warn(mdev, "irq_set_affinity_hint failed, irq > 0x%.4x", irq); > -#endif > > return 0; > } Acked-by: Saeed Mahameed <sae...@mellanox.com> Thank you Arnd !!

Re: [PATCH net] net/mlx5: avoid build warning for uniprocessor

et_affinity_hint(irq, priv->irq_info[i].mask)) > mlx5_core_warn(mdev, "irq_set_affinity_hint failed, irq > 0x%.4x", irq); > -#endif > > return 0; > } Acked-by: Saeed Mahameed Thank you Arnd !!

Re: [PATCH net-next] net/mlx5e: fix build error without CONFIG_SYSFS

eues != num_txqs) > - netif_set_real_num_tx_queues(netdev, num_txqs); > - if (netdev->real_num_rx_queues != priv->channels.num) > - netif_set_real_num_rx_queues(netdev, priv->channels.num); > + netif_set_real_num_tx_queues(netdev, num_txqs); > + netif_set_real_num_rx_

Re: [PATCH net-next] net/mlx5e: fix build error without CONFIG_SYSFS

> - if (netdev->real_num_rx_queues != priv->channels.num) > - netif_set_real_num_rx_queues(netdev, priv->channels.num); > + netif_set_real_num_tx_queues(netdev, num_txqs); > + netif_set_real_num_rx_queues(netdev, priv->channels.num); > Acked-by:

Re: mlx5: net_device.addr_list_lock usage before initialization

On Tue, Dec 13, 2016 at 3:22 PM, Sebastian Ott wrote: > Hi, > > I ran into the following lockdep complaint: > > [7.059561] INFO: trying to register non-static key. > [7.059566] the code is fine but needs lockdep annotation. > [7.059570] turning off the

Re: mlx5: net_device.addr_list_lock usage before initialization

On Tue, Dec 13, 2016 at 3:22 PM, Sebastian Ott wrote: > Hi, > > I ran into the following lockdep complaint: > > [7.059561] INFO: trying to register non-static key. > [7.059566] the code is fine but needs lockdep annotation. > [7.059570] turning off the locking correctness validator. >

Re: [PATCH net-next 1/3] net/mlx5e: use %pad format string for dma_addr_t

print the correct address and avoid the warning. > > Fixes: 1c1b522808a1 ("net/mlx5e: Implement Fragmented Work Queue (WQ)") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thank you Arnd !! Acked-by: Saeed Mahameed <sae...@mellanox.com>

Re: [PATCH net-next 1/3] net/mlx5e: use %pad format string for dma_addr_t

print the correct address and avoid the warning. > > Fixes: 1c1b522808a1 ("net/mlx5e: Implement Fragmented Work Queue (WQ)") > Signed-off-by: Arnd Bergmann Thank you Arnd !! Acked-by: Saeed Mahameed

Re: [patch] net/mlx5: remove a duplicate condition

On Thu, Nov 24, 2016 at 1:03 PM, Dan Carpenter <dan.carpen...@oracle.com> wrote: > We verified that MLX5_FLOW_CONTEXT_ACTION_COUNT was set on the first > line of the function so we don't need to check again here. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

Re: [patch] net/mlx5: remove a duplicate condition

On Thu, Nov 24, 2016 at 1:03 PM, Dan Carpenter wrote: > We verified that MLX5_FLOW_CONTEXT_ACTION_COUNT was set on the first > line of the function so we don't need to check again here. > > Signed-off-by: Dan Carpenter Acked-by: Saeed Mahameed

Re: [PATCH] net/mlx5: drop duplicate header delay.h

On Thu, Nov 24, 2016 at 3:58 PM, Geliang Tang <geliangt...@gmail.com> wrote: > Drop duplicate header delay.h from mlx5/core/main.c. > > Signed-off-by: Geliang Tang <geliangt...@gmail.com> Acked-by: Saeed Mahameed <sae...@mellanox.com>

Re: [PATCH] net/mlx5: drop duplicate header delay.h

On Thu, Nov 24, 2016 at 3:58 PM, Geliang Tang wrote: > Drop duplicate header delay.h from mlx5/core/main.c. > > Signed-off-by: Geliang Tang Acked-by: Saeed Mahameed

Re: mlx5: ifup failure due to huge allocation

On Wed, Nov 2, 2016 at 3:37 PM, Sebastian Ott wrote: > Hi, > > Ifup on an interface provided by CX4 (MLX5 driver) on s390 fails with: > > [ 22.318553] [ cut here ] > [ 22.318564] WARNING: CPU: 1 PID: 399 at mm/page_alloc.c:3421 >

Re: mlx5: ifup failure due to huge allocation

On Wed, Nov 2, 2016 at 3:37 PM, Sebastian Ott wrote: > Hi, > > Ifup on an interface provided by CX4 (MLX5 driver) on s390 fails with: > > [ 22.318553] [ cut here ] > [ 22.318564] WARNING: CPU: 1 PID: 399 at mm/page_alloc.c:3421 > __alloc_pages_nodemask+0x2ee/0x1298 >

Re: [PATCH] net/mlx5: Simplify a test

On 11/01/2016 09:10 AM, Christophe JAILLET wrote: 'create_root_ns()' does not return an error pointer, so the test can be simplified to be more consistent. Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Acked-by: Saeed Mahameed <sae...@mellanox.com>

Re: [PATCH] net/mlx5: Simplify a test

On 11/01/2016 09:10 AM, Christophe JAILLET wrote: 'create_root_ns()' does not return an error pointer, so the test can be simplified to be more consistent. Signed-off-by: Christophe JAILLET Acked-by: Saeed Mahameed

Re: [PATCH v2] mlx5: Add ndo_poll_controller() implementation

On Wed, Sep 28, 2016 at 1:23 AM, Calvin Owens <calvinow...@fb.com> wrote: > This implements ndo_poll_controller in net_device_ops callback for mlx5, > which is necessary to use netconsole with this driver. > > Cc: Saeed Mahameed <sae...@dev.mellanox.co.il> > Signed-off

Re: [PATCH v2] mlx5: Add ndo_poll_controller() implementation

On Wed, Sep 28, 2016 at 1:23 AM, Calvin Owens wrote: > This implements ndo_poll_controller in net_device_ops callback for mlx5, > which is necessary to use netconsole with this driver. > > Cc: Saeed Mahameed > Signed-off-by: Calvin Owens Acked-By: Saeed Mahameed

Re: [PATCH] mlx5: Add ndo_poll_controller() implementation

On Fri, Sep 23, 2016 at 11:13 PM, Calvin Owens wrote: > This implements ndo_poll_controller in net_device_ops for mlx5, which is > necessary to use netconsole with this driver. > > Signed-off-by: Calvin Owens > --- >

Re: [PATCH] mlx5: Add ndo_poll_controller() implementation

On Fri, Sep 23, 2016 at 11:13 PM, Calvin Owens wrote: > This implements ndo_poll_controller in net_device_ops for mlx5, which is > necessary to use netconsole with this driver. > > Signed-off-by: Calvin Owens > --- > drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 20 >

Re: linux-next: Tree for Aug 16 (mellanox/mlx5 & sound/oss/)

On Tue, Aug 16, 2016 at 6:26 PM, Randy Dunlap wrote: > On 08/15/16 21:01, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20160815: >> > > on i386: > > sound/built-in.o:(.data+0x5c): multiple definition of `dev_list' > drivers/built-in.o:(.data+0x6aee8): first

Re: linux-next: Tree for Aug 16 (mellanox/mlx5 & sound/oss/)

On Tue, Aug 16, 2016 at 6:26 PM, Randy Dunlap wrote: > On 08/15/16 21:01, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20160815: >> > > on i386: > > sound/built-in.o:(.data+0x5c): multiple definition of `dev_list' > drivers/built-in.o:(.data+0x6aee8): first defined here > ld: Warning:

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

On Thu, Jul 28, 2016 at 12:37 PM, Leon Romanovsky wrote: > On Thu, Jul 28, 2016 at 01:49:49PM +0530, Bhaktipriya Shridhar wrote: >> A dedicated workqueue has been used since the work items are being used >> on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

On Thu, Jul 28, 2016 at 12:37 PM, Leon Romanovsky wrote: > On Thu, Jul 28, 2016 at 01:49:49PM +0530, Bhaktipriya Shridhar wrote: >> A dedicated workqueue has been used since the work items are being used >> on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward >> progress

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

On Thu, Jul 28, 2016 at 11:19 AM, Bhaktipriya Shridhar wrote: > A dedicated workqueue has been used since the work items are being used > on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward > progress under memory pressure. > > The workqueue has a

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

On Thu, Jul 28, 2016 at 11:19 AM, Bhaktipriya Shridhar wrote: > A dedicated workqueue has been used since the work items are being used > on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward > progress under memory pressure. > > The workqueue has a single work item. Hence,

Re: [RFC] net/mlx5_core/en_main: Remove deprecated create_workqueue

On Wed, Jul 27, 2016 at 9:12 AM, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue() with WQ_MEM_RECLAIM set replaces > deprecated create_singlethread_workqueue(). This is the identity > conversion. > > A dedicated workqueue has been used since mlx5e workqueue was

Re: [RFC] net/mlx5_core/en_main: Remove deprecated create_workqueue

On Wed, Jul 27, 2016 at 9:12 AM, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue() with WQ_MEM_RECLAIM set replaces > deprecated create_singlethread_workqueue(). This is the identity > conversion. > > A dedicated workqueue has been used since mlx5e workqueue was created to > handle all

Re: linux-next: manual merge of the net-next tree with the net tree

On Mon, Jul 4, 2016 at 6:07 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en_main.c > > between commit: > > 29429f3300a3 ("net/mlx5e: Timeout if SQ doesn't flush

Re: linux-next: manual merge of the net-next tree with the net tree

On Mon, Jul 4, 2016 at 6:07 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en_main.c > > between commit: > > 29429f3300a3 ("net/mlx5e: Timeout if SQ doesn't flush during close") > > from

Re: linux-next: manual merge of the net-next tree with the net tree

On Mon, Jul 4, 2016 at 6:02 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en.h > > between commit: > > 6cd392a082de ("net/mlx5e: Handle RQ flush in error cases") > >

Re: linux-next: manual merge of the net-next tree with the net tree

On Mon, Jul 4, 2016 at 6:02 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en.h > > between commit: > > 6cd392a082de ("net/mlx5e: Handle RQ flush in error cases") > > from the net tree and

Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

On Thu, Jun 23, 2016 at 8:27 AM, Leon Romanovsky wrote: > On Wed, Jun 22, 2016 at 11:23:59AM -0700, Joe Perches wrote: >> The logging macros create a bit of duplicated code/text. >> >> Use specialized functions to reduce the duplication. >> >> (defconfig/x86-64) >> $ size

Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

On Thu, Jun 23, 2016 at 8:27 AM, Leon Romanovsky wrote: > On Wed, Jun 22, 2016 at 11:23:59AM -0700, Joe Perches wrote: >> The logging macros create a bit of duplicated code/text. >> >> Use specialized functions to reduce the duplication. >> >> (defconfig/x86-64) >> $ size

Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

On Wed, Jun 22, 2016 at 9:23 PM, Joe Perches wrote: [...] > --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c > @@ -1557,3 +1557,37 @@ static void __exit cleanup(void) > > module_init(init); > module_exit(cleanup); > +

Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

On Wed, Jun 22, 2016 at 9:23 PM, Joe Perches wrote: [...] > --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c > @@ -1557,3 +1557,37 @@ static void __exit cleanup(void) > > module_init(init); > module_exit(cleanup); > + > +void

Re: [PATCH 2/2] mlx5: fix 64-bit division on times

On Wed, Jun 15, 2016 at 6:27 PM, Arnd Bergmann wrote: > The mlx5 driver fails to build on 32-bit architectures after some > references to 64-bit divisions got added: > > drivers/net/built-in.o: In function `mlx5e_rx_am': > :(.text+0xf88ac): undefined reference to `__aeabi_ldivmod'

Re: [PATCH 2/2] mlx5: fix 64-bit division on times

On Wed, Jun 15, 2016 at 6:27 PM, Arnd Bergmann wrote: > The mlx5 driver fails to build on 32-bit architectures after some > references to 64-bit divisions got added: > > drivers/net/built-in.o: In function `mlx5e_rx_am': > :(.text+0xf88ac): undefined reference to `__aeabi_ldivmod' > > The driver

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

On Wed, Jun 15, 2016 at 11:50 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > Ok, I see. It would be nice if the process had a way to avoid build > regressions > in linux-next, in particular if you already have

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

On Wed, Jun 15, 2016 at 11:50 PM, Arnd Bergmann wrote: > On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > Ok, I see. It would be nice if the process had a way to avoid build > regressions > in linux-next, in particular if you already have a fix by the

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

On Wed, Jun 15, 2016 at 6:27 PM, Arnd Bergmann wrote: > We get a build error with the mlx5 driver when the ethernet > support (CONFIG_MLX5_CORE_EN) is disabled: > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1320:22: error: > 'mlx5_devlink_eswitch_mode_set' undeclared here

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

On Wed, Jun 15, 2016 at 6:27 PM, Arnd Bergmann wrote: > We get a build error with the mlx5 driver when the ethernet > support (CONFIG_MLX5_CORE_EN) is disabled: > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1320:22: error: > 'mlx5_devlink_eswitch_mode_set' undeclared here (not in a

Re: [PATCH 2/3] net/mlx5e: make VXLAN support conditional

On Fri, May 6, 2016 at 10:35 PM, David Miller wrote: > From: Arnd Bergmann > Date: Thu, 05 May 2016 20:09:19 +0200 > >> For reference, I've tried it out on the MLX4 driver, and it does >> seem nicer that way, see below. > > Is it possible to wind down this

Re: [PATCH 2/3] net/mlx5e: make VXLAN support conditional

On Fri, May 6, 2016 at 10:35 PM, David Miller wrote: > From: Arnd Bergmann > Date: Thu, 05 May 2016 20:09:19 +0200 > >> For reference, I've tried it out on the MLX4 driver, and it does >> seem nicer that way, see below. > > Is it possible to wind down this conversation and have someone submit >

Re: [PATCH 2/3] net/mlx5e: make VXLAN support conditional

On Wed, May 4, 2016 at 3:31 PM, Arnd Bergmann wrote: > VXLAN can be disabled at compile-time or it can be a loadable > module while mlx5 is built-in, which leads to a link error: > > drivers/net/built-in.o: In function `mlx5e_create_netdev': > ntb_netdev.c:(.text+0x106de4):

Re: [PATCH 2/3] net/mlx5e: make VXLAN support conditional

On Wed, May 4, 2016 at 3:31 PM, Arnd Bergmann wrote: > VXLAN can be disabled at compile-time or it can be a loadable > module while mlx5 is built-in, which leads to a link error: > > drivers/net/built-in.o: In function `mlx5e_create_netdev': > ntb_netdev.c:(.text+0x106de4): undefined reference to

Re: [PATCH 3/3] net/mlx5e: don't build RFS without ethernet

On Wed, May 4, 2016 at 5:23 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Wednesday 04 May 2016 16:09:16 Saeed Mahameed wrote: >> On Wed, May 4, 2016 at 3:32 PM, Arnd Bergmann <a...@arndb.de> wrote: >> > The RFS acceleration support in mlx5 is enabled whenever C

Re: [PATCH 3/3] net/mlx5e: don't build RFS without ethernet

On Wed, May 4, 2016 at 5:23 PM, Arnd Bergmann wrote: > On Wednesday 04 May 2016 16:09:16 Saeed Mahameed wrote: >> On Wed, May 4, 2016 at 3:32 PM, Arnd Bergmann wrote: >> > The RFS acceleration support in mlx5 is enabled whenever CONFIG_RFS_ACCEL >> > is in use. Ho

Re: [PATCH 3/3] net/mlx5e: don't build RFS without ethernet

On Wed, May 4, 2016 at 3:32 PM, Arnd Bergmann wrote: > The RFS acceleration support in mlx5 is enabled whenever CONFIG_RFS_ACCEL > is in use. However, this fails if a user turns off CONFIG_MLX5_CORE_EN, > because the rfs code now calls into the ethernet portion of the > driver: > >

Re: [PATCH 3/3] net/mlx5e: don't build RFS without ethernet

On Wed, May 4, 2016 at 3:32 PM, Arnd Bergmann wrote: > The RFS acceleration support in mlx5 is enabled whenever CONFIG_RFS_ACCEL > is in use. However, this fails if a user turns off CONFIG_MLX5_CORE_EN, > because the rfs code now calls into the ethernet portion of the > driver: > > ERROR:

Re: linux-next: manual merge of the net-next tree with the net tree

On Wed, Apr 27, 2016 at 5:01 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en_main.c > > between commit: > > d8edd2469ace ("et/mlx5e: Fix minimum MTU") > > from the

Re: linux-next: manual merge of the net-next tree with the net tree

On Wed, Apr 27, 2016 at 5:01 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en_main.c > > between commit: > > d8edd2469ace ("et/mlx5e: Fix minimum MTU") > > from the net tree and commit: >

Re: [PATCH v2] net/mlx5e: avoid stack overflow in mlx5e_open_channels

not in > a fast path, so the easiest workaround is to use another kzalloc > for allocating the channel parameters. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: d3c9bc2743dc ("net/mlx5e: Added ICO SQs") Acked-by: Saeed Mahameed <sae...@mellanox.com>

Re: [PATCH v2] net/mlx5e: avoid stack overflow in mlx5e_open_channels

t path, so the easiest workaround is to use another kzalloc > for allocating the channel parameters. > > Signed-off-by: Arnd Bergmann > Fixes: d3c9bc2743dc ("net/mlx5e: Added ICO SQs") Acked-by: Saeed Mahameed

Re: [PATCH] net/mlx5e: avoid stack overflow in mlx5e_open_channels

On Tue, Apr 26, 2016 at 6:49 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Tuesday 26 April 2016 17:41:45 Saeed Mahameed wrote: >> On Tue, Apr 26, 2016 at 4:53 PM, Arnd Bergmann <a...@arndb.de> wrote: >> > >> > Sure, do you want to just edit this when you fo

Re: [PATCH] net/mlx5e: avoid stack overflow in mlx5e_open_channels

On Tue, Apr 26, 2016 at 6:49 PM, Arnd Bergmann wrote: > On Tuesday 26 April 2016 17:41:45 Saeed Mahameed wrote: >> On Tue, Apr 26, 2016 at 4:53 PM, Arnd Bergmann wrote: >> > >> > Sure, do you want to just edit this when you forward the patch, or >> > do you

Re: [PATCH] net/mlx5e: avoid stack overflow in mlx5e_open_channels

On Tue, Apr 26, 2016 at 4:53 PM, Arnd Bergmann wrote: > > Sure, do you want to just edit this when you forward the patch, or > do you need me to do it? > Well, I won't say no if you want to do it :) Saeed

Re: [PATCH] net/mlx5e: avoid stack overflow in mlx5e_open_channels

On Tue, Apr 26, 2016 at 4:53 PM, Arnd Bergmann wrote: > > Sure, do you want to just edit this when you forward the patch, or > do you need me to do it? > Well, I won't say no if you want to do it :) Saeed

Re: [PATCH] net/mlx5e: avoid stack overflow in mlx5e_open_channels

On Mon, Apr 25, 2016 at 4:15 PM, Arnd Bergmann wrote: > struct mlx5e_channel_param is a large structure that is allocated > on the stack of mlx5e_open_channels, and with a recent change > it has grown beyond the warning size for the maximum stack > that a single function should

Re: [PATCH] net/mlx5e: avoid stack overflow in mlx5e_open_channels

On Mon, Apr 25, 2016 at 4:15 PM, Arnd Bergmann wrote: > struct mlx5e_channel_param is a large structure that is allocated > on the stack of mlx5e_open_channels, and with a recent change > it has grown beyond the warning size for the maximum stack > that a single function should use: > >

Re: [PATCH] net/mlx5e: make VXLAN support conditional

On Fri, Feb 26, 2016 at 11:13 PM, Arnd Bergmann wrote: > VXLAN can be disabled at compile-time or it can be a loadable > module while mlx5 is built-in, which leads to a link error: > > drivers/net/built-in.o: In function `mlx5e_create_netdev': > ntb_netdev.c:(.text+0x106de4):

Re: [PATCH] net/mlx5e: make VXLAN support conditional

On Fri, Feb 26, 2016 at 11:13 PM, Arnd Bergmann wrote: > VXLAN can be disabled at compile-time or it can be a loadable > module while mlx5 is built-in, which leads to a link error: > > drivers/net/built-in.o: In function `mlx5e_create_netdev': > ntb_netdev.c:(.text+0x106de4): undefined reference

<    1   2   3