[PATCH net 05/19] net: hns: Remove redundant memset during buffer release

2017-03-30 Thread Salil Mehta
f-by: lipeng Signed-off-by: Weiwei Deng Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hnae.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/drivers/net/ethernet/hisilicon/hns/hnae.c index b6ed818..

[PATCH net 13/19] net: hns: Remove redundant mac table operations

2017-03-30 Thread Salil Mehta
From: Kejian Yan This patch removes redundant functions used only for debugging purposes. Reported-by: Weiwei Deng Signed-off-by: Kejian Yan Reviewed-by: Salil Mehta Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 160 - drivers/net

[PATCH net 09/19] net: hns: Replace netif_tx_lock to ring spin lock

2017-03-30 Thread Salil Mehta
From: lipeng netif_tx_lock is a global spin lock, it will take affect in all rings in the netdevice. In tx_poll_one process, it can only lock the current ring, in this case, we define a spin lock in hnae_ring struct for it. Signed-off-by: lipeng reviewed-by: Yisen Zhuang Signed-off-by: Salil

[PATCH net 14/19] net: hns: Clean redundant code from hns_mdio.c file

2017-03-30 Thread Salil Mehta
From: Kejian Yan This patch cleans the redundant code from hns_mdio.c. Reported-by: Ping Zhang Signed-off-by: Kejian Yan Reviewed-by: Salil Mehta Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns_mdio.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers

[PATCH net 15/19] net: hns: Optimise the code in hns_mdio_wait_ready()

2017-03-30 Thread Salil Mehta
From: Kejian Yan This patch fixes the code to clear pclint warning/info. Reported-by: Ping Zhang Signed-off-by: Kejian Yan Reviewed-by: Salil Mehta Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns_mdio.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions

[PATCH net 12/19] net: hns: Remove redundant mac_get_id()

2017-03-30 Thread Salil Mehta
From: Kejian Yan There is a mac_id in mac control block structure, so the callback function mac_get_id() is useless. Here we remove this function. Reported-by: Weiwei Deng Signed-off-by: Kejian Yan Reviewed-by: Salil Mehta Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns

[PATCH net 18/19] net: hns: Avoid Hip06 chip TX packet line bug

2017-03-30 Thread Salil Mehta
send thread on ARM and an iperf send thread on X86 for XGE. Signed-off-by: lipeng Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hnae.c | 5 ++ drivers/net/ethernet/hisilicon/hns/hnae.h | 6 +- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 78

[PATCH net 11/19] net: hns: Remove the redundant adding and deleting mac function

2017-03-30 Thread Salil Mehta
From: Kejian Yan The functions (hns_dsaf_set_mac_mc_entry() and hns_mac_del_mac()) are not called by any functions. They are dead code in hns. And the same features are implemented by the patch (the id is 66355f5). Reported-by: Weiwei Deng Signed-off-by: Kejian Yan Reviewed-by: Salil Mehta

[PATCH net 19/19] net: hns: Some checkpatch.pl script & warning fixes

2017-03-30 Thread Salil Mehta
This patch fixes some checkpatch.pl script caught errors and warnings during the compilation time. Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hnae.h | 1 - drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 11 +-- drivers/net/ethernet/hisilicon/hns

[PATCH net 17/19] net: hns: Adjust the SBM module buffer threshold

2017-03-30 Thread Salil Mehta
: Salil Mehta Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c index abd8aec

[PATCH net 10/19] net: hns: Correct HNS RSS key set function

2017-03-30 Thread Salil Mehta
From: lipeng This patch fixes below ethtool configuration error: localhost:~ # ethtool -X eth0 hkey XX:XX:XX... Cannot set Rx flow hash configuration: Operation not supported Signed-off-by: lipeng Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns

[PATCH net 16/19] net: hns: Simplify the exception sequence in hns_ppe_init()

2017-03-30 Thread Salil Mehta
From: Kejian Yan We need to free all ppe submodule if it fails to initialize ppe by any fault, so this patch will free all ppe resource before hns_ppe_init() returns exception situation Reported-by: JinchuanTian Signed-off-by: Kejian Yan Reviewed-by: Salil Mehta Signed-off-by: Salil Mehta

[PATCH net 08/19] net: hns: Fix to adjust buf_size of ring according to mtu

2017-03-30 Thread Salil Mehta
. Because the Pv660 do not support rss indirection, we need add version check in mtu change process. Signed-off-by: lipeng reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hnae.h | 37 drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 26

[PATCH net 02/19] net: hns: Modify GMAC init TX threshold value

2017-03-30 Thread Salil Mehta
From: lipeng This patch reduces GMAC TX threshold value to avoid gmac hang-up with speed 100M/duplex half. Signed-off-by: lipeng Signed-off-by: JinchuanTian Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 6 ++ drivers/net

[PATCH V2 net] net: hns: Fix the device being used for dma mapping during TX

2017-02-09 Thread Salil Mehta
ned-off-by: Kejian Yan Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- Change log: PATCH V2: Addressed comment given by, Yuan Linyu PATCH V1: Initial submit --- drivers/net/ethernet/hisilicon/hns/hns_enet.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

RE: [PATCH net] net: hns: Fix the device being used for dma mapping during TX

2017-02-09 Thread Salil Mehta
> -Original Message- > From: Lino Sanfilippo [mailto:linosanfili...@gmx.de] > Sent: Thursday, February 09, 2017 10:25 AM > To: Salil Mehta > Cc: da...@davemloft.net; Salil Mehta; Zhuangyuzeng (Yisen); > mehta.salil@gmail.com; net...@vger.kernel.org; linux- > k

RE: [PATCH net] net: hns: Fix the device being used for dma mapping during TX

2017-02-09 Thread Salil Mehta
> -Original Message- > From: Salil Mehta > Sent: Thursday, February 09, 2017 9:48 AM > To: 'YUAN Linyu'; da...@davemloft.net > Cc: Zhuangyuzeng (Yisen); mehta.salil@gmail.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm; > Yanke

RE: [PATCH net] net: hns: Fix the device being used for dma mapping during TX

2017-02-09 Thread Salil Mehta
> -Original Message- > From: YUAN Linyu [mailto:linyu.y...@alcatel-sbell.com.cn] > Sent: Thursday, February 09, 2017 9:36 AM > To: Salil Mehta; da...@davemloft.net > Cc: Zhuangyuzeng (Yisen); mehta.salil@gmail.com; > net...@vger.kernel.org; linux-kernel@vger.ke

[PATCH net] net: hns: Fix the device being used for dma mapping during TX

2017-02-09 Thread Salil Mehta
ned-off-by: Kejian Yan Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_enet.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c in

[PATCH V4 net-next] net: hns: Fix to conditionally convey RX checksum flag to stack

2016-12-06 Thread Salil Mehta
not maintain the RX L3/L4 checksum counters as well. Signed-off-by: Salil Mehta --- Change Log: Patch V4: Accidentally floated a wrong V3 patch. corrected this: Link: https://lkml.org/lkml/2016/12/5/604 Patch V3: Re-structured the code. Patch V2: Addressed the comment by David Miller

RE: [PATCH V2 net-next] net: hns: Fix to conditionally convey RX checksum flag to stack

2016-12-05 Thread Salil Mehta
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Saturday, December 03, 2016 8:09 PM > To: Salil Mehta > Cc: Zhuangyuzeng (Yisen); mehta.salil@gmail.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm > Subject: R

RE: [PATCH V2 net-next] net: hns: Fix to conditionally convey RX checksum flag to stack

2016-12-05 Thread Salil Mehta
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Saturday, December 03, 2016 8:25 PM > To: Salil Mehta > Cc: Zhuangyuzeng (Yisen); mehta.salil@gmail.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm > Subject: R

[PATCH V3 net-next] net: hns: Fix to conditionally convey RX checksum flag to stack

2016-12-05 Thread Salil Mehta
not maintain the RX L3/L4 checksum counters as well. Signed-off-by: Salil Mehta --- Change Log: Patch V3: Re-structured the code. Patch V2: Addressed the comment by David Miller Link: https://www.spinics.net/lists/netdev/msg406697.html Patch V1: This patch is a result of the

RE: [PATCH V2 net-next] net: hns: Fix to conditionally convey RX checksum flag to stack

2016-12-01 Thread Salil Mehta
> -Original Message- > From: Salil Mehta > Sent: Thursday, December 01, 2016 12:09 PM > To: 'David Miller' > Cc: Zhuangyuzeng (Yisen); mehta.salil@gmail.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm > Subject: RE: [PATC

RE: [PATCH V2 net-next] net: hns: Fix to conditionally convey RX checksum flag to stack

2016-12-01 Thread Salil Mehta
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, November 30, 2016 7:26 PM > To: Salil Mehta > Cc: Zhuangyuzeng (Yisen); mehta.salil@gmail.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm > Subject: R

[PATCH for-next 5/6] IB/hns: Fix the bug when free cq

2016-11-29 Thread Salil Mehta
outstanding CQE have been written. Then the cq buffer can be released. Signed-off-by: Shaobo Xu Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_common.h |2 + drivers/infiniband/hw/hns/hns_roce_cq.c | 27 -- drivers/infiniband

[PATCH for-next 6/6] IB/hns: Fix the IB device name

2016-11-29 Thread Salil Mehta
From: Lijun Ou This patch mainly fix the name for IB device in order to match with libhns. Signed-off-by: Lijun Ou Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hns

[PATCH for-next 1/6] IB/hns: Fix the bug when destroy qp

2016-11-29 Thread Salil Mehta
try and push it into the workqueue, Work function will finish checking and release the related resources later. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Lijun Ou Signed-off-by: Dongdong Huang(Donald) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_common.h | 40 +++ dri

[PATCH for-next 4/6] IB/hns: Delete the redundant memset operation

2016-11-29 Thread Salil Mehta
From: "Wei Hu (Xavier)" It deleted the redundant memset operation because the memory allocated by ib_alloc_device has been set zero. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_main.c |3 --- 1 file changed, 3 deletions(-)

[PATCH for-next 2/6] IB/hns: Fix the bug when free mr

2016-11-29 Thread Salil Mehta
ensure zero wqe when free mr. When the mac address is reset, in order to avoid loopback failure, we need to release the reserved loopback QPs and recreate them. Signed-off-by: Shaobo Xu Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_cmd.h|5

[PATCH for-next 0/6] IB/hns: Bug Fixes for HNS RoCE Driver

2016-11-29 Thread Salil Mehta
This patch-set contains bug fixes for the HNS RoCE driver. Lijun Ou (1): IB/hns: Fix the IB device name Shaobo Xu (2): IB/hns: Fix the bug when free mr IB/hns: Fix the bug when free cq Wei Hu (Xavier) (3): IB/hns: Fix the bug when destroy qp IB/hns: Fix the bug of setting port mtu IB

[PATCH for-next 3/6] IB/hns: Fix the bug of setting port mtu

2016-11-29 Thread Salil Mehta
From: "Wei Hu (Xavier)" In hns_roce driver, we need not call iboe_get_mtu to reduce IB headers from effective IBoE MTU because hr_dev->caps.max_mtu has already been reduced. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_

[PATCH V2 net-next] net: hns: Fix to conditionally convey RX checksum flag to stack

2016-11-29 Thread Salil Mehta
r other error for this packet. 2b. If above errors do not exists, then we set checksum un-necessary for upper layers. Signed-off-by: Salil Mehta --- Change Log: Patch V2: Addressed the comment by David Miller Link: https://www.spinics.net/lists/netdev/msg406697.html Patch V1

RE: [PATCH net-next] net: hns: Fix to conditionally convey RX checksum flag to stack

2016-11-29 Thread Salil Mehta
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, November 28, 2016 5:13 PM > To: Salil Mehta > Cc: Zhuangyuzeng (Yisen); mehta.salil@gmail.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm > Subject: Re:

[PATCH net-next] net: hns: Fix to conditionally convey RX checksum flag to stack

2016-11-25 Thread Salil Mehta
in the HNS hardware. 2b. If above errors do not exists, then we set checksum un-necessary for upper layers. Signed-off-by: Salil Mehta --- Change Log: Patch V1: This patch is a result of the comments given by David Miller Link: https://lkml.org/lkml/2016/6/15/27

[PATCH V3 for-next 00/11] Code improvements & fixes for HNS RoCE driver

2016-11-23 Thread Salil Mehta
state in hns_roce_v1_m_qp() Salil Mehta (1): IB/hns: Fix for Checkpatch.pl comment style errors Shaobo Xu (1): IB/hns: Implement the add_gid/del_gid and optimize the GIDs management Wei Hu (Xavier) (5): IB/hns: Add code for refreshing CQ CI using TPTR IB/hns: Optimize the logic of

[PATCH V3 for-next 01/11] IB/hns: Add the interface for querying QP1

2016-11-23 Thread Salil Mehta
From: Lijun Ou In old code, It only added the interface for querying non-specific QP. This patch mainly adds an interface for querying QP1. Signed-off-by: Lijun Ou Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- Change Log Patch V2: Addressed the comment provided by Anurup M

[PATCH V3 for-next 04/11] IB/hns: add self loopback for CM

2016-11-23 Thread Salil Mehta
From: Lijun Ou This patch mainly adds self loopback support for CM. Signed-off-by: Lijun Ou Signed-off-by: Peter Chen Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 11 +++ drivers/infiniband/hw/hns/hns_roce_hw_v1.h

[PATCH V3 for-next 06/11] IB/hns: Fix the bug for qp state in hns_roce_v1_m_qp()

2016-11-23 Thread Salil Mehta
From: Lijun Ou In old code, the value of qp state from qpc was assigned for attr->qp_state. The value may be an error while attr_mask & IB_QP_STATE is zero. Signed-off-by: Lijun Ou Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c

[PATCH V3 for-next 07/11] IB/hns: Modify the macro for the timeout when cmd process

2016-11-23 Thread Salil Mehta
}; After modification: #define HNS_ROCE_CMD_TIMEOUT_MSECS 1 Signed-off-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_cmd.h |7 +-- drivers/infiniband/hw/hns/hns_roce_cq.c|4 ++-- drivers/infiniband/hw/hns/hns_roce_hw_v

[PATCH V3 for-next 09/11] IB/hns: Change qpn allocation to round-robin mode.

2016-11-23 Thread Salil Mehta
ode for qp number and non round-robing mode for other resources like cq number, pd number etc. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_alloc.c | 11 +++ drivers/infiniband/hw/hns/hns_roce_cq.c |4 ++-- drivers/infinib

[PATCH V3 for-next 08/11] IB/hns: Modify query info named port_num when querying RC QP

2016-11-23 Thread Salil Mehta
From: "Wei Hu (Xavier)" This patch modified the output query info qp_attr->port_num to fix bug in hip06. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --

[PATCH V3 for-next 11/11] IB/hns: Fix for Checkpatch.pl comment style errors

2016-11-23 Thread Salil Mehta
This patch correct the comment style errors caught by checkpatch.pl script Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_cmd.c|8 ++-- drivers/infiniband/hw/hns/hns_roce_device.h | 28 ++--- drivers/infiniband/hw/hns/hns_roce_eq.c |6 +-- drivers

[PATCH V3 for-next 10/11] IB/hns: Implement the add_gid/del_gid and optimize the GIDs management

2016-11-23 Thread Salil Mehta
/del_gid to set the GIDs in the RoCE driver, remove the redundant calculation and management of GIDs in the notifier call of the net device and the inet, and update the query_gid. Signed-off-by: Shaobo Xu Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns

[PATCH V3 for-next 05/11] IB/hns: Modify the condition of notifying hardware loopback

2016-11-23 Thread Salil Mehta
the smac of the local port N or the loop_idc is 1, we should set loopback bit in QP context to notify hardware. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Lijun Ou Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 24 +++- 1 file changed, 7

[PATCH V3 for-next 02/11] IB/hns: Add code for refreshing CQ CI using TPTR

2016-11-23 Thread Salil Mehta
ang(Donald) Signed-off-by: Lijun Ou Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_common.h |2 - drivers/infiniband/hw/hns/hns_roce_cq.c |9 +++ drivers/infiniband/hw/hns/hns_roce_device.h |6 +- drivers/infiniband/hw/hns/hns_roce_hw_v1

[PATCH V3 for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

2016-11-23 Thread Salil Mehta
ned-off-by: Salil Mehta --- Change log: PATCH V2: Addressed comment given by Leon Link: https://patchwork.kernel.org/patch/9412859/ PATCH V1: Initial Submit --- drivers/infiniband/hw/hns/hns_roce_mr.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git

RE: [PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

2016-11-21 Thread Salil Mehta
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > Sent: Monday, November 21, 2016 5:14 PM > To: Salil Mehta > Cc: dledf...@redhat.com; Huwei (Xavier); oulijun; > mehta.salil..

RE: [PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

2016-11-21 Thread Salil Mehta
> -Original Message- > From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Wednesday, November 16, 2016 8:36 AM > To: Salil Mehta > Cc: dledf...@redhat.com; Huwei (Xavier); oulijun; > mehta.salil@gmail.com; linux-r...@vger.kernel.org; > net...@vger.ker

[PATCH V2 for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

2016-11-15 Thread Salil Mehta
ned-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_mr.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c index fb87883..d3dfb5f 100644 --- a/drivers/infinib

[PATCH V2 for-next 08/11] IB/hns: Modify query info named port_num when querying RC QP

2016-11-15 Thread Salil Mehta
From: "Wei Hu (Xavier)" This patch modified the output query info qp_attr->port_num to fix bug in hip06. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --

[PATCH V2 for-next 07/11] IB/hns: Modify the macro for the timeout when cmd process

2016-11-15 Thread Salil Mehta
}; After modification: #define HNS_ROCE_CMD_TIMEOUT_MSECS 1 Signed-off-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_cmd.h |7 +-- drivers/infiniband/hw/hns/hns_roce_cq.c|4 ++-- drivers/infiniband/hw/hns/hns_roce_hw_v

[PATCH V2 for-next 01/11] IB/hns: Add the interface for querying QP1

2016-11-15 Thread Salil Mehta
From: Lijun Ou In old code, It only added the interface for querying non-specific QP. This patch mainly adds an interface for querying QP1. Signed-off-by: Lijun Ou Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- Change Log Patch V2: Addressed the comment provided by Anurup M

[PATCH V2 for-next 11/11] IB/hns: Fix for Checkpatch.pl comment style errors

2016-11-15 Thread Salil Mehta
This patch correct the comment style errors caught by checkpatch.pl script Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_cmd.c|8 ++-- drivers/infiniband/hw/hns/hns_roce_device.h | 28 ++--- drivers/infiniband/hw/hns/hns_roce_eq.c |6 +-- drivers

[PATCH V2 for-next 04/11] IB/hns: add self loopback for CM

2016-11-15 Thread Salil Mehta
From: Lijun Ou This patch mainly adds self loopback support for CM. Signed-off-by: Lijun Ou Signed-off-by: Peter Chen Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 11 +++ drivers/infiniband/hw/hns/hns_roce_hw_v1.h

[PATCH V2 for-next 10/11] IB/hns: Implement the add_gid/del_gid and optimize the GIDs management

2016-11-15 Thread Salil Mehta
/del_gid to set the GIDs in the RoCE driver, remove the redundant calculation and management of GIDs in the notifier call of the net device and the inet, and update the query_gid. Signed-off-by: Shaobo Xu Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns

[PATCH V2 for-next 05/11] IB/hns: Modify the condition of notifying hardware loopback

2016-11-15 Thread Salil Mehta
the smac of the local port N or the loop_idc is 1, we should set loopback bit in QP context to notify hardware. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Lijun Ou Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 24 +++- 1 file changed, 7

[PATCH V2 for-next 00/11] Code improvements & fixes for HNS RoCE driver

2016-11-15 Thread Salil Mehta
state in hns_roce_v1_m_qp() Salil Mehta (1): IB/hns: Fix for Checkpatch.pl comment style errors Shaobo Xu (1): IB/hns: Implement the add_gid/del_gid and optimize the GIDs management Wei Hu (Xavier) (5): IB/hns: Add code for refreshing CQ CI using TPTR IB/hns: Optimize the logic of

[PATCH V2 for-next 02/11] IB/hns: Add code for refreshing CQ CI using TPTR

2016-11-15 Thread Salil Mehta
ang(Donald) Signed-off-by: Lijun Ou Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_common.h |2 - drivers/infiniband/hw/hns/hns_roce_cq.c |9 +++ drivers/infiniband/hw/hns/hns_roce_device.h |6 +- drivers/infiniband/hw/hns/hns_roce_hw_v1

[PATCH V2 for-next 09/11] IB/hns: Change qpn allocation to round-robin mode.

2016-11-15 Thread Salil Mehta
ode for qp number and non round-robing mode for other resources like cq number, pd number etc. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_alloc.c | 11 +++ drivers/infiniband/hw/hns/hns_roce_cq.c |4 ++-- drivers/infinib

[PATCH V2 for-next 06/11] IB/hns: Fix the bug for qp state in hns_roce_v1_m_qp()

2016-11-15 Thread Salil Mehta
From: Lijun Ou In old code, the value of qp state from qpc was assigned for attr->qp_state. The value may be an error while attr_mask & IB_QP_STATE is zero. Signed-off-by: Lijun Ou Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c

RE: [PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

2016-11-15 Thread Salil Mehta
> -Original Message- > From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Wednesday, November 09, 2016 7:22 AM > To: Salil Mehta > Cc: dledf...@redhat.com; Huwei (Xavier); oulijun; > mehta.salil@gmail.com; linux-r...@vger.kernel.org; > net...@vger.ker

[PATCH net-next 00/17] Bug fixes & Code improvements in HNS driver

2016-11-09 Thread Salil Mehta
This patch-set introduces some bug fixes and code improvements. These have been identified during internal review or testing of the driver by internal Hisilicon teams. Daode Huang (3): net: hns: set default mac pause time to 0x net: hns: bug fix about restart auto-negotiation net: hns: f

[PATCH net-next 17/17] net: hns: add the support to add/remove the ucast entry to/from table

2016-11-09 Thread Salil Mehta
From: Kejian Yan This patch adds the support to add or remove the unicast entries to the table and remove from the table. Reported-by: Daode Huang Signed-off-by: Kejian Yan Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hnae.h |8

[PATCH net-next 02/17] net: hns: add fuzzy match of tcam table for hns

2016-11-09 Thread Salil Mehta
Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 16 ++- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h |8 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 140 ++-- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h |6

[PATCH net-next 03/17] net: hns: fix for promisc mode in HNS driver

2016-11-09 Thread Salil Mehta
-off-by: Kejian Yan Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c |2 + drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 63 ++-- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h |3 + drivers/net/ethernet

[PATCH net-next 12/17] net: hns: modify table index to get mac entry

2016-11-09 Thread Salil Mehta
From: Qianqian Xie Big-endian is not supported by the current definition of table index to get mac entry. It needs to be modified to support both Little-endian and Big-endian. Signed-off-by: Qianqian Xie Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon

[PATCH net-next 01/17] Doc: hisi: hns adds mc-mac-mask property

2016-11-09 Thread Salil Mehta
Zhuang Signed-off-by: Salil Mehta --- .../devicetree/bindings/net/hisilicon-hns-dsaf.txt |8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt index d4b7f2e

[PATCH net-next 16/17] net: hns: add multicast tcam table clear

2016-11-09 Thread Salil Mehta
From: Kejian Yan There is no clear operation before add a new multicast tcam table, so the tcam table will be overflow when add more entries. Reported-by: Daode Huang Signed-off-by: Kejian Yan Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns

[PATCH net-next 09/17] net: hns: modify buffer format of cpu data to le64

2016-11-09 Thread Salil Mehta
From: Qianqian Xie Hardware ring buffer data is stored in Little-endian. Thus cpu data should be modified to Little-endian. Signed-off-by: Qianqian Xie Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hnae.h |6 +++--- 1 file changed, 3

[PATCH net-next 08/17] net: hns: fix to intimate the link-status change by adding LF/RF method

2016-11-09 Thread Salil Mehta
interface changes. This patch also removes the existing hns_dsaf_xge_core_srst_by_port function which was being used to reset the RX/TX functionality at XGE Core. Reported-by: Jun He Signed-off-by: Daode Huang Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon

[PATCH net-next 07/17] net: hns: modify ethtool statistics value error

2016-11-09 Thread Salil Mehta
From: Qianqian Xie This patch modify the gmac_rx_filt_pkt and gmac_rx_octets_total_filt statistics value. The two statistics is inconsistent with register, and just the opposite. Signed-off-by: Qianqian Xie Signed-off-by: Jun He Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta

[PATCH net-next 06/17] net: hns: delete redundant macro definition

2016-11-09 Thread Salil Mehta
From: Qianqian Xie This patch deletes redundant macro definitions in hns drivers. And change the .h file containing relation to make the layers more clearly Signed-off-by: Qianqian Xie Signed-off-by: Weiwei Deng Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet

[PATCH net-next 13/17] net: hns: modify tcam table of mac mc-port

2016-11-09 Thread Salil Mehta
From: Qianqian Xie Little-endian is only supported by current tcam table to add or delete mac mc-port. This patch makes it support both Little-endian and Big-endian. Signed-off-by: Qianqian Xie Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns

[PATCH net-next 10/17] net: hns: modify tcam table and set mac key

2016-11-09 Thread Salil Mehta
: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 16 drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h | 13 - 2 files changed, 20 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns

[PATCH net-next 15/17] net: hns: modify tcam table of mask_key

2016-11-09 Thread Salil Mehta
-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c index 74ca53d..250e4a1 100644 --- a/drivers/net/ethernet

[PATCH net-next 11/17] net: hns: modify tcam table of mac uc-entry

2016-11-09 Thread Salil Mehta
From: Qianqian Xie The current definition of mac_uc_entry is only suitable for Little-endian. Thus it needs to modify tcam table of mac uc-entry to support both Little-endian and Big-endian. Signed-off-by: Qianqian Xie Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net

[PATCH net-next 14/17] net: hns: modify tcam table of mac mc-entry

2016-11-09 Thread Salil Mehta
From: Qianqian Xie The current definition of mac_mc_entry is only suitable for Little-endian. Thus it needs to modify tcam table of mac mc-entry to support both Little-endian and Big-endian. Signed-off-by: Qianqian Xie Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net

[PATCH net-next 04/17] net: hns: set default mac pause time to 0xffff

2016-11-09 Thread Salil Mehta
From: Daode Huang The default mac pause time set to 0xff which is too short for pausing, this patch change it to the max value 0x. Signed-off-by: Daode Huang Reviewed-by: Yisen Zhuang Reviewed-by: lipeng Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h

[PATCH net-next 05/17] net: hns: bug fix about restart auto-negotiation

2016-11-09 Thread Salil Mehta
Signed-off-by: Daode Huang Reviewed-by: Yisen Zhuang Reviewed-by: lipeng Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/ne

RE: [PATCH for-next 01/11] IB/hns: Add the interface for querying QP1

2016-11-07 Thread Salil Mehta
> -Original Message- > From: Anurup m > Sent: Monday, November 07, 2016 5:46 AM > To: Salil Mehta; dledf...@redhat.com > Cc: linux-r...@vger.kernel.org; net...@vger.kernel.org; > mehta.salil@gmail.com; linux-kernel@vger.kernel.org; Linuxarm > Subject: Re: [PAT

[PATCH for-next 00/11] Code improvements & fixes for HNS RoCE driver

2016-11-04 Thread Salil Mehta
state in hns_roce_v1_m_qp() Salil Mehta (1): IB/hns: Fix for Checkpatch.pl comment style errors Shaobo Xu (1): IB/hns: Implement the add_gid/del_gid and optimize the GIDs management Wei Hu (Xavier) (5): IB/hns: Add code for refreshing CQ CI using TPTR IB/hns: Optimize the logic of

[PATCH for-next 07/11] IB/hns: Modify the macro for the timeout when cmd process

2016-11-04 Thread Salil Mehta
}; After modification: #define HNS_ROCE_CMD_TIMEOUT_MSECS 1 Signed-off-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_cmd.h |7 +-- drivers/infiniband/hw/hns/hns_roce_cq.c|4 ++-- drivers/infiniband/hw/hns/hns_roce_hw_v

[PATCH for-next 02/11] IB/hns: Add code for refreshing CQ CI using TPTR

2016-11-04 Thread Salil Mehta
ang(Donald) Signed-off-by: Lijun Ou Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_common.h |2 - drivers/infiniband/hw/hns/hns_roce_cq.c |9 +++ drivers/infiniband/hw/hns/hns_roce_device.h |6 +- drivers/infiniband/hw/hns/hns_roce_hw_v1

[PATCH for-next 11/11] IB/hns: Fix for Checkpatch.pl comment style errors

2016-11-04 Thread Salil Mehta
This patch correct the comment style errors caught by checkpatch.pl script Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_cmd.c|8 ++-- drivers/infiniband/hw/hns/hns_roce_device.h | 28 +++--- drivers/infiniband/hw/hns/hns_roce_eq.c |6 +-- drivers

[PATCH for-next 10/11] IB/hns: Implement the add_gid/del_gid and optimize the GIDs management

2016-11-04 Thread Salil Mehta
/del_gid to set the GIDs in the RoCE driver, remove the redundant calculation and management of GIDs in the notifier call of the net device and the inet, and update the query_gid. Signed-off-by: Shaobo Xu Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns

[PATCH for-next 09/11] IB/hns: Change qpn allocation to round-robin mode.

2016-11-04 Thread Salil Mehta
ode for qp number and non round-robing mode for other resources like cq number, pd number etc. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_alloc.c | 11 +++ drivers/infiniband/hw/hns/hns_roce_cq.c |4 ++-- drivers/infinib

[PATCH for-next 08/11] IB/hns: Modify query info named port_num when querying RC QP

2016-11-04 Thread Salil Mehta
From: "Wei Hu (Xavier)" This patch modified the output query info qp_attr->port_num to fix bug in hip06. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --

[PATCH for-next 06/11] IB/hns: Fix the bug for qp state in hns_roce_v1_m_qp()

2016-11-04 Thread Salil Mehta
From: Lijun Ou In old code, the value of qp state from qpc was assigned for attr->qp_state. The value may be an error while attr_mask & IB_QP_STATE is zero. Signed-off-by: Lijun Ou Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c

[PATCH for-next 04/11] IB/hns: add self loopback for CM

2016-11-04 Thread Salil Mehta
From: Lijun Ou This patch mainly adds self loopback support for CM. Signed-off-by: Lijun Ou Signed-off-by: Peter Chen Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 11 +++ drivers/infiniband/hw/hns/hns_roce_hw_v1.h

[PATCH for-next 05/11] IB/hns: Modify the condition of notifying hardware loopback

2016-11-04 Thread Salil Mehta
the smac of the local port N or the loop_idc is 1, we should set loopback bit in QP context to notify hardware. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Lijun Ou Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 24 +++- 1 file changed, 7

[PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

2016-11-04 Thread Salil Mehta
ned-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_mr.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c index fb87883..d3dfb5f 100644 --- a/drivers/infinib

[PATCH for-next 01/11] IB/hns: Add the interface for querying QP1

2016-11-04 Thread Salil Mehta
From: Lijun Ou In old code, It only added the interface for querying non-specific QP. This patch mainly adds an interface for querying QP1. Signed-off-by: Lijun Ou Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 87

RE: [PATCH V2 for-next 0/8] Bug Fixes and Code Improvement in HNS driver

2016-10-13 Thread Salil Mehta
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, September 30, 2016 6:34 AM > To: Salil Mehta > Cc: dledf...@redhat.com; Zhuangyuzeng (Yisen); Huwei (Xavier); oulijun; > mehta.salil@gmail.com; linux-r...@vger.kernel.org; > n

RE: [PATCH for-next 0/8] Bug Fixes and Code Improvement in HNS driver

2016-09-29 Thread Salil Mehta
> Hi Salil, > > I've chatted with Dave Miller about this series. Here's where we > stand. > > First, the review feedback from Dave: > > --- > > In patch #7, their comments are mis-formatted and these > hns guys do this a lot. > > /*fix hardware broadcast/multicast packets queue loopback

[PATCH V2 for-next 4/8] net: hns: delete repeat read fbd num after while

2016-09-29 Thread Salil Mehta
From: Daode Huang Because we handle the received packets after napi, so delete the checking before submitting. It delete the code of read the fbd number register, which reduces the cpu usages while receiving packets Signed-off-by: Daode Huang Reviewed-by: Yisen Zhuang Signed-off-by: Salil

[PATCH V2 for-next 6/8] net: hns: fix the bug of forwarding table

2016-09-29 Thread Salil Mehta
d-off-by: Daode Huang Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- PATCH V2: Addressed comments by David Miller Link: https://lkml.org/lkml/2016/9/28/390 PATCH V1: Initial Submit --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c |8 ++-- drivers/net/ethernet/hisi

[PATCH V2 for-next 7/8] net: hns: bug fix about broadcast/multicast packets

2016-09-29 Thread Salil Mehta
select queue 0 to send broadcast and multicast packets. Signed-off-by: Daode Huang Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- PATCH v2: Addressed comments by David Miller Link: https://lkml.org/lkml/2016/9/28/390 PATCH V1: Initial Submit --- drivers/net/ethernet/hisilicon

[PATCH V2 for-next 8/8] net: hns: delete redundant broadcast packet filter process

2016-09-29 Thread Salil Mehta
From: Daode Huang The broadcast packets is filtered in the hardware now, so this process is no need in the driver, just delete it. Signed-off-by: Daode Huang Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 10 -- 1 file

[PATCH V2 for-next 2/8] net: hns: bug fix about setting coalsecs-usecs to 0

2016-09-29 Thread Salil Mehta
-off-by: Daode Huang Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 16 drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h |4 2 files changed, 20 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns

<    1   2   3   4   5   6   7   >