Re: [PATCH] ASoC: simple-card: fix possible uninitialized single_cpu local variable

2021-04-07 Thread Sameer Pujar
+- sound/soc/generic/simple-card.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Acked-by: Sameer Pujar

Re: [PATCH v2] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes

2021-03-29 Thread Sameer Pujar
exists. Cc: Liam Girdwood Cc: Mark Brown Cc: Thierry Reding Cc: Jonathan Hunter Cc: Sameer Pujar Cc: alsa-de...@alsa-project.org Cc: linux-te...@vger.kernel.org Signed-off-by: Rob Herring --- v2: - Also add 'dspk' child node This patch ideally should be applied before this series[1]. [1

Re: [PATCH] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes

2021-03-24 Thread Sameer Pujar
). Add the child nodes and reference their schema if one exists. Cc: Liam Girdwood Cc: Mark Brown Cc: Thierry Reding Cc: Jonathan Hunter Cc: Sameer Pujar Cc: alsa-de...@alsa-project.org Cc: linux-te...@vger.kernel.org Signed-off-by: Rob Herring --- This patch ideally should be applied before

[PATCH v2] arm64: tegra: Move clocks from RT5658 endpoint to device node

2021-03-15 Thread Sameer Pujar
avier") Suggested-by: Rob Herring Signed-off-by: Sameer Pujar --- Changelog: v1 -> v2: Added "clock-names" property as rt5659 driver specifically looks for this clock name. arch/arm64/boot/dts/nvidia/tegra194-p2972-.dts | 3 ++- 1 file changed, 2 insertions(

[PATCH 2/2] ASoC: rt5659: Update MCLK rate in set_sysclk()

2021-03-15 Thread Sameer Pujar
-by: Sameer Pujar --- sound/soc/codecs/rt5659.c | 5 + 1 file changed, 5 insertions(+) diff --git a/sound/soc/codecs/rt5659.c b/sound/soc/codecs/rt5659.c index b787515..0af9601 100644 --- a/sound/soc/codecs/rt5659.c +++ b/sound/soc/codecs/rt5659.c @@ -3430,12 +3430,17 @@ static int

[PATCH 1/2] ASoC: simple-card-utils: Do not handle device clock

2021-03-15 Thread Sameer Pujar
: Fix device module clock") Signed-off-by: Sameer Pujar --- sound/soc/generic/simple-card-utils.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c index ab31045..6cada4c 100644 --- a

[PATCH 0/2] Do not handle MCLK device clock in simple-card-utils

2021-03-15 Thread Sameer Pujar
et_sysclk() callback and card driver need not actually update MCLK rate. Instead, codec can take ownership of this clock and do the necessary configuration. So the original commit is reverted and codec driver for rt5659 is updated to fix my board which has this codec. Sameer Pujar (2): ASoC: s

Re: Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock

2021-03-15 Thread Sameer Pujar
Yes this is a problem, unfortunately I missed checking some of the simple-card examples. I wonder we should be specifically looking for "mclk" clock here. That would definitely help mitigate the problem but I really think it's cleaner and safer to just push this down to set_sysclk().

Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock

2021-03-15 Thread Sameer Pujar
On 3/15/2021 9:03 PM, Michael Walle wrote: Am 2021-03-15 16:19, schrieb Sameer Pujar: On 3/15/2021 5:35 PM, Michael Walle wrote: Am 2021-03-12 14:46, schrieb Mark Brown: On Fri, Mar 12, 2021 at 01:30:02PM +0100, Michael Walle wrote: The card calls set_sysclk(), which eventually ends up

Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock

2021-03-15 Thread Sameer Pujar
On 3/15/2021 5:35 PM, Michael Walle wrote: External email: Use caution opening links or attachments Am 2021-03-12 14:46, schrieb Mark Brown: On Fri, Mar 12, 2021 at 01:30:02PM +0100, Michael Walle wrote: The card calls set_sysclk(), which eventually ends up in the codec. The codec

Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock

2021-03-11 Thread Sameer Pujar
On 3/11/2021 4:46 PM, Michael Walle wrote: Am 2021-03-11 12:05, schrieb Sameer Pujar: It would work and initially I had similar patch, see [0] and related series. Suggestion is to always use "clocks" property with devices only. I see. But again, I don't think it is correct

Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock

2021-03-11 Thread Sameer Pujar
On 3/11/2021 3:57 PM, Michael Walle wrote: I've had a closer look at this and it seems you're messing around with the clock of the codec's node (which is _not_ a subnode of the simple-audio-card). I don't think this is correct. I guess you should rather set the clock property in the codec

Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock

2021-03-10 Thread Sameer Pujar
On 3/10/2021 11:44 PM, Michael Walle wrote: Btw I'm pretty sure, the MCLK was enabled and disabled depending on whether there was an audio stream, the last time I've measured the clock. This may be true in your case because wm8904 driver does an explicit clock enable/disable and does not

Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock

2021-03-10 Thread Sameer Pujar
On 3/10/2021 4:00 AM, Michael Walle wrote: Am 2021-03-09 17:27, schrieb Sameer Pujar: On 3/9/2021 8:11 PM, Michael Walle wrote: If "clocks = <>" is specified from the CPU or Codec component device node, the clock is not getting enabled. Thus audio playback or cap

Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock

2021-03-09 Thread Sameer Pujar
is by populating "simple_dai->clk" field when clocks property is specified from device node as well. Also tidy up by re-organising conditional statements of parsing logic. Fixes: bb6fc620c2ed ("ASoC: simple-card-utils: add asoc_simple_card_parse_clk()") Cc: Kuninori Morimoto Sign

Re: [RFC PATCH 3/5] ASoC: audio-graph-card: Add bindings for sysclk and pll

2021-03-02 Thread Sameer Pujar
On 3/2/2021 7:40 AM, Rob Herring wrote: External email: Use caution opening links or attachments On Thu, Feb 25, 2021 at 12:06 PM Sameer Pujar wrote: ASoC core provides callbacks snd_soc_dai_set_sysclk() and snd_soc_dai_set_pll() for system clock (sysclk) and pll configurations

Re: [RFC PATCH 0/5] Flexible sysclk/pll configuration

2021-02-25 Thread Sameer Pujar
On 2/25/2021 11:35 PM, Sameer Pujar wrote: This series attempts to add flexible system clock (sysclk) and pll configuration for the DAI controller from simple card or audio graph card. Sysclk configuration Motivation: --- The problem this tries

[RFC PATCH 5/5] ASoC: simple-card-utils: Support pll configuration

2021-02-25 Thread Sameer Pujar
ted at runtime. */ pll-input-reference = <2>; /* * pll will generate output rate based on MCLK, which is * calculated at runtime as (mclk_fs * sample rate). */ pll-output-reference = <1>; /* MCLK as output rate */

[RFC PATCH 0/5] Flexible sysclk/pll configuration

2021-02-25 Thread Sameer Pujar
uot;pll-output-frequency" All these are optional properties. Simple card or audio graph card drivers can use above info and call snd_soc_dai_set_pll() for necessary configuration. Sameer Pujar (5): ASoC: soc-component: Fix return value of snd_soc_component_set_pll() ASoC: soc-dai: Add

[RFC PATCH 4/5] ASoC: simple-card-utils: Parse sysclk id and source

2021-02-25 Thread Sameer Pujar
system-clock-source = <...>; ... }; The default sysclk id and source are 0 in the driver and hence nothing needs to be specified if default values are good enough. Cc: Kuninori Morimoto Signed-off-by: Sameer Pujar --- include/sound/simple_card_utils.h | 2 ++ sound/soc/

[RFC PATCH 1/5] ASoC: soc-component: Fix return value of snd_soc_component_set_pll()

2021-02-25 Thread Sameer Pujar
uot;ASoC: error at snd_soc_dai_set_pll on xxx: -22" Above is not necessary because a component may not need additional configuration and chooses to not implement this. Fix this by changing default return value to "-ENOTSUPP" and driver code which invokes snd_soc_component_set_pll() can ignore this

[RFC PATCH 3/5] ASoC: audio-graph-card: Add bindings for sysclk and pll

2021-02-25 Thread Sameer Pujar
codings in driver and makes it more generic. Also add system-clock related bindings, "system-clock-direction-out" and "system-clock-frequency", which are already supported. Cc: Kuninori Morimoto Cc: Rob Herring Signed-off-by: Sameer Pujar --- .../bindings/sound/a

Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock

2021-02-14 Thread Sameer Pujar
Hi Morimoto-san, On 2/12/2021 5:14 AM, Kuninori Morimoto wrote: diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c index bc0b62e..0754d70 100644 --- a/sound/soc/generic/simple-card-utils.c +++ b/sound/soc/generic/simple-card-utils.c @@ -173,16 +173,15

[PATCH 2/3] Revert "ASoC: audio-graph-card: Add clocks property to endpoint node"

2021-02-09 Thread Sameer Pujar
An endpoint is not a device and it is recommended to use clocks property in the device node. Hence reverting the original change. Fixes: 531e5b7abbde ("ASoC: audio-graph-card: Add clocks property to endpoint node") Suggested-by: Rob Herring Cc: Kuninori Morimoto Signed-off-by: Sa

[PATCH 3/3] arm64: tegra: Move clocks from RT5658 endpoint to device node

2021-02-09 Thread Sameer Pujar
avier") Suggested-by: Rob Herring Signed-off-by: Sameer Pujar --- arch/arm64/boot/dts/nvidia/tegra194-p2972-.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2972-.dts b/arch/arm64/boot/dts/nvidia/tegra194-p2972-.dts ind

[PATCH 0/3] Use clocks property in a device node

2021-02-09 Thread Sameer Pujar
to be a bug in simple-card-utils.c where clock handle is not assigned when parsing clocks from device node. Fix the same and revert original change which actually added clocks property in endpoint subnode. Also update Jetson AGX Xavier DT where the usage is found. Sameer Pujar (3): ASoC: simple

[PATCH 1/3] ASoC: simple-card-utils: Fix device module clock

2021-02-09 Thread Sameer Pujar
by re-organising conditional statements of parsing logic. Fixes: bb6fc620c2ed ("ASoC: simple-card-utils: add asoc_simple_card_parse_clk()") Cc: Kuninori Morimoto Signed-off-by: Sameer Pujar --- sound/soc/generic/simple-card-utils.c | 13 ++--- 1 file changed, 6 insertions(+),

[PATCH v3 2/2] ASoC: tegra: Add driver remove() callback

2021-02-07 Thread Sameer Pujar
ort" Signed-off-by: Sameer Pujar Acked-by: Kuninori Morimoto --- sound/soc/tegra/tegra_audio_graph_card.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/tegra/tegra_audio_graph_card.c b/sound/soc/tegra/tegra_audio_graph_card.c index 121e572..ddedf18 100644 -

[PATCH v3 1/2] ASoC: audio-graph: Rename functions needed for export

2021-02-07 Thread Sameer Pujar
gra audio graph card drivers. Signed-off-by: Sameer Pujar Cc: Kuninori Morimoto Acked-by: Kuninori Morimoto --- include/sound/graph_card.h | 6 -- sound/soc/generic/audio-graph-card.c | 17 + sound/soc/tegra/tegra_audio_graph_card.c | 6 +++--- 3 files ch

[PATCH v3 0/2] Rename audio graph export functions

2021-02-07 Thread Sameer Pujar
audio_graph_card_probe() as well. - Update above references in audio graph driver. [Patch v2 2/3]: New patch - Update references for audio_graph_parse_of() and audio_graph_card_probe() in Tegra graph driver. - Add "Depends-on" tag [Patch v2 3/3]: - Update commit me

[PATCH v2 1/3] ASoC: audio-graph: Rename functions needed for export

2021-02-04 Thread Sameer Pujar
e updated to make use of above. Signed-off-by: Sameer Pujar Cc: Kuninori Morimoto --- include/sound/graph_card.h | 6 -- sound/soc/generic/audio-graph-card.c | 17 + 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/include/sound/graph_card.h b/incl

[PATCH v2 3/3] ASoC: tegra: Add driver remove() callback

2021-02-04 Thread Sameer Pujar
ort" Signed-off-by: Sameer Pujar --- sound/soc/tegra/tegra_audio_graph_card.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/tegra/tegra_audio_graph_card.c b/sound/soc/tegra/tegra_audio_graph_card.c index 121e572..ddedf18 100644 --- a/sound/soc/tegra/tegra_audi

[PATCH v2 2/3] ASoC: tegra: Update references of audio graph helpers

2021-02-04 Thread Sameer Pujar
The audio graph helper functions are renamed now for a better global visibility and hence references need to be updated in Tegra audio graph. Signed-off-by: Sameer Pujar --- sound/soc/tegra/tegra_audio_graph_card.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound

[PATCH v2 0/3] Rename audio graph export functions

2021-02-04 Thread Sameer Pujar
: - Update commit message to add "Depends-on" tag. Sameer Pujar (3): ASoC: audio-graph: Rename functions needed for export ASoC: tegra: Update references of audio graph helpers ASoC: tegra: Add driver remove() callback include/sound/graph_card.h | 6 -- sound/

Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function

2021-02-03 Thread Sameer Pujar
On 2/4/2021 4:03 AM, Kuninori Morimoto wrote: External email: Use caution opening links or attachments Hi +int graph_remove(struct platform_device *pdev); I think this needs better namespacing if it's going to be exported. audio_graph_remove() can be a better choice? Yeah, that looks

Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function

2021-02-03 Thread Sameer Pujar
On 2/4/2021 4:01 AM, Kuninori Morimoto wrote: Audio graph based sound card drivers can call graph_remove() function for cleanups during driver removal. To facilitate this export above mentioned function. Signed-off-by: Sameer Pujar Cc: Kuninori Morimoto (snip) -static int graph_remove

Re: Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function

2021-02-03 Thread Sameer Pujar
On 2/3/2021 9:49 PM, Mark Brown wrote: On Wed, Feb 03, 2021 at 09:39:34PM +0530, Sameer Pujar wrote: +int graph_remove(struct platform_device *pdev); I think this needs better namespacing if it's going to be exported. audio_graph_remove() can be a better choice?

[PATCH 1/2] ASoC: audio-graph: Export graph_remove() function

2021-02-03 Thread Sameer Pujar
Audio graph based sound card drivers can call graph_remove() function for cleanups during driver removal. To facilitate this export above mentioned function. Signed-off-by: Sameer Pujar Cc: Kuninori Morimoto --- include/sound/graph_card.h | 2 ++ sound/soc/generic/audio-graph-card.c

[PATCH 2/2] ASoC: tegra: Add driver remove() callback

2021-02-03 Thread Sameer Pujar
There is cleanup required, related to release of phandles, during driver removal and hence point remove function pointer to graph_remove(). Fixes: 202e2f774543 ("ASoC: tegra: Add audio graph based card driver") Signed-off-by: Sameer Pujar --- sound/soc/tegra/tegra_audio_graph_card.c

[PATCH 0/2] Add remove path for Tegra audio graph card

2021-02-03 Thread Sameer Pujar
Audio graph driver cleans up phandle references of CPU/CODEC nodes in graph_remove() path. As Tegra graph card driver is based on this populate remove callback for it. Sameer Pujar (2): ASoC: audio-graph: Export graph_remove() function ASoC: tegra: Add driver remove() callback include/sound

[RESEND PATCH v2 5/9] arm64: defconfig: Enable RT5659

2021-02-02 Thread Sameer Pujar
Enable the RT5659 audio codec driver. Signed-off-by: Sameer Pujar Cc: Oder Chiou Cc: Bard Liao --- Resending this as I missed the maintainer and email groups specifically required for this patch. The link for original series can be found here, https://lore.kernel.org/alsa-devel/1611944866

Re: [PATCH] ASoC: tegra: SND_SOC_TEGRA_AUDIO_GRAPH_CARD should depend on SND_SOC_TEGRA

2021-01-29 Thread Sameer Pujar
river") Signed-off-by: Geert Uytterhoeven --- sound/soc/tegra/Kconfig | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) Acked-by: Sameer Pujar

Re: Re: Re: [RESEND PATCH v6 5/6] arm64: tegra: Audio graph header for Tegra210

2021-01-19 Thread Sameer Pujar
On 1/19/2021 11:27 PM, Thierry Reding wrote: On Tue, Jan 19, 2021 at 11:09:32PM +0530, Sameer Pujar wrote: On 1/19/2021 10:45 PM, Thierry Reding wrote: On Tue, Jan 19, 2021 at 02:58:15PM +0530, Sameer Pujar wrote: Expose a header which describes DT bindings required to use audio-graph

Re: Re: [RESEND PATCH v6 5/6] arm64: tegra: Audio graph header for Tegra210

2021-01-19 Thread Sameer Pujar
On 1/19/2021 10:45 PM, Thierry Reding wrote: On Tue, Jan 19, 2021 at 02:58:15PM +0530, Sameer Pujar wrote: Expose a header which describes DT bindings required to use audio-graph based sound card. All Tegra210 based platforms can include this header and add platform specific information

[RESEND PATCH v6 3/6] ASoC: tegra: Add audio graph based card driver

2021-01-19 Thread Sameer Pujar
with component model. Signed-off-by: Sameer Pujar Reviewed-by: Jon Hunter --- sound/soc/tegra/Kconfig | 9 ++ sound/soc/tegra/Makefile | 2 + sound/soc/tegra/tegra_audio_graph_card.c | 251 +++ 3 files changed, 262 insertions(+) create

[RESEND PATCH v6 2/6] ASoC: dt-bindings: tegra: Add json-schema for Tegra audio graph card

2021-01-19 Thread Sameer Pujar
Add YAML schema for Tegra audio graph sound card DT bindings. It uses the same DT bindings provided by generic audio graph driver. Along with this few standard clock DT bindings are added which are specifically required for Tegra audio. Signed-off-by: Sameer Pujar Reviewed-by: Jon Hunter

[RESEND PATCH v6 6/6] arm64: tegra: Audio graph sound card for Jetson Nano and TX1

2021-01-19 Thread Sameer Pujar
Enable support for audio-graph based sound card on Jetson-Nano and Jetson-TX1. Depending on the platform, required I/O interfaces are enabled. * Jetson-Nano: Enable I2S3, I2S4, DMIC1 and DMIC2. * Jetson-TX1: Enable all I2S and DMIC interfaces. Signed-off-by: Sameer Pujar Reviewed-by: Jon

[RESEND PATCH v6 5/6] arm64: tegra: Audio graph header for Tegra210

2021-01-19 Thread Sameer Pujar
-by: Sameer Pujar Reviewed-by: Jon Hunter --- .../boot/dts/nvidia/tegra210-audio-graph.dtsi | 153 + 1 file changed, 153 insertions(+) create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-audio-graph.dtsi diff --git a/arch/arm64/boot/dts/nvidia/tegra210-audio-graph.dtsi b

[RESEND PATCH v6 4/6] arm64: defconfig: Enable Tegra audio graph card driver

2021-01-19 Thread Sameer Pujar
This commit enables Tegra audio graph card driver which is based on the generic audio-graph card driver. This is intended to be used on platforms based on Tegra210 and later chips. Signed-off-by: Sameer Pujar Reviewed-by: Jon Hunter --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1

[RESEND PATCH v6 0/6] Tegra210 audio graph card

2021-01-19 Thread Sameer Pujar
AIF and XBAR. Updated DT patches accordingly. * After above change, multiple Codec endpoint support is not required and hence dropped for now. This will be considered separately if at all required in future. * Re-ordered patches in the series. Sameer Pujar (6): ASoC: dt-bindings: tegra: Add

[RESEND PATCH v6 1/6] ASoC: dt-bindings: tegra: Add graph bindings

2021-01-19 Thread Sameer Pujar
Add device tree binding properties of generic graph to ASoC component devices. This allows to define audio ports out of these components or DAIs and audio graph based sound card can be realised with this. Signed-off-by: Sameer Pujar Reviewed-by: Jon Hunter --- .../bindings/sound/nvidia

[RESEND PATCH] ASoC: audio-graph-card: Drop remote-endpoint as required property

2021-01-17 Thread Sameer Pujar
-by: Sameer Pujar --- Documentation/devicetree/bindings/sound/audio-graph-port.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml index 2005014..766e910 100644

Re: [PATCH] dt-bindings: Remove plain text OF graph binding

2021-01-12 Thread Sameer Pujar
On 1/12/2021 9:16 PM, Rob Herring wrote: External email: Use caution opening links or attachments From: Sameer Pujar A schema for the OF graph binding has been added to the dt-schema repo based on graph.txt contents. Let's replace graph.txt now duplicated contents with a reference

Re: [PATCH] ASoC: audio-graph-card: Drop remote-endpoint as required property

2021-01-10 Thread Sameer Pujar
Hi Rob, On 12/10/2020 8:14 PM, Sameer Pujar wrote: Hi Rob, The remote-endpoint may not be available if it is part of some pluggable module. One such example would be an audio card, the Codec endpoint will not be available until it is plugged in. Hence drop 'remote-endpoint' as a required

Re: [PATCH v2 2/2] ALSA: hda/tegra: fix tegra-hda on tegra30 soc

2021-01-08 Thread Sameer Pujar
Tested-by: Ion Agorria Signed-off-by: Peter Geis --- sound/pci/hda/hda_tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks Peter. Reviewed-by: Sameer Pujar

Re: [PATCH v2 1/2] clk: tegra30: Add hda clock default rates to clock driver

2021-01-08 Thread Sameer Pujar
. This matches upstream t124 and downstream t30. Acked-by: Jon Hunter Tested-by: Ion Agorria Signed-off-by: Peter Geis --- drivers/clk/tegra/clk-tegra30.c | 2 ++ 1 file changed, 2 insertions(+) Acked-by: Sameer Pujar

Re: [PATCH 2/2] ALSA: hda/tegra: fix tegra-hda on tegra30 soc

2021-01-08 Thread Sameer Pujar
On 1/7/2021 2:51 AM, Peter Geis wrote: External email: Use caution opening links or attachments On Tue, Jan 5, 2021 at 1:30 AM Sameer Pujar wrote: On 12/25/2020 6:50 AM, Peter Geis wrote: External email: Use caution opening links or attachments Currently hda on tegra30 fails to open

[PATCH] arm64: tegra: Add power-domain for Tegra210 HDA

2021-01-06 Thread Sameer Pujar
0") Cc: Signed-off-by: Sameer Pujar --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi index 4fbf8c1..fd33b4d 100644 --- a/arch/arm64/boot/dts/nvidia/tegra210.d

Re: [PATCH 2/2] ALSA: hda/tegra: fix tegra-hda on tegra30 soc

2021-01-04 Thread Sameer Pujar
On 12/25/2020 6:50 AM, Peter Geis wrote: External email: Use caution opening links or attachments Currently hda on tegra30 fails to open a stream with an input/output error. This is similar to the issue referenced in [1]. For example: speaker-test -Dhw:0,3 -c 2 speaker-test 1.2.2

Re: [PATCH] ASoC: audio-graph-card: Drop remote-endpoint as required property

2020-12-27 Thread Sameer Pujar
Hi Rob, The remote-endpoint may not be available if it is part of some pluggable module. One such example would be an audio card, the Codec endpoint will not be available until it is plugged in. Hence drop 'remote-endpoint' as a required property. Please hold off on this. I have more changes

Re: [PATCH] ASoC: audio-graph-card: Drop remote-endpoint as required property

2020-12-10 Thread Sameer Pujar
Hi Rob, The remote-endpoint may not be available if it is part of some pluggable module. One such example would be an audio card, the Codec endpoint will not be available until it is plugged in. Hence drop 'remote-endpoint' as a required property. Please hold off on this. I have more changes

[PATCH] ASoC: audio-graph-card: Drop remote-endpoint as required property

2020-12-08 Thread Sameer Pujar
-by: Sameer Pujar --- Documentation/devicetree/bindings/sound/audio-graph-port.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml index 2005014..766e910 100644

Re: Re: Re: [PATCH v6 0/6] Tegra210 audio graph card

2020-12-08 Thread Sameer Pujar
No, this was sent by a b4 bug - notice the "no commit info" there, they weren't applied. Oh I see! I guess review would be still pending then. I don't seem to have them in my backlog so either there was feedback from someone else I was expecting to see addressed or some other issue. I am

Re: Re: [PATCH v6 0/6] Tegra210 audio graph card

2020-12-07 Thread Sameer Pujar
[1/3] ASoC: dt-bindings: tegra: Add graph bindings (no commit info) [2/3] ASoC: dt-bindings: tegra: Add json-schema for Tegra audio graph card (no commit info) [3/3] ASoC: tegra: Add audio graph based card driver (no commit info) I don't see above patches in linux-next

Re: [PATCH v6 0/6] Tegra210 audio graph card

2020-12-06 Thread Sameer Pujar
Hi Mark, This series adds audio graph based sound card support for Tegra210 platforms like Jetson-TX1 an Jetson-Nano. The following preparatory audio graph enhancement series is already merged. * https://patchwork.kernel.org/project/alsa-devel/list/?series=375629=* Following are the summary

[RESEND PATCH 1/2] dt-bindings: tegra: Convert HDA doc to json-schema

2020-12-03 Thread Sameer Pujar
Convert Tegra HDA doc to YAML format. Signed-off-by: Sameer Pujar --- .../bindings/sound/nvidia,tegra30-hda.txt | 35 .../bindings/sound/nvidia,tegra30-hda.yaml | 98 ++ 2 files changed, 98 insertions(+), 35 deletions(-) delete mode 100644

[RESEND PATCH 2/2] dt-bindings: tegra: Add missing HDA properties

2020-12-03 Thread Sameer Pujar
Document the missing properties which are currently required for Tegra186/Tegra194 DT files. Signed-off-by: Sameer Pujar --- .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/sound

[RESEND PATCH 0/2] Convert Tegra HDA doc to json-schema

2020-12-03 Thread Sameer Pujar
Convert Tegra HDA doc to YAML format. Ran binding validation checks to ensure there are no warnings/errors for HDA. Patch "arm64: tegra: Fix Tegra194 HDA {clock,reset}-names ordering" is already merged and hence not included here. Sameer Pujar (2): dt-bindings: tegra: Convert HDA d

[PATCH v6 0/6] Tegra210 audio graph card

2020-11-26 Thread Sameer Pujar
ge, multiple Codec endpoint support is not required and hence dropped for now. This will be considered separately if at all required in future. * Re-ordered patches in the series. Sameer Pujar (6): ASoC: dt-bindings: tegra: Add graph bindings ASoC: dt-bindings: tegra: Add json-schema for Tegra audio

[PATCH v6 6/6] arm64: tegra: Audio graph sound card for Jetson Nano and TX1

2020-11-26 Thread Sameer Pujar
Enable support for audio-graph based sound card on Jetson-Nano and Jetson-TX1. Depending on the platform, required I/O interfaces are enabled. * Jetson-Nano: Enable I2S3, I2S4, DMIC1 and DMIC2. * Jetson-TX1: Enable all I2S and DMIC interfaces. Signed-off-by: Sameer Pujar Reviewed-by: Jon

[PATCH v6 5/6] arm64: tegra: Audio graph header for Tegra210

2020-11-26 Thread Sameer Pujar
-by: Sameer Pujar Reviewed-by: Jon Hunter --- .../boot/dts/nvidia/tegra210-audio-graph.dtsi | 153 + 1 file changed, 153 insertions(+) create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-audio-graph.dtsi diff --git a/arch/arm64/boot/dts/nvidia/tegra210-audio-graph.dtsi b

[PATCH v6 3/6] ASoC: tegra: Add audio graph based card driver

2020-11-26 Thread Sameer Pujar
with component model. Signed-off-by: Sameer Pujar Reviewed-by: Jon Hunter --- sound/soc/tegra/Kconfig | 9 ++ sound/soc/tegra/Makefile | 2 + sound/soc/tegra/tegra_audio_graph_card.c | 251 +++ 3 files changed, 262 insertions(+) create

[PATCH v6 4/6] arm64: defconfig: Enable Tegra audio graph card driver

2020-11-26 Thread Sameer Pujar
This commit enables Tegra audio graph card driver which is based on the generic audio-graph card driver. This is intended to be used on platforms based on Tegra210 and later chips. Signed-off-by: Sameer Pujar Reviewed-by: Jon Hunter --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1

[PATCH v6 1/6] ASoC: dt-bindings: tegra: Add graph bindings

2020-11-26 Thread Sameer Pujar
Add device tree binding properties of generic graph to ASoC component devices. This allows to define audio ports out of these components or DAIs and audio graph based sound card can be realised with this. Signed-off-by: Sameer Pujar Reviewed-by: Jon Hunter --- .../bindings/sound/nvidia

[PATCH v6 2/6] ASoC: dt-bindings: tegra: Add json-schema for Tegra audio graph card

2020-11-26 Thread Sameer Pujar
Add YAML schema for Tegra audio graph sound card DT bindings. It uses the same DT bindings provided by generic audio graph driver. Along with this few standard clock DT bindings are added which are specifically required for Tegra audio. Signed-off-by: Sameer Pujar Reviewed-by: Jon Hunter

Re: [PATCH v5 3/6] ASoC: tegra: Add audio graph based card driver

2020-11-23 Thread Sameer Pujar
DPCM with component model. Signed-off-by: Sameer Pujar --- sound/soc/tegra/Kconfig | 9 ++ sound/soc/tegra/Makefile | 2 + sound/soc/tegra/tegra_audio_graph_card.c | 255 +++ 3 files changed, 266 insertions(+) create mode

Re: [PATCH v5 1/6] ASoC: dt-bindings: tegra: Add graph bindings

2020-11-19 Thread Sameer Pujar
guess I'll need to provide a branch as there's multiple subsystems needing it. Signed-off-by: Sameer Pujar --- .../devicetree/bindings/sound/nvidia,tegra186-dspk.yaml | 6 ++ .../devicetree/bindings/sound/nvidia,tegra210-admaif.yaml | 6 ++ .../devicetree/bindings/sound/nvidia

[PATCH 3/3] dt-bindings: tegra: Add missing HDA properties

2020-11-18 Thread Sameer Pujar
Document the missing properties which are currently required for Tegra186/Tegra194 DT files. Signed-off-by: Sameer Pujar --- .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/sound

[PATCH 2/3] dt-bindings: tegra: Convert HDA doc to json-schema

2020-11-18 Thread Sameer Pujar
Convert Tegra HDA doc to YAML format. Signed-off-by: Sameer Pujar --- .../bindings/sound/nvidia,tegra30-hda.txt | 35 .../bindings/sound/nvidia,tegra30-hda.yaml | 98 ++ 2 files changed, 98 insertions(+), 35 deletions(-) delete mode 100644

[PATCH 1/3] arm64: tegra: Fix Tegra194 HDA {clock,reset}-names ordering

2020-11-18 Thread Sameer Pujar
As per the HDA binding doc reorder {clock,reset}-names entries for Tegra194. This also serves as a preparation for converting existing binding doc to json-schema. Signed-off-by: Sameer Pujar --- arch/arm64/boot/dts/nvidia/tegra194.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH 0/3] Convert Tegra HDA doc to json-schema

2020-11-18 Thread Sameer Pujar
Fix Tegra194 DT and convert Tegra HDA doc to YAML format. Ran binding validation checks to ensure there are no warnings/errors for HDA. Sameer Pujar (3): arm64: tegra: Fix Tegra194 HDA {clock,reset}-names ordering dt-bindings: tegra: Convert HDA doc to json-schema dt-bindings: tegra: Add

[PATCH v5 4/6] arm64: defconfig: Enable Tegra audio graph card driver

2020-11-11 Thread Sameer Pujar
This commit enables Tegra audio graph card driver which is based on the generic audio-graph card driver. This is intended to be used on platforms based on Tegra210 and later chips. Signed-off-by: Sameer Pujar --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v5 6/6] arm64: tegra: Audio graph sound card for Jetson Nano and TX1

2020-11-11 Thread Sameer Pujar
Enable support for audio-graph based sound card on Jetson-Nano and Jetson-TX1. Depending on the platform, required I/O interfaces are enabled. * Jetson-Nano: Enable I2S3, I2S4, DMIC1 and DMIC2. * Jetson-TX1: Enable all I2S and DMIC interfaces. Signed-off-by: Sameer Pujar --- arch/arm64/boot

[PATCH v5 5/6] arm64: tegra: Audio graph header for Tegra210

2020-11-11 Thread Sameer Pujar
-by: Sameer Pujar --- .../boot/dts/nvidia/tegra210-audio-graph.dtsi | 153 + 1 file changed, 153 insertions(+) create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-audio-graph.dtsi diff --git a/arch/arm64/boot/dts/nvidia/tegra210-audio-graph.dtsi b/arch/arm64/boot/dts

[PATCH v5 2/6] ASoC: dt-bindings: tegra: Add json-schema for Tegra audio graph card

2020-11-11 Thread Sameer Pujar
Add YAML schema for Tegra audio graph sound card DT bindings. It uses the same DT bindings provided by generic audio graph driver. Along with this few standard clock DT bindings are added which are specifically required for Tegra audio. Signed-off-by: Sameer Pujar --- .../sound/nvidia,tegra

[PATCH v5 1/6] ASoC: dt-bindings: tegra: Add graph bindings

2020-11-11 Thread Sameer Pujar
Add device tree binding properties of generic graph to ASoC component devices. This allows to define audio ports out of these components or DAIs and audio graph based sound card can be realised with this. Signed-off-by: Sameer Pujar --- .../devicetree/bindings/sound/nvidia,tegra186-dspk.yaml

[PATCH v5 3/6] ASoC: tegra: Add audio graph based card driver

2020-11-11 Thread Sameer Pujar
with component model. Signed-off-by: Sameer Pujar --- sound/soc/tegra/Kconfig | 9 ++ sound/soc/tegra/Makefile | 2 + sound/soc/tegra/tegra_audio_graph_card.c | 255 +++ 3 files changed, 266 insertions(+) create mode 100644 sound/soc/tegra

[PATCH v5 0/6] Tegra210 audio graph card

2020-11-11 Thread Sameer Pujar
ter above change, multiple Codec endpoint support is not required and hence dropped for now. This will be considered separately if at all required in future. * Re-ordered patches in the series. Sameer Pujar (6): ASoC: dt-bindings: tegra: Add graph bindings ASoC: dt-bindings: tegra: Add j

[PATCH 0/2] Refactor Audio Graph schema

2020-11-11 Thread Sameer Pujar
reference 'audio-graph.yaml' and define its own compatible and specific properties. This depends on following series: http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20201102203656.220187-2-r...@kernel.org/ Sameer Pujar (2): ASoC: audio-graph-card: Refactor schema ASoC: renesas,rsnd

[PATCH 1/2] ASoC: audio-graph-card: Refactor schema

2020-11-11 Thread Sameer Pujar
There can be customized sound cards which are based on generic audio graph. In such cases most of the stuff is reused from generic audio graph. To facilitate this, refactor audio graph schema into multiple files and the base schema can be reused for specific sound cards. Signed-off-by: Sameer

[PATCH 2/2] ASoC: renesas,rsnd: Update audio graph references

2020-11-11 Thread Sameer Pujar
Since audio graph schema is refactored now update the related references here. Signed-off-by: Sameer Pujar Cc: Kuninori Morimoto --- Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree

Re: [PATCH v3 1/3] dt-bindings: Convert graph bindings to json-schema

2020-11-11 Thread Sameer Pujar
Hi Rob, From: Sameer Pujar Convert device tree bindings of graph to YAML format. Currently graph.txt doc is referenced in multiple files and all of these need to use schema references. For now graph.txt is updated to refer to graph.yaml. For users of the graph binding, they should reference

[PATCH v2 4/4] dt-bindings: bus: Convert ACONNECT doc to json-schema

2020-11-06 Thread Sameer Pujar
Move ACONNECT documentation to YAML format. Signed-off-by: Sameer Pujar --- .../bindings/bus/nvidia,tegra210-aconnect.txt | 44 .../bindings/bus/nvidia,tegra210-aconnect.yaml | 82 ++ 2 files changed, 82 insertions(+), 44 deletions(-) delete mode

[PATCH v2 1/4] arm64: tegra: Rename ADMA device nodes for Tegra210

2020-11-06 Thread Sameer Pujar
DMA device nodes should follow regex pattern of "^dma-controller(@.*)?$". This is a preparatory patch to use YAML doc format for ADMA. Signed-off-by: Sameer Pujar --- arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 2 +- arch/arm64/boot/dts/nvidia/tegra210-p3450-.dts | 2 +-

[PATCH v2 2/4] dt-bindings: dma: Convert ADMA doc to json-schema

2020-11-06 Thread Sameer Pujar
Move ADMA documentation to YAML format. Signed-off-by: Sameer Pujar --- .../bindings/dma/nvidia,tegra210-adma.txt | 56 .../bindings/dma/nvidia,tegra210-adma.yaml | 99 ++ 2 files changed, 99 insertions(+), 56 deletions(-) delete mode 100644

[PATCH v2 3/4] dt-bindings: interrupt-controller: arm,gic: Update Tegra compatibles

2020-11-06 Thread Sameer Pujar
Update Tegra compatibles to support newer Tegra chips and required combinations. Signed-off-by: Sameer Pujar Reviewed-by: Rob Herring --- .../devicetree/bindings/interrupt-controller/arm,gic.yaml| 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Documentation

[PATCH v2 0/4] Convert few Tegra docs to json-schema

2020-11-06 Thread Sameer Pujar
red 'additionalProperty' and thus fix errors/warnings in the schema. * Fix indentation warnings in arm,gic.yaml for AGIC documentation. With this fix add "Reviewed-by" tag from Rob. * Drop individual child pattern properties for ACONNECT schema and instead use generic pattern property.

Re: [PATCH 4/4] dt-bindings: bus: Convert ACONNECT doc to json-schema

2020-11-05 Thread Sameer Pujar
Move ACONNECT documentation to YAML format. Signed-off-by: Sameer Pujar --- .../bindings/bus/nvidia,tegra210-aconnect.txt | 44 --- .../bindings/bus/nvidia,tegra210-aconnect.yaml | 86 ++ 2 files changed, 86 insertions(+), 44 deletions(-) delete

[PATCH 3/4] dt-bindings: interrupt-controller: arm,gic: Update Tegra compatibles

2020-11-05 Thread Sameer Pujar
Update Tegra compatibles to support newer Tegra chips and required combinations. Signed-off-by: Sameer Pujar --- .../devicetree/bindings/interrupt-controller/arm,gic.yaml| 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings

[PATCH 2/4] dt-bindings: dma: Convert ADMA doc to json-schema

2020-11-05 Thread Sameer Pujar
Move ADMA documentation to YAML format. Signed-off-by: Sameer Pujar --- .../bindings/dma/nvidia,tegra210-adma.txt | 56 - .../bindings/dma/nvidia,tegra210-adma.yaml | 95 ++ 2 files changed, 95 insertions(+), 56 deletions(-) delete mode 100644

  1   2   3   4   >