From: Satyam Sharma [EMAIL PROTECTED]
[8/9] netconsole: Support multiple logging targets
This patch introduces support for multiple targets:
Let's keep this out of CONFIG_NETCONSOLE_DYNAMIC as well -- this is useful
even in the default case and (including the infrastructure introduced
From: Satyam Sharma [EMAIL PROTECTED]
[9/9] netconsole: Support dynamic reconfiguration using configfs
This patch introduces support for dynamic reconfiguration (adding, removing
and/or modifying parameters of netconsole targets at runtime) using a
userspace interface exported via configfs
From: Satyam Sharma [EMAIL PROTECTED]
[7/9] netconsole: Use netif_running() in write_msg()
Avoid unnecessarily disabling interrupts and calling netpoll_send_udp()
if the corresponding local interface is not up.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
Cc: Keiichi Kii [EMAIL PROTECTED
From: Satyam Sharma [EMAIL PROTECTED]
[5/9] netconsole: Introduce netconsole_target
Introduce a wrapper structure over netpoll to represent logging targets
configured in netconsole. This will get extended with other members in
further patches.
The original patchset did this along
On 7/10/07, Avi Kivity [EMAIL PROTECTED] wrote:
Satyam Sharma wrote:
On 7/9/07, Andi Kleen [EMAIL PROTECTED] wrote:
[...]
on_each_cpu() was imho always a mistake. It would have been better
to just fix smp_call_function() directly
I'm not sure what you mean by fix here, but if you're
On 7/10/07, Avi Kivity [EMAIL PROTECTED] wrote:
Satyam Sharma wrote:
On 7/10/07, Avi Kivity [EMAIL PROTECTED] wrote:
Satyam Sharma wrote:
On 7/9/07, Andi Kleen [EMAIL PROTECTED] wrote:
[...]
on_each_cpu() was imho always a mistake. It would have been better
to just fix
Hi,
On Tue, 10 Jul 2007, Duane Griffin wrote:
On 10/07/07, Satyam Sharma [EMAIL PROTECTED] wrote:
+ /* Avoid taking lock and disabling interrupts unnecessarily */
+ if (unlikely(list_empty(target_list)))
+ return;
Is the unlikely a good idea here? Not having
Hi Jesper,
On Tue, 10 Jul 2007, Jesper Juhl wrote:
On Tuesday 10 July 2007 11:41:43 Matt Mackall wrote:
On Tue, Jul 10, 2007 at 02:49:41PM +0530, Satyam Sharma wrote:
From: Satyam Sharma [EMAIL PROTECTED]
[4/9] netconsole: Add some useful tips to documentation
Add some useful
Juhl [EMAIL PROTECTED]
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
---
Documentation/networking/netconsole.txt | 24
1 file changed, 24 insertions(+)
---
diff -ruNp a/Documentation/networking/netconsole.txt
b/Documentation/networking/netconsole.txt
On Tue, 10 Jul 2007, Joel Becker wrote:
On Wed, Jul 11, 2007 at 03:40:22AM +0530, Satyam Sharma wrote:
IMHO something that mentions /proc/sys/kernel/printk would be better.
You don't need to have built with SysRq support for that, it's clearly
more flexible than the ignore_loglevel
On 7/9/07, Oliver Neukum <[EMAIL PROTECTED]> wrote:
Am Montag, 9. Juli 2007 schrieb Kunai, Takashi:
> (b)printk hashes and (c)Format strings. (a) seems difficult to get
> supports from kernel developers and (c) lacks uniqueness of each
> message. Though (b) also lacks uniqueness, adding
On 7/10/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
On Fri, 6 Jul 2007, Dr. David Alan Gilbert wrote:
> * Robert P. J. Day ([EMAIL PROTECTED]) wrote:
>
> > and if that happens, then the config variables defined in
> > drivers/acorn/block/Kconfig:
> >
> > config BLK_DEV_FD1772
> >
Hi,
ISTR participating in a similar discussion some time back, but ...
anyway, I don't like the change in semantics of smp_call_function()
being proposed here *at* *all* ...
On 7/9/07, Avi Kivity <[EMAIL PROTECTED]> wrote:
>> This defines on_cpu() which is similar to smp_call_function_single()
Hi,
ISTR participating in a similar discussion some time back, but ...
anyway, I don't like the change in semantics of smp_call_function()
being proposed here *at* *all* ...
On 7/9/07, Avi Kivity [EMAIL PROTECTED] wrote:
This defines on_cpu() which is similar to smp_call_function_single()
On 7/10/07, Robert P. J. Day [EMAIL PROTECTED] wrote:
On Fri, 6 Jul 2007, Dr. David Alan Gilbert wrote:
* Robert P. J. Day ([EMAIL PROTECTED]) wrote:
and if that happens, then the config variables defined in
drivers/acorn/block/Kconfig:
config BLK_DEV_FD1772
config BLK_DEV_MFM
On 7/9/07, Oliver Neukum [EMAIL PROTECTED] wrote:
Am Montag, 9. Juli 2007 schrieb Kunai, Takashi:
(b)printk hashes and (c)Format strings. (a) seems difficult to get
supports from kernel developers and (c) lacks uniqueness of each
message. Though (b) also lacks uniqueness, adding component id
On Sun, 8 Jul 2007, Satyam Sharma wrote:
> On Sun, 8 Jul 2007, KII Keiichi wrote:
> [...]
> > But, in the case, we must think of the case of changing IP address
> > because we can change IP address without disabling the network device and
> > can't hook the even
Hi Keiichi,
On Sun, 8 Jul 2007, KII Keiichi wrote:
> [...]
> I tested your patches on the x86 architecture and report the results.
> It is no problem except for the above problem.
> I think that it is useful to use configfs(especially, mkdir and rmdir because
> of adding/removing
Hi,
On Sun, 8 Jul 2007, KII Keiichi wrote:
> [...]
> Should we avoid the automatic update of netconsole_target until we can notice
> all
> necessary members of netconsole_target updated automatically?
>
> I had thought about automatic updating of the netconsole_target(i.e. local IP
> address
Hi,
On Sun, 8 Jul 2007, KII Keiichi wrote:
> Hi Satyam,
>
> The following comments aren't essential.
>
> > if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
> > event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
> > - goto done;
> > + goto done;
>
>
Hi Keiichi,
On Sun, 8 Jul 2007, KII Keiichi wrote:
> Hi Satyam,
>
> > After more discussion, Joel suggested the idea to separately manage the
> > lifetimes of the two kinds of netconsole_target objects, those created while
> > parsing boot/module options and those created via configfs mkdir(2)
Hi Albert,
[ added linux-cifs-client to Cc: ]
On 7/7/07, Albert Cahalan <[EMAIL PROTECTED]> wrote:
I had one share mounted, from XP to Linux, and wanted another.
At first I had an incorrect setting on the XP box, almost
certainly related to permissions. The mount failed of course.
Running
nit.text: (between 'mv_dreamcast' and 'systemasic_int')
These are bogus warnings, sh_machine_vector structures are used only at
init-time. So mark .mv_setup functions as __initmv too, to get rid of them.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
---
First sent in http://lkml.org/lkml
those four lines at beginning of kthreadd() itself.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
---
First discussed in http://lkml.org/lkml/2007/6/26/274,
and I keep getting this with:
|$ ld -V
|GNU ld version 2.17
| Supported emulations:
| elf_i386
| i386linux
| elf_x86_64
|$
nit.text: (between 'mv_dreamcast' and 'systemasic_int')
These are bogus warnings, sh_machine_vector structures are used only at
init-time. So mark .mv_setup functions as __initmv too, to get rid of them.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
---
First sent in http://lkml.org/lkml
Hi Stephen,
On Thu, 5 Jul 2007, Stephen Hemminger wrote:
> On Wed, 4 Jul 2007 08:56:42 -0500
> Matt Mackall <[EMAIL PROTECTED]> wrote:
> [...]
> > > + if (nt->dev_status) {
> >
> > Why not simply call net_dev_is_up?
>
> The flags field values are really BSD legacy-ish stuff and should not be
>
em member of struct configfs_subsystem to a struct
> mutex, as that's what it is. Also convert all the users and update
> Documentation/configfs.txt and Documentation/configfs_example.c
> accordingly.
>
> Inspired-by: Satyam Sharma <[EMAIL PROTECTED]>
> Signed-off-
Hi Joel,
On Fri, 6 Jul 2007, Joel Becker wrote:
> On Wed, Jul 04, 2007 at 04:38:24PM +0530, Satyam Sharma wrote:
> > struct netconsole_target {
> > struct list_headlist;
> > + struct config_item item;
> > + int id;
> > +
Hi Joel,
On Fri, 6 Jul 2007, Joel Becker wrote:
On Wed, Jul 04, 2007 at 04:38:24PM +0530, Satyam Sharma wrote:
struct netconsole_target {
struct list_headlist;
+ struct config_item item;
+ int id;
+ int enabled;
int
of struct configfs_subsystem to a struct
mutex, as that's what it is. Also convert all the users and update
Documentation/configfs.txt and Documentation/configfs_example.c
accordingly.
Inspired-by: Satyam Sharma [EMAIL PROTECTED]
Signed-off-by: Joel Becker [EMAIL PROTECTED]
With that caveat, Acked
Hi Stephen,
On Thu, 5 Jul 2007, Stephen Hemminger wrote:
On Wed, 4 Jul 2007 08:56:42 -0500
Matt Mackall [EMAIL PROTECTED] wrote:
[...]
+ if (nt-dev_status) {
Why not simply call net_dev_is_up?
The flags field values are really BSD legacy-ish stuff and should not be
used internally.
: (between 'mv_dreamcast' and 'systemasic_int')
These are bogus warnings, sh_machine_vector structures are used only at
init-time. So mark .mv_setup functions as __initmv too, to get rid of them.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
---
First sent in http://lkml.org/lkml/2007/6/23/116
at beginning of kthreadd() itself.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
---
First discussed in http://lkml.org/lkml/2007/6/26/274,
and I keep getting this with:
|$ ld -V
|GNU ld version 2.17
| Supported emulations:
| elf_i386
| i386linux
| elf_x86_64
|$ gcc -v
|Reading specs
: (between 'mv_dreamcast' and 'systemasic_int')
These are bogus warnings, sh_machine_vector structures are used only at
init-time. So mark .mv_setup functions as __initmv too, to get rid of them.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
---
First sent in http://lkml.org/lkml/2007/6/23/116
Hi Albert,
[ added linux-cifs-client to Cc: ]
On 7/7/07, Albert Cahalan [EMAIL PROTECTED] wrote:
I had one share mounted, from XP to Linux, and wanted another.
At first I had an incorrect setting on the XP box, almost
certainly related to permissions. The mount failed of course.
Running mount
Hi Keiichi,
On Sun, 8 Jul 2007, KII Keiichi wrote:
Hi Satyam,
After more discussion, Joel suggested the idea to separately manage the
lifetimes of the two kinds of netconsole_target objects, those created while
parsing boot/module options and those created via configfs mkdir(2) from
Hi,
On Sun, 8 Jul 2007, KII Keiichi wrote:
Hi Satyam,
The following comments aren't essential.
if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
- goto done;
+ goto done;
The above diff
Hi,
On Sun, 8 Jul 2007, KII Keiichi wrote:
[...]
Should we avoid the automatic update of netconsole_target until we can notice
all
necessary members of netconsole_target updated automatically?
I had thought about automatic updating of the netconsole_target(i.e. local IP
address
and
Hi Keiichi,
On Sun, 8 Jul 2007, KII Keiichi wrote:
[...]
I tested your patches on the x86 architecture and report the results.
It is no problem except for the above problem.
I think that it is useful to use configfs(especially, mkdir and rmdir because
of adding/removing netconsole_target).
Hi Guillaume,
[ Added relevant folks to Cc: ]
On 7/6/07, Guillaume LECERF <[EMAIL PROTECTED]> wrote:
[...]
--- a/drivers/net/wireless/libertas/cmd.c
+++ b/drivers/net/wireless/libertas/cmd.c
@@ -241,7 +241,7 @@
if (*enable)
penableRSN->enable =
Hi Guillaume,
[ Added relevant folks to Cc: ]
On 7/6/07, Guillaume LECERF [EMAIL PROTECTED] wrote:
[...]
--- a/drivers/net/wireless/libertas/cmd.c
+++ b/drivers/net/wireless/libertas/cmd.c
@@ -241,7 +241,7 @@
if (*enable)
penableRSN-enable =
On Thu, 5 Jul 2007, Satyam Sharma wrote:
> [...]
> BTW I did some testing myself, and have found another *embarrassing* bug:
> if netconsole is loaded _without_ specifying any "netconsole=" parameter,
> module is still kept loaded, but on unloading configfs_unregister_..
Hi Keiichi,
On Thu, 5 Jul 2007, Keiichi KII wrote:
> Hi Satyam,
>
> > + cat enabled # check if enabled is 1
> > + echo 0 > enabled # disable the target (if required)
> > + echo eth2 > dev_name # set local interface
>
> I think
On Wed, 4 Jul 2007, Joel Becker wrote:
> On Wed, Jul 04, 2007 at 04:38:19PM +0530, Satyam Sharma wrote:
> > +Some examples follow (configfs is mounted at the /config mountpoint, say).
>
> configfs is generally expected to be mounted at
> /sys/kernel/config, a
On Wed, 4 Jul 2007, Joel Becker wrote:
> On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
> > - if (!(event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
> > - goto done;
> > + if (!(event == NETDEV_UP || event == NETDEV_DOWN |
Hi Joel,
On Wed, 4 Jul 2007, Joel Becker wrote:
> On Wed, Jul 04, 2007 at 04:37:01PM +0530, Satyam Sharma wrote:
> > From: Satyam Sharma <[EMAIL PROTECTED]>
> >
> > [0/3] configfs: Miscellaneous cleanups
> >
> > Simple cleanups for configfs (
On Wed, 4 Jul 2007, Joel Becker wrote:
On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
- if (!(event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
- goto done;
+ if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
+ event == NETDEV_CHANGEADDR
On Wed, 4 Jul 2007, Joel Becker wrote:
On Wed, Jul 04, 2007 at 04:38:19PM +0530, Satyam Sharma wrote:
+Some examples follow (configfs is mounted at the /config mountpoint, say).
configfs is generally expected to be mounted at
/sys/kernel/config, and it even creates that mountpoint
Hi Joel,
On Wed, 4 Jul 2007, Joel Becker wrote:
On Wed, Jul 04, 2007 at 04:37:01PM +0530, Satyam Sharma wrote:
From: Satyam Sharma [EMAIL PROTECTED]
[0/3] configfs: Miscellaneous cleanups
Simple cleanups for configfs (plus DLM and OCFS2, wherever applicable).
This is diffed against
On Thu, 5 Jul 2007, Satyam Sharma wrote:
[...]
BTW I did some testing myself, and have found another *embarrassing* bug:
if netconsole is loaded _without_ specifying any netconsole= parameter,
module is still kept loaded, but on unloading configfs_unregister_...()
obviously panics
Hi Keiichi,
On Thu, 5 Jul 2007, Keiichi KII wrote:
Hi Satyam,
+ cat enabled # check if enabled is 1
+ echo 0 enabled # disable the target (if required)
+ echo eth2 dev_name # set local interface
I think that the
Hi Matt,
On Wed, 4 Jul 2007, Matt Mackall wrote:
> On Wed, Jul 04, 2007 at 04:38:09PM +0530, Satyam Sharma wrote:
> > From: Satyam Sharma <[EMAIL PROTECTED]>
> >
> > [6/9] netconsole: Update documentation for multiple target support
> >
> > ... and add a
On Wed, 4 Jul 2007, Matt Mackall wrote:
> On Wed, Jul 04, 2007 at 04:37:59PM +0530, Satyam Sharma wrote:
> > From: Satyam Sharma <[EMAIL PROTECTED]>
> >
> > [4/9] netconsole: Introduce netconsole_netdev_notifier
> >
> > To update fields of
On Wed, 4 Jul 2007, Matt Mackall wrote:
> On Wed, Jul 04, 2007 at 04:37:49PM +0530, Satyam Sharma wrote:
> > [...]
> > (2) With this change, option_setup() is not required for modular netconsole.
>
> How is this a simplification? You've taken code with no #ifdefs and
> add
On Wed, 4 Jul 2007, Matt Mackall wrote:
> On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
> > [...]
> > +/*
> > + * Why no net_dev_is_up() in netdevice.h? The kernel could lose a lot of
> > + * weight if only netdevice.h had the good sense to export such
[ Some more thoughts I had on this, for those interested. ]
> +#ifdef CONFIG_NETCONSOLE_DYNAMIC
> +
> +/*
> + * Targets that were created by parsing the boot/module option string
> + * do not exist in the configfs hierarchy and will never go away (and
> + * have zeroed-out config_item
Hi Keiichi,
On Wed, 4 Jul 2007, Keiichi KII wrote:
> [...]
> At first, thank you for your helping.
> I'm going to try/review your patches.
>
> >[ I had initially thought about only modifying Keiichi's patches to
> >incorporate the suggested stuff, sysfs+ioctl->configfs conversion, etc,
> >but
From: Satyam Sharma <[EMAIL PROTECTED]>
[3/3] configfs+dlm: Rename config_group_find_obj and state semantics clearly
[ Ok, this might sound like a gratuitous patch, but I believe there are
good reasons for it. ]
Configfs being based upon sysfs code, config_group_find_obj() is probably
so
From: Satyam Sharma <[EMAIL PROTECTED]>
[0/9] netconsole: Multiple targets and dynamic reconfigurability
This patchset is a rework of the original idea and patches posted by
Keiichi Kii and Takayoshi Kochi at: http://lkml.org/lkml/2007/6/13/72
[ I had initially thought about only mod
From: Satyam Sharma <[EMAIL PROTECTED]>
[8/9] netconsole: Update documentation for dynamic reconfigurability
Add myself to parties interested in receiving bug reports, and give lots
of examples. Also fix some whitespace inconsistencies I introduced earlier.
Signed-off-by: Satyam Sharma &
From: Satyam Sharma <[EMAIL PROTECTED]>
[3/9] netconsole: Introduce netconsole_target
Introduce a wrapper structure over netpoll to represent targets
configured in netconsole. This will get extended with other members in
further patches.
Ok, so the original patchset did this
From: Satyam Sharma <[EMAIL PROTECTED]>
[1/1] netpoll: Fix a leak-n-bug in netpoll_cleanup()
93ec2c723e3f8a216dde2899aeb85c648672bc6b applied excessive duct tape to
the netpoll beast's netpoll_cleanup(), thus substituting one leak with
another, and opening up a little buglet :-)
net_
From: Satyam Sharma <[EMAIL PROTECTED]>
[5/9] netconsole: Introduce dev_status member
Introduce a new member in netconsole_target that tracks the status (up or
down) of the underlying interface network device that the specific logging
target netpoll is attached to.
We then join t
From: Satyam Sharma <[EMAIL PROTECTED]>
[7/9] netconsole: Support multiple logging targets
This patch introduces support for multiple targets:
Let's keep this out of CONFIG_NETCONSOLE_DYNAMIC as well -- this is useful
even in the default case and (including the infrastructure intr
From: Satyam Sharma <[EMAIL PROTECTED]>
[9/9] netconsole: Support dynamic reconfiguration using configfs
This patch introduces support for dynamic reconfiguration (adding, removing
and/or modifying parameters of netconsole targets at runtime) using a
userspace interface exported via co
From: Satyam Sharma <[EMAIL PROTECTED]>
[2/3] configfs+dlm+ocfs2: Convert subsystem semaphore to mutex
Convert the su_sem member of struct configfs_subsystem to a struct mutex,
as that's what it is. Also convert all the users and update
Documentation/configfs.txt and Documen
From: Satyam Sharma <[EMAIL PROTECTED]>
[0/3] configfs: Miscellaneous cleanups
Simple cleanups for configfs (plus DLM and OCFS2, wherever applicable).
This is diffed against 2.6.22-rc6-mm1.
[1/3] configfs+dlm: Separate out __CONFIGFS_ATTR into configfs.h
[2/3] configfs+dlm+ocfs2: C
From: Satyam Sharma <[EMAIL PROTECTED]>
[1/9] netconsole: Cleanups, codingstyle, prettyfication
(1) Remove unwanted headers.
(2) Mark __init and __exit as appropriate.
(3) Various trivial codingstyle and prettification stuffs.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
Cc:
From: Satyam Sharma <[EMAIL PROTECTED]>
[2/9] netconsole: Code simplification
(1) Extract netpoll_parse_options() out of option_setup(), and into
init_netconsole() itself. So "configured" variable is redundant and
can be removed.
(2) With this change, option_setup() is not requ
From: Satyam Sharma <[EMAIL PROTECTED]>
[6/9] netconsole: Update documentation for multiple target support
... and add a few useful general purpose tips as well while we're at it.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
Cc: Keiichi Kii <[EMAIL PROTECTED]>
Cc: Takay
From: Satyam Sharma <[EMAIL PROTECTED]>
[4/9] netconsole: Introduce netconsole_netdev_notifier
To update fields of underlying netpoll structure at runtime on
corresponding NETDEV_CHANGEADDR or NETDEV_CHANGENAME notifications.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
Cc:
From: Satyam Sharma <[EMAIL PROTECTED]>
[1/3] configfs+dlm: Separate out __CONFIGFS_ATTR into configfs.h
fs/dlm/config.c contains a useful generic macro called __CONFIGFS_ATTR
that is similar to sysfs' __ATTR macro that makes defining attributes
easy for any user of configfs. Separate
Argh, my sendpatchset script got David's address wrong. I've made up
for that by sending the patchset separately to him -- didn't want to
spam the entire list.
On Wed, 4 Jul 2007, Satyam Sharma wrote:
> From: Satyam Sharma <[EMAIL PROTECTED]>
>
> [0/3] configfs: Miscell
Argh, my sendpatchset script got David's address wrong. I've made up
for that by sending the patchset separately to him -- didn't want to
spam the entire list.
On Wed, 4 Jul 2007, Satyam Sharma wrote:
From: Satyam Sharma [EMAIL PROTECTED]
[0/3] configfs: Miscellaneous cleanups
Simple
From: Satyam Sharma [EMAIL PROTECTED]
[1/3] configfs+dlm: Separate out __CONFIGFS_ATTR into configfs.h
fs/dlm/config.c contains a useful generic macro called __CONFIGFS_ATTR
that is similar to sysfs' __ATTR macro that makes defining attributes
easy for any user of configfs. Separate it out
From: Satyam Sharma [EMAIL PROTECTED]
[4/9] netconsole: Introduce netconsole_netdev_notifier
To update fields of underlying netpoll structure at runtime on
corresponding NETDEV_CHANGEADDR or NETDEV_CHANGENAME notifications.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
Cc: Keiichi Kii [EMAIL
From: Satyam Sharma [EMAIL PROTECTED]
[6/9] netconsole: Update documentation for multiple target support
... and add a few useful general purpose tips as well while we're at it.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
Cc: Keiichi Kii [EMAIL PROTECTED]
Cc: Takayoshi Kochi [EMAIL PROTECTED
From: Satyam Sharma [EMAIL PROTECTED]
[1/9] netconsole: Cleanups, codingstyle, prettyfication
(1) Remove unwanted headers.
(2) Mark __init and __exit as appropriate.
(3) Various trivial codingstyle and prettification stuffs.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
Cc: Keiichi Kii [EMAIL
From: Satyam Sharma [EMAIL PROTECTED]
[2/9] netconsole: Code simplification
(1) Extract netpoll_parse_options() out of option_setup(), and into
init_netconsole() itself. So configured variable is redundant and
can be removed.
(2) With this change, option_setup() is not required for modular
From: Satyam Sharma [EMAIL PROTECTED]
[2/3] configfs+dlm+ocfs2: Convert subsystem semaphore to mutex
Convert the su_sem member of struct configfs_subsystem to a struct mutex,
as that's what it is. Also convert all the users and update
Documentation/configfs.txt and Documentation
From: Satyam Sharma [EMAIL PROTECTED]
[0/3] configfs: Miscellaneous cleanups
Simple cleanups for configfs (plus DLM and OCFS2, wherever applicable).
This is diffed against 2.6.22-rc6-mm1.
[1/3] configfs+dlm: Separate out __CONFIGFS_ATTR into configfs.h
[2/3] configfs+dlm+ocfs2: Convert
From: Satyam Sharma [EMAIL PROTECTED]
[9/9] netconsole: Support dynamic reconfiguration using configfs
This patch introduces support for dynamic reconfiguration (adding, removing
and/or modifying parameters of netconsole targets at runtime) using a
userspace interface exported via configfs
From: Satyam Sharma [EMAIL PROTECTED]
[7/9] netconsole: Support multiple logging targets
This patch introduces support for multiple targets:
Let's keep this out of CONFIG_NETCONSOLE_DYNAMIC as well -- this is useful
even in the default case and (including the infrastructure introduced
From: Satyam Sharma [EMAIL PROTECTED]
[3/9] netconsole: Introduce netconsole_target
Introduce a wrapper structure over netpoll to represent targets
configured in netconsole. This will get extended with other members in
further patches.
Ok, so the original patchset did this along
From: Satyam Sharma [EMAIL PROTECTED]
[1/1] netpoll: Fix a leak-n-bug in netpoll_cleanup()
93ec2c723e3f8a216dde2899aeb85c648672bc6b applied excessive duct tape to
the netpoll beast's netpoll_cleanup(), thus substituting one leak with
another, and opening up a little buglet :-)
net_device-npinfo
From: Satyam Sharma [EMAIL PROTECTED]
[5/9] netconsole: Introduce dev_status member
Introduce a new member in netconsole_target that tracks the status (up or
down) of the underlying interface network device that the specific logging
target netpoll is attached to.
We then join this up
From: Satyam Sharma [EMAIL PROTECTED]
[0/9] netconsole: Multiple targets and dynamic reconfigurability
This patchset is a rework of the original idea and patches posted by
Keiichi Kii and Takayoshi Kochi at: http://lkml.org/lkml/2007/6/13/72
[ I had initially thought about only modifying
From: Satyam Sharma [EMAIL PROTECTED]
[8/9] netconsole: Update documentation for dynamic reconfigurability
Add myself to parties interested in receiving bug reports, and give lots
of examples. Also fix some whitespace inconsistencies I introduced earlier.
Signed-off-by: Satyam Sharma [EMAIL
From: Satyam Sharma [EMAIL PROTECTED]
[3/3] configfs+dlm: Rename config_group_find_obj and state semantics clearly
[ Ok, this might sound like a gratuitous patch, but I believe there are
good reasons for it. ]
Configfs being based upon sysfs code, config_group_find_obj() is probably
so named
Hi Keiichi,
On Wed, 4 Jul 2007, Keiichi KII wrote:
[...]
At first, thank you for your helping.
I'm going to try/review your patches.
[ I had initially thought about only modifying Keiichi's patches to
incorporate the suggested stuff, sysfs+ioctl-configfs conversion, etc,
but the changes
[ Some more thoughts I had on this, for those interested. ]
+#ifdef CONFIG_NETCONSOLE_DYNAMIC
+
+/*
+ * Targets that were created by parsing the boot/module option string
+ * do not exist in the configfs hierarchy and will never go away (and
+ * have zeroed-out config_item members).
On Wed, 4 Jul 2007, Matt Mackall wrote:
On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
[...]
+/*
+ * Why no net_dev_is_up() in netdevice.h? The kernel could lose a lot of
+ * weight if only netdevice.h had the good sense to export such a function.
+ * Oh well
On Wed, 4 Jul 2007, Matt Mackall wrote:
On Wed, Jul 04, 2007 at 04:37:49PM +0530, Satyam Sharma wrote:
[...]
(2) With this change, option_setup() is not required for modular netconsole.
How is this a simplification? You've taken code with no #ifdefs and
added one! Please have both modular
On Wed, 4 Jul 2007, Matt Mackall wrote:
On Wed, Jul 04, 2007 at 04:37:59PM +0530, Satyam Sharma wrote:
From: Satyam Sharma [EMAIL PROTECTED]
[4/9] netconsole: Introduce netconsole_netdev_notifier
To update fields of underlying netpoll structure at runtime on
corresponding
Hi Matt,
On Wed, 4 Jul 2007, Matt Mackall wrote:
On Wed, Jul 04, 2007 at 04:38:09PM +0530, Satyam Sharma wrote:
From: Satyam Sharma [EMAIL PROTECTED]
[6/9] netconsole: Update documentation for multiple target support
... and add a few useful general purpose tips as well while we're
[ Shamelessly off-topic, but SCNR myself ]
On 7/2/07, Nigel Cunningham <[EMAIL PROTECTED]> wrote:
Hi all.
Suspend2's name is changing to "TuxOnIce".
Hmm, FunkyMixedCase name ...
... hope this'll make it work on my laptop too :-)
[ Is there a prize for posting waaay off-topic messages? ]
[ Shamelessly off-topic, but SCNR myself ]
On 7/2/07, Nigel Cunningham [EMAIL PROTECTED] wrote:
Hi all.
Suspend2's name is changing to TuxOnIce.
Hmm, FunkyMixedCase name ...
tongue-firmly-in-cheek
... hope this'll make it work on my laptop too :-)
[ Is there a prize for posting waaay
Hi,
[ Cc:'s trimmed ]
On 7/2/07, Josef Sipek <[EMAIL PROTECTED]> wrote:
On Sun, Jul 01, 2007 at 10:23:30PM +0200, Adrian Bunk wrote:
> This patch makes some needlessly global functions static.
>
...
> --- linux-2.6.22-rc6-mm1/fs/unionfs/lookup.c.old 2007-07-01
00:05:02.0 +0200
>
Hi,
[ Cc:'s trimmed ]
On 7/2/07, Josef Sipek [EMAIL PROTECTED] wrote:
On Sun, Jul 01, 2007 at 10:23:30PM +0200, Adrian Bunk wrote:
This patch makes some needlessly global functions static.
...
--- linux-2.6.22-rc6-mm1/fs/unionfs/lookup.c.old 2007-07-01
00:05:02.0 +0200
+++
On 7/1/07, Sam Ravnborg <[EMAIL PROTECTED]> wrote:
[...]
I am heading for vacation for 20 days without Internet (real vacation :-))
I hope I'm not late in catching you here ...
By the way - kbuild.git is lacking behind on patches.
I have several queded from other peopel and have more in the
901 - 1000 of 1619 matches
Mail list logo
