Re: [PATCH] mtd: st_spi_fsm: remove unused variable

2019-09-19 Thread Sergei Shtylyov
Hello! On 09/19/2019 03:29 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The region resource in struct stfsm is unused and can be removed. OK, except it's not a variable (as the subject says), it's a structure field. "region resource" also seems strange... > >

Re: [PATCH v3 bpf-next 09/14] samples: bpf: makefile: use own flags but not host when cross compile

2019-09-17 Thread Sergei Shtylyov
Hello! On 16.09.2019 13:54, Ivan Khoronzhuk wrote: While compile natively, the hosts cflags and ldflags are equal to ones Compiling. Host's. used from HOSTCFLAGS and HOSTLDFLAGS. When cross compiling it should have own, used for target arch. While verification, for arm, arm64 and x86_64

Re: [PATCH v2] ixgbe: Use memset_explicit directly in crypto cases

2019-09-17 Thread Sergei Shtylyov
Hello! On 17.09.2019 6:45, zhong jiang wrote: It's better to use memset_explicit() to replace memset() in crypto cases. But you're using memzero_explicit() below? Signed-off-by: zhong jiang --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 6 +++--- 1 file changed, 3

Re: [PATCH bpf-next 01/11] samples: bpf: makefile: fix HDR_PROBE "echo"

2019-09-11 Thread Sergei Shtylyov
On 10.09.2019 17:54, Ivan Khoronzhuk wrote: Hello! On 10.09.2019 13:38, Ivan Khoronzhuk wrote: echo should be replaced on echo -e to handle \n correctly, but instead,  s/on/with/? s/echo/printf/ instead of s/echo/echo -e/ I only pointed that 'on' is incorrect there. You replace

Re: [PATCH V2 net-next 4/7] net: hns3: fix port setting handle for fibre port

2019-09-11 Thread Sergei Shtylyov
Hello! On 11.09.2019 5:40, Huazhong Tan wrote: From: Guangbin Huang For hardware doesn't support use specified speed and duplex Can't parse that. "For hardware that does not support using", perhaps? to negotiate, it's unnecessary to check and modify the port speed and duplex for fibre

Re: [PATCH V2 net-next 4/7] net: hns3: fix port setting handle for fibre port

2019-09-11 Thread Sergei Shtylyov
Hello! On 11.09.2019 5:40, Huazhong Tan wrote: From: Guangbin Huang For hardware doesn't support use specified speed and duplex Can't pasre that. "For hardware that does not support using", perhaps? to negotiate, it's unnecessary to check and modify the port speed and duplex for fibre

Re: [PATCH bpf-next 01/11] samples: bpf: makefile: fix HDR_PROBE "echo"

2019-09-10 Thread Sergei Shtylyov
Hello! On 10.09.2019 13:38, Ivan Khoronzhuk wrote: echo should be replaced on echo -e to handle \n correctly, but instead, s/on/with/? replace it on printf as some systems can't handle echo -e. Likewise? Signed-off-by: Ivan Khoronzhuk [...] MBR, Sergei

Re: [PATCH net] net: sonic: replace dev_kfree_skb in sonic_send_packet

2019-09-10 Thread Sergei Shtylyov
Hello! On 10.09.2019 11:58, Mao Wenan wrote: sonic_send_packet will be processed in irq or none s/none irq/non-irq/? irq context, so it would better use dev_kfree_skb_any instead of dev_kfree_skb. Fixes: d9fb9f384292 ("*sonic/natsemi/ns83829: Move the National Semi-conductor drivers")

Re: [PATCH net-next 4/7] net: hns3: add client node validity judgment

2019-09-05 Thread Sergei Shtylyov
On 04.09.2019 17:06, Huazhong Tan wrote: From: Peng Li HNS3 driver can only unregister client which included in hnae3_client_list. This patch adds the client node validity judgment. Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.c | 16

Re: [PATCH] arcnet: capmode: remove redundant assignment to pointer pkt

2019-08-28 Thread Sergei Shtylyov
Hello! On 27.08.2019 14:29, Colin King wrote: From: Colin Ian King Pointer pkt is being initialized with a value that is never read and pkg is being re-assigned a little later on. The assignment is ^^^ pkt redundant and hence can be removed. Addresses-Coverity: ("Ununsed value")

Re: [PATCH v6 11/14] mips: Adjust brk randomization offset to fit generic version

2019-08-08 Thread Sergei Shtylyov
Hello! On 08.08.2019 9:17, Alexandre Ghiti wrote: This commit simply bumps up to 32MB and 1GB the random offset of brk, compared to 8MB and 256MB, for 32bit and 64bit respectively. Suggested-by: Kees Cook Signed-off-by: Alexandre Ghiti Acked-by: Paul Burton Reviewed-by: Kees Cook

Re: [PATCH v6 09/14] mips: Properly account for stack randomization and stack guard gap

2019-08-08 Thread Sergei Shtylyov
Hello! On 08.08.2019 9:17, Alexandre Ghiti wrote: This commit takes care of stack randomization and stack guard gap when computing mmap base address and checks if the task asked for randomization. This fixes the problem uncovered and not fixed for arm here:

Re: [PATCH v16 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-08-02 Thread Sergei Shtylyov
Hello! On 07/31/2019 05:14 AM, Mason Yang wrote: > Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. > > Signed-off-by: Mason Yang > Signed-off-by: Sergei Shtylyov [...] > diff --git a/drivers/spi/spi-renesas-rpc.c b/drivers/spi/spi-renesas-rpc.c > new file m

Re: [PATCH net-next] net: can: Fix compiling warning

2019-08-02 Thread Sergei Shtylyov
Hello! On 02.08.2019 6:36, Mao Wenan wrote: There are two warings in net/can, fix them by setting bcm_sock_no_ioctlcmd Warnings. :-) and raw_sock_no_ioctlcmd as static. net/can/bcm.c:1683:5: warning: symbol 'bcm_sock_no_ioctlcmd' was not declared. Should it be static?

Re: [PATCH v2 10/11] vsock_test: skip read() in test_stream*close tests on a VMCI host

2019-08-01 Thread Sergei Shtylyov
Hello! On 08/01/2019 06:25 PM, Stefano Garzarella wrote: > When VMCI transport is used, if the guest closes a connection, > all data is gone and EOF is returned, so we should skip the read > of data written by the peer before closing the connection. > > Reported-by: Jorgen Hansen >

Re: [PATCH net-next v2 3/4] dt-bindings: net: fsl: enetc: Add bindings for the central MDIO PCIe endpoint

2019-07-25 Thread Sergei Shtylyov
Hello! On 07/25/2019 02:19 PM, Claudiu Manoil wrote: > The on-chip PCIe root complex that integrates the ENETC ethernet > controllers also integrates a PCIe enpoint for the MDIO controller > provinding for cetralized control of the ENETC mdio bus. Providing, centralized. > Add bindings for

Re: [PATCH] MIPS: Kconfig: remove HAVE_LATENCYTOP_SUPPORT

2019-07-16 Thread Sergei Shtylyov
Hello! On 15.07.2019 19:08, Fabian Mewes wrote: HAVE_LATENCYTOP_SUPPORT was removed all together in da48d094ce5d7. You need to also specify that commit's summary enclosed in (""). This commit removes a leftover in the MIPS Kconfig. Signed-off-by: Fabian Mewes MBR, Sergei

Re: [PATCH v8 3/5] mtd: Add support for HyperBus memory devices

2019-07-11 Thread Sergei Shtylyov
Hello! On 06/25/2019 10:57 AM, Vignesh Raghavendra wrote: > Cypress' HyperBus is Low Signal Count, High Performance Double Data Rate > Bus interface between a host system master and one or more slave > interfaces. HyperBus is used to connect microprocessor, microcontroller, > or ASIC devices

Re: [PATCH v2 05/10] net: hisilicon: HI13X1_GMAX need dreq reset at first

2019-07-09 Thread Sergei Shtylyov
Hello! On 09.07.2019 6:31, Jiangfeng Xiao wrote: HI13X1_GMAC delete request for soft reset at first, otherwise, the subsequent initialization will not take effect. Signed-off-by: Jiangfeng Xiao --- drivers/net/ethernet/hisilicon/hip04_eth.c | 24 1 file changed,

Re: [PATCH] usb: roles: Add PM callbacks

2019-07-08 Thread Sergei Shtylyov
Hello! On 08.07.2019 5:25, Chen, Hu wrote: On some Broxton NUC, the usb role is lost after S3 (it becomes "none"). Add PM callbacks to address this issue: save the role during suspend and restore usb to that role during resume. Test: Run Android on UC6CAY, a NUC powered by Broxton. Access

Re: [PATCH][next] ubifs: remove redundant assignment to pointer fname

2019-07-05 Thread Sergei Shtylyov
On 07/05/2019 11:31 AM, Colin Ian King wrote: >>> From: Colin Ian King >>> >>> The pointer fname rc is being assigned with a value that is never >> >>rc? > > Oops, cut'n'paste error. Do you want me to resend to can this be fixed > when it's applied? That's the question to the

Re: [PATCH][next] ubifs: remove redundant assignment to pointer fname

2019-07-05 Thread Sergei Shtylyov
Hello! On 05.07.2019 1:28, Colin King wrote: From: Colin Ian King The pointer fname rc is being assigned with a value that is never rc? read because the function returns after the assignment. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value")

Re: [PATCH v5 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings

2019-07-04 Thread Sergei Shtylyov
Hello! On 03.07.2019 10:15, Mason Yang wrote: Document the bindings used by the Macronix raw NAND controller. Signed-off-by: Mason Yang --- Documentation/devicetree/bindings/mtd/mxic-nand.txt | 20 1 file changed, 20 insertions(+) create mode 100644

Re: [PATCH v8 3/5] mtd: Add support for HyperBus memory devices

2019-07-03 Thread Sergei Shtylyov
Hello! On 07/03/2019 07:41 AM, Vignesh Raghavendra wrote: >>> Cypress' HyperBus is Low Signal Count, High Performance Double Data Rate >>> Bus interface between a host system master and one or more slave >>> interfaces. HyperBus is used to connect microprocessor, microcontroller, >>> or ASIC

Re: [PATCH v8 3/5] mtd: Add support for HyperBus memory devices

2019-07-02 Thread Sergei Shtylyov
Hello! On 06/25/2019 10:57 AM, Vignesh Raghavendra wrote: > Cypress' HyperBus is Low Signal Count, High Performance Double Data Rate > Bus interface between a host system master and one or more slave > interfaces. HyperBus is used to connect microprocessor, microcontroller, > or ASIC devices

Re: [PATCH] USB: gadget: function: fix issue Unneeded variable: "value"

2019-07-01 Thread Sergei Shtylyov
Hello! On 07/01/2019 09:20 PM, Hariprasad Kelam wrote: > fix below issue reported by coccicheck > drivers/usb/gadget/function/f_eem.c:169:7-12: Unneeded variable: > "value". Return "- EOPNOTSUPP" on line 179 > > We can not change return type of eem_setup as its registed with callback

Re: [PATCH v8 3/5] mtd: Add support for HyperBus memory devices

2019-06-25 Thread Sergei Shtylyov
Hello! On 06/25/2019 10:57 AM, Vignesh Raghavendra wrote: > Cypress' HyperBus is Low Signal Count, High Performance Double Data Rate > Bus interface between a host system master and one or more slave > interfaces. HyperBus is used to connect microprocessor, microcontroller, > or ASIC devices

Re: [PATCH net-next] net: stmmac: Fix the case when PHY handle is not present

2019-06-25 Thread Sergei Shtylyov
On 25.06.2019 13:29, Sergei Shtylyov wrote: Some DT bindings do not have the PHY handle. Let's fallback to manually discovery in case phylink_of_phy_connect() fails. Reported-by: Katsuhiro Suzuki Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove phylib logic")

Re: [PATCH net-next] net: stmmac: Fix the case when PHY handle is not present

2019-06-25 Thread Sergei Shtylyov
Hello! On 25.06.2019 11:19, Jose Abreu wrote: Some DT bindings do not have the PHY handle. Let's fallback to manually discovery in case phylink_of_phy_connect() fails. Reported-by: Katsuhiro Suzuki Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove phylib logic") Signed-off-by:

Re: [PATCH v7 3/5] mtd: Add support for HyperBus memory devices

2019-06-21 Thread Sergei Shtylyov
Hello! On 06/20/2019 08:22 PM, Vignesh Raghavendra wrote: > Cypress' HyperBus is Low Signal Count, High Performance Double Data Rate > Bus interface between a host system master and one or more slave > interfaces. HyperBus is used to connect microprocessor, microcontroller, > or ASIC devices

Re: [PATCH 6/6] usb: bdc: Update compatible match strings

2019-06-21 Thread Sergei Shtylyov
Hello! On 21.06.2019 0:09, Al Cooper wrote: Remove "brcm,bdc-v0.16" because it was never used on any system. You're not really removing it, are you? Add "brcm,bdc-udc-v3.1" which exists for any STB system with BDC. Signed-off-by: Al Cooper --- drivers/usb/gadget/udc/bdc/bdc_core.c |

Re: [PATCH v7 4/5] dt-bindings: mtd: Add bindings for TI's AM654 HyperBus memory controller

2019-06-20 Thread Sergei Shtylyov
On 06/20/2019 08:22 PM, Vignesh Raghavendra wrote: > Add binding documentation for TI's HyperBus memory controller present on > AM654 SoC. > > Signed-off-by: Vignesh Raghavendra > --- > > v7: Fix example to move HyperBus node out of syscon > v6: Use generic names for bindings > >

Re: [PATCH net] net: mvpp2: prs: Don't override the sign bit in SRAM parser shift

2019-06-20 Thread Sergei Shtylyov
On 19.06.2019 17:54, Maxime Chevallier wrote: The Header Parser allows identifying various fields in the packet headers, used for for various kind of filtering and classification One "for" is enough. :-) steps. This is a re-entrant process, where the offset in the packet header depends

Re: [PATCH] mlxsw: spectrum_ptp: fix 32-bit build

2019-06-20 Thread Sergei Shtylyov
Hello! On 19.06.2019 16:31, Arnd Bergmann wrote: On 32-bit architectures, we cannot easily device 64-bit numbers: s/device/divide/? ERROR: "__aeabi_uldivmod" [drivers/net/ethernet/mellanox/mlxsw/mlxsw_spectrum.ko] undefined! Use do_div() to annotate the fact that we know this is an

Re: [PATCH v5 3/5] mtd: Add support for HyperBus memory devices

2019-06-17 Thread Sergei Shtylyov
Hello! On 06/11/2019 02:57 PM, Vignesh Raghavendra wrote: >>> Cypress' HyperBus is Low Signal Count, High Performance Double Data Rate >>> Bus interface between a host system master and one or more slave >>> interfaces. HyperBus is used to connect microprocessor, microcontroller, >>> or ASIC

Re: [PATCH 15/17] binfmt_flat: move the MAX_SHARED_LIBS definition to binfmt_flat.c

2019-06-14 Thread Sergei Shtylyov
Hello! On 13.06.2019 10:09, Christoph Hellwig wrote: MAX_SHARED_LIBS is an implementation detail of the kernel loader, and should be kept away from the file format definition. Signed-off-by: Christoph Hellwig --- fs/binfmt_flat.c | 6 ++ include/linux/flat.h | 6 -- 2 files

Re: [RFC 3/3] ata: sata_mv, avoid trigerrable BUG_ON

2019-06-14 Thread Sergei Shtylyov
Hello! On 14.06.2019 10:11, Jiri Slaby wrote: There are several reports that the BUG_ON on unsupported command in mv_qc_prep can be triggered under some circumstances: https://bugzilla.suse.com/show_bug.cgi?id=1110252 https://serverfault.com/questions/97/raid-problems-after-power-outage

Re: [PATCH v5 3/5] mtd: Add support for HyperBus memory devices

2019-06-10 Thread Sergei Shtylyov
On 06/09/2019 01:32 PM, Vignesh Raghavendra wrote: > Cypress' HyperBus is Low Signal Count, High Performance Double Data Rate > Bus interface between a host system master and one or more slave > interfaces. HyperBus is used to connect microprocessor, microcontroller, > or ASIC devices with random

Re: [PATCH v5 4/5] dt-bindings: mtd: Add bindings for TI's AM654 HyperBus memory controller

2019-06-10 Thread Sergei Shtylyov
Hello! On 06/09/2019 01:32 PM, Vignesh Raghavendra wrote: > Add binding documentation for TI's HyperBus memory controller present on > AM654 SoC. > > Signed-off-by: Vignesh Raghavendra > --- > v5: > Update binding example to show MMIO mux > Fix reg property for flash slave. > >

Re: [PATCH trivial] qed: Spelling s/configuraion/configuration/

2019-06-08 Thread Sergei Shtylyov
Again, typo in the subject. :-) On 07.06.2019 14:25, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven [...] MBR, Sergei

Re: [PATCH] sh: dma: Add missing IS_ERR test

2019-06-08 Thread Sergei Shtylyov
Hello! On 07.06.2019 14:54, Rolf Evers-Fischer wrote: get_dma_channel may return ERR_PTR, so a check is added. Signed-off-by: Rolf Evers-Fischer --- arch/sh/drivers/dma/dma-api.c | 20 +++- arch/sh/drivers/dma/dma-sysfs.c | 2 +- 2 files changed, 20 insertions(+), 2

Re: [PATCH trivial] net/mlx5e: Spelling s/configuraion/configuration/

2019-06-07 Thread Sergei Shtylyov
Hello! On 06/07/2019 02:10 PM, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven Unfortunately, while fixing this typo, you made another one, in your subject. ;-) [...] MBR, Sergei

Re: [RESEND][PATCH v3 1/2] usb: dwc3: Add avoiding vbus glitch happen during xhci reset

2019-06-06 Thread Sergei Shtylyov
Hello! On 06.06.2019 5:54, Ran Wang wrote: When DWC3 is set to host mode by programming register DWC3_GCTL, VBUS (or its control signal) will turn on immediately on related Root Hub ports. Then the VBUS will be de-asserted for a little while during xhci reset (conducted by xhci driver) for a

Re: [PATCH v13 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF controller bindings

2019-06-03 Thread Sergei Shtylyov
Hello! On 06/03/2019 04:04 PM, Lee Jones wrote: >>> Document the bindings used by the Renesas R-Car Gen3 RPC-IF controller. >>> >>> Signed-off-by: Mason Yang >>> --- >>> .../devicetree/bindings/mfd/renesas-rpc-if.txt | 65 >>> ++ >>> 1 file changed, 65 insertions(+)

Re: [PATCH] hooks: fix a missing-check bug in selinux_add_mnt_opt()

2019-05-30 Thread Sergei Shtylyov
On 30.05.2019 12:18, Gen Zhang wrote: On 30.05.2019 11:06, Gen Zhang wrote: In selinux_add_mnt_opt(), 'val' is allcoted by kmemdup_nul(). It returns Allocated? Thanks for your reply, Sergei. I used 'allocated' because kmemdup_nul() does some allocation in its implementation. And its

Re: [PATCH] hooks: fix a missing-check bug in selinux_add_mnt_opt()

2019-05-30 Thread Sergei Shtylyov
Hello! On 30.05.2019 11:06, Gen Zhang wrote: In selinux_add_mnt_opt(), 'val' is allcoted by kmemdup_nul(). It returns Allocated? NULL when fails. So 'val' should be checked. Signed-off-by: Gen Zhang [...] MBR, Sergei

Re: [PATCH bpf] libbpf: Return btf_fd in libbpf__probe_raw_btf

2019-05-29 Thread Sergei Shtylyov
Hello! On 29.05.2019 11:29, Michal Rostecki wrote: Function load_sk_storage_btf expects that libbpf__probe_raw_btf is returning a btf descriptor, but before this change it was returning an information about whether the probe was successful (0 or 1). load_sk_storage_btf was using that value as

Re: [PATCH V3] hsr: fix don't prune the master node from the node_db

2019-05-23 Thread Sergei Shtylyov
Hello! On 23.05.2019 10:02, Andreas Oetken wrote: Don't prune master node in the hsr_prune_nodes function. Neither time_in[HSR_PT_SLAVE_A], nor time_in[HSR_PT_SLAVE_B], will ever be updated by hsr_register_frame_in for the master port. Thus the master node will be repeatedly pruned leading to

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-22 Thread Sergei Shtylyov
On 05/22/2019 08:05 PM, Geert Uytterhoeven wrote: >> On 05/20/2019 10:23 AM, masonccy...@mxic.com.tw wrote: >>> +- clocks: should contain 1 entries for the module's clock >> >>1 entry (clock node phandle and specifier). > > Doesn't "specifier" mean "phandle + optional arguments"? No.

Re: [PATCH v13 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF controller bindings

2019-05-22 Thread Sergei Shtylyov
On 05/21/2019 10:19 AM, Mason Yang wrote: > Document the bindings used by the Renesas R-Car Gen3 RPC-IF controller. > > Signed-off-by: Mason Yang > --- > .../devicetree/bindings/mfd/renesas-rpc-if.txt | 65 > ++ > 1 file changed, 65 insertions(+) > create mode 100644

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-22 Thread Sergei Shtylyov
On 05/20/2019 10:23 AM, masonccy...@mxic.com.tw wrote: > --> > > Renesas R-Car Gen3 RPC-IF controller Device Tree Bindings > - > > RPC-IF supports both SPI

Re: [PATCH v5 2/6] net: stmmac: sun8i: force select external PHY when no internal one

2019-05-21 Thread Sergei Shtylyov
Hello! On 21.05.2019 2:50, meg...@megous.com wrote: From: Icenowy Zheng The PHY selection bit also exists on SoCs without an internal PHY; if it's set to 1 (internal PHY, default value) then the MAC will not make use of any PHY such SoCs. ^ "on" or "with" missing? This problem

Re: [PATCH] of_net: fix of_get_mac_address retval if compiled without CONFIG_OF

2019-05-20 Thread Sergei Shtylyov
Hello! On 19.05.2019 15:18, Petr Štetiar wrote: of_get_mac_address prior to commit d01f449c008a ("of_net: add NVMEM support to of_get_mac_address") could return only valid pointer or NULL, after this change it could return only valid pointer or ERR_PTR encoded error value, but I've forget to

Re: [PATCH] drm: rcar-du: writeback: include interface header

2019-05-18 Thread Sergei Shtylyov
Hello! On 18.05.2019 0:20, Kieran Bingham wrote: The new writeback feature is exports functions so that they can ^^ not needed? integrate into the rcar_du_kms module. The interface functions are defined in the rcar_du_writeback header, but it is not included in

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-14 Thread Sergei Shtylyov
On 05/14/2019 12:46 PM, masonccy...@mxic.com.tw wrote: There's precedence for such constructs being an MFD: please see drivers/mfd/at91-usart.c, which registers a single MFD cell for > either serial or SPI. >> >>Thanks fir your example, Geert! :-) s/fir/for/, not the

Re: [PATCH v9 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-05-14 Thread Sergei Shtylyov
On 05/14/2019 10:06 PM, Sergei Shtylyov wrote: [...] >>>>>>>> Have you tested reading? v8 patch still works while v9 patches >>>>>>>> hang on doing: >>>>>>>> >>>>>>>> $ cat /dev/mtd... >>>

Re: [PATCH v9 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-05-14 Thread Sergei Shtylyov
Hello! On 04/19/2019 08:38 AM, masonccy...@mxic.com.tw wrote: >> >> >> >> Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. >> >> >> >> >> >> >> >> Signed-off-by: Mason Yang >> >> >> >> S

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-13 Thread Sergei Shtylyov
Hello! On 05/13/2019 12:37 PM, masonccy...@mxic.com.tw wrote: >> > > [...] >> > > >> > >> > On 4/24/19 11:23 PM, Rob Herring wrote: >> > > >> > >> > > On Wed, Apr 24, 2019 at 03:55:36PM +0800, Mason Yang wrote: >> > > >> > >> > >> Document the bindings used by the Renesas R-Car >> Gen3 RPC-IF

Re: [PATCH v4 5/5] mtd: hyperbus: Add driver for TI's HyperBus memory controller

2019-04-27 Thread Sergei Shtylyov
On 04/23/2019 01:48 PM, Vignesh Raghavendra wrote: > Add driver for HyperBus memory controller on TI's AM654 SoC. Programming > IP is pretty simple and provides direct memory mapped access to > connected Flash devices. > > Add basic support for the IP without DMA. Second chipSelect is not >

Re: [PATCH v4 1/5] mtd: cfi_cmdset_0002: Add support for polling status register

2019-04-27 Thread Sergei Shtylyov
Hello! On 04/23/2019 01:48 PM, Vignesh Raghavendra wrote: > HyperFlash devices are compliant with CFI AMD/Fujitsu Extended Command > Set(0x0002) for flash operations, therefore > drivers/mtd/chips/cfi_cmdset_0002.c > can be used as is. But these devices do not support DQ polling method of >

Re: [PATCH v3 2/2] thermal: rcar_gen3_thermal: disable interrupt in .remove

2019-04-23 Thread Sergei Shtylyov
On 04/23/2019 05:14 PM, Jiada Wang wrote: > Currently IRQ is remain enabled after .remove, later if device is probed, IRQ remains enabled. > IRQ is requested before .thermal_init, this may cause IRQ function be > called before device is initialized. > > this patch by disable interrupt in

Re: [PATCH v11 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-04-22 Thread Sergei Shtylyov
On 04/22/2019 09:32 PM, Sergei Shtylyov wrote: >> Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. >> >> Signed-off-by: Mason Yang >> Signed-off-by: Sergei Shtylyov > [...] > > Do dote that I'm opposed to the driver separation as it's pr

Re: [PATCH v10 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF controller bindings

2019-04-18 Thread Sergei Shtylyov
Hello! On 04/18/2019 08:55 AM, masonccy...@mxic.com.tw wrote: >> > > > Document the bindings used by the Renesas R-Car Gen3 RPC-IF >> MFD controller. >> > > > >> > > > Signed-off-by: Mason Yang >> > > > --- >> > > > .../devicetree/bindings/mfd/mfd-renesas-rpc.txt | 37 + >> > >

Re: [PATCH v3 0/5] MTD: Add Initial Hyperbus support

2019-04-18 Thread Sergei Shtylyov
Hello! On 04/17/2019 08:24 PM, Vignesh Raghavendra wrote: >> Vignesh Raghavendra (5): >>mtd: cfi_cmdset_0002: Add support for polling status register >>dt-bindings: mtd: Add binding documentation for HyperFlash >>mtd: Add support for HyperBus memory devices >>dt-bindings: mtd:

Re: [PATCH v10 1/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD controller driver

2019-04-15 Thread Sergei Shtylyov
The patch name is somewhat misleading -- there's no "MFD controller". On 04/15/2019 10:37 AM, Mason Yang wrote: > Add a driver for Renesas R-Car Gen3 RPC-IF MFD controller. > > Signed-off-by: Mason Yang [...] > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 26ad646..7914349

Re: [PATCH v3 4/5] dt-bindings: mtd: Add bindings for TI's AM654 HyperBus memory controller

2019-04-14 Thread Sergei Shtylyov
On 04/12/2019 12:29 PM, Vignesh Raghavendra wrote: > Add binding documentation for TI's HyperBus memory controller present on > AM654 SoC. > > Signed-off-by: Vignesh Raghavendra > --- > .../devicetree/bindings/mtd/ti,am654-hbmc.txt | 31 +++ > MAINTAINERS

Re: [PATCH v3 3/5] mtd: Add support for HyperBus memory devices

2019-04-14 Thread Sergei Shtylyov
Hello! On 04/12/2019 12:29 PM, Vignesh Raghavendra wrote: > Cypress' HyperBus is Low Signal Count, High Performance Double Data Rate > Bus interface between a host system master and one or more slave > interfaces. HyperBus is used to connect microprocessor, microcontroller, > or ASIC devices

Re: [PATCH 1/2] mtd: nandsim: Embed struct nand_chip in struct nandsim

2019-04-13 Thread Sergei Shtylyov
Hello! On 13.04.2019 11:40, Richard Weinberger wrote: We well need struct nand_controller soon, so more stuff need to We will, maybe? be parts of struct nandsim. While we are here, rename "nand" to "ns" to use the same naming scheme everywhere in nandsim. Signed-off-by: Richard

Re: [PATCH v9 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-04-04 Thread Sergei Shtylyov
Hello! On 04/03/2019 12:20 PM, masonccy...@mxic.com.tw wrote: >> >> > +static void rpc_spi_mem_set_prep_op_cfg(struct spi_device *spi, >> >> > + const struct spi_mem_op *op, >> >> > + u64 *offs, size_t *len) >> >> > +{ >> >> > + struct rpc_spi *rpc =

Re: [RFC PATCH v2 5/5] mtd: hyperbus: Add driver for TI's Hyperbus memory controller

2019-03-26 Thread Sergei Shtylyov
On 03/21/2019 08:45 PM, Vignesh Raghavendra wrote: > Add driver for Hyperbus memory controller on TI's AM654 SoC. Programming > IP is pretty simple and provides direct memory mapped access to > connected Flash devices. > > Add basic support for the IP without DMA. Second ChipSelect is not >

Re: [RFC PATCH v2 3/5] mtd: Add support for Hyperbus memory devices

2019-03-26 Thread Sergei Shtylyov
On 25.03.2019 23:13, Sergei Shtylyov wrote: Cypress' Hyperbus is Low Signal Count, High Performance Double Data Rate It's HyperBus, according to the spec... Bus interface between a host system master and one or more slave interfaces. Hyperbus is used to connect microprocessor

Re: [RFC PATCH v2 3/5] mtd: Add support for Hyperbus memory devices

2019-03-25 Thread Sergei Shtylyov
Hello! On 03/21/2019 08:45 PM, Vignesh Raghavendra wrote: > Cypress' Hyperbus is Low Signal Count, High Performance Double Data Rate It's HyperBus, according to the spec... > Bus interface between a host system master and one or more slave > interfaces. Hyperbus is used to connect

Re: [RFC PATCH v2 1/5] mtd: cfi_cmdset_0002: Add support for polling status register

2019-03-24 Thread Sergei Shtylyov
Hello! On 03/21/2019 08:45 PM, Vignesh Raghavendra wrote: > HyperFlash devices are compliant with CFI AMD/Fujitsu Extended Command > Set(0x0002) for flash operations, therefore > drivers/mtd/chips/cfi_cmdset_0002.c > can be use as is. But these devices do not support DQ polling method of >

Re: [RFC PATCH v2 2/5] dt-bindings: mtd: Add binding documentation for Hyperbus memory devices

2019-03-24 Thread Sergei Shtylyov
Hello! On 03/21/2019 08:45 PM, Vignesh Raghavendra wrote: > Add DT binding documentation for Hyperbus memory devices. Only > Hyperflash is supported at the moment. > > Signed-off-by: Vignesh Raghavendra > --- > Documentation/devicetree/bindings/mtd/cypress,hyperbus.txt | 6 ++ > 1 file

Re: [PATCH 9/9] drivers: ata: sata_rcar: use devm_platform_ioremap_resource()

2019-03-12 Thread Sergei Shtylyov
On 03/12/2019 12:19 PM, Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult Reviewed-by: Sergei Shtylyov [...] MBR, Sergei

Re: [PATCH 4/9] drivers: ata: ahci_xgene: use devm_platform_ioremap_resource()

2019-03-12 Thread Sergei Shtylyov
Hello! On 03/12/2019 12:19 PM, Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- > drivers/ata/ahci_xgene.c | 21 +++-- >

Re: [PATCH] ata: pata_oldpiix: Add missing device ID for INTEL_82371AB

2019-03-12 Thread Sergei Shtylyov
On 03/12/2019 01:41 PM, LABBE Corentin wrote: >>> When playing with a virtual SPARC machine with qemu, I found that the >>> IDE emulated device was not probing with the ata/pata_oldpiix driver. >> >>Correctly, it should probe with ata_piix, >> >>> But with the old ide/piix, it was probed.>

Re: [PATCH v8 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-03-08 Thread Sergei Shtylyov
Hello! On 03/08/2019 12:14 PM, Geert Uytterhoeven wrote: >>> Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. >>> >>> Signed-off-by: Mason Yang >>> Signed-off-by: Sergei Shtylyov >> [...] >>> diff --git a/drivers/spi/spi-renesas-rpc.

Re: [PATCH v8 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-03-07 Thread Sergei Shtylyov
Hello! On 01/28/2019 09:49 AM, Mason Yang wrote: > Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. > > Signed-off-by: Mason Yang > Signed-off-by: Sergei Shtylyov [...] > diff --git a/drivers/spi/spi-renesas-rpc.c b/drivers/spi/spi-renesas-rpc.c > new file m

Re: [PATCH] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm

2019-03-04 Thread Sergei Shtylyov
Hello! On 04.03.2019 8:46, Su Yanjun wrote: For rcu protected pointers, we'd bettter add '__rcu' for them. 2 t's were enough. :-) No functional change. Signed-off-by: Su Yanjun [...] MBR, Sergei

Re: [PATCH] netfilter: nf_ct_helper: Fix possible panic when nf_conntrack_helper_unregister is used in an unloadable module

2019-03-01 Thread Sergei Shtylyov
Hello! On 01.03.2019 8:56, Su Yanjun wrote: From: Su Yanjun Because nf_conntrack_helper_unregister maybe used in an unloadable module, it uses 'synchronize_rcu' which may cause kernel panic. According to the artical: Article? RCU and Unloadable Modules

Re: [RFC PATCH 5/5] mtd: hyperbus: Add driver for TI's Hyperbus memory controller

2019-02-26 Thread Sergei Shtylyov
On 02/19/2019 09:36 AM, Vignesh R (by way of Boris Brezillon ) wrote: > Add driver for Hyperbus memory controller on TI's AM654 SoC. Programming > IP is pretty simple and provides direct memory mapped access to > connected Flash devices. > > Add basic support for the IP without DMA. Second

Re: [RFC PATCH 3/5] mtd: Add support for Hyperbus memory devices

2019-02-26 Thread Sergei Shtylyov
On 02/19/2019 09:36 AM, Vignesh R (by way of Boris Brezillon ) wrote: > Cypress HyperBus is Low Signal Count, High Performance Double Data Rate Bus > interface between a host system master and one or more slave interfaces. > HyperBus is used to connect microprocessor, microcontroller, or ASIC >

Re: [RFC PATCH 3/5] mtd: Add support for Hyperbus memory devices

2019-02-26 Thread Sergei Shtylyov
On 02/26/2019 01:26 PM, Vignesh R wrote: >> [...] > HyperBus specification can be found at[1] > HyperFlash datasheet can be found at[2] > > [1] https://www.cypress.com/file/213356/download > [2] https://www.cypress.com/file/213346/download > [3]

Re: [RFC PATCH 3/5] mtd: Add support for Hyperbus memory devices

2019-02-25 Thread Sergei Shtylyov
On 02/25/2019 09:21 PM, Vignesh R wrote: [...] >>> HyperBus specification can be found at[1] >>> HyperFlash datasheet can be found at[2] >>> >>> [1] https://www.cypress.com/file/213356/download >>> [2] https://www.cypress.com/file/213346/download >>> [3]

Re: [RFC PATCH 3/5] mtd: Add support for Hyperbus memory devices

2019-02-25 Thread Sergei Shtylyov
On 02/19/2019 09:36 AM, Vignesh R (by way of Boris Brezillon ) wrote: > Cypress HyperBus is Low Signal Count, High Performance Double Data Rate Bus > interface between a host system master and one or more slave interfaces. > HyperBus is used to connect microprocessor, microcontroller, or ASIC >

Re: [RFC PATCH 5/5] mtd: hyperbus: Add driver for TI's Hyperbus memory controller

2019-02-25 Thread Sergei Shtylyov
Hello! On 02/19/2019 09:36 AM, Vignesh R (by way of Boris Brezillon ) wrote: > Add driver for Hyperbus memory controller on TI's AM654 SoC. Programming > IP is pretty simple and provides direct memory mapped access to > connected Flash devices. Are you sure you posted the _complete_ driver?

Re: [RFC PATCH 5/5] mtd: hyperbus: Add driver for TI's Hyperbus memory controller

2019-02-24 Thread Sergei Shtylyov
Hello! On 19.02.2019 9:36, Vignesh R (by way of Boris Brezillon ) wrote: Add driver for Hyperbus memory controller on TI's AM654 SoC. Programming IP is pretty simple and provides direct memory mapped access to connected Flash devices. Add basic support for the IP without DMA. Second

Re: [RFC PATCH 3/5] mtd: Add support for Hyperbus memory devices

2019-02-23 Thread Sergei Shtylyov
Hello! On 02/19/2019 09:36 AM, Vignesh R (by way of Boris Brezillon ) wrote: > Cypress HyperBus is Low Signal Count, High Performance Double Data Rate Bus > interface between a host system master and one or more slave interfaces. > HyperBus is used to connect microprocessor, microcontroller, or

Re: [RFC PATCH 1/5] mtd: cfi_cmdset_0002: Add support for polling status register

2019-02-23 Thread Sergei Shtylyov
On 02/19/2019 09:36 AM, Vignesh R (by way of Boris Brezillon ) wrote: > HyperFlash devices are compliant with CFI AMD/Fujitsu Extended Command > Set(0x0002) for flash operations, therefore > drivers/mtd/chips/cfi_cmdset_0002.c > can be use as is. But these devices do not support DQ polling

Re: [RFC PATCH 1/5] mtd: cfi_cmdset_0002: Add support for polling status register

2019-02-23 Thread Sergei Shtylyov
Hello! On 02/19/2019 09:36 AM, Vignesh R (by way of Boris Brezillon ) wrote: > HyperFlash devices are compliant with CFI AMD/Fujitsu Extended Command > Set(0x0002) for flash operations, therefore > drivers/mtd/chips/cfi_cmdset_0002.c > can be use as is. But these devices do not support DQ

Re: [PATCH v2 02/10] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960

2019-02-19 Thread Sergei Shtylyov
Hello! On 18.02.2019 14:23, Yu Chen wrote: This patch adds binding documentation to support usb hub and usb data role switch of Hisilicon HiKey960 Board. Cc: Sergei Shtylyov Cc: Rob Herring Cc: Mark Rutland Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- v1: * Fix some

Re: [PATCH] net: mv643xx_eth: disable clk on error path in mv643xx_eth_shared_probe()

2019-02-16 Thread Sergei Shtylyov
On 16.02.2019 0:20, Alexey Khoroshilov wrote: If mv643xx_eth_shared_of_probe() fails, mv643xx_eth_shared_probe() leaves clk undisabled. Enabled, that is? :-) Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov [...] MBR, Sergei

Re: [PATCH] ata: fix a race condition when internal cmd time out

2019-02-15 Thread Sergei Shtylyov
Hello! On 16.02.2019 6:42, Jason Yan wrote: For internal cmds, we will unmap DMA memory associated with the cmd before we abort the cmd. If DMA transfering data before the aborting, Transferring. bus error will occured. Occur. ata_exec_internal_sg ->ata_port_freeze if timeout

Re: [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any

2019-02-14 Thread Sergei Shtylyov
Hello! On 14.02.2019 9:42, Huang Zijiang wrote: The skb should be freed by dev_consume_skb_any() efx_tx_tso_fallback() ^ in? when skb is still used. The skb is be replaced by segments, so the ^^ will?

Re: [PATCH v3 7/9] usb: typec: Find the ports by also matching against the device node

2019-02-13 Thread Sergei Shtylyov
On 13.02.2019 10:45, Heikki Krogerus wrote: When the connections are defined in firmware, struct device_connection will have the fwnode member pointing to the device node (struct fwnode_handle) of the requested device, and the endpoint will not be used at all in that case. Acked-by: Hans de

Re: [PATCH v3 1/9] platform/x86: intel_cht_int33fe: Prepare for better mux naming scheme

2019-02-13 Thread Sergei Shtylyov
Hello! On 13.02.2019 10:45, Heikki Krogerus wrote: Adding new connections with for the muxes with new I can't parse this. :-) identifiers. The old connection are left in for now. Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko Reviewed-by: Jun

Re: [PATCH v5 3/6] math64: New DIV64_U64_ROUND_CLOSEST helper

2019-02-11 Thread Sergei Shtylyov
On 02/11/2019 04:58 PM, Simon Horman wrote: > Provide DIV64_U64_ROUND_CLOSEST helper which performs division rounded to > the closes integer using an unsigned 64bit dividend and divisor. Closest? > This will be used in a follow-up patch to allow calculation of clock > divisors with high

Re: [PATCH] mt76: change the retun type of mt76_dma_attach()

2019-02-11 Thread Sergei Shtylyov
Hello! On 11.02.2019 5:13, Ryder Lee wrote: There is no need to retun 0 in mt76_dma_attach(), so switch it to void. ^ r missing :-) Signed-off-by: Ryder Lee [...] MBR, Sergei

Re: [PATCH][next] can: at91_can: mark expected switch fall-throughs

2019-02-09 Thread Sergei Shtylyov
On 02/08/2019 09:55 PM, Sergei Shtylyov wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> Notice that, in this particular case, the /* fall through */ >> comments are placed at the botto

<    1   2   3   4   5   6   7   8   9   10   >