Re: [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm control

2015-07-21 Thread Shobhit Kumar
On Fri, Jul 10, 2015 at 6:36 PM, Shobhit Kumar wrote: > On Mon, Jun 29, 2015 at 3:48 AM, Paul Gortmaker > wrote: >> [Re: [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm >> control] On 26/06/2015 (Fri 20:47) Ville Syrjälä wrote: >> >>> On Fri,

Re: [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm control

2015-07-10 Thread Shobhit Kumar
n 26, 2015 at 02:32:03PM +0530, Shobhit Kumar wrote: >> > > Hi, >> > > Next update of the series reviewed at >> > > https://lkml.org/lkml/2015/6/22/155 >> > > >> > > Major changes are few review comments from Varka and Ville being >>

Re: [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm control

2015-06-27 Thread Shobhit Kumar
On Fri, Jun 26, 2015 at 11:17 PM, Ville Syrjälä wrote: > On Fri, Jun 26, 2015 at 06:31:37PM +0200, Daniel Vetter wrote: >> On Fri, Jun 26, 2015 at 02:32:03PM +0530, Shobhit Kumar wrote: >> > Hi, >> > Next update of the series reviewed at >> > https://lkml.or

[v3 1/7] gpiolib: Add support for removing registered consumer lookup table

2015-06-26 Thread Shobhit Kumar
: Alexandre Courbot Reviewed-by: Linus Walleij Tested-by: Ville Syrjälä Signed-off-by: Shobhit Kumar --- v2: Ccing maintainers v3: Correct the subject line (Lee jones) drivers/gpio/gpiolib.c | 13 + include/linux/gpio/machine.h | 1 + 2 files changed, 14 insertions(+) diff --git a

[v3 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-26 Thread Shobhit Kumar
eding Reviewed-by: Ville Syrjälä Tested-by: Ville Syrjälä Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/intel_drv.h | 4 ++ drivers/gpu/drm/i915/intel_dsi.c | 5 ++ drivers/gpu/drm/i915/intel_panel.c | 94 -- 3 files changed, 98 insertions(+), 5 dele

[v3 6/7] drm/i915: Use the CRC gpio for panel enable/disable

2015-06-26 Thread Shobhit Kumar
(Ville) v4: Moved PWM vs SoC backlight #defines to intel_bios.h (Jani) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Acked-by: Linus Walleij Reviewed-by: Jani Nikula Tested-by: Ville Syrjälä Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/intel_bios.h

[v3 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-06-26 Thread Shobhit Kumar
Cc: Thierry Reding Cc: Paul Bolle Cc: Paul Gortmaker Tested-by: Ville Syrjälä Signed-off-by: Shobhit Kumar --- v2: Use the existing config callback with duty_ns and period_ns(Thierry) v3: Correct the subject line (Lee jones) v4: Address comment by Thierry & Paul - Commit message up

[v3 2/7] mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal

2015-06-26 Thread Shobhit Kumar
-by: Linus Walleij Tested-by: Ville Syrjälä Signed-off-by: Shobhit Kumar --- v2: Make the lookup table static (Thierry) Remove the lookup table during driver remove (Thierry) v3: Correct the subject line (Lee jones) drivers/mfd/intel_soc_pmic_core.c | 17 + 1 file changed, 17

[v3 3/7] mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC

2015-06-26 Thread Shobhit Kumar
Needed for PWM control suuported by the PMIC CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Acked-by: Lee Jones Tested-by: Ville Syrjälä Signed-off-by: Shobhit Kumar --- v2: Correct the subject line (Lee jones) drivers/mfd/intel_soc_pmic_crc.c | 3 +++ 1 file

[v3 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM

2015-06-26 Thread Shobhit Kumar
On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup entry for the same to be used by the consumer (Intel GFX) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Acked-by: Lee Jones Tested-by: Ville Syrjälä Signed-off-by: Shobhit Kumar --- v2

[v3 0/7] Crystalcove (CRC) PMIC based panel and pwm control

2015-06-26 Thread Shobhit Kumar
. Regards Shobhit Shobhit Kumar (7): gpiolib: Add support for removing registered consumer lookup table mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC mfd: intel_soc_pmic_core: ADD PWM lookup

Re: [Intel-gfx] [v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-25 Thread Shobhit Kumar
On Thu, Jun 25, 2015 at 6:17 PM, Ville Syrjälä wrote: > On Thu, Jun 25, 2015 at 05:38:50PM +0530, Shobhit Kumar wrote: >> On Thu, Jun 25, 2015 at 2:18 PM, Ville Syrjälä >> wrote: >> > On Mon, Jun 22, 2015 at 04:24:25PM +0530, Shobhit Kumar wrote: >> >> Use the

Re: [Intel-gfx] [v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM

2015-06-25 Thread Shobhit Kumar
On Tue, Jun 23, 2015 at 12:49 PM, Lee Jones wrote: > On Mon, 22 Jun 2015, Daniel Vetter wrote: > >> On Mon, Jun 22, 2015 at 04:33:22PM +0530, Varka Bhadram wrote: >> > Hi Shobhit Kumar, >> > >> > On 06/22/2015 04:24 PM, Shobhit Kumar wrote: >> >

Re: [Intel-gfx] [v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-25 Thread Shobhit Kumar
On Thu, Jun 25, 2015 at 2:18 PM, Ville Syrjälä wrote: > On Mon, Jun 22, 2015 at 04:24:25PM +0530, Shobhit Kumar wrote: >> Use the CRC PWM device in intel_panel.c and add new MIPI backlight >> specififc callbacks >> >> v2: Modify to use pwm_config callback >&

Re: [Intel-gfx] [v2 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-06-23 Thread Shobhit Kumar
On Mon, Jun 22, 2015 at 4:46 PM, Varka Bhadram wrote: > Hi Shobhit Kumar, > > On 06/22/2015 04:24 PM, Shobhit Kumar wrote: > >> The Crystalcove PMIC provides three PWM signals and this driver exports >> one of them on the BYT platform which is used to control backlight f

[v2 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-06-22 Thread Shobhit Kumar
move the redundant rule of three while calculating pwm level - Use the platform_device in pwm_chip - Use builin_platform_driver CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Cc: Paul Bolle Cc: Paul Gortmaker Signed-off-by: Shobhit Kumar --- drivers/pwm/Kco

[v2 3/7] mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC

2015-06-22 Thread Shobhit Kumar
Needed for PWM control suuported by the PMIC v2: Correct the subject line (Lee jones) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Acked-by: Lee Jones Signed-off-by: Shobhit Kumar --- drivers/mfd/intel_soc_pmic_crc.c | 3 +++ 1 file changed, 3 insertions

[v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM

2015-06-22 Thread Shobhit Kumar
: Thierry Reding Acked-by: Lee Jones Signed-off-by: Shobhit Kumar --- drivers/mfd/intel_soc_pmic_core.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index f3d918e..a00ddd9 100644 --- a/drivers/mfd

[v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-22 Thread Shobhit Kumar
EV in case pwm_get fails - in case pwm_config error return error cdoe from pwm_config - Cleanup pwm in intel_panel_destroy_backlight CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/intel_drv.h

[v2 1/7] gpiolib: Add support for removing registered consumer lookup table

2015-06-22 Thread Shobhit Kumar
Cc: Alexandre Courbot Cc: Thierry Reding Reviewed-by: Alexandre Courbot Reviewed-by: Linus Walleij Signed-off-by: Shobhit Kumar --- drivers/gpio/gpiolib.c | 13 + include/linux/gpio/machine.h | 1 + 2 files changed, 14 insertions(+) diff --git a/drivers/gpio/gpiolib.c b

[v2 2/7] mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal

2015-06-22 Thread Shobhit Kumar
: Correct the subject line (Lee jones) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Acked-by: Lee Jones Acked-by: Linus Walleij Signed-off-by: Shobhit Kumar --- drivers/mfd/intel_soc_pmic_core.c | 17 + 1 file changed, 17 insertions(+) diff --git

[v2 6/7] drm/i915: Use the CRC gpio for panel enable/disable

2015-06-22 Thread Shobhit Kumar
(Ville) v4: Moved PWM vs SoC backlight #defines to intel_bios.h (Jani) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Acked-by: Linus Walleij Reviewed-by: Jani Nikula Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/intel_bios.h | 7 +++ drivers/gpu

[v2 0/7] Crystalcove (CRC) PMIC based panel and pwm control

2015-06-22 Thread Shobhit Kumar
/backlight/intel_backlight interface. Patches were also verified on android-x86 tree for AsusT100. Regards Shobhit Shobhit Kumar (7): gpiolib: Add support for removing registered consumer lookup table mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal mfd

Re: [Intel-gfx] [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver

2015-06-22 Thread Shobhit Kumar
On Sat, Jun 20, 2015 at 11:34 PM, Paul Gortmaker wrote: > [Re: [Intel-gfx] [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver] > On 20/06/2015 (Sat 13:23) Paul Bolle wrote: > >> [Added Paul Gortmaker.] >> >> Hi Shobhit, >> >> On Fri, 2015-06-19 at 12

Re: [Intel-gfx] [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver

2015-06-18 Thread Shobhit Kumar
Hi Paul, On Fri, Jun 19, 2015 at 12:11 AM, Paul Bolle wrote: > Hi Shobhit, > > On Thu, 2015-06-18 at 23:24 +0530, Shobhit Kumar wrote: >> On Fri, May 1, 2015 at 2:42 AM, Paul Bolle wrote: >> > On Wed, 2015-04-29 at 19:30 +0530, Shobhit Kumar wrote: >> >> -

Re: [Intel-gfx] [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver

2015-06-18 Thread Shobhit Kumar
On Fri, May 1, 2015 at 2:42 AM, Paul Bolle wrote: > On Wed, 2015-04-29 at 19:30 +0530, Shobhit Kumar wrote: >> --- a/drivers/pwm/Kconfig >> +++ b/drivers/pwm/Kconfig > >> +config PWM_CRC >> + bool "Intel Crystalcove (CRC) PWM support" >> +

Re: [Intel-gfx] [PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-06-16 Thread Shobhit Kumar
On Wed, May 20, 2015 at 8:39 PM, Shobhit Kumar wrote: > On Thu, May 7, 2015 at 12:49 PM, Shobhit Kumar wrote: >> On Wed, May 6, 2015 at 5:44 PM, Thierry Reding >> wrote: >>> On Tue, May 05, 2015 at 03:08:36PM +0530, Shobhit Kumar wrote: >>>> The Crystalcov

Re: [Intel-gfx] [PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-05-20 Thread Shobhit Kumar
On Thu, May 7, 2015 at 12:49 PM, Shobhit Kumar wrote: > On Wed, May 6, 2015 at 5:44 PM, Thierry Reding > wrote: >> On Tue, May 05, 2015 at 03:08:36PM +0530, Shobhit Kumar wrote: >>> The Crystalcove PMIC controls PWM signals and this driver exports that >> >> You

Re: [Intel-gfx] [PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-05-07 Thread Shobhit Kumar
On Wed, May 6, 2015 at 5:44 PM, Thierry Reding wrote: > On Tue, May 05, 2015 at 03:08:36PM +0530, Shobhit Kumar wrote: >> The Crystalcove PMIC controls PWM signals and this driver exports that > > You say signal_s_ here, but you only expose a single PWM device. Does > the PMIC r

Re: [Intel-gfx] [PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-05-07 Thread Shobhit Kumar
On Wed, May 6, 2015 at 1:10 PM, Paul Bolle wrote: > On Tue, 2015-05-05 at 15:08 +0530, Shobhit Kumar wrote: >> The Crystalcove PMIC controls PWM signals and this driver exports that >> capability as a PWM chip driver. This is platform device implementtaion >> of the driver

Re: [PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM

2015-05-05 Thread Shobhit Kumar
On 04/29/2015 07:54 PM, Lee Jones wrote: > On Wed, 29 Apr 2015, Shobhit Kumar wrote: > >> On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup >> entry for the same to be used by the consumer (Intel GFX) >> >> v2: Remove the lookup table on dr

[PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-05-05 Thread Shobhit Kumar
jones) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/pwm/Kconfig | 7 +++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-crc.c | 171 ++ 3 files changed, 179 insertions

[PATCH 5/8] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM

2015-05-05 Thread Shobhit Kumar
: Thierry Reding Acked-by: Lee Jones Signed-off-by: Shobhit Kumar --- drivers/mfd/intel_soc_pmic_core.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index f3d918e..a00ddd9 100644 --- a/drivers/mfd

[PATCH 4/8] mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC

2015-05-05 Thread Shobhit Kumar
Needed for PWM control suuported by the PMIC v2: Correct the subject line (Lee jones) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Acked-by: Lee Jones Signed-off-by: Shobhit Kumar --- drivers/mfd/intel_soc_pmic_crc.c | 3 +++ 1 file changed, 3 insertions

[PATCH 3/8] mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal

2015-05-05 Thread Shobhit Kumar
: Correct the subject line (Lee jones) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Acked-by: Lee Jones Signed-off-by: Shobhit Kumar --- drivers/mfd/intel_soc_pmic_core.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/mfd

[PATCH 2/8] pwm: core: Add support to remove registered consumer lookup tables

2015-05-05 Thread Shobhit Kumar
: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/pwm/core.c | 17 + include/linux/pwm.h | 5 + 2 files changed, 22 insertions(+) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index ba34c7d..d2fe7c8d 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c

[PATCH 1/8] gpiolib: Add support for removing registered consumer lookup table

2015-05-05 Thread Shobhit Kumar
Cc: Alexandre Courbot Cc: Thierry Reding Reviewed-by: Alexandre Courbot Signed-off-by: Shobhit Kumar --- drivers/gpio/gpiolib.c | 13 + include/linux/gpio/machine.h | 1 + 2 files changed, 14 insertions(+) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index

Re: [PATCH 3/8] drivers/mfd: Add lookup table for Panel Control as GPIO signal

2015-04-30 Thread Shobhit Kumar
On 04/29/2015 07:57 PM, Lee Jones wrote: > On Wed, 29 Apr 2015, Shobhit Kumar wrote: > >> On some Intel SoC platforms, the panel enable/disable signals are >> controlled by CRC PMIC. Add those control as a new GPIO in a lookup >> table for gpio-crystalcove chip during

[PATCH 2/8] drivers/pwm/core: Add support to remove registered consumer lookup tables

2015-04-29 Thread Shobhit Kumar
In case some drivers are unloading, they can remove lookup tables which they would have registered during their load time to avoid redundant entries if loaded again v2: Ccing maintainers CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar

[PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM

2015-04-29 Thread Shobhit Kumar
On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup entry for the same to be used by the consumer (Intel GFX) v2: Remove the lookup table on driver unload (Thierry) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar

[PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver

2015-04-29 Thread Shobhit Kumar
Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/pwm/Kconfig | 7 +++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-crc.c | 171 ++ 3 files changed, 179 insertions(+) create mode 100644 drivers/pwm/pwm-crc.c

[PATCH 7/8] drm/i915: Use the CRC gpio for panel enable/disable

2015-04-29 Thread Shobhit Kumar
(Ville) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/intel_dsi.c | 32 ++-- drivers/gpu/drm/i915/intel_dsi.h | 6 ++ 2 files changed, 36 insertions(+), 2 deletions(-) diff

[PATCH 8/8] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-04-29 Thread Shobhit Kumar
Use the CRC PWM device in intel_panel.c and add new MIPI backlight specififc callbacks v2: Modify to use pwm_config callback CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/intel_drv.h | 5 +++ drivers/gpu

[PATCH 4/8] drivers/mfd: Add PWM cell device for Crystalcove PMIC

2015-04-29 Thread Shobhit Kumar
Needed for PWM control suuported by the PMIC CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/mfd/intel_soc_pmic_crc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd

[PATCH 3/8] drivers/mfd: Add lookup table for Panel Control as GPIO signal

2015-04-29 Thread Shobhit Kumar
: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/mfd/intel_soc_pmic_core.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index 7b50b6b

[PATCH 0/8] Crystalcove (CRC) PMIC based panel and pwm control

2015-04-29 Thread Shobhit Kumar
. This is now added in the generic panel backlight control infrastructure All these patches have been tested on AsusT100 and working fine using /sys/class/backlight/intel_backlight interface. Patches are also verified on android-x86 tree for AsusT100. Regards Shobhit Shobhit Kumar (8

[PATCH 1/8] drivers/gpio/gpiolib: Add support for removing registered consumer lookup table

2015-04-29 Thread Shobhit Kumar
Reviewed-by: Alexandre Courbot Signed-off-by: Shobhit Kumar --- drivers/gpio/gpiolib.c | 13 + include/linux/gpio/machine.h | 1 + 2 files changed, 14 insertions(+) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 59eaa23..2420af9 100644 --- a/drivers/gpio