[PATCH 1/3] staging: kpc2000: simplify comparison to NULL in kpc2000_spi.c

Fixes checkpatch warning "Comparison to NULL could be written [...]". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000_spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc

[PATCH 3/3] staging: kpc2000: simplify comparison to NULL in fileops.c

Fixes checkpatch warning "Comparison to NULL could be written [...]". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc_dma/fileops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/staging/kpc20

[PATCH 2/3] staging: kpc2000: simplify comparison to NULL in dma.c

Fixes checkpatch warning "Comparison to NULL could be written [...]". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc_dma/dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_dma/dma.c b/drivers/staging/kpc2000/kpc

[PATCH 0/3] Simplify NULL comparisons in staging/kpc2000

Hi, These patches simplifies a few comparisons to NULL ("foo == NULL" => "!foo") in staging/kpc2000, as reported by checkpatch.pl. - Simon Simon Sandström (3): staging: kpc2000: simplify comparison to NULL in kpc2000_spi.c staging: kpc2000: simplify comparison to

[PATCH v2] staging: kpc2000: fix brace issues in kpc2000_spi.c

Fixes issues found by checkpatch: - "WARNING: braces {} are not necessary for single statement blocks" - "WARNING: braces {} are not necessary for any arm of this statement" Signed-off-by: Simon Sandström --- Changed in v2: rebased. drivers/staging/kpc200

[PATCH] staging: kpc2000: fix brace issues in kpc2000_spi.c

Fixes issues found by checkpatch: - "WARNING: braces {} are not necessary for single statement blocks" - "WARNING: braces {} are not necessary for any arm of this statement" Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000_spi.c | 39 ++-

[PATCH 4/4] staging: kpc2000: fix brace issues in kpc2000_spi.c

Fixes checkpatch errors: "else should follow close brace '}'" and "braces {} are not necessary for single statement blocks". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000_spi.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --g

[PATCH 0/4] Minor style issue fixes for staging/kpc2000

Hi, Here are some fixes for minor space, parenthese and brace issues in kpc2000 reported by checkpatch.pl. - Simon Simon Sandström (4): staging: kpc2000: add missing spaces in kpc2000_i2c.c staging: kpc2000: add missing spaces in kpc2000_spi.c staging: kpc2000: remove unnecessary

[PATCH 2/4] staging: kpc2000: add missing spaces in kpc2000_spi.c

Fixes checkpatch errors: - spaces required around that '=' (ctx:VxV) - space required before the open parenthesis '(' - spaces preferred around that '-' (ctx:VxV) - space required before the open brace '{' Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000_spi.c | 14

[PATCH 1/4] staging: kpc2000: add missing spaces in kpc2000_i2c.c

Fixes checkpatch "CHECK: spaces preferred around that '+' (ctx:VxV)". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000_i2c.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drivers/staging/kpc2000/kpc

[PATCH 3/4] staging: kpc2000: remove unnecessary parentheses in kpc2000_spi.c

Fixes checkpatch "CHECK: Unnecessary parentheses around '...'". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_s

[PATCH] staging: kpc2000: simplify error handling in kp2000_pcie_probe

We can get rid of a few iounmaps in the middle of the function by re-ordering the error handling labels and adding two new labels. Signed-off-by: Simon Sandström --- This change has not been tested besides by compiling. It might be good took take an extra look to make sure that I got everything

[PATCH] staging: kpc2000: remove dead code in core.c

Fixes checkpatch warning: "Consider removing the code enclosed by this #if 0 and its #endif". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/stagi

[PATCH v2 0/2] staging: kpc2000: minor fixes in kp2000_pcie_probe

repeats the code. Version 2: - Don't convert C style comments to C++ style Simon Sandström (2): staging: kpc2000: improve label names in kp2000_pcie_probe staging: kpc2000: remove unnecessary comments in kp2000_pcie_probe drivers/staging/kpc2000/kpc2000/core.c | 80

[PATCH v2 1/2] staging: kpc2000: improve label names in kp2000_pcie_probe

Use self-explanatory label names instead of the generic numbered ones, to make it easier to follow and understand the code. Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 42 -- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git

[PATCH v2 2/2] staging: kpc2000: remove unnecessary comments in kp2000_pcie_probe

Much of the code comments in kp2000_pcie_probe just repeats the code and does not add any additional information. Delete them and make sure that comments still left in the function all use the same style. Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 38

Re: [PATCH 2/2] staging: kpc2000: remove unnecessary comments in kp2000_pcie_probe

On 12/06, Greg KH wrote: > On Wed, Jun 12, 2019 at 10:39:36AM +0300, Dan Carpenter wrote: > > On Mon, Jun 10, 2019 at 10:05:35PM +0200, Simon Sandström wrote: > > > @@ -349,9 +340,7 @@ static int kp2000_pcie_probe(struct pci_dev *pdev, > > >

[PATCH 2/2] staging: kpc2000: remove unnecessary comments in kp2000_pcie_probe

Much of the code comments in kp2000_pcie_probe just repeats the code and does not add any additional information. Delete them and make sure that comments still left in the function all use the same style. Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 38

[PATCH 1/2] staging: kpc2000: improve label names in kp2000_pcie_probe

Use self-explanatory label names instead of the generic numbered ones, to make it easier to follow and understand the code. Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 42 -- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git

[PATCH 0/2] staging: kpc2000: minor fixes in kp2000_pcie_probe

repeats the code. Simon Sandström (2): staging: kpc2000: improve label names in kp2000_pcie_probe staging: kpc2000: remove unnecessary comments in kp2000_pcie_probe drivers/staging/kpc2000/kpc2000/core.c | 80 -- 1 file changed, 25 insertions(+), 55 deletions

[PATCH 2/5] staging: kpc2000: remove unnecessary debug prints in core.c

Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000

[PATCH 3/5] staging: kpc2000: remove unnecessary debug prints in dma.c

Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc_dma/dma.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_dma

[PATCH 1/5] staging: kpc2000: remove unnecessary debug prints in cell_probe.c

Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/kpc2000

[PATCH 4/5] staging: kpc2000: remove unnecessary debug prints in fileops.c

Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc_dma/fileops.c | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/staging

[PATCH 5/5] staging: kpc2000: remove unnecessary debug prints in kpc_dma_driver.c

Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/kpc2000

[PATCH 0/5] staging: kpc2000: remove unnecessary debug prints

These patches removes unnecessary debug prints in staging/kpc2000. Debug prints that just informs about function entry or exit can be removed as ftrace can be used to get this information. Simon Sandström (5): staging: kpc2000: remove unnecessary debug prints in cell_probe.c staging: kpc2000

Re: [PATCH 4/7] staging: kpc2000: use __func__ in debug messages in core.c

On 06/06, Greg KH wrote: > On Tue, Jun 04, 2019 at 12:29:13AM +0200, Simon Sandström wrote: > > > > - dev_dbg(>dev, "kp2000_pcie_probe(pdev = [%p], id = [%p])\n", > > - pdev, id); > > + dev_dbg(>dev, "%s(pdev = [%p], i

[PATCH 4/7] staging: kpc2000: use __func__ in debug messages in core.c

Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using '', this function's name, in a string". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/sta

[PATCH 6/7] staging: kpc2000: use sizeof(var) in kzalloc call

Fixes checkpatch.pl warning "Prefer kzalloc(sizeof(*pcard)...) over kzalloc(sizeof(struct kp2000_device)...)". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000

[PATCH 3/7] staging: kpc2000: remove unnecessary oom message in core.c

Fixes checkpatch.pl warning "Possible unnecessary 'out of memory' message". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/staging/kpc20

[PATCH 7/7] staging: kpc2000: fix incorrect code comment in core.c

Step 11 was removed from kp2000_pcie_probe in a previous commit but the comment was not changed to reflect this, so do it now. Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000

[PATCH 0/7] staging: kpc2000: various minor checkpatch fixes

Here is a bunch of checkpatch fixes for core.c in staging/kpc2000. Some of these were sent earlier but not applied. Now rebased on top of staging-testing (incl. Jeremy's kpc2000 misc device removal commits). - Simon Simon Sandström (7): staging: kpc2000: simplify comparisons to NULL

[PATCH 1/7] staging: kpc2000: simplify comparisons to NULL in core.c

Fixes checkpatch.pl warnings "Comparison to NULL could be written [...]" and "Comparisons should place the constant on the right side of the test". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 12 ++-- 1 file changed, 6 insertions(+),

[PATCH 5/7] staging: kpc2000: remove unnecessary include in core.c

Fixes checkpatch.pl warning "Use #include instead of ". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/staging/kpc2000/kpc2000/core.c index 6d4fc1f37c9f..3f

[PATCH 2/7] staging: kpc2000: remove unnecessary parentheses in core.c

Fixes checkpatch.pl check "Unnecessary parentheses around pdev->dev.kobj". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/st

[PATCH] staging: kpc2000: replace bogus variable name in core.c

"struct kp2000_regs temp" has nothing to do with temperatures, so replace it with the more proper name "regs". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-)

Re: [PATCH 3/4] staging: kpc2000: add missing spaces in core.c

On Mon, May 27, 2019 at 10:31:59AM +0300, Dan Carpenter wrote: > On Fri, May 24, 2019 at 01:08:01PM +0200, Simon Sandström wrote: > > [..] > > - ret = copy_to_user((void*)ioctl_param, (void*), > > sizeof(temp)); > > + ret = copy_to_user

Re: [PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000

On Sat, May 25, 2019 at 10:39:18AM +0200, Simon Sandström wrote: > On Sat, May 25, 2019 at 07:00:17AM +0200, Greg KH wrote: > > > > This is already in linux-next (in a different form), are you sure you > > are working against the latest kernel tree? > > > > th

Re: [PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000

On Sat, May 25, 2019 at 07:00:17AM +0200, Greg KH wrote: > On Fri, May 24, 2019 at 10:30:58PM +0200, Simon Sandström wrote: > > Fixes build errors: > > > > ERROR: "mfd_remove_devices" [kpc2000.ko] undefined! > > ERROR: "uio_unregister_device" [kpc

[PATCH 0/2] Fixes for staging/kpc2000's Kconfig

not sure that I solved it correctly. Maybe there are some other things to consider as this is in staging? - Simon Simon Sandström (2): staging: kpc2000: fix typo in Kconfig staging: kpc2000: add missing dependencies for kpc2000 drivers/staging/kpc2000/Kconfig | 6 -- 1 file changed, 4

[PATCH 1/2] staging: kpc2000: fix typo in Kconfig

Fixes two minor typos in kpc2000's Kconfig: s/Kaktronics/Daktronics Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig index fb5922928f47

[PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000

Fixes build errors: ERROR: "mfd_remove_devices" [kpc2000.ko] undefined! ERROR: "uio_unregister_device" [kpc2000.ko] undefined! ERROR: "mfd_add_devices" [kpc2000.ko] undefined! ERROR: "__uio_register_device" [kpc2000.ko] undefined! Signed-off-by: Simon

[PATCH 4/4] staging: kpc2000: remove extra spaces in core.c

Fixes checkpatch.pl error "foo __init bar" should be "foo __init bar" and "foo __exit bar" should be "foo __exit bar". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

[PATCH 0/4] Fix whitespace issues in staging/kpc2000

Hi, These patches fixes minor whitespace issues in staging/kpc2000/core.c as reported by checkpatch.pl. - Simon Simon Sandström (4): staging: kpc2000: add spaces around operators in core.c staging: kpc2000: remove extra blank line in core.c staging: kpc2000: add missing spaces in core.c

[PATCH 3/4] staging: kpc2000: add missing spaces in core.c

Fixes checkpatch.pl errors "space required before the open brace '{'" and "(foo*)" should be "(foo *)". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/sta

[PATCH 1/4] staging: kpc2000: add spaces around operators in core.c

Fixes checkpatch.pl check "spaces preferred around that ". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/stagi

[PATCH 2/4] staging: kpc2000: remove extra blank line in core.c

Fixes checkpatch.pl check "Please don't use multiple blank lines". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/staging/kpc2000/kpc2000/core.c index b4

[PATCH v2 0/9] Fix more coding style issues in staging/kpc2000

don't bother fixing the __func__ usage in the out of memory debug message, instead add a patch that removes it completely. - Simon Simon Sandström (9): staging: kpc2000: add blank line after declarations staging: kpc2000: use __func__ in debug messages staging:

[PATCH v2 2/9] staging: kpc2000: use __func__ in debug messages

Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using '', this function's name, in a string". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --g

[PATCH v2 1/9] staging: kpc2000: add blank line after declarations

Fixes checkpatch.pl warning "Missing a blank line after declarations". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc20

[PATCH v2 3/9] staging: kpc2000: add missing asterisk in comment

Fixes checkpatch.pl error "code indent should use tabs where possible". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/stagi

[PATCH v2 8/9] staging: kpc2000: remove unnecessary include in cell_probe.c

Fixes checkpatch.pl warning "Use #include instead of ". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_pro

[PATCH v2 9/9] staging: kpc2000: remove unnecessary oom message

Fixes checkpatch.pl warning "Possible unnecessary 'out of memory' message". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drive

[PATCH v2 5/9] staging: kpc2000: remove extra blank lines in cell_probe.c

Fixes checkpatch.pl warnings "Please don't use multiple blank lines". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc20

[PATCH v2 7/9] staging: kpc2000: remove unnecessary braces in cell_probe.c

Fixes checkpatch.pl warnings "braces {} are not necessary for single statement blocks". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_

[PATCH v2 4/9] staging: kpc2000: fix alignment issues in cell_probe.c

Fixes checkpatch.pl warnings "Alignment should match open parenthesis" and "Lines should not end with a '('". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 34 +--- 1 file changed, 15 insertions(+), 19 deletions(-)

[PATCH v2 6/9] staging: kpc2000: use kzalloc(sizeof(var)...) in cell_probe.c

Fixes checkpatch.pl warning "Prefer kzalloc(sizeof(*kudev)...) over kzalloc(sizeof(struct kpc_uio_device)...)" Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc20

Re: [PATCH 2/8] staging: kpc2000: use __func__ in debug messages

On Thu, May 23, 2019 at 01:55:53PM +0200, Greg KH wrote: > On Thu, May 23, 2019 at 01:36:07PM +0200, Simon Sandström wrote: > > Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using > > '', this function's name, in a string". >

[PATCH 3/8] staging: kpc2000: add missing asterisk in comment

Fixes checkpatch.pl error "code indent should use tabs where possible". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/stagi

[PATCH 5/8] staging: kpc2000: remove extra blank lines in cell_probe.c

Fixes checkpatch.pl warnings "Please don't use multiple blank lines". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc20

[PATCH 0/8] Fix more coding style issues in staging/kpc2000

Hi, These patches fixes a few more minor coding style issues found in staging/kpc2000/cell_probe.c. There are only two more types of checkpatch.pl warnings left in this file with these patches applied: "line over 80 characters" and "Macro argument reuse". - Simon Simon Sand

[PATCH 2/8] staging: kpc2000: use __func__ in debug messages

Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using '', this function's name, in a string". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 22 +--- 1 file changed, 14 insertions(+), 8 deletions(-)

[PATCH 1/8] staging: kpc2000: add blank line after declarations

Fixes checkpatch.pl warning "Missing a blank line after declarations". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc20

[PATCH 4/8] staging: kpc2000: fix alignment issues in cell_probe.c

Fixes checkpatch.pl warnings "Alignment should match open parenthesis" and "Lines should not end with a '('". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 34 +--- 1 file changed, 15 insertions(+), 19 deletions(-)

[PATCH 7/8] staging: kpc2000: remove unnecessary braces in cell_probe.c

Fixes checkpatch.pl warnings "braces {} are not necessary for single statement blocks". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_

[PATCH 8/8] staging: kpc2000: remove unnecessary include in cell_probe.c

Fixes checkpatch.pl warning "Use #include instead of ". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_pro

[PATCH 6/8] staging: kpc2000: use kzalloc(sizeof(var)...) in cell_probe.c

Fixes checkpatch.pl warning "Prefer kzalloc(sizeof(*kudev)...) over kzalloc(sizeof(struct kpc_uio_device)...)" Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc20

Re: [PATCH 1/6] staging: kpc2000: fix indent in cell_probe.c

On Thu, May 23, 2019 at 09:27:59AM +0200, Greg KH wrote: > On Thu, May 23, 2019 at 09:26:25AM +0200, Greg KH wrote: > > > > This chunk does not match what you said this commit did :( > > > > Please fix up and resend. > > Actually, wait, rebase and resend after I apply your other patches. > I'll

[PATCH 1/6] staging: kpc2000: fix indent in cell_probe.c

Use tabs instead of spaces for indentation. Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 574 +-- 1 file changed, 287 insertions(+), 287 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000

[PATCH 5/6] staging: kpc2000: add space after comma in cell_probe.c

Fixes checkpatch.pl error "space required after that ','". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc20

[PATCH 2/6] staging: kpc2000: add space between ) and { in cell_probe.c

Fixes checkpatch.pl error "space required before the open brace '{'". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_

[PATCH 4/6] staging: kpc2000: add spaces around operators in cell_probe.c

Fixes checkpatch.pl warning "spaces preferred around that ". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc20

[PATCH 6/6] staging: kpc2000: remove invalid spaces in cell_probe.c

Fixes checkpatch.pl error "space prohibited before/after that parenthesis". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drive

[PATCH 3/6] staging: kpc2000: fix invalid linebreaks in cell_probe.c

Fixes checkpatch.pl error "else should follow close brace '}'" and "trailing statements should be on next line". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --g

[PATCH 0/6] Fix coding style issues in drivers/staging/kpc2000

These patches fixes a bunch of minor coding style issues in kpc2000/cell_probe.c. - Simon Simon Sandström (6): staging: kpc2000: fix indent in cell_probe.c staging: kpc2000: add space between ) and { in cell_probe.c staging: kpc2000: fix invalid linebreaks in cell_probe.c staging

[PATCH RESEND] staging: pi433: break long lines in pi433_if.c

Breaks long lines in pi433_if.c, fixing checkpatch.pl warnings: "WARNING: line over 80 characters" Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH RESEND] staging: pi433: break long lines in pi433_if.c

Breaks long lines in pi433_if.c, fixing checkpatch.pl warnings: "WARNING: line over 80 characters" Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c

[PATCH] staging: pi433: break long lines in rf69.c

Breaks long lines in rf69.c, fixing checkpatch.pl warnings: "WARNING: line over 80 characters" Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/rf69.c | 182 ++- 1 file changed, 129 insertions(+), 53 deletion

[PATCH] staging: pi433: break long lines in rf69.c

Breaks long lines in rf69.c, fixing checkpatch.pl warnings: "WARNING: line over 80 characters" Signed-off-by: Simon Sandström --- drivers/staging/pi433/rf69.c | 182 ++- 1 file changed, 129 insertions(+), 53 deletions(-) diff --git a/drive

[PATCH] staging: pi433: break long lines in pi433_if.c

Breaks long lines in pi433_if.c, fixing checkpatch.pl warnings: "WARNING: line over 80 characters" Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drive

[PATCH] staging: pi433: break long lines in pi433_if.c

Breaks long lines in pi433_if.c, fixing checkpatch.pl warnings: "WARNING: line over 80 characters" Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi

[PATCH] staging: pi433: break long lines

Breaks long lines in rf69.h, fixing checkpatch.pl warnings: "WARNING: line over 80 characters" Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/rf69.h | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a

[PATCH] staging: pi433: break long lines

Breaks long lines in rf69.h, fixing checkpatch.pl warnings: "WARNING: line over 80 characters" Signed-off-by: Simon Sandström --- drivers/staging/pi433/rf69.h | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/staging/pi433/rf69.h

Re: rf69_get_lna_gain

On Thu, Dec 14, 2017 at 06:08:11PM +0200, Marcus Wolf wrote: > Hi! > > This is an information for all of you, doing experiments with real hardware! > > I wanted to explain, what this lna_gain stuff is used for: > > If you are receiving messages from different sender (let's say several >

Re: rf69_get_lna_gain

On Thu, Dec 14, 2017 at 06:08:11PM +0200, Marcus Wolf wrote: > Hi! > > This is an information for all of you, doing experiments with real hardware! > > I wanted to explain, what this lna_gain stuff is used for: > > If you are receiving messages from different sender (let's say several >

[PATCH 2/3] staging: pi433: Remove function entry dev_dbg()

ftrace can be used to trace function calls, so there is no need to use dev_dbg() here. Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/rf69.c | 156 --- 1 file changed, 156 deletions(-) diff --git a/drivers/staging/pi433/

[PATCH 2/3] staging: pi433: Remove function entry dev_dbg()

ftrace can be used to trace function calls, so there is no need to use dev_dbg() here. Signed-off-by: Simon Sandström --- drivers/staging/pi433/rf69.c | 156 --- 1 file changed, 156 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging

[PATCH 1/3] staging: pi433: Remove indentation on #ifdef blocks

ifdef blocks should not increase indentation level. Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/rf69.c | 314 +-- 1 file changed, 153 insertions(+), 161 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/d

[PATCH 0/3] staging: pi433: Refactor usage of dev_dbg and #ifdef DEBUG

and DEBUG_VALUES. Perhaps they should be removed as well? - Simon --- Simon Sandström (3): staging: pi433: Remove indentation on #ifdef blocks staging: pi433: Remove function entry dev_dbg() staging: pi433: Remove unnecessary #ifdef DEBUG around dev_dbg drivers/staging/pi433/rf69.c | 232

[PATCH 1/3] staging: pi433: Remove indentation on #ifdef blocks

ifdef blocks should not increase indentation level. Signed-off-by: Simon Sandström --- drivers/staging/pi433/rf69.c | 314 +-- 1 file changed, 153 insertions(+), 161 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c

[PATCH 0/3] staging: pi433: Refactor usage of dev_dbg and #ifdef DEBUG

and DEBUG_VALUES. Perhaps they should be removed as well? - Simon --- Simon Sandström (3): staging: pi433: Remove indentation on #ifdef blocks staging: pi433: Remove function entry dev_dbg() staging: pi433: Remove unnecessary #ifdef DEBUG around dev_dbg drivers/staging/pi433/rf69.c | 232

[PATCH 3/3] staging: pi433: Remove unnecessary #ifdef DEBUG around dev_dbg

dev_dbg() already depends on DEBUG. Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/rf69.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index 04a74423c325..6e38e6a515a4 100644 --- a/drivers/s

[PATCH 3/3] staging: pi433: Remove unnecessary #ifdef DEBUG around dev_dbg

dev_dbg() already depends on DEBUG. Signed-off-by: Simon Sandström --- drivers/staging/pi433/rf69.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index 04a74423c325..6e38e6a515a4 100644 --- a/drivers/staging/pi433/rf69.c +++ b

[PATCH] staging: pi433: Add spaces around & and + operator

Fixes checkpatch warning: "spaces preferred around that '&'". Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/rf69.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/staging/pi433/rf69

[PATCH] staging: pi433: Add spaces around & and + operator

Fixes checkpatch warning: "spaces preferred around that '&'". Signed-off-by: Simon Sandström --- drivers/staging/pi433/rf69.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi43

[PATCH] staging: pi433: Fix ISO-8859 encoded non-english comments

Some comments, like "without memcpy would be nice", are removed. Other comments are just translated to english. rf69.c is now plain ASCII. Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/rf69.c | 11 ++- 1 file changed, 6 insertions(+), 5 de

[PATCH] staging: pi433: Fix ISO-8859 encoded non-english comments

Some comments, like "without memcpy would be nice", are removed. Other comments are just translated to english. rf69.c is now plain ASCII. Signed-off-by: Simon Sandström --- drivers/staging/pi433/rf69.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 1/6] staging: pi433: Split rf69_set_crc_enabled into two functions

On Thu, Dec 07, 2017 at 03:38:57PM +0100, Greg KH wrote: > On Wed, Dec 06, 2017 at 09:42:19PM +0100, Simon Sandström wrote: > > Splits rf69_set_crc_enabled(dev, enabled) into > > rf69_enable_crc(dev) and rf69_disable_crc(dev). > > > > Signed-off-by: Simon

Re: [PATCH 1/6] staging: pi433: Split rf69_set_crc_enabled into two functions

On Thu, Dec 07, 2017 at 03:38:57PM +0100, Greg KH wrote: > On Wed, Dec 06, 2017 at 09:42:19PM +0100, Simon Sandström wrote: > > Splits rf69_set_crc_enabled(dev, enabled) into > > rf69_enable_crc(dev) and rf69_disable_crc(dev). > > > > Signed-off-by: Simon Sandström &

[PATCH 5/6] staging: pi433: Move enum option_on_off to pi433_if.h

The enum is now only used for ioctl, so move it pi433_if.h. Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.h | 5 + drivers/staging/pi433/rf69_enum.h | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging

  1   2   >