On 06/24/2016 01:48 PM, Jason Gunthorpe wrote:
On Fri, Jun 24, 2016 at 10:36:55AM -0400, Stefan Berger wrote:
Introduce TPM_VTPM_PROXY_NO_SYSFS flag that prevents a vtpm_proxy driver
instance from having the typical sysfs entries that shows the state of the
TPM. The flag is to be set in the
set by a container management stack to prevent
TPM related information leakage between containers who share entries
in sysfs.
Signed-off-by: Stefan Berger
---
drivers/char/tpm/tpm-chip.c | 2 +-
drivers/char/tpm/tpm.h| 1 +
drivers/char/tpm/tpm_vtpm_proxy.c | 5 -
include
[noderef] *
drivers/char/tpm//tpm_crb.c:248:31:got void *
Fixes: 1bd047be37d9 ("tpm_crb: Use devm_ioremap_resource")
Signed-off-by: Jarkko Sakkinen
Tested-by: Stefan Berger
:expected void [noderef] *to
drivers/char/tpm//tpm_vtpm_proxy.c:559:34:got struct vtpm_proxy_new_dev
*vtpm_new_dev_p
The __user annotation was missing from the corresponding variable.
Signed-off-by: Jarkko Sakkinen
Tested-by: Stefan Berger
PS: I get similar warnings for line 248 in tpm_crb.c.
On 05/11/2016 10:29 AM, Jeremiah Mahler wrote:
Stefan,
On Wed, May 11, 2016 at 06:27:52AM -0400, Stefan Berger wrote:
Jeremiah Mahler wrote on 05/10/2016 09:26:17 PM:
[...]
I forgot to cc you on the patch and obviously you weren't cc'ed through
the Reported-by: line.
Here'
ement to ensure it's always there
when we need it.
Signed-off-by: Arnd Bergmann
Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")
Acked-by: Stefan Berger
Thanks.
On 04/27/2016 08:56 AM, Jarkko Sakkinen wrote:
On Tue, Apr 26, 2016 at 07:30:26AM -0400, Stefan Berger wrote:
On 04/26/2016 05:28 AM, Jarkko Sakkinen wrote:
On Fri, Apr 22, 2016 at 07:54:27PM +0300, Jarkko Sakkinen wrote:
On Mon, Apr 18, 2016 at 01:26:12PM -0400, Stefan Berger wrote:
The
On 04/26/2016 05:28 AM, Jarkko Sakkinen wrote:
On Fri, Apr 22, 2016 at 07:54:27PM +0300, Jarkko Sakkinen wrote:
On Mon, Apr 18, 2016 at 01:26:12PM -0400, Stefan Berger wrote:
The following series of patches implements a multi-instance vTPM
proxy driver that can dynamically create TPM 's
On 04/22/2016 11:06 AM, Jarkko Sakkinen wrote:
On Mon, Apr 18, 2016 at 01:26:13PM -0400, Stefan Berger wrote:
From: Jason Gunthorpe
The final thing preventing this was the way the sysfs files were
attached to the pdev. Follow the approach developed for ppi and move
the sysfs files to the chip
On 04/25/2016 01:57 PM, Jason Gunthorpe wrote:
On Mon, Apr 25, 2016 at 12:21:30PM +0300, Jarkko Sakkinen wrote:
Signed-off-by: Jarkko Sakkinen
Reported-by: Stefan Berger
drivers/char/tpm/tpm-chip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-By: Jason Gunthorpe
Fixes
On 04/19/2016 06:12 AM, Jarkko Sakkinen wrote:
On Mon, Apr 18, 2016 at 01:26:13PM -0400, Stefan Berger wrote:
From: Jason Gunthorpe
The final thing preventing this was the way the sysfs files were
attached to the pdev. Follow the approach developed for ppi and move
the sysfs files to the chip
5:
- Introduced different error codes for unsupported flags and ioctls
- Added documentation patch
Jason Gunthorpe (1):
tpm: Remove all uses of drvdata from the TPM Core
Stefan Berger (3):
tpm: Introduce TPM_CHIP_FLAG_VIRTUAL
tpm: Proxy driver for supporting multiple emulated TPMs
tpm: Add d
get the chip.
Signed-off-by: Jason Gunthorpe
Signed-off-by: Stefan Berger
---
drivers/char/tpm/tpm-chip.c | 73
drivers/char/tpm/tpm-interface.c | 7 ++--
drivers/char/tpm/tpm-sysfs.c | 61 ++---
drivers/char/tpm/tp
Add documentation for the tpm_vtpm device driver that implements
support for providing TPM functionality to Linux containers.
Parts of this documentation were recycled from the Xen vTPM
device driver documentation.
Update the documentation for the ioctl numbers.
Signed-off-by: Stefan Berger
Introduce TPM_CHIP_FLAG_VIRTUAL to be used when the chip device has no
parent device.
Prevent sysfs entries requiring a parent device from being created.
Signed-off-by: Stefan Berger
Reviewed-by: Jason Gunthorpe
---
drivers/char/tpm/tpm-chip.c | 7 +--
drivers/char/tpm/tpm.h | 1 +
2
. Since this requires
the startup of the TPM, we send a startup for TPM 1.2 as well as TPM 2.
Signed-off-by: Stefan Berger
Reviewed-by: Jason Gunthorpe
CC: linux-kernel@vger.kernel.org
CC: linux-...@vger.kernel.org
CC: linux-...@vger.kernel.org
---
drivers/char/tpm/Kconfig | 10 +
drivers
get the chip.
Signed-off-by: Jason Gunthorpe
Signed-off-by: Stefan Berger
---
drivers/char/tpm/tpm-chip.c | 73
drivers/char/tpm/tpm-interface.c | 7 ++--
drivers/char/tpm/tpm-sysfs.c | 61 ++---
drivers/char/tpm/tp
Add the retrieval of TPM 1.2 durations and timeouts. Since this requires
the startup of the TPM, do this for TPM 1.2 and TPM 2.
Signed-off-by: Stefan Berger
CC: linux-kernel@vger.kernel.org
CC: linux-...@vger.kernel.org
CC: linux-...@vger.kernel.org
---
drivers/char/tpm/tpm_vtpm_proxy.c | 96
Add documentation for the tpm_vtpm device driver that implements
support for providing TPM functionality to Linux containers.
Parts of this documentation were recycled from the Xen vTPM
device driver documentation.
Update the documentation for the ioctl numbers.
Signed-off-by: Stefan Berger
to own project (dropped patch 11).
v5->v6:
- Adapted errno's for unsupported flags and ioctls following Jason's
comments
v4->v5:
- Introduced different error codes for unsupported flags and ioctls
- Added documentation patch
Jason Gunthorpe (1):
tpm: Remove all u
Introduce TPM_CHIP_FLAG_VIRTUAL to be used when the chip device has no
parent device.
Prevent sysfs entries requiring a parent device from being created.
Signed-off-by: Stefan Berger
---
drivers/char/tpm/tpm-chip.c | 7 +--
drivers/char/tpm/tpm.h | 1 +
2 files changed, 6 insertions
/dev/tpmX is the usual TPM device created by the core TPM
driver. Applications or kernel subsystems can send TPM commands to it
and the corresponding server-side file descriptor receives these
commands and delivers them to an emulated TPM.
Signed-off-by: Stefan Berger
CC: linux-kernel
On 04/07/2016 08:35 AM, Jarkko Sakkinen wrote:
On Tue, Mar 29, 2016 at 02:19:12PM -0400, Stefan Berger wrote:
This patch implements a proxy driver for supporting multiple emulated TPMs
in a system.
The driver implements a device /dev/vtpmx that is used to created
a client device pair /dev/tpmX
On 03/31/2016 04:24 AM, Jarkko Sakkinen wrote:
On Tue, Mar 29, 2016 at 02:19:13PM -0400, Stefan Berger wrote:
Add the retrieval of TPM 1.2 durations and timeouts. Since this requires
the startup of the TPM, do this for TPM 1.2 and TPM 2.
@@ -343,6 +362,55 @@ static const struct tpm_class_ops
Add documentation for the tpm_vtpm device driver that implements
support for providing TPM functionality to Linux containers.
Parts of this documentation were recycled from the Xen vTPM
device driver documentation.
Update the documentation for the ioctl numbers.
Signed-off-by: Stefan Berger
CC
Add the retrieval of TPM 1.2 durations and timeouts. Since this requires
the startup of the TPM, do this for TPM 1.2 and TPM 2.
Signed-off-by: Stefan Berger
CC: linux-kernel@vger.kernel.org
CC: linux-...@vger.kernel.org
CC: linux-...@vger.kernel.org
---
drivers/char/tpm/tpm_vtpm_proxy.c | 96
Introduce TPM_CHIP_FLAG_VIRTUAL to be used when the chip device has no
parent device. Also adapt tpm_chip_alloc so that it can be called with
parent device being NULL.
Signed-off-by: Stefan Berger
Reviewed-by: Jason Gunthorpe
Reviewed-by: Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen
/dev/tpmX is the usual TPM device created by the core TPM
driver. Applications or kernel subsystems can send TPM commands to it
and the corresponding server-side file descriptor receives these
commands and delivers them to an emulated TPM.
Signed-off-by: Stefan Berger
CC: linux-kernel
own project (dropped patch 11).
v5->v6:
- Adapted errno's for unsupported flags and ioctls following Jason's
comments
v4->v5:
- Introduced different error codes for unsupported flags and ioctls
- Added documentation patch
Stefan Berger (4):
tpm: Introduce TPM_CHIP_FLAG_VIRTU
On 03/29/2016 11:31 AM, Jarkko Sakkinen wrote:
On Tue, Mar 22, 2016 at 06:54:30AM -0400, Stefan Berger wrote:
On 03/22/2016 02:34 AM, Jarkko Sakkinen wrote:
On Sun, Mar 13, 2016 at 06:54:39PM -0400, Stefan Berger wrote:
Add the retrieval of TPM 1.2 durations and timeouts. Since this requires
On 03/22/2016 02:34 AM, Jarkko Sakkinen wrote:
On Sun, Mar 13, 2016 at 06:54:39PM -0400, Stefan Berger wrote:
Add the retrieval of TPM 1.2 durations and timeouts. Since this requires
the startup of the TPM, do this for TPM 1.2 and TPM 2.
Signed-off-by: Stefan Berger
CC: linux-kernel
On 03/16/2016 01:57 PM, Jason Gunthorpe wrote:
On Wed, Mar 16, 2016 at 12:13:41PM +0200, Jarkko Sakkinen wrote:
On Wed, Mar 16, 2016 at 09:19:48AM +0100, Arnd Bergmann wrote:
A cleanup patch changed the prototype of the regular tpm_bios_log_setup
function, but not that of the stub that is used
On 03/16/2016 04:42 PM, Jarkko Sakkinen wrote:
On Sun, Mar 13, 2016 at 06:54:38PM -0400, Stefan Berger wrote:
+
+/* above flags */
+#define VTPM_PROXY_FLAG_TPM2 1 /* emulator is TPM 2 */
+
+/* all supported flags */
+#define VTPM_PROXY_FLAGS_ALL (VTPM_PROXY_FLAG_TPM2)
This can be moved
On 03/16/2016 08:09 AM, Jarkko Sakkinen wrote:
On Sun, Mar 13, 2016 at 06:54:38PM -0400, Stefan Berger wrote:
This patch implements a proxy driver for supporting multiple emulated TPMs
in a system.
The driver implements a device /dev/vtpmx that is used to created
a client device pair /dev/tpmX
On 03/15/2016 05:36 PM, Jarkko Sakkinen wrote:
The iomem resource is needed only temporarily so it is better to pass
it on instead of storing it permanently. Named the variable as io_res
so that the code better documents itself.
Signed-off-by: Jarkko Sakkinen
Reviewed-by: Stefan Berger
From: Jason Gunthorpe
tpm_chip_alloc becomes a typical subsystem allocate call.
Signed-off-by: Jason Gunthorpe
Reviewed-by: Stefan Berger
Tested-by: Stefan Berger
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-chip.c | 49
Add the retrieval of TPM 1.2 durations and timeouts. Since this requires
the startup of the TPM, do this for TPM 1.2 and TPM 2.
Signed-off-by: Stefan Berger
CC: linux-kernel@vger.kernel.org
CC: linux-...@vger.kernel.org
CC: linux-...@vger.kernel.org
---
drivers/char/tpm/tpm_vtpm_proxy.c | 95
holds the reader lock
on 'ops' while using 'ops' and this prevents the module from un-
registering, which needs the writer lock. Once the module unregistered
the 'ops' cannot be found anymore.
Signed-off-by: Stefan Berger
Reviewed-by: Jason Gunthorpe
Reviewed-by: Jarkko
is placed very high in the call stack, it could
be pushed down and made more granular in future if necessary.
Signed-off-by: Jason Gunthorpe
Reviewed-by: Stefan Berger
Reviewed-by: Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-c
by: Stefan Berger
Tested-by: Stefan Berger
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-chip.c | 15 ++-
drivers/char/tpm/tpm-dev.c | 4 +---
drivers/char/tpm/tpm-interface
Add documentation for the tpm_vtpm device driver that implements
support for providing TPM functionality to Linux containers.
Parts of this documentation were recycled from the Xen vTPM
device driver documentation.
Update the documentation for the ioctl numbers.
Signed-off-by: Stefan Berger
CC
/dev/tpmX is the usual TPM device created by the core TPM
driver. Applications or kernel subsystems can send TPM commands to it
and the corresponding server-side file descriptor receives these
commands and delivers them to an emulated TPM.
Signed-off-by: Stefan Berger
CC: linux-kernel
ifferent error codes for unsupported flags and ioctls
- Added documentation patch
Jason Gunthorpe (4):
tpm: Get rid of chip->pdev
tpm: Get rid of devname
tpm: Provide strong locking for device removal
tpm: Split out the devm stuff from tpmm_chip_alloc
Stefan Berger (6):
tpm: Get r
.
Signed-off-by: Stefan Berger
Reviewed-by: Jason Gunthorpe
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-chip.c | 84 +---
drivers/char/tpm/tpm-interface.c | 1 +
drivers/char/tpm/tpm.h
Introduce TPM_CHIP_FLAG_VIRTUAL to be used when the chip device has no
parent device. Also adapt tpm_chip_alloc so that it can be called with
parent device being NULL.
Signed-off-by: Stefan Berger
Reviewed-by: Jason Gunthorpe
Reviewed-by: Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen
From: Jason Gunthorpe
Now that we have a proper struct device just use dev_name() to
access this value instead of keeping two copies.
Signed-off-by: Jason Gunthorpe
Signed-off-by: Stefan Berger
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen
On 03/12/2016 01:51 PM, Jarkko Sakkinen wrote:
On Fri, Mar 11, 2016 at 09:51:03PM -0500, Stefan Berger wrote:
This patch implements a proxy driver for supporting multiple emulated TPMs
in a system.
The driver implements a device /dev/vtpmx that is used to created
a client device pair /dev/tpmX
by: Stefan Berger
Tested-by: Stefan Berger
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-chip.c | 15 ++-
drivers/char/tpm/tpm-dev.c | 4 +---
drivers/char/tpm/tpm-interface
is placed very high in the call stack, it could
be pushed down and made more granular in future if necessary.
Signed-off-by: Jason Gunthorpe
Reviewed-by: Stefan Berger
Reviewed-by: Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-c
Add the retrieval of TPM 1.2 durations and timeouts. Since this requires
the startup of the TPM, do this for TPM 1.2 and TPM 2.
Signed-off-by: Stefan Berger
CC: linux-kernel@vger.kernel.org
CC: linux-...@vger.kernel.org
CC: linux-...@vger.kernel.org
---
drivers/char/tpm/tpm_vtpm_proxy.c | 95
Add documentation for the tpm_vtpm device driver that implements
support for providing TPM functionality to Linux containers.
Parts of this documentation were recycled from the Xen vTPM
device driver documentation.
Update the documentation for the ioctl numbers.
Signed-off-by: Stefan Berger
CC
/dev/tpmX is the usual TPM device created by the core TPM
driver. Applications or kernel subsystems can send TPM commands to it
and the corresponding server-side file descriptor receives these
commands and delivers them to an emulated TPM.
Signed-off-by: Stefan Berger
CC: linux-kernel
;v5:
- Introduced different error codes for unsupported flags and ioctls
- Added documentation patch
Jason Gunthorpe (4):
tpm: Get rid of chip->pdev
tpm: Get rid of devname
tpm: Provide strong locking for device removal
tpm: Split out the devm stuff from tpmm_chip_alloc
Stefan Ber
.
Signed-off-by: Stefan Berger
Reviewed-by: Jason Gunthorpe
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-chip.c | 84 +---
drivers/char/tpm/tpm-interface.c | 1 +
drivers/char/tpm/tpm.h
holds the reader lock
on 'ops' while using 'ops' and this prevents the module from un-
registering, which needs the writer lock. Once the module unregistered
the 'ops' cannot be found anymore.
Signed-off-by: Stefan Berger
Reviewed-by: Jason Gunthorpe
Reviewed-by: Jarkko
From: Jason Gunthorpe
tpm_chip_alloc becomes a typical subsystem allocate call.
Signed-off-by: Jason Gunthorpe
Reviewed-by: Stefan Berger
Tested-by: Stefan Berger
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-chip.c | 49
Introduce TPM_CHIP_FLAG_VIRTUAL to be used when the chip device has no
parent device. Also adapt tpm_chip_alloc so that it can be called with
parent device being NULL.
Signed-off-by: Stefan Berger
Reviewed-by: Jason Gunthorpe
Reviewed-by: Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen
From: Jason Gunthorpe
Now that we have a proper struct device just use dev_name() to
access this value instead of keeping two copies.
Signed-off-by: Jason Gunthorpe
Signed-off-by: Stefan Berger
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen
On 03/09/2016 09:57 PM, Andy Lutomirski wrote:
On Wed, Mar 9, 2016 at 6:34 PM, Stefan Berger
wrote:
On 03/09/2016 01:01 PM, Andy Lutomirski wrote:
On Wed, Mar 9, 2016 at 9:39 AM, Stefan Berger
wrote:
This patch implements a driver for supporting multiple emulated TPMs in a
system.
The
On 03/10/2016 11:39 AM, Jarkko Sakkinen wrote:
+/* above flags */
+#define VTPM_FLAG_TPM2 1 /* emulator is TPM 2 */
+
+/* all supported flags */
+#define VTPM_FLAGS_ALL (VTPM_FLAG_TPM2)
+
+#define VTPM_TPM 0xa0
+
+#define VTPM_NEW_DEV _IOW(VTPM_TPM, 0x00, struct vtpm_new_dev)
> On Wed, Mar 09, 2016 at 12:39:27PM -0500, Stefan Berger wrote:
> > This patch implements a driver for supporting multiple emulated
TPMs in a
> > system.
> >
> > The driver implements a device /dev/vtpmx that is used to created
> > a client device pair /dev/tpm
On 03/09/2016 01:01 PM, Andy Lutomirski wrote:
On Wed, Mar 9, 2016 at 9:39 AM, Stefan Berger
wrote:
This patch implements a driver for supporting multiple emulated TPMs in a
system.
The driver implements a device /dev/vtpmx that is used to created
a client device pair /dev/tpmX (e.g., /dev
/tpmX is the usual TPM device created by the core TPM
driver. Applications or kernel subsystems can send TPM commands to it
and the corresponding server-side file descriptor receives these
commands and delivers them to an emulated TPM.
Signed-off-by: Stefan Berger
CC: linux-kernel@vger.kernel.org
CC
Add documentation for the tpm_vtpm device driver that implements
support for providing TPM functionality to Linux containers.
Parts of this documentation were recycled from the Xen vTPM
device driver documentation.
Signed-off-by: Stefan Berger
CC: linux-kernel@vger.kernel.org
CC: linux
Add the retrieval of TPM 1.2 durations and timeouts. Since this requires
the startup of the TPM, do this for TPM 1.2 and TPM 2.
Signed-off-by: Stefan Berger
CC: linux-kernel@vger.kernel.org
CC: linux-...@vger.kernel.org
CC: linux-...@vger.kernel.org
---
drivers/char/tpm/tpm_vtpm.c | 94
Add the retrieval of TPM 1.2 durations and timeouts. Since this requires
the startup of the TPM, do this for TPM 1.2 and TPM 2.
Signed-off-by: Stefan Berger
CC: linux-kernel@vger.kernel.org
CC: linux-...@vger.kernel.org
CC: linux-...@vger.kernel.org
---
drivers/char/tpm/tpm_vtpm.c | 94
Add documentation for the tpm_vtpm device driver that implements
support for providing TPM functionality to Linux containers.
Parts of this documentation were recycled from the Xen vTPM
device driver documentation.
Signed-off-by: Stefan Berger
CC: linux-kernel@vger.kernel.org
CC: linux
/tpmX is the usual TPM device created by the core TPM
driver. Applications or kernel subsystems can send TPM commands to it
and the corresponding server-side file descriptor receives these
commands and delivers them to an emulated TPM.
Signed-off-by: Stefan Berger
CC: linux-kernel@vger.kernel.org
CC
On 02/12/2016 07:04 PM, Jason Gunthorpe wrote:
This is a hold over from before the struct device conversion.
- All prints should be using &chip->dev, which is the Linux
standard. This changes prints to use tpm0 as the device name,
not the PnP/etc ID.
- The few places involving sysfs/module
On 05/05/2015 08:51 PM, Hon Ching(Vicky) Lo wrote:
Do not skip the last entry of the event log.
Signed-off-by: Hon Ching(Vicky) Lo
Signed-off-by: Joy Latten
Changelog:
- remove redundant code
---
drivers/char/tpm/tpm_eventlog.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
On 02/10/2015 07:50 AM, Jarkko Sakkinen wrote:
On Tue, Feb 10, 2015 at 07:16:32AM -0500, Stefan Berger wrote:
On 02/09/2015 03:39 AM, Jarkko Sakkinen wrote:
On Mon, Feb 09, 2015 at 12:08:46AM +0100, Peter Hüwe wrote:
Am Mittwoch, 4. Februar 2015, 15:21:09 schrieb Jarkko Sakkinen:
If during
On 02/09/2015 03:39 AM, Jarkko Sakkinen wrote:
On Mon, Feb 09, 2015 at 12:08:46AM +0100, Peter Hüwe wrote:
Am Mittwoch, 4. Februar 2015, 15:21:09 schrieb Jarkko Sakkinen:
If during transmission system error was returned, the logic was to
incorrectly deduce that chip is a TPM 1.x chip. This patc
On 12/14/2014 01:27 PM, Scot Doyle wrote:
On Sun, 14 Dec 2014, Stefan Berger wrote:
On 12/14/2014 10:40 AM, Jarkko Sakkinen wrote:
On Sun, Dec 14, 2014 at 09:48:26AM -0500, Stefan Berger wrote:
On 12/12/2014 02:46 PM, Jarkko Sakkinen wrote:
Detect TPM 2.0 by sending idempotent TPM 2.x
On 12/14/2014 10:40 AM, Jarkko Sakkinen wrote:
On Sun, Dec 14, 2014 at 09:48:26AM -0500, Stefan Berger wrote:
On 12/12/2014 02:46 PM, Jarkko Sakkinen wrote:
Detect TPM 2.0 by sending idempotent TPM 2.x command. Ordinals for
TPM 2.0 are higher than TPM 1.x commands so this should be fail-safe
On 12/12/2014 02:46 PM, Jarkko Sakkinen wrote:
Detect TPM 2.0 by sending idempotent TPM 2.x command. Ordinals for
TPM 2.0 are higher than TPM 1.x commands so this should be fail-safe.
Using STS3 is unreliable because some chips just report 0xff and not
what the spec says.
TPM TIS 1.2 can report
ling works fine here.
Signed-off-by: Jarkko Sakkinen
Reviewed-by: Jasob Gunthorpe
Reviewed-by: Stephan Berger
Not quite ... Stefan Berger
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
Mo
On 12/05/2014 10:01 AM, Peter Huewe wrote:
Am Donnerstag, 4. Dezember 2014, 06:55:18 schrieb Jarkko Sakkinen:
From: Will Arthur
Detect TPM 2.0 by using the extended STS (STS3) register. For TPM 2.0,
instead of calling tpm_get_timeouts(), assign duration and timeout
values defined in the TPM 2.
On 12/02/2014 05:31 PM, Jarkko Sakkinen wrote:
+
+/**
+ * tpm2_startup() - send startup command to the TPM chip
+ * @chip: TPM chip to use.
+ * @startup_type startup type. The value is either
+ * TPM_SU_CLEAR or TPM_SU_STATE.
+ *
+ * 0 is returned when the
On 12/02/2014 05:31 PM, Jarkko Sakkinen wrote:
+
+#define TPM2_STARTUP_IN_SIZE \
+ (sizeof(struct tpm_input_header) + \
+sizeof(struct tpm2_pcr_read_in))
+
+static const struct tpm_input_header tpm2_startup_header = {
+ .tag = cpu_to_be16(TPM2_ST_NO_SESSIONS),
+ .length
On 12/02/2014 05:31 PM, Jarkko Sakkinen wrote:
+struct acpi_tpm2 {
+ struct acpi_table_header hdr;
+ u16 platform_class;
+ u16 reserved;
+ u64 control_area_pa;
+ u32 start_method;
+} __packed;
[...]
+ }
+
+ if (buf->hdr.length != sizeof(struct acpi_tp
On 11/27/2014 10:40 AM, Jarkko Sakkinen wrote:
On Wed, Nov 26, 2014 at 09:06:57AM -0500, Stefan Berger wrote:
On 11/11/2014 08:45 AM, Jarkko Sakkinen wrote:
tpm_crb is a driver for TPM 2.0 Command Response Buffer (CRB) Interface
as defined in PC Client Platform TPM Profile (PTP) Specification
On 11/11/2014 08:45 AM, Jarkko Sakkinen wrote:
From: Will Arthur
Detect TPM 2.0 by using the extended STS (STS3) register. For TPM 2.0,
instead of calling tpm_get_timeouts(), assign duration and timeout
values defined in the TPM 2.0 PTP specification.
Signed-off-by: Will Arthur
Signed-off
c
+++ b/drivers/char/tpm/xen-tpmfront.c
@@ -175,9 +175,9 @@ static int setup_chip(struct device *dev, struct
tpm_private *priv)
{
struct tpm_chip *chip;
- chip = tpm_register_hardware(dev, &tpm_vtpm);
- if (!chip)
- return -ENODEV;
+ chip = tpmm_chip_a
On 11/11/2014 08:45 AM, Jarkko Sakkinen wrote:
tpm_crb is a driver for TPM 2.0 Command Response Buffer (CRB) Interface
as defined in PC Client Platform TPM Profile (PTP) Specification.
Only polling and single locality is supported as these are the limitations
of the available hardware, Platform
i);
@@ -708,7 +708,7 @@ static int tpm_tis_init(struct device *dev, acpi_handle
acpi_dev_handle,
TPM_INT_VECTOR(chip->vendor.locality));
if (devm_request_irq
(dev, chip->vendor.irq, tis_int_handler,
On 11/11/2014 08:45 AM, Jarkko Sakkinen wrote:
The sysfs attributes of the TPM device were created to the platform
device directory that owns the character device instead of placing
them correctly to the directory of the character device,
They were also created in a racy way so that character de
On 11/11/2014 08:45 AM, Jarkko Sakkinen wrote:
TPM 2.0 devices are separated by adding a field 'flags' to struct
tpm_chip and defining a flag TPM_CHIP_FLAG_TPM2 for tagging them.
This patch adds the following internal functions:
- tpm2_get_random()
- tpm2_get_tpm_pt()
- tpm2_pcr_extend()
- tpm2
On 11/11/2014 08:45 AM, Jarkko Sakkinen wrote:
Manadatory sysfs attributes for TPM 2.0 devices so that it is easy
to check whether storage hierarchies are enabled and use PPI
interface.
Signed-off-by: Jarkko Sakkinen
---
Documentation/ABI/stable/sysfs-class-tpm2 | 57 +++
drivers/ch
On 11/11/2014 08:45 AM, Jarkko Sakkinen wrote:
From: Will Arthur
Detect TPM 2.0 by using the extended STS (STS3) register. For TPM 2.0,
instead of calling tpm_get_timeouts(), assign duration and timeout
values defined in the TPM 2.0 PTP specification.
Signed-off-by: Will Arthur
Signed-off-by:
const struct tpm_class_ops *ops;
int dev_num;/* /dev/tpm# */
So this is the core requiring the renamings. I assume you got them all
and none were hidden in #if's or so.
Reviewed-by: Stefan Berger
--
To unsubscribe from this list: send the line "unsubscribe linux-ker
On 11/11/2014 08:45 AM, Jarkko Sakkinen wrote:
Traversal of the ACPI device tree was not done right. It should lookup
PPI only under the ACPI device that it is associated. Otherwise, it could
match to a wrong PPI interface if there are two TPM devices in the device
tree.
Removed global ACPI hand
On 11/11/2014 08:45 AM, Jarkko Sakkinen wrote:
Merged transmit_cmd() functions in tpm-interface.c and tpm-sysfs.c.
Added "tpm_" prefix for consistency sake. Changed cmd parameter as
opaque. This enables to use separate command structures for TPM1
and TPM2 commands in future. Loose coupling works
On 10/07/2014 02:02 PM, Jason Gunthorpe wrote:
On Tue, Oct 07, 2014 at 01:54:41PM -0400, Stefan Berger wrote:
Why add the complexity of swapping of authenticated sessions and keys
into the kernel if you can handle this in userspace? You need a library
that is aware of the number of key slots
On 09/23/2014 12:42 PM, Andy Lutomirski wrote:
On Sep 22, 2014 2:07 AM, "Peter Huewe" wrote:
Hi,
I would like to 'invite' all interested parties in a short TPM minisummit where
we can discuss the following hot topics of the TPM subsystem over a beer or two:
- State of the TPM Subsystem
-
On 09/24/2014 03:38 PM, Scot Doyle wrote:
On Tue, 23 Sep 2014, Stefan Berger wrote:
On 09/23/2014 07:55 AM, Scot Doyle wrote:
On Tue, 23 Sep 2014, Scot Doyle wrote:
+static void disable_interrupts(struct tpm_chip *chip)
+{
+ u32 intmask;
+ intmask =
+ ioread32(chip
On 09/24/2014 01:13 PM, Jason Gunthorpe wrote:
On Wed, Sep 24, 2014 at 12:06:02PM +0300, Jarkko Sakkinen wrote:
+static ssize_t durations_show(struct device *dev, struct device_attribute
*attr,
+ char *buf)
+{
+ struct tpm_chip *chip = dev_get_drvdata(dev);
+
+
On 09/23/2014 07:55 AM, Scot Doyle wrote:
On Tue, 23 Sep 2014, Scot Doyle wrote:
---
drivers/char/tpm/tpm_tis.c | 76 +-
1 file changed, 62 insertions(+), 14 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 2c46734
On 10/04/2013 01:08 PM, Jason Gunthorpe wrote:
On Mon, Sep 30, 2013 at 05:09:51PM -0500, Joel Schopp wrote:
So far, nobody I have talked to has offered any strong opinions on
what locality should be used or how it should be set. I think finding
a developer of trousers may be the most useful to
501 - 598 of 598 matches
Mail list logo