Re: file metadata via fs API

Hi, On 12/08/2020 20:50, Linus Torvalds wrote: On Wed, Aug 12, 2020 at 12:34 PM Steven Whitehouse wrote: The point of this is to give us the ability to monitor mounts from userspace. We haven't had that before, I don't see why it's suddenly such a big deal. The notification side I

Re: file metadata via fs API

Hi, On 12/08/2020 19:18, Linus Torvalds wrote: On Tue, Aug 11, 2020 at 5:05 PM David Howells wrote: Well, the start of it was my proposal of an fsinfo() system call. Ugh. Ok, it's that thing. This all seems *WAY* over-designed - both your fsinfo and Miklos' version. What's wrong with

Re: file metadata via fs API

Hi, On 12/08/2020 09:37, Miklos Szeredi wrote: [snip] b) The awarded performance boost is not warranted for the use cases it is designed for. Thanks, Miklos This is a key point. One of the main drivers for this work is the efficiency improvement for large numbers of mounts. Ian and Karel

Re: Why add the general notification queue and its sources

Hi, On 05/09/2019 18:19, Linus Torvalds wrote: On Thu, Sep 5, 2019 at 10:01 AM David Howells wrote: I'm just going to be very blunt about this, and say that there is no way I can merge any of this *ever*, unless other people stand up and say that (a) they'll use it and (b) they'll

Re: [git pull] mount API series

Hi, On 31/10/18 15:38, Eric W. Biederman wrote: Al Viro writes: mount API series from David Howells. Last cycle's objections had been of the "I'd do it differently" variety and with no such differently done variants having ever materialized over several cycles... Absolutely not.

Re: [git pull] mount API series

Hi, On 31/10/18 15:38, Eric W. Biederman wrote: Al Viro writes: mount API series from David Howells. Last cycle's objections had been of the "I'd do it differently" variety and with no such differently done variants having ever materialized over several cycles... Absolutely not.

Re: [git pull] mount API series

Hi, On 31/10/18 16:18, Linus Torvalds wrote: On Tue, Oct 30, 2018 at 10:34 PM Al Viro wrote: mount API series from David Howells. Last cycle's objections had been of the "I'd do it differently" variety and with no such differently done variants having ever materialized over several

Re: [git pull] mount API series

Hi, On 31/10/18 16:18, Linus Torvalds wrote: On Tue, Oct 30, 2018 at 10:34 PM Al Viro wrote: mount API series from David Howells. Last cycle's objections had been of the "I'd do it differently" variety and with no such differently done variants having ever materialized over several

Re: vmalloc with GFP_NOFS

Hi, On 24/04/18 17:27, Michal Hocko wrote: Hi, it seems that we still have few vmalloc users who perform GFP_NOFS allocation: drivers/mtd/ubi/io.c fs/ext4/xattr.c fs/gfs2/dir.c fs/gfs2/quota.c fs/nfs/blocklayout/extent_tree.c fs/ubifs/debug.c fs/ubifs/lprops.c fs/ubifs/lpt_commit.c

Re: vmalloc with GFP_NOFS

Hi, On 24/04/18 17:27, Michal Hocko wrote: Hi, it seems that we still have few vmalloc users who perform GFP_NOFS allocation: drivers/mtd/ubi/io.c fs/ext4/xattr.c fs/gfs2/dir.c fs/gfs2/quota.c fs/nfs/blocklayout/extent_tree.c fs/ubifs/debug.c fs/ubifs/lprops.c fs/ubifs/lpt_commit.c

Re: WARNING: kobject bug in sysfs_warn_dup

Hi, On 05/04/18 14:34, Greg KH wrote: On Thu, Apr 05, 2018 at 10:00:04AM +0100, Steven Whitehouse wrote: Hi, On 05/04/18 09:52, Dmitry Vyukov wrote: On Thu, Apr 5, 2018 at 10:36 AM, Steven Whitehouse <swhit...@redhat.com> wrote: Hi, On 05/04/18 09:19, Dmitry Vyukov wrote: On Th

Re: WARNING: kobject bug in sysfs_warn_dup

Hi, On 05/04/18 14:34, Greg KH wrote: On Thu, Apr 05, 2018 at 10:00:04AM +0100, Steven Whitehouse wrote: Hi, On 05/04/18 09:52, Dmitry Vyukov wrote: On Thu, Apr 5, 2018 at 10:36 AM, Steven Whitehouse wrote: Hi, On 05/04/18 09:19, Dmitry Vyukov wrote: On Thu, Apr 5, 2018 at 8:34 AM

Re: WARNING: kobject bug in sysfs_warn_dup

Hi, On 05/04/18 09:52, Dmitry Vyukov wrote: On Thu, Apr 5, 2018 at 10:36 AM, Steven Whitehouse <swhit...@redhat.com> wrote: Hi, On 05/04/18 09:19, Dmitry Vyukov wrote: On Thu, Apr 5, 2018 at 8:34 AM, Greg KH <gre...@linuxfoundation.org> wrote: On Wed, Apr 04, 2018 at 07:0

Re: WARNING: kobject bug in sysfs_warn_dup

Hi, On 05/04/18 09:52, Dmitry Vyukov wrote: On Thu, Apr 5, 2018 at 10:36 AM, Steven Whitehouse wrote: Hi, On 05/04/18 09:19, Dmitry Vyukov wrote: On Thu, Apr 5, 2018 at 8:34 AM, Greg KH wrote: On Wed, Apr 04, 2018 at 07:02:01PM -0700, syzbot wrote: Hello, syzbot hit the following

Re: WARNING: kobject bug in sysfs_warn_dup

Hi, On 05/04/18 09:19, Dmitry Vyukov wrote: On Thu, Apr 5, 2018 at 8:34 AM, Greg KH wrote: On Wed, Apr 04, 2018 at 07:02:01PM -0700, syzbot wrote: Hello, syzbot hit the following crash on upstream commit 3e968c9f1401088abc9a19ae6ff571644d37a355 (Wed Apr 4

Re: WARNING: kobject bug in sysfs_warn_dup

Hi, On 05/04/18 09:19, Dmitry Vyukov wrote: On Thu, Apr 5, 2018 at 8:34 AM, Greg KH wrote: On Wed, Apr 04, 2018 at 07:02:01PM -0700, syzbot wrote: Hello, syzbot hit the following crash on upstream commit 3e968c9f1401088abc9a19ae6ff571644d37a355 (Wed Apr 4 21:19:24 2018 +) Merge tag

Re: WARNING in account_page_dirtied

Hi, On 04/04/18 13:36, Jan Kara wrote: Hi, On Wed 04-04-18 10:24:48, Steven Whitehouse wrote: On 03/04/18 13:05, Jan Kara wrote: Hello, On Sun 01-04-18 10:01:02, syzbot wrote: syzbot hit the following crash on upstream commit 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00

Re: WARNING in account_page_dirtied

Hi, On 04/04/18 13:36, Jan Kara wrote: Hi, On Wed 04-04-18 10:24:48, Steven Whitehouse wrote: On 03/04/18 13:05, Jan Kara wrote: Hello, On Sun 01-04-18 10:01:02, syzbot wrote: syzbot hit the following crash on upstream commit 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00

Re: WARNING in account_page_dirtied

Hi, On 03/04/18 13:05, Jan Kara wrote: Hello, On Sun 01-04-18 10:01:02, syzbot wrote: syzbot hit the following crash on upstream commit 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00 2018 +) Merge branch 'perf-urgent-for-linus' of

Re: WARNING in account_page_dirtied

Hi, On 03/04/18 13:05, Jan Kara wrote: Hello, On Sun 01-04-18 10:01:02, syzbot wrote: syzbot hit the following crash on upstream commit 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00 2018 +) Merge branch 'perf-urgent-for-linus' of

Re: [Cluster-devel] [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

Hi, Can we solve the problem another way, by not taking refs on the glocks when we are iterating over them for the debugfs files? I assume that is the main issue here. We didn't used to take refs since the rcu locking was enough during the walk itself. We used to only keep track of the hash

Re: [Cluster-devel] [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

Hi, Can we solve the problem another way, by not taking refs on the glocks when we are iterating over them for the debugfs files? I assume that is the main issue here. We didn't used to take refs since the rcu locking was enough during the walk itself. We used to only keep track of the hash

Re: [RFC PATCH v1 00/13] lru_lock scalability

Hi, On 02/02/18 04:18, Daniel Jordan wrote: On 02/01/2018 10:54 AM, Steven Whitehouse wrote: Hi, On 31/01/18 23:04, daniel.m.jor...@oracle.com wrote: lru_lock, a per-node* spinlock that protects an LRU list, is one of the hottest locks in the kernel.  On some workloads on large machines

Re: [RFC PATCH v1 00/13] lru_lock scalability

Hi, On 02/02/18 04:18, Daniel Jordan wrote: On 02/01/2018 10:54 AM, Steven Whitehouse wrote: Hi, On 31/01/18 23:04, daniel.m.jor...@oracle.com wrote: lru_lock, a per-node* spinlock that protects an LRU list, is one of the hottest locks in the kernel.  On some workloads on large machines

Re: [RFC PATCH v1 00/13] lru_lock scalability

Hi, On 31/01/18 23:04, daniel.m.jor...@oracle.com wrote: lru_lock, a per-node* spinlock that protects an LRU list, is one of the hottest locks in the kernel. On some workloads on large machines, it shows up at the top of lock_stat. One way to improve lru_lock scalability is to introduce an

Re: [RFC PATCH v1 00/13] lru_lock scalability

Hi, On 31/01/18 23:04, daniel.m.jor...@oracle.com wrote: lru_lock, a per-node* spinlock that protects an LRU list, is one of the hottest locks in the kernel. On some workloads on large machines, it shows up at the top of lock_stat. One way to improve lru_lock scalability is to introduce an

Re: linux-next: Signed-off-by missing for commit in the gfs2 tree

On 16/01/18 20:51, Stephen Rothwell wrote: Hi all, Commit 7d2040199855 ("gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use") is missing a Signed-off-by from its author. Bob, can you add that? Steve.

Re: linux-next: Signed-off-by missing for commit in the gfs2 tree

On 16/01/18 20:51, Stephen Rothwell wrote: Hi all, Commit 7d2040199855 ("gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use") is missing a Signed-off-by from its author. Bob, can you add that? Steve.

Re: [PATCH 3/3] ima: use fs method to read integrity data (updated patch description)

Hi, On 17/09/17 17:38, Al Viro wrote: On Sun, Sep 17, 2017 at 09:34:01AM -0700, Linus Torvalds wrote: Now, I suspect most (all?) do, but that's a historical artifact rather than "design". In particular, the VFS layer used to do the locking for the filesystems, to guarantee the POSIX

Re: [PATCH 3/3] ima: use fs method to read integrity data (updated patch description)

Hi, On 17/09/17 17:38, Al Viro wrote: On Sun, Sep 17, 2017 at 09:34:01AM -0700, Linus Torvalds wrote: Now, I suspect most (all?) do, but that's a historical artifact rather than "design". In particular, the VFS layer used to do the locking for the filesystems, to guarantee the POSIX

Re: [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait

Hi, On 31/07/17 13:22, Jeff Layton wrote: On Mon, 2017-07-31 at 13:05 +0100, Steven Whitehouse wrote: Hi, On 31/07/17 12:44, Jeff Layton wrote: On Mon, 2017-07-31 at 12:32 +0100, Steven Whitehouse wrote: Hi, On 31/07/17 12:27, Jeff Layton wrote: On Thu, 2017-07-27 at 08:48 -0400, Jeff

Re: [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait

Hi, On 31/07/17 13:22, Jeff Layton wrote: On Mon, 2017-07-31 at 13:05 +0100, Steven Whitehouse wrote: Hi, On 31/07/17 12:44, Jeff Layton wrote: On Mon, 2017-07-31 at 12:32 +0100, Steven Whitehouse wrote: Hi, On 31/07/17 12:27, Jeff Layton wrote: On Thu, 2017-07-27 at 08:48 -0400, Jeff

Re: [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait

Hi, On 31/07/17 12:44, Jeff Layton wrote: On Mon, 2017-07-31 at 12:32 +0100, Steven Whitehouse wrote: Hi, On 31/07/17 12:27, Jeff Layton wrote: On Thu, 2017-07-27 at 08:48 -0400, Jeff Layton wrote: On Thu, 2017-07-27 at 10:49 +0200, Jan Kara wrote: On Wed 26-07-17 13:55:36, Jeff Layton

Re: [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait

Hi, On 31/07/17 12:44, Jeff Layton wrote: On Mon, 2017-07-31 at 12:32 +0100, Steven Whitehouse wrote: Hi, On 31/07/17 12:27, Jeff Layton wrote: On Thu, 2017-07-27 at 08:48 -0400, Jeff Layton wrote: On Thu, 2017-07-27 at 10:49 +0200, Jan Kara wrote: On Wed 26-07-17 13:55:36, Jeff Layton

Re: [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait

Hi, On 31/07/17 12:27, Jeff Layton wrote: On Thu, 2017-07-27 at 08:48 -0400, Jeff Layton wrote: On Thu, 2017-07-27 at 10:49 +0200, Jan Kara wrote: On Wed 26-07-17 13:55:36, Jeff Layton wrote: +int file_write_and_wait(struct file *file) +{ + int err = 0, err2; + struct

Re: [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait

Hi, On 31/07/17 12:27, Jeff Layton wrote: On Thu, 2017-07-27 at 08:48 -0400, Jeff Layton wrote: On Thu, 2017-07-27 at 10:49 +0200, Jan Kara wrote: On Wed 26-07-17 13:55:36, Jeff Layton wrote: +int file_write_and_wait(struct file *file) +{ + int err = 0, err2; + struct

Re: [PATCH v2 4/4] gfs2: convert to errseq_t based writeback error reporting for fsync

Hi, On 28/07/17 13:47, Jeff Layton wrote: On Fri, 2017-07-28 at 13:37 +0100, Steven Whitehouse wrote: Hi, On 27/07/17 13:47, Bob Peterson wrote: - Original Message - On Wed, 2017-07-26 at 12:21 -0700, Matthew Wilcox wrote: On Wed, Jul 26, 2017 at 01:55:38PM -0400, Jeff Layton

Re: [PATCH v2 4/4] gfs2: convert to errseq_t based writeback error reporting for fsync

Hi, On 28/07/17 13:47, Jeff Layton wrote: On Fri, 2017-07-28 at 13:37 +0100, Steven Whitehouse wrote: Hi, On 27/07/17 13:47, Bob Peterson wrote: - Original Message - On Wed, 2017-07-26 at 12:21 -0700, Matthew Wilcox wrote: On Wed, Jul 26, 2017 at 01:55:38PM -0400, Jeff Layton

Re: [PATCH v2 4/4] gfs2: convert to errseq_t based writeback error reporting for fsync

Hi, On 27/07/17 13:47, Bob Peterson wrote: - Original Message - | On Wed, 2017-07-26 at 12:21 -0700, Matthew Wilcox wrote: | > On Wed, Jul 26, 2017 at 01:55:38PM -0400, Jeff Layton wrote: | > > @@ -668,12 +668,14 @@ static int gfs2_fsync(struct file *file, loff_t | > > start, loff_t

Re: [PATCH v2 4/4] gfs2: convert to errseq_t based writeback error reporting for fsync

Hi, On 27/07/17 13:47, Bob Peterson wrote: - Original Message - | On Wed, 2017-07-26 at 12:21 -0700, Matthew Wilcox wrote: | > On Wed, Jul 26, 2017 at 01:55:38PM -0400, Jeff Layton wrote: | > > @@ -668,12 +668,14 @@ static int gfs2_fsync(struct file *file, loff_t | > > start, loff_t

Re: Question about SOCK_SEQPACKET

Hi, On 05/05/17 11:09, Sowmini Varadhan wrote: On (05/05/17 10:45), Steven Whitehouse wrote: I do wonder if the man page for recvmsg is wrong, or at least a bit confusing. SOCK_SEQPACKET is stream based not message based - it just happens to have EOR markers in the stream. There is no reason

Re: Question about SOCK_SEQPACKET

Hi, On 05/05/17 11:09, Sowmini Varadhan wrote: On (05/05/17 10:45), Steven Whitehouse wrote: I do wonder if the man page for recvmsg is wrong, or at least a bit confusing. SOCK_SEQPACKET is stream based not message based - it just happens to have EOR markers in the stream. There is no reason

Re: Question about SOCK_SEQPACKET

Hi, On 05/05/17 06:18, Sam Kumar wrote: Hello, I have recently had occasion to use SOCK_SEQPACKET sockets on Linux, and noticed some odd behavior. When using sendmsg and recvmsg with these sockets, it seems that the "end-of-record" flag (MSG_EOR) is not being propagated correctly. It depends

Re: Question about SOCK_SEQPACKET

Hi, On 05/05/17 06:18, Sam Kumar wrote: Hello, I have recently had occasion to use SOCK_SEQPACKET sockets on Linux, and noticed some odd behavior. When using sendmsg and recvmsg with these sockets, it seems that the "end-of-record" flag (MSG_EOR) is not being propagated correctly. It depends

Re: [Cluster-devel] [PATCH 2/2] GFS2: Add a gfs2-specific prune_icache_sb

Hi, On 28/06/16 03:08, Dave Chinner wrote: On Fri, Jun 24, 2016 at 02:50:11PM -0500, Bob Peterson wrote: This patch adds a new prune_icache_sb function for the VFS slab shrinker to call. Trying to directly free the inodes from memory might deadlock because it evicts inodes, which calls into

Re: [Cluster-devel] [PATCH 2/2] GFS2: Add a gfs2-specific prune_icache_sb

Hi, On 28/06/16 03:08, Dave Chinner wrote: On Fri, Jun 24, 2016 at 02:50:11PM -0500, Bob Peterson wrote: This patch adds a new prune_icache_sb function for the VFS slab shrinker to call. Trying to directly free the inodes from memory might deadlock because it evicts inodes, which calls into

Re: [Cluster-devel] [PATCH 2/2] GFS2: Add a gfs2-specific prune_icache_sb

Hi, I think the idea looks good. A couple of comments below though... On 24/06/16 20:50, Bob Peterson wrote: This patch adds a new prune_icache_sb function for the VFS slab shrinker to call. Trying to directly free the inodes from memory might deadlock because it evicts inodes, which calls

Re: [Cluster-devel] [PATCH 2/2] GFS2: Add a gfs2-specific prune_icache_sb

Hi, I think the idea looks good. A couple of comments below though... On 24/06/16 20:50, Bob Peterson wrote: This patch adds a new prune_icache_sb function for the VFS slab shrinker to call. Trying to directly free the inodes from memory might deadlock because it evicts inodes, which calls

Re: [Cluster-devel] [PATCH 0/2] scop GFP_NOFS api

Hi, On 29/04/16 06:35, NeilBrown wrote: On Tue, Apr 26 2016, Michal Hocko wrote: Hi, we have discussed this topic at LSF/MM this year. There was a general interest in the scope GFP_NOFS allocation context among some FS developers. For those who are not aware of the discussion or the issue I

Re: [Cluster-devel] [PATCH 0/2] scop GFP_NOFS api

Hi, On 29/04/16 06:35, NeilBrown wrote: On Tue, Apr 26 2016, Michal Hocko wrote: Hi, we have discussed this topic at LSF/MM this year. There was a general interest in the scope GFP_NOFS allocation context among some FS developers. For those who are not aware of the discussion or the issue I

Re: [PATCH v5 10/11] block: remove bio_get_nr_vecs()

Hi, On 06/07/15 18:21, Ming Lin wrote: On Mon, Jul 6, 2015 at 3:58 AM, Steven Whitehouse wrote: Hi, On 06/07/15 08:44, Ming Lin wrote: From: Kent Overstreet We can always fill up the bio now, no need to estimate the possible size based on queue parameters. [snip] diff --git a/fs/gfs2

Re: [PATCH v5 10/11] block: remove bio_get_nr_vecs()

Hi, On 06/07/15 18:21, Ming Lin wrote: On Mon, Jul 6, 2015 at 3:58 AM, Steven Whitehouse swhit...@redhat.com wrote: Hi, On 06/07/15 08:44, Ming Lin wrote: From: Kent Overstreet kent.overstr...@gmail.com We can always fill up the bio now, no need to estimate the possible size based on queue

Re: [PATCH v5 10/11] block: remove bio_get_nr_vecs()

Hi, On 06/07/15 08:44, Ming Lin wrote: From: Kent Overstreet We can always fill up the bio now, no need to estimate the possible size based on queue parameters. [snip] diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c index 2c1ae86..64d3116 100644 --- a/fs/gfs2/lops.c +++ b/fs/gfs2/lops.c @@

Re: [PATCH v5 10/11] block: remove bio_get_nr_vecs()

Hi, On 06/07/15 08:44, Ming Lin wrote: From: Kent Overstreet kent.overstr...@gmail.com We can always fill up the bio now, no need to estimate the possible size based on queue parameters. [snip] diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c index 2c1ae86..64d3116 100644 --- a/fs/gfs2/lops.c

Re: [RFC 1/1 linux-next] gfs2: convert simple_str to kstr

-by: Steven Whitehouse Steve. --- fs/gfs2/sys.c | 56 1 file changed, 44 insertions(+), 12 deletions(-) diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c index ae8e881..436bdeb 100644 --- a/fs/gfs2/sys.c +++ b/fs/gfs2/sys.c @@ -101,8 +101,11

Re: [RFC 1/1 linux-next] gfs2: convert simple_str to kstr

anyway. Acked-by: Steven Whitehouse swhit...@redhat.com Steve. --- fs/gfs2/sys.c | 56 1 file changed, 44 insertions(+), 12 deletions(-) diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c index ae8e881..436bdeb 100644 --- a/fs/gfs2/sys.c +++ b

Re: linux-next: Tree for Apr 20 (gfs2)

Hi, On 20/04/15 16:40, Randy Dunlap wrote: On 04/19/15 22:45, Stephen Rothwell wrote: Hi all, Please do not add any v4.2 material to your linux-next included trees until after v4.1-rc1 is released. Changes since 20150415: on i386: ERROR: "__divdi3" [fs/gfs2/gfs2.ko] undefined! These

Re: linux-next: Tree for Apr 20 (gfs2)

Hi, On 20/04/15 16:40, Randy Dunlap wrote: On 04/19/15 22:45, Stephen Rothwell wrote: Hi all, Please do not add any v4.2 material to your linux-next included trees until after v4.1-rc1 is released. Changes since 20150415: on i386: ERROR: __divdi3 [fs/gfs2/gfs2.ko] undefined! These

Re: GFS2: Pull request (merge window)

Hi, On 15/04/15 00:16, Linus Torvalds wrote: On Tue, Apr 14, 2015 at 10:47 AM, Bob Peterson wrote: There's another that adds me as a GFS2 co-maintainer [...] So generally, when I start getting pull requests from different people, I'd like to see a previous separate heads-up or confirmation

Re: GFS2: Pull request (merge window)

Hi, On 15/04/15 00:16, Linus Torvalds wrote: On Tue, Apr 14, 2015 at 10:47 AM, Bob Peterson rpete...@redhat.com wrote: There's another that adds me as a GFS2 co-maintainer [...] So generally, when I start getting pull requests from different people, I'd like to see a previous separate

Re: [Cluster-devel] [PATCH 08/16] gfs2: use is_xxx_kiocb instead of filp->fl_flags

Hi, On 04/04/15 20:13, Dmitry Monakhov wrote: Cc: cluster-de...@redhat.com Signed-off-by: Dmitry Monakhov Acked-by: Steven Whitehouse Steve. --- fs/gfs2/file.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index f6fc412

Re: [Cluster-devel] [PATCH 08/16] gfs2: use is_xxx_kiocb instead of filp-fl_flags

Hi, On 04/04/15 20:13, Dmitry Monakhov wrote: Cc: cluster-de...@redhat.com Signed-off-by: Dmitry Monakhov dmonak...@openvz.org Acked-by: Steven Whitehouse swhit...@redhat.com Steve. --- fs/gfs2/file.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/gfs2

Re: [PATCH 1/1] gfs2: incorrect check for debugfs returns

reasonable to me: Acked-by: Steven Whitehouse Steve. Signed-off-by: Chengyu Song --- fs/gfs2/glock.c | 47 --- 1 file changed, 28 insertions(+), 19 deletions(-) diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index f42dffb..0fa8062 100644 --- a/fs/gfs2

Re: [PATCH 1/1] gfs2: incorrect check for debugfs returns

reasonable to me: Acked-by: Steven Whitehouse swhit...@redhat.com Steve. Signed-off-by: Chengyu Song cson...@gatech.edu --- fs/gfs2/glock.c | 47 --- 1 file changed, 28 insertions(+), 19 deletions(-) diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index

Re: [PATCH] fs: record task name which froze superblock

Hi, On 18/02/15 09:13, Jan Kara wrote: On Wed 18-02-15 10:34:55, Alexey Dobriyan wrote: On Mon, Feb 16, 2015 at 10:38:52AM +0100, Jan Kara wrote: On Sat 14-02-15 21:55:24, Alexey Dobriyan wrote: Freezing and thawing are separate system calls, task which is supposed to thaw

Re: [PATCH] fs: record task name which froze superblock

Hi, On 18/02/15 09:13, Jan Kara wrote: On Wed 18-02-15 10:34:55, Alexey Dobriyan wrote: On Mon, Feb 16, 2015 at 10:38:52AM +0100, Jan Kara wrote: On Sat 14-02-15 21:55:24, Alexey Dobriyan wrote: Freezing and thawing are separate system calls, task which is supposed to thaw

GFS2: Pull request (merge window)

Hi, Please consider pulling the following changes, Steve. -- This time we have mostly clean ups. There is a bug fix for a NULL dereference relating to ACLs, and another which improves (but does not fix entirely) an

[PATCH 2/5] GFS2: fix sprintf format specifier

From: alex chen Sprintf format specifier "%d" and "%u" are mixed up in gfs2_recovery_done() and freeze_show(). So correct them. Signed-off-by: Alex Chen Reviewed-by: Joseph Qi Signed-off-by: Steven Whitehouse diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c index 573

[PATCH 4/5] GFS2: use __vmalloc GFP_NOFS for fs-related allocations.

From: Oleg Drokin leaf_dealloc uses vzalloc as a fallback to kzalloc(GFP_NOFS), so it clearly does not want any shrinker activity within the fs itself. convert vzalloc into __vmalloc(GFP_NOFS|__GFP_ZERO) to better achieve this goal. Signed-off-by: Oleg Drokin Signed-off-by: Steven Whitehouse

[PATCH 1/5] GFS2: Eliminate __gfs2_glock_remove_from_lru

From: Bob Peterson Since the only caller of function __gfs2_glock_remove_from_lru locks the same spin_lock as gfs2_glock_remove_from_lru, the functions can be combined. Signed-off-by: Bob Peterson Signed-off-by: Steven Whitehouse diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index a23524a

[PATCH 3/5] GFS2: Eliminate a nonsense goto

From: Bob Peterson This patch just removes a goto that did nothing. Signed-off-by: Bob Peterson Signed-off-by: Steven Whitehouse diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 9054002..73c72253 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c @@ -543,10 +543,7 @@ static int

GFS2: Pre-pull patch posting

This time we have mostly clean ups. There is a bug fix for a NULL dereference relating to ACLs, and another which improves (but does not fix entirely) an allocation fall-back code path. The other three patches are small clean ups. Steve. -- To unsubscribe from this list: send the line

[PATCH 5/5] GFS2: Fix crash during ACL deletion in acl max entry check in gfs2_set_acl()

From: Andrew Elble Fixes: e01580bf9e ("gfs2: use generic posix ACL infrastructure") Reported-by: Eric Meddaugh Tested-by: Eric Meddaugh Signed-off-by: Andrew Elble Signed-off-by: Steven Whitehouse diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c index 3088e2a..7b31430 100644 --- a/fs/

[PATCH 2/5] GFS2: fix sprintf format specifier

From: alex chen alex.c...@huawei.com Sprintf format specifier %d and %u are mixed up in gfs2_recovery_done() and freeze_show(). So correct them. Signed-off-by: Alex Chen alex.c...@huawei.com Reviewed-by: Joseph Qi joseph...@huawei.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff

[PATCH 4/5] GFS2: use __vmalloc GFP_NOFS for fs-related allocations.

...@linuxhacker.ru Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index c5a34f0..6371192 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -1896,7 +1896,8 @@ static int leaf_dealloc(struct gfs2_inode *dip, u32 index, u32 len, ht = kzalloc(size

[PATCH 1/5] GFS2: Eliminate __gfs2_glock_remove_from_lru

From: Bob Peterson rpete...@redhat.com Since the only caller of function __gfs2_glock_remove_from_lru locks the same spin_lock as gfs2_glock_remove_from_lru, the functions can be combined. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff

[PATCH 3/5] GFS2: Eliminate a nonsense goto

From: Bob Peterson rpete...@redhat.com This patch just removes a goto that did nothing. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 9054002..73c72253 100644 --- a/fs/gfs2/inode.c +++ b

[PATCH 5/5] GFS2: Fix crash during ACL deletion in acl max entry check in gfs2_set_acl()

From: Andrew Elble awe...@rit.edu Fixes: e01580bf9e (gfs2: use generic posix ACL infrastructure) Reported-by: Eric Meddaugh etm...@rit.edu Tested-by: Eric Meddaugh etm...@rit.edu Signed-off-by: Andrew Elble awe...@rit.edu Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2

GFS2: Pre-pull patch posting

This time we have mostly clean ups. There is a bug fix for a NULL dereference relating to ACLs, and another which improves (but does not fix entirely) an allocation fall-back code path. The other three patches are small clean ups. Steve. -- To unsubscribe from this list: send the line

GFS2: Pull request (merge window)

Hi, Please consider pulling the following changes, Steve. -- This time we have mostly clean ups. There is a bug fix for a NULL dereference relating to ACLs, and another which improves (but does not fix entirely) an

Re: [PATCH] gfs2: use __vmalloc GFP_NOFS for fs-related allocations.

Hi, On 04/02/15 07:13, Oleg Drokin wrote: Hello! On Feb 3, 2015, at 5:33 PM, Dave Chinner wrote: I also wonder if vmalloc is still very slow? That was the case some time ago when I noticed a problem in directory access times in gfs2, which made us change to use kmalloc with a vmalloc fallback

Re: [PATCH] gfs2: use __vmalloc GFP_NOFS for fs-related allocations.

Hi, On 04/02/15 07:13, Oleg Drokin wrote: Hello! On Feb 3, 2015, at 5:33 PM, Dave Chinner wrote: I also wonder if vmalloc is still very slow? That was the case some time ago when I noticed a problem in directory access times in gfs2, which made us change to use kmalloc with a vmalloc fallback

Re: [PATCH] gfs2: use __vmalloc GFP_NOFS for fs-related allocations.

Hi, On 02/02/15 08:11, Dave Chinner wrote: On Mon, Feb 02, 2015 at 01:57:23AM -0500, Oleg Drokin wrote: Hello! On Feb 2, 2015, at 12:37 AM, Dave Chinner wrote: On Sun, Feb 01, 2015 at 10:59:54PM -0500, gr...@linuxhacker.ru wrote: From: Oleg Drokin leaf_dealloc uses vzalloc as a fallback

Re: [PATCH] gfs2: use __vmalloc GFP_NOFS for fs-related allocations.

Hi, On 02/02/15 08:11, Dave Chinner wrote: On Mon, Feb 02, 2015 at 01:57:23AM -0500, Oleg Drokin wrote: Hello! On Feb 2, 2015, at 12:37 AM, Dave Chinner wrote: On Sun, Feb 01, 2015 at 10:59:54PM -0500, gr...@linuxhacker.ru wrote: From: Oleg Drokin gr...@linuxhacker.ru leaf_dealloc uses

GFS2: Pull request (merge window)

Hi, Please consider pulling the following changes, Steve. -- The following changes since commit 0df1f2487d2f0d04703f142813d53615d62a1da4: Linux 3.18-rc3 (2014-11-02 15:01:51 -0800) are available in the git

GFS2: Pull request (merge window)

Hi, Please consider pulling the following changes, Steve. -- The following changes since commit 0df1f2487d2f0d04703f142813d53615d62a1da4: Linux 3.18-rc3 (2014-11-02 15:01:51 -0800) are available in the git

Re: [Cluster-devel] gfs2: gfs2_dir_get_hash_table(): avoiding deferred vfree() is easy here...

Hi, All five patches now in the GFS2 -nmw tree. Thanks, Steve. On 20/11/14 05:19, Al Viro wrote: vfree() is allowed under spinlock these days, but it's cheaper when it doesn't step into deferred case and here it's very easy to avoid. Signed-off-by: Al Viro --- fs/gfs2/dir.c |7 ---

Re: [Cluster-devel] gfs2: gfs2_dir_get_hash_table(): avoiding deferred vfree() is easy here...

Hi, All five patches now in the GFS2 -nmw tree. Thanks, Steve. On 20/11/14 05:19, Al Viro wrote: vfree() is allowed under spinlock these days, but it's cheaper when it doesn't step into deferred case and here it's very easy to avoid. Signed-off-by: Al Viro v...@zeniv.linux.org.uk ---

Re: [PATCH 1/1] GFS2: Deletion of unnecessary checks before two function calls

Hi, Now in the GFS2 -nmw git tree. Thanks, Steve. On 18/11/14 10:35, SF Markus Elfring wrote: From: Markus Elfring Date: Tue, 18 Nov 2014 11:31:23 +0100 The functions iput() and put_pid() test whether their argument is NULL and then return immediately. Thus the test around the call is not

Re: [PATCH 1/1] GFS2: Deletion of unnecessary checks before two function calls

Hi, Now in the GFS2 -nmw git tree. Thanks, Steve. On 18/11/14 10:35, SF Markus Elfring wrote: From: Markus Elfring elfr...@users.sourceforge.net Date: Tue, 18 Nov 2014 11:31:23 +0100 The functions iput() and put_pid() test whether their argument is NULL and then return immediately. Thus the

Re: [Cluster-devel] [PATCH v5 6/7] fs: pass iocb to generic_write_sync

generic_write_sync to implement a crude version of fallocate. It has been switched to use an open coded variant instead. Signed-off-by: Christoph Hellwig GFS2 bits: Acked-by: Steven Whitehouse I know that Andy Price has some work in this area too, so in due course we'll have

Re: [Cluster-devel] [PATCH v5 6/7] fs: pass iocb to generic_write_sync

also used generic_write_sync to implement a crude version of fallocate. It has been switched to use an open coded variant instead. Signed-off-by: Christoph Hellwig h...@lst.de GFS2 bits: Acked-by: Steven Whitehouse swhit...@redhat.com I know that Andy Price has some work in this area

Re: [PATCH 1/1 linux-next] GFS2: directly return gfs2_dir_check()

Hi, On 09/10/14 21:49, Fabian Frederick wrote: No need to store gfs2_dir_check result and test it before returning. Signed-off-by: Fabian Frederick Since I've already sent a pull request for this merge window, and this is not urgent, I'll keep this one and use it to start off the new tree

Re: [PATCH 1/1 linux-next] GFS2: directly return gfs2_dir_check()

Hi, On 09/10/14 21:49, Fabian Frederick wrote: No need to store gfs2_dir_check result and test it before returning. Signed-off-by: Fabian Frederick f...@skynet.be Since I've already sent a pull request for this merge window, and this is not urgent, I'll keep this one and use it to start off

GFS2: Pull request (merge window)

Hi, Please consider pulling the following changes, Steve. - The following changes since commit 37504a3be90b69438426d74ccf467a9fe192932b: Merge tag 'gfs2-fixes' of

[PATCH 4/4] GFS2: use _RET_IP_ instead of (unsigned long)__builtin_return_address(0)

From: Fabian Frederick use macro definition Signed-off-by: Fabian Frederick Signed-off-by: Steven Whitehouse diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 7f513b1..8f0c19d 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -811,7 +811,7 @@ void gfs2_holder_init(struct gfs2_glock

[PATCH 2/4] GFS2: Make rename not save dirent location

ocation is not saved and the buffer_head is released as per previous behavior. Signed-off-by: Bob Peterson Signed-off-by: Steven Whitehouse diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index 1a349f9..5d4261f 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -2100,8 +2100,13 @@ int gfs2_diradd_alloc_r

[PATCH 1/4] GFS2: fix bad inode i_goal values during block allocation

i_no_addr field is invalid and so, the fix in gfs2_inplace_reserve() as per 1) won't work in this scenario. We need to catch and fix it sooner in the parent dir itself (gfs2_create_inode()), before it is copied to the new inode. Signed-off-by: Abhi Das Signed-off-by: Steven Whitehouse diff --git

GFS2: Pre-pull patch posting (merge window)

Hi, Not a huge amount this time... just four patches. This time we have a couple of bug fixes, one relating to bad i_goal values which are now ignored (i_goal is basically a hint so it is safe to so this) and another relating to the saving of the dirent location during rename. There is one

[PATCH 3/4] GFS2: Use gfs2_rbm_incr in rgblk_free

From: Bob Peterson This patch speeds up GFS2 unlink operations by using function gfs2_rbm_incr rather than continuously calculating the rbm. Signed-off-by: Bob Peterson Signed-off-by: Steven Whitehouse diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 55ef72d..7474c41 100644 --- a/fs/gfs2

  1   2   3   4   5   6   7   8   9   10   >