Re: [RFC 05/10] i2c: s3c2410: Remove support for Exynos5440

nel.org> Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [RFC 05/10] i2c: s3c2410: Remove support for Exynos5440

On 04/24/2018 10:32 PM, Krzysztof Kozlowski wrote: > The Exynos5440 is not actively developed, there are no development > boards available and probably there are no real products with it. > Remove wide-tree support for Exynos5440. > > Signed-off-by: Krzysztof Kozlowski Reviewe

Re: [PATCH 05/61] clk: samsung: simplify getting .drvdata

On 04/19/2018 04:05 PM, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Patch applied, thanks!

Re: [PATCH 05/61] clk: samsung: simplify getting .drvdata

On 04/19/2018 04:05 PM, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Patch applied, thanks!

Re: [RFC 08/10] spi: s3c64xx: samsung: Remove support for Exynos5440

@kernel.org> It's good you didn't remove S3C64XX_SPI_QUIRK_POLL entirely as it will be needed for Exynos5433 ISP SPI controllers. Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [RFC 08/10] spi: s3c64xx: samsung: Remove support for Exynos5440

good you didn't remove S3C64XX_SPI_QUIRK_POLL entirely as it will be needed for Exynos5433 ISP SPI controllers. Reviewed-by: Sylwester Nawrocki

Re: [RFC 04/10] clk: samsung: Remove support for Exynos5440

Cc: Jingoo Han On 04/24/2018 10:32 PM, Krzysztof Kozlowski wrote: > The Exynos5440 is not actively developed, there are no development > boards available and probably there are no real products with it. > Remove wide-tree support for Exynos5440. > > Signed-off-by: Krzysztof Kozlowski

Re: [RFC 04/10] clk: samsung: Remove support for Exynos5440

Cc: Jingoo Han On 04/24/2018 10:32 PM, Krzysztof Kozlowski wrote: > The Exynos5440 is not actively developed, there are no development > boards available and probably there are no real products with it. > Remove wide-tree support for Exynos5440. > > Signed-off-by: Krzysztof Kozlowski Thanks

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

On 04/18/2018 05:24 PM, Colin Ian King wrote: > Oops, shall I re-send? There is no need to, thanks.

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

On 04/18/2018 05:24 PM, Colin Ian King wrote: > Oops, shall I re-send? There is no need to, thanks.

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: > On 04/18/2018 05:06 PM, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >> this is not being used and cfg

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: > On 04/18/2018 05:06 PM, Colin King wrote: >> From: Colin Ian King >> >> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >> this is not being used and cfg is being re-assigned. I believe the &g

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

d actually be instead the |= operator. > > Detected by CoverityScan, CID#1467987 ("Unused value") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks for the patch. Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

. > > Detected by CoverityScan, CID#1467987 ("Unused value") > > Signed-off-by: Colin Ian King Thanks for the patch. Acked-by: Sylwester Nawrocki

[PATCH] phy: exynos-mipi-video: Simplify code by using regmap_update_bits()

There is no functional change, just replacing regmap_read()/modify/ regmap_write() with regmap_update_bits() function calls. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/phy/samsung/phy-exynos-mipi-video.c | 34 - 1 file chang

[PATCH] phy: exynos-mipi-video: Simplify code by using regmap_update_bits()

There is no functional change, just replacing regmap_read()/modify/ regmap_write() with regmap_update_bits() function calls. Signed-off-by: Sylwester Nawrocki --- drivers/phy/samsung/phy-exynos-mipi-video.c | 34 - 1 file changed, 14 insertions(+), 20 deletions

Re: [PATCH v2] ASoC: samsung: Mark unused Odroid compatibles as deprecated

On 03/20/2018 08:11 AM, Krzysztof Kozlowski wrote: > On Mon, Mar 19, 2018 at 4:14 PM, Sylwester Nawrocki > <s.nawro...@samsung.com> wrote: >> On 03/19/2018 11:56 AM, Krzysztof Kozlowski wrote: >>> On Mon, Mar 19, 2018 at 11:29 AM, Sylwester Nawrocki >>> <s.

Re: [PATCH v2] ASoC: samsung: Mark unused Odroid compatibles as deprecated

On 03/20/2018 08:11 AM, Krzysztof Kozlowski wrote: > On Mon, Mar 19, 2018 at 4:14 PM, Sylwester Nawrocki > wrote: >> On 03/19/2018 11:56 AM, Krzysztof Kozlowski wrote: >>> On Mon, Mar 19, 2018 at 11:29 AM, Sylwester Nawrocki >>> wrote: >>>> On 03/1

Re: [PATCH v2] ASoC: samsung: Mark unused Odroid compatibles as deprecated

On 03/18/2018 04:35 PM, Krzysztof Kozlowski wrote: > diff --git a/Documentation/devicetree/bindings/sound/samsung,odroid.txt > b/Documentation/devicetree/bindings/sound/samsung,odroid.txt > index f35a2694eb04..e9da2200e173 100644 > --- a/Documentation/devicetree/bindings/sound/samsung,odroid.txt

Re: [PATCH v2] ASoC: samsung: Mark unused Odroid compatibles as deprecated

On 03/18/2018 04:35 PM, Krzysztof Kozlowski wrote: > diff --git a/Documentation/devicetree/bindings/sound/samsung,odroid.txt > b/Documentation/devicetree/bindings/sound/samsung,odroid.txt > index f35a2694eb04..e9da2200e173 100644 > --- a/Documentation/devicetree/bindings/sound/samsung,odroid.txt

Re: [PATCH v2] ASoC: samsung: Mark unused Odroid compatibles as deprecated

On 03/19/2018 11:56 AM, Krzysztof Kozlowski wrote: > On Mon, Mar 19, 2018 at 11:29 AM, Sylwester Nawrocki > <s.nawro...@samsung.com> wrote: >> On 03/18/2018 04:35 PM, Krzysztof Kozlowski wrote: >>> Compatible for XU4 audio is not being used. Instead the board uses the

Re: [PATCH v2] ASoC: samsung: Mark unused Odroid compatibles as deprecated

On 03/19/2018 11:56 AM, Krzysztof Kozlowski wrote: > On Mon, Mar 19, 2018 at 11:29 AM, Sylwester Nawrocki > wrote: >> On 03/18/2018 04:35 PM, Krzysztof Kozlowski wrote: >>> Compatible for XU4 audio is not being used. Instead the board uses the >>> same compatibl

Re: [PATCH v2] ASoC: samsung: Mark unused Odroid compatibles as deprecated

On 03/18/2018 04:35 PM, Krzysztof Kozlowski wrote: > Compatible for XU4 audio is not being used. Instead the board uses the > same compatible as XU3. The devices are now just compatible so they > should use the same value. Mark "hardkernel,odroid-xu4-audio" as being > deprecated so in this

Re: [PATCH v2] ASoC: samsung: Mark unused Odroid compatibles as deprecated

On 03/18/2018 04:35 PM, Krzysztof Kozlowski wrote: > Compatible for XU4 audio is not being used. Instead the board uses the > same compatible as XU3. The devices are now just compatible so they > should use the same value. Mark "hardkernel,odroid-xu4-audio" as being > deprecated so in this

Re: [PATCH 1/4] ARM: dts: exynos5250: Add #sound-dai-cells property to hdmi device node

Hi Inki, On 03/12/2018 01:48 AM, Inki Dae wrote: > Thanks for explanation. By the way, who binds '#sound-dai-cells' property?. > This patch adds this property to hdmi device node which will be bound by > HDMI driver fo Exynos DRM but I don't see any place to bind > '#sound-dai-cells' >

Re: [PATCH 1/4] ARM: dts: exynos5250: Add #sound-dai-cells property to hdmi device node

Hi Inki, On 03/12/2018 01:48 AM, Inki Dae wrote: > Thanks for explanation. By the way, who binds '#sound-dai-cells' property?. > This patch adds this property to hdmi device node which will be bound by > HDMI driver fo Exynos DRM but I don't see any place to bind > '#sound-dai-cells' >

[PATCH v3 2/6] ARM: dts: exynos: Add audio clocks configuration for exynos5250-snow

. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since v1: - edited commit summary line. --- arch/arm/boot/dts/exynos5250-snow-common.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi b/arch/arm/bo

[PATCH v3 5/6] ARM: dts: exynos: Enable HDMI audio support on exynos5420-peach-pit

This patch adds new cpu, codec subnodes according to the updated "google,snow-audio-max98090" DT bindings and the I2S clock tree configuration so sound on the HDMI interface can also be supported. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since v1:

[PATCH v3 3/6] ARM: dts: exynos: Update of the max98095 node in exynos5250-snow.dts

-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since v1: - edited commit summary line. --- arch/arm/boot/dts/exynos5250-snow.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index 4827cb

[PATCH v3 5/6] ARM: dts: exynos: Enable HDMI audio support on exynos5420-peach-pit

This patch adds new cpu, codec subnodes according to the updated "google,snow-audio-max98090" DT bindings and the I2S clock tree configuration so sound on the HDMI interface can also be supported. Signed-off-by: Sylwester Nawrocki --- Changes since v1: - edited commit summary line.

[PATCH v3 3/6] ARM: dts: exynos: Update of the max98095 node in exynos5250-snow.dts

-off-by: Sylwester Nawrocki --- Changes since v1: - edited commit summary line. --- arch/arm/boot/dts/exynos5250-snow.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index 4827cb506fa3..16e37c337a3f 100644

[PATCH v3 2/6] ARM: dts: exynos: Add audio clocks configuration for exynos5250-snow

. Signed-off-by: Sylwester Nawrocki --- Changes since v1: - edited commit summary line. --- arch/arm/boot/dts/exynos5250-snow-common.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi b/arch/arm/boot/dts/exynos5250-snow-common.dtsi

[PATCH v3 6/6] ARM: dts: exynos: Enable HDMI audio support on exynos5800-peach-pi

This patch adds new cpu, codec subnodes according to the updated "google,snow-audio-max98091" DT bindings and the I2S clock tree configuration so sound on the HDMI interface can be also supported. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- NOTE: I couldn't test

[PATCH v3 6/6] ARM: dts: exynos: Enable HDMI audio support on exynos5800-peach-pi

This patch adds new cpu, codec subnodes according to the updated "google,snow-audio-max98091" DT bindings and the I2S clock tree configuration so sound on the HDMI interface can be also supported. Signed-off-by: Sylwester Nawrocki --- NOTE: I couldn't test this patch as I have no acces

[PATCH v3 4/6] ARM: dts: exynos: Enable HDMI audio on Snow Chromebook

This patch adds new cpu, codec subnodes according to the updated "google,snow-audio-max98095" DT bindings and the I2S clock tree configuration so sound on the HDMI interface can also be supported. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since v2

[PATCH v3 4/6] ARM: dts: exynos: Enable HDMI audio on Snow Chromebook

This patch adds new cpu, codec subnodes according to the updated "google,snow-audio-max98095" DT bindings and the I2S clock tree configuration so sound on the HDMI interface can also be supported. Signed-off-by: Sylwester Nawrocki --- Changes since v2: - i2s0/#clock-cells prop

[PATCH v3 1/6] ARM: dts: exynos: Add #sound-dai-cells property to hdmi node in exynos5250.dtsi

This property is required for specifying link between the HDMI IP block and the SoC's audio subsystem. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since v1: - edited commit summary line. --- arch/arm/boot/dts/exynos5250.dtsi | 1 + 1 file changed, 1 insertion(+)

[PATCH v3 1/6] ARM: dts: exynos: Add #sound-dai-cells property to hdmi node in exynos5250.dtsi

This property is required for specifying link between the HDMI IP block and the SoC's audio subsystem. Signed-off-by: Sylwester Nawrocki --- Changes since v1: - edited commit summary line. --- arch/arm/boot/dts/exynos5250.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot

Re: [PATCH v2 4/4] ARM: dts: Enable HDMI audio on Snow Chromebook

On 03/09/2018 02:01 PM, Krzysztof Kozlowski wrote: >> diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi >> b/arch/arm/boot/dts/exynos5250-snow-common.dtsi >> index bdf59dd3654b..932a00cfd716 100644 >> --- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi >> +++

Re: [PATCH v2 4/4] ARM: dts: Enable HDMI audio on Snow Chromebook

On 03/09/2018 02:01 PM, Krzysztof Kozlowski wrote: >> diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi >> b/arch/arm/boot/dts/exynos5250-snow-common.dtsi >> index bdf59dd3654b..932a00cfd716 100644 >> --- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi >> +++

Re: [PATCH 1/4] ARM: dts: exynos5250: Add #sound-dai-cells property to hdmi device node

Hi Inki, On 03/09/2018 03:40 AM, Inki Dae wrote: > 2018년 03월 08일 02:27에 Sylwester Nawrocki 이(가) 쓴 글: >> This property is required for specifying link between the HDMI IP block >> and the SoC's audio subsystem. >> >> Signed-off-by: Sylwester Nawrocki <s.nawro...@sa

Re: [PATCH 1/4] ARM: dts: exynos5250: Add #sound-dai-cells property to hdmi device node

Hi Inki, On 03/09/2018 03:40 AM, Inki Dae wrote: > 2018년 03월 08일 02:27에 Sylwester Nawrocki 이(가) 쓴 글: >> This property is required for specifying link between the HDMI IP block >> and the SoC's audio subsystem. >> >> Signed-off-by: Sylwester Nawrocki >> --- >

[PATCH] ARM: dts: Enable HDMI audio support on exynos5800-peach-pi

This patch adds new cpu, codec subnodes according to the updated "google,snow-audio-max98091" DT bindings and the I2S clock tree configuration so sound on the HDMI interface can be also supported. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- NOTE: I couldn't

[PATCH] ARM: dts: Enable HDMI audio support on exynos5800-peach-pi

This patch adds new cpu, codec subnodes according to the updated "google,snow-audio-max98091" DT bindings and the I2S clock tree configuration so sound on the HDMI interface can be also supported. Signed-off-by: Sylwester Nawrocki --- NOTE: I couldn't test this patch as I have

[PATCH] ARM: dts: Enable HDMI audio support on exynos5420-peach-pit

This patch adds new cpu, codec subnodes according to the updated "google,snow-audio-max98090" DT bindings and the I2S clock tree configuration so sound on the HDMI interface can also be supported. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- arch/arm/boot/dts/

[PATCH] ARM: dts: Enable HDMI audio support on exynos5420-peach-pit

This patch adds new cpu, codec subnodes according to the updated "google,snow-audio-max98090" DT bindings and the I2S clock tree configuration so sound on the HDMI interface can also be supported. Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos5420-peach-pi

[PATCH v2 4/4] ARM: dts: Enable HDMI audio on Snow Chromebook

This patch adds new cpu, codec subnodes according to the updated "google,snow-audio-max98095" DT bindings and the I2S clock tree configuration so sound on the HDMI interface can also be supported. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since v2:

[PATCH v2 4/4] ARM: dts: Enable HDMI audio on Snow Chromebook

This patch adds new cpu, codec subnodes according to the updated "google,snow-audio-max98095" DT bindings and the I2S clock tree configuration so sound on the HDMI interface can also be supported. Signed-off-by: Sylwester Nawrocki --- Changes since v2: - changed order of codec phandle

Re: [PATCH 4/4] ARM: dts: Enable HDMI audio on Snow Chromebook

On 03/07/2018 06:27 PM, Sylwester Nawrocki wrote: > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -18,6 +18,14 @@ > + cpu { > + sound-dai = < 0>; > + }; &

Re: [PATCH 4/4] ARM: dts: Enable HDMI audio on Snow Chromebook

On 03/07/2018 06:27 PM, Sylwester Nawrocki wrote: > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -18,6 +18,14 @@ > + cpu { > + sound-dai = < 0>; > + }; &

[PATCH 3/4] ARM: dts: exynos5250-snow MAX98095 CODEC node update

-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- arch/arm/boot/dts/exynos5250-snow.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index 4827cb506fa3..16e37c337a3f 100644 --- a/arch/arm/bo

[PATCH 3/4] ARM: dts: exynos5250-snow MAX98095 CODEC node update

-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos5250-snow.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index 4827cb506fa3..16e37c337a3f 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch

[PATCH 1/4] ARM: dts: exynos5250: Add #sound-dai-cells property to hdmi device node

This property is required for specifying link between the HDMI IP block and the SoC's audio subsystem. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- arch/arm/boot/dts/exynos5250.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi

[PATCH 1/4] ARM: dts: exynos5250: Add #sound-dai-cells property to hdmi device node

This property is required for specifying link between the HDMI IP block and the SoC's audio subsystem. Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos5250.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250

[PATCH 2/4] ARM: dts: Add audio clocks configuration for exynos5250-snow

. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- arch/arm/boot/dts/exynos5250-snow-common.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi b/arch/arm/boot/dts/exynos5250-snow-common.dtsi index 59cf1b

[PATCH 2/4] ARM: dts: Add audio clocks configuration for exynos5250-snow

. Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos5250-snow-common.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi b/arch/arm/boot/dts/exynos5250-snow-common.dtsi index 59cf1b202849..bdf59dd3654b 100644 --- a/arch/arm

[PATCH 4/4] ARM: dts: Enable HDMI audio on Snow Chromebook

This patch adds new cpu, codec subnodes according to the updated "google,snow-audio-max98095" bindings and the I2S clock tree configuration so sound on the HDMI interface can also be supported. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- arch/arm/boot/dts

[PATCH 4/4] ARM: dts: Enable HDMI audio on Snow Chromebook

This patch adds new cpu, codec subnodes according to the updated "google,snow-audio-max98095" bindings and the I2S clock tree configuration so sound on the HDMI interface can also be supported. Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos5250-snow-common.dtsi | 4

Re: [PATCH v2] clk: exynos5433: Extend list of available AUD_PLL output frequencies

On 02/12/2018 10:46 PM, Chanwoo Choi wrote: > On 2018년 02월 13일 00:52, Sylwester Nawrocki wrote: >> Add one more entry to the exynos5433_aud_pll_rates table, this allows >> to support audio sample rates: 48000, 96000, 192000 Hz with minimum >> error. The M, P, S, K values r

Re: [PATCH v2] clk: exynos5433: Extend list of available AUD_PLL output frequencies

On 02/12/2018 10:46 PM, Chanwoo Choi wrote: > On 2018년 02월 13일 00:52, Sylwester Nawrocki wrote: >> Add one more entry to the exynos5433_aud_pll_rates table, this allows >> to support audio sample rates: 48000, 96000, 192000 Hz with minimum >> error. The M, P, S, K values r

Re: [PATCH] clk: samsung: Add git tree entry to MAINTAINERS

On 02/05/2018 04:17 PM, Krzysztof Kozlowski wrote: > On Mon, Feb 5, 2018 at 3:41 PM, Sylwester Nawrocki > <s.nawro...@samsung.com> wrote: >> Add a missing git tree entry for drivers/clk/samsung. >> >> Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH] clk: samsung: Add git tree entry to MAINTAINERS

On 02/05/2018 04:17 PM, Krzysztof Kozlowski wrote: > On Mon, Feb 5, 2018 at 3:41 PM, Sylwester Nawrocki > wrote: >> Add a missing git tree entry for drivers/clk/samsung. >> >> Signed-off-by: Sylwester Nawrocki >> --- >> MAINTAINERS | 1 + >>

Re: [PATCH 3/3] clk: exynos5433: Add CLK_IGNORE_UNUSED flag to sclk_ioclk_i2s1_bclk

On 02/06/2018 05:08 AM, Chanwoo Choi wrote: > On 2018년 02월 05일 23:22, Sylwester Nawrocki wrote: >> The sclk_ioclk_i2s1_bclk clock is not currently handled by any driver >> and disabling this clock by the clk core prevents proper operation >> of the I2S1 block. CLK_IGNORE

Re: [PATCH 3/3] clk: exynos5433: Add CLK_IGNORE_UNUSED flag to sclk_ioclk_i2s1_bclk

On 02/06/2018 05:08 AM, Chanwoo Choi wrote: > On 2018년 02월 05일 23:22, Sylwester Nawrocki wrote: >> The sclk_ioclk_i2s1_bclk clock is not currently handled by any driver >> and disabling this clock by the clk core prevents proper operation >> of the I2S1 block. CLK_IGNORE

[PATCH v2 3/7] ASoC: samsung: i2s: Prevent external abort on exynos5433 I2S1 access

led by the runtime PM ops. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since v1: - removed stray whitespace change. --- sound/soc/samsung/i2s.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2

[PATCH v2 3/7] ASoC: samsung: i2s: Prevent external abort on exynos5433 I2S1 access

led by the runtime PM ops. Signed-off-by: Sylwester Nawrocki --- Changes since v1: - removed stray whitespace change. --- sound/soc/samsung/i2s.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index 5088d12faeda..7b57ad11c

[PATCH v2 4/7] ASoC: samsung: i2s: Define the parameters list for SAMSUNG_I2S_OPCLK

The SAMSUNG_I2S_OPCLK is not currently used by any card driver thus we can safely change semantics of 'dir' argument of the I2S set_sysclk() callback. Now an enumeration is exported instead of directly using register bit field values. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.

[PATCH v2 4/7] ASoC: samsung: i2s: Define the parameters list for SAMSUNG_I2S_OPCLK

The SAMSUNG_I2S_OPCLK is not currently used by any card driver thus we can safely change semantics of 'dir' argument of the I2S set_sysclk() callback. Now an enumeration is exported instead of directly using register bit field values. Signed-off-by: Sylwester Nawrocki Acked-by: Krzysztof

[PATCH v2 2/7] ASoC: samsung: i2s: Ensure names of supplied clocks are unique

, not by name. This change allows to have both I2S0 and I2S1 enabled simultaneously on exynos5433 and working properly when #clock-cells property is specified in respective DT nodes. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since v1: - added devm_kasprintf() error ha

[PATCH v2 2/7] ASoC: samsung: i2s: Ensure names of supplied clocks are unique

, not by name. This change allows to have both I2S0 and I2S1 enabled simultaneously on exynos5433 and working properly when #clock-cells property is specified in respective DT nodes. Signed-off-by: Sylwester Nawrocki --- Changes since v1: - added devm_kasprintf() error handling. --- sound/soc/samsung

[PATCH v2 1/7] ASoC: samsung: i2s: Update clock-output-names property documentation

The clock-output-names property is marked as deprecated. While at it, and few typos are fixed. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> Acked-by: Krzysztof Kozlowski <k...@kernel.org> Reviewed-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/sou

[PATCH v2 1/7] ASoC: samsung: i2s: Update clock-output-names property documentation

The clock-output-names property is marked as deprecated. While at it, and few typos are fixed. Signed-off-by: Sylwester Nawrocki Acked-by: Krzysztof Kozlowski Reviewed-by: Rob Herring --- .../devicetree/bindings/sound/samsung-i2s.txt| 20 ++-- 1 file changed, 10

[PATCH v2 6/7] ASoC: samsung: Add support for HDMI audio on TM2 board

DTBs with just a single CPU DAI specified, without the HDMI link. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since v1: - dropped the AUD PLL frequency adjustments, only 48k, 96k, 192k sample rates will be supported. --- sound/soc/samsung/tm2_wm5110.c

[PATCH v2 6/7] ASoC: samsung: Add support for HDMI audio on TM2 board

DTBs with just a single CPU DAI specified, without the HDMI link. Signed-off-by: Sylwester Nawrocki --- Changes since v1: - dropped the AUD PLL frequency adjustments, only 48k, 96k, 192k sample rates will be supported. --- sound/soc/samsung/tm2_wm5110.c | 152

[PATCH v2 7/7] ASoC: samsung: Add missing #sound-dai-cells property documentation

The #sound-dai-cells property might be helpful in selecting primary or secondary CPU DAI and it's already present in i2s nodes for some exynos SoCs so let's add it to the DT binding documentation. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since v1: - the pr

[PATCH v2 5/7] ASoC: samsung,tm2-audio DT binding documentation update

This patch documents additional entries of the audio-codec and i2s-controller properties required for the HDMI audio support. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> Reviewed-by: Rob Herring <r...@kernel.org> Acked-by: Krzysztof Kozlowski <k...@kernel.org> -

[PATCH v2 7/7] ASoC: samsung: Add missing #sound-dai-cells property documentation

The #sound-dai-cells property might be helpful in selecting primary or secondary CPU DAI and it's already present in i2s nodes for some exynos SoCs so let's add it to the DT binding documentation. Signed-off-by: Sylwester Nawrocki --- Changes since v1: - the property moved to the "Optiona

[PATCH v2 5/7] ASoC: samsung,tm2-audio DT binding documentation update

This patch documents additional entries of the audio-codec and i2s-controller properties required for the HDMI audio support. Signed-off-by: Sylwester Nawrocki Reviewed-by: Rob Herring Acked-by: Krzysztof Kozlowski --- .../devicetree/bindings/sound/samsung,tm2-audio.txt| 14

[PATCH v2 0/7] ASoC: samsung: Add HDMI sound support for tm2 board

quency might cause regressions. Sylwester Nawrocki (7): ASoC: samsung: i2s: Update clock-output-names property documentation ASoC: samsung: i2s: Ensure names of supplied clocks are unique ASoC: samsung: i2s: Prevent external abort on exynos5433 I2S1 access ASoC: samsung: i2s:

[PATCH v2 0/7] ASoC: samsung: Add HDMI sound support for tm2 board

quency might cause regressions. Sylwester Nawrocki (7): ASoC: samsung: i2s: Update clock-output-names property documentation ASoC: samsung: i2s: Ensure names of supplied clocks are unique ASoC: samsung: i2s: Prevent external abort on exynos5433 I2S1 access ASoC: samsung: i2s:

[PATCH v2] clk: exynos5433: Extend list of available AUD_PLL output frequencies

Add one more entry to the exynos5433_aud_pll_rates table, this allows to support audio sample rates: 48000, 96000, 192000 Hz with minimum error. The M, P, S, K values re confirmed by the HW team. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/clk/samsung/clk-exynos

[PATCH v2] clk: exynos5433: Extend list of available AUD_PLL output frequencies

Add one more entry to the exynos5433_aud_pll_rates table, this allows to support audio sample rates: 48000, 96000, 192000 Hz with minimum error. The M, P, S, K values re confirmed by the HW team. Signed-off-by: Sylwester Nawrocki --- drivers/clk/samsung/clk-exynos5433.c | 1 + 1 file changed, 1

Re: [PATCH 2/3] clk: exynos5433: Allow audio subsystem clock rate propagation

Hi Chanwoo, On 02/09/2018 08:36 AM, Chanwoo Choi wrote: > On 2018년 02월 08일 00:18, Sylwester Nawrocki wrote: >> On 02/06/2018 05:06 AM, Chanwoo Choi wrote: >>>> drivers/clk/samsung/clk-exynos5433.c | 22 +++--- >>>> 1 file changed, 11 insertions(+

Re: [PATCH 2/3] clk: exynos5433: Allow audio subsystem clock rate propagation

Hi Chanwoo, On 02/09/2018 08:36 AM, Chanwoo Choi wrote: > On 2018년 02월 08일 00:18, Sylwester Nawrocki wrote: >> On 02/06/2018 05:06 AM, Chanwoo Choi wrote: >>>> drivers/clk/samsung/clk-exynos5433.c | 22 +++--- >>>> 1 file changed, 11 insertions(+

Re: [PATCH 7/8] ASoC: samsung: Add missing #sound-dai-cells property documentation

On 02/06/2018 02:02 PM, Krzysztof Kozlowski wrote: > On Mon, Feb 5, 2018 at 4:44 PM, Sylwester Nawrocki > <s.nawro...@samsung.com> wrote: >> The #sound-dai-cells property might be helpful in selecting primary >> or secondary CPU DAI and it's already present in i2s nodes fo

Re: [PATCH 7/8] ASoC: samsung: Add missing #sound-dai-cells property documentation

On 02/06/2018 02:02 PM, Krzysztof Kozlowski wrote: > On Mon, Feb 5, 2018 at 4:44 PM, Sylwester Nawrocki > wrote: >> The #sound-dai-cells property might be helpful in selecting primary >> or secondary CPU DAI and it's already present in i2s nodes for some >> exynos SoCs s

Re: [PATCH 8/8] ASoC: samsung,tm2-audio DT binding documentation update

On 02/06/2018 02:05 PM, Krzysztof Kozlowski wrote: > On Mon, Feb 5, 2018 at 4:44 PM, Sylwester Nawrocki > <s.nawro...@samsung.com> wrote: >> This patch documents additional entries of the audio-codec and >> i2s-controller properties required for the HDMI audio s

Re: [PATCH 8/8] ASoC: samsung,tm2-audio DT binding documentation update

On 02/06/2018 02:05 PM, Krzysztof Kozlowski wrote: > On Mon, Feb 5, 2018 at 4:44 PM, Sylwester Nawrocki > wrote: >> This patch documents additional entries of the audio-codec and >> i2s-controller properties required for the HDMI audio support. >> >> Sig

Re: [PATCH 4/8] ASoC: samsung: i2s: Define the parameters list for SAMSUNG_I2S_OPCLK

On 02/06/2018 01:26 PM, Krzysztof Kozlowski wrote: > On Mon, Feb 5, 2018 at 4:43 PM, Sylwester Nawrocki > <s.nawro...@samsung.com> wrote: >> diff --git a/sound/soc/samsung/i2s.h b/sound/soc/samsung/i2s.h >> index 79781de2f247..a9832a9555cb 100644 >> --- a/sound/so

Re: [PATCH 4/8] ASoC: samsung: i2s: Define the parameters list for SAMSUNG_I2S_OPCLK

On 02/06/2018 01:26 PM, Krzysztof Kozlowski wrote: > On Mon, Feb 5, 2018 at 4:43 PM, Sylwester Nawrocki > wrote: >> diff --git a/sound/soc/samsung/i2s.h b/sound/soc/samsung/i2s.h >> index 79781de2f247..a9832a9555cb 100644 >> --- a/sound/soc/samsung/i2s.h >>

Re: [PATCH 2/8] ASoC: samsung: i2s: Ensure names of supplied clocks are unique

On 02/06/2018 01:20 PM, Krzysztof Kozlowski wrote: >> @@ -1214,30 +1216,35 @@ static int i2s_register_clock_provider(struct >> platform_device *pdev) >> clk_put(rclksrc); >> } >> >> + for (i = 0; i < ARRAY_SIZE(i2s_clk_desc); i++) >> + i2s_clk_name[i] =

Re: [PATCH 2/8] ASoC: samsung: i2s: Ensure names of supplied clocks are unique

On 02/06/2018 01:20 PM, Krzysztof Kozlowski wrote: >> @@ -1214,30 +1216,35 @@ static int i2s_register_clock_provider(struct >> platform_device *pdev) >> clk_put(rclksrc); >> } >> >> + for (i = 0; i < ARRAY_SIZE(i2s_clk_desc); i++) >> + i2s_clk_name[i] =

Re: [PATCH 2/3] clk: exynos5433: Allow audio subsystem clock rate propagation

Hi Chanwoo, On 02/06/2018 05:06 AM, Chanwoo Choi wrote: >> drivers/clk/samsung/clk-exynos5433.c | 22 +++--- >> 1 file changed, 11 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/clk/samsung/clk-exynos5433.c >> b/drivers/clk/samsung/clk-exynos5433.c >> index

Re: [PATCH 2/3] clk: exynos5433: Allow audio subsystem clock rate propagation

Hi Chanwoo, On 02/06/2018 05:06 AM, Chanwoo Choi wrote: >> drivers/clk/samsung/clk-exynos5433.c | 22 +++--- >> 1 file changed, 11 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/clk/samsung/clk-exynos5433.c >> b/drivers/clk/samsung/clk-exynos5433.c >> index

Re: [PATCH 1/3] clk: exynos5433: Extend list of available AUD_PLL output frequencies

On 02/07/2018 12:24 PM, Chanwoo Choi wrote: > Could you share your equation? > because your result is a little bit different of my result. > - my equation : ((mdiv + kdiv/65535) x 24MHz) / (pdiv x POWER(2,sdiv)) It resembles the code from samsung_pll36xx_recalc_rate(): (24 * 10^6 * (M * 2^16 +

Re: [PATCH 1/3] clk: exynos5433: Extend list of available AUD_PLL output frequencies

On 02/07/2018 12:24 PM, Chanwoo Choi wrote: > Could you share your equation? > because your result is a little bit different of my result. > - my equation : ((mdiv + kdiv/65535) x 24MHz) / (pdiv x POWER(2,sdiv)) It resembles the code from samsung_pll36xx_recalc_rate(): (24 * 10^6 * (M * 2^16 +

Re: [PATCH 1/3] clk: exynos5433: Extend list of available AUD_PLL output frequencies

On 02/06/2018 03:44 AM, Chanwoo Choi wrote: > When I developed the clk-exynos5433.c I referred to the following description. > TRM specified that "Samsung recommends only the values > between 252MH ~ 400MHz in the PMS2460X PMS value" for aud_pll. Thanks, I somehow missed it. There is also another

Re: [PATCH 1/3] clk: exynos5433: Extend list of available AUD_PLL output frequencies

On 02/06/2018 03:44 AM, Chanwoo Choi wrote: > When I developed the clk-exynos5433.c I referred to the following description. > TRM specified that "Samsung recommends only the values > between 252MH ~ 400MHz in the PMS2460X PMS value" for aud_pll. Thanks, I somehow missed it. There is also another

[PATCH] ASoC: samsung: Add the DT binding files entry to MAINTAINERS

This patch adds missing DT binding files to the Samsung ASoC drivers entry. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5046003ea162..da2df3194d72 100644 --- a/MAINTAINERS

[PATCH] ASoC: samsung: Add the DT binding files entry to MAINTAINERS

This patch adds missing DT binding files to the Samsung ASoC drivers entry. Signed-off-by: Sylwester Nawrocki --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5046003ea162..da2df3194d72 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11921,6

<    1   2   3   4   5   6   7   8   9   10   >