; CAPI). And many thanks to Hansjoerg Lipp and Tilman Schmidt for writing and
> upstreaming this driver.
>
> Signed-off-by: Paul Bolle
> ---
> MAINTAINERS | 7 ---
> 1 file changed, 7 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 783569e3c4b4..e99a
another place, Paul already did show you the place.
>
> To which source code place do you refer here?
Obviously the one Paul pointed out to you in detail in his mail dated
Mon, 26 Sep 2016 23:13:54 +0200.
HTH,
Tilman
--
Tilman Schmidt
til...@imap.cc
another place, Paul already did show you the place.
>
> To which source code place do you refer here?
Obviously the one Paul pointed out to you in detail in his mail dated
Mon, 26 Sep 2016 23:13:54 +0200.
HTH,
Tilman
--
Tilman Schmidt
til...@imap.cc
ly reclaimed
> after it would return a null pointer?
No. Should I? Do you?
Regards,
Tilman
--
Tilman Schmidt
til...@imap.cc
ly reclaimed
> after it would return a null pointer?
No. Should I? Do you?
Regards,
Tilman
--
Tilman Schmidt
til...@imap.cc
tion.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
>
> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
The patch is fine but the link in the commit message is irrelevant.
Please remove it.
(Yes, I read through the whole presentation to verify that. It
CJ16-Refactor_Strings-WSang_0.pdf
>
> Signed-off-by: Markus Elfring
The patch is fine but the link in the commit message is irrelevant.
Please remove it.
(Yes, I read through the whole presentation to verify that. It was fun,
even.)
--
Tilman Schmidt
til...@imap.cc
dary importance,
and if you want to do that, as a minimum you have to make sure that you
don't introduce new bugs.
Thanks,
Tilman
--
Tilman Schmidt
til...@imap.cc
dary importance,
and if you want to do that, as a minimum you have to make sure that you
don't introduce new bugs.
Thanks,
Tilman
--
Tilman Schmidt
til...@imap.cc
e has
> ISDN support which is actively used.
AFAIK none of these uses I4L anymore. Asterisk dropped I4L support with
version 2 if my memory is correct and nowadays uses CAPI, mISDN or its
own DAHDI interface.
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
e has
> ISDN support which is actively used.
AFAIK none of these uses I4L anymore. Asterisk dropped I4L support with
version 2 if my memory is correct and nowadays uses CAPI, mISDN or its
own DAHDI interface.
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
over-TCP service
- last but not least, via the mISDNcapid daemon and mISDN
Of course this cuts off anything that doesn't pass through libcapi20.so,
including applications that (against the standard) access /dev/capi20
directly but also the capidrv.ko i4l compatibility shim.
--
Tilman Schmidt
over-TCP service
- last but not least, via the mISDNcapid daemon and mISDN
Of course this cuts off anything that doesn't pass through libcapi20.so,
including applications that (against the standard) access /dev/capi20
directly but also the capidrv.ko i4l compatibility shim.
--
Tilman Schmidt
Am 07.03.2016 um 09:48 schrieb Paul Bolle:
> On za, 2016-03-05 at 14:08 +0100, Tilman Schmidt wrote:
>> As a consequence, owners of HiSAX type adapters are in fact stuck with
>> the old hisax driver if they want to continue using i4l userspace
>> tools.
>
> Do you know
Am 07.03.2016 um 09:48 schrieb Paul Bolle:
> On za, 2016-03-05 at 14:08 +0100, Tilman Schmidt wrote:
>> As a consequence, owners of HiSAX type adapters are in fact stuck with
>> the old hisax driver if they want to continue using i4l userspace
>> tools.
>
> Do you know
ault ISDN_I4L
help
This option provides the glue code to hook up CAPI driven cards to
the legacy isdn4linux link layer. If you have a card which is
Jm2c,
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.
signature.asc
Description: OpenPGP digital signature
ault ISDN_I4L
help
This option provides the glue code to hook up CAPI driven cards to
the legacy isdn4linux link layer. If you have a card which is
Jm2c,
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.
signature.asc
Description: OpenPGP digital signature
.com>
> Tested-by: Dmitry Vyukov <dvyu...@google.com>
> Signed-off-by: Paul Bolle <pebo...@tiscali.nl>
Acked-by: Tilman Schmidt <til...@imap.cc>
Thanks for cleaning up the mess I left behind.
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.
signature.asc
Description: OpenPGP digital signature
ice_release() to get to our struct cardstate. Which has the
> net effect of leaking a struct ser_cardstate at every call of this
> driver's tty close() operation. So using container_of() has the
> additional benefit of actually working.
>
> Reported-by: Dmitry Vyukov
> Tested-by: Dmit
o have
> a NULL tiocmset method. That in itself is probably a mistake given modern
> coding practices - but needs fixing in the tty layer.
>
> Signed-off-by: Alan Cox
Acked-by: Tilman Schmidt
(Overlooking the nettling subject line.)
> ---
> drivers/isdn/gigaset/ser-gigaset.c |
fine
> with that.)
I think as a maintainer you are supposed to sign off patches for the
code you maintain. My signed-off as recently retired ex-maintainer was
probably still good enough in July. I'm unsure whether it still is today.
Regards,
Tilman
--
Tilman Schmidt
return;
>>>> + dev_set_drvdata(dev, NULL);
>
> This is of marginal value and (I think) unnecessary; it implies
> the core will use the device after release, which would trigger
> many problems if true.
Agreed, but I'm just moving existing code here. Dropping the
dev_set_drvdata() call would be an unrelated change which should be done
in a separate patch if I understand the rules correctly.
Regards,
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.
signature.asc
Description: OpenPGP digital signature
return;
>>>> + dev_set_drvdata(dev, NULL);
>
> This is of marginal value and (I think) unnecessary; it implies
> the core will use the device after release, which would trigger
> many problems if true.
Agreed, but I'm just moving existing code here. Dropping the
dev_set_drvdata() call would be an unrelated change which should be done
in a separate patch if I understand the rules correctly.
Regards,
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.
signature.asc
Description: OpenPGP digital signature
ned-off by me, I'm perfectly fine
> with that.)
I think as a maintainer you are supposed to sign off patches for the
code you maintain. My signed-off as recently retired ex-maintainer was
probably still good enough in July. I'm unsure whether it still is today.
Regards,
Tilman
--
Tilman Schmidt
o have
> a NULL tiocmset method. That in itself is probably a mistake given modern
> coding practices - but needs fixing in the tty layer.
>
> Signed-off-by: Alan Cox <a...@linux.intel.com>
Acked-by: Tilman Schmidt <til...@imap.cc>
(Overlooking the nettling subject line.)
>
's still an opportunity to have
> another look at that code.)
I'm a big fan of one change per patch. If we also want to modify the
moved code then that should be done in a separate patch. It makes
bisecting so much easier. Same reason why I separated out patch 3/3. And
btw same reason why I thin
Am 08.12.2015 um 23:16 schrieb One Thousand Gnomes:
> The right fix as far as I can see is to remove the tests although
> WARN_ON() combined with your tty->ops change might be safer.
Feel free to submit a patch.
>> It's pretty obvious that this should have been part of commit
>> f34d7a5b7010
Am 08.12.2015 um 23:16 schrieb One Thousand Gnomes:
> The right fix as far as I can see is to remove the tests although
> WARN_ON() combined with your tty->ops change might be safer.
Feel free to submit a patch.
>> It's pretty obvious that this should have been part of commit
>> f34d7a5b7010
's still an opportunity to have
> another look at that code.)
I'm a big fan of one change per patch. If we also want to modify the
moved code then that should be done in a separate patch. It makes
bisecting so much easier. Same reason why I separated out patch 3/3. And
btw same reason why I thin
device->platform_data and platform_device->resource are never used
and remain NULL through their entire life. Drops the kfree() calls
for them from the device release method.
Signed-off-by: Tilman Schmidt
Reported-by: Paul Bolle
---
drivers/isdn/gigaset/ser-gigaset.c | 5 -
1 file c
Commit f34d7a5b changed tty->driver to tty->ops but left NULL checks
for tty->driver untouched. Fix.
Signed-off-by: Tilman Schmidt
Fixes: f34d7a5b7010 ("tty: The big operations rework")
---
drivers/isdn/gigaset/ser-gigaset.c | 6 +++---
1 file changed, 3 insertions(+), 3
When shutting down the device, the struct ser_cardstate must not be
kfree()d immediately after the call to platform_device_unregister()
since the embedded struct platform_device is still in use.
Move the kfree() call to the release method instead.
Signed-off-by: Tilman Schmidt
Fixes
en through the cracks in my last series.
Patch 2/3 should go into stable releases all the way back to 2.6.32.
It applies cleanly to release 3.*/4.* with at most offset 1.
For release 2.6.32 there is a trivial merge conflict with a removed
comment line.
Thanks,
Tilman
Tilman Schmidt (3):
ser_gi
en through the cracks in my last series.
Patch 2/3 should go into stable releases all the way back to 2.6.32.
It applies cleanly to release 3.*/4.* with at most offset 1.
For release 2.6.32 there is a trivial merge conflict with a removed
comment line.
Thanks,
Tilman
Tilman Schmidt (3):
ser_gi
device->platform_data and platform_device->resource are never used
and remain NULL through their entire life. Drops the kfree() calls
for them from the device release method.
Signed-off-by: Tilman Schmidt <til...@imap.cc>
Reported-by: Paul Bolle <pebo...@tiscali.nl>
---
driver
Commit f34d7a5b changed tty->driver to tty->ops but left NULL checks
for tty->driver untouched. Fix.
Signed-off-by: Tilman Schmidt <til...@imap.cc>
Fixes: f34d7a5b7010 ("tty: The big operations rework")
---
drivers/isdn/gigaset/ser-gigaset.c | 6 +++---
1 file ch
When shutting down the device, the struct ser_cardstate must not be
kfree()d immediately after the call to platform_device_unregister()
since the embedded struct platform_device is still in use.
Move the kfree() call to the release method instead.
Signed-off-by: Tilman Schmidt <til...@imap
s for mine.
> In the mean time you might want to turn your patch into something that
> can actually be applied (with or without my Sign-off or Ack; I don't
> care how it finds its way into the tree). Please add add
> Fixes: 2869b23e4b95 ("[PATCH] drivers/isdn/gigaset: new M101 dr
Am 06.12.2015 um 21:12 schrieb Paul Bolle:
> On zo, 2015-12-06 at 16:29 +0100, Tilman Schmidt wrote:
>> So the solution might be as simple as moving the kfree() call from
>> gigaset_freecshw() to gigaset_device_release(). Something like this:
>>
>> --- a/drivers/isdn/gig
Am 06.12.2015 um 21:12 schrieb Paul Bolle:
> On zo, 2015-12-06 at 16:29 +0100, Tilman Schmidt wrote:
>> So the solution might be as simple as moving the kfree() call from
>> gigaset_freecshw() to gigaset_device_release(). Something like this:
>>
>> --- a/drivers/isdn/gig
s for mine.
> In the mean time you might want to turn your patch into something that
> can actually be applied (with or without my Sign-off or Ack; I don't
> care how it finds its way into the tree). Please add add
> Fixes: 2869b23e4b95 ("[PATCH] drivers/isdn/gigaset: new M101 dr
latform_device_unregister(>hw.ser->dev);
- kfree(cs->hw.ser);
- cs->hw.ser = NULL;
}
static void gigaset_device_release(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
+ struct cardstate *cs = dev_get_drvdata(dev);
- /* adapte
latform_device_unregister(>hw.ser->dev);
- kfree(cs->hw.ser);
- cs->hw.ser = NULL;
}
static void gigaset_device_release(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
+ struct cardstate *cs = dev_get_drvdata(dev);
- /* adapte
lue, but it has never been anything
but 1 in the entire in-tree history of the driver.)
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.
signature.asc
Description: OpenPGP digital signature
lue, but it has never been anything
but 1 in the entire in-tree history of the driver.)
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.
signature.asc
Description: OpenPGP digital signature
'ed and) free'd.
I wonder how that will behave if someone attaches two of the devices to
different serial ports. Not likely, but not forbidden either.
Regards,
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger
'ed and) free'd.
I wonder how that will behave if someone attaches two of the devices to
different serial ports. Not likely, but not forbidden either.
Regards,
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger
t.
[...]
> The platform_device embedded in struct ser_cardstate hasn't been released when
> you kfree() the memory it's in.
Btw I don't see a timer_list object in struct platform_device either.
Nor in the embedded struct device.
--
Tilman Schmidt E-Mail: til
Am 29.11.2015 um 19:22 schrieb Peter Hurley:
> On 11/29/2015 10:30 AM, Tilman Schmidt wrote:
>>
>> Judging from the backtrace below this must be the call
>>
>> kfree(cs->hw.ser);
>>
>> in drivers/isdn/gigaset/ser-gigaset.c line 375.
>
freecshw+0xe1/0x120
There are functions by this name in all three Gigaset hardware dependent
modules (bas_gigaset, ser_gigaset and usb_gigaset), but ...
> [ 413.562723] [] gigaset_freecs+0x2ad/0x600
> [ 413.564240] [] gigaset_tty_close+0x210/0x280
this function only exists in ser_gigaset.
t.
[...]
> The platform_device embedded in struct ser_cardstate hasn't been released when
> you kfree() the memory it's in.
Btw I don't see a timer_list object in struct platform_device either.
Nor in the embedded struct device.
--
Tilman Schmidt E-Mail: til
Am 29.11.2015 um 19:22 schrieb Peter Hurley:
> On 11/29/2015 10:30 AM, Tilman Schmidt wrote:
>>
>> Judging from the backtrace below this must be the call
>>
>> kfree(cs->hw.ser);
>>
>> in drivers/isdn/gigaset/ser-gigaset.c line 375.
>
freecshw+0xe1/0x120
There are functions by this name in all three Gigaset hardware dependent
modules (bas_gigaset, ser_gigaset and usb_gigaset), but ...
> [ 413.562723] [] gigaset_freecs+0x2ad/0x600
> [ 413.564240] [] gigaset_tty_close+0x210/0x280
this function only exists in ser_gigaset.
Hi Paul,
Am 19.10.2015 um 11:09 schrieb Paul Bolle:
> On ma, 2015-10-12 at 11:18 +0200, Tilman Schmidt wrote:
>> While it doesn't make any sense indeed to run two instances of
>> ldattach
>> in parallel on one and the same serial port, it is entirely conceivable
>&g
Hi Paul,
Am 19.10.2015 um 11:09 schrieb Paul Bolle:
> On ma, 2015-10-12 at 11:18 +0200, Tilman Schmidt wrote:
>> While it doesn't make any sense indeed to run two instances of
>> ldattach
>> in parallel on one and the same serial port, it is entirely conceivable
>&g
Paul,
Am 06.10.2015 um 23:00 schrieb Paul Bolle:
> On ma, 2015-09-21 at 18:07 +0200, Tilman Schmidt wrote:
>> Am 21.09.2015 um 15:13 schrieb Peter Hurley:
>>> ???
>>>
>>> The tool you authored will do it from the command line
>>>
>>> $ ld
Paul,
Am 06.10.2015 um 23:00 schrieb Paul Bolle:
> On ma, 2015-09-21 at 18:07 +0200, Tilman Schmidt wrote:
>> Am 21.09.2015 um 15:13 schrieb Peter Hurley:
>>> ???
>>>
>>> The tool you authored will do it from the command line
>>>
>>> $ ld
Mention that the ldisc open method must set tty->receive_room, and
that many methods are optional. Add description of receive_buf2 method.
Signed-off-by: Tilman Schmidt
---
Documentation/serial/tty.txt | 60
1 file changed, 39 insertions(+),
Mention that the ldisc open method must set tty->receive_room, and
that many methods are optional. Add description of receive_buf2 method.
Signed-off-by: Tilman Schmidt <til...@imap.cc>
---
Documentation/serial/tty.txt | 60
1 file ch
Am 21.09.2015 um 18:54 schrieb Peter Hurley:
> On 09/21/2015 09:38 AM, Tilman Schmidt wrote:
>> Am 21.09.2015 um 15:13 schrieb Peter Hurley:
>>> On 09/18/2015 08:38 AM, Tilman Schmidt wrote:
>>>> Am 17.09.2015 um 20:13 schrieb Peter Hurley:
>>>>> On
Am 21.09.2015 um 15:13 schrieb Peter Hurley:
> On 09/18/2015 08:38 AM, Tilman Schmidt wrote:
>> Am 17.09.2015 um 20:13 schrieb Peter Hurley:
[...]
>>> So for example, if you manually set N_PPP (as if by user error)
>>
>> User error wouldn't suffice, as the LD
Am 21.09.2015 um 15:13 schrieb Peter Hurley:
> On 09/18/2015 08:38 AM, Tilman Schmidt wrote:
>> Am 17.09.2015 um 20:13 schrieb Peter Hurley:
>>> On Wed, Sep 16, 2015 at 7:26 AM, Tilman Schmidt wrote:
[...]
>>>> - The requirement for line disciplines to set receive_r
Am 21.09.2015 um 15:13 schrieb Peter Hurley:
> On 09/18/2015 08:38 AM, Tilman Schmidt wrote:
>> Am 17.09.2015 um 20:13 schrieb Peter Hurley:
>>> On Wed, Sep 16, 2015 at 7:26 AM, Tilman Schmidt <til...@imap.cc> wrote:
[...]
>>>> - The requirement for line di
Am 21.09.2015 um 15:13 schrieb Peter Hurley:
> On 09/18/2015 08:38 AM, Tilman Schmidt wrote:
>> Am 17.09.2015 um 20:13 schrieb Peter Hurley:
[...]
>>> So for example, if you manually set N_PPP (as if by user error)
>>
>> User error wouldn't suffice, as the LD
Am 21.09.2015 um 18:54 schrieb Peter Hurley:
> On 09/21/2015 09:38 AM, Tilman Schmidt wrote:
>> Am 21.09.2015 um 15:13 schrieb Peter Hurley:
>>> On 09/18/2015 08:38 AM, Tilman Schmidt wrote:
>>>> Am 17.09.2015 um 20:13 schrieb Peter Hurley:
>>>>> On
Am 17.09.2015 um 20:13 schrieb Peter Hurley:
> On Wed, Sep 16, 2015 at 7:26 AM, Tilman Schmidt wrote:
>> Am 16.09.2015 um 03:18 schrieb Peter Hurley:
>>> On Tue, Sep 15, 2015 at 8:37 PM, Tilman Schmidt wrote:
>>>> Am 16.09.2015 um 01:08 schrieb Peter Hurley:
>&
Am 17.09.2015 um 20:13 schrieb Peter Hurley:
> On Wed, Sep 16, 2015 at 7:26 AM, Tilman Schmidt <til...@imap.cc> wrote:
>> Am 16.09.2015 um 03:18 schrieb Peter Hurley:
>>> On Tue, Sep 15, 2015 at 8:37 PM, Tilman Schmidt <til...@imap.cc> wrote:
>>>> A
Am 16.09.2015 um 03:18 schrieb Peter Hurley:
> On Tue, Sep 15, 2015 at 8:37 PM, Tilman Schmidt wrote:
>> Am 16.09.2015 um 01:08 schrieb Peter Hurley:
>>> On Tue, Sep 15, 2015 at 10:22 AM, Jiri Slaby wrote:
>>>
>>> From: Tilman Schmidt
>>>
>>
Am 16.09.2015 um 03:18 schrieb Peter Hurley:
> On Tue, Sep 15, 2015 at 8:37 PM, Tilman Schmidt <til...@imap.cc> wrote:
>> Am 16.09.2015 um 01:08 schrieb Peter Hurley:
>>> On Tue, Sep 15, 2015 at 10:22 AM, Jiri Slaby <jsl...@suse.cz> wrote:
>>>
>&
Am 16.09.2015 um 01:08 schrieb Peter Hurley:
> On Tue, Sep 15, 2015 at 10:22 AM, Jiri Slaby <mailto:jsl...@suse.cz>> wrote:
>
> From: Tilman Schmidt
>
> 3.12-stable review patch. If anyone has any objections, please let
> me know.
>
> ==
Am 16.09.2015 um 01:08 schrieb Peter Hurley:
> On Tue, Sep 15, 2015 at 10:22 AM, Jiri Slaby <jsl...@suse.cz
> <mailto:jsl...@suse.cz>> wrote:
>
> From: Tilman Schmidt <til...@imap.cc>
>
> 3.12-stable review patch. If anyone has any
Am 14.07.2015 um 01:14 schrieb Peter Hurley:
> On 07/13/2015 06:37 PM, Tilman Schmidt wrote:
>> Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"),
>> first merged in kernel release 3.10, caused the following regression
>> in the Gigaset M101 d
The line discipline read and write methods are optional so the dummy
methods in ser_gigaset are unnecessary and can be removed.
Signed-off-by: Tilman Schmidt
---
drivers/isdn/gigaset/ser-gigaset.c | 24
1 files changed, 0 insertions(+), 24 deletions(-)
diff --git
This series fixes a serious regression in the Gigaset M101 driver
introduced in kernel release 3.10 and removes some unneeded code.
Please also queue up patch 1 of the series for inclusion in the
stable/longterm releases 3.10 and later.
Tilman Schmidt (2):
isdn/gigaset: reset tty->receive_r
the ldisc open method.
Fixes: 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc")
Signed-off-by: Tilman Schmidt
---
drivers/isdn/gigaset/ser-gigaset.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/gigaset/ser-gigaset.c
b/driv
Mention that the ldisc open method must reset tty->receive_room, and
that many methods are optional. Add description of receive_buf2 method.
Signed-off-by: Tilman Schmidt
---
Documentation/serial/tty.txt | 59 +++---
1 files changed, 38 insertions(+),
Am 14.07.2015 um 01:14 schrieb Peter Hurley:
On 07/13/2015 06:37 PM, Tilman Schmidt wrote:
Commit 79901317ce80 (n_tty: Don't flush buffer when closing ldisc),
first merged in kernel release 3.10, caused the following regression
in the Gigaset M101 driver:
Before that commit, when closing
Mention that the ldisc open method must reset tty-receive_room, and
that many methods are optional. Add description of receive_buf2 method.
Signed-off-by: Tilman Schmidt til...@imap.cc
---
Documentation/serial/tty.txt | 59 +++---
1 files changed, 38
This series fixes a serious regression in the Gigaset M101 driver
introduced in kernel release 3.10 and removes some unneeded code.
Please also queue up patch 1 of the series for inclusion in the
stable/longterm releases 3.10 and later.
Tilman Schmidt (2):
isdn/gigaset: reset tty-receive_room
The line discipline read and write methods are optional so the dummy
methods in ser_gigaset are unnecessary and can be removed.
Signed-off-by: Tilman Schmidt til...@imap.cc
---
drivers/isdn/gigaset/ser-gigaset.c | 24
1 files changed, 0 insertions(+), 24 deletions
method.
Fixes: 79901317ce80 (n_tty: Don't flush buffer when closing ldisc)
Signed-off-by: Tilman Schmidt til...@imap.cc
---
drivers/isdn/gigaset/ser-gigaset.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/gigaset/ser-gigaset.c
b/drivers/isdn
didate for porting to the kernel
CAPI interface, had anyone bothered. Which reinforces the impression
that no-one is using this anymore.
Note also that the FTP URL mentioned in Documentation/isdn/README.pcbit
doesn't exist anymore.
--
Tilman Schmidt E-Mail: til...@imap.c
for porting to the kernel
CAPI interface, had anyone bothered. Which reinforces the impression
that no-one is using this anymore.
Note also that the FTP URL mentioned in Documentation/isdn/README.pcbit
doesn't exist anymore.
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn
As German phone operators are discontinuing ISDN service, neither
Hansjörg nor I will be able to maintain the Gigaset ISDN drivers
any longer. Paul Bolle offered to step into the breach for odd
fixes.
Signed-off-by: Tilman Schmidt
Acked-by: Paul Bolle
---
MAINTAINERS | 5 ++---
1 file changed
As German phone operators are discontinuing ISDN service, neither
Hansjörg nor I will be able to maintain the Gigaset ISDN drivers
any longer. Paul Bolle offered to step into the breach for odd
fixes.
Signed-off-by: Tilman Schmidt til...@imap.cc
Acked-by: Paul Bolle pebo...@tiscali.nl
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 09.02.2015 um 11:07 schrieb Bas Peters:
> 2015-02-09 0:59 GMT+01:00 Karsten Keil :
>> Am 08.02.2015 um 20:47 schrieb Tilman Schmidt:
>>> Am 07.02.2015 um 21:43 schrieb Paul Bolle:
>>>> [M]aybe we should consider,
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 09.02.2015 um 11:07 schrieb Bas Peters:
2015-02-09 0:59 GMT+01:00 Karsten Keil kk...@linux-pingi.de:
Am 08.02.2015 um 20:47 schrieb Tilman Schmidt:
Am 07.02.2015 um 21:43 schrieb Paul Bolle:
[M]aybe we should consider, say, removing i4l
s that
are not
- - supported by the new CAPI subsystem yet.
- -
source "drivers/isdn/i4l/Kconfig"
menuconfig ISDN_CAPI
and working its way from that to remove anything that's become
unreachable.
Shall I?
- --
Tilman Schmidt E-Mail: ti
by the new CAPI subsystem yet.
- -
source drivers/isdn/i4l/Kconfig
menuconfig ISDN_CAPI
and working its way from that to remove anything that's become
unreachable.
Shall I?
- --
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus
Am 27.01.2015 um 03:42 schrieb Guenter Roeck:
> On 01/26/2015 02:46 PM, Greg Kroah-Hartman wrote:
>> On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote:
>>> On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote:
make ARCH=i386 allyesconfig fails with
Am 27.01.2015 um 03:42 schrieb Guenter Roeck:
On 01/26/2015 02:46 PM, Greg Kroah-Hartman wrote:
On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote:
On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote:
make ARCH=i386 allyesconfig fails with
drivers/staging/built-in.o: In
but returns the already
> generated one passed to gigaset_procinfo by the structure passed
> to this function.
>
> Signed-off-by: Nicholas Krause
Acked-by: Tilman Schmidt
Thanks,
Tilman
> ---
> drivers/isdn/gigaset/capi.c | 6 +++---
> 1 file changed, 3 insertions(+),
generated one passed to gigaset_procinfo by the structure passed
to this function.
Signed-off-by: Nicholas Krause xerofo...@gmail.com
Acked-by: Tilman Schmidt til...@imap.cc
Thanks,
Tilman
---
drivers/isdn/gigaset/capi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
ong int *value;
> + int result;
>
> - value = simple_strtol(buf, , 0);
> - while (*end)
> - if (!isspace(*end++))
> - return -EINVAL;
> + result = kstrtol(buf, 0, );
> + if (result == -ERANGE)
> + /* Ov
semantics. Your code will not accept the same input as
the original code, and it will emit messages of its own instead of
just returning an error code to the caller as it should.
In sum: NACK.
Regards,
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
elf to
do so eventually but obviously didn't succeed. :-)
So let's leave it for now.
Thanks,
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe
eventually but obviously didn't succeed. :-)
So let's leave it for now.
Thanks,
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite
api.c @@
> -182,7 +182,6 @@ static void decode_ie(u8 *in, char *out) { int i =
> *in; while (i-- > 0) { - /* ToDo: conversion to upper case
> necessary? */ *out++ = toupper(hex_asc_hi(*++in)); *out++ =
> toupper(hex_asc_lo(*in)); }
>
- --
Tilman Schmidt
rs/isdn/gigaset/usb-gigaset.c +++
> b/drivers/isdn/gigaset/usb-gigaset.c
> default: rate = 9600; - dev_err(cs->dev, "unsupported baudrate
> request 0x%x," - " using default of B9600\n", cflag); +
> dev_err(cs->dev, &q
,\ +
using
default of B9600\n, cflag);
This makes the message much less readable by inserting a long stretch
of whitespace after the comma.
In sum: NACK.
Regards,
Tilman
- --
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus
1 - 100 of 583 matches
Mail list logo
